From patchwork Wed Jul 12 11:52:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 13310250 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCE58EB64D9 for ; Wed, 12 Jul 2023 11:55:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233311AbjGLLzM (ORCPT ); Wed, 12 Jul 2023 07:55:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43082 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233338AbjGLLyu (ORCPT ); Wed, 12 Jul 2023 07:54:50 -0400 Received: from mail-ot1-x332.google.com (mail-ot1-x332.google.com [IPv6:2607:f8b0:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0716926B0; Wed, 12 Jul 2023 04:53:59 -0700 (PDT) Received: by mail-ot1-x332.google.com with SMTP id 46e09a7af769-6b923910dd4so405642a34.1; Wed, 12 Jul 2023 04:53:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689162789; x=1689767589; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Lk2CkawsWRPhUJhT7owy+MSUDnvJYEHIC5w9ORyYobQ=; b=Km9zYC/U6UXcasyyGW1McNOjTg4581w63rMh1WmLdV8hhNk70SF+VsTtw72+4GSVhi tjj3rxoSkaVcbqvPfr87FIikooOFnixJtOxSXNKKvMPqzicEA5Fg3goHUPjbzq7jQ6A3 yiaglOgdeLY99baAsNfsZMAc6cYhwhou8dukfGVwSeChImq+gC1DTIB9k7JIO6SLdRsU 7tcnD+MFbdcZjiHDogLqxH942DciGVQBc6kz/TQPOpZ3Uy0UhwPgdqAotlqYarj5fMxu wSN0IsL5L/8X3RBwHIrxWo1x9hpFZbHEYqiuX0yMfFrDML+unOnMaa3HSekYxu24dPFc /R1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689162789; x=1689767589; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Lk2CkawsWRPhUJhT7owy+MSUDnvJYEHIC5w9ORyYobQ=; b=BxyhJGDYEvKBQ8FVIzcPiGUEkrT+LmvsUJC1c2CJxQBeqVAipnX5BE6aH/JuObtYQD vo6pXxbyF7nVi2owY4U3JxgMyuYdf0KXYc3WUI7Ht0BgS5mzEsRGSFb/9SAD/h67DxqG wDFTzh2crGqETGOjAegz2IvDU7yA8MNSGfNDX0oCoZNo9OUiL8NW0VglOq3ETsIZQtOC V/6k9L8wU8grornepYzb0QbyRHdNQfwqCh10dwuvmbsUjrZT0lhMAeimWam7KtfrDQAl 2TdpFetk8drdxGCt48sxttFQxOTjUyrRrQT8Ff+DLZAx/KFwLG1I67/fxyX1/Qm/hDu6 bPKA== X-Gm-Message-State: ABy/qLZ4cr1JUMOX6BoNXMj44tgqNerF4QELM4UIoVNDXwo/9HqG11jl R+FeHLb/+4b0/ja6mrMGt60= X-Google-Smtp-Source: APBJJlHEla6YNT5iMgxmsaeujd1HxpkpIWcPh/o2YYUbBsJqgGJgv5+E7pT2BZwaZYV6WiMOr2m5fw== X-Received: by 2002:a05:6870:230d:b0:1b0:6500:8045 with SMTP id w13-20020a056870230d00b001b065008045mr13859449oao.1.1689162789293; Wed, 12 Jul 2023 04:53:09 -0700 (PDT) Received: from fabio-Precision-3551.. ([2804:14c:485:4b61:ce5f:dbc6:1eb6:2900]) by smtp.gmail.com with ESMTPSA id zh27-20020a0568716b9b00b001a663e49523sm1905890oab.36.2023.07.12.04.53.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jul 2023 04:53:08 -0700 (PDT) From: Fabio Estevam To: shawnguo@kernel.org Cc: hs@denx.de, linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, abelvesa@kernel.org, linux-clk@vger.kernel.org, Fabio Estevam , stable@vger.kernel.org Subject: [PATCH v3 1/3] ARM: dts: imx6sx: Remove LDB endpoint Date: Wed, 12 Jul 2023 08:52:59 -0300 Message-Id: <20230712115301.690714-1-festevam@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org From: Fabio Estevam Remove the LDB endpoint description from the common imx6sx.dtsi as it causes regression for boards that has the LCDIF connected directly to a parallel display. Let the LDB endpoint be described in the board devicetree file instead. Cc: stable@vger.kernel.org Fixes: b74edf626c4f ("ARM: dts: imx6sx: Add LDB support") Signed-off-by: Fabio Estevam --- Changes since v2: - Rebased against 6.5-rc1. arch/arm/boot/dts/nxp/imx/imx6sx.dtsi | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi index 3a4308666552..41c900929758 100644 --- a/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi +++ b/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi @@ -863,7 +863,6 @@ port@0 { reg = <0>; ldb_from_lcdif1: endpoint { - remote-endpoint = <&lcdif1_to_ldb>; }; }; @@ -1309,11 +1308,8 @@ lcdif1: lcdif@2220000 { power-domains = <&pd_disp>; status = "disabled"; - ports { - port { - lcdif1_to_ldb: endpoint { - remote-endpoint = <&ldb_from_lcdif1>; - }; + port { + lcdif1_to_ldb: endpoint { }; }; }; From patchwork Wed Jul 12 11:53:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 13310251 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FEF4EB64DA for ; Wed, 12 Jul 2023 11:55:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233338AbjGLLzN (ORCPT ); Wed, 12 Jul 2023 07:55:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233342AbjGLLyv (ORCPT ); Wed, 12 Jul 2023 07:54:51 -0400 Received: from mail-oa1-x2c.google.com (mail-oa1-x2c.google.com [IPv6:2001:4860:4864:20::2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0ECF626BB for ; Wed, 12 Jul 2023 04:54:00 -0700 (PDT) Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-1b776754932so76767fac.1 for ; Wed, 12 Jul 2023 04:54:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689162792; x=1689767592; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yzbz0hc2TWNvLrywr/bdFJaS83jkhqY5GQagZ14q+5M=; b=pHYiCJNf6rQn4QA3loFIU96JV9M5tD6sn5G+/nD7kM1VLUZhRkKKjn6oZXca8/psz1 7kW8UgYyxdGTaSOkPTVanMAK+29MDUem0kNVaquJ2vUXtRK112AWANNRcm3bO22x/kJa RaPtkAKIx8KJNTm9kGlAAZ8T8FyWcsHm61uYT+/5B1+lMowQW3E1VrjUVzdWI3bHf/Hk k5bR33BqMe6N6via32+8onAzcSf5iPdOZ7Mx9+g9EobxJOfy4P87JHXbHOUNk6cEVvsl 5HNK/yRlDLx4CQNpsC244UE9AlvvhjmI5Y270td7UgPkSfquNnK5v2UPusYEcukJvmj8 Efkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689162792; x=1689767592; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yzbz0hc2TWNvLrywr/bdFJaS83jkhqY5GQagZ14q+5M=; b=L324TPZvqh51h2E4A5++DTIx/4YMlxmiQYCqrL86LuVdhRae7zBzr3g05HA1LkOHZ6 OyFqqU/wBRIT1xE4Q3KBH6dznyYxYJwi2GJjRnpwpCYQJNJ45KlVzzxg2+baiYrmUFMX HQg62UAvoyQiQyCIlUg2qUr3ujPY09hWLR8jXDPOX8BqchGy8B7UZJjoKbx6G75wFXKL AWiZIUR4F0hWKGGsKFfMryHI6E1SCAGlZNjgqz6NkkqVVC5V50pLDWZTOflCDdN3fbyk zE5PmFoTHcNhVaQXHYf4g2CBc4Y44cV9//oV12A2SEnqExfWyqoqKV/QGTJ/NRT7HEan LwtQ== X-Gm-Message-State: ABy/qLadiEHkPSjKQISaLb/aDNSKmz+g8nMQw+EgaXYcSdelfNLz70m4 BWivZYgc/bSxUesHhsBA1dE= X-Google-Smtp-Source: APBJJlEaara2sS8sPaw9c00SpEacflV6uILENpS/lJQD/UOpWlL/WSIiqyQ2lYO041Jwy22lZeFxxA== X-Received: by 2002:a05:6870:548d:b0:1b7:5f4b:c686 with SMTP id f13-20020a056870548d00b001b75f4bc686mr3464544oan.2.1689162792213; Wed, 12 Jul 2023 04:53:12 -0700 (PDT) Received: from fabio-Precision-3551.. ([2804:14c:485:4b61:ce5f:dbc6:1eb6:2900]) by smtp.gmail.com with ESMTPSA id zh27-20020a0568716b9b00b001a663e49523sm1905890oab.36.2023.07.12.04.53.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jul 2023 04:53:11 -0700 (PDT) From: Fabio Estevam To: shawnguo@kernel.org Cc: hs@denx.de, linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, abelvesa@kernel.org, linux-clk@vger.kernel.org, Fabio Estevam Subject: [PATCH v3 2/3] ARM: dts: imx6sx: Describe the default LCDIF1 parent Date: Wed, 12 Jul 2023 08:53:00 -0300 Message-Id: <20230712115301.690714-2-festevam@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230712115301.690714-1-festevam@gmail.com> References: <20230712115301.690714-1-festevam@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org From: Fabio Estevam A suitable default for the LCDIF parent is the PLL5 clock, so describe it in the device tree. The imx6sx clock driver harcodes PLL5 as the LCDIF1 parent, but in preparation for removing such hardcoding, describe the parent relationship via devicetree. There are some boards that may want to use a different parent for the LCDIF due to EMI reasons, for example. With this approch, the user can change the LCDIF parent in the board devicetree if needed. Signed-off-by: Fabio Estevam --- Changes since v2: - Rebased against 6.5-rc1. arch/arm/boot/dts/nxp/imx/imx6sx.dtsi | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi index 41c900929758..0d549e1f3ced 100644 --- a/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi +++ b/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi @@ -1305,6 +1305,10 @@ lcdif1: lcdif@2220000 { <&clks IMX6SX_CLK_LCDIF_APB>, <&clks IMX6SX_CLK_DISPLAY_AXI>; clock-names = "pix", "axi", "disp_axi"; + assigned-clocks = <&clks IMX6SX_CLK_LCDIF1_PRE_SEL>, + <&clks IMX6SX_CLK_LCDIF1_SEL>; + assigned-clock-parents = <&clks IMX6SX_CLK_PLL5_VIDEO_DIV>, + <&clks IMX6SX_CLK_LCDIF1_PODF>; power-domains = <&pd_disp>; status = "disabled"; From patchwork Wed Jul 12 11:53:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 13310252 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4E92EB64D9 for ; Wed, 12 Jul 2023 11:55:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233467AbjGLLzO (ORCPT ); Wed, 12 Jul 2023 07:55:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233391AbjGLLyw (ORCPT ); Wed, 12 Jul 2023 07:54:52 -0400 Received: from mail-oa1-x2d.google.com (mail-oa1-x2d.google.com [IPv6:2001:4860:4864:20::2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CB7C26BA for ; Wed, 12 Jul 2023 04:54:01 -0700 (PDT) Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-1b3fb484eedso1339777fac.0 for ; Wed, 12 Jul 2023 04:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689162795; x=1689767595; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LhxNJrO+C7dqS4hZc7jEcBrR+kGnCAyE3Qa2KVh3AZ4=; b=MEWsxjPVUjHs7u8eIqXBpNBo+voE7Cg2M9UnfHOFGBZAAQVty1EliINRWIm112NiPZ 0Go01D4Sj2qQQrXl0taNzVr3rMCF+ab89PYwsb6AqMaNe35yL45wjTkiK84z+TTK4qeD mu5+21i3cieKs3D6UdJSY9aC5uryHqpVnytr2MIfCPud5kKbCyfKrDQeLpHRhKR+EGMA 7TGgik7CYa8szdZoFe7EIMNPPoXrNl50Jx5Tm05CiJxUC6XKKbYT+kcQ43eTU5ieUdhD BvI1BXgvYnXAfeeL7uFry3Nbfx+EwVYXPQkMrzR44vUFhLDLxEOtJWQGGmQeoPPfi9ZS 1lBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689162795; x=1689767595; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LhxNJrO+C7dqS4hZc7jEcBrR+kGnCAyE3Qa2KVh3AZ4=; b=YXou8R0yu3liyplBoNxlZ1bN06w7vQrCW5qPa10we3eEuD2D3V4oSpZPD1cWWgLs7M oocANUNfMgQIWGCWrV+q1LBDsDwt+HFAYYpAs5A3GH92EvS5K/UVjcvoPdmDytcOHi9U bItGQE0nqQezY3rv41elfi5j3DQAPZSrDhlv1M42tlKTb6lSDjcjFz9yp6bJTdT8wc8d 6nfaIgcyvCQMcF+jrHUIkhFBYpRVkCe3UGH3iVN8y0c3dh2l+JRW2mURdmexywzPq7yX rIH6jsJQJ39orn9fHR57B8QrpEjyUruCK2zVN2CrblGuexnc2fk3hORvD7Hacauy5HC9 aQWg== X-Gm-Message-State: ABy/qLZ7z+ogdXpQY/ZA4WULuy3kJDf680M8HKcrOdm65cZUtQxHYMv7 Dmv1vNuaj1Reb1FbNImbSW4= X-Google-Smtp-Source: APBJJlGJQIZJA8B4pZuHg+Po2JXZJdxDBXRVpNdstY/fkoPZ0lKrgEbZe/bsK98g7aIBDzU+s98CqA== X-Received: by 2002:a05:6870:548d:b0:1b7:5f4b:c686 with SMTP id f13-20020a056870548d00b001b75f4bc686mr3464617oan.2.1689162795154; Wed, 12 Jul 2023 04:53:15 -0700 (PDT) Received: from fabio-Precision-3551.. ([2804:14c:485:4b61:ce5f:dbc6:1eb6:2900]) by smtp.gmail.com with ESMTPSA id zh27-20020a0568716b9b00b001a663e49523sm1905890oab.36.2023.07.12.04.53.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jul 2023 04:53:14 -0700 (PDT) From: Fabio Estevam To: shawnguo@kernel.org Cc: hs@denx.de, linux-arm-kernel@lists.infradead.org, sboyd@kernel.org, abelvesa@kernel.org, linux-clk@vger.kernel.org, Fabio Estevam Subject: [PATCH v3 3/3] clk: imx: imx6sx: Remove hardcoded LCDIF1 parent Date: Wed, 12 Jul 2023 08:53:01 -0300 Message-Id: <20230712115301.690714-3-festevam@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230712115301.690714-1-festevam@gmail.com> References: <20230712115301.690714-1-festevam@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org From: Fabio Estevam It is not a good idea to hardcode the LCDIF1 parent inside the clock driver because some users may want to use a different clock parent for LCDIF1. One of the reasons could be related to EMI tests. Remove the harcoded LCDIF1 parent as this is better described via devicetree. Signed-off-by: Fabio Estevam --- Changes since v2: - Rebased against 6.5-rc1. drivers/clk/imx/clk-imx6sx.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/clk/imx/clk-imx6sx.c b/drivers/clk/imx/clk-imx6sx.c index 3f1502933e59..b110258b9036 100644 --- a/drivers/clk/imx/clk-imx6sx.c +++ b/drivers/clk/imx/clk-imx6sx.c @@ -498,10 +498,6 @@ static void __init imx6sx_clocks_init(struct device_node *ccm_node) clk_set_parent(hws[IMX6SX_CLK_EIM_SLOW_SEL]->clk, hws[IMX6SX_CLK_PLL2_PFD2]->clk); clk_set_rate(hws[IMX6SX_CLK_EIM_SLOW]->clk, 132000000); - /* set parent clock for LCDIF1 pixel clock */ - clk_set_parent(hws[IMX6SX_CLK_LCDIF1_PRE_SEL]->clk, hws[IMX6SX_CLK_PLL5_VIDEO_DIV]->clk); - clk_set_parent(hws[IMX6SX_CLK_LCDIF1_SEL]->clk, hws[IMX6SX_CLK_LCDIF1_PODF]->clk); - /* Set the parent clks of PCIe lvds1 and pcie_axi to be pcie ref, axi */ if (clk_set_parent(hws[IMX6SX_CLK_LVDS1_SEL]->clk, hws[IMX6SX_CLK_PCIE_REF_125M]->clk)) pr_err("Failed to set pcie bus parent clk.\n");