From patchwork Thu Jul 13 11:11:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= X-Patchwork-Id: 13311849 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A457AEB64DD for ; Thu, 13 Jul 2023 11:12:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=PsfURKWl6dBhqm/hwDSFaI5pT5ZLTlP9oycjrWD2Yw0=; b=Gor/lWTbGfD7RO 2viX0vxjm/SBhwaHNd1eEXP7tKCmKK1FIuLWJ7ie89bZlRSZ/13iD8Y88UsSUypE3t9ZWI4x5MJ3q I4nBd2+ckl3WydqwpxaCsfyjzHo7NS8JjPTgKwIB8ZqvtBp7b0BGIm4WWOcQcaMmKdIQTQXL573+Z Z0AgsPvp+x2feXE6bGyqZlCjNcRGtmMjivIGCrhH2ZfjShARGntsFguIDKYtA6hyZDmlCETRV4HDm D2cGSTQFyxqI3/Up4NO61Z6KK9F83DaqrMb/pRVffIlCsiQjjlDZvyKHVkwpMT3GegivzoSDwjhM9 KE3Jt+LMIdHH7D5ujLrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJuF8-0032g8-34; Thu, 13 Jul 2023 11:12:18 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJuF3-0032eK-0q for linux-arm-kernel@lists.infradead.org; Thu, 13 Jul 2023 11:12:17 +0000 Received: by mail-lf1-x12e.google.com with SMTP id 2adb3069b0e04-4fafe87c6fbso1036694e87.3 for ; Thu, 13 Jul 2023 04:12:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689246730; x=1691838730; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=7F2VqRkNnanQmzsZgDU0wjctQv+3KrqiPN+MNUqHJRc=; b=Sg2I5Mf23hj4V+3EoPmqRpAh/c1ef0z3Meo8cgXBGwW+btztGKueA/H45vOGx/tn8Z Z8TxdJLOVFKZVvLNCDm/c04zNmuqbsNGvAFWp0vEh0ZjjRRmKVYHcAmicC6FJ2HrkF2e as6sx8Lpb1PLpf5Z0jWvW5cq7s6sczgaN80fiiwdRC4EVaurZBYzh6hcMOydZUbOv32O fnCoMmKZ53HFa51ZdW9B7Qus2dPlArOeZmsxcxZFE4J+DeKK/IL5Cis3rfWY9/xtDyuL 8cdExyJkDuwKUAh7G/L6QvUkoeibTnv2deJmU3aw1lrRPibPydSJO2Bc6Tr647kHSP9L lDKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689246730; x=1691838730; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7F2VqRkNnanQmzsZgDU0wjctQv+3KrqiPN+MNUqHJRc=; b=WyqQWBSAUI3bZogdjQXXo/x57/O6ljWcwv1ALyBiDyAbqfevt9KfapWj2xq6UZ5kAb sWshgftJQ9CS2aKOtE9XI2lA94lYURpThz23vIMaR5vRZckZNMgYIIVZDutMMfQMQobd fa1T1QV28/ufUYRa1/FZ59Df+XDrJfsmJl9apsd/KfXhKgV/hXtxXADvUeBFf6GesOcl 5ckTZ+848Tz+tMJIcXAwtsipE9r/116JVlxOm/TjW/gAlcftnCM6QCyhYev3xseyfBPM CwatVu136/nU+58Og1VhkoAsVawsuztudiSTkc3884RPW5okW3yWeKNsU9/zee+4V5jm puCg== X-Gm-Message-State: ABy/qLZ/vse3pX/akiszJwZFwNgRQTDcrWAL0ipxvET3RfZ6hpGO60nP zxIyxJlEMKzzmmmhagXUuuM= X-Google-Smtp-Source: APBJJlGPNHzNklItxtLj6IhPMlCqzw7XU6HhPxNZ7iWY9jWyI7Dj4v074K+i+0hrofeALI4SmdbGNg== X-Received: by 2002:ac2:4e89:0:b0:4fb:9341:9921 with SMTP id o9-20020ac24e89000000b004fb93419921mr835866lfr.52.1689246729823; Thu, 13 Jul 2023 04:12:09 -0700 (PDT) Received: from localhost.lan (031011218106.poznan.vectranet.pl. [31.11.218.106]) by smtp.gmail.com with ESMTPSA id r4-20020ac252a4000000b004f8422b7991sm1070080lfm.154.2023.07.13.04.12.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jul 2023 04:12:09 -0700 (PDT) From: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= To: Florian Fainelli Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Subject: [PATCH] ARM: dts: BCM53573: Fix Ethernet info for Luxul devices Date: Thu, 13 Jul 2023 13:11:45 +0200 Message-Id: <20230713111145.14864-1-zajec5@gmail.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230713_041213_296190_3AF68395 X-CRM114-Status: GOOD ( 14.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Rafał Miłecki Both Luxul's XAP devices (XAP-810 and XAP-1440) are access points that use a non-default design. They don't include switch but have a single Ethernet port and BCM54210E PHY connected to the Ethernet controller's MDIO bus. Support for those devices regressed due to two changes: 1. Describing MDIO bus with switch After commit 9fb90ae6cae7 ("ARM: dts: BCM53573: Describe on-SoC BCM53125 rev 4 switch") Linux stopped probing for MDIO devices. 2. Dropping hardcoded BCM54210E delays In commit fea7fda7f50a ("net: phy: broadcom: Fix RGMII delays configuration for BCM54210E") support for other PHY modes was added but that requires a proper "phy-mode" value in DT. Both above changes are correct (they don't need to be reverted or anything) but they need this fix for DT data to be correct and for Linux to work properly. Fixes: 9fb90ae6cae7 ("ARM: dts: BCM53573: Describe on-SoC BCM53125 rev 4 switch") Signed-off-by: Rafał Miłecki --- .../boot/dts/broadcom/bcm47189-luxul-xap-1440.dts | 13 +++++++++++++ .../boot/dts/broadcom/bcm47189-luxul-xap-810.dts | 13 +++++++++++++ 2 files changed, 26 insertions(+) diff --git a/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dts b/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dts index b9dd50844419..0f6d7fe30068 100644 --- a/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dts +++ b/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-1440.dts @@ -45,3 +45,16 @@ button-restart { }; }; }; + +&gmac0 { + phy-mode = "rgmii"; + phy-handle = <&bcm54210e>; + + mdio { + /delete-node/ switch@1e; + + bcm54210e: ethernet-phy@0 { + reg = <0>; + }; + }; +}; diff --git a/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-810.dts b/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-810.dts index cb22ae2a02e5..4e0ef0af726f 100644 --- a/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-810.dts +++ b/arch/arm/boot/dts/broadcom/bcm47189-luxul-xap-810.dts @@ -81,3 +81,16 @@ pcie0_chipcommon: chipcommon@0 { }; }; }; + +&gmac0 { + phy-mode = "rgmii"; + phy-handle = <&bcm54210e>; + + mdio { + /delete-node/ switch@1e; + + bcm54210e: ethernet-phy@0 { + reg = <0>; + }; + }; +};