From patchwork Fri Jul 14 21:51:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 13314249 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E87AAC0015E for ; Fri, 14 Jul 2023 21:51:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1154A6B0071; Fri, 14 Jul 2023 17:51:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C5FC6B0072; Fri, 14 Jul 2023 17:51:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECFD46B0074; Fri, 14 Jul 2023 17:51:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DE9CD6B0071 for ; Fri, 14 Jul 2023 17:51:22 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AA849402F2 for ; Fri, 14 Jul 2023 21:51:22 +0000 (UTC) X-FDA: 81011564004.07.E711BA6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf03.hostedemail.com (Postfix) with ESMTP id 9F25A2000F for ; Fri, 14 Jul 2023 21:51:20 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IuA11kVt; spf=pass (imf03.hostedemail.com: domain of trix@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=trix@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689371480; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=8Hxo+RkWpN14XLiWcgexFQoX59W2A8cV2w6hOlqdXYc=; b=a9OWi/boRYCIioVt7rRrkgSklkU4pTdfpG/P0EZJvDmlRjlPZN4ZfgUSkwLIF19nqwzOK9 4z/drldBhBt7DV1pDqke+bLzfAmnh2Iz3HWpSjXY4sVMWz6/LlEsfPdREx5otah0tcgazM 41yDsmWT9/bULVHDomeD4ChP3qndkJM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689371480; a=rsa-sha256; cv=none; b=XTwGsq3nWzALWvPVE9yPVdch8lagUSxk4BQ08VYBGYLtwKYYH+mk/6E7TB5IdNpl3Wy1Wt RkAziEC9dqO32XcB+fHgyL4QE+XODFXUSWgm2zRiPebhtQ+gaEWMc0nI3zgSV8LNUu5IMY ffmm6RgNB2cP86uy9LFiT3de4tjL4Lo= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IuA11kVt; spf=pass (imf03.hostedemail.com: domain of trix@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=trix@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689371479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=8Hxo+RkWpN14XLiWcgexFQoX59W2A8cV2w6hOlqdXYc=; b=IuA11kVtueHWTwDlnAF/2uiq0MTBNEnvbAqh3fEnJYNU9w7iRMcq0NEsKYq79y7xlMIe9D XA5Z0ImNkkTxppu5ViUkn0EpR/1xOFmZDCE5sZOdEFOZ+IScCE2McN2BqPXY+SndwtiFEA MxpknP9RUIgjeCt0knFCjRYLq8gHhRU= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-423-MXDldYluMCuwvgip37G7Pw-1; Fri, 14 Jul 2023 17:51:16 -0400 X-MC-Unique: MXDldYluMCuwvgip37G7Pw-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-634dacfa27bso23770356d6.3 for ; Fri, 14 Jul 2023 14:51:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689371476; x=1691963476; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8Hxo+RkWpN14XLiWcgexFQoX59W2A8cV2w6hOlqdXYc=; b=S0bp4MRv1zD3SWmunS5IuWELJ2hnGDSObnr+3fOEPXpsDn7EzEjo/L7RLNZR47m+mG q66DS71dS+qTylH3TS2lw6SsZCriReXobeVT1zj1d5Q+kwt5184SHNb1NG/OCzQ4tqkb gQ3dkrYy3Sg8Nqmfwv6aqu8lKdzziM5wMZhbfnSDMXjJyxXM0JPR3l5aIhkWFNqiFz8c iQvAhj9IJ3JsOxzY0YGAdNpMp+tgLXPaBojB+MtOdmn6uGayqEF83kPgGQgEFQEyNUMN 3JbbdJBf8GSQRpazgT/g3/yC1ldfOzVTPRA2Xi8P2nKXflWbRnQkcMc3cG2xL6zxB7a0 azfA== X-Gm-Message-State: ABy/qLb6tILM/x8wFDYUItTrHDfOPxnXeT22UjxyJCkuvvVXOLyhwyuN O9f8Gs7SInVb471ubjwFsFouI1pscadlRQjzGmaeC6zB4XbON0mjUoSkp1NLFHM+pzKnmL4jzF8 yj4uZ5pTBdbM= X-Received: by 2002:a0c:f452:0:b0:635:e209:178c with SMTP id h18-20020a0cf452000000b00635e209178cmr5074119qvm.10.1689371476123; Fri, 14 Jul 2023 14:51:16 -0700 (PDT) X-Google-Smtp-Source: APBJJlECeKhR/HE5D/xADqgqYjum7rx4dSsBrkvBGCkPPWkWzdk7JOvc6oRDSx7upiK11VtkOw7Wtg== X-Received: by 2002:a0c:f452:0:b0:635:e209:178c with SMTP id h18-20020a0cf452000000b00635e209178cmr5074111qvm.10.1689371475858; Fri, 14 Jul 2023 14:51:15 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id t10-20020a0c8d8a000000b00626362f1bf1sm4276508qvb.63.2023.07.14.14.51.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jul 2023 14:51:15 -0700 (PDT) From: Tom Rix To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] shmem: set variable shmem_mark_dquot_dirty and shmem_dquot_write_info storage-class-specifier to static Date: Fri, 14 Jul 2023 17:51:13 -0400 Message-Id: <20230714215113.3919026-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Stat-Signature: wp3qfs5hqfrg71iiywyjrbwqmuirahex X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 9F25A2000F X-Rspam-User: X-HE-Tag: 1689371480-375766 X-HE-Meta: U2FsdGVkX18Y4LdiqVDExBG+KJrYrZG80ZvfaL4CNQMBdPmvLvvqz+g9paS4f7csPOGsT29jnO4E2hqKARTT5G4YIMuwPHxcZCFgBnUwOOClMQSwRUDlva8uAtWw8hQ4z2S4E2FHkaWJ0stahchtB/p3LPzIoABhFstJtOkXcB57SnxixErX9VoqZC1XXkIp1AiftiChu/CzN/4gu1TWvApL3+vWLgi9XUJdO3njljhUs+M1fFTFklfr3VpOnU881P8WbU9lStMppBasDhwBhBjZLgqaRCe1HVK7QDoFkiilbNDdapqp50/epAFJjHReU9IYvXCNfsCdyXPvP1+/6TjH8GQexRgd3h3h8rd1GLg9yHpaEtpDu8gK1jNsYeFfJThPioQ3+1EYv2JTTGZs24pvgtinMo2DSNBLNJFfc+Lj2owxbFXe8wEwW98/OxWH9DTGf0sXT89Tlo4k2bg2B3nwZ/dVQzpVgwUseKpzDHuu3MxzbSF5sc9wkappls2szugunmnCaygkEMkZoFUpQlXf/yCPgZhb9oRo+1qVxXVtslewSzqjyDne+/PbeVOpnrJzvOrdZ/tgkJoP5+l8PfVXpAjRgcbN1bVUzuYVVfbJXtdfuaZrS8dvoLrd7Uwtm3CL6OIwKyzVIn6h03uZLVuwNyQdZYA+OtdQZJqByFggojQpq3L8CCyZdMpNi2JVmutDTYild/xuoFcmgJjM7PDbUW9zp/JA19fGL1JMXiOQ5fpAOggnWGzPrXKnOA78bY1mm3uKiDt0SbvOod5BpJxzEfU0hHJgBRiD5fTLVElhQHoFoi+c6sn+wHGcnNA6XMAfIs1htHKX2mTZuCEwdbnWqU1FR4AEmiwwkdTcjeqmQ9XBZV+IK8+ezGrmv7rG41j2CUtgDe0D39yUyWpLAl7Wr3NIkxoDZYUNaB7yl7IgNET7NZiEzlGATPBihxcLSK345FlQrGzPjtz667j JxK3Z/8F y7oofD1aoBjucJHiGopc2mmi8e6jrvHZ8g/9GjTUu/n2tjvckhKF+gkdfEpbl3u6aNoi6iTNu8HBjyxRZ/CObbDSDscHDY9QNQXV0BqOe7YWk976xJlcTwQtbpE/JGux206s/AKzpGI7MzuCdhVi/O/cvSGz8/1IJ5ZhoK6aBIhMYLiEabAg2iMRZL30wAypBhs7wS1lPv4OwZ5ee3b7HiayUTM+AR925ueJE2ZlLzjzmvqpdp2bjBu9kNZUUzjASJ4y7QwFXPjCNbzCxncRPywE9hqkTQSeBNw+MxirqUnEul3JToFztzwcnrIo3Yvn8VWzhCXqJdxxyyyM9ap4D36LHsduOCP2eCdCfPofcDADQLqzu8t20zYGQkl5CIBdOgS33P5kDodCvPC44X0o5LFLLcUvbIqAVsgluXtJxfk85NRFeJt50sYYzNA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: smatch reports mm/shmem_quota.c:318:5: warning: symbol 'shmem_mark_dquot_dirty' was not declared. Should it be static? mm/shmem_quota.c:323:5: warning: symbol 'shmem_dquot_write_info' was not declared. Should it be static? These variables are only used in their defining file, so it should be static. Signed-off-by: Tom Rix --- mm/shmem_quota.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/shmem_quota.c b/mm/shmem_quota.c index e349c0901bce..062d1c1097ae 100644 --- a/mm/shmem_quota.c +++ b/mm/shmem_quota.c @@ -315,12 +315,12 @@ static int shmem_release_dquot(struct dquot *dquot) return 0; } -int shmem_mark_dquot_dirty(struct dquot *dquot) +static int shmem_mark_dquot_dirty(struct dquot *dquot) { return 0; } -int shmem_dquot_write_info(struct super_block *sb, int type) +static int shmem_dquot_write_info(struct super_block *sb, int type) { return 0; }