From patchwork Wed Jul 19 13:54:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Roberts X-Patchwork-Id: 13319020 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 058EDC001B0 for ; Wed, 19 Jul 2023 13:55:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 67A7628005E; Wed, 19 Jul 2023 09:55:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62A1528004C; Wed, 19 Jul 2023 09:55:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F16E28005E; Wed, 19 Jul 2023 09:55:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 40F4B28004C for ; Wed, 19 Jul 2023 09:55:09 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E2DA114036A for ; Wed, 19 Jul 2023 13:55:08 +0000 (UTC) X-FDA: 81028507896.08.41140D1 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf08.hostedemail.com (Postfix) with ESMTP id 0FF6B160006 for ; Wed, 19 Jul 2023 13:55:06 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf08.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689774907; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hNL1y3SfunmfxSUTvIEH48/V1tE9GSr47MXZQeskAHk=; b=jOsmJTUMe80oyoVc9BtLwsaKcMuIOW0WG7B6ytpYj5AZE5cIyjMhUzoLLAcBdPMB0ehVgq c7/qPLHN3ddo7wqy8UsT7fhxXtQ271ZmQsEpdLem+eWx6h2OROIHyYFAPsdO4eAOI04rVh 5j1zoj9TJBhsOgvMXfWnOn1lCxiLKRk= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf08.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689774907; a=rsa-sha256; cv=none; b=JT+B5FiRtO/q3GPO9kIDqsOIQXFFXJFC7pzQGzFlv5+jn06g0Qa4fkQgY9oc1pTlI7urmz ScIKVfwN9a5BFfmFKY7IlZZUaKOvkadD1SiNRvDzOCELJ6fFvMKePsNHRL5bbUj2hdMaJH DxuZLgF8ZWPohIKxZxruRQjm2qAh66A= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6CEF3D75; Wed, 19 Jul 2023 06:55:49 -0700 (PDT) Received: from e125769.cambridge.arm.com (e125769.cambridge.arm.com [10.1.196.26]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 90B6C3F6C4; Wed, 19 Jul 2023 06:55:04 -0700 (PDT) From: Ryan Roberts To: Andrew Morton , Matthew Wilcox , Yin Fengwei , David Hildenbrand , Yu Zhao , Yang Shi , "Huang, Ying" , Zi Yan Cc: Ryan Roberts , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v2 1/3] mm: Allow deferred splitting of arbitrary large anon folios Date: Wed, 19 Jul 2023 14:54:48 +0100 Message-Id: <20230719135450.545227-2-ryan.roberts@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230719135450.545227-1-ryan.roberts@arm.com> References: <20230719135450.545227-1-ryan.roberts@arm.com> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0FF6B160006 X-Stat-Signature: zpmpbk6wee5qnrtneg7a6dx37w9e5r5d X-HE-Tag: 1689774906-629940 X-HE-Meta: U2FsdGVkX1+KvyXthtpl0YOgavQtIgvqETH4pQmPbjUc9EQTOOSe2HVfxtZlYO6DKm7btJx+0RmtqErvjyoSmAfW3/waRgiE9tASfl4o3d0eleKrZpEqK3Pyy7bvurpCnpriDKcCYOiiFw/FsCuzMDuWd1rWgJpYwUZ7taGo0XhDC49MONqMPiaAHjK0vb+rE7ekfbR7xGZdU4np0bJNrXsxXUjsvKxrp+5hJ4ykdSR2CXcB+ffSoRZJv/vsFOW3okT1Z/o7Ka2kmg8Q1pWN0o2qK68Y+7zJ20hYZAPiCmkmRnudzQmyynGYk+8Kgj3xgYSMoTI4bYgBp5RLMljy9Oynw82wMA7Ulj0vlLXpByncozcZOwmbhiwRfdy948OD4VRJTlOxFtQZyI32BMyYf+ADLdQDQG43oscxdATOewjwhE5hq1kx/F8niPM+PmYBP027buQ31134Wui4HvVUx0soKpG1kzbFOGbfYi6nT67eY6tnAjORYQ43cyhYNFcci3Pt0HJ1E79ZKGVKWqZ2yKOMwFyuWBV+tCfioknw+lMRzbdL6Z/5iw8mX5RYS5aIjPU4EUA1de285bOvBOqy6A8aTaTA93DMKP6BEm3FEKb2s3NgdCSEbxHhiwtEmSZafRlZsy8/pukVNYl4qxTDWdg0CRkDqYTT/XbtQIlLNd8t90pUHQJEwYjVEt1QAFERwzpekud51vNYQGlmjAa55FMdohuBvH7YD/G3yBAUs6Z3dhfjCu4OfNgwqXNGA9ggcVUYk/D3VKYSdY5CzKhmY0YrguGpWI/lnpOA3WTTFmqCRINVeiySjdBUK/H7CbeiF40jJbInUG38myhQM+JpbW1eMJXnPVxVxWef59VyApiRbt1pV6xZBvxpImsWLP3652UfCQ+YsEN00lA3avYnrLXOnqzJli5JmxkpGgjpNyY0WMHEdo+Nxyt7I2SA8ZNdt2V3btv+cJnBTDZ5hK6 lMfH+pq2 LOX6jMiKTWyF+iriH2p780H3nLleO58jYSnzuNg86BI85WsuzyHwsPHDKa4bjF6pY4JwrYKoCdOPeBMLTzPT5olcyQK3dw3vWWEuFDsIk+BwpBgexBpnsmei5x0AO+X5CRcJXlnDdHKN6FihtaW9IMTeh+Q8bWTCMgKzECKfo0NSgAL29kWC6xnMM9eudCDJD9xHlZ7+ue+uf3cZu2oQFDgg2mvuYBWK/w90zMSMJWC7/biPWt1aWQu5MF9TC/Zpd0eYDWW8n4ramLOWc1z+xQrxU5rqwvE2Ho+o9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In preparation for the introduction of large folios for anonymous memory, we would like to be able to split them when they have unmapped subpages, in order to free those unused pages under memory pressure. So remove the artificial requirement that the large folio needed to be at least PMD-sized. Reviewed-by: Yu Zhao Reviewed-by: Yin Fengwei Reviewed-by: Matthew Wilcox (Oracle) Reviewed-by: David Hildenbrand Signed-off-by: Ryan Roberts --- mm/rmap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/rmap.c b/mm/rmap.c index 0c0d8857dfce..eb0bb00dae34 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -1426,11 +1426,11 @@ void page_remove_rmap(struct page *page, struct vm_area_struct *vma, __lruvec_stat_mod_folio(folio, idx, -nr); /* - * Queue anon THP for deferred split if at least one + * Queue anon large folio for deferred split if at least one * page of the folio is unmapped and at least one page * is still mapped. */ - if (folio_test_pmd_mappable(folio) && folio_test_anon(folio)) + if (folio_test_large(folio) && folio_test_anon(folio)) if (!compound || nr < nr_pmdmapped) deferred_split_folio(folio); } From patchwork Wed Jul 19 13:54:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Roberts X-Patchwork-Id: 13319021 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 764BBEB64DA for ; Wed, 19 Jul 2023 13:55:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BFAB028005F; Wed, 19 Jul 2023 09:55:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B844428004C; Wed, 19 Jul 2023 09:55:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A489D28005F; Wed, 19 Jul 2023 09:55:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 93E4928004C for ; Wed, 19 Jul 2023 09:55:11 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 55B82C029D for ; Wed, 19 Jul 2023 13:55:11 +0000 (UTC) X-FDA: 81028508022.15.A91CB64 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf03.hostedemail.com (Postfix) with ESMTP id 4D7722001B for ; Wed, 19 Jul 2023 13:55:08 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf03.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689774909; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2dqIz3C526jfk09wr8sX5z1Ztv6RWuu5WBWCEVsOmTA=; b=zAmF/HGimKE8Zlw/8HD+XWz0WJcDTYmAYjZ5HOk/9oPtoCZtSg1sPWRG7XzeLUhJljQEW6 NeR1pGriHhgNYRs8qgZHX4O3XqlX/4mj0I8RI3thKxHMMKZ0O/wM6uYioAj1E6CHjmMSfs 23XW7Cj6Uyl1sWfXX+8FgOq2LMuLPt0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf03.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689774909; a=rsa-sha256; cv=none; b=kzEKfiTQtd3KXwPmiQjwBwbPRX8RvB+V/AD3G3jCz5sebe9hLH22uAZUGZsLWivctQMIb4 NSA9Ya17gif+058EXpvUx4+qQiqmCesFSQ7cUC/efgB0t2AQxzfXowrB/Y9NlN9dspd0/Q WtOAG/mufsvG2a89XRuGHiXmUHGHVcw= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4238512FC; Wed, 19 Jul 2023 06:55:51 -0700 (PDT) Received: from e125769.cambridge.arm.com (e125769.cambridge.arm.com [10.1.196.26]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 672B43F6C4; Wed, 19 Jul 2023 06:55:06 -0700 (PDT) From: Ryan Roberts To: Andrew Morton , Matthew Wilcox , Yin Fengwei , David Hildenbrand , Yu Zhao , Yang Shi , "Huang, Ying" , Zi Yan Cc: Ryan Roberts , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v2 2/3] mm: Implement folio_remove_rmap_range() Date: Wed, 19 Jul 2023 14:54:49 +0100 Message-Id: <20230719135450.545227-3-ryan.roberts@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230719135450.545227-1-ryan.roberts@arm.com> References: <20230719135450.545227-1-ryan.roberts@arm.com> MIME-Version: 1.0 X-Rspam-User: X-Stat-Signature: 8h7f1yxfgnkpk7i1xfh5hmsrpe81uz73 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4D7722001B X-HE-Tag: 1689774908-686510 X-HE-Meta: U2FsdGVkX1/tNk+/gfmVcdSj/lqgVHTC0S9cfhFNpt4V+tpv3vdMhwblguUjgQhvDEgJKJAcpAzRMw2fRHRq+AryjVVpbG4eLGPPpfTn7uPYunRjHF+aC7iW0KarkpomeUqkGr1lWl49341Q8ID+X0SPeslxj7Zy+vM2O/q56jwvufbuP1gagcYblQeL5MCnRvXIk1dqDnNIYBxvjkXHjoobpP3zWpt6g71pi+Rwt6NsFGcIebQgJj2Q5aCRHQ74qDJxFBk0URThxOuF59RwAG009zoJSpmN1fSBYyU6oOxiX68XLtmuAMMImVfaTV3sppLR/0tdBUpzBUq0wfoDwCUGiNVENdPg7/OCjXfyvGV661bgX9c9ML1aekZ8gwkkPSbc0FSjseWNi+xDpI7bcxqzflR8zSbtKYi0Gsc4Swp03xbRLb58NQyTygdpBb23CCXJP6qjf9OVTg2kZrTqqTfIbx7xJjLCAkPkgdW7m0UIeTR4QZd27Tnb7lSpB7hLTJ6pr1+n0R8Ig2VAe21aB9fgOp8QfUIZBZ3VlJVOwP7+8KyqUs113yThPoOYA7foMJpBvKKHKRht/oqM5UgW2zXU7ufgANrcfMyI1pSmt4qyDomvWxER26E98TU4KxGDB9gfv3jWdaWM/MUyzeVOUWrBnYqZ2sSgjF0T0E0IKTnJMrre++/Tz1lmSZz/Y/LQ1jIZ+8aePtSvnki+JXe900+wzYBaZfWetzR3kqr/ggB7cTtwZ1xlsRY7CTs8JmmxdVXyYBTiC6UnNN42lRvZu0hGse6ysXGGocT709AQ9nGEKw2vRk/8u2LIJMgN4cNkEjurAVHKKmAlVXDnu7BM+oo3fS4xLsnXdMFP30M9Bo7+AhjN43RwOhJHOxMGDH7ycOY+yMhBoHQZ7KZ9S+dEBsXVC9gIOuEun3angmoqy99vi9u3X86ftAPHhX/PPt0mLMnTVC8xHBSoDNWewYS e+NnoUpy NWpYmDwGti7N8TR7afWbZ5n3Ys0E2iI6O22iDzpQ3qjLeVZCqGmTBeIpcFiEIpIio+NQGziyga618O2m7+iWNpgV86m9KFRY1j6hstdyyv4VNxLPw+uaFq0ZEI16GmYDAkEutQ+xfHLG3rGv626IQYHtc/v1YVDwnzQtEV+Cupl/4pzDFmf5ci7ugYOWcvVBH22G3uDFltI4vE79NfHAysDfEEEE1X3MmDSfFGBAt+ENtvDiwpprEExOTTw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Like page_remove_rmap() but batch-removes the rmap for a range of pages belonging to a folio. This can provide a small speedup due to less manipuation of the various counters. But more crucially, if removing the rmap for all pages of a folio in a batch, there is no need to (spuriously) add it to the deferred split list, which saves significant cost when there is contention for the split queue lock. All contained pages are accounted using the order-0 folio (or base page) scheme. Reviewed-by: Yin Fengwei Reviewed-by: Zi Yan Signed-off-by: Ryan Roberts --- include/linux/rmap.h | 2 ++ mm/rmap.c | 72 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 74 insertions(+) diff --git a/include/linux/rmap.h b/include/linux/rmap.h index b87d01660412..f578975c12c0 100644 --- a/include/linux/rmap.h +++ b/include/linux/rmap.h @@ -200,6 +200,8 @@ void page_add_file_rmap(struct page *, struct vm_area_struct *, bool compound); void page_remove_rmap(struct page *, struct vm_area_struct *, bool compound); +void folio_remove_rmap_range(struct folio *folio, struct page *page, + int nr, struct vm_area_struct *vma); void hugepage_add_anon_rmap(struct page *, struct vm_area_struct *, unsigned long address, rmap_t flags); diff --git a/mm/rmap.c b/mm/rmap.c index eb0bb00dae34..4022a3ab73a8 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -1359,6 +1359,78 @@ void page_add_file_rmap(struct page *page, struct vm_area_struct *vma, mlock_vma_folio(folio, vma, compound); } +/** + * folio_remove_rmap_range - Take down PTE mappings from a range of pages. + * @folio: Folio containing all pages in range. + * @page: First page in range to unmap. + * @nr: Number of pages to unmap. + * @vma: The VM area containing the range. + * + * All pages in the range must belong to the same VMA & folio. They + * must be mapped with PTEs, not a PMD. + * + * Context: Caller holds the pte lock. + */ +void folio_remove_rmap_range(struct folio *folio, struct page *page, + int nr, struct vm_area_struct *vma) +{ + atomic_t *mapped = &folio->_nr_pages_mapped; + int nr_unmapped = 0; + int nr_mapped; + bool last; + enum node_stat_item idx; + + if (unlikely(folio_test_hugetlb(folio))) { + VM_WARN_ON_FOLIO(1, folio); + return; + } + + VM_WARN_ON_ONCE(page < &folio->page || + page + nr > (&folio->page + folio_nr_pages(folio))); + + if (!folio_test_large(folio)) { + /* Is this the page's last map to be removed? */ + last = atomic_add_negative(-1, &page->_mapcount); + nr_unmapped = last; + } else { + for (; nr != 0; nr--, page++) { + /* Is this the page's last map to be removed? */ + last = atomic_add_negative(-1, &page->_mapcount); + if (last) + nr_unmapped++; + } + + /* Pages still mapped if folio mapped entirely */ + nr_mapped = atomic_sub_return_relaxed(nr_unmapped, mapped); + if (nr_mapped >= COMPOUND_MAPPED) + nr_unmapped = 0; + } + + if (nr_unmapped) { + idx = folio_test_anon(folio) ? NR_ANON_MAPPED : NR_FILE_MAPPED; + __lruvec_stat_mod_folio(folio, idx, -nr_unmapped); + + /* + * Queue anon large folio for deferred split if at least one + * page of the folio is unmapped and at least one page is still + * mapped. + */ + if (folio_test_large(folio) && + folio_test_anon(folio) && nr_mapped) + deferred_split_folio(folio); + } + + /* + * It would be tidy to reset folio_test_anon mapping when fully + * unmapped, but that might overwrite a racing page_add_anon_rmap + * which increments mapcount after us but sets mapping before us: + * so leave the reset to free_pages_prepare, and remember that + * it's only reliable while mapped. + */ + + munlock_vma_folio(folio, vma, false); +} + /** * page_remove_rmap - take down pte mapping from a page * @page: page to remove mapping from From patchwork Wed Jul 19 13:54:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Roberts X-Patchwork-Id: 13319022 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47CDBC001B0 for ; Wed, 19 Jul 2023 13:55:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7DCA280060; Wed, 19 Jul 2023 09:55:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D2F0028004C; Wed, 19 Jul 2023 09:55:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2788280060; Wed, 19 Jul 2023 09:55:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B17DD28004C for ; Wed, 19 Jul 2023 09:55:17 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 911E016035F for ; Wed, 19 Jul 2023 13:55:17 +0000 (UTC) X-FDA: 81028508274.17.049C616 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf16.hostedemail.com (Postfix) with ESMTP id BB310180005 for ; Wed, 19 Jul 2023 13:55:15 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689774915; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G2GF+BZHvW+OuduMU+juyHwMecPdL/HtveJeza/m3Jw=; b=SObHX62Aclqh8LbgUuDvTMH3b087lPTEYTFWPjRILmTqEHrWsBf741LBcN6xuKYhaDE7CJ k9jFuWEZFISCg7Vmgq+laYAQRmTO1pZACHsKD3jUKmICX45BcZqXXZJDoHhNLzsltqOY2a sPTTJcO3ATY7ll3vlN4VpfsTbGA9Hbw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689774915; a=rsa-sha256; cv=none; b=TE1F/uJXayU3H1aVBkQBfnTqrsaqJ9HUGpHckuItX4oJZraO5RTI4aCr7CfHRnEDmNn0UC Fn4Do3hzIGV+T3sJsIc/OIfxWeeCfMKZvpqcaMRkjuP0A1Fwa446JsTIrZdfMnyuVTaZ5v wQgdJfk2pANtJzpUoTQZVDzriKdZq8k= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; spf=pass (imf16.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A0532F4; Wed, 19 Jul 2023 06:55:58 -0700 (PDT) Received: from e125769.cambridge.arm.com (e125769.cambridge.arm.com [10.1.196.26]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3DE203F6C4; Wed, 19 Jul 2023 06:55:08 -0700 (PDT) From: Ryan Roberts To: Andrew Morton , Matthew Wilcox , Yin Fengwei , David Hildenbrand , Yu Zhao , Yang Shi , "Huang, Ying" , Zi Yan Cc: Ryan Roberts , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v2 3/3] mm: Batch-zap large anonymous folio PTE mappings Date: Wed, 19 Jul 2023 14:54:50 +0100 Message-Id: <20230719135450.545227-4-ryan.roberts@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230719135450.545227-1-ryan.roberts@arm.com> References: <20230719135450.545227-1-ryan.roberts@arm.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: BB310180005 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 1efzabie3cropu6amopfd6fk35nbujpb X-HE-Tag: 1689774915-217083 X-HE-Meta: U2FsdGVkX18s7cydk6je/6s6Ib9MZZoWwURltF/LAKyHB5x2LYj8QgGeqRHqbvCYbanNKOn7ETEUFlfPH129uui6CiYJaCVUQKNe8mAZFlEykeO8qaV28sfCIGRgIOuUAt4IqohV/qtM2hznKbV2NKoG93whyFExriiYe5TOB5YrR/D2QKG9UesTbragjIbufNYMvJJb6YAmdiRnol1d6+L4Bapend+2Bo1nswORafkZii7mNiSxu9yj5BWjlUKLMwiQ1KLlX2XzBj/1OamLXtxcQ/7HaqZ5/8Op1x/d705iInUVl0aQRDC5yVnufz9vvGlr9P1Q3DBMvK/+Dh0A7vTFb2j1sORg0i0Q7ytMaydT6UmD0LQx0zd2CJrOhprArPBgk2HaNcnHwZIvTpIk2lsBpMnvEQ3gv+K3S56AbuXdyO38Gy4peMV8NrigRbVom274zB5NDGABWxk5yHlD3QZAkiq0zkHXeDHRP++2Y5ueySpPQEdbzGRFxfbEalvL64bkkrJpMbbcjST0l1Ex5onx8M2sXuv5cY/OeWdTNgGyPZ3EFt6uijNaHtBPqhal5x2LMFecRnZsfNhq/LUm9U4yla+PYC8SQZVVa8ZVLWivd4WDsSSwKZilMxHLoxEqvLiAYKi6erZhSu6NVbn61UfokuJMCdJ3rKIgPgtGvIFlmd3Elmm6a3v7HYe+KrD4TPeqiy5go1N7IobtQ2ZVS25kfGtVkCry/Qaj+Xmxc9p0aSb3FqYn08sbI3SbOnAHwoW6GUqnB1UqRpzmy4cYjIIxGjHcr3NljkKeOWy+w8MLLeFeGTNgsQUUbkDku6HQ8FmHJaWFyYRzNAMGzP6chTG1cNfhd5mYLUDTNKFzqI118gwqlOr9GPqFXPLgk65OghePd81k0i3bQkGwoSW8X5igeSjPhym0jtdqSZqi2eNxxDNGpwXYgHVEwluvbkB0r/kSVE4NntcuTyv72Jy Kq6tJXHg Z1CuEuo/VxWQQLAtpbI8cGpVaUOBO1M60KJ7bZfzr40rq7WAkCMjxgLa7x8uggGc8ENSycyEiFx1lXNCHuRpsev52O5j2a1+tG22ksC7FFeEDZ7DAxc8h6xJY0krb7AtvSGPpAUZ8w92YvF5UFS/wzqKejxA5SpQOMjQR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This allows batching the rmap removal with folio_remove_rmap_range(), which means we avoid spuriously adding a partially unmapped folio to the deferred split queue in the common case, which reduces split queue lock contention. Previously each page was removed from the rmap individually with page_remove_rmap(). If the first page belonged to a large folio, this would cause page_remove_rmap() to conclude that the folio was now partially mapped and add the folio to the deferred split queue. But subsequent calls would cause the folio to become fully unmapped, meaning there is no value to adding it to the split queue. Signed-off-by: Ryan Roberts --- mm/memory.c | 120 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 120 insertions(+) diff --git a/mm/memory.c b/mm/memory.c index 01f39e8144ef..189b1cfd823d 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -1391,6 +1391,94 @@ zap_install_uffd_wp_if_needed(struct vm_area_struct *vma, pte_install_uffd_wp_if_needed(vma, addr, pte, pteval); } +static inline unsigned long page_cont_mapped_vaddr(struct page *page, + struct page *anchor, unsigned long anchor_vaddr) +{ + unsigned long offset; + unsigned long vaddr; + + offset = (page_to_pfn(page) - page_to_pfn(anchor)) << PAGE_SHIFT; + vaddr = anchor_vaddr + offset; + + if (anchor > page) { + if (vaddr > anchor_vaddr) + return 0; + } else { + if (vaddr < anchor_vaddr) + return ULONG_MAX; + } + + return vaddr; +} + +static int folio_nr_pages_cont_mapped(struct folio *folio, + struct page *page, pte_t *pte, + unsigned long addr, unsigned long end) +{ + pte_t ptent; + int floops; + int i; + unsigned long pfn; + struct page *folio_end; + + if (!folio_test_large(folio)) + return 1; + + folio_end = &folio->page + folio_nr_pages(folio); + end = min(page_cont_mapped_vaddr(folio_end, page, addr), end); + floops = (end - addr) >> PAGE_SHIFT; + pfn = page_to_pfn(page); + pfn++; + pte++; + + for (i = 1; i < floops; i++) { + ptent = ptep_get(pte); + + if (!pte_present(ptent) || pte_pfn(ptent) != pfn) + break; + + pfn++; + pte++; + } + + return i; +} + +static unsigned long try_zap_anon_pte_range(struct mmu_gather *tlb, + struct vm_area_struct *vma, + struct folio *folio, + struct page *page, pte_t *pte, + unsigned long addr, int nr_pages, + struct zap_details *details) +{ + struct mm_struct *mm = tlb->mm; + pte_t ptent; + bool full; + int i; + + for (i = 0; i < nr_pages;) { + ptent = ptep_get_and_clear_full(mm, addr, pte, tlb->fullmm); + tlb_remove_tlb_entry(tlb, pte, addr); + zap_install_uffd_wp_if_needed(vma, addr, pte, details, ptent); + full = __tlb_remove_page(tlb, page, 0); + + if (unlikely(page_mapcount(page) < 1)) + print_bad_pte(vma, addr, ptent, page); + + i++; + page++; + pte++; + addr += PAGE_SIZE; + + if (unlikely(full)) + break; + } + + folio_remove_rmap_range(folio, page - i, i, vma); + + return i; +} + static unsigned long zap_pte_range(struct mmu_gather *tlb, struct vm_area_struct *vma, pmd_t *pmd, unsigned long addr, unsigned long end, @@ -1428,6 +1516,38 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb, page = vm_normal_page(vma, addr, ptent); if (unlikely(!should_zap_page(details, page))) continue; + + /* + * Batch zap large anonymous folio mappings. This allows + * batching the rmap removal, which means we avoid + * spuriously adding a partially unmapped folio to the + * deferrred split queue in the common case, which + * reduces split queue lock contention. + */ + if (page && PageAnon(page)) { + struct folio *folio = page_folio(page); + int nr_pages_req, nr_pages; + + nr_pages_req = folio_nr_pages_cont_mapped( + folio, page, pte, addr, end); + + nr_pages = try_zap_anon_pte_range(tlb, vma, + folio, page, pte, addr, + nr_pages_req, details); + + rss[mm_counter(page)] -= nr_pages; + nr_pages--; + pte += nr_pages; + addr += nr_pages << PAGE_SHIFT; + + if (unlikely(nr_pages < nr_pages_req)) { + force_flush = 1; + addr += PAGE_SIZE; + break; + } + continue; + } + ptent = ptep_get_and_clear_full(mm, addr, pte, tlb->fullmm); tlb_remove_tlb_entry(tlb, pte, addr);