From patchwork Wed Jul 19 15:17:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Van Hensbergen X-Patchwork-Id: 13319111 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC5E1156CA for ; Wed, 19 Jul 2023 15:17:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 77B2EC433CA; Wed, 19 Jul 2023 15:17:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689779841; bh=WUnkwoYUUaeSflcgEirZoVzc0KTIoUWAOUey/F0595E=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=J2fQqp+fG2a9bG2AbvMG+1AquX/HeauPeLpjDo/QiW2tWytYlMZTaDeYO1f1e2GCn cODJeQFzCtEeVP4k6v8KdsFloyH0ZtKW+hcvV0iPaKsmY6nLm5ZszYMBvrD4pGIQWA M7F3ODvF5ZCTp/wu6rShp4KRjVwBZHUTcGR7tNMIkDHlJUArUgqsszYvpW+4S1zc2s j7eBVU/2wGuHRKlO19C9mVf2/xOYN3P2SqYah8EsFj8lDZpWfF5sFw3lo+cB/KOQcY FgnlvPtaKFaA/DNBcEzwkl8gXGUXGqjGVsHBK3jRbcE0zg1B36AhJbhUHfmls3/ehD hVvGwULqQUo2w== From: Eric Van Hensbergen Date: Wed, 19 Jul 2023 15:17:05 +0000 Subject: [PATCH v3 1/4] fs/9p: remove unnecessary and overrestrictive check Precedence: bulk X-Mailing-List: v9fs@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20230716-fixes-overly-restrictive-mmap-v3-1-769791f474fd@kernel.org> References: <20230716-fixes-overly-restrictive-mmap-v3-0-769791f474fd@kernel.org> In-Reply-To: <20230716-fixes-overly-restrictive-mmap-v3-0-769791f474fd@kernel.org> To: Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck Cc: v9fs@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, stable@vger.kernel.org, Robert Schwebel , Eric Van Hensbergen X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1121; i=ericvh@kernel.org; h=from:subject:message-id; bh=WUnkwoYUUaeSflcgEirZoVzc0KTIoUWAOUey/F0595E=; b=owEBbQKS/ZANAwAKAYj/1ftKX/+YAcsmYgBkt/5+sjS/J2eXctdnFkVSGorDfItoESVfVnLlO u1TSResKW+JAjMEAAEKAB0WIQSWlvDRlqWQmKTK0VGI/9X7Sl//mAUCZLf+fgAKCRCI/9X7Sl// mKnlD/9gTDICEgt4oNIktJwJ54LppB/+HdDJ3lrDEyTHtvDiG67S5Ch9+XTOM4+RwN6L86jYnLK Mybtaze2WRW1BDBy9X3P6zzptBG60z/F8Rue9pVC2VNc02MZ1/2kF9yMLvER2uPy0Wyw1Ngvonm FHAz9Ua5eIsJewOe/h239t7qsZ2SiP3FtBHI2sVk9XWa0LZG4lYwhqCO0gobnXqZ0I+oddvNRWD 020NdzQekYrPGAQ+mHKYbBVvKCUq4IajQEltCOU6bMG1sTkkdMLuFqFunqwmtDKgb5ukgjafXbK jaY4g0kPJc6KefWoyNyskuP840uu957mED2MrA1+e3OuQOI4Tj5bnGqpMHsxYCF7FCPrGdP9nPs Bh9muCBdhe1oiG51rfB/9XQk01XBEGzbnfdc081sL9JYRII2mZSDmg3HsD5+Evb8AHQvaZq5lqx DNz9ayNhuHf0eenYlBFO+U5B4L17SPm596RydHEEs1Dj+vs269WbsPYZyKGFPb8Jd5JIyCZHIMD BLAzp0i/DoeBSft/PlWqci/Og7kTPLpC6iNv1QZwf/QW3cMaW0SR4uPoBKHRt7uPFlMW8PRCvnr oLoqyelLtyD5SR5xvPM+uexBu/25PNQB5PuiJKuZXyH7eHk13rFiMt/Rbfdn1dH+TUzBQtM0pZD SroebqlMCsc6LOg== X-Developer-Key: i=ericvh@kernel.org; a=openpgp; fpr=9696F0D196A59098A4CAD15188FFD5FB4A5FFF98 This eliminates a check for shared that was overrestrictive and duplicated a check in generic_file_readonly_mmap. Fixes: 1543b4c5071c ("fs/9p: remove writeback fid and fix per-file modes") Link: https://lore.kernel.org/v9fs/ZK25XZ%2BGpR3KHIB%2F@pengutronix.de/ Reviewed-by: Dominique Martinet Reviewed-by: Christian Schoenebeck Signed-off-by: Eric Van Hensbergen --- fs/9p/vfs_file.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c index 2996fb00387f..9b61b480a9b0 100644 --- a/fs/9p/vfs_file.c +++ b/fs/9p/vfs_file.c @@ -505,9 +505,7 @@ v9fs_file_mmap(struct file *filp, struct vm_area_struct *vma) p9_debug(P9_DEBUG_MMAP, "filp :%p\n", filp); if (!(v9ses->cache & CACHE_WRITEBACK)) { - p9_debug(P9_DEBUG_CACHE, "(no mmap mode)"); - if (vma->vm_flags & VM_MAYSHARE) - return -ENODEV; + p9_debug(P9_DEBUG_CACHE, "(read-only mmap mode)"); invalidate_inode_pages2(filp->f_mapping); return generic_file_readonly_mmap(filp, vma); } From patchwork Wed Jul 19 15:17:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Van Hensbergen X-Patchwork-Id: 13319112 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BEBF13AF5 for ; Wed, 19 Jul 2023 15:17:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84DD4C433C8; Wed, 19 Jul 2023 15:17:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689779842; bh=cdptwf+tCAM2+aWoAXX9cPeXcqVcV7F8UHRwJ0Ju4kw=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=t/oe2DsB04e2eegO989Vv0cqI+6ZK/iNawU1RvdIfkuDSQ6pCeymBGqCjMhkAdNd8 vUUNDzEGV6Pdt9GW6Os5Q0hNFGyaCDP3tJJ7EIqeHxQ1wclu0Sg9jWmW6Acqx7eKYe L+hVEr98EfnROW5I/GJBIp04UoymQZ6NKneQ4nlg+1SuoqTqo1URYaAoQb+g3z4/fq jnyy5aNv4G6uQC4ZLxd+OG2fawqUDtXAXAtYf33BQXZOaLsv/T+iGg/n5g8oQfPf9m TI3lBlDRwaubvCnZ0SwRGzImqW2wCh1WpRqoJJTv0IUVS0AqrSjjRfz4hA/k8HDCLy Q/a+AKWsCMQfw== From: Eric Van Hensbergen Date: Wed, 19 Jul 2023 15:17:06 +0000 Subject: [PATCH v3 2/4] fs/9p: fix typo in comparison logic for cache mode Precedence: bulk X-Mailing-List: v9fs@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20230716-fixes-overly-restrictive-mmap-v3-2-769791f474fd@kernel.org> References: <20230716-fixes-overly-restrictive-mmap-v3-0-769791f474fd@kernel.org> In-Reply-To: <20230716-fixes-overly-restrictive-mmap-v3-0-769791f474fd@kernel.org> To: Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck Cc: v9fs@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, stable@vger.kernel.org, Robert Schwebel , Eric Van Hensbergen X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1068; i=ericvh@kernel.org; h=from:subject:message-id; bh=cdptwf+tCAM2+aWoAXX9cPeXcqVcV7F8UHRwJ0Ju4kw=; b=owEBbQKS/ZANAwAKAYj/1ftKX/+YAcsmYgBkt/5/HnwbXRdNIzUha4P+gQM2t1MHNIResSrWm bTMBQOwTuqJAjMEAAEKAB0WIQSWlvDRlqWQmKTK0VGI/9X7Sl//mAUCZLf+fwAKCRCI/9X7Sl// mEshD/43bFiL1TWaXPJYjtdnXsN4qkzvuLpslJVZnNOdR0dfKG4KEKO3/TYZYGt+SFSjm/6oZeh /VNFGu98+1QS5WT8+b1ezHW/hiyi22DyLyD9ohYP1Aoor9MijoDgu5YNlz/UetUSIu2+G5FjRqp K1PMamBX72Rp16AOrafjmoZM+onrZSwtQVQhjgDrRwBcM3IYSVT8IdvwSwUNQiDwcySi+AngtGq gA+3+GXEnjr2kAnLNF5PYeFbaO1z+Qsm0YcvZYn7WQi4ipCIvy5H8SZgpivpqLRnZSlgP6aMUs4 odkx+RibL0RhJ5IX+5wgby16UKrrwF/xONA9X/q6h2JGVEp9k5Rw+1mLjnxMfhpikCBV7uY8Ddd pmknhTFPko/zZHjbo21AdBBKrUewFvFV9VAReseKrmO1VlRvxvtifJ/EFKCU9gLz9wrIE4dQW6o rt6zVGgUj1vZNiJhhpBL2H7Ay+6P0c0N5smWYQFpBR8gkLxdcx098uOa7y6vsNjfKDVqmTUy77J tFgMwTSubsmTf1J1mPd43K7N0JnCabqjW0ZcXUwudu8bAPGlCi43qMw6frlFVOPjxqxCXJOC/JX IhNcXnrsc+2PgJgHVjjkkEKqk6WpzqziMHYNHJXAOgRY5vehDaIoDyQY3Dg9W7cRyvSxN1fFG/j FuashKVhN2c/19g== X-Developer-Key: i=ericvh@kernel.org; a=openpgp; fpr=9696F0D196A59098A4CAD15188FFD5FB4A5FFF98 There appears to be a typo in the comparison statement for the logic which sets a file's cache mode based on mount flags. Fixes: 1543b4c5071c ("fs/9p: remove writeback fid and fix per-file modes") Link: https://lore.kernel.org/v9fs/ZK25XZ%2BGpR3KHIB%2F@pengutronix.de/ Reviewed-by: Christian Schoenebeck Reviewed-by: Dominique Martinet Signed-off-by: Eric Van Hensbergen --- fs/9p/fid.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/9p/fid.h b/fs/9p/fid.h index 0c51889a60b3..297c2c377e3d 100644 --- a/fs/9p/fid.h +++ b/fs/9p/fid.h @@ -57,7 +57,7 @@ static inline void v9fs_fid_add_modes(struct p9_fid *fid, int s_flags, (s_flags & V9FS_DIRECT_IO) || (f_flags & O_DIRECT)) { fid->mode |= P9L_DIRECT; /* no read or write cache */ } else if ((!(s_cache & CACHE_WRITEBACK)) || - (f_flags & O_DSYNC) | (s_flags & V9FS_SYNC)) { + (f_flags & O_DSYNC) || (s_flags & V9FS_SYNC)) { fid->mode |= P9L_NOWRITECACHE; } } From patchwork Wed Jul 19 15:17:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Van Hensbergen X-Patchwork-Id: 13319113 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0118D13AF5 for ; Wed, 19 Jul 2023 15:17:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A62AEC433CB; Wed, 19 Jul 2023 15:17:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689779843; bh=37fxouyOhTLlN51p11xeLF2Xq6fH1PuX7PAunRa1+I4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=fylAeVKuZFgjAnD1Rbim39U56NZuBKOVKurcYlSzFSYgdYzCcVRgdWKtmDP8BIb8X irT9O6qEfUYfN7IkSyHpADgOlsW3uzZV8eJW/FPIeYTInOw3WZX04YljcvBdoQMtwX LU9p+6lHxJpr+LRjd+o2jXa7BE2xZqgXOe/GQQ6EgswaUtdAY5/v3Sf1sawn1qT5Z7 TIafQfzfn11/SDxcpGw72B9Y8GcCUkmOsyrlqZPCiZ5nx9TVytCWLDMgtsl+KqfIW+ H0ZxOhNhsjhOwPJEbJRDp57+X4VCvE97Z8kEgfZqtf0QR+PUzfkjPfzhkARjREd6G2 JQMm85MEBwRkA== From: Eric Van Hensbergen Date: Wed, 19 Jul 2023 15:17:07 +0000 Subject: [PATCH v3 3/4] fs/9p: fix type mismatch in file cache mode helper Precedence: bulk X-Mailing-List: v9fs@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20230716-fixes-overly-restrictive-mmap-v3-3-769791f474fd@kernel.org> References: <20230716-fixes-overly-restrictive-mmap-v3-0-769791f474fd@kernel.org> In-Reply-To: <20230716-fixes-overly-restrictive-mmap-v3-0-769791f474fd@kernel.org> To: Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck Cc: v9fs@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, stable@vger.kernel.org, Robert Schwebel , Eric Van Hensbergen X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1102; i=ericvh@kernel.org; h=from:subject:message-id; bh=37fxouyOhTLlN51p11xeLF2Xq6fH1PuX7PAunRa1+I4=; b=owEBbQKS/ZANAwAKAYj/1ftKX/+YAcsmYgBkt/5/NwNmg5qgKtbbcoMgW80FHdRrrxHqqWmhz 2n1QoBKK2qJAjMEAAEKAB0WIQSWlvDRlqWQmKTK0VGI/9X7Sl//mAUCZLf+fwAKCRCI/9X7Sl// mBamD/9iUHjCZ0miq5COrTtaDVZNcwtUvz0doOrSLg6zYoajcTbAiy4PdqPp8O4ZenpN7R/T29J sUGXZ8alc7Zr0M1ILxSqgok1y9mCY4Oa9Cm/SUv+rYxW29+id4od2wcEeDvui8Zmt9gsdr1DOcj j0dfZCuMqjQZX2sJSC8Ej66JcelxE7n19RES54JZIq66bOWL8e9goFce9R1kHP7XONEKipNL9Ia mrDsoXSC9fTK7Rr/FfLKDDuJaozbdM3mubfXOVDMvGY4LOElfs/B1Gq7VwFckXKIdjhAQkALify +UpIwqbK6jNppC21fXJLP97G4WIQzodpq/QTzBF+n590RKPvpiIMxrAIU5ReUhtrksDgVkw8ETp 72YAhRXHJU+9m6B+Ld3TVI70Swj8uVp+0BSrjX0HRghg8JIedOD/lhMfnj3D/Vp7m4jUsTcTjxu GNknf78iSbzfOa0ZTpwpRm0Wg6XqbVT7FfoKddOp3KPARi2CYa6yoxWDinOtWJAO9wcF+MSsk6t DV6wcJrOqNUGe78rcSPyrqrqW18jazl/sloFJXmmGgz4iFnG8hob/a0AgYgJ/CnAenIG1k35W6v mNFDNcJbIVWHti3YwC+289Bfd0X7ayQ/AYSv/7lSRs9S26K8ZO8ARRcB1PvVAe4nw6ZAJV/+fly nIWB0prL0tfJ0Zw== X-Developer-Key: i=ericvh@kernel.org; a=openpgp; fpr=9696F0D196A59098A4CAD15188FFD5FB4A5FFF98 There were two flags (s_flags and s_cache) which had incorrect signed type in the parameters of the file cache mode helper function. Fixes: 1543b4c5071c ("fs/9p: remove writeback fid and fix per-file modes") Link: https://lore.kernel.org/v9fs/ZK25XZ%2BGpR3KHIB%2F@pengutronix.de/ Reviewed-by: Dominique Martinet Signed-off-by: Eric Van Hensbergen --- fs/9p/fid.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/9p/fid.h b/fs/9p/fid.h index 297c2c377e3d..29281b7c3887 100644 --- a/fs/9p/fid.h +++ b/fs/9p/fid.h @@ -46,8 +46,8 @@ static inline struct p9_fid *v9fs_fid_clone(struct dentry *dentry) * NOTE: these are set after open so only reflect 9p client not * underlying file system on server. */ -static inline void v9fs_fid_add_modes(struct p9_fid *fid, int s_flags, - int s_cache, unsigned int f_flags) +static inline void v9fs_fid_add_modes(struct p9_fid *fid, unsigned int s_flags, + unsigned int s_cache, unsigned int f_flags) { if (fid->qid.type != P9_QTFILE) return; From patchwork Wed Jul 19 15:17:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Van Hensbergen X-Patchwork-Id: 13319114 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C365A156D7 for ; Wed, 19 Jul 2023 15:17:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1355C433CA; Wed, 19 Jul 2023 15:17:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689779844; bh=E6XjzAYb9Wv8oYLom3aRYwYdeEdNznryP3hobD0L6AA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=CbHavf/cQw/xrJlvtM3ACNoao/JKPypDZv35q57vsOt11oXryHyVXIhg7rqCYegCl 2LzXAH28+xVSLuy1j5g6NyJ2uZ0Es4NeqsoDjdYWabjKbQRXHO4PwFqOoKk2M4mmbH 9hHRUW4s8FxVGA6HbuF088TbCSFfRWBFPsizt4r7jCY5G+OWGvHWkc7HvchkvGFP5s OEZP6mPDYVXT56i6Fz0eGtUjm6Zt8Kqezl6/P1kPeWOvi+jR1K0y/DXNx0lqHwEkhq EyOI1VriQRDO81Tr9GmNUPhjSWOouEDEVpOr6bmEN7pWaNSve8+7Dz5ZJuXJ3Y2trv LDeWzoVp5/NgA== From: Eric Van Hensbergen Date: Wed, 19 Jul 2023 15:17:08 +0000 Subject: [PATCH v3 4/4] fs/9p: remove unnecessary invalidate_inode_pages2 Precedence: bulk X-Mailing-List: v9fs@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20230716-fixes-overly-restrictive-mmap-v3-4-769791f474fd@kernel.org> References: <20230716-fixes-overly-restrictive-mmap-v3-0-769791f474fd@kernel.org> In-Reply-To: <20230716-fixes-overly-restrictive-mmap-v3-0-769791f474fd@kernel.org> To: Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck Cc: v9fs@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de, stable@vger.kernel.org, Robert Schwebel , Eric Van Hensbergen X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=850; i=ericvh@kernel.org; h=from:subject:message-id; bh=E6XjzAYb9Wv8oYLom3aRYwYdeEdNznryP3hobD0L6AA=; b=owEBbQKS/ZANAwAKAYj/1ftKX/+YAcsmYgBkt/5/O/0AVC5JOGzadqwGbJJ1VIXriZIyzCt4q YAmlkbSB9CJAjMEAAEKAB0WIQSWlvDRlqWQmKTK0VGI/9X7Sl//mAUCZLf+fwAKCRCI/9X7Sl// mI35EACitPglHMdcam1474rTYkZfuDo0JBuCs+MFd+lWN98XeGkTRk7hKEELWQIlnzFiHogaR99 2jCVCuVR1zV9hcdTcc49gAwPqAJbc2uLjXkUAYsLECXzrK6Ow7nM5zDmub2meHGMrRj4PJfKVl2 A4WkW3pgGaaAol8PWLJgmPCHaLxOY2HLr4u+rhn1LbjTJoW7hCQSt72WzFqUlZFGwbxyu8jmswR Ba60h6VUMVTzYI5AjGjA2Bfoc3X7G0Ls8KmuyugRQ1dxpKcR7pMqJbz8ktLYQwsEmMR3V5GdU/x T76NPEurUOV0VeBV5RIK8/Jr9CYfIYhw52TC82jx99RrEfJt6KBADEJUMRiWkMBmY7HL1FM7c2S Dgunry2SxIlEfY7PoiY7HW/nXKalrS32MZuUBi8O5JfP/N5nX9ECJrxZiRYh6hkz58gzcPlptHX kFEXPs7IuWAVwL67RPvNPkc5x+HegNUeNi76vswaRjlTyWVK9f2CmUdunJtiWrJxzGjVJQcNz6D icBiieMND9MYYnC10DVn5nhyKz0UIZRdD2UGb1G1SGg3ttYQ0wnVNj7Du1/IgP/xLHy70UnyPwf 40OjowiBp0DkxsXVsuRgm29GTAwA6k4Jt0FzguDuQM+GLbEMo9y1iOXllGrKzBb8PKsWNcu88Mi sbjkcO9IeuCgCOg== X-Developer-Key: i=ericvh@kernel.org; a=openpgp; fpr=9696F0D196A59098A4CAD15188FFD5FB4A5FFF98 There was an invalidate_inode_pages2 added to mmap that is unnecessary. Fixes: 1543b4c5071c ("fs/9p: remove writeback fid and fix per-file modes") Link: https://lore.kernel.org/v9fs/ZK25XZ%2BGpR3KHIB%2F@pengutronix.de/ Reviewed-by: Christian Schoenebeck Signed-off-by: Eric Van Hensbergen --- fs/9p/vfs_file.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c index 9b61b480a9b0..11cd8d23f6f2 100644 --- a/fs/9p/vfs_file.c +++ b/fs/9p/vfs_file.c @@ -506,7 +506,6 @@ v9fs_file_mmap(struct file *filp, struct vm_area_struct *vma) if (!(v9ses->cache & CACHE_WRITEBACK)) { p9_debug(P9_DEBUG_CACHE, "(read-only mmap mode)"); - invalidate_inode_pages2(filp->f_mapping); return generic_file_readonly_mmap(filp, vma); }