From patchwork Wed Jul 26 13:27:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Pundir X-Patchwork-Id: 13328034 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86A1DC0015E for ; Wed, 26 Jul 2023 13:27:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233102AbjGZN1d (ORCPT ); Wed, 26 Jul 2023 09:27:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231579AbjGZN1c (ORCPT ); Wed, 26 Jul 2023 09:27:32 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BEE4F7 for ; Wed, 26 Jul 2023 06:27:28 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-686daaa5f1fso396335b3a.3 for ; Wed, 26 Jul 2023 06:27:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690378047; x=1690982847; h=content-transfer-encoding:author:mime-version:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=8lxc77XWTDPTeWKbOVls7trvqC1maeRESKQ7JlGBAVk=; b=tzlf/K6lA2nbzCK73P1REKEDFjco9nWhyDMS8OpMrVB0n5mWFKtD++dNg2lByeu7m0 d/zJYAKzFrMg3vWf5aU7sOnjhvN5QHBX0y7FQ9UYQgnKfr9xuvMsFHiYG2QDmHD7k+8q wvw/MD+Gf1t21AqrcccEsCI6otUTJ+XKxBvHL62rhWbUpKt55bqx0UCVcaZlogJ81HYp Tlhm31L8wPRXG3h53U/ofo4BB5wXwgYOqIGcj+szBaXFhZSG9s6mA/xAfsKweCycf+hG V4WdnEeL5ZPUsyVYERCtTl0/y3YymEbtIwL0xCguLZsY5qIrXdFrHUa1iF3dlgHOdJRZ vCwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690378047; x=1690982847; h=content-transfer-encoding:author:mime-version:message-id:date :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8lxc77XWTDPTeWKbOVls7trvqC1maeRESKQ7JlGBAVk=; b=eMZ98n8C5AkhVisLVvngVFFMuflgWnZjPOKXD2A1h5263Q7BF01B5SjEvP5DVV92R1 f1+q6RHnJWntGkePZ6zRUmU1GwzRS5x0ptnhwxAA7CzRNLmtv7NWsMYM2AK6zHW+j2j1 XX8R4pM9EXn35zmlnj3PiUHcg2NlTSs0tWdtmwneJoZYe/NB+Pa6Bhy8haNmNSArR+XP WBSG2Ccdy7eFgewlLW0Rk4bNfgI16Wc6IEzN2hbe7kY54e9GUZGMoT7ViboYoN5KdWKi ikpA788aYacBtzuXC5odTUlpIoi4DTc+xV+M2+/sQoMJlv2wxDPcWhTNwPwecdYyLFCJ kEOg== X-Gm-Message-State: ABy/qLZzDpOb8BzbiD8udwDUiDU/oSP0I7vr8lfDNOI4SHIcF6FaWZFG trPDGhR9sTvIaw5h6kvSArKn7g== X-Google-Smtp-Source: APBJJlEkGaXvYl0Z4D2WNxjIzaFmZ0xG0IQslvweGeXL3npbZc6MEWn92JA3fL7KJSzJy2bGF2OmTQ== X-Received: by 2002:a05:6a00:2d09:b0:667:e17e:85c1 with SMTP id fa9-20020a056a002d0900b00667e17e85c1mr2058353pfb.1.1690378047425; Wed, 26 Jul 2023 06:27:27 -0700 (PDT) Received: from x-wing.lan ([49.207.50.231]) by smtp.gmail.com with ESMTPSA id x52-20020a056a000bf400b00682ba300cd1sm11485918pfu.29.2023.07.26.06.27.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jul 2023 06:27:26 -0700 (PDT) From: Amit Pundir To: Bjorn Andersson , Andy Gross , Dmitry Baryshkov , Rob Herring , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Caleb Connolly , Bryan Donoghue , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , Krishna Manikandan Cc: dri-devel , freedreno , linux-arm-msm , dt , lkml , Krzysztof Kozlowski , Rob Herring Subject: [PATCH v6 1/2] dt-bindings: display/msm: mdss-common: add memory-region property Date: Wed, 26 Jul 2023 18:57:18 +0530 Message-Id: <20230726132719.2117369-1-amit.pundir@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Author: Amit Pundir Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Add and document the reserved memory region property in the mdss-common schema. For now (sdm845-db845c), it points to a framebuffer memory region reserved by the bootloader for splash screen. Acked-by: Krzysztof Kozlowski Reviewed-by: Rob Herring Signed-off-by: Amit Pundir --- v6: Re-sending with review and ack tags. Ideally this dt-binding patch should be marked for stable as well, like the follow-up sdm845-db845c.dts patch in the series but it can't be cherry picked cleanly on older LTS versions. I can do it separately if it is required. v5: Moving the dt-binding to mdss-common schema with updated commit message and property description. v4: Adding this new dt-binding patch, in qcom,sdm845-mdss schema, in the v4 of the follow-up patch for sdm845-db845c. https://lore.kernel.org/lkml/20230712130215.666924-2-amit.pundir@linaro.org/ .../devicetree/bindings/display/msm/mdss-common.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml index ccd7d6417523..84ed2757ded5 100644 --- a/Documentation/devicetree/bindings/display/msm/mdss-common.yaml +++ b/Documentation/devicetree/bindings/display/msm/mdss-common.yaml @@ -77,6 +77,12 @@ properties: items: - description: MDSS_CORE reset + memory-region: + maxItems: 1 + description: + Phandle to a node describing a reserved framebuffer memory region. + For example, the splash memory region set up by the bootloader. + required: - reg - reg-names From patchwork Wed Jul 26 13:27:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Pundir X-Patchwork-Id: 13328035 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 379FDC001DE for ; Wed, 26 Jul 2023 13:27:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234077AbjGZN1f (ORCPT ); Wed, 26 Jul 2023 09:27:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233434AbjGZN1e (ORCPT ); Wed, 26 Jul 2023 09:27:34 -0400 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A42ADE2 for ; Wed, 26 Jul 2023 06:27:33 -0700 (PDT) Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-686b643df5dso1048997b3a.1 for ; Wed, 26 Jul 2023 06:27:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690378053; x=1690982853; h=content-transfer-encoding:author:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=89pDHiQuuTGBrFn4u+2m7Al4Ng6hp0tFQ+lBB6CO7z8=; b=QzQQ58weFbx13ZPAeX9zmEbDZELDz9db2Ffpc0ES48wh1SJYJGC4Z2mdgS9QFKcYfO EabPeQPjzH93WOaUBhAtkLfpQ3qbdX/+1G87al+3Q5xmyFbaDRV3hVxCGMYSpyUMdfdk SyWTu/4g62HL7jgUwfP6IzAYd+1kBjxQ2ZBj0cyjtR3MfioY1dvqcN0S42qhUi891/mp iNhSgV2sGLEGsDaTfPYotDDu1U5WpavGIR/hLewOnsoO71VMS07S1voZF0xDbMO39Oq3 nK5sdySJ+brI4wBWZEfQpyLbixODkMRrttYeWAE6L/LQ4i9Y9DVlzorkIcr8BVHwDaa4 Zqbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690378053; x=1690982853; h=content-transfer-encoding:author:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=89pDHiQuuTGBrFn4u+2m7Al4Ng6hp0tFQ+lBB6CO7z8=; b=jdC6yGeJLpeQhI3QhL7E/GgNNCgTrHJTn/krvUrWsuYHnsadtZr2i7ws6L6qZ0xNFx WmAPJMV0ujJ9EWUTW3Xt1d1i0lJFTx4ihYtqGQSqwqsp3Q+vg66gvY+c1igLzryh/eMb AqixvDbnel7DjdMJ9cpemVxzctaq2EU+4ZbAe35lOlAQ3EdDvVVcGKqLSR4fBvFhXnPv m7opXOnRGhScHkDf8b8ApU4tjUyIGVh8UNo62rwAp4V1akVGzeJDckpPOTLxESFpHJ6e gs6TOr0gpTpjnwTYrIVObHti4m3+7d0Zsj6g0wJQUo9mNkai/3xA9adRKPetbD6paE0u DYcQ== X-Gm-Message-State: ABy/qLaSLBPVr0wWXggWWTy62VJAiEXB+iWY5D1nzdg7nFGfwrO+CWvb VvnKrjWCd7OT2QL5JLfPQcuenA== X-Google-Smtp-Source: APBJJlFizJ74bxiKNwhoKoBmbCLVamjSoW8dbcj9VNixsovbSS+Bhsm7WcaYIWUOWupkeWiuWFNlRA== X-Received: by 2002:a05:6a00:194c:b0:686:dff6:50f with SMTP id s12-20020a056a00194c00b00686dff6050fmr944702pfk.8.1690378053122; Wed, 26 Jul 2023 06:27:33 -0700 (PDT) Received: from x-wing.lan ([49.207.50.231]) by smtp.gmail.com with ESMTPSA id x52-20020a056a000bf400b00682ba300cd1sm11485918pfu.29.2023.07.26.06.27.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jul 2023 06:27:32 -0700 (PDT) From: Amit Pundir To: Bjorn Andersson , Andy Gross , Dmitry Baryshkov , Rob Herring , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Caleb Connolly , Bryan Donoghue , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , Krishna Manikandan Cc: dri-devel , freedreno , linux-arm-msm , dt , lkml , stable@vger.kernel.org Subject: [PATCH v6 2/2] arm64: dts: qcom: sdm845-db845c: Mark cont splash memory region as reserved Date: Wed, 26 Jul 2023 18:57:19 +0530 Message-Id: <20230726132719.2117369-2-amit.pundir@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230726132719.2117369-1-amit.pundir@linaro.org> References: <20230726132719.2117369-1-amit.pundir@linaro.org> MIME-Version: 1.0 Author: Amit Pundir Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Adding a reserved memory region for the framebuffer memory (the splash memory region set up by the bootloader). It fixes a kernel panic (arm-smmu: Unhandled context fault at this particular memory region) reported on DB845c running v5.10.y. Cc: stable@vger.kernel.org # v5.10+ Reviewed-by: Caleb Connolly Signed-off-by: Amit Pundir Acked-by: Krzysztof Kozlowski --- v6: Collected review tag, updated commit message for the context and marked for stable kernel versions. v5: Re-sending with updated dt-bindings patch in mdss-common schema. v4: Re-sending this along with a new dt-bindings patch to document memory-region property in qcom,sdm845-mdss schema and keep dtbs_check happy. v3: Point this reserved region to MDSS. v2: Updated commit message. There was some dicussion on v1 but it didn't go anywhere, https://lore.kernel.org/linux-kernel/20230124182857.1524912-1-amit.pundir@linaro.org/T/#u. The general consensus is that this memory should be freed and be made resuable but that (releasing this piece of memory) has been tried before and it is not trivial to return the reserved memory node to the system RAM pool in this case. arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts index d6b464cb61d6..f546f6f57c1e 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts @@ -101,6 +101,14 @@ hdmi_con: endpoint { }; }; + reserved-memory { + /* Cont splash region set up by the bootloader */ + cont_splash_mem: framebuffer@9d400000 { + reg = <0x0 0x9d400000 0x0 0x2400000>; + no-map; + }; + }; + lt9611_1v8: lt9611-vdd18-regulator { compatible = "regulator-fixed"; regulator-name = "LT9611_1V8"; @@ -506,6 +514,7 @@ &i2c14 { }; &mdss { + memory-region = <&cont_splash_mem>; status = "okay"; };