From patchwork Fri Jul 28 14:58:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13332025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77F46C001DE for ; Fri, 28 Jul 2023 14:58:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AB2C610E70D; Fri, 28 Jul 2023 14:58:36 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3633110E70D for ; Fri, 28 Jul 2023 14:58:35 +0000 (UTC) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qPOvI-00030N-Eg; Fri, 28 Jul 2023 16:58:32 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1qPOvH-002jOA-PO; Fri, 28 Jul 2023 16:58:31 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qPOvG-008WkM-VO; Fri, 28 Jul 2023 16:58:30 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Javier Martinez Canillas , David Airlie , Daniel Vetter Subject: [PATCH 1/3] drm/ssd130x: Print the PWM's label instead of its number Date: Fri, 28 Jul 2023 16:58:22 +0200 Message-Id: <20230728145824.616687-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230728145824.616687-1-u.kleine-koenig@pengutronix.de> References: <20230728145824.616687-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=989; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=9uB1OXNNW+zwAUhmyEf2cN1xF00OtdK5L16qJeKgSQM=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkw9eJT4BCwPcaZJGa4Q/dqalhhcq0hMX6If5wb Jllnj0VezCJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZMPXiQAKCRCPgPtYfRL+ Tj1cB/4ggve2JqBzDjsNtkvhToVeWOqiO8T7twsKR1y5BRuRfE2pdpP6ixKkBCtS6Abifcxx6cV cgiK4k6QpG7P/tYK2cGFcVzj6YZ1TZ8IHh91WIvDjeddzlwkb3ekAO+Pev3rN1lUj7oe94PnnlR 25+/DTQz6CZ4I0hooCXQ72RcCLW1pW8YWy717AUWfRMl88NXHIhMmul1bI7j6d7Cfkli69Ighwy S1Wlu5c0P7hoF7XYKOx8Ds4he2o6a+RJjf/KjKRmi5Fdw5DjD/A5O6jJVmSnmkbpXY5WjTRewyA RAAIvvHKzjWxlRq81Pf2XbfNovG7NB5aXsOnhfYOI6xhoVco X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel@pengutronix.de, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" struct pwm_device::pwm is a write-only variable in the pwm core and used nowhere apart from this and another dev_dbg. So it isn't useful to identify the used PWM. Emit the PWM's label instead in the debug message. Signed-off-by: Uwe Kleine-König Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/solomon/ssd130x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/solomon/ssd130x.c b/drivers/gpu/drm/solomon/ssd130x.c index 8cbf5aa66e19..6aa3baefabe4 100644 --- a/drivers/gpu/drm/solomon/ssd130x.c +++ b/drivers/gpu/drm/solomon/ssd130x.c @@ -244,8 +244,8 @@ static int ssd130x_pwm_enable(struct ssd130x_device *ssd130x) /* Enable the PWM */ pwm_enable(ssd130x->pwm); - dev_dbg(dev, "Using PWM%d with a %lluns period.\n", - ssd130x->pwm->pwm, pwm_get_period(ssd130x->pwm)); + dev_dbg(dev, "Using PWM %s with a %lluns period.\n", + ssd130x->pwm->label, pwm_get_period(ssd130x->pwm)); return 0; } From patchwork Fri Jul 28 14:58:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13332027 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EA84AC001DE for ; Fri, 28 Jul 2023 14:58:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3E1DB10E711; Fri, 28 Jul 2023 14:58:52 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5A18310E711 for ; Fri, 28 Jul 2023 14:58:47 +0000 (UTC) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qPOvL-00030O-ON; Fri, 28 Jul 2023 16:58:35 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1qPOvH-002jOE-W9; Fri, 28 Jul 2023 16:58:32 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qPOvH-008WkP-D3; Fri, 28 Jul 2023 16:58:31 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Helge Deller , Andy Shevchenko , Javier Martinez Canillas , Benjamin Mugnier , Thomas Zimmermann , Jilin Yuan Subject: [PATCH 2/3] video: fbdev: ssd1307fb: Print the PWM's label instead of its number Date: Fri, 28 Jul 2023 16:58:23 +0200 Message-Id: <20230728145824.616687-3-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230728145824.616687-1-u.kleine-koenig@pengutronix.de> References: <20230728145824.616687-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1002; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=0P1/KpGQ9f8J6bY99RI2pVsdqUOU6FI+1+net6ZiEy4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkw9eKLLisLuS+D7TCHzgyRAnVPUSEs/f6CMa59 mfDk0tQp5OJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZMPXigAKCRCPgPtYfRL+ Tp7nB/4ud4oh/0jcHDyNPNBCOVkB7D5/nUUG87YrdL+ja3WHQHXhqfOln5fZEYDcwGa/5e4qKp3 xZZL9uWd+6+82o0Lbk8fWHgpN1DPfPXU4/B95qbpsBxTpPfMQTXekgEGrAravU9C1xxTDu2+ibG XnzQRGTD54M+OuCWdzu+o6qgmx26LU6uTjGKK/Mna2KEnNYSSJ5PFo7GoZAKehNRhG2w3O/+OLr sPPgyujzVBmwopYr6j07RxQyWiJvBGaPyOmPYXbC02lGldp4WhuNUJ5AuEk7ElR6L7zYC1PCqmB jnCRTDpVZrmyCrL220uHKYEIvR8cgAiMlbVqpPdMhQlId4dY X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, kernel@pengutronix.de, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" struct pwm_device::pwm is a write-only variable in the pwm core and used nowhere apart from this and another dev_dbg. So it isn't useful to identify the used PWM. Emit the PWM's label instead in the debug message. Signed-off-by: Uwe Kleine-König Reviewed-by: Javier Martinez Canillas --- drivers/video/fbdev/ssd1307fb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/ssd1307fb.c b/drivers/video/fbdev/ssd1307fb.c index 11c373798279..46881a691549 100644 --- a/drivers/video/fbdev/ssd1307fb.c +++ b/drivers/video/fbdev/ssd1307fb.c @@ -399,8 +399,8 @@ static int ssd1307fb_init(struct ssd1307fb_par *par) /* Enable the PWM */ pwm_enable(par->pwm); - dev_dbg(&par->client->dev, "Using PWM%d with a %lluns period.\n", - par->pwm->pwm, pwm_get_period(par->pwm)); + dev_dbg(&par->client->dev, "Using PWM %s with a %lluns period.\n", + par->pwm->label, pwm_get_period(par->pwm)); } /* Set initial contrast */