From patchwork Sun Jul 30 21:57:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 13333548 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D5A8EB64DD for ; Sun, 30 Jul 2023 21:58:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5A37510E146; Sun, 30 Jul 2023 21:58:21 +0000 (UTC) Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 85C0610E140; Sun, 30 Jul 2023 21:58:14 +0000 (UTC) Received: by mail-il1-x12d.google.com with SMTP id e9e14a558f8ab-3490ebe5286so4632985ab.1; Sun, 30 Jul 2023 14:58:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690754294; x=1691359094; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=emw84RlF3bNbcIqSZRMxOIrvwHQ8jc+o13j5yyfv6Es=; b=XzBrK3fiUVV+Qw4FCBmhAFwh1M0BxMpb4QGOJCxG7oDqhsffTtg/qFqxOVRqkaqopU MLw7n8YGvbNiZ6khvhNn+Jt/Z3E+WMCbucPJv2IQ4lolvyur+F5jlnJarCaSME/UkEku 9F6Ja5BmoEkjw3Wr2+chJjJaBE+ONMPflSSvi2Tl+Gqmb2+wSbGpHDqUbJUPKdMr4rdh 5qBAI6BIgkp+++m+RHQShsg9LkzNA2p44oaJDMiOGM8bkXK6SO7+lWEEo2a/ncPoyRfX XB9cWkYe2V2JmnCJ5S5jV0DVJLrbsFyJVNuO4xx2K88BM0faTo0inK4m4XzVUR4czgsv rykQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690754294; x=1691359094; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=emw84RlF3bNbcIqSZRMxOIrvwHQ8jc+o13j5yyfv6Es=; b=kUmtWLyxbngDXbG13Jf5uTMInZQ9jHKHcLxHhmtsoefcmy/KmDAk/ongvJpC2RtXs3 WQ6ERaR50+y9yLYfkF169+Dalb59pItsPWpqt8pRACELN4kXn4VBlEmPRikDWLhKa9v5 p/z+jc1CLL9E/H+W1RKhNUUuwxBpz9/heB6HoYefSPLz3y9ZagH+rlZDgMvoECvSO+7W c3jBWd3fU4GYiukibMoZCcn0PBQC4zCwQYcUJBEsJz8WnkZH0DsUICheYZDiLSJNGJYa 44qWDfMto+DLLSyS2aZUVk7ITj/mvqZV3VmVF4jtywlsK8A7of4KwM0SoTGzXEsEDub4 PH+g== X-Gm-Message-State: ABy/qLZSFNVzCUI8r+0sn6/yFmNoBLu0O6B+Q4W0mqnJtDyzupy+BWUn f+uokgMaFEdSf3fOYdqYikM= X-Google-Smtp-Source: APBJJlH6xhZtbgvn4c0B+kMVYzCY+kgywJH6WENm9VN8LteRzuOqbTqqERlfoNBE7GYEfulDvwvIaA== X-Received: by 2002:a05:6e02:931:b0:348:c57f:b016 with SMTP id o17-20020a056e02093100b00348c57fb016mr5734702ilt.3.1690754293582; Sun, 30 Jul 2023 14:58:13 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id e18-20020a92de52000000b003424b3d6d37sm2747520ilr.24.2023.07.30.14.58.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jul 2023 14:58:13 -0700 (PDT) From: Jim Cromie To: daniel@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: [PATCH 1/5] drm_dbg: add trailing newlines to remaining callsites Date: Sun, 30 Jul 2023 15:57:50 -0600 Message-ID: <20230730215758.54010-2-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230730215758.54010-1-jim.cromie@gmail.com> References: <20230730215758.54010-1-jim.cromie@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Edmund Dea , Maxime Ripard , Thomas Zimmermann , Anitha Chrisanthus Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" All callers should uniformly include a trailing newline, the vast majority already do: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in this and next commits (split for easy acks). No functional changes. Signed-off-by: Jim Cromie --- drivers/gpu/drm/kmb/kmb_crtc.c | 10 +++++----- drivers/gpu/drm/kmb/kmb_plane.c | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/kmb/kmb_crtc.c b/drivers/gpu/drm/kmb/kmb_crtc.c index 647872f65bff..a58baf25322d 100644 --- a/drivers/gpu/drm/kmb/kmb_crtc.c +++ b/drivers/gpu/drm/kmb/kmb_crtc.c @@ -94,7 +94,7 @@ static void kmb_crtc_set_mode(struct drm_crtc *crtc, vm.hback_porch = 0; vm.hsync_len = 28; - drm_dbg(dev, "%s : %dactive height= %d vbp=%d vfp=%d vsync-w=%d h-active=%d h-bp=%d h-fp=%d hsync-l=%d", + drm_dbg(dev, "%s : %dactive height= %d vbp=%d vfp=%d vsync-w=%d h-active=%d h-bp=%d h-fp=%d hsync-l=%d\n", __func__, __LINE__, m->crtc_vdisplay, vm.vback_porch, vm.vfront_porch, vm.vsync_len, m->crtc_hdisplay, vm.hback_porch, @@ -194,24 +194,24 @@ static enum drm_mode_status int vfp = mode->vsync_start - mode->vdisplay; if (mode->vdisplay < KMB_CRTC_MAX_HEIGHT) { - drm_dbg(dev, "height = %d less than %d", + drm_dbg(dev, "height = %d less than %d\n", mode->vdisplay, KMB_CRTC_MAX_HEIGHT); return MODE_BAD_VVALUE; } if (mode->hdisplay < KMB_CRTC_MAX_WIDTH) { - drm_dbg(dev, "width = %d less than %d", + drm_dbg(dev, "width = %d less than %d\n", mode->hdisplay, KMB_CRTC_MAX_WIDTH); return MODE_BAD_HVALUE; } refresh = drm_mode_vrefresh(mode); if (refresh < KMB_MIN_VREFRESH || refresh > KMB_MAX_VREFRESH) { - drm_dbg(dev, "refresh = %d less than %d or greater than %d", + drm_dbg(dev, "refresh = %d less than %d or greater than %d\n", refresh, KMB_MIN_VREFRESH, KMB_MAX_VREFRESH); return MODE_BAD; } if (vfp < KMB_CRTC_MIN_VFP) { - drm_dbg(dev, "vfp = %d less than %d", vfp, KMB_CRTC_MIN_VFP); + drm_dbg(dev, "vfp = %d less than %d\n", vfp, KMB_CRTC_MIN_VFP); return MODE_BAD; } diff --git a/drivers/gpu/drm/kmb/kmb_plane.c b/drivers/gpu/drm/kmb/kmb_plane.c index 9e0562aa2bcb..308bd1cb50c8 100644 --- a/drivers/gpu/drm/kmb/kmb_plane.c +++ b/drivers/gpu/drm/kmb/kmb_plane.c @@ -78,7 +78,7 @@ static unsigned int check_pixel_format(struct drm_plane *plane, u32 format) * plane configuration is not supported. */ if (init_disp_cfg.format && init_disp_cfg.format != format) { - drm_dbg(&kmb->drm, "Cannot change format after initial plane configuration"); + drm_dbg(&kmb->drm, "Cannot change format after initial plane configuration\n"); return -EINVAL; } for (i = 0; i < plane->format_count; i++) { @@ -124,7 +124,7 @@ static int kmb_plane_atomic_check(struct drm_plane *plane, if ((init_disp_cfg.width && init_disp_cfg.height) && (init_disp_cfg.width != fb->width || init_disp_cfg.height != fb->height)) { - drm_dbg(&kmb->drm, "Cannot change plane height or width after initial configuration"); + drm_dbg(&kmb->drm, "Cannot change plane height or width after initial configuration\n"); return -EINVAL; } can_position = (plane->type == DRM_PLANE_TYPE_OVERLAY); @@ -375,7 +375,7 @@ static void kmb_plane_atomic_update(struct drm_plane *plane, spin_lock_irq(&kmb->irq_lock); if (kmb->kmb_under_flow || kmb->kmb_flush_done) { spin_unlock_irq(&kmb->irq_lock); - drm_dbg(&kmb->drm, "plane_update:underflow!!!! returning"); + drm_dbg(&kmb->drm, "plane_update:underflow!!!! returning\n"); return; } spin_unlock_irq(&kmb->irq_lock); From patchwork Sun Jul 30 21:57:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 13333552 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 531F5C001DE for ; Sun, 30 Jul 2023 21:58:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9ED7210E14D; Sun, 30 Jul 2023 21:58:31 +0000 (UTC) Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 323A810E148; Sun, 30 Jul 2023 21:58:20 +0000 (UTC) Received: by mail-io1-xd2d.google.com with SMTP id ca18e2360f4ac-790a590237aso27568039f.3; Sun, 30 Jul 2023 14:58:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690754299; x=1691359099; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nOewQfiuna8cVbGW5XrkGFy/hH53YPAnw6xDAt3LB98=; b=DKqR8ijCyupw8t6lZBwoDKFigkZROGJMEnXL0h+oDYIWwrL9txDkSZwkw8qDxS3soa c3XjOLuZrGWsm9OD3KHhrpaHR8GLxe/CB5Ro1EaU9VacZqveIVmsH8CsmTBO++Xaw043 S9c6oT2auG+ybCgccn4OLLiMrn6/XVSvAF3xW6fHj3I96dLrXCCEGBqomm+i4JrtxKNP 4IzSucxKUjtCeXcpYBmuwY5QKkQKoRM3oL5rXZFv2h34c6/mpHNp06uALNOSgH9FacqC 9CA1m/gl3qLd2CeJGFNDiLv4DsucE5zaM45Bd6PL+T/8Hi3WkinQ5SEFRhcOE5+BRjef 0hQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690754299; x=1691359099; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nOewQfiuna8cVbGW5XrkGFy/hH53YPAnw6xDAt3LB98=; b=Vho84KwTpM7lKtfsMA2BcN9aOryPXkRRbOZt5Z7P4l2haEVjUYuKzjXJfDlHoeV40H 3P8YB8qvVJJI7MnSRDq8a/ELyVU/6ojlVCsNQX46zUDQ+1iSr2jUJc65AleTYExA3C6J 8mGrxwobdfCFNzSSWvrFb4qZDvMbeQRBzCSfJURzwAl7QxQ0gqcGA+maea61t2eg98xv Iws1WKvVdXXoQ3FFGz7QvRCD494J9L2eUF2BZiXzIdRCXZGs5FdxKNsBz1zrreU5VWsp 03LAIcUtKq8z8KLdxYw9RGdP23hrm8zGRgx5ctgn0nxxgcclPAEJ3T0AsBBPQ0gss4A8 5yyQ== X-Gm-Message-State: ABy/qLavlYB43XugLUDKA8EVCRxxkLXDTBw+bgr0BMwG1Nt9p7gNAur2 GSH7+fTexEv/q6xu+K6d29E= X-Google-Smtp-Source: APBJJlE+/l1vuBJeosdUA7YLF9Qwd6Adbkqlh0UuNChyRu2idYwLmWELfaF8uOq6UyjwQhIZGytVZw== X-Received: by 2002:a05:6e02:134e:b0:340:8cb1:aaa8 with SMTP id k14-20020a056e02134e00b003408cb1aaa8mr6815096ilr.21.1690754299458; Sun, 30 Jul 2023 14:58:19 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id e18-20020a92de52000000b003424b3d6d37sm2747520ilr.24.2023.07.30.14.58.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jul 2023 14:58:19 -0700 (PDT) From: Jim Cromie To: daniel@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: [PATCH 2/5] drm_dbg: add trailing newlines Date: Sun, 30 Jul 2023 15:57:51 -0600 Message-ID: <20230730215758.54010-3-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230730215758.54010-1-jim.cromie@gmail.com> References: <20230730215758.54010-1-jim.cromie@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Tvrtko Ursulin , "Jason A. Donenfeld" , Mika Kahola , Lucas De Marchi , Chris Wilson , Andrzej Hajda , Daniele Ceraolo Spurio , Maxime Ripard , Thomas Zimmermann , Rodrigo Vivi , Niranjana Vishwanathapura , Matthew Auld Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Signed-off-by: Jim Cromie --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c index 3a7b98837516..993ba9f01018 100644 --- a/drivers/gpu/drm/i915/display/intel_ddi.c +++ b/drivers/gpu/drm/i915/display/intel_ddi.c @@ -3808,7 +3808,7 @@ static int intel_ddi_compute_config_late(struct intel_encoder *encoder, struct drm_connector *connector = conn_state->connector; u8 port_sync_transcoders = 0; - drm_dbg_kms(&i915->drm, "[ENCODER:%d:%s] [CRTC:%d:%s]", + drm_dbg_kms(&i915->drm, "[ENCODER:%d:%s] [CRTC:%d:%s]\n", encoder->base.base.id, encoder->base.name, crtc_state->uapi.crtc->base.id, crtc_state->uapi.crtc->name); diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c index 3aeede6aee4d..c7daae828792 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c @@ -1428,7 +1428,7 @@ eb_relocate_entry(struct i915_execbuffer *eb, if (unlikely(reloc->write_domain & (reloc->write_domain - 1))) { drm_dbg(&i915->drm, "reloc with multiple write domains: " "target %d offset %d " - "read %08x write %08x", + "read %08x write %08x\n", reloc->target_handle, (int) reloc->offset, reloc->read_domains, @@ -1439,7 +1439,7 @@ eb_relocate_entry(struct i915_execbuffer *eb, & ~I915_GEM_GPU_DOMAINS)) { drm_dbg(&i915->drm, "reloc with read/write non-GPU domains: " "target %d offset %d " - "read %08x write %08x", + "read %08x write %08x\n", reloc->target_handle, (int) reloc->offset, reloc->read_domains, From patchwork Sun Jul 30 21:57:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 13333549 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC00BC001DE for ; Sun, 30 Jul 2023 21:58:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8A8BD10E1D0; Sun, 30 Jul 2023 21:58:29 +0000 (UTC) Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 09BCE10E148; Sun, 30 Jul 2023 21:58:23 +0000 (UTC) Received: by mail-il1-x12e.google.com with SMTP id e9e14a558f8ab-3490920531cso13723025ab.1; Sun, 30 Jul 2023 14:58:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690754302; x=1691359102; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dzT1NtmhVPgMEzc8/Vu/DYGCtAi6F3prLfzQtzunD4A=; b=i0VV1Pxf7fG96sx0/4My6LgaDnMdoakFvgPb0GqVsaBE0OE88LPAs1C1z/LFiLzGY5 tK1P659w0nu2hKiaVoiKdy0SSV51ZlEFs7/CvGJkv6PZFbBdo/R3QRsLeXdRm7XDC7O9 wdfHH3f0+y2lP3D4FCSXCk8XG7edQ5vLizkTzo3oJESZdEuVmPQAuLS37O0S5Smj3X5w 7omb+y63UjShSSAZwWtxVTQuLG+fBkZSNtQrEhVlp8snane6OWnw89sObWaAS8FCbao2 fVuSfXU/JV8oMmCqhR0azQwVHqLzvgLTHx2O7JPpxlBqAO6ok++yOGD8Jat+Qlr4jLNA /YNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690754302; x=1691359102; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dzT1NtmhVPgMEzc8/Vu/DYGCtAi6F3prLfzQtzunD4A=; b=PjF19upaFUQ5vNGFZJxjre7OzStfqhn1eXz+64rV4d+d4Sfn09T1Z793Roc8ZDetK0 ostg2klGDoJwb5pDvu3UxnhcgEuH8bGQtG4pTcqNKFUfGDKbVar6qOwko6iyWcK9k7bz uYIF7CO1Qm9/Ky40Hjk7GI6rip7fc/OVQg+XdJROVUHFRzR9WEJxdNDzz8YTeqh48a+j 8ovseDir/SWphghuHyVD+hRU7XksLMqt2b9+j4jxR0LCADt9mz069Cva8NJtejSAD3Fc rVV2oCyUVm8yc7k+Z3BYg3aUfUUvtaX2aL7b8VfoXfjrMOmn7fwumTULULavEDlXUQrC mVDw== X-Gm-Message-State: ABy/qLZtOsfP1Mu7HP+D2wnf8IyTCJdhcsFq5DzumeZ91s+QcP7aH1FJ baLO2EfZlyL7J/33iUMUJxA= X-Google-Smtp-Source: APBJJlH4diQF/gKGaFZFV2noWGnmxyr7j4k1TEOXzKb7Z048RyRdykHNxKRIZVn7OfF540vKITQnhg== X-Received: by 2002:a05:6e02:218d:b0:346:d51:9922 with SMTP id j13-20020a056e02218d00b003460d519922mr8975282ila.13.1690754302289; Sun, 30 Jul 2023 14:58:22 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id e18-20020a92de52000000b003424b3d6d37sm2747520ilr.24.2023.07.30.14.58.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jul 2023 14:58:21 -0700 (PDT) From: Jim Cromie To: daniel@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: [PATCH 3/5] drm_dbg: add trailing newlines Date: Sun, 30 Jul 2023 15:57:52 -0600 Message-ID: <20230730215758.54010-4-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230730215758.54010-1-jim.cromie@gmail.com> References: <20230730215758.54010-1-jim.cromie@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, Sean Paul , Abhinav Kumar , Maxime Ripard , Thomas Zimmermann , linux-arm-msm@vger.kernel.org, Dmitry Baryshkov Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Signed-off-by: Jim Cromie --- drivers/gpu/drm/msm/msm_fb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_fb.c b/drivers/gpu/drm/msm/msm_fb.c index e3f61c39df69..80166f702a0d 100644 --- a/drivers/gpu/drm/msm/msm_fb.c +++ b/drivers/gpu/drm/msm/msm_fb.c @@ -89,7 +89,7 @@ int msm_framebuffer_prepare(struct drm_framebuffer *fb, for (i = 0; i < n; i++) { ret = msm_gem_get_and_pin_iova(fb->obj[i], aspace, &msm_fb->iova[i]); - drm_dbg_state(fb->dev, "FB[%u]: iova[%d]: %08llx (%d)", + drm_dbg_state(fb->dev, "FB[%u]: iova[%d]: %08llx (%d)\n", fb->base.id, i, msm_fb->iova[i], ret); if (ret) return ret; @@ -176,7 +176,7 @@ static struct drm_framebuffer *msm_framebuffer_init(struct drm_device *dev, const struct msm_format *format; int ret, i, n; - drm_dbg_state(dev, "create framebuffer: mode_cmd=%p (%dx%d@%4.4s)", + drm_dbg_state(dev, "create framebuffer: mode_cmd=%p (%dx%d@%4.4s)\n", mode_cmd, mode_cmd->width, mode_cmd->height, (char *)&mode_cmd->pixel_format); @@ -232,7 +232,7 @@ static struct drm_framebuffer *msm_framebuffer_init(struct drm_device *dev, refcount_set(&msm_fb->dirtyfb, 1); - drm_dbg_state(dev, "create: FB ID: %d (%p)", fb->base.id, fb); + drm_dbg_state(dev, "create: FB ID: %d (%p)\n", fb->base.id, fb); return fb; From patchwork Sun Jul 30 21:57:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 13333551 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9C62C001DC for ; Sun, 30 Jul 2023 21:58:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0456910E16E; Sun, 30 Jul 2023 21:58:31 +0000 (UTC) Received: from mail-il1-x133.google.com (mail-il1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) by gabe.freedesktop.org (Postfix) with ESMTPS id 18DA910E14D; Sun, 30 Jul 2023 21:58:24 +0000 (UTC) Received: by mail-il1-x133.google.com with SMTP id e9e14a558f8ab-3491516c4aeso1416575ab.1; Sun, 30 Jul 2023 14:58:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690754303; x=1691359103; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vu0ECoPsGxDrhExN3brXHjUi2LDDzR+FiP6BVL6w+Kw=; b=h2LpsYBPFywLz1hFWTqus0/HFnW3Z94Zi07PcYMQkZiem7z0ylk17/7KsTQPPlC49J WwWEMAsnKjGxik3r9XXI45OgJR2XTvUZ+dJRbDKGMNvD2iQdJkySUFNB3SnqG1jmV4Av ZNfDadE3pOeeTc3WclrdH2Fjw9mazeO0r+rBnVebI5Rvp0r7HhgpL9n0Kg5vzpnWu7mv wtwzKAbSxAHbXfPEEFYMrnL3Ky0XmLv2ukbzDgZkUBX1MPu3CX46st9FWTMU1vn0jJRA h/YUn7AsWV81jr8SmGici+CfPXznEghYrzftC3PmSbagKM+5dbAHRH2EHLFZhWm8HcZh D2wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690754303; x=1691359103; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vu0ECoPsGxDrhExN3brXHjUi2LDDzR+FiP6BVL6w+Kw=; b=Mc7/OP2bH9Y/CQxXeGaFBb2qXawVJxmem5G/CBdUkmI1uoKEwlAA1YIlDXkkSycoH9 pRGOERs2oyP5lO+Ooi8KYvpEXPqw8o+jV2WxjX+RxzPOWfskQe9+yP9Vzp0OHPi3zaRc pu8WuUPar5eINKhv3Orosy7cuqSsMrIqncA/lrb8OMMtIAo6ojBOGvrsBnQU4w/azO33 uaFzEtzZxoWmy5rF4LMhGSOxryljqwGNAxE8u4fkKGnrSrjX2U9EQxN0gExaJCc/vxA2 bJ2XmOFQNy/5kFa3S7+0HDAihqDZDWNPjUxTFu9M8LBKzWYqnoauOfc0tPWsXcu97yah OYVw== X-Gm-Message-State: ABy/qLYseOx27bDmONMG8HlYI+Tro5bvCGXt8T1R4NjSJpWN1DQ/mNkW P/qjJSyK1QViQcXgiG4xNwyK1YFlL0JT9w== X-Google-Smtp-Source: APBJJlGFctHBx6g16uBxY6S5P569mXmHB6D7A2XcVTPreJQ0slf/YQc2sQUGDPhGIc2DYrEGBMMm2g== X-Received: by 2002:a05:6e02:ed3:b0:348:1a1f:5542 with SMTP id i19-20020a056e020ed300b003481a1f5542mr6325346ilk.17.1690754303337; Sun, 30 Jul 2023 14:58:23 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id e18-20020a92de52000000b003424b3d6d37sm2747520ilr.24.2023.07.30.14.58.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jul 2023 14:58:22 -0700 (PDT) From: Jim Cromie To: daniel@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: [PATCH 4/5] drm_dbg: add trailing newlines Date: Sun, 30 Jul 2023 15:57:53 -0600 Message-ID: <20230730215758.54010-5-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230730215758.54010-1-jim.cromie@gmail.com> References: <20230730215758.54010-1-jim.cromie@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emma Anholt , Maxime Ripard , Thomas Zimmermann Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Signed-off-by: Jim Cromie --- drivers/gpu/drm/vc4/vc4_crtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index bef9d45ef1df..959123759711 100644 --- a/drivers/gpu/drm/vc4/vc4_crtc.c +++ b/drivers/gpu/drm/vc4/vc4_crtc.c @@ -592,7 +592,7 @@ static void vc4_crtc_atomic_disable(struct drm_crtc *crtc, struct drm_encoder *encoder = vc4_get_crtc_encoder(crtc, old_state); struct drm_device *dev = crtc->dev; - drm_dbg(dev, "Disabling CRTC %s (%u) connected to Encoder %s (%u)", + drm_dbg(dev, "Disabling CRTC %s (%u) connected to Encoder %s (%u)\n", crtc->name, crtc->base.id, encoder->name, encoder->base.id); require_hvs_enabled(dev); @@ -620,7 +620,7 @@ static void vc4_crtc_atomic_enable(struct drm_crtc *crtc, struct vc4_encoder *vc4_encoder = to_vc4_encoder(encoder); int idx; - drm_dbg(dev, "Enabling CRTC %s (%u) connected to Encoder %s (%u)", + drm_dbg(dev, "Enabling CRTC %s (%u) connected to Encoder %s (%u)\n", crtc->name, crtc->base.id, encoder->name, encoder->base.id); if (!drm_dev_enter(dev, &idx)) From patchwork Sun Jul 30 21:57:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 13333550 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44572C04E69 for ; Sun, 30 Jul 2023 21:58:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B7E5D10E16B; Sun, 30 Jul 2023 21:58:29 +0000 (UTC) Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1298510E156; Sun, 30 Jul 2023 21:58:25 +0000 (UTC) Received: by mail-io1-xd30.google.com with SMTP id ca18e2360f4ac-790a590237aso27571139f.3; Sun, 30 Jul 2023 14:58:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690754304; x=1691359104; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zbdMUo5HBcvY3eA/Wfik+1Hzr5RoZnPa0wj8fbM2oVc=; b=agVaMhk3pEDzjsQ5PJyT8TavFw+ZA1YIJ4H/s3iaFPJoI8A+JU9zgKcNSrJCgxUl/r gYWsjp9fZNe4vt7RemD5oACo4VCjF07da+eVPFlVJIkfktYDXcy5Oq+0ekv9WXTj7pcm hmEnSEYYhhmntvlDW4g70h2LR2HkvQn5FqAST7z6k08AS8fAEwVkjuN8tRLiIF0a5ZIV zqZnaBhzbuwwTxWL4loRMEodWBeftbndPQeDTMmB1/vwK4WwDkrY7l5AJVSHTEYTFO29 s5w0iqu/j3yx3l/WX3aD+U1AhW9tHhIrbBDMXu+ZSBw+XLzelPALaICnC91VG1juNtbi c5/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690754304; x=1691359104; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zbdMUo5HBcvY3eA/Wfik+1Hzr5RoZnPa0wj8fbM2oVc=; b=eul4y24WC/BOoZcBOL5LdVrLRg9Y2ADh+3GcKsukRL8YlhyKNhijG7WhyMqQPKyhI0 n0pBdBySwxmt5sJ5BSoVQJ8DGSkObxIUCzOayhcMqKtaAPCxOkhv8VmZJVBVKyNvWg0N ekOphuFcYbZiL0zSI8cdeXc5jXkEEfn7rGhAogDMs+JeF3u4y2ytVQpPQin/K6+fmIEo fVQQvlCAbJKJ5xv/es185iXK1Q9FmNzpLr9ueiowX4AL1iKkaCMCtgAdDbQQJ5orPkjO ipT6C3XGlQ5/fG4YchSDtjgIy7WWlaPbe58tlicrrA++FKhlitLfuU7HBSt0r3RciC1t XkLw== X-Gm-Message-State: ABy/qLaGxDdmPhiPPZbezGo8V6KGQD+Not2SX9eUpbJcKHb4Au3zGrFQ FcRKm/XWC4r1nLVGI5jqOQ8= X-Google-Smtp-Source: APBJJlHWzXyQhdHLBN6Z9svWK4MZ1KGWPcL9B/eTSCudiAIzkRE+6jckTWaAdZVRO5La86sBKnRHQw== X-Received: by 2002:a05:6e02:1aad:b0:346:50ce:d602 with SMTP id l13-20020a056e021aad00b0034650ced602mr8965298ilv.1.1690754304330; Sun, 30 Jul 2023 14:58:24 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id e18-20020a92de52000000b003424b3d6d37sm2747520ilr.24.2023.07.30.14.58.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 30 Jul 2023 14:58:23 -0700 (PDT) From: Jim Cromie To: daniel@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: [PATCH 5/5] drm_dbg: add trailing newlines Date: Sun, 30 Jul 2023 15:57:54 -0600 Message-ID: <20230730215758.54010-6-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230730215758.54010-1-jim.cromie@gmail.com> References: <20230730215758.54010-1-jim.cromie@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Zimmermann , Maxime Ripard Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Signed-off-by: Jim Cromie --- drivers/gpu/drm/drm_connector.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index 48df7a5ea503..39eab45649c8 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -2868,7 +2868,9 @@ int drm_mode_getconnector(struct drm_device *dev, void *data, dev->mode_config.max_width, dev->mode_config.max_height); else - drm_dbg_kms(dev, "User-space requested a forced probe on [CONNECTOR:%d:%s] but is not the DRM master, demoting to read-only probe", + drm_dbg_kms(dev, + "User-space requested a forced probe on [CONNECTOR:%d:%s] " + "but is not the DRM master, demoting to read-only probe\n", connector->base.id, connector->name); }