From patchwork Tue Aug 1 14:01:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: wangzhu X-Patchwork-Id: 13336759 X-Patchwork-Delegate: dipenp@nvidia.com Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F55D111E for ; Tue, 1 Aug 2023 14:01:52 +0000 (UTC) Received: from dggpeml500025.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4RFcBz1CP4zNmLw; Tue, 1 Aug 2023 21:58:19 +0800 (CST) Received: from ubuntu1804.huawei.com (10.67.174.202) by dggpeml500025.china.huawei.com (7.185.36.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 1 Aug 2023 22:01:44 +0800 From: Zhu Wang To: , , , , CC: Subject: [PATCH -next] hte: tegra-194: remove redundant dev_err_probe() Date: Tue, 1 Aug 2023 22:01:14 +0800 Message-ID: <20230801140114.257740-1-wangzhu9@huawei.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk X-Mailing-List: timestamp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Originating-IP: [10.67.174.202] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpeml500025.china.huawei.com (7.185.36.35) X-CFilter-Loop: Reflected When platform_get_irq() is called, the error message has been printed, so it need not to call dev_err_probe() to print error, we remove the redundant platform_get_irq(). Signed-off-by: Zhu Wang --- drivers/hte/hte-tegra194.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/hte/hte-tegra194.c b/drivers/hte/hte-tegra194.c index 06ef349a2265..01f416c881e6 100644 --- a/drivers/hte/hte-tegra194.c +++ b/drivers/hte/hte-tegra194.c @@ -730,7 +730,6 @@ static int tegra_hte_probe(struct platform_device *pdev) ret = platform_get_irq(pdev, 0); if (ret < 0) { - dev_err_probe(dev, ret, "failed to get irq\n"); return ret; } hte_dev->hte_irq = ret;