From patchwork Fri Feb 8 04:59:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nathan Chancellor X-Patchwork-Id: 10802419 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D2439922 for ; Fri, 8 Feb 2019 05:00:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B5BBE2DC58 for ; Fri, 8 Feb 2019 05:00:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A860C2DC60; Fri, 8 Feb 2019 05:00:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AF3EB2DC58 for ; Fri, 8 Feb 2019 05:00:14 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 4558F267483; Fri, 8 Feb 2019 06:00:12 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 2D715267492; Fri, 8 Feb 2019 06:00:09 +0100 (CET) Received: from mail-ed1-f68.google.com (mail-ed1-f68.google.com [209.85.208.68]) by alsa0.perex.cz (Postfix) with ESMTP id 927B22666B3 for ; Fri, 8 Feb 2019 06:00:06 +0100 (CET) Received: by mail-ed1-f68.google.com with SMTP id g4so1756292eds.4 for ; Thu, 07 Feb 2019 21:00:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nTcpChwmopYs8aEyjJhEMtiLIKLRzcFXiyjfHHM2XYU=; b=nMRnOqpc8wagCKJOHvkjrkHWpSt9WocYP4UoWP+xREBc8X7GOa5osbr53XZSEXM3cv fYHq2kj/3QWeWN3++oHPTtr/M5o1DWDdbBMKFvVjsjnsGLnSJusg3EpsilPYcE5liecL /IxWaHblGJawaIx2XGd0MlVvVCkF6SvTCiNNnoLTQAts9QucRIW8wEuxwlk84oIrdWue rpLnzZbRXSYzrPDRskiewi7xTR9MTHrxwoBIAEQdg0l8bm1YuS2eBsxaX+PhnWz0s3Zt a+YNj8C1q5nsb5SS5MgmnXEBZQ85aNQTzTODJgs/WZR7MWlaf2Mywh4DaXrec+8oOGs6 zX7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nTcpChwmopYs8aEyjJhEMtiLIKLRzcFXiyjfHHM2XYU=; b=Tj8EuhfDKpydjxTicSnIzAO0tObgQfTUSLPF/qDtADaRUb2bmq/vVn2zQK7k+95W6I ZTUZUZ/BEot10w8Qv2EzoasEQ85EU21j/+TJ39AgkMonjQqG2QXBin7pW7yWngZyjV7+ XF6znjXIzGCTC0GacmJe3JQeC8J4xtXutHEjAac5xgV6FOGgo/VePvR9FAsJ6/kmUDfV dYAybXxbHraevdg6Dt7Q2DNAycS0W/7InXjSvQSXNSSf8dmTGcrAAtbdvFtp9Uv8aN/W LHKnutf+K/ZXCBvMLKCmej/O7YM7jHYPMBD0dIdGwm7RdtJhHYjcGRngOaqH1xeaLBIa n14w== X-Gm-Message-State: AHQUAuZxEztihWLq36QQ9hxZbT+h4mNU1O2yxuYigTOHY/HJAsNndftA 0OAs1vV+COBKc6Fz+AKEe8U= X-Google-Smtp-Source: AHgI3IaynJB2LtcYd7NxS+sMp+e63V9RHzZ4eR95qkekDWDlvbUdxQWnqAtzeuDv3zQ0bWTKy2voGQ== X-Received: by 2002:a50:98a6:: with SMTP id j35mr15164991edb.141.1549602005401; Thu, 07 Feb 2019 21:00:05 -0800 (PST) Received: from localhost.localdomain ([2a01:4f9:2a:1fae::2]) by smtp.gmail.com with ESMTPSA id v11sm332287edy.49.2019.02.07.21.00.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Feb 2019 21:00:04 -0800 (PST) From: Nathan Chancellor To: Liam Girdwood , Mark Brown Date: Thu, 7 Feb 2019 21:59:18 -0700 Message-Id: <20190208045918.16799-1-natechancellor@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Patchwork-Bot: notify Cc: Paul Cercueil , alsa-devel@alsa-project.org, Nick Desaulniers , linux-kernel@vger.kernel.org, Nathan Chancellor Subject: [alsa-devel] [PATCH] ASoC: codecs: jz4725b: Remove unnecessary const qualifier X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP Clang warns: sound/soc/codecs/jz4725b.c:177:14: warning: duplicate 'const' declaration specifier [-Wduplicate-decl-specifier] static const SOC_VALUE_ENUM_SINGLE_DECL(jz4725b_codec_adc_src_enum, ^ include/sound/soc.h:356:2: note: expanded from macro 'SOC_VALUE_ENUM_SINGLE_DECL' SOC_VALUE_ENUM_DOUBLE_DECL(name, xreg, xshift, xshift, xmask, xtexts, xvalues) ^ include/sound/soc.h:353:2: note: expanded from macro 'SOC_VALUE_ENUM_DOUBLE_DECL' const struct soc_enum name = SOC_VALUE_ENUM_DOUBLE(xreg, xshift_l, xshift_r, xmask, \ ^ As it points out, SOC_VALUE_ENUM_DOUBLE_DECL has the const attribute in its definition so remove it here. Fixes: e9d97b05a80f ("ASoC: codecs: Add jz4725b-codec driver") Link: https://github.com/ClangBuiltLinux/linux/issues/354 Signed-off-by: Nathan Chancellor Reviewed-by: Nick Desaulniers --- sound/soc/codecs/jz4725b.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/soc/codecs/jz4725b.c b/sound/soc/codecs/jz4725b.c index e3dba92f30bd..5cc8c7ca24c6 100644 --- a/sound/soc/codecs/jz4725b.c +++ b/sound/soc/codecs/jz4725b.c @@ -174,12 +174,12 @@ static const char * const jz4725b_codec_adc_src_texts[] = { "Mic 1", "Mic 2", "Line In", "Mixer", }; static const unsigned int jz4725b_codec_adc_src_values[] = { 0, 1, 2, 3, }; -static const SOC_VALUE_ENUM_SINGLE_DECL(jz4725b_codec_adc_src_enum, - JZ4725B_CODEC_REG_CR3, - REG_CR3_INSEL_OFFSET, - REG_CR3_INSEL_MASK, - jz4725b_codec_adc_src_texts, - jz4725b_codec_adc_src_values); +static SOC_VALUE_ENUM_SINGLE_DECL(jz4725b_codec_adc_src_enum, + JZ4725B_CODEC_REG_CR3, + REG_CR3_INSEL_OFFSET, + REG_CR3_INSEL_MASK, + jz4725b_codec_adc_src_texts, + jz4725b_codec_adc_src_values); static const struct snd_kcontrol_new jz4725b_codec_adc_src_ctrl = SOC_DAPM_ENUM("Route", jz4725b_codec_adc_src_enum);