From patchwork Tue Aug 8 10:37:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thippeswamy Havalige X-Patchwork-Id: 13345930 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3089FC001B0 for ; Tue, 8 Aug 2023 10:38:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=D96LMhyz3KJM7qNCN/X0dyQpmkdc3krTISDoydau9DI=; b=AzRL0y/k0Ks+c5 VIVEmeeKLLhYnJXDxY/XZd3VjbTi3uv0oyV7Ftmgnx9zCzqnWQOh0oexOV5hURACJ0BfrP2QO5yzF ssG7q45J7zTmGDoVdg4yXN/DixP/5blq5Cnx2TI34JNOvagVuGYe5RrjPLlTiHtulvgylMk4/YMu5 8YPY44jUYtLYRcbpWvY8m/8R8es+feUHMauRGasD3+KquyjlyPa+zXq8dBPg2h/dXsAuahcUbvSfN XSvszWKgczkJE1fqpiGx8RmxJkzSk6N+9os/CNY2DF06dYYQOFYNdXSW3/k+tDBo1e3d1SF0LtVEF jG4ZiIpgNq0bUwl85lJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTK6B-002GAK-2g; Tue, 08 Aug 2023 10:37:59 +0000 Received: from mail-co1nam11on20609.outbound.protection.outlook.com ([2a01:111:f400:7eab::609] helo=NAM11-CO1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTK67-002G4w-0E for linux-arm-kernel@lists.infradead.org; Tue, 08 Aug 2023 10:37:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OF/4fIXj6mYG8b3Kl9wxht2UDtMP5MbQQ8rsNJTUnJ/MJGmmm6pyEHx4q7En7yq6H4x7KWYhJeRRIgsb++hV8gVeVgUoBd1/82Ud+7K5NSoPc/ySV0T/xpsjTSnVndU+YQPixSZrkhRSR3qcLtgnffBuNhJD3w2w/JWxbFpjnYqJK3g/RnMHNUc12E6DmtQL2kaWvfQKzikB+IqMRnC42xmPgG8y0pHTKTtdNDd9KQ8uXdHHymk4WRJ46Q8s/+mrLKRYWHcvYRdGqWH1K9eRjnVCYcj0Dp1NnKw50M0PaMvT38wSw3bl3CEXBNxYgahdkUED3S3qKpIjwNyYBrtn4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MT727cE5n5Z7p14SKUaU8uc+4dvWAuUo0kRSN4JV8OA=; b=DFaJdyGrd0QuoJgMlTjspru8dWlUwQNU0oBTAWjrRakprz3LaZI8PPikGoScFvQvh0RmdZZ8KF/ykUM6xC8cGjbIDYytQ+I8TKhokGn+Q8JGHomIHSRJ4OW77ggsuFupydMk4Wh5+pAwhZaVpLPjMZNJ5VVXSenikNs5iIfXh10uryKfrCLBhebUQzooLO9TXfB6LV+S1ecjz5GmRbpPzF4vFbiYflcS92x/EPZPEk8f7Fj/3aXqda3/rMmbtVEKAhnrIAAzV8t0CF0gzXwSw+MOXYpwO7+jgxIfmTVQMzf7gaHNZndbBvLmw+Ea5yILwljvcRcVQN3jLXV5xtisAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MT727cE5n5Z7p14SKUaU8uc+4dvWAuUo0kRSN4JV8OA=; b=4KJ4urDVqZMSyTshzMqGjfgmvuKlw5jQ/nknjHx6DtcERQgtiGEUmUuO+P4j4yvOSdjaj59NILrAnbBnFyS0FZDwY8hu07XkdR9dHnOT00YkUh3x9cbSoBu6+ruqlQTqBuEPgxOq5P06U76PTjYrJ2ePO/rMWOHT3mBlbMfKGDI= Received: from CY5PR15CA0041.namprd15.prod.outlook.com (2603:10b6:930:1b::31) by CY8PR12MB7513.namprd12.prod.outlook.com (2603:10b6:930:91::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.26; Tue, 8 Aug 2023 10:37:46 +0000 Received: from CY4PEPF0000E9D0.namprd03.prod.outlook.com (2603:10b6:930:1b:cafe::a4) by CY5PR15CA0041.outlook.office365.com (2603:10b6:930:1b::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27 via Frontend Transport; Tue, 8 Aug 2023 10:37:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Received: from SATLEXMB03.amd.com (165.204.84.17) by CY4PEPF0000E9D0.mail.protection.outlook.com (10.167.241.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6652.19 via Frontend Transport; Tue, 8 Aug 2023 10:37:46 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 8 Aug 2023 05:37:45 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 8 Aug 2023 03:37:45 -0700 Received: from xhdthippesw40.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Tue, 8 Aug 2023 05:37:42 -0500 From: Thippeswamy Havalige To: , , , , , CC: , , , , "Thippeswamy Havalige" Subject: [PATCH v2] PCI: xilinx-nwl: Remove unnecessary code which updates primary,secondary and sub-ordinate bus numbers. Date: Tue, 8 Aug 2023 16:07:30 +0530 Message-ID: <20230808103733.93707-1-thippeswamy.havalige@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D0:EE_|CY8PR12MB7513:EE_ X-MS-Office365-Filtering-Correlation-Id: 3169b7c3-bdca-4510-006c-08db97fb814f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BfQWTNRt9puot0FeQ/fZwxHzvDmMEyoZ1fLvguHUGoJHIglTSukc0lD1ZvRHfAnce/jAuptIR16YscS1gkY4YR2ApOw3ovvLELgf+At1ccx9ndnfkgs1BnjKQDbBZupJzV17qurkBYyQajSLed6uqUtHqsw07+5hYnkqHP7a158w1F1h08tXp86FaM46kMt/OWLx8fO6aU2gmrT6iPdIebffPAgEybaaYYLbcFOiwOviJxR8Bn7FvXO+TOlipD8t/97kB/CfZOZoShk0JVatUWBegvf5RZFBp9Hsb9wPtn2ffETiaAg3kGknR6hexn6oCglYLt8brM0YXsGizXx3f2CzGSuuyFO+MvuivOS6IV12EPotfS/SQ11loQyuUjUVfozXBfkJdsebOM9gGxQ9Oz3Xdus8LX8ohpUJbc4pjpyPzB1gs57rrzK6Xi1ZWaL2/e4xT2IVE+Vq9lRulcXLn8TbLzsK2F+uuWJLnGgp9CmcI5Ir8aALe10+/w1tkSCioAOmhoXKAkzNI6glqFeZgZ2uk0TjoGfWndv5JDP7gbg9mnb04XfRbyBYbdhjSpeCfdCxf/ElAeGdVf7I3lRCL1wTfovYt45wfzg0pVL+rqztbizCXWtKWpzkal0JV+gDSC/CDeCCFld2wnOdmQ6wNzbHh3kVvq2mnmG+h0anYxbf+1Xu+wedemo1jC3ACixXmypfBvM6wePublRT/VBUGvroEMQv97k55VsNTzcWWMRcDVg4dnVKPkKycxavMb9Evk0kb4LE8Iy54Zz5pxGZ5w== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(376002)(396003)(346002)(136003)(39860400002)(451199021)(186006)(82310400008)(1800799003)(36840700001)(46966006)(40470700004)(81166007)(40480700001)(40460700003)(2616005)(6666004)(86362001)(82740400003)(54906003)(478600001)(26005)(36756003)(356005)(1076003)(15650500001)(4326008)(316002)(5660300002)(8676002)(44832011)(8936002)(2906002)(41300700001)(70206006)(110136005)(70586007)(336012)(47076005)(83380400001)(36860700001)(426003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 10:37:46.3987 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3169b7c3-bdca-4510-006c-08db97fb814f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D0.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7513 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_033755_116840_251532D7 X-CRM114-Status: GOOD ( 14.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The primary,secondary and sub-ordinate bus number registers are updated by Linux PCI core, so remove code which updates repective fields of type 1 header 18th offset of Root Port configuration space. Signed-off-by: Thippeswamy Havalige Signed-off-by: Bharat Kumar Gogada --- changes in v2: - Code increasing ECAM Size value is added into a seperate patch. - Modified commit messages. changes in v1: - Modified commit messages. --- drivers/pci/controller/pcie-xilinx-nwl.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/pci/controller/pcie-xilinx-nwl.c b/drivers/pci/controller/pcie-xilinx-nwl.c index 176686b..a73554e 100644 --- a/drivers/pci/controller/pcie-xilinx-nwl.c +++ b/drivers/pci/controller/pcie-xilinx-nwl.c @@ -165,8 +165,6 @@ struct nwl_pcie { u32 ecam_size; int irq_intx; int irq_misc; - u32 ecam_value; - u8 last_busno; struct nwl_msi msi; struct irq_domain *legacy_irq_domain; struct clk *clk; @@ -625,7 +623,7 @@ static int nwl_pcie_bridge_init(struct nwl_pcie *pcie) { struct device *dev = pcie->dev; struct platform_device *pdev = to_platform_device(dev); - u32 breg_val, ecam_val, first_busno = 0; + u32 breg_val, ecam_val; int err; breg_val = nwl_bridge_readl(pcie, E_BREG_CAPABILITIES) & BREG_PRESENT; @@ -675,7 +673,7 @@ static int nwl_pcie_bridge_init(struct nwl_pcie *pcie) E_ECAM_CR_ENABLE, E_ECAM_CONTROL); nwl_bridge_writel(pcie, nwl_bridge_readl(pcie, E_ECAM_CONTROL) | - (pcie->ecam_value << E_ECAM_SIZE_SHIFT), + (NWL_ECAM_VALUE_DEFAULT << E_ECAM_SIZE_SHIFT), E_ECAM_CONTROL); nwl_bridge_writel(pcie, lower_32_bits(pcie->phys_ecam_base), @@ -683,15 +681,6 @@ static int nwl_pcie_bridge_init(struct nwl_pcie *pcie) nwl_bridge_writel(pcie, upper_32_bits(pcie->phys_ecam_base), E_ECAM_BASE_HI); - /* Get bus range */ - ecam_val = nwl_bridge_readl(pcie, E_ECAM_CONTROL); - pcie->last_busno = (ecam_val & E_ECAM_SIZE_LOC) >> E_ECAM_SIZE_SHIFT; - /* Write primary, secondary and subordinate bus numbers */ - ecam_val = first_busno; - ecam_val |= (first_busno + 1) << 8; - ecam_val |= (pcie->last_busno << E_ECAM_SIZE_SHIFT); - writel(ecam_val, (pcie->ecam_base + PCI_PRIMARY_BUS)); - if (nwl_pcie_link_up(pcie)) dev_info(dev, "Link is UP\n"); else @@ -792,7 +781,6 @@ static int nwl_pcie_probe(struct platform_device *pdev) pcie = pci_host_bridge_priv(bridge); pcie->dev = dev; - pcie->ecam_value = NWL_ECAM_VALUE_DEFAULT; err = nwl_pcie_parse_dt(pcie, pdev); if (err) { From patchwork Tue Aug 8 10:37:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thippeswamy Havalige X-Patchwork-Id: 13345933 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB5ACC001B0 for ; Tue, 8 Aug 2023 10:38:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P095a1AAyb6VaGjuA82Y5z2H/6A8J/Rj14HPFTYPN/c=; b=4C1Sf1IcYf2hNg Pbqk4LJlUY7HtHdNd5Ix8rxQ1Q/ddV6gcelHggnT/GLroCoyoKaqqUT2dJWPGonl8zmX9+WJEAmVg 8LYcBL8+VEcUB8xKs1sPN2Q64lKH4eRJOBRoAZT48iUUYqOQIbuTXspZXioXWwNk0EMQzFfsMfBe+ g8DnHqm/FBsAB9xjTDBIqAW+oBUb9DKSlhmLgOfX7llGq7EuPAVVH3XHO3zTKZsiiPpFcraGEwYqy RQaKm6LN9JtC/u5rFHh1GRosOzWuoZ6lxlYm5mRyYze/mzHYn7Gei+9EFJbZfVNT3p09xogxX6siv LFLBXKZlyHQBEgmAcGew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTK6W-002GQK-2b; Tue, 08 Aug 2023 10:38:20 +0000 Received: from mail-bn8nam12on2060b.outbound.protection.outlook.com ([2a01:111:f400:fe5b::60b] helo=NAM12-BN8-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTK6T-002GMk-1G for linux-arm-kernel@lists.infradead.org; Tue, 08 Aug 2023 10:38:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QWhcehBiuq2uIVI5jtg7Yb8p59MUpPR2Cswayreoxg1LGYHvQ6Ngz5qyVoGOmJFJ8hCVf+6oSRcg26Arqc2yFcc668LL127DvRAXQ9+rylCkvuoBqdM/EufXDkJU4yZYfxCU3wW/qHMO7cLyJ9o6YZ49G/hf3p8AJOIBqDi2c9+RwZsuySZV5KboM+PlYUT1OK3Nim1Vj1IjOMD9WqqKYtfHiN5QjkSnx9Mn0t8OJ4lmSVL8AT8mHkRjcEnuD83nlBOsv6wUTetzl2TOUzbdYju/HKsjXXQCITz6QGxMrx3Lv0fNsntcEUDmM1x62JKbqEuL497xHQyRo0MACFjmTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h8F7Gg8zuPB9EzHOl9s40woauJyLnmF88nRo/0QJcVw=; b=O9iTOurbZ1SUQ0bDxDP8VJDglvZZ39XvNzKPFdDpRAbu7MTcPXKqy6Fep5AKBjeDH+NkggwNazVB2DhO8iNnLaxkaZzN2a5115CF/F53EVp3AMVYjlXZakJ1OAVKTzUjgZCwSsbJRlgLHgDbqevdUhc64774ML22JmEHURVpo5F91kCU18VomhqW/5qvdDzgtXaC0/yVRF+ysUBZYA6W3ALoquEWj2abyE29SGwRLDP0VGcBOoYDI3Kx5er6CvuZdUJGEuxfoVKONbLlzf6BsAeKp/Ix9QnFY+sKMlQy4KqdnZP7KEoCI3U64bW374nH+cz5mhdvLOP5GG9YTWIWjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h8F7Gg8zuPB9EzHOl9s40woauJyLnmF88nRo/0QJcVw=; b=pXxbmogluU4uMVbqcZimn898K9n6NiN787hedB5HgPWKXyJgVpVKZyoPYFlS4yjrWaBiALC/m5wm+ia3boVldhxGL7ey8EVi3NMDmtLVZe8dMNUsqrUPLM3RZsEGOH15Q0GYTRA4ZWuOHTQr8BL4Be6BZtRtNT3esKl2YktlMuQ= Received: from PH8PR15CA0023.namprd15.prod.outlook.com (2603:10b6:510:2d2::22) by DM6PR12MB5006.namprd12.prod.outlook.com (2603:10b6:5:1b8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27; Tue, 8 Aug 2023 10:38:10 +0000 Received: from SN1PEPF0002529E.namprd05.prod.outlook.com (2603:10b6:510:2d2:cafe::f0) by PH8PR15CA0023.outlook.office365.com (2603:10b6:510:2d2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6652.27 via Frontend Transport; Tue, 8 Aug 2023 10:38:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SN1PEPF0002529E.mail.protection.outlook.com (10.167.242.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6652.20 via Frontend Transport; Tue, 8 Aug 2023 10:38:10 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 8 Aug 2023 05:38:09 -0500 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 8 Aug 2023 05:38:09 -0500 Received: from xhdthippesw40.xilinx.com (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server id 15.1.2507.27 via Frontend Transport; Tue, 8 Aug 2023 05:38:06 -0500 From: Thippeswamy Havalige To: , , , , , CC: , , , , "Thippeswamy Havalige" Subject: [PATCH v2 2/2] PCI: xilinx-nwl: Increase ECAM size to accommodate 256 buses. Date: Tue, 8 Aug 2023 16:07:33 +0530 Message-ID: <20230808103733.93707-4-thippeswamy.havalige@amd.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230808103733.93707-1-thippeswamy.havalige@amd.com> References: <20230808103733.93707-1-thippeswamy.havalige@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF0002529E:EE_|DM6PR12MB5006:EE_ X-MS-Office365-Filtering-Correlation-Id: c71c7a90-78d0-4fa4-f44c-08db97fb8f7d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C1HcHwRi1P5Ds8zHaIv5JNchDbtsOF2qGm+P0v5Ag453fjbrKCDW/6gjWX5ljVG7EsRJIRmtjkuNlfhruNnguU9MEeHIkx++/DbNg8ErlwY7QOOkTrRl3TJq/KZ6MFZjmi1GYoOGQl1wiSA1MTsojdAh/moy83ER/f4Ea77h4Jje8KncIzbzqca/h+uzpg3eSpKWkYimlTLoAM/cs4oiE+A6D+JMqE79P7JRbdGbEALiAmJ8QoN2iebeCmkJ/DEjq37T5BKjlKGHozGFHzLJzgMpjCOBrP8j3frMTI/OUXn6GuCa9W5WWln06T2WpwU3i0Rf7Dla3KaZVJZLXhymuVjnS8cig8OHIiKjtL+zt57p7vhaLDJdegCF7nsQea2fvQ7QzcRlH3pYqHVl7nW3oli0soJjdNAvC6ry9q/yTE2AiI5Es5DTg3/thBfWWRLQIrXJZfxrU35cxayIRr+J18fEy3DFnMoog7dyfY25mQyPApNUuSR3WT5jnrhX2+oZrxAUY56vn77kTYx5y+y7F2QJJ9Bnefz9GqHR8JtqBT0iich2og5wqI1gfkPOfyBY3lUvmKe4nHjId/26ZUHYDM5iESQYiqW9ZrRJYWismN6GQyZ5nMt9u+19PSjtAucqEhmMoV5a/VmW8hnxkekC97eCR3UvZEGaWOuipWV7xqaDObkvM2GGGr0UxD9gW6yCTGRvDpQC9rs7fI3bD+8XwJz1V/+LzVY2Vf6IsiClieNhpbCvezM7w0YCpKoZQB8D2m8EjY6NwrWwJoIS+PxHJg== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(39860400002)(376002)(346002)(82310400008)(1800799003)(186006)(451199021)(46966006)(36840700001)(40470700004)(2616005)(26005)(1076003)(36756003)(336012)(6666004)(81166007)(478600001)(356005)(82740400003)(110136005)(54906003)(70586007)(70206006)(4326008)(41300700001)(426003)(316002)(8676002)(8936002)(5660300002)(44832011)(40460700003)(2906002)(36860700001)(83380400001)(47076005)(86362001)(40480700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2023 10:38:10.2414 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c71c7a90-78d0-4fa4-f44c-08db97fb8f7d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF0002529E.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5006 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_033817_432505_544781C8 X-CRM114-Status: GOOD ( 12.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Our controller is expecting ECAM size to be programmed by software. By programming "NWL_ECAM_VALUE_DEFAULT 12" controller can access up to 16MB ECAM region which is used to detect 16 buses, so by updating "NWL_ECAM_VALUE_DEFAULT" to 16 so that controller can access up to 256MB ECAM region to detect 256 buses. Signed-off-by: Thippeswamy Havalige Signed-off-by: Bharat Kumar Gogada --- changes in v2: - Update this changes in a seperate patch. --- drivers/pci/controller/pcie-xilinx-nwl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/pcie-xilinx-nwl.c b/drivers/pci/controller/pcie-xilinx-nwl.c index a73554e..b515019 100644 --- a/drivers/pci/controller/pcie-xilinx-nwl.c +++ b/drivers/pci/controller/pcie-xilinx-nwl.c @@ -126,7 +126,7 @@ #define E_ECAM_CR_ENABLE BIT(0) #define E_ECAM_SIZE_LOC GENMASK(20, 16) #define E_ECAM_SIZE_SHIFT 16 -#define NWL_ECAM_VALUE_DEFAULT 12 +#define NWL_ECAM_VALUE_DEFAULT 16 #define CFG_DMA_REG_BAR GENMASK(2, 0) #define CFG_PCIE_CACHE GENMASK(7, 0)