From patchwork Thu Aug 10 09:53:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 13348675 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7B74C04A6A for ; Thu, 10 Aug 2023 01:53:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 806006B0071; Wed, 9 Aug 2023 21:53:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F7436B007B; Wed, 9 Aug 2023 21:53:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D2BB6B0075; Wed, 9 Aug 2023 21:53:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 30AEE6B0074 for ; Wed, 9 Aug 2023 21:53:10 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EAFAFB29CD for ; Thu, 10 Aug 2023 01:53:09 +0000 (UTC) X-FDA: 81106522098.07.E18BFF5 Received: from dggsgout11.his.huawei.com (dggsgout11.his.huawei.com [45.249.212.51]) by imf18.hostedemail.com (Postfix) with ESMTP id 423C91C001A for ; Thu, 10 Aug 2023 01:53:06 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=none; dmarc=none; spf=none (imf18.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691632388; a=rsa-sha256; cv=none; b=iMGMgKI0GD8gXiDg+PQtRhNaG+UJz6zw15BahYec8BxIfDOI3O+gWfCl+oMxagB/17bFQL 7Jd0kH0Nu0Lj/IA2Po7uDKUrJwJg8tyz9aMvGAfBCFQVHqi3we1wBo+BKaWCMykbIHG3dl rUq0K713x8hqQYU5WZSFXOdlTdojK7U= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=none; dmarc=none; spf=none (imf18.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691632388; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nIqZB04IiPyJXZi5xQsaTzy6cjJNH//CpUiITuOoPWM=; b=JKnVI1nB2/L94ErpDTWFtozN1JieMVtUkGxzSEcRTozPQ3stC5CaGhvolC6yRFUvFOG5pX xnHpMYFz837g4UQPkdrfk6lam9iP6x4YlsWrUTvHu1M18xKFoO9axFfDO6kLx+w2XeooAX zBm+bl2i0t5bWtH2DYieHi+NKYwM/w4= Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RLqgx1kLCz4f3mHJ for ; Thu, 10 Aug 2023 09:53:01 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgCXJ6r8QtRkiaZjAQ--.27199S3; Thu, 10 Aug 2023 09:53:02 +0800 (CST) From: Kemeng Shi To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, david@redhat.com, willy@infradead.org Cc: shikemeng@huaweicloud.com Subject: [PATCH 1/3] mm/page_alloc: correct start page when guard page debug is enabled Date: Thu, 10 Aug 2023 17:53:07 +0800 Message-Id: <20230810095309.3109107-2-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230810095309.3109107-1-shikemeng@huaweicloud.com> References: <20230810095309.3109107-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgCXJ6r8QtRkiaZjAQ--.27199S3 X-Coremail-Antispam: 1UD129KBjvdXoW7Xw15Ary8Zr4DKr1UZryrWFg_yoWDuFb_uF s7trs7tryUKa4IkF17u3WxJFZFqwn5ur4xXF1YgF13Ka4DAFn2ya1kX3WfArWDZw1xuryU u3ZrXrW5XF17ZjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb6AFF20E14v26ryj6rWUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M28IrcIa0xkI8V A2jI8067AKxVWUGwA2048vs2IY020Ec7CjxVAFwI0_JFI_Gr1l8cAvFVAK0II2c7xJM28C jxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3wA2z4x0Y4vE2Ix0cI 8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E 87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64 kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm 72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYx C7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_ Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x 0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8 JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIx AIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7sRE2NtUUUUUU= = X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 423C91C001A X-Stat-Signature: wsaaicxfuhn4keyytcz4yxo6strhkiz1 X-Rspam-User: X-HE-Tag: 1691632386-568997 X-HE-Meta: U2FsdGVkX1+997Smmxp8+a7hn7qzBpNu5RqPMKzMUb1CbrYQBLmzOXw8gpiscFfmfZqgi4voy+ZyecjPJ7htfgZfujT+JbDktFNA060ftiTuFdtclaPBHq45m1/0xKP7AukCL5KStjRpsM35m+Fc/h3Fm0E3DxTrKkw/9XYCm+SXHhRBA6APrK5H+2w4ru3mKWIv3Iobmi+pBnzrubgWm4QNS96+yLh/GpnsVNXxbI2PJciX4Vxh6nbNcBTCBZzRJ75vq+HhB6/NW3EOES2ZDJpp/+ejx5xCzLI6DEhvywy4Lo05q3+b/kbJnWTNX9d9fpUKe3h7SRMJnirPocOKlyC5ms45V6odGq/mohQfcrU08cFi5r5qvBxXlz/TWlwI67a6yUwABYzMTgXLy574cXDorraEpPuxqAg/kl2w7r01liy3lV6WMoljW/4h4hFTZfHUALKV+vTCa8uU1/F+fluVFOWKUI6iKhXNj/9g9T6UYWE4kxT0MLHF//xQ8z0S7pI59XZ/V19mR49j5cqlrh7ewkvpXN3JOMe54EaBVmMYrYdY72Nb/kbEPYxAJjubizKgwK5Le++FRC9O8ydSJFDu/4opJIeNpcE5LozyhJdiIGM95nt7O472WjzulqoYBDqeYZEevOutPebNOT+Y83A1Dz79J+fVk7RdOUQ2rc+YLrKwpVoGuMbMC+V9SEpVGLHAJWfWRoJnc+SUMifZhMPMUmxn/ypH9GGMlZpwyngDLsWOu3FrpTvcZhVTA1IrlzjZVZtXP2iNVMDGInD8yc1z7iCUrAR3Jq0hgnqxj8Ae+YoOxhS+e7DjCzy55Rw0NzflQl3o6eSWhPovwz7x8ww1dxXSgU9ialKgYSuqHQWi8oysbZCzOKfPWQ8slo5eJL94Hz9zi9iHyF5YsuulV8mO2cD+3ElTemxXr6dg/XCsFn0KN3XKZOiHJ4fymXjP9eKDPayWjazjPNx66VF FFgF3pSZ JOQdAeH1UtNgDpQK2QhZ6636u84cdKhBE1TyJWYNoJTYR029hlxxy7yRjZ6hlpeobMizYUviP8+iB3lLNIp7GEQ+l3FVar920y6ar7WJtWKyxy3qgREsZ2Ry88T+1lt0SV/knhyLFYvBGyKFqWD3kGp1Mhmj9BYB1YYwmS2sVV5Xiz0YhnLMrZSKIFmEdLDgbCXDoqjF9xcvnPEGz25Nl3dUGKh5wBsKLl8gECO7A3dno67HqmfzUQrHLD66gIv4QrwDqwZfk9pwLJ8Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When guard page debug is enabled and set_page_guard returns success, we miss to forward page to point to start of next split range and we will do split unexpectedly in page range without target page. Move start page update before set_page_guard to fix this. Signed-off-by: Kemeng Shi --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 96b7c1a7d1f2..fd93d1396ccd 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -6557,6 +6557,7 @@ static void break_down_buddy_pages(struct zone *zone, struct page *page, next_page = page; current_buddy = page + size; } + page = next_page; if (set_page_guard(zone, current_buddy, high, migratetype)) continue; @@ -6564,7 +6565,6 @@ static void break_down_buddy_pages(struct zone *zone, struct page *page, if (current_buddy != target) { add_to_free_list(current_buddy, zone, high, migratetype); set_buddy_order(current_buddy, high); - page = next_page; } } } From patchwork Thu Aug 10 09:53:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 13348676 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DDEDEB64DD for ; Thu, 10 Aug 2023 01:53:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC6176B0075; Wed, 9 Aug 2023 21:53:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C73DC6B0078; Wed, 9 Aug 2023 21:53:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3BD18E0001; Wed, 9 Aug 2023 21:53:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9E8256B0075 for ; Wed, 9 Aug 2023 21:53:10 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 70577140942 for ; Thu, 10 Aug 2023 01:53:10 +0000 (UTC) X-FDA: 81106522140.04.F6BB7F8 Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) by imf10.hostedemail.com (Postfix) with ESMTP id A794BC0012 for ; Thu, 10 Aug 2023 01:53:07 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=none; spf=none (imf10.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.56) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691632388; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KfsDLmW+33ck7UhsOCgtuHEW/S7e7sfMpJT8/TxaYT4=; b=PA/G1f8th4Ug2+5GP0HZR9PcMY9lYwF13mN9sGjKTOBje7AhzgFkYCeMsmuphdJr7Y1PVW gKyI3dk55BYkggVNs13VZ49nkjTDvjQ41JgEOvhY3SlmKy3jDmn0tc/3ewbcsvyRkZYNUQ gG7CjrjSiXygqtmw0OAqr5sD7CIYVtg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=none; spf=none (imf10.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.56) smtp.mailfrom=shikemeng@huaweicloud.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691632388; a=rsa-sha256; cv=none; b=aI1Y7k+GixWsK2/qewMlzKDw2n9Ro+gz/oCUSRs4tsJN0E0D5g6m8gks5a9EqQnYLMwy68 9tIQKiUDSsLMAkkXEwhpyDeMYSk+8FTqWIirl0gwE20neWDmYQ1tu6b2J1SBO5FIaWB2Eu MKu64K6r51c+JzOlRWRv/5Zda/2WZUc= Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4RLqgv5yytz4f3lKZ for ; Thu, 10 Aug 2023 09:52:59 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgCXJ6r8QtRkiaZjAQ--.27199S4; Thu, 10 Aug 2023 09:53:02 +0800 (CST) From: Kemeng Shi To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, david@redhat.com, willy@infradead.org Cc: shikemeng@huaweicloud.com Subject: [PATCH 2/3] mm/page_alloc: remove unnecessary check in break_down_buddy_pages Date: Thu, 10 Aug 2023 17:53:08 +0800 Message-Id: <20230810095309.3109107-3-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230810095309.3109107-1-shikemeng@huaweicloud.com> References: <20230810095309.3109107-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgCXJ6r8QtRkiaZjAQ--.27199S4 X-Coremail-Antispam: 1UD129KBjvdXoW7XF4rWr48Kr18Wr1rWw1xZrb_yoWDAFb_ua n7tr95tFy5KF1IgF17C3W7GrWkWw1F9w4xWF4YgFsxKa4UAFnxta1kXFyrJr1Duay8ur98 W3ZxArW2qr1a9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbqAYFVCjjxCrM7AC8VAFwI0_Wr0E3s1l1xkIjI8I6I8E6xAIw20E Y4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l87I20VAvwVAaII0Ic2I_JFv_Gryl82 xGYIkIc2x26280x7IE14v26r15M28IrcIa0xkI8VCY1x0267AKxVW8JVW5JwA2ocxC64kI II0Yj41l84x0c7CEw4AK67xGY2AK021l84ACjcxK6xIIjxv20xvE14v26w1j6s0DM28EF7 xvwVC0I7IYx2IY6xkF7I0E14v26r4UJVWxJr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2 z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4 xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v2 6r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6I AqYI8I648v4I1l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAq x4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r1q6r 43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF 7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxV WUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjTR QNVDUUUUU X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: A794BC0012 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: nhqbyhy6y6fn1yn84uy8kpewwm6o3myc X-HE-Tag: 1691632387-576162 X-HE-Meta: U2FsdGVkX1+03UM1EezeJ1h5vOJ44do7pn4Op3q6/9bTaL2+PmEwAzZF3nfUYp19Y/Yj4WPc22Dq92/jpJGJnakrTtSaNQWfuMzdR3VTRIdMCBmR1YDvg86hik/lOOc8l5OBtahYo/bQLaFreo762dEiGi/AWD7hBAxPYlc0OS6+MM05LGMFG3ZQFm1/bEU9BDUFScu2EbDcEjzxGz+45M8nubQpPMd5FBjXBBLs73Mx2Gp/oTYeRQm86OezvjcCYBlsOqb3ZpvYvlC5/KmC5S2dO8zWuCKbZMwmd9V9NOptifkm3hWDw3FJl87CKHXj5ilp0DxrVSlNQNk7a34+D/5OHt8KQMrIvLnyUkCcpCEHXW8bSc6L3OzTJKoPIVkQpM5XUXya/jVcX3l9ZIHPMhGb2d4MfbnoPQ6yxRz9/2n81k/XwMJyCuGtOykyfIeAYsNj++ZQdVak1Y9m2OAC/i0rJOuHji0ragzG0l1jrS98KULfQBWYQ/AC4XNx6MR8Lu1VyHmBtOfiUOabcczLPV7UqVjEINXfkO6o4UWItzehf694dSCovnSwEhm81YtOMhD1JqkPUajI4YbiVjSrZVHksQ38tniHp7WHQOHHp1q2XacG/YRrTgtauHxkHP+tvEeoSBJ6yY59zLhfrVHdo3h6QfNoNmNm7XlLFZce3RqxQvUijQNj5h/bmk2h0wJzy9QdkY0L/pU7cBFDKyRc+cz1euawCY5RMoYqzzLtNjFT60D4R+zYt1JpQ7+UZZw8Va2jAETADKus8jyi3R591B8yl+UdDkxDqMcuxDlQw+9o860S779cLqE/nNG8lw4IOgbTLPZZnGrtmjXTkyCHxPG42zE0UI70Dfkl8xlMZtYOmDTZY1JFXGiRYqP9r1dWNLyytrgQo246EwHy6Pv70r51plwXNA8MJe76Zu2nKZjaSJ8PDSLSnzrg+6FkxLxDDED6xyMWBZYpbjzdgVv qIQVFnhw JiCubG9QCPVbP1tyYF0/3BqnqX+2f0N6PtD0mYVIMtE8i7YapFoATZoiaaWFq8Wb1i4LvGClmyMwARjK45/EZGR9W7LWpF6e0b/w4lvEoI6tpgqa8dWztrbGCD6bmuYhF6v3sNY20H8rITRjuvfFvv3Y7yZyeJWiMos0y0VLRKqMylHk+ig1AHVRqHzfc7dYxloxpJjaDqzR+8XN4f7/tbS4OKXXj8Kgglx7ejvostNYKJSbp93S7rssj6F7Ei67SMkr/WkzVtRrl5qcHIeTtr8ofW+6S/uTWAt/caDHOLOG5AaM1hGBFyFg1DtL7FU2tPzhg X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 1. We always have target in range started with next_page and full free range started with current_buddy. 2. The last splited range size is 1 << low and low should be >= 0, then size >= 1, then page + size and page will not interleave. As summary, current_page will not equal to target page. Signed-off-by: Kemeng Shi --- mm/page_alloc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index fd93d1396ccd..d0b400733031 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -6562,10 +6562,8 @@ static void break_down_buddy_pages(struct zone *zone, struct page *page, if (set_page_guard(zone, current_buddy, high, migratetype)) continue; - if (current_buddy != target) { - add_to_free_list(current_buddy, zone, high, migratetype); - set_buddy_order(current_buddy, high); - } + add_to_free_list(current_buddy, zone, high, migratetype); + set_buddy_order(current_buddy, high); } } From patchwork Thu Aug 10 09:53:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kemeng Shi X-Patchwork-Id: 13348674 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F8B2C001E0 for ; Thu, 10 Aug 2023 01:53:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 598776B0074; Wed, 9 Aug 2023 21:53:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5489E6B0071; Wed, 9 Aug 2023 21:53:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E9F46B0078; Wed, 9 Aug 2023 21:53:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1E8046B0071 for ; Wed, 9 Aug 2023 21:53:10 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E354D160282 for ; Thu, 10 Aug 2023 01:53:09 +0000 (UTC) X-FDA: 81106522098.06.691A80E Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by imf13.hostedemail.com (Postfix) with ESMTP id AA5692000F for ; Thu, 10 Aug 2023 01:53:07 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; spf=none (imf13.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691632388; a=rsa-sha256; cv=none; b=RUcf50sg4WaOikmIQ8wlshRXT3BtSpr9Jy/G9+IALlvB33gIB4YOokBus4bV+lkAY6t5YO x1qhQ8JCSuYzCq+4p35zQnZdT7l3ynnHL3bVDp4ffBPxMsBeGpfbqYxKV2DL7Mf9r46Lpf BdmzfKRblEWs7bzDXgq28Yydfa8MBDo= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; spf=none (imf13.hostedemail.com: domain of shikemeng@huaweicloud.com has no SPF policy when checking 45.249.212.51) smtp.mailfrom=shikemeng@huaweicloud.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691632388; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Leyhi4mhcX+IdG76ZRxKEVXMYP5GGXi6Ta1WvlexVJY=; b=UM5hq14Ur9gWfchmdpNMXJ1mCbvWIwRHk7FRKmzekvDAocFCX3CEzrzTgaJ4KOtuueEnUn SckbKM2xUTNoBsiXzTymSKOwH3P4lQmcXK04LhPqg3iCD6zFSezwGpfdBVcM96Wt5QOACi Z8QjTyW7t1seHG/O9WYJLfOQvBygVL4= Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4RLqgy0RlQz4f3mJQ for ; Thu, 10 Aug 2023 09:53:02 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP4 (Coremail) with SMTP id gCh0CgCXJ6r8QtRkiaZjAQ--.27199S5; Thu, 10 Aug 2023 09:53:03 +0800 (CST) From: Kemeng Shi To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, david@redhat.com, willy@infradead.org Cc: shikemeng@huaweicloud.com Subject: [PATCH 3/3] mm/page_alloc: remove unnecessary next_page in break_down_buddy_pages Date: Thu, 10 Aug 2023 17:53:09 +0800 Message-Id: <20230810095309.3109107-4-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20230810095309.3109107-1-shikemeng@huaweicloud.com> References: <20230810095309.3109107-1-shikemeng@huaweicloud.com> MIME-Version: 1.0 X-CM-TRANSID: gCh0CgCXJ6r8QtRkiaZjAQ--.27199S5 X-Coremail-Antispam: 1UD129KBjvdXoWrZr48Cr17tF4ktryrZrW3Awb_yoWfKrg_Ga n7twnxtFy5KFyxKa17A3WxJrWDXa4F9r4xXF13tr9xAFyDJFnaq3WkXFy5CrZ8ua4ru348 uasxXrW7tr4I9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb6AFF20E14v26rWj6s0DM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M28IrcIa0xkI8V A2jI8067AKxVWUWwA2048vs2IY020Ec7CjxVAFwI0_Xr0E3s1l8cAvFVAK0II2c7xJM28C jxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWDJVCq3wA2z4x0Y4vE2Ix0cI 8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I8E 87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64 kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm 72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYx C7MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_ Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x 0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8 JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIx AIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7sRiyCJDUUUUU= = X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: AA5692000F X-Stat-Signature: o57ihx7qbtard34c69jdumbg5stn49bg X-HE-Tag: 1691632387-62123 X-HE-Meta: U2FsdGVkX18z6yBnVV4xp/s24y56FjYOlGODgt8AkDoQ67OMnZwCUATxrq406wpx++RVIHYQlMIdx5qQIYNAYqvvGp8bBB7aL9XrzvzihuyvZWK5paMCGkNX5fAq9qs15+sSI9gkLF8bHKKA5BLdh2kLMVWVjdY8gM8sMawtYNi63z2RV5wb1I4CAd0aE8Unzl90atAQklvX+ulZBcKtpxGMEtVTV9k0iIqV50rDPo9q6hzMVCTUP0LCALpn5isouz1OKBqqvzXFEdttJM87xb+4bmgg6I7U91UyVWcN0tAqi87m8hhJgNqyVkJ0nqEw3Ffr5VGIc8bjZw/vmTkA8RYTvy51C5KwODIWE2syuaRelnCSjNhs0tKDC7v9Nlz87trNrOynhPmj5KUB3TLLK1i/diI8ZYDywBIgJ88hhcigWqeYDawTWlpZlc2NxnwV2rMI7yP5mJrgYKgNCNSAMZhZVntaFHIu66pG9m0eJNkex4ur7c9mW8fmFLqFDIvqgfLeyea/CiMY01RcuV3J5mzl3yKBz34ceuN1ThfZ13lUC0KYKxfOfYEzDvP8o0wMQBk2VLqqUMv+1tgWrb6ZFWNFuKz9I8slg1Vyu8O+QgNeb8uxejuuRJjKDxIukAdKUW8kU0ldY6JsA4JxQ7+DVMv3u0x2oU5Wl2R9MbjtO4PhNq/IPjEISUQ3Ha66GfFEuBCLmqx5xuW0disEyM06rErjFlTTPwmAfiY9mQx5/qeUeD54sOSxXKKMQm4z2uqb6Cjhbv532uClt4xMbTISMRiqOjoKlL5o19vylXIh622XWqkvZImmMaPp3vDtwHqfXCiN9xEt4b410nGtPvGEdhOpTDgoXqWYn+JyKAW/bqTVrIh5P/CXgxFV+WdapMWzZbmrY8x2iVpKzI6ZDgoeY7LkDtQXTIagzYfgVOJmIjREH4CNgg4a20TuqpJiluP1HZEdhzllxsjDvGXWdqg 9KkXB36V gROXKXd5EXoOM7gEAiZYRQ10GIP7eWk0Lz/DUYtUxAcxXOgJyQRnJrKh/bWft6IpHIJodJUuPmQKoSCLxw7QlpYhwiOzlER2QTbpysa5iOddJtiIpUxSnKvYmuA0426gYjc/ZJH4s2i/8nSHRp1Y1CLcycVROXWotChRkZTLJTVoByuQNG+Q6mOX3nPNWbj/RhReBIgBRK8UI/D485UanAaT89wEMNTp8jbTyTY8XDdgyoL9KkXBOVIzGphHkJQ02Tz4H/MRK9nIfAId1ZKXsjZdDXIAmnFrXHZNFyoN9UgQpktienwJ5zDCITbeO4SeusCQh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The next_page is only used to forward page in case target is in second harf range. Move forward page directly to remove unnecessary next_page. Signed-off-by: Kemeng Shi --- mm/page_alloc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index d0b400733031..e884d3fd0d06 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -6544,20 +6544,18 @@ static void break_down_buddy_pages(struct zone *zone, struct page *page, int migratetype) { unsigned long size = 1 << high; - struct page *current_buddy, *next_page; + struct page *current_buddy; while (high > low) { high--; size >>= 1; if (target >= &page[size]) { - next_page = page + size; current_buddy = page; + page = page + size; } else { - next_page = page; current_buddy = page + size; } - page = next_page; if (set_page_guard(zone, current_buddy, high, migratetype)) continue;