From patchwork Fri Aug 11 16:06:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Helge Deller X-Patchwork-Id: 13351077 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01AABEB64DD for ; Fri, 11 Aug 2023 16:06:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 517206B0074; Fri, 11 Aug 2023 12:06:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C71A6B0078; Fri, 11 Aug 2023 12:06:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B5AE6B007B; Fri, 11 Aug 2023 12:06:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2BBA16B0074 for ; Fri, 11 Aug 2023 12:06:36 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D74D4141133 for ; Fri, 11 Aug 2023 16:06:35 +0000 (UTC) X-FDA: 81112301550.18.452E04C Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by imf10.hostedemail.com (Postfix) with ESMTP id 221B0C007A for ; Fri, 11 Aug 2023 16:06:22 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmx.de header.s=s31663417 header.b="DB/k8079"; spf=pass (imf10.hostedemail.com: domain of deller@gmx.de designates 212.227.15.15 as permitted sender) smtp.mailfrom=deller@gmx.de; dmarc=pass (policy=none) header.from=gmx.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691769983; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=K4CnQ8UJvR7QCKMIwjNfKcRTgKH09TKZifVzmHQt1sE=; b=LI9bTuUPly4GPHBf1Jo8IlhSFHpXFS2ZJz+e8rNW0r+gMpc41u2OQwRoINiz+oek3dW22s TeY78GfSj0ddoTzKidaIaPv+tUbim/pUCm1huvhfTpGg+KWfOhroVtpAABr8dzd+S7S2Hw 7uPBDugYJFZ94GqRKTFYm5W1Vnsp5+U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691769983; a=rsa-sha256; cv=none; b=by081nhecW4dVQqvd5LnOEcU6XtmOOqqPbU6LN1bFGUv4ORCHP73rOVUNwNiJ0Vfb8eptF Es09yl2dsHWPB7M+XKdycqftvXNeGXrrda3JOuIwdoyg5sffwFmeKeaXXwPX+nAdz4vS91 szVi+E87t4JHL+6zY1bZG92ctl9CJo4= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmx.de header.s=s31663417 header.b="DB/k8079"; spf=pass (imf10.hostedemail.com: domain of deller@gmx.de designates 212.227.15.15 as permitted sender) smtp.mailfrom=deller@gmx.de; dmarc=pass (policy=none) header.from=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1691769980; x=1692374780; i=deller@gmx.de; bh=bM/lxnNu93m6Yx0W4MNwa1wlMBa9CKt9oNj9d9WdiMU=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject; b=DB/k8079UF6IJPmJiOv7LCySVPuyAtSZty4jVagS3n6XurZ17SKGoaBZMrjxnZHhpst6+9k 5tRahp4Z3UBTiOWKX+Tc1PQ1ACve075dQScNN3WUnRPMLnJbPyIXeFKZR/TkSkjs3z7HFcATp VQwHhSJ5sMCsRw4SDngebkUKylrVR5n51aR3LnSB9ZlpoyaSFDMhLZbr3/A11YMqwXfn8I6up zaoYXSpvEwFXdpJqy5IHi1nIOtWDt1fTFORAMZXGt98a2zqbAa/gntiAsRXixSqAZpHorCf9i xQGTvvlPhF5fgq3j6xbYazZRLae2c3u3aI2p/RtwGAUqku6pHHvA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from p100 ([94.134.154.87]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M1Ygz-1qWPf52wDD-0032vD; Fri, 11 Aug 2023 18:06:20 +0200 Date: Fri, 11 Aug 2023 18:06:19 +0200 From: Helge Deller To: Mike Rapoport , Andrew Morton , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org Subject: [PATCH] mm: Add lockdep annotation to pgdat_init_all_done_comp completer Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Provags-ID: V03:K1:MqD9tjnHfgm1cT35TMquLYoF0rtz68dGu4LVqCJ6Ts7lXGdq3mH iwboquz5neAbw11Nuv26zG9hwiyhqMgVopgeoLs2UPPDz/U8Rl+WBarNGwPEX7ZeKiv3MAE VouUDbr5482Ugnj4sXCpsGu36V8vseEPpmctPg7ie1ZJ616I2PW8aGTB0wM4CMsty7VCjzk 8fzZlZCjdvXQUNh+e5A+w== UI-OutboundReport: notjunk:1;M01:P0:KubA4rTKNXk=;VPc061pTwBvEjwtoI6BYpjeuJAZ EiRxYs8QaJ4H/sNSzLbR9fCmwQJyy1iqO6eHvbQC0vPiWEuc+ewLrtOtAWgFICqepco1cy9U4 Z+g0F9fQCzCWdep4lQzJpri6+BHkuzPEhV8dHTPgrOIx0OJWALeTWAKcbV+yLQLeKAIfppiHp dzyjmXkWL7guHQ5dr5KCxljKcTWwjDhVcfrac/7lnqCL4l8KBq+x2P7bgUu8eaJtZJltPiQ8t 0gwI6S10DqzHN6VrpkKY6GutpVda89o8qI8upplT6500ZnF/uzgyLM51dcURebWcGrOrxL9/k Ufojztl8cMngJUy2VDQEL+4oc5+zWW4e45bhWm++Ugc40eTsVEMXGXwBAfSFpbYuDYynKl21p rACWbGoWYYbe7Mzf8hXL1zrGKnVmkwHhcv5OoCaYhSnKmTA9UyjEF4ErmMssYSp46SPmEHdND BhEW+Zt9MTHe19Umn0ZORLEIE4nCLvDL+1IbzXJkAUtPVN5qltfbfJxJoKsQmyrrLCT2KNwf9 bgqvoU+3lTpENu2ATwJbCRz/JOlKyhcZAgsukJ4vmNs6sKh7Abp96jU7JOHzg1Uy92ElwWczQ M36cqnqHJ0Uq+sY1YWFBucFLk9/Oz9fp0pO0uqulNesv+G5dBH6jAHh+hh6UCS65DaAfwIOW8 jcPyzLodUZ0jHQTrK3+VSSMn7ddt4/dbkcFqKhnps2pogj4enfvZr2D7d8v6wr2iriLAFkm7Q q2e19ZRvqB0yANSoMsw8WAGiIUTM8EZBXVUZEloSTVc/XHXB1b7CQkURaYWuat2oW4B1s+vl6 VVGKFC/LNzBnR/hhOmDm56VOWhvqOxnk22O72R6TYxWhHmg8r7mK2JY4Qc/1KulUvTZJGzHfD TCh+5EgLhBuUsePJ3IdJQxO0LozL0t24+9Ns9CE9W3T+Df6zTDTJnfsqn9l5iOdF/7UmXXuyP NUsjcJw35Rc1YCd/JqDRzCbYt4A= X-Rspamd-Queue-Id: 221B0C007A X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: km948cmb4815kjpgir7egdn54mncna33 X-HE-Tag: 1691769982-426928 X-HE-Meta: U2FsdGVkX1+bkMArlDTGjDDPL+L0UWCv2pEEU99pZsQ95sjIuI+aIaLVUTwKyI/IFt1EdUrAUpwWSr6ePuYPVz65meKepCw/E4NX/aAi6Cr9p1f+FF6TniXBwXu35hZWLTk4PuA51LGWtvHGH61NfUtxEN+3xH8APVAJ8uLG597touV5kfiM0oH6a7niODNHrIwIBgi5l8qrFhExvUTqcu9lNJ5PuBDfz6GO9rIggL6bdyEnmRdiEe+duFzg1FrWDbo75vRAoep3VjG8KhfPrZ0UpHKcNJ5xi8sVcicVFZXrY7ZFx8Ap5iimfNxKKslNsRtfA3NrGsHLIk7CZuzB0s4Zjwa9xjimA11JW5nRZVQrYJiZ9mTGriT23qUjHADgfacFC8swF8LIw8Np0cz9wRn/m+LTpPBcC7WNuiOBILKi6uAymcJYWFw9EcuMAHkt22GWwNSAE0m1equq+GBgr3xbfnrO1kMIJopCmUY7boAByb3YNi5Br4OTaIDHYuSPlw//Pm/47GXajMhunL1I2nsnzkp9Z5B77jsEa5goOuswL9Eley2kFXIHWFB7HMr8f2omulWREcsXuD4lOCpoi8hHAaYK1A0scbdfv4eGW2JIzHqKWtMtZbyN1LhmBUJhlRf8qrOL47shGCsQScbDB14GMrVdoXitCQmPpLu0Rn37amUXwxhxNBtNsEjm1mp6LGB1bn0Iyj8gZJL2yTNc+qPTD9A5ZFHhc23t21/9P8In7jvf64e38A10whi911thjy/w6Krc/Xrv3HqV8raWUc6yssbgtqtk6JfuLBH5/TjoY5yji6AClFUrbioku90Ofq1jfZBpXRbd1GeMrlCRJUZ2rRTscEo5r/65i13nVs2DyX1CD/6lYckQf+Q0LYfi8mZSVcqMbR+5O5pCghSFDl6EYNZok03NibcgEdnzf6qe0+cZurjSMIks92utMczj/W2ATjiI2A8L1rdydLL iOAUnOFz hUmVtAAJt3o4TVEZof8AprVVIM8c7+GNGYcP8tfyHI1WcGfNGZrUM3F/fqzYP+HxfbHnanNRCpQiVZ4NgGBK75vtSzOUzsfAdSrxOH2cJZWQhNA1UvivejEXGu7vqOXESwftym6tbgkcLZkWAAFZsTrRLFhOoQeUNk7n2C267TkA/6CigPmWC/wf8U8fnjgHawXR4AH9WdFGzZcYmv36o/7W/SdoC9HNLmChw/MIZVWtm6k4DEx6evSmILHqO/ml5DE4pnii/wU40Vixlt9UaPtv8CHOtN0CzzEGAVKg5K3FhQedVLB5uNONPL72Qyy5ZG3ugL8DCELpmNc3Ag81AXfzMuEFZzK5I3nQf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Add the missing lockdep annotation to avoid this kernel warning: smp: Brought up 1 node, 1 CPU INFO: trying to register non-static key. The code is fine but needs lockdep annotation, or maybe you didn't initialize this object before use?' turning off the locking correctness validator. CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.5.0-rc5+ #683 Hardware name: 9000/785/C3700 Backtrace: [<000000004030bcd0>] show_stack+0x74/0xb0 [<000000004146c63c>] dump_stack_lvl+0x104/0x180 [<000000004146c6ec>] dump_stack+0x34/0x48 [<000000004040e5b4>] register_lock_class+0xd24/0xd30 [<000000004040c21c>] __lock_acquire.isra.0+0xb4/0xac8 [<000000004040cd60>] lock_acquire+0x130/0x298 [<000000004147095c>] _raw_spin_lock_irq+0x60/0xb8 [<0000000041474a4c>] wait_for_completion+0xa0/0x2d0 [<000000004012bf04>] page_alloc_init_late+0xf8/0x2b0 [<0000000040102b20>] kernel_init_freeable+0x464/0x7f0 [<000000004146df68>] kernel_init+0x64/0x3a8 [<0000000040302020>] ret_from_kernel_thread+0x20/0x28 Signed-off-by: Helge Deller diff --git a/mm/mm_init.c b/mm/mm_init.c index a1963c3322af..b390b4b27dad 100644 --- a/mm/mm_init.c +++ b/mm/mm_init.c @@ -2377,6 +2377,7 @@ void __init page_alloc_init_late(void) int nid; #ifdef CONFIG_DEFERRED_STRUCT_PAGE_INIT + init_completion(&pgdat_init_all_done_comp); /* There will be num_node_state(N_MEMORY) threads */ atomic_set(&pgdat_init_n_undone, num_node_state(N_MEMORY));