From patchwork Tue Aug 15 13:59:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Marko X-Patchwork-Id: 13353828 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EEB0C04A94 for ; Tue, 15 Aug 2023 14:01:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237460AbjHOOBH (ORCPT ); Tue, 15 Aug 2023 10:01:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237073AbjHOOAh (ORCPT ); Tue, 15 Aug 2023 10:00:37 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 860BDD1; Tue, 15 Aug 2023 07:00:36 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-4fe0c566788so8537724e87.0; Tue, 15 Aug 2023 07:00:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692108035; x=1692712835; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0HpL5vZ5TK3sBIkkNc1Nff9Nd8amkfnZofZ3YOp6jpc=; b=b9zaGkxrBEpPcKvR+VRIqgJK+Vm0P/VtpTqg1CuFCnl2LAjdF8bXqqvBgMnXuKGTzD p3zb6np7huhjju0qs+mm3d16tYc5pSCjtr1bZHqX8YwJhfxVtX1rmu10pYI5m1zEaQ54 33HH8zVPBzif7R+23M6IxxbiMTXHbG4t/JUPErNMLTTUdsU2UQRh4rtV4oJiELo+b8x+ xVJYMU2CPai81kZmWr75Hoay+aYN4RkrbY1F//QYvQFVwNxk4CRkNXToqsRRRsqpwZWP TdpOFRnLhpEmGYRgbMt1B+VN4crFH1zJdnWNoX9xmm8iUj0+yXTPhQjnmmEU+MSUOsGV bGDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692108035; x=1692712835; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0HpL5vZ5TK3sBIkkNc1Nff9Nd8amkfnZofZ3YOp6jpc=; b=QRJmukqwb0r0t9m4PnQAq7ADaJQCMZpkqnovTyoSHHxuBI57/jNT2gKTnY3iMMdNe2 kLlnv9dlbdC1KMldLeAiFCEua+lrPDhU8x0lOGWdhdOvQVpxAi3DMom1buRibFvfdpzk fpSZ73+rw8czu0JMY9YoOrRuCWA0uYyHuRQomAeNNO24+avhbuSrIHicg1kILyBjkqND szzQgHxuNkBuGSELgnD85BsDqnSNAHanMSKHLW/KTUXpBYPmxhu1pI2y+kRDxiq9hpS6 dlUNoYnYbkmZvUAOkqDnwMXPp7WeJY2wYrxhN61frM6J/TE2//6NoT2iXNwrT7azKeYC /qXQ== X-Gm-Message-State: AOJu0Yxab+5piwF0vCYOuo5Gmsm70YX+cVKHhYY0H0mKMyFwuwiZR81g jFw0CLBoj4cUeexsppcRo1M= X-Google-Smtp-Source: AGHT+IEk+ezPDL0N8dKyfHvugYBvOwY6+UjD1tlCJXfUzMr36l+/tByYEC5NUUTQRjZxPOlRPd/ABw== X-Received: by 2002:a05:6512:746:b0:4fe:958:88ac with SMTP id c6-20020a056512074600b004fe095888acmr8223617lfs.6.1692108034313; Tue, 15 Aug 2023 07:00:34 -0700 (PDT) Received: from fedora.. (dh207-96-14.xnet.hr. [88.207.96.14]) by smtp.googlemail.com with ESMTPSA id a26-20020aa7d91a000000b00525740aa68dsm1049042edr.36.2023.08.15.07.00.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Aug 2023 07:00:33 -0700 (PDT) From: Robert Marko To: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, quic_gurus@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: computersforpeace@gmail.com, Robert Marko Subject: [PATCH v2 1/5] dt-bindings: firmware: qcom,scm: Document SDI disable Date: Tue, 15 Aug 2023 15:59:34 +0200 Message-ID: <20230815140030.1068590-1-robimarko@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org IPQ5018 has SDI (Secure Debug Image) enabled by TZ by default, and that means that WDT being asserted or just trying to reboot will hang the board in the debug mode and only pulling the power and repowering will help. Some IPQ4019 boards like Google WiFI have it enabled as well. So, lets add a boolean property to indicate that SDI should be disabled. Signed-off-by: Robert Marko --- Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml index 4233ea839bfc..bf753192498a 100644 --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml @@ -89,6 +89,14 @@ properties: protocol to handle sleeping SCM calls. maxItems: 1 + qcom,sdi-disable: + description: + Indicates that the SDI (Secure Debug Image) has been enabled by TZ + by default and it needs to be disabled. + If not disabled WDT assertion or reboot will cause the board to hang + in the debug mode. + type: boolean + qcom,dload-mode: $ref: /schemas/types.yaml#/definitions/phandle-array items: From patchwork Tue Aug 15 13:59:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Marko X-Patchwork-Id: 13353827 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFADAC0015E for ; Tue, 15 Aug 2023 14:01:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237464AbjHOOBI (ORCPT ); Tue, 15 Aug 2023 10:01:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237122AbjHOOAj (ORCPT ); Tue, 15 Aug 2023 10:00:39 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80915D1; Tue, 15 Aug 2023 07:00:38 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-4fe1489ced6so8717096e87.0; Tue, 15 Aug 2023 07:00:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692108037; x=1692712837; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/J5BLI7U7z59XFqFa9a1k82CWsFOs34AOvZvawtPipE=; b=oMxoxV6kO+sLMRBrjig1knnZ0b+lRE71fItzGR0cuJ3Hc8h/A2Gr2Mw3CtKDLlKGx2 2vav5i8oxgdVM1UjqpKjOfhlDX5xxydo+/i0eo6WsmJMXPIQ2eKpy0Syp5GM/+9iCukP 7/Kga1mbnlDu8O6e0xuZjJK03FQdRM/JBHZ+s11edaYvpLckIJkHS95QsuWyho6X0TH6 yVo2zsVnnsREgyNZrQPB2t04V+J+mnnTV/Eh+NyY1Y7AAwrBb0IXzUEVdiW/fHH88mg8 +oJeUlmAdaW5esUK3ThbWr+9FFsw6neKaAGEI0qqnRT5xICQH1hSFIJp2cD+VRUI7lNL FLCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692108037; x=1692712837; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/J5BLI7U7z59XFqFa9a1k82CWsFOs34AOvZvawtPipE=; b=KIvt8yQXKMNDJhdwE70VcNKtQpkcf4llfrMHwOggyAlJOdwCjMXrnTd+95KVdkmhZH n9Pn+AmCSGpKAVRpwLjfmqeJJzhnXVqzmNwcBdK+u5+mt74eYCQcxoaks36md5PUOL5j nf/wdhYFo3UDTQkh0QIA4AmWidMlYxJS5zFdXnPhnNXEfL5Zukuq9IjNQAsabmmMF+1w YIHnoqRDHQLL8kT2W0Q7kzEWYcEecO9fu6jLXMQtVrmmlyCEmyDcXst8EGDynk2+E3xT txOOnOuk5cLkP8DShCmpjs1fYYYSuyVaRx+PZgPjqXg2/UIRNpKTp9UToElrnKZk3aoN VThw== X-Gm-Message-State: AOJu0Yyu4eL2gPOkia8rcddD6AEN8BPr6dQjkMOsG5YjGwexWWNxMzOo QfCgJIZAzzIfPP6J2f2Qdz4= X-Google-Smtp-Source: AGHT+IG5B6uqja6yiLKv29LYsifjGiyjWIDrpp9xtWC0X/BlTvQk/UlQ8DOitzCpm/vw+yowW7wIYA== X-Received: by 2002:a05:6512:a8d:b0:4fd:c884:51fc with SMTP id m13-20020a0565120a8d00b004fdc88451fcmr10960985lfu.58.1692108035768; Tue, 15 Aug 2023 07:00:35 -0700 (PDT) Received: from fedora.. (dh207-96-14.xnet.hr. [88.207.96.14]) by smtp.googlemail.com with ESMTPSA id a26-20020aa7d91a000000b00525740aa68dsm1049042edr.36.2023.08.15.07.00.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Aug 2023 07:00:35 -0700 (PDT) From: Robert Marko To: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, quic_gurus@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: computersforpeace@gmail.com, Robert Marko , Mukesh Ojha Subject: [PATCH v2 2/5] firmware: qcom: scm: Add SDI disable support Date: Tue, 15 Aug 2023 15:59:35 +0200 Message-ID: <20230815140030.1068590-2-robimarko@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230815140030.1068590-1-robimarko@gmail.com> References: <20230815140030.1068590-1-robimarko@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Some SoC-s like IPQ5018 require SDI(Secure Debug Image) to be disabled before trying to reboot, otherwise board will just hang after reboot has been issued via PSCI. So, provide a call to SCM that allows disabling it. Signed-off-by: Robert Marko Acked-by: Mukesh Ojha --- drivers/firmware/qcom_scm.c | 23 +++++++++++++++++++++++ drivers/firmware/qcom_scm.h | 1 + 2 files changed, 24 insertions(+) diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c index 06fe8aca870d..abb54df663ea 100644 --- a/drivers/firmware/qcom_scm.c +++ b/drivers/firmware/qcom_scm.c @@ -403,6 +403,29 @@ int qcom_scm_set_remote_state(u32 state, u32 id) } EXPORT_SYMBOL_GPL(qcom_scm_set_remote_state); +static int qcom_scm_disable_sdi(void) +{ + int ret; + struct qcom_scm_desc desc = { + .svc = QCOM_SCM_SVC_BOOT, + .cmd = QCOM_SCM_BOOT_SDI_CONFIG, + .args[0] = 1, /* Disable watchdog debug */ + .args[1] = 0, /* Disable SDI */ + .arginfo = QCOM_SCM_ARGS(2), + .owner = ARM_SMCCC_OWNER_SIP, + }; + struct qcom_scm_res res; + + ret = qcom_scm_clk_enable(); + if (ret) + return ret; + ret = qcom_scm_call(__scm->dev, &desc, &res); + + qcom_scm_clk_disable(); + + return ret ? : res.result[0]; +} + static int __qcom_scm_set_dload_mode(struct device *dev, bool enable) { struct qcom_scm_desc desc = { diff --git a/drivers/firmware/qcom_scm.h b/drivers/firmware/qcom_scm.h index e6e512bd57d1..7b68fa820495 100644 --- a/drivers/firmware/qcom_scm.h +++ b/drivers/firmware/qcom_scm.h @@ -80,6 +80,7 @@ extern int scm_legacy_call(struct device *dev, const struct qcom_scm_desc *desc, #define QCOM_SCM_SVC_BOOT 0x01 #define QCOM_SCM_BOOT_SET_ADDR 0x01 #define QCOM_SCM_BOOT_TERMINATE_PC 0x02 +#define QCOM_SCM_BOOT_SDI_CONFIG 0x09 #define QCOM_SCM_BOOT_SET_DLOAD_MODE 0x10 #define QCOM_SCM_BOOT_SET_ADDR_MC 0x11 #define QCOM_SCM_BOOT_SET_REMOTE_STATE 0x0a From patchwork Tue Aug 15 13:59:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Marko X-Patchwork-Id: 13353831 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C736CC07E8A for ; Tue, 15 Aug 2023 14:01:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237471AbjHOOBJ (ORCPT ); Tue, 15 Aug 2023 10:01:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237431AbjHOOAk (ORCPT ); Tue, 15 Aug 2023 10:00:40 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1091199A; Tue, 15 Aug 2023 07:00:38 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-5231410ab27so7095398a12.0; Tue, 15 Aug 2023 07:00:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692108037; x=1692712837; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1mZoNnewKQDmbxD48rcfjhqVVmaStyll33cRTzymWNU=; b=QpFAZ4qKDgw+pEskJQpnti+erQcjjvbcgl2qfbt8mFW0noSyrgBGfX9BkaBHknfLMR wZoZqiEW+93B9oDwZZdZNuyCA649B3wc9/P9eD+7LCXjzY8SA1NmfLiS9dUbiXTqfKFA tNlK6aPpk/sSwDuET12vedI3OJvpkRMvIPvQQwf0A84tQ2Hv5X2BIsaLO1LZE2Z5Lvl/ i+cgnP0oDNyj2CHVQ5yBAM4QirRK+5XugNl+V48lmMIsJLZioCciRxIOfvbSC9DfIAgg XVJls/3H3/890cs0EW1nAb+MHws0P/6W7ccU7U4zpxFvTzCSd/mQnh93pYcUpVmZcN5/ uIbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692108037; x=1692712837; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1mZoNnewKQDmbxD48rcfjhqVVmaStyll33cRTzymWNU=; b=BT5WXqICk97+PRqSmtVHYVFC6+8x5dnCPb9xlELkGGbr8bGA1nTJLroYEW4GjuDF9e gSQtYfIySgfV3Nd5KbxdOEHpbspvM7/53XH0jlYBXi5LDLwSGviq4JV5oZ4BXgW4cter c4s572kThm8Q8aGfZhB2UwrBrOrcq5te4Kux3VPsblQpPmjhkzd0O6Q7sCO0TmP9PneE Ms1POauDM2vGwDe5SprI2FQL2OvcOdoBI1j/vbgPn24u+Uc6JID7hiZDKHxT9RD8tUXh JqgxOrINdlYFAIn3b7U0tFCsIORgKS42+YpWJxc2NEBkE3RokTx6w2KRjGhB8Ey7viqI +U4w== X-Gm-Message-State: AOJu0YyzC4z/xH8/EMKCPGK8xs8e7aDWxzZkKTpzr2xR3TqJI6s/y+Rx 4cPw7J7jCbutdGuETdPE+0I= X-Google-Smtp-Source: AGHT+IE0E4oixKaZbCWGOYt5Rzkyjigj39Arszy2GW/HFD8p/g6uUY1YAEWFCoOlgPAAE2RBNR3RxQ== X-Received: by 2002:a05:6402:12d8:b0:523:2274:91cb with SMTP id k24-20020a05640212d800b00523227491cbmr9688003edx.12.1692108037121; Tue, 15 Aug 2023 07:00:37 -0700 (PDT) Received: from fedora.. (dh207-96-14.xnet.hr. [88.207.96.14]) by smtp.googlemail.com with ESMTPSA id a26-20020aa7d91a000000b00525740aa68dsm1049042edr.36.2023.08.15.07.00.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Aug 2023 07:00:36 -0700 (PDT) From: Robert Marko To: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, quic_gurus@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: computersforpeace@gmail.com, Robert Marko Subject: [PATCH v2 3/5] firmware: qcom_scm: disable SDI if required Date: Tue, 15 Aug 2023 15:59:36 +0200 Message-ID: <20230815140030.1068590-3-robimarko@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230815140030.1068590-1-robimarko@gmail.com> References: <20230815140030.1068590-1-robimarko@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org IPQ5018 has SDI (Secure Debug Image) enabled by TZ by default, and that means that WDT being asserted or just trying to reboot will hang the board in the debug mode and only pulling the power and repowering will help. Some IPQ4019 boards like Google WiFI have it enabled as well. So, lets use the boolean DT property to disable SDI during SCM probe. It is important to disable it as soon as possible as we might have a WDT assertion at any time which would then leave the board in debug mode, thus disabling it during SCM removal is not enough. Signed-off-by: Robert Marko --- drivers/firmware/qcom_scm.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c index abb54df663ea..71d886626233 100644 --- a/drivers/firmware/qcom_scm.c +++ b/drivers/firmware/qcom_scm.c @@ -1491,6 +1491,12 @@ static int qcom_scm_probe(struct platform_device *pdev) if (download_mode) qcom_scm_set_download_mode(true); + /* + * Disable SDI if indicated by DT. + */ + if (of_property_read_bool(pdev->dev.of_node, "qcom,sdi-disable")) + qcom_scm_disable_sdi(); + return 0; } From patchwork Tue Aug 15 13:59:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Marko X-Patchwork-Id: 13353830 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F817C04E69 for ; Tue, 15 Aug 2023 14:01:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237468AbjHOOBI (ORCPT ); Tue, 15 Aug 2023 10:01:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237456AbjHOOAl (ORCPT ); Tue, 15 Aug 2023 10:00:41 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93B32D1; Tue, 15 Aug 2023 07:00:40 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-4fe28f92d8eso8555783e87.1; Tue, 15 Aug 2023 07:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692108039; x=1692712839; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ltyQwF2LAMGJH0evTykrvVjQou+GUeNnjt/wVeM5SF0=; b=ZHukLVy0358l0WMPNL3pncLnc/8q25csLKF6Cjv9hPbTOZfCSvsjChHoX7POz7RIkI RN/KEjFoWrVw2yRIDYgqFXODJVbLm94e5WGyZ0NxWunzj+ifssTK3/e9YejYzfC29GP5 Ab4MJ06QLfi52RO1zDUGC0E/9xK3NLoJ19FtYuG74VZ6GnbapI6n+bERusHpWd/DrSjG k1A3lRAMth5I2tmNQuxWe7D6llF2lNk/B7ZIkWo4Y7m5hcC54d0AN8ZWPCzREHibwxCG 0ydGV2vbDPJRjEp3tvL/FemQfKBmiw8wgLyK46z2XUazA4UPX6emR/EJchiywiL7flFI j6OQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692108039; x=1692712839; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ltyQwF2LAMGJH0evTykrvVjQou+GUeNnjt/wVeM5SF0=; b=D8upkTb3WwuWp6K3P0MDTVCzKHlT/sB+u8KOF2JuIIWqJSRJHAtKJAs3vaFlu4dLzD olWSxQKG3aBsYa9UunQW2EvhtainPS+KYNH3mg62dvnncjayOMZ9cQDDQwwHNTMUDw06 /1Jn+gffRQrFe99LURRSrTzR82GSDK596m5PJFMeyKzgPFsJ5nFpqKTpMtREOnmIclKj ClevOj4X6A7QR2bBZeVSNUHL9NHlN5hBnbGa7fQuDZP1+4O1D2ks4j7mr7iGukswlVkQ SHv13GVKQ9Ev5or1QYAR3ebSnlpbvAb0DNIAseENIohJTbnwR2C14zH6ryoJE8ScyxgU xuzg== X-Gm-Message-State: AOJu0YzfckYZ8XvgipNni6EH98DwNQPJccvSBFaaobi2/B0CuIa4o5SC VQj/tg+8dfa0fcxcu9JHBJY= X-Google-Smtp-Source: AGHT+IEfr77smkL+24HO9hz+7rz2f9ubnVRvLkFPiEEn2cUK6jQbiqLOYgbvez2LJm6rf+D4Ivg20g== X-Received: by 2002:a05:6512:2147:b0:4f8:5e8b:5ec8 with SMTP id s7-20020a056512214700b004f85e8b5ec8mr7416051lfr.9.1692108038419; Tue, 15 Aug 2023 07:00:38 -0700 (PDT) Received: from fedora.. (dh207-96-14.xnet.hr. [88.207.96.14]) by smtp.googlemail.com with ESMTPSA id a26-20020aa7d91a000000b00525740aa68dsm1049042edr.36.2023.08.15.07.00.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Aug 2023 07:00:37 -0700 (PDT) From: Robert Marko To: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, quic_gurus@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: computersforpeace@gmail.com, Robert Marko Subject: [PATCH v2 4/5] dt-bindings: firmware: qcom,scm: document IPQ5018 compatible Date: Tue, 15 Aug 2023 15:59:37 +0200 Message-ID: <20230815140030.1068590-4-robimarko@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230815140030.1068590-1-robimarko@gmail.com> References: <20230815140030.1068590-1-robimarko@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org It seems that IPQ5018 compatible was never documented in the bindings. Signed-off-by: Robert Marko Reviewed-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml index bf753192498a..212ad5f32408 100644 --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml @@ -24,6 +24,7 @@ properties: - qcom,scm-apq8064 - qcom,scm-apq8084 - qcom,scm-ipq4019 + - qcom,scm-ipq5018 - qcom,scm-ipq5332 - qcom,scm-ipq6018 - qcom,scm-ipq806x From patchwork Tue Aug 15 13:59:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Marko X-Patchwork-Id: 13353829 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA18CC04FE0 for ; Tue, 15 Aug 2023 14:01:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237474AbjHOOBJ (ORCPT ); Tue, 15 Aug 2023 10:01:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237457AbjHOOAm (ORCPT ); Tue, 15 Aug 2023 10:00:42 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4DC0D1; Tue, 15 Aug 2023 07:00:41 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-4fe11652b64so8462772e87.0; Tue, 15 Aug 2023 07:00:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692108040; x=1692712840; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2qzbPPmHH2Cs84MMNUNLEy/8AFYHbEVzbBv7dcVzhPE=; b=O2HcgsWmVGf3noRrJ9w/dYS9V9qM1/QoW+WU7MUAeJ7W22RhWFLbwBf6WSf+ZVoyDC 2snnbesW1aam6kkwc7Vwv27Icb/KrQgKR0jz6BZjtpslNAFrXiYU1uXSs+QZJfzmifB4 aFC87yM1znezWHUI/2M4x4wq9o8iQqtUtJJmVTZYfWm9PdveS+LyCuItuWI9o5cYf3yH I7PO28oxEI5wATU0Dga6nSYmCxQV0XFTdlorwfuyI78x/NUc15ma8SpFOhntPTS6VcHw 30IGLK/enBALtX6qT8Yez3sELl3fd1BnRiaP4F9V9DVsFFs9ePZOevnnr61ANlBe1aWZ zlTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692108040; x=1692712840; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2qzbPPmHH2Cs84MMNUNLEy/8AFYHbEVzbBv7dcVzhPE=; b=X84nZPHyuzmr+9d9r5xXmvXAo7Quz8QQmS+Q3F3RCX0hZZG3J9ckv5mfVp+Dv3QcCr d5Nyl8jnO2fHAfO3r2uL8SD3EUL8WWTofBFl3w7euVa+WXjZlsIX8L1ylO27NgqkZ3jM XqCO2gE2142hSRm8Aqpj1l4c4pQO6DbWTLE+eL+bqgoQMTjDyhhSme8SelTB6TOJgmk5 Yfx0PLe9A0krSe/ebn2qNdS+y3h9lM0hnwTUustaEko4RM/dw+I1UQZ5QHaawfG0kuZ9 jVT3zMIJ+bcQTdvPbi4tL5Z6h66IJL/HN+xu5WqBSr5uRYoUXpN2OnXSwMJeh50SaxwT +lPw== X-Gm-Message-State: AOJu0YyiZugDN3ERqUk4kAIdQUYNI+hCnp9zKcmLBojUptAxO590iFox IJBOivZ5mnmdaRRYmWNtses= X-Google-Smtp-Source: AGHT+IH09mRKKgi7n4qLOrwYSpjBkp5Qo0J6B2qC/jr9UQv6lMBVjwpMiLlv5m02pKEJwLW/kFjjcg== X-Received: by 2002:a05:6512:3589:b0:4fe:3724:fdae with SMTP id m9-20020a056512358900b004fe3724fdaemr7883880lfr.66.1692108039828; Tue, 15 Aug 2023 07:00:39 -0700 (PDT) Received: from fedora.. (dh207-96-14.xnet.hr. [88.207.96.14]) by smtp.googlemail.com with ESMTPSA id a26-20020aa7d91a000000b00525740aa68dsm1049042edr.36.2023.08.15.07.00.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Aug 2023 07:00:39 -0700 (PDT) From: Robert Marko To: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, quic_gurus@quicinc.com, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: computersforpeace@gmail.com, Robert Marko Subject: [PATCH v2 5/5] arm64: dts: qcom: ipq5018: indicate that SDI should be disabled Date: Tue, 15 Aug 2023 15:59:38 +0200 Message-ID: <20230815140030.1068590-5-robimarko@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230815140030.1068590-1-robimarko@gmail.com> References: <20230815140030.1068590-1-robimarko@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Now that SCM has support for disabling SDI if indicated by DT, lets set it for IPQ5018 as it has SDI enabled by default and it must be disabled. Signed-off-by: Robert Marko --- arch/arm64/boot/dts/qcom/ipq5018.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi index 9f13d2dcdfd5..3285c86824cf 100644 --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi @@ -57,6 +57,7 @@ L2_0: l2-cache { firmware { scm { compatible = "qcom,scm-ipq5018", "qcom,scm"; + qcom,sdi-disable; }; };