From patchwork Tue Aug 22 13:19:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grant B Adams X-Patchwork-Id: 13360779 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 657F6EE4993 for ; Tue, 22 Aug 2023 13:21:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235976AbjHVNVJ (ORCPT ); Tue, 22 Aug 2023 09:21:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235977AbjHVNVJ (ORCPT ); Tue, 22 Aug 2023 09:21:09 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEF8618B; Tue, 22 Aug 2023 06:21:07 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id 4fb4d7f45d1cf-523bf06f7f8so5364566a12.1; Tue, 22 Aug 2023 06:21:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692710466; x=1693315266; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=7u0D1vKsgp+LzrkxafeIdw43ha9lu5raeDJAVDWxoo8=; b=cZwaRC3X2zDR0oj+ZR+Axpm6IjYOrIyh4H6kiJ206iG3Q5SM6vHIsx+kyuS1vlXwWo AEEo2iAHs1W5XQ6iMxQRdIH+j1ZxXvksmhMcHQBtO0tub71ygab7VO5DCFtDDQoBSCYC fYcgtVIgs8AzwX7WoEhBp6iJljuIbcnrIRWZlGYB4D3/Tsc8llHgUriCRxs4KCBQ4jiw pFOetxlCOiNe68vpUHMaDqb+UHvYQ7hAFcmnKLgvkQ57ZYuJJTsKuXaCgOls1a5sfi0N 0ShSVG95vUJOqCWzlsbqv6rejro/Hbk6p0jMxCRKjpFt1OqeRLxRRljwesXS/c3wUNca LzBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692710466; x=1693315266; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7u0D1vKsgp+LzrkxafeIdw43ha9lu5raeDJAVDWxoo8=; b=SGnWlesolpmzG/WrDSgbTAGue4r77WbLcRhA41fzinoGtz47ZjJbfu0M8ThPH89w9C ZMCkiJLQv5KAZGvskvYjNt0JCXqIhPLFiE9fzC/47IQ93vGH4cqD7obfijLXhi6OjX+Z +ebeyo+L1OZlRYPnOccIC5Jtb5fRFFNsOpqXw93mfddZaI3kzUBF8GOgne+0EH9XaSoN vnE5dkIEQjrZeOSCUPZd1Pvl7To1gpsNs/XuvWVIYfBiXpIzaQTdr/5txmo0HHd/xcqm jLqDnJdbi2hogNo/WTXhYbFMmt3sL2H37SaRAi1a/704GpUhJZjlq0rCRQ2z7PLjBjUU zj+w== X-Gm-Message-State: AOJu0Yzj1xhquQhSyzFjlbq660rSC72JEXqyxfBnwCwtefbOX8b5mr52 DKDkapN3LyxHMJ5n9sfajBX1uiVmOe/SXg== X-Google-Smtp-Source: AGHT+IFUVTI6k19eR4xuknD+vKQzdm0gfqs/b2MGnOosJG8jTdAOtaVMgsMwmYfDYT+IAOu1YT3WmA== X-Received: by 2002:a05:6402:648:b0:52a:943:9ab5 with SMTP id u8-20020a056402064800b0052a09439ab5mr4952530edx.31.1692710465748; Tue, 22 Aug 2023 06:21:05 -0700 (PDT) Received: from localhost.localdomain ([102.39.140.247]) by smtp.gmail.com with ESMTPSA id c4-20020aa7df04000000b00523b1335618sm7582034edy.97.2023.08.22.06.21.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Aug 2023 06:21:05 -0700 (PDT) From: Grant B Adams Cc: linux-omap@vger.kernel.org, tony@atomide.com, Grant B Adams , Sebastian Reichel , Bin Liu , Greg Kroah-Hartman , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH 1/2] power: supply: Fix tps65217-charger vs vbus irq conflict Date: Tue, 22 Aug 2023 15:19:53 +0200 Message-Id: <20230822131953.19582-1-nemith592@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Enabling the tps65217-charger driver/module causes an interrupt conflict with the vbus driver resulting in a probe failure. The conflict is resolved by changing both driver's threaded interrupt request function from IRQF_ONESHOT to IRQF_SHARED. Signed-off-by: Grant B Adams --- drivers/power/supply/tps65217_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps65217_charger.c index a4bc9f2a10bc..6f68becdbfd0 100644 --- a/drivers/power/supply/tps65217_charger.c +++ b/drivers/power/supply/tps65217_charger.c @@ -238,7 +238,7 @@ static int tps65217_charger_probe(struct platform_device *pdev) for (i = 0; i < NUM_CHARGER_IRQS; i++) { ret = devm_request_threaded_irq(&pdev->dev, irq[i], NULL, tps65217_charger_irq, - IRQF_ONESHOT, "tps65217-charger", + IRQF_SHARED, "tps65217-charger", charger); if (ret) { dev_err(charger->dev, From patchwork Tue Aug 22 13:22:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grant B Adams X-Patchwork-Id: 13360784 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE136EE4993 for ; Tue, 22 Aug 2023 13:22:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235977AbjHVNWW (ORCPT ); Tue, 22 Aug 2023 09:22:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234984AbjHVNWV (ORCPT ); Tue, 22 Aug 2023 09:22:21 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DE25BE; Tue, 22 Aug 2023 06:22:19 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id 2adb3069b0e04-4fe11652b64so6823643e87.0; Tue, 22 Aug 2023 06:22:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692710537; x=1693315337; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wGWZmoxclOfYzjyLvlkmT9ZvCsngcDBgs2bkB2Nywss=; b=MU+J9C1wcQYK1gVd6TaxkuHqX/vrIL2N+Xf4RY2de74ButEFa7v7SxadrbCpR1MGTS Q/hFE7B9FkMWdi1sI/HhrIES+xG6AD8xtd2RG3WCR4167UVWEcTXxvHbWe65BkzTfj0o 9M+oxOi6klLSM/D2il+R3H0zzRSavyvt3bwCyEaGASZ5h7rRhvmtOl444QrxE4lPyt4T HeLSSmIr9Pco68I7488aywjAKKjJN8FRB3T7Y0FjlfoAvPWuZ2+32jfgfwH3HuPQ08iR uauXbpiTa+KhwC0wUIBLs569C0/4zzOWI5GKIK7tVYzPw6fmZsgl28jasITLIbMDSIUv RYlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692710537; x=1693315337; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wGWZmoxclOfYzjyLvlkmT9ZvCsngcDBgs2bkB2Nywss=; b=AqQswqTXtyJenE7iUC0KA84g6FUfrf1NX7M3DSlraMphRfVQCIGp5eD9EO4eFl/4wr rny/MMgzS5JqqgmnXleXkGfMZgAcw2Km2zI8SVv9VenrQcHuGORqNruxvUo0TCcktH20 oDLUbHoPgGgElJVk+4L4qsAk84d6POqHO8s1r34DA0nogiCnD+h8xLoi53XVRSXAsFXZ AGZw/zFzligzh5RFsYtVSjuDQTymvGY1tlKdtJKvY7c40mms/P52pMmU8yMc7g9wFYyO sIlQ1VX3t5z+gHxROg6NbvMlOv0CLTjIN9UwngfuwmeRiAusXlT66yNqxLdF4Y+jJV+m IHWw== X-Gm-Message-State: AOJu0Yw4XIQD7YiV/q2em+MRmmWSZDXDkem2lUq67a7Ho9smoNvgQmxw kp5GE3nPv05HBZVXC5ZapWH6jvp7/hmIoQ== X-Google-Smtp-Source: AGHT+IETp5Dr++LaS88bS0SWHxpcPKsyakg7Le7M3QyrWJ3aj7P0kb/fJ9wcgyjvLYdZbuMMot66Ew== X-Received: by 2002:ac2:4d90:0:b0:4f8:5905:8e0a with SMTP id g16-20020ac24d90000000b004f859058e0amr6176696lfe.6.1692710536887; Tue, 22 Aug 2023 06:22:16 -0700 (PDT) Received: from localhost.localdomain ([102.39.140.247]) by smtp.gmail.com with ESMTPSA id k11-20020a05640212cb00b005233f2635fbsm7575696edx.21.2023.08.22.06.22.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Aug 2023 06:22:16 -0700 (PDT) From: Grant B Adams Cc: linux-omap@vger.kernel.org, tony@atomide.com, Grant B Adams , Sebastian Reichel , Bin Liu , Greg Kroah-Hartman , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH 2/2] usb: musb: dsps: Fix vbus vs tps65217-charger irq conflict Date: Tue, 22 Aug 2023 15:22:02 +0200 Message-Id: <20230822132202.19659-1-nemith592@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org Enabling the tps65217-charger driver/module causes an interrupt conflict with the vbus driver resulting in a probe failure. The conflict is resolved by changing both driver's threaded interrupt request function from IRQF_ONESHOT to IRQF_SHARED. Signed-off-by: Grant B Adams --- drivers/usb/musb/musb_dsps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_dsps.c b/drivers/usb/musb/musb_dsps.c index 9119b1d51370..cbb45de5a76f 100644 --- a/drivers/usb/musb/musb_dsps.c +++ b/drivers/usb/musb/musb_dsps.c @@ -851,7 +851,7 @@ static int dsps_setup_optional_vbus_irq(struct platform_device *pdev, error = devm_request_threaded_irq(glue->dev, glue->vbus_irq, NULL, dsps_vbus_threaded_irq, - IRQF_ONESHOT, + IRQF_SHARED, "vbus", glue); if (error) { glue->vbus_irq = 0;