From patchwork Wed Aug 23 02:13:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Li Zhijian X-Patchwork-Id: 13361557 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B87DCEE49A5 for ; Wed, 23 Aug 2023 02:13:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232168AbjHWCNS (ORCPT ); Tue, 22 Aug 2023 22:13:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230462AbjHWCNS (ORCPT ); Tue, 22 Aug 2023 22:13:18 -0400 Received: from esa10.hc1455-7.c3s2.iphmx.com (esa10.hc1455-7.c3s2.iphmx.com [139.138.36.225]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3E7F3CEF; Tue, 22 Aug 2023 19:13:16 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10810"; a="116846128" X-IronPort-AV: E=Sophos;i="6.01,194,1684767600"; d="scan'208";a="116846128" Received: from unknown (HELO oym-r1.gw.nic.fujitsu.com) ([210.162.30.89]) by esa10.hc1455-7.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2023 11:13:13 +0900 Received: from oym-m1.gw.nic.fujitsu.com (oym-nat-oym-m1.gw.nic.fujitsu.com [192.168.87.58]) by oym-r1.gw.nic.fujitsu.com (Postfix) with ESMTP id A453AD29E6; Wed, 23 Aug 2023 11:13:11 +0900 (JST) Received: from kws-ab4.gw.nic.fujitsu.com (kws-ab4.gw.nic.fujitsu.com [192.51.206.22]) by oym-m1.gw.nic.fujitsu.com (Postfix) with ESMTP id D64C4D8B7F; Wed, 23 Aug 2023 11:13:10 +0900 (JST) Received: from localhost.localdomain (unknown [10.167.234.230]) by kws-ab4.gw.nic.fujitsu.com (Postfix) with ESMTP id 10EFF6B817; Wed, 23 Aug 2023 11:13:10 +0900 (JST) From: Li Zhijian To: linux-rdma@vger.kernel.org Cc: zyjzyj2000@gmail.com, jgg@ziepe.ca, leon@kernel.org, linux-kernel@vger.kernel.org, rpearsonhpe@gmail.com, Li Zhijian Subject: [PATCH 1/2] RDMA/rxe: add missing newline to rxe_set_mtu message Date: Wed, 23 Aug 2023 10:13:05 +0800 Message-Id: <20230823021306.170901-1-lizhijian@fujitsu.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-TM-AS-Product-Ver: IMSS-9.1.0.1417-9.0.0.1002-27830.003 X-TM-AS-User-Approved-Sender: Yes X-TMASE-Version: IMSS-9.1.0.1417-9.0.1002-27830.003 X-TMASE-Result: 10-0.490300-10.000000 X-TMASE-MatchedRID: UpZ+EYxJ0vntAplHZmS+xk7nLUqYrlslFIuBIWrdOePfUZT83lbkEMi+ UJljoDHwzhvnvWgCKR4AjeDwXx2MYgzyMxeMEX6wFEUknJ/kEl5jFT88f69nG/oLR4+zsDTtjoc zmuoPCq3iLksbXZuk3eG5Gam1ger6AgqwE4H+UHVKRyGul7qFUsNg6qN/5IWoubnZTxMUT3oiDU jqX2A6fCmjniQnoHNlwGQhKv4yiPQVwbf5lERMgI/2RRfVn5u4Tcu6aRtCI3BUKpNI+7y1VHsDE gQ63iHZ X-TMASE-SNAP-Result: 1.821001.0001-0-1-22:0,33:0,34:0-0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org A newline help flushing message out. Signed-off-by: Li Zhijian Reviewed-by: Daisuke Matsuda --- drivers/infiniband/sw/rxe/rxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/sw/rxe/rxe.c b/drivers/infiniband/sw/rxe/rxe.c index 54c723a6edda..cb2c0d54aae1 100644 --- a/drivers/infiniband/sw/rxe/rxe.c +++ b/drivers/infiniband/sw/rxe/rxe.c @@ -161,7 +161,7 @@ void rxe_set_mtu(struct rxe_dev *rxe, unsigned int ndev_mtu) port->attr.active_mtu = mtu; port->mtu_cap = ib_mtu_enum_to_int(mtu); - rxe_info_dev(rxe, "Set mtu to %d", port->mtu_cap); + rxe_info_dev(rxe, "Set mtu to %d\n", port->mtu_cap); } /* called by ifc layer to create new rxe device. From patchwork Wed Aug 23 02:13:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Li Zhijian X-Patchwork-Id: 13361558 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 219B8EE49A5 for ; Wed, 23 Aug 2023 02:13:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231279AbjHWCN1 (ORCPT ); Tue, 22 Aug 2023 22:13:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232192AbjHWCN0 (ORCPT ); Tue, 22 Aug 2023 22:13:26 -0400 Received: from esa12.hc1455-7.c3s2.iphmx.com (esa12.hc1455-7.c3s2.iphmx.com [139.138.37.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 966A8E4E; Tue, 22 Aug 2023 19:13:22 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10810"; a="108546362" X-IronPort-AV: E=Sophos;i="6.01,194,1684767600"; d="scan'208";a="108546362" Received: from unknown (HELO yto-r2.gw.nic.fujitsu.com) ([218.44.52.218]) by esa12.hc1455-7.c3s2.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2023 11:13:19 +0900 Received: from yto-m3.gw.nic.fujitsu.com (yto-nat-yto-m3.gw.nic.fujitsu.com [192.168.83.66]) by yto-r2.gw.nic.fujitsu.com (Postfix) with ESMTP id 9480DC68E5; Wed, 23 Aug 2023 11:13:15 +0900 (JST) Received: from kws-ab4.gw.nic.fujitsu.com (kws-ab4.gw.nic.fujitsu.com [192.51.206.22]) by yto-m3.gw.nic.fujitsu.com (Postfix) with ESMTP id BAD24D20AF; Wed, 23 Aug 2023 11:13:14 +0900 (JST) Received: from localhost.localdomain (unknown [10.167.234.230]) by kws-ab4.gw.nic.fujitsu.com (Postfix) with ESMTP id E39766B817; Wed, 23 Aug 2023 11:13:13 +0900 (JST) From: Li Zhijian To: linux-rdma@vger.kernel.org Cc: zyjzyj2000@gmail.com, jgg@ziepe.ca, leon@kernel.org, linux-kernel@vger.kernel.org, rpearsonhpe@gmail.com, Li Zhijian Subject: [PATCH 2/2] RDMA/rxe: Call rxe_set_mtu after rxe_register_device Date: Wed, 23 Aug 2023 10:13:06 +0800 Message-Id: <20230823021306.170901-2-lizhijian@fujitsu.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20230823021306.170901-1-lizhijian@fujitsu.com> References: <20230823021306.170901-1-lizhijian@fujitsu.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-TM-AS-Product-Ver: IMSS-9.1.0.1417-9.0.0.1002-27830.003 X-TM-AS-User-Approved-Sender: Yes X-TMASE-Version: IMSS-9.1.0.1417-9.0.1002-27830.003 X-TMASE-Result: 10--4.000400-10.000000 X-TMASE-MatchedRID: 5PeO86FyjNKIYY2hRSylnMQ4mpKyfkqZ0MQw+++ihy/qFRQsrMdGBLbS c9DZ5nsJJCq8bCHd+Z97L4dx4z+0QP9HU1IxzaoJSs47mbT7SAQh9mNF8ZPJ2J4Q+L3BXIWucwh qloOj04py+ROQfAr1jeaffHI8kAmiHY/bzRmIaZGqFx2c/3V5cf3l3BKhUmN/myiLZetSf8nyb6 HMFK1qe11j5mhaIsibJ0RPnyOnrZICgmfua/fPXtuW3D6HtXwtBOtTmZPZgcKgolbk5R0jWqi4O rUcQoc5QkbGFj8igiyBx2s7JQ1vW2HbVJe6RBtpX2C5l3vFPxjAYLx7rnbR8rDQ8m3TqgloelpC XnG+JjvDGBZ1G8r1Sf2D6gx/0ozp X-TMASE-SNAP-Result: 1.821001.0001-0-1-22:0,33:0,34:0-0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org rxe_set_mtu() will call rxe_info_dev() to print message, and rxe_info_dev() expects dev_name(rxe->ib_dev->dev) has been assigned. Previously since dev_name() is not set, when a new rxe link is being added, 'null' will be used as the dev_name like: "(null): rxe_set_mtu: Set mtu to 1024" Move rxe_register_device() earlier to assign the correct dev_name so that it can be read by rxe_set_mtu() later. And it's safe to do such change since mtu will not be used during the rxe_register_device() After this change, message becomes: "rxe_eth0: rxe_set_mtu: Set mtu to 4096" Signed-off-by: Li Zhijian Reviewed-by: Daisuke Matsuda --- drivers/infiniband/sw/rxe/rxe.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/sw/rxe/rxe.c b/drivers/infiniband/sw/rxe/rxe.c index cb2c0d54aae1..d29efce6e5ca 100644 --- a/drivers/infiniband/sw/rxe/rxe.c +++ b/drivers/infiniband/sw/rxe/rxe.c @@ -169,10 +169,13 @@ void rxe_set_mtu(struct rxe_dev *rxe, unsigned int ndev_mtu) */ int rxe_add(struct rxe_dev *rxe, unsigned int mtu, const char *ibdev_name) { + int ret; + rxe_init(rxe); + ret = rxe_register_device(rxe, ibdev_name); rxe_set_mtu(rxe, mtu); - return rxe_register_device(rxe, ibdev_name); + return ret; } static int rxe_newlink(const char *ibdev_name, struct net_device *ndev)