From patchwork Fri Sep 1 17:39:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 13372800 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64327CA0FEF for ; Fri, 1 Sep 2023 17:40:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345435AbjIARkb (ORCPT ); Fri, 1 Sep 2023 13:40:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235729AbjIARka (ORCPT ); Fri, 1 Sep 2023 13:40:30 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DD69CF3; Fri, 1 Sep 2023 10:40:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AF9D3B823C3; Fri, 1 Sep 2023 17:40:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0062FC433CA; Fri, 1 Sep 2023 17:40:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693590024; bh=HjNvhwGQdVXb8EZQzq8Ia733+IrZkicCXID9IHHZpm4=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=AJKbyuBNXxDA9ZizliaFC4nRA0kjDqRQHFZZWmEThhVHEvUPmBhy4Tv0YVHbMxTha HfBf5XqNQtvjvA+SNzHV7AJ+lNazq6zkdf8TdsJIsg+kiT2whDkutbs73ac9s1G2tX CoQWzPQn43S7+E0DJlnJNFgbSzf3JvsQMZkKTTAUJIrzUuxBttJL4osJQBm+dJnXjx atFcHzhlI86mWUky1K05+pXFnHwDoDy3Ysl7Oxmc5PtTWZTFn15yKMOAMXwcIneVg3 fegDffQ9LDRmWt3BJab+dq+4Ea0u3dDnNFy3761hQIccbMePzCWrAwIlkAWUIDmM4r pJEjFIriKEI/g== From: Jeff Layton Date: Fri, 01 Sep 2023 13:39:55 -0400 Subject: [PATCH fstests v2 1/3] generic/294: don't run this test on NFS MIME-Version: 1.0 Message-Id: <20230901-nfs-skip-v2-1-9eccd59bc524@kernel.org> References: <20230901-nfs-skip-v2-0-9eccd59bc524@kernel.org> In-Reply-To: <20230901-nfs-skip-v2-0-9eccd59bc524@kernel.org> To: fstests@vger.kernel.org Cc: linux-nfs@vger.kernel.org, Zorro Lang , Jeff Layton X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=864; i=jlayton@kernel.org; h=from:subject:message-id; bh=HjNvhwGQdVXb8EZQzq8Ia733+IrZkicCXID9IHHZpm4=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBk8iIGYs74+Rv8jzc/eL7sqtY4RZRtbAsH7p7jw w9RwTp1MHyJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCZPIiBgAKCRAADmhBGVaC Fcy0D/sHEQynAoEw9tWklNOCi3/EsxdAt7Ig79qRNhQgaFHu3avas7JTvXw0j/uxUPhNTKht9E/ Iz+Q0hZHmN/4KdnclYxYy1Py1aSenHSZiMKPxF0tgkM5w6TiNOKUMxM06KzZ4EA8mHv+/5glfY0 Pqd1d8SOxKQodSVmiuyddivzw5ZrvVQy2s4P7U9owRlTivdb9DOevBlVkHhd+Pu1A081wc+HlHx k1gB8V1wsL6LMzyCPRc7PVHQRwDJehGai5mmqlHSGXYK00fWMWLr9LkMnxESt6VXYxoJChObRYZ JJACcvKwH0A6wg3iZXVHheEblsfqvCavysW5o6eBTy6uiNS7oyTt3CPHLmY+CG/2Aq5d1ZSK4d3 iJybC0QwkeATuqyZBKLmCZPpmtXk5EL3JZbir9+9OztZzLvnpBnIBUpNPLvYNr8uFwgpOXCkvkB eN5xS3vIqlrVx3pH9D3vGDt5atq/HUcv7F2RGNCE/uiA+lip7vUSpNoz9elTJaZNyXWP1AvGeRl hzxGQtquE1OU0J/hoDxRKJ2Rjah6xpAK1L97jihyX3IeAcX2+VkHWKaSRJvz781zOu3YV2eCN2r MIoXQN/s3j7vauG5TKySiC7G3Eb5G1j8oM2L52Sb0W4r+IJp+/UAQBKi0Tz6NPyfVqAQunTpDfu aOtbl9c0t/0AJAQ== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org When creating a new dentry (of any type), NFS will optimize away any on-the-wire lookups prior to the create since that means an extra round trip to the server. Because of that, it consistently fails this test. Signed-off-by: Jeff Layton --- tests/generic/294 | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/generic/294 b/tests/generic/294 index 406b1b3954b9..46c7001234a5 100755 --- a/tests/generic/294 +++ b/tests/generic/294 @@ -15,8 +15,10 @@ _begin_fstest auto quick # real QA test starts here -# Modify as appropriate. -_supported_fs generic +# NFS will optimize away the on-the-wire lookup before attempting to +# create a new file (since that means an extra round trip). +_supported_fs ^nfs generic + _require_scratch _require_symlinks _require_mknod From patchwork Fri Sep 1 17:39:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 13372801 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF354CA0FED for ; Fri, 1 Sep 2023 17:40:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350441AbjIARkc (ORCPT ); Fri, 1 Sep 2023 13:40:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235729AbjIARkb (ORCPT ); Fri, 1 Sep 2023 13:40:31 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83DDBE54; Fri, 1 Sep 2023 10:40:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4502EB82522; Fri, 1 Sep 2023 17:40:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90976C433C9; Fri, 1 Sep 2023 17:40:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693590024; bh=UKS7WfwiBAf5L3NmDm0GoGm7mjygeHIx1WTlZp2pOqE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Zj2jIcx1jW0JgALfqpec4xfvlcDDegsCLacBNvcp1YEYNwqx6htxTiQZv0ZvydUou AG10CGiJBXZ3+92gZBG8pGMUJqvrDXtRBoWsN0VjGaB5Xz4E61s19GH6ty3ByScLdr lCFy5vfC1PWkBL7c4nvsK9tsBK0gkH7J4OefpkZ/jbbzna66paQIWrSyCcnNkb8/4e f6JcMEILkAhdNkmNPMk8SXUBihJHot3NJuI/qCroQrU6+4Uryfm8+46im2YyBLLIFp fHGKdy2GHfQ2xGR0afQoHFSGJ+sgPNq5b5irmBeOIPT3THHCEIYht+NzbHqPSPcU1L iEAlevNhsAyfA== From: Jeff Layton Date: Fri, 01 Sep 2023 13:39:56 -0400 Subject: [PATCH fstests v2 2/3] generic/357: don't run this test on NFS MIME-Version: 1.0 Message-Id: <20230901-nfs-skip-v2-2-9eccd59bc524@kernel.org> References: <20230901-nfs-skip-v2-0-9eccd59bc524@kernel.org> In-Reply-To: <20230901-nfs-skip-v2-0-9eccd59bc524@kernel.org> To: fstests@vger.kernel.org Cc: linux-nfs@vger.kernel.org, Zorro Lang , Jeff Layton X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=756; i=jlayton@kernel.org; h=from:subject:message-id; bh=UKS7WfwiBAf5L3NmDm0GoGm7mjygeHIx1WTlZp2pOqE=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBk8iIGOowBUBmRDnzgVXoy1VT1eHgwwLRmxjJ94 s3ClGUAuseJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCZPIiBgAKCRAADmhBGVaC FTfwD/0STzoYnbypLHV9JrNEcbjkS4eXJ2oO7RuLxsZDZkHb8IxtYuqlELWn9iXlOEJk7n0JPu0 MGmaVCEeoluvruAc5fAxFxLMJgtJNSXGLF2skD1MMwIP6Q4H3j6ukozPPf0fV+YitA62HnPGqEc 4wHWRD1fJOTuoqe0LsH9BAnY4emdl7WBMsy1x2NsuTX6Z574SyTfNNG+ZioyUSaAH0CxEhj4IpF +B6Z0vc8D3MBmx5VNEC+REnjTngoicihhGIQsRl4jwIypmylsJie4apehiEI7X1KJBvjAJaipEP EIa9GWNt6lvGOQMP1e4gb+GehJ6bmGi0mVrdUog7CUxzSscoF8E3hsiQSNfiwb9msOA+mCD1bpo X72CPe1XSwebNYzEL2LCsf4W/dKfRaDli5UiczMsQPIUYiHSC0nVd3XurJGDYwmKWxHmsaAWFND kvrgD2GDnTO3Fu5NZayNav+vEISSFn8JVw9JmJezpof9b+6MNOYfXNUH6tdxnCo9YeFajoQkWOv CDaOshA1MVGNbNaR/rWiNY2OmBuTJSwWCbeNyfI+STZ6dS7ltOllqhpx3+7YAR42KVb7OADziQS jjWy+GDPQ7HxoylF0kQr3WOPqXQ9EhF6h8GEePr/DPEMuRIpcy5fU2P1L7jtLyDL1pPGw3TwGy9 /qZs73ccdwdAz8w== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org NFS doesn't keep track of whether a file is reflinked or not, so it doesn't prevent this behavior. It shouldn't be a problem for NFS anyway, so just skip this test there. Signed-off-by: Jeff Layton --- tests/generic/357 | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/generic/357 b/tests/generic/357 index ce748f854327..a0299b32bc90 100755 --- a/tests/generic/357 +++ b/tests/generic/357 @@ -24,6 +24,11 @@ _cleanup() . ./common/reflink # real QA test starts here + +# For NFS, a reflink is just a CLONE operation, and after that +# point it's dealt with by the server. +_supported_fs ^nfs generic + _require_scratch_swapfile _require_scratch_reflink _require_cp_reflink From patchwork Fri Sep 1 17:39:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Layton X-Patchwork-Id: 13372802 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B916BCA0FEE for ; Fri, 1 Sep 2023 17:40:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350444AbjIARkd (ORCPT ); Fri, 1 Sep 2023 13:40:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345679AbjIARkc (ORCPT ); Fri, 1 Sep 2023 13:40:32 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23C45E5F; Fri, 1 Sep 2023 10:40:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 52EEFCE23ED; Fri, 1 Sep 2023 17:40:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C781C433CD; Fri, 1 Sep 2023 17:40:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693590025; bh=l2j+uv/+MikdtqQ3F2+J+3rQEZpSbqnYX/8LIP4jhGo=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=RDWxyLaW1kEsjwhDUjIogoBxbJIjuzXLI//gQ7sz7x/45mEaG+12y/u8XwG37fXGV eJyDhqRhfL03MzUw8h5ZGanmPh6L1Pyx2bHq4tx+BNcp43CNMYRUxFt0m1Syct4nub F8wq8QRDsqI//e8KmJdYgLczIkLmnz/a6DI1vloWLnfb30IwGb8PxNxatCRuspRLsB BPU/GgLW+2MvKCu4fZiGSqdc8Zq04nK6K/+u5IV7wVBjz5PM0YdovfixMzuswn9Xlh W4K0KR9cbkxFCfTqw4Q3d209bPCZuvh8A4GqMPHDAGitx3OGCvhmL1+4O17YNZXz7I UHbbYhSluJuuQ== From: Jeff Layton Date: Fri, 01 Sep 2023 13:39:57 -0400 Subject: [PATCH fstests v2 3/3] generic/187: don't run this test on NFS MIME-Version: 1.0 Message-Id: <20230901-nfs-skip-v2-3-9eccd59bc524@kernel.org> References: <20230901-nfs-skip-v2-0-9eccd59bc524@kernel.org> In-Reply-To: <20230901-nfs-skip-v2-0-9eccd59bc524@kernel.org> To: fstests@vger.kernel.org Cc: linux-nfs@vger.kernel.org, Zorro Lang , Jeff Layton X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=1122; i=jlayton@kernel.org; h=from:subject:message-id; bh=l2j+uv/+MikdtqQ3F2+J+3rQEZpSbqnYX/8LIP4jhGo=; b=owEBbQKS/ZANAwAIAQAOaEEZVoIVAcsmYgBk8iIHT+4iGaE6sqm2dib7aeJMbohKQNec8L/X4 m0paJUudUuJAjMEAAEIAB0WIQRLwNeyRHGyoYTq9dMADmhBGVaCFQUCZPIiBwAKCRAADmhBGVaC Fe43D/4qiB85y6dEnXVcO61XtWfDa5BVcXkH2EnobK/E/Q9/S99y/uWqz5MqlOLV+dqwab7bL8+ NqASWCCkL94aTclfS4i2HgzbIwoVCgPnc2U6A7Ru/poL9uaisaKE2kIRu8PkWXjmM67E/1b0aNl AtnX3RbeCh6UDa0vK14cF9xDcb5UYphJCfQqC+LArT4vKnrjZkHg8bYuQKSvZFkcnhFKY6n47fD xqMTRz+d9kMLsgybC/wNR2qkfJPuxjLWUCtkyFySrZxpqouE2KFWzwRHxeErAkALTR03vJ36/H4 HK5cA1+xWA+Z+t9E6qp1r2ArekvheswqlWlYpgnNjuxSBpl0scKtQxzb0hpC6MjGZclQGzFxy3P X1NUPv2JjgaFG6ZA9eCj2Fv5lShhjTQYHZ9eOZbzq+9cALMCGnq04XuI+NVKGbD8qWmAMBEiNBQ oDPr3OUJaqLNTenqY/7rBLoyWYy77bv//uh/IilxYvvo/Vm3kSsRp4Jm/06aV0KOqliwJHtKu38 fQZ3D3c6gGaMcBYQH5MJ7weWQU96IROoAkYAB/kVRTQcH12rHPmN4KfAIvKgEw132VxTvACXOps O59oDorvMOrCKxgqCAAx1QdOH6QFDCqgrtZajrhTAp1fbZhZ/eGPZnsINXSG+9EpoHWJIWdAGdP XDwAOGQHnAnIlgg== X-Developer-Key: i=jlayton@kernel.org; a=openpgp; fpr=4BC0D7B24471B2A184EAF5D3000E684119568215 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org This test is unreliable on NFS. It fails consistently when run vs. a server exporting btrfs, but passes when the server exports xfs. Since we don't have any sort of attribute that we can require to test this, just skip this one on NFS. Also, subsume the check for btrfs into the _supported_fs check, and add a comment for it. Signed-off-by: Jeff Layton --- tests/generic/187 | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/generic/187 b/tests/generic/187 index 0653b92f12f4..1b3509424462 100755 --- a/tests/generic/187 +++ b/tests/generic/187 @@ -29,13 +29,17 @@ _cleanup() . ./common/reflink # real QA test starts here + +# btrfs can't fragment free space. This test is unreliable on NFS, as it +# depends on the exported filesystem. +_supported_fs ^btrfs ^nfs generic _require_scratch_reflink _require_cp_reflink _require_xfs_io_command "falloc" _require_xfs_io_command "fpunch" -test $FSTYP = "btrfs" && _notrun "Can't fragment free space on btrfs." _require_odirect + _fragment_freesp() { file=$1