From patchwork Sun Sep 3 18:45:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 13373316 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80A12CA0FFB for ; Sun, 3 Sep 2023 18:46:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5D80E10E181; Sun, 3 Sep 2023 18:46:25 +0000 (UTC) Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by gabe.freedesktop.org (Postfix) with ESMTPS id D893E10E008; Sun, 3 Sep 2023 18:46:13 +0000 (UTC) Received: by mail-io1-xd2b.google.com with SMTP id ca18e2360f4ac-79275d86bc3so37875439f.0; Sun, 03 Sep 2023 11:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693766773; x=1694371573; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WS96irfNC14gdmDiFClarh9DIKJfgD77OErS65jXzQY=; b=Ttp4JPd4Jj33/XfdzSQIdkJBIO3nlWazutzzx51ULrEwEF1Yziiucpvzxs5gwI/BBL Cl1L/Jru9SyMKz3LfqT2RzVpgG7QjZGotFCHYuKcyUkmaXtBIpD5F9jc1tVpuNIIBz5l sJu/tSGY2s47xNcjnjqt6lANvMwsFF6hedXiGtqOZEVcUAGBr8n0iG4rFcxKAa+LSpfC M8ew2XY17k/PdxXb+1CCKHuOX8qUHSoBXuPBM4CDvJ9FptFw5cBZCc4gx7b0Fxy1X2uF ANweDl0OJoLBDHljRqBQMvO/INzKOjAYEtTzjQ30FnpVN68i2TMy+VYq43yo/yY9VuNG vkmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693766773; x=1694371573; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WS96irfNC14gdmDiFClarh9DIKJfgD77OErS65jXzQY=; b=k52w/YLPBhDQpKh6PgwiEGbhz61XwNyHTy9+UkxrH5cY2q3dWueHlfQ4uBbxhwvrlW +0bnVUFu8gJ3XvJfICmpA0KVH+Eryoyv+qSbGMJ690yYvvhlmef8QutIcccZsh2fZwis T9KwRLxLkuX32lC1nl438lca3RfIQ16/pHEX3uSQe7aR1SLdM4l7Cy0bgGBCXBqvv8x0 3Wb8GA6ctuLsw4ipND+h2t4g8/HVq2SwiBJca2EpUGy1UXIlGQ4gDe36B5UVHytdZrwK bKYWeWFmFI5P686tjG1eN1G1jvdCoNM2z/lscEXbjP0j4nmvwvqZx7CQSAoTyHwn7Bxg STfw== X-Gm-Message-State: AOJu0YxJ3JlauzFd12+OkqOjVWW+8axqtdtuET7DjiFs35FyCHp35mxa PTUz/n/SlS+DZ91L0rN+VoI= X-Google-Smtp-Source: AGHT+IFYCmR7Iv8xnRYnf/lKtlWv1bE7hNxZ00vdtzELzd9ulSSSQd6sJ4F8ae9sGd8UtxCQOEjWOw== X-Received: by 2002:a6b:ec16:0:b0:792:82f8:6f90 with SMTP id c22-20020a6bec16000000b0079282f86f90mr9317430ioh.16.1693766773070; Sun, 03 Sep 2023 11:46:13 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id u9-20020a02cb89000000b0042b37dda71asm2519968jap.136.2023.09.03.11.46.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Sep 2023 11:46:12 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Date: Sun, 3 Sep 2023 12:45:58 -0600 Message-ID: <20230903184607.272198-2-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230903184607.272198-1-jim.cromie@gmail.com> References: <20230903184607.272198-1-jim.cromie@gmail.com> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH v2 1/6] drm_dbg: add trailing newlines to msgs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Zimmermann , jani.nikula@intel.com, daniel.vetter@ffwll.ch, Maxime Ripard , Jim Cromie , seanpaul@chromium.org, daniel@ffwll.ch, David Airlie Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks. No functional changes. Signed-off-by: Jim Cromie --- drivers/gpu/drm/drm_connector.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index f28725736237..14020585bdc0 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -2925,7 +2925,9 @@ int drm_mode_getconnector(struct drm_device *dev, void *data, dev->mode_config.max_width, dev->mode_config.max_height); else - drm_dbg_kms(dev, "User-space requested a forced probe on [CONNECTOR:%d:%s] but is not the DRM master, demoting to read-only probe", + drm_dbg_kms(dev, + "User-space requested a forced probe on [CONNECTOR:%d:%s] " + "but is not the DRM master, demoting to read-only probe\n", connector->base.id, connector->name); } From patchwork Sun Sep 3 18:45:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 13373321 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47542C88CB2 for ; Sun, 3 Sep 2023 18:46:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6DA1910E1D9; Sun, 3 Sep 2023 18:46:37 +0000 (UTC) Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0F45410E06B; Sun, 3 Sep 2023 18:46:15 +0000 (UTC) Received: by mail-io1-xd32.google.com with SMTP id ca18e2360f4ac-79536bc6697so22152739f.1; Sun, 03 Sep 2023 11:46:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693766774; x=1694371574; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7joZjSDNylfwIjlN/v1EJKsLNVMUogPTU5+zZ+4Y2sA=; b=JCdB2JyUs215ve1xZsK0Pz6TtiG/b/L1m3rWJpR3MwvpbWHiC43XpsJvNeHo3r5bv+ yoTrkq1NnQRqW1oWkcWEuNT68g5Dxhx22F743WbOckqszhDC1FXAT82dPhBIPqHmQ/WO wkAQrMFJg7C1ZDs5EQpg0y4zyEgQmkhPkcGxBNYTDaXiTKwiS3FWYux9RsT2q5ecE2Hs By5dlBcbGSfiaxw4GExPgb3tfvNDNotsHF3f2zMBh/7QhntdYwA5J/Cxgz3/oN6Situu +Uj/DZsoXanCUJriVbbIWzu8mHR9IU7zTykCODsmY+AVNcCj1F8Dr1EdwI0rRieseokZ rdcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693766774; x=1694371574; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7joZjSDNylfwIjlN/v1EJKsLNVMUogPTU5+zZ+4Y2sA=; b=kf2dfEg85LWaZmtXdiZG9pbBcKizSjsJslssx1MvxmX5m9Hx8l4/cFSWmohp42P5Zf es3BHi1pjRbiFfHzBpAqfAKRS1e026QdrZZCkyc2r8QA3rEdF+mjHmb3ZfM37ZuL8rMW uHDmQkpqFWQ0vZh+MwCevO+STF0X2Pck1I5A4vFW1ffPsPSaDlUnkArJrsibhqaCCp2d T2Hrrr+tomTp6Mx0jvGBNpo6dpwk/M62Gcq4Ih9WTdXv7hdb88wdH6v7I2bxNQX87x45 1lO187nWn/mRYZYLl2kmYGE/7ygbcNIvT7KXn6wqnibdszq2IcAh9Kh+NPtGh89qx/Mc cfyg== X-Gm-Message-State: AOJu0YyuMIx95WDrN4voJldLsgiqIX07qTvCzoJTmTWfz4hyULwU7skf TY9y0zzkbBDKnFVGn96FsKg= X-Google-Smtp-Source: AGHT+IHUzoCTyhxdX6icAGEBT8dXiH/ioOo1c7WiBYkDqk/qvBXBfPW/4NAojWOMT3RGaqLcGBJwug== X-Received: by 2002:a05:6e02:964:b0:34c:abcb:97e8 with SMTP id q4-20020a056e02096400b0034cabcb97e8mr7956738ilt.24.1693766774237; Sun, 03 Sep 2023 11:46:14 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id u9-20020a02cb89000000b0042b37dda71asm2519968jap.136.2023.09.03.11.46.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Sep 2023 11:46:13 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Date: Sun, 3 Sep 2023 12:45:59 -0600 Message-ID: <20230903184607.272198-3-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230903184607.272198-1-jim.cromie@gmail.com> References: <20230903184607.272198-1-jim.cromie@gmail.com> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH v2 2/6] drm_dbg: add trailing newlines to msgs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jani.nikula@intel.com, daniel.vetter@ffwll.ch, Edmund Dea , Jim Cromie , seanpaul@chromium.org, daniel@ffwll.ch, Anitha Chrisanthus , David Airlie Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks. No functional changes. Signed-off-by: Jim Cromie --- drivers/gpu/drm/kmb/kmb_crtc.c | 10 +++++----- drivers/gpu/drm/kmb/kmb_plane.c | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/kmb/kmb_crtc.c b/drivers/gpu/drm/kmb/kmb_crtc.c index 647872f65bff..a58baf25322d 100644 --- a/drivers/gpu/drm/kmb/kmb_crtc.c +++ b/drivers/gpu/drm/kmb/kmb_crtc.c @@ -94,7 +94,7 @@ static void kmb_crtc_set_mode(struct drm_crtc *crtc, vm.hback_porch = 0; vm.hsync_len = 28; - drm_dbg(dev, "%s : %dactive height= %d vbp=%d vfp=%d vsync-w=%d h-active=%d h-bp=%d h-fp=%d hsync-l=%d", + drm_dbg(dev, "%s : %dactive height= %d vbp=%d vfp=%d vsync-w=%d h-active=%d h-bp=%d h-fp=%d hsync-l=%d\n", __func__, __LINE__, m->crtc_vdisplay, vm.vback_porch, vm.vfront_porch, vm.vsync_len, m->crtc_hdisplay, vm.hback_porch, @@ -194,24 +194,24 @@ static enum drm_mode_status int vfp = mode->vsync_start - mode->vdisplay; if (mode->vdisplay < KMB_CRTC_MAX_HEIGHT) { - drm_dbg(dev, "height = %d less than %d", + drm_dbg(dev, "height = %d less than %d\n", mode->vdisplay, KMB_CRTC_MAX_HEIGHT); return MODE_BAD_VVALUE; } if (mode->hdisplay < KMB_CRTC_MAX_WIDTH) { - drm_dbg(dev, "width = %d less than %d", + drm_dbg(dev, "width = %d less than %d\n", mode->hdisplay, KMB_CRTC_MAX_WIDTH); return MODE_BAD_HVALUE; } refresh = drm_mode_vrefresh(mode); if (refresh < KMB_MIN_VREFRESH || refresh > KMB_MAX_VREFRESH) { - drm_dbg(dev, "refresh = %d less than %d or greater than %d", + drm_dbg(dev, "refresh = %d less than %d or greater than %d\n", refresh, KMB_MIN_VREFRESH, KMB_MAX_VREFRESH); return MODE_BAD; } if (vfp < KMB_CRTC_MIN_VFP) { - drm_dbg(dev, "vfp = %d less than %d", vfp, KMB_CRTC_MIN_VFP); + drm_dbg(dev, "vfp = %d less than %d\n", vfp, KMB_CRTC_MIN_VFP); return MODE_BAD; } diff --git a/drivers/gpu/drm/kmb/kmb_plane.c b/drivers/gpu/drm/kmb/kmb_plane.c index 9e0562aa2bcb..308bd1cb50c8 100644 --- a/drivers/gpu/drm/kmb/kmb_plane.c +++ b/drivers/gpu/drm/kmb/kmb_plane.c @@ -78,7 +78,7 @@ static unsigned int check_pixel_format(struct drm_plane *plane, u32 format) * plane configuration is not supported. */ if (init_disp_cfg.format && init_disp_cfg.format != format) { - drm_dbg(&kmb->drm, "Cannot change format after initial plane configuration"); + drm_dbg(&kmb->drm, "Cannot change format after initial plane configuration\n"); return -EINVAL; } for (i = 0; i < plane->format_count; i++) { @@ -124,7 +124,7 @@ static int kmb_plane_atomic_check(struct drm_plane *plane, if ((init_disp_cfg.width && init_disp_cfg.height) && (init_disp_cfg.width != fb->width || init_disp_cfg.height != fb->height)) { - drm_dbg(&kmb->drm, "Cannot change plane height or width after initial configuration"); + drm_dbg(&kmb->drm, "Cannot change plane height or width after initial configuration\n"); return -EINVAL; } can_position = (plane->type == DRM_PLANE_TYPE_OVERLAY); @@ -375,7 +375,7 @@ static void kmb_plane_atomic_update(struct drm_plane *plane, spin_lock_irq(&kmb->irq_lock); if (kmb->kmb_under_flow || kmb->kmb_flush_done) { spin_unlock_irq(&kmb->irq_lock); - drm_dbg(&kmb->drm, "plane_update:underflow!!!! returning"); + drm_dbg(&kmb->drm, "plane_update:underflow!!!! returning\n"); return; } spin_unlock_irq(&kmb->irq_lock); From patchwork Sun Sep 3 18:46:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 13373320 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2A4BC88CB2 for ; Sun, 3 Sep 2023 18:46:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 01ECC10E1D4; Sun, 3 Sep 2023 18:46:32 +0000 (UTC) Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by gabe.freedesktop.org (Postfix) with ESMTPS id 19BB810E17B; Sun, 3 Sep 2023 18:46:19 +0000 (UTC) Received: by mail-io1-xd36.google.com with SMTP id ca18e2360f4ac-792975085b2so37498439f.1; Sun, 03 Sep 2023 11:46:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693766778; x=1694371578; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NxH9YviFYJ/sVQ921jdxmjDcbIQzwn47fQGdVFEkDL8=; b=WwncGzCLU+qQCq7Rkz27rjvhKVWsx/tKhakzC0jqkGgomgFaKYXkOJTYa5pRV8Q/wh P0l6eK2gDndbGEU62Ti1dfkPfBaD2KCTV8a0Z3W9AA6yqpuNZDijmOajFHU7zfpC3WbP IJOwRvYft+Pek2s9jzVZN9Q2Vksx4BW5gKPmfWZAzJwqAKQ0xw8EYF2qwWeV91B1B8m0 D1QQ/1JLtl9zuav6DcttWJIShEKA8QLIt+LqDcImVyhejHhlxPe2vp7WOoxiyz3cYQij czIhOiIrtAIcJ7qhv1KmoIAhFBtwOy5uJcE12y/e3PV8Wykf3KUKsSdye7QZM7fkzPsR 9jEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693766778; x=1694371578; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NxH9YviFYJ/sVQ921jdxmjDcbIQzwn47fQGdVFEkDL8=; b=F5xuwiiHSlxVwAtePJvtR9AmtVjozT4fQ728pxqD4vi3SXvUOW/r0KW+Y34i4fqIiL z9ztnRDPC17Zu1FTUw8PGkqP5Id9ze0DoIPx8Eu9wfAZtMV1zzuZxl+0HT2Lc1Di2P1F 4Al3Pr0sKQpHjHTEO2Ff1GfGIWpSJrC3lKF85yBhr2SH1TNZU8CZ7SIj7zHezHXL7+0L xNh7WI/BRX+vuZ+znFqT7BvVi1/LNJoH7YV7uq8KY2UsOD3vZT4CaSntKw5KME6nNfbG RRtHXYsIRH8Otm1VeTvfbIcuyhbdpdfkHDzHEeAOLCI8jPMHQ5vq3dYGrfTazE9QAypg 40mA== X-Gm-Message-State: AOJu0YwOQXb9cxWWQPc8vBwbvf4dSe3deIHctlsA4fNP7gqb3riYuQo1 MBtwPw4297agtY0K/+IZk8s= X-Google-Smtp-Source: AGHT+IFaoNhYGsbvB6jznT4bSDBnIoFY2jvJJdHmVHBwkTi3nPyjBv03yWffGFhGkV6csSuj+h269g== X-Received: by 2002:a92:dad2:0:b0:34d:e998:fb4f with SMTP id o18-20020a92dad2000000b0034de998fb4fmr7949087ilq.10.1693766778270; Sun, 03 Sep 2023 11:46:18 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id u9-20020a02cb89000000b0042b37dda71asm2519968jap.136.2023.09.03.11.46.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Sep 2023 11:46:17 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Date: Sun, 3 Sep 2023 12:46:00 -0600 Message-ID: <20230903184607.272198-4-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230903184607.272198-1-jim.cromie@gmail.com> References: <20230903184607.272198-1-jim.cromie@gmail.com> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH v2 3/6] drm_dbg: add trailing newlines to msgs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Jason A. Donenfeld" , daniel.vetter@ffwll.ch, Chris Wilson , Andrzej Hajda , David Airlie , Rob Clark , Matthew Auld , jani.nikula@intel.com, seanpaul@chromium.org, Rodrigo Vivi , Jim Cromie , daniel@ffwll.ch Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks. No functional changes. Signed-off-by: Jim Cromie Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c index 090f242e610c..0a196348e2d1 100644 --- a/drivers/gpu/drm/i915/display/intel_ddi.c +++ b/drivers/gpu/drm/i915/display/intel_ddi.c @@ -4171,7 +4171,7 @@ static int intel_ddi_compute_config_late(struct intel_encoder *encoder, struct drm_connector *connector = conn_state->connector; u8 port_sync_transcoders = 0; - drm_dbg_kms(&i915->drm, "[ENCODER:%d:%s] [CRTC:%d:%s]", + drm_dbg_kms(&i915->drm, "[ENCODER:%d:%s] [CRTC:%d:%s]\n", encoder->base.base.id, encoder->base.name, crtc_state->uapi.crtc->base.id, crtc_state->uapi.crtc->name); diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c index cfd7929587d8..29c40e8a7183 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c @@ -1436,7 +1436,7 @@ eb_relocate_entry(struct i915_execbuffer *eb, if (unlikely(reloc->write_domain & (reloc->write_domain - 1))) { drm_dbg(&i915->drm, "reloc with multiple write domains: " "target %d offset %d " - "read %08x write %08x", + "read %08x write %08x\n", reloc->target_handle, (int) reloc->offset, reloc->read_domains, @@ -1447,7 +1447,7 @@ eb_relocate_entry(struct i915_execbuffer *eb, & ~I915_GEM_GPU_DOMAINS)) { drm_dbg(&i915->drm, "reloc with read/write non-GPU domains: " "target %d offset %d " - "read %08x write %08x", + "read %08x write %08x\n", reloc->target_handle, (int) reloc->offset, reloc->read_domains, From patchwork Sun Sep 3 18:46:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 13373318 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9DB5C71153 for ; Sun, 3 Sep 2023 18:46:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EBDCF10E1B3; Sun, 3 Sep 2023 18:46:28 +0000 (UTC) Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 56F2510E008; Sun, 3 Sep 2023 18:46:20 +0000 (UTC) Received: by mail-io1-xd31.google.com with SMTP id ca18e2360f4ac-792623074edso32724039f.1; Sun, 03 Sep 2023 11:46:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693766779; x=1694371579; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VQ/W1vAuvct0eQaNfV42dDs6Is2Bz/K+5cHGfVn4Nlg=; b=MNEL8PWtVnTFfXGWQnjgJ8oYdsYcbHT3eg6KZg/PG6PM/uNg3Z/D8s5yvxKvCtpeVp kIUa2J0191+tPntP/bXNg31kfYU8ynX0Q0r21h9EHEAi46PVs8yY4oyxK6XRKaeVK8kT RU8XXmyyUXAh9XfKqzN9MhVURXma68yjKr3vKAEGHmq7LC+dunUeST3RDAdOtOnXQHXC C6o0JDsW9NekeKrJMDKrP+Ko2YFXy33wZlg5KJ47wckgTu6gIyy4/ysRTnxbBDKQaSEt sE6BIoGrPu4c1hF9ee3AGG5JI8FsYqOqOkKROzO59+3509R1ReFbWlsxjfrOccWZ6cA4 XhtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693766779; x=1694371579; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VQ/W1vAuvct0eQaNfV42dDs6Is2Bz/K+5cHGfVn4Nlg=; b=UcJ8feBDIBxbZsbwb8N1rWXkKV/sWVBymOSAXQggo3h/m13qW1jDpJBtJlTSJsyPOD UPS9cLHkI8pusk1OHqvM525a7ctBRvtGhijGd7/eC70i/6/Jkswi9tIBv4Bxo53f1R+C NPodn1+ztIFqbk01Brhsmp0o9+CM4JXnJNXdTe7yORn6ItmZBackov06uL/exDIWXB8s vRvAk0J0ltCO6f54LM1tcOZLKi77RODrgGfs8sodAo1BhK3ROdnoy2ExW6U4vvdRVYzG UZ/NHzssqJWj4qcedhX6pS+A+q1OwQgvITdJuyDB27XzVESngxt7K3Gbj0TyufZRanWs j1Pw== X-Gm-Message-State: AOJu0YybP5G9P/m501qzML4kbdKD3NFh3MimyWznggXPbriBj3WSSoCD 36VWrZGeBx1u+/yJUgx8734= X-Google-Smtp-Source: AGHT+IG0oYogHO+wAh1Qc2b0RpBbRi8d3sGxNY89NwIzDxZvPXy3apKKIsYkF1LHmvM+09NoaEvKYw== X-Received: by 2002:a05:6e02:184e:b0:34d:ecbb:9cc4 with SMTP id b14-20020a056e02184e00b0034decbb9cc4mr10979635ilv.3.1693766779453; Sun, 03 Sep 2023 11:46:19 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id u9-20020a02cb89000000b0042b37dda71asm2519968jap.136.2023.09.03.11.46.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Sep 2023 11:46:19 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Date: Sun, 3 Sep 2023 12:46:01 -0600 Message-ID: <20230903184607.272198-5-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230903184607.272198-1-jim.cromie@gmail.com> References: <20230903184607.272198-1-jim.cromie@gmail.com> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH v2 4/6] drm_dbg: add trailing newlines to msgs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, jani.nikula@intel.com, daniel.vetter@ffwll.ch, Abhinav Kumar , Jim Cromie , seanpaul@chromium.org, daniel@ffwll.ch, linux-arm-msm@vger.kernel.org, Dmitry Baryshkov , Marijn Suijten , David Airlie Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks. No functional changes. Signed-off-by: Jim Cromie --- drivers/gpu/drm/msm/msm_fb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_fb.c b/drivers/gpu/drm/msm/msm_fb.c index e3f61c39df69..80166f702a0d 100644 --- a/drivers/gpu/drm/msm/msm_fb.c +++ b/drivers/gpu/drm/msm/msm_fb.c @@ -89,7 +89,7 @@ int msm_framebuffer_prepare(struct drm_framebuffer *fb, for (i = 0; i < n; i++) { ret = msm_gem_get_and_pin_iova(fb->obj[i], aspace, &msm_fb->iova[i]); - drm_dbg_state(fb->dev, "FB[%u]: iova[%d]: %08llx (%d)", + drm_dbg_state(fb->dev, "FB[%u]: iova[%d]: %08llx (%d)\n", fb->base.id, i, msm_fb->iova[i], ret); if (ret) return ret; @@ -176,7 +176,7 @@ static struct drm_framebuffer *msm_framebuffer_init(struct drm_device *dev, const struct msm_format *format; int ret, i, n; - drm_dbg_state(dev, "create framebuffer: mode_cmd=%p (%dx%d@%4.4s)", + drm_dbg_state(dev, "create framebuffer: mode_cmd=%p (%dx%d@%4.4s)\n", mode_cmd, mode_cmd->width, mode_cmd->height, (char *)&mode_cmd->pixel_format); @@ -232,7 +232,7 @@ static struct drm_framebuffer *msm_framebuffer_init(struct drm_device *dev, refcount_set(&msm_fb->dirtyfb, 1); - drm_dbg_state(dev, "create: FB ID: %d (%p)", fb->base.id, fb); + drm_dbg_state(dev, "create: FB ID: %d (%p)\n", fb->base.id, fb); return fb; From patchwork Sun Sep 3 18:46:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 13373322 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87D89C83F2C for ; Sun, 3 Sep 2023 18:46:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AB0EA10E1F6; Sun, 3 Sep 2023 18:46:45 +0000 (UTC) Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5CE2910E181; Sun, 3 Sep 2023 18:46:21 +0000 (UTC) Received: by mail-io1-xd36.google.com with SMTP id ca18e2360f4ac-77acb04309dso37719439f.2; Sun, 03 Sep 2023 11:46:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693766780; x=1694371580; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A7euIhAUxsBgqAycWxnasjxETI8zYNC1RLZ3qD73WsM=; b=enwkai3t/rnjxv6OiAhe+NzNvbQ0abppn5KbHTT2Fb7VUMxvxR1qmf/d9NRntx4uyz s+hlxSuE/w3X4gEP+Y/zClA0io5G3iYL4CEdbAcVXjYISufpudQORggvqxAmSEFzP2hf 0AbmlPYXPWBrEuVTSfvY3wqCICxvp/AGwROddGTvEtvYOjekkZMvuGYnVR3QB48tjPqT bnvRxgTEMZvKweTkv575EhZahX1ltLdEXJICripIYD4i9hgocTmUmpijAp7oFeQk1DvL fIawQlyGG98ccNMppXRm6ya61Nl+YffwtdlfNph7j56p+12ZxH4rfxlsbyrow709L/wC WBxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693766780; x=1694371580; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A7euIhAUxsBgqAycWxnasjxETI8zYNC1RLZ3qD73WsM=; b=Y4fDiSKZavQkdPcRrG9V8+gX1wyPhGphmckgFkAAfzDxsBbwzuSwVuymcPDmddJypw ULj4KjNcHXkkDUHbUDpTY7wtc9DAre1DnjmsOGb82wA6sb1NNeHidL7S/ZY2+rTQ0wVd g+BoGQUkmZ7uq7ppInGlTc5Z0/+69oruHHBkZUR+/wyiYjQRZaopygvLE2l6ojQ9WjBw kotLet7MHm5LatqOiLUvUU2ZlgVHvvuOJZrI+y5pZzUhehiWDuf431aBM4eeyx7Wdppt M5HzyifRoyyLLU8XFsmFQgDjHVoxxQzl3ywZ5TlMFMo+5dxfs6MLs0yXHM9oDqsijroO H04w== X-Gm-Message-State: AOJu0Yzq1p7YQ1BbCsbxcv6/4fhognwItkyqdZYkh5egfZjy+TSqvd7H 04ktxEX30yfmMtNC/+Kjmg3K42O+jx7eYA== X-Google-Smtp-Source: AGHT+IFezAhzBe8bHNafQV2ls3Rrm07SEuvb9e6ZJAhZmonaPCE5ktQ5RYLT+3Q1JAWulfB2inkf2w== X-Received: by 2002:a6b:5103:0:b0:792:9333:2cbf with SMTP id f3-20020a6b5103000000b0079293332cbfmr9837914iob.6.1693766780607; Sun, 03 Sep 2023 11:46:20 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id u9-20020a02cb89000000b0042b37dda71asm2519968jap.136.2023.09.03.11.46.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Sep 2023 11:46:20 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Date: Sun, 3 Sep 2023 12:46:02 -0600 Message-ID: <20230903184607.272198-6-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230903184607.272198-1-jim.cromie@gmail.com> References: <20230903184607.272198-1-jim.cromie@gmail.com> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH v2 5/6] drm_dbg: add trailing newlines to msgs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emma Anholt , jani.nikula@intel.com, daniel.vetter@ffwll.ch, Maxime Ripard , Jim Cromie , seanpaul@chromium.org, daniel@ffwll.ch, David Airlie Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks. No functional changes. Signed-off-by: Jim Cromie --- drivers/gpu/drm/vc4/vc4_crtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index bef9d45ef1df..959123759711 100644 --- a/drivers/gpu/drm/vc4/vc4_crtc.c +++ b/drivers/gpu/drm/vc4/vc4_crtc.c @@ -592,7 +592,7 @@ static void vc4_crtc_atomic_disable(struct drm_crtc *crtc, struct drm_encoder *encoder = vc4_get_crtc_encoder(crtc, old_state); struct drm_device *dev = crtc->dev; - drm_dbg(dev, "Disabling CRTC %s (%u) connected to Encoder %s (%u)", + drm_dbg(dev, "Disabling CRTC %s (%u) connected to Encoder %s (%u)\n", crtc->name, crtc->base.id, encoder->name, encoder->base.id); require_hvs_enabled(dev); @@ -620,7 +620,7 @@ static void vc4_crtc_atomic_enable(struct drm_crtc *crtc, struct vc4_encoder *vc4_encoder = to_vc4_encoder(encoder); int idx; - drm_dbg(dev, "Enabling CRTC %s (%u) connected to Encoder %s (%u)", + drm_dbg(dev, "Enabling CRTC %s (%u) connected to Encoder %s (%u)\n", crtc->name, crtc->base.id, encoder->name, encoder->base.id); if (!drm_dev_enter(dev, &idx)) From patchwork Sun Sep 3 18:46:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 13373319 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B61A3C71153 for ; Sun, 3 Sep 2023 18:46:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3922310E1D3; Sun, 3 Sep 2023 18:46:31 +0000 (UTC) Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) by gabe.freedesktop.org (Postfix) with ESMTPS id AA30A10E1A1; Sun, 3 Sep 2023 18:46:22 +0000 (UTC) Received: by mail-il1-x130.google.com with SMTP id e9e14a558f8ab-34df008b0cbso3303145ab.1; Sun, 03 Sep 2023 11:46:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693766782; x=1694371582; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9+vShd9z6JIlJdMcVT9ozEMb7ECMtYhQaxypaqn+ojI=; b=gsG7vqqREloVFGLQnEO9qOBUm3hP/oMcF+m2BCq68YPNrflltw3N+FN1LMoJOvlgQe 2VlGc7IfBWyUjeEACWGHqYuy3d9TvY5UJtKFfNNyrytreyC7n0CWo45J9B9A3tpoh4J8 TizawBiB6p/1Ypwl+D7Oeix8ePXy1HEvaAPLgF8jpkmKjUx7tgPf/DxqgM0qRrXxbrEK 1amYyM5QzHRoyGWW0GDgeouyx/uC368Gu42qvJCrhmTMLS1sqi7rSXcG5pk5jPpWHKXY rT02ZjicRDoNpo2rTM8S2/KKQroWk+M58cpdVo9X6C6bfDcSWxHWEKho9DoenBDuh0hb bjTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693766782; x=1694371582; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9+vShd9z6JIlJdMcVT9ozEMb7ECMtYhQaxypaqn+ojI=; b=MW9IveanG2u26KxmtZCnmblLyAXe8iUHheIvnTjj3xuQhzJa/cVAtfQbADZLUVuM0j cuxiKlmQb9pVAvOwFkQsB3dXRLUnJG2VMV3OtWdjV2ErhEM0V9VO+bmtH+CDOUBX+tgX +JLJ6JqccG6ozLWkzPrTuz3nshQQRjmIhAG/Nmo9b4L55VvT67JiyHRoDkBDTk97PtTc nCBKhnN5UN+8CPGXthqfSqWcBsIfXvAaIqjuAd8BcsuF/gIuKOLUjQ8dyzmOfIvqEpl1 gmHCBfatMLanUmlPS17LtjVrnIF1f57wyfjoCKLd9r4p+lSk+oYiJCY7G1CfhxoHcScZ EEvQ== X-Gm-Message-State: AOJu0YyFJgJrUbMUn6VnBQhZRQG5y/UBxI8LUQcH90CkTn0+0Glyo0xK jj/AI44cV8WL/xqvcZAfWdk= X-Google-Smtp-Source: AGHT+IGqOoyhaY6/BLxjGQwr9jgSrLCBNKR3l+qSBXjy+8E6+buexCVqqyAEqMiNiyX8+oyGCVjU2Q== X-Received: by 2002:a05:6e02:e12:b0:349:9993:f223 with SMTP id a18-20020a056e020e1200b003499993f223mr8706895ilk.23.1693766781766; Sun, 03 Sep 2023 11:46:21 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id u9-20020a02cb89000000b0042b37dda71asm2519968jap.136.2023.09.03.11.46.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Sep 2023 11:46:21 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Date: Sun, 3 Sep 2023 12:46:03 -0600 Message-ID: <20230903184607.272198-7-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230903184607.272198-1-jim.cromie@gmail.com> References: <20230903184607.272198-1-jim.cromie@gmail.com> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH v2 6/6] drm: use correct ccflags-y syntax X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Zimmermann , jani.nikula@intel.com, daniel.vetter@ffwll.ch, Maxime Ripard , Jim Cromie , seanpaul@chromium.org, daniel@ffwll.ch, Greg Kroah-Hartman , David Airlie Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Incorrect CFLAGS- usage failed to add -DDYNAMIC_DEBUG_MODULE, which broke builds with: CONFIG_DRM_USE_DYNAMIC_DEBUG=Y CONFIG_DYNAMIC_DEBUG_CORE=Y, but CONFIG_DYNAMIC_DEBUG=N Also add subdir-ccflags so that all drivers pick up the addition. Fixes: 84ec67288c10 ("drm_print: wrap drm_*_dbg in dyndbg descriptor factory macro") Signed-off-by: Jim Cromie --- drivers/gpu/drm/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 7a09a89b493b..013cde886326 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -3,7 +3,8 @@ # Makefile for the drm device driver. This driver provides support for the # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. -CFLAGS-$(CONFIG_DRM_USE_DYNAMIC_DEBUG) += -DDYNAMIC_DEBUG_MODULE +ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG) += -DDYNAMIC_DEBUG_MODULE +subdir-ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG) += -DDYNAMIC_DEBUG_MODULE drm-y := \ drm_aperture.o \