From patchwork Wed Sep 6 19:02:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 13375903 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25EF5EE14D0 for ; Wed, 6 Sep 2023 19:02:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 63E2110E70D; Wed, 6 Sep 2023 19:02:36 +0000 (UTC) Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by gabe.freedesktop.org (Postfix) with ESMTPS id ADDB810E064; Wed, 6 Sep 2023 19:02:31 +0000 (UTC) Received: by mail-io1-xd2b.google.com with SMTP id ca18e2360f4ac-7927611c54bso4351039f.2; Wed, 06 Sep 2023 12:02:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694026951; x=1694631751; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WS96irfNC14gdmDiFClarh9DIKJfgD77OErS65jXzQY=; b=olM0Eazh76MoJPGntnFvf531vRaxVkT7JjC2HtkTpFOZKxs03YTliC8lQWYwX6BU6O vK3FoCPiKi6px/EPlZwLXXivEvdeVZjl1sNVwOpbadY+CB6T/ahEvrc88/9111D91nQ6 ULUvZr1OuWFR5QMWtN9xw89PKzK/Fqv0caXayNOgaGW74/10TJKA5jAzkJ7Oy2mpBhJf EaJ0jKs6YhO+zWs+FslkbYQUKHAkZ3pEfyIDbbb0y3aFNjoPrdxpoOLe/IHrFkp5RJJp 1Ljg5/FBE0tjt2fm/f7xxBUPalhbi1Sfosn+hdTidyq4Xi0HLBMn91Dgc22puy/QrsKH cl1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694026951; x=1694631751; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WS96irfNC14gdmDiFClarh9DIKJfgD77OErS65jXzQY=; b=DzvjEq92SW8JpPrwudy6RpFc8fWGRJzsjTHTPFC9bEqAhkTB4+DNS3nntf616dp85g 3vpgX39DnmosAAZhjKitjY2DwMZlaHHTpY9IPr/A7H29Dz52K6moIS5a6Qhh+B8wlNoK IMHpEvs5N4/2+0Jp46PR8dZFII+oyUh/Kz9mN1mBVn3re8++b3AZ9lEe5uhLe5g+G1US oJlVaABaZvwCz7SLBo5a8+W1t+JgHcHm+QhFvMlSezOLD9Nuc4K8KEFGteCf59AVDosx Mi6Lqgo0XDX/NRPuTS/xJ4ByBwqcgkpAybtbm4mkcRAICVahm/h3G+NLuRo+tgkZ5ou1 1Tww== X-Gm-Message-State: AOJu0YwzbhVU7mDYFgMiHucnZ70DtcDbxFqG7cXV03VB2eJ2zH9atdji Thw3CYVtbs22Cxqsz2mbZao= X-Google-Smtp-Source: AGHT+IEm+/duIejOs4uEx0V1ECGyB/EMXsZAKUYZsERs5kQRkhUOS9SyRyr5dfsXrmwu8JiEQjVuXQ== X-Received: by 2002:a6b:5c0c:0:b0:787:230f:55b1 with SMTP id z12-20020a6b5c0c000000b00787230f55b1mr18474144ioh.2.1694026950925; Wed, 06 Sep 2023 12:02:30 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id w11-20020a5d844b000000b0076ffebfc9fasm5152306ior.47.2023.09.06.12.02.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 12:02:30 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: [PATCH v3 1/5] drm/connector: add trailing newlines to drm_dbg msgs Date: Wed, 6 Sep 2023 13:02:19 -0600 Message-ID: <20230906190224.583577-2-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230906190224.583577-1-jim.cromie@gmail.com> References: <20230906190224.583577-1-jim.cromie@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Zimmermann , jani.nikula@intel.com, daniel.vetter@ffwll.ch, Maxime Ripard , seanpaul@chromium.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks. No functional changes. Signed-off-by: Jim Cromie --- drivers/gpu/drm/drm_connector.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c index f28725736237..14020585bdc0 100644 --- a/drivers/gpu/drm/drm_connector.c +++ b/drivers/gpu/drm/drm_connector.c @@ -2925,7 +2925,9 @@ int drm_mode_getconnector(struct drm_device *dev, void *data, dev->mode_config.max_width, dev->mode_config.max_height); else - drm_dbg_kms(dev, "User-space requested a forced probe on [CONNECTOR:%d:%s] but is not the DRM master, demoting to read-only probe", + drm_dbg_kms(dev, + "User-space requested a forced probe on [CONNECTOR:%d:%s] " + "but is not the DRM master, demoting to read-only probe\n", connector->base.id, connector->name); } From patchwork Wed Sep 6 19:02:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 13375902 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4CE7EE14D0 for ; Wed, 6 Sep 2023 19:02:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5A63410E70C; Wed, 6 Sep 2023 19:02:36 +0000 (UTC) Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by gabe.freedesktop.org (Postfix) with ESMTPS id D9CE610E1CA; Wed, 6 Sep 2023 19:02:32 +0000 (UTC) Received: by mail-io1-xd36.google.com with SMTP id ca18e2360f4ac-77a62a84855so5042039f.1; Wed, 06 Sep 2023 12:02:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694026952; x=1694631752; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7joZjSDNylfwIjlN/v1EJKsLNVMUogPTU5+zZ+4Y2sA=; b=Tp8CBU5FYUpqAmt0782HGt/w57+sx8LZRCtYLi6Zvi/hIxaatLtU9OxiDfCmT23MiD YCS+hvFlXHwfmxLD6erCrmnt0AJ7n1CsFXWYN+H3MJUkf6G5GZGb4jQby8wDWPLwv1bS 6Gbt/JKM8E2/fBN61fp41btHo5JRU0Ldntc8RbJ2wWZyWALJkdUZCFCi4OuCJs6mk/np UF/BjpwWfMPXaeXZxPIz4GGeRc+M0/T+Czz5GQp9KQUPqQEvSUjk1iVVXIqTd7l9s1Vl TXcOYW9QnCdU1+AMCxeZUy0AjtP+V0PdO9Wo1WcIzsVWbiQ1zOyzyfU6Gya94012/BTu GH4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694026952; x=1694631752; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7joZjSDNylfwIjlN/v1EJKsLNVMUogPTU5+zZ+4Y2sA=; b=YUKM42lRGoqLyTI8IzM9xz2UTOP4YbcyFqTOtdY3k7vlvlVHpWeRKFD5Xlpwbv1hO+ LdrBVzi5P5vLxjrgxHzGr/EGw+RAS2w4MLxCh2dbSgkJAqKhvJRh8qFGaLKD1c7/fFzX ZNlldqddhrNzz3FiokjT7p9JpsBxfEZMC4xluqInFwcy3GEaYxSK7f58eu+5TxEoSD1a 6UxbPFjOUf69yqsKYE/7DJaMKbnDvKRc/TbLVV+O+lo+cH0pUVhxXu9hEXzHxdsyBCIp /eFo2+wwBpBKsCzPsWhz/2IyUgWOvlqnIZlWfWdPXptEx8c8JVqFN+RzgWijuB2N4Z0F /xLQ== X-Gm-Message-State: AOJu0YyXCjGC5LVrDFNhg6zweWuNqahdZ//GPqDu9lJ85KrlWpFxya/R WJKEX3dZnz3xNC78Cy5m29kL5bKMK19Ncw== X-Google-Smtp-Source: AGHT+IF9+5z8gW/L2WmhxsI+81BMma/N4jRZCRB7iE4meseUn0CUi23FnZlRHWkkTJI6XVkfvLHlSg== X-Received: by 2002:a5e:8913:0:b0:783:47cd:27b5 with SMTP id k19-20020a5e8913000000b0078347cd27b5mr18383468ioj.3.1694026952009; Wed, 06 Sep 2023 12:02:32 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id w11-20020a5d844b000000b0076ffebfc9fasm5152306ior.47.2023.09.06.12.02.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 12:02:31 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: [PATCH v3 2/5] drm/kmb: add trailing newlines to drm_dbg msgs Date: Wed, 6 Sep 2023 13:02:20 -0600 Message-ID: <20230906190224.583577-3-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230906190224.583577-1-jim.cromie@gmail.com> References: <20230906190224.583577-1-jim.cromie@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jani.nikula@intel.com, daniel.vetter@ffwll.ch, Edmund Dea , seanpaul@chromium.org, Anitha Chrisanthus Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks. No functional changes. Signed-off-by: Jim Cromie Acked-by: Anitha Chrisanthus --- drivers/gpu/drm/kmb/kmb_crtc.c | 10 +++++----- drivers/gpu/drm/kmb/kmb_plane.c | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/kmb/kmb_crtc.c b/drivers/gpu/drm/kmb/kmb_crtc.c index 647872f65bff..a58baf25322d 100644 --- a/drivers/gpu/drm/kmb/kmb_crtc.c +++ b/drivers/gpu/drm/kmb/kmb_crtc.c @@ -94,7 +94,7 @@ static void kmb_crtc_set_mode(struct drm_crtc *crtc, vm.hback_porch = 0; vm.hsync_len = 28; - drm_dbg(dev, "%s : %dactive height= %d vbp=%d vfp=%d vsync-w=%d h-active=%d h-bp=%d h-fp=%d hsync-l=%d", + drm_dbg(dev, "%s : %dactive height= %d vbp=%d vfp=%d vsync-w=%d h-active=%d h-bp=%d h-fp=%d hsync-l=%d\n", __func__, __LINE__, m->crtc_vdisplay, vm.vback_porch, vm.vfront_porch, vm.vsync_len, m->crtc_hdisplay, vm.hback_porch, @@ -194,24 +194,24 @@ static enum drm_mode_status int vfp = mode->vsync_start - mode->vdisplay; if (mode->vdisplay < KMB_CRTC_MAX_HEIGHT) { - drm_dbg(dev, "height = %d less than %d", + drm_dbg(dev, "height = %d less than %d\n", mode->vdisplay, KMB_CRTC_MAX_HEIGHT); return MODE_BAD_VVALUE; } if (mode->hdisplay < KMB_CRTC_MAX_WIDTH) { - drm_dbg(dev, "width = %d less than %d", + drm_dbg(dev, "width = %d less than %d\n", mode->hdisplay, KMB_CRTC_MAX_WIDTH); return MODE_BAD_HVALUE; } refresh = drm_mode_vrefresh(mode); if (refresh < KMB_MIN_VREFRESH || refresh > KMB_MAX_VREFRESH) { - drm_dbg(dev, "refresh = %d less than %d or greater than %d", + drm_dbg(dev, "refresh = %d less than %d or greater than %d\n", refresh, KMB_MIN_VREFRESH, KMB_MAX_VREFRESH); return MODE_BAD; } if (vfp < KMB_CRTC_MIN_VFP) { - drm_dbg(dev, "vfp = %d less than %d", vfp, KMB_CRTC_MIN_VFP); + drm_dbg(dev, "vfp = %d less than %d\n", vfp, KMB_CRTC_MIN_VFP); return MODE_BAD; } diff --git a/drivers/gpu/drm/kmb/kmb_plane.c b/drivers/gpu/drm/kmb/kmb_plane.c index 9e0562aa2bcb..308bd1cb50c8 100644 --- a/drivers/gpu/drm/kmb/kmb_plane.c +++ b/drivers/gpu/drm/kmb/kmb_plane.c @@ -78,7 +78,7 @@ static unsigned int check_pixel_format(struct drm_plane *plane, u32 format) * plane configuration is not supported. */ if (init_disp_cfg.format && init_disp_cfg.format != format) { - drm_dbg(&kmb->drm, "Cannot change format after initial plane configuration"); + drm_dbg(&kmb->drm, "Cannot change format after initial plane configuration\n"); return -EINVAL; } for (i = 0; i < plane->format_count; i++) { @@ -124,7 +124,7 @@ static int kmb_plane_atomic_check(struct drm_plane *plane, if ((init_disp_cfg.width && init_disp_cfg.height) && (init_disp_cfg.width != fb->width || init_disp_cfg.height != fb->height)) { - drm_dbg(&kmb->drm, "Cannot change plane height or width after initial configuration"); + drm_dbg(&kmb->drm, "Cannot change plane height or width after initial configuration\n"); return -EINVAL; } can_position = (plane->type == DRM_PLANE_TYPE_OVERLAY); @@ -375,7 +375,7 @@ static void kmb_plane_atomic_update(struct drm_plane *plane, spin_lock_irq(&kmb->irq_lock); if (kmb->kmb_under_flow || kmb->kmb_flush_done) { spin_unlock_irq(&kmb->irq_lock); - drm_dbg(&kmb->drm, "plane_update:underflow!!!! returning"); + drm_dbg(&kmb->drm, "plane_update:underflow!!!! returning\n"); return; } spin_unlock_irq(&kmb->irq_lock); From patchwork Wed Sep 6 19:02:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 13375904 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3785EE14D0 for ; Wed, 6 Sep 2023 19:02:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4D92010E715; Wed, 6 Sep 2023 19:02:38 +0000 (UTC) Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1891610E706; Wed, 6 Sep 2023 19:02:34 +0000 (UTC) Received: by mail-io1-xd29.google.com with SMTP id ca18e2360f4ac-79536bc6697so4638039f.1; Wed, 06 Sep 2023 12:02:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694026953; x=1694631753; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Shuu74iNOrUzggTrIzmIdLUSQe5OqUirbEavz/33+0U=; b=EZ5rL+Vy7fZNCPDyFWaHJA72AYBctyaxYn8neQ0YHBNe1EQmdLfknVcTrvsMG6m6rT qe/zJvwwY/XqjU2MXxlnl9gxfKHVttaESfADVdntc3Znmvz2UZBIA8uLRFUmRqUTWslO 5sRjCzeZGsuhJX27bfbdt2M3T5ZtJ6DZEKqHoYGroC0uwtcRVBZAGml4l5VhR5OsjU1F BAn5SItD8ryndij55O+tZAH6UhvFyy2xZ17L70d16cUeGWt3eBdZQXlow5XYy9fYeu/q 1BacKv6JoMK/tBHIlnJJxNH9f0ertXf7dH7z1zHP7NW/O65ssKdVguhtw4GQzBmR65/y cUfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694026953; x=1694631753; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Shuu74iNOrUzggTrIzmIdLUSQe5OqUirbEavz/33+0U=; b=eVQdKOPKtYvi+MuxoeWx0WewST6r3L5nswwfGyGmXEKv4JIJ7hMqqFfMI/IOS9iK+2 qIxqX4jLqhYlCvnp9HME8qFC25QfXo5Sx+y69DrwbJiSAXmnBS8RhEHp9LrOmmRX+Mhp YZVcSMu32ZtPEaMZRjEw8n5V1MzwtP+uLiSWokI5PoCH2l0Hv1CGJ9XJb9JN9UE1fNRU b4X617dgi5Xf5zLmCpA4MI0eiUMksR23sbZZuu15nkahtHn89b1/WMTgLKhcPfmiLLyB Wann3OE3KXpn12HFeKGcK9uJIuvsZQh5nxpjHsT9pa4jOr+BeXtPZP4XuqO7jkgMrm1n iVGg== X-Gm-Message-State: AOJu0YyRfu1biFpt82S0TPTLsT6yU+Lg9wCVIDr4b3TO9LhpwZT1Ichc 1Hwf1CahRZY9RGqAn8WXQDw= X-Google-Smtp-Source: AGHT+IG8dUwsOLP2n+Ukg0ohoD1JineJZS15vcrecPVQqbrwV1b9zykvv4DUg7GBrgG/kgmfyMJyGQ== X-Received: by 2002:a6b:dc17:0:b0:792:8d16:91ef with SMTP id s23-20020a6bdc17000000b007928d1691efmr16839930ioc.18.1694026953259; Wed, 06 Sep 2023 12:02:33 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id w11-20020a5d844b000000b0076ffebfc9fasm5152306ior.47.2023.09.06.12.02.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 12:02:32 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: [PATCH v3 3/5] drm/msm: add trailing newlines to drm_dbg msgs Date: Wed, 6 Sep 2023 13:02:21 -0600 Message-ID: <20230906190224.583577-4-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230906190224.583577-1-jim.cromie@gmail.com> References: <20230906190224.583577-1-jim.cromie@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, jani.nikula@intel.com, daniel.vetter@ffwll.ch, Abhinav Kumar , seanpaul@chromium.org, linux-arm-msm@vger.kernel.org, Dmitry Baryshkov , Marijn Suijten , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks. No functional changes. Signed-off-by: Jim Cromie Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/msm_fb.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_fb.c b/drivers/gpu/drm/msm/msm_fb.c index e3f61c39df69..88bb5fa23bb1 100644 --- a/drivers/gpu/drm/msm/msm_fb.c +++ b/drivers/gpu/drm/msm/msm_fb.c @@ -89,7 +89,7 @@ int msm_framebuffer_prepare(struct drm_framebuffer *fb, for (i = 0; i < n; i++) { ret = msm_gem_get_and_pin_iova(fb->obj[i], aspace, &msm_fb->iova[i]); - drm_dbg_state(fb->dev, "FB[%u]: iova[%d]: %08llx (%d)", + drm_dbg_state(fb->dev, "FB[%u]: iova[%d]: %08llx (%d)\n", fb->base.id, i, msm_fb->iova[i], ret); if (ret) return ret; @@ -176,9 +176,9 @@ static struct drm_framebuffer *msm_framebuffer_init(struct drm_device *dev, const struct msm_format *format; int ret, i, n; - drm_dbg_state(dev, "create framebuffer: mode_cmd=%p (%dx%d@%4.4s)", - mode_cmd, mode_cmd->width, mode_cmd->height, - (char *)&mode_cmd->pixel_format); + drm_dbg_state(dev, "create framebuffer: mode_cmd=%p (%dx%d@%4.4s)\n", + mode_cmd, mode_cmd->width, mode_cmd->height, + (char *)&mode_cmd->pixel_format); n = info->num_planes; format = kms->funcs->get_format(kms, mode_cmd->pixel_format, @@ -232,7 +232,7 @@ static struct drm_framebuffer *msm_framebuffer_init(struct drm_device *dev, refcount_set(&msm_fb->dirtyfb, 1); - drm_dbg_state(dev, "create: FB ID: %d (%p)", fb->base.id, fb); + drm_dbg_state(dev, "create: FB ID: %d (%p)\n", fb->base.id, fb); return fb; From patchwork Wed Sep 6 19:02:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 13375905 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B09FEE14D9 for ; Wed, 6 Sep 2023 19:02:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9F53810E718; Wed, 6 Sep 2023 19:02:39 +0000 (UTC) Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 19B2B10E70B; Wed, 6 Sep 2023 19:02:35 +0000 (UTC) Received: by mail-io1-xd33.google.com with SMTP id ca18e2360f4ac-7926b7f8636so2792939f.1; Wed, 06 Sep 2023 12:02:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694026954; x=1694631754; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A7euIhAUxsBgqAycWxnasjxETI8zYNC1RLZ3qD73WsM=; b=ctHx0Vur9+BAW8YMU62p6Y+6YLm7h0Y1i+eDqN0a2/qOcK/Nfo0jYBFc03Zt+TzAbs +XPq3MZaLq6rJznjmmDCseE4gnh8o6UmT+ik3W4MzwKeQQDRovje3qit1MJEhV6uWAl4 A7HASvBcPn91ddy34xlDcdiwH6PewY9g1ULletE3BvrNfzWS7eltsFaiNHTpY8maMHwC o3FSh6mLENQN7FNHgpxdf9y4XEMdDYeL64GN+3W84PRZHAZDn2mdwfkNOmFJrCjnWbTY 8MoL8Dz0u/KS0KHwjQsMMQHuGmKYoXFe377KVQiViluDaSfvDB1swb33uiUCshgbfLhQ GmdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694026954; x=1694631754; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A7euIhAUxsBgqAycWxnasjxETI8zYNC1RLZ3qD73WsM=; b=CvQGsGzQ6bJHkka4DQ/MIXLnGPbxtUjEk1AGDihJgFSuLJpB8uDlnaFmBpMU3k7dGQ 3XmCoR6MuxTUlS7lfuHRoArpWIa45jDZAbFEjHWi7dcyQPF6f0nV5+zt69zaaSztcWaQ x1eyatKzFA98fsu9I2s9nu8qilYReii3E++SlCIO/y45Us5/tf47+/AvGaf9YLb5Ef/B aYtyuLDX1sjMicKZ2M20ZKby6yuMyKDzyPjBGQgDOOAF0RCPZr8+1dOXCDrQ9J10V9p2 bTIRhKWdPo9Bn7b3hIs/s+5phA/DKoh2OPR0tW43M8yTU/aVxA1JiLQ7Y0wV+KVFiCsS DdMg== X-Gm-Message-State: AOJu0Yzzcb1kyFn2gk1Wtu7Ubt3dvj1q+wUxL63fhzGeBXUEXE7xIBZ7 9BGPEn1x49VyUj5IPcA8SlU= X-Google-Smtp-Source: AGHT+IEerlB6JrUC+Z/0QRgCoRQoVs5aiPA8URhXDpxxGTJSTcPFuBIaCE9H+Uno/nfLK9zvHQVWkg== X-Received: by 2002:a5e:a718:0:b0:794:c9a8:27eb with SMTP id b24-20020a5ea718000000b00794c9a827ebmr544496iod.5.1694026954382; Wed, 06 Sep 2023 12:02:34 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id w11-20020a5d844b000000b0076ffebfc9fasm5152306ior.47.2023.09.06.12.02.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 12:02:34 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: [PATCH v3 4/5] drm/vc4: add trailing newlines to drm_dbg msgs Date: Wed, 6 Sep 2023 13:02:22 -0600 Message-ID: <20230906190224.583577-5-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230906190224.583577-1-jim.cromie@gmail.com> References: <20230906190224.583577-1-jim.cromie@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emma Anholt , jani.nikula@intel.com, daniel.vetter@ffwll.ch, Maxime Ripard , seanpaul@chromium.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" By at least strong convention, a print-buffer's trailing newline says "message complete, send it". The exception (no TNL, followed by a call to pr_cont) proves the general rule. Most DRM.debug calls already comport with this: 207 DRM_DEV_DEBUG, 1288 drm_dbg. Clean up the remainders, in maintainer sized chunks. No functional changes. Signed-off-by: Jim Cromie Acked-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index bef9d45ef1df..959123759711 100644 --- a/drivers/gpu/drm/vc4/vc4_crtc.c +++ b/drivers/gpu/drm/vc4/vc4_crtc.c @@ -592,7 +592,7 @@ static void vc4_crtc_atomic_disable(struct drm_crtc *crtc, struct drm_encoder *encoder = vc4_get_crtc_encoder(crtc, old_state); struct drm_device *dev = crtc->dev; - drm_dbg(dev, "Disabling CRTC %s (%u) connected to Encoder %s (%u)", + drm_dbg(dev, "Disabling CRTC %s (%u) connected to Encoder %s (%u)\n", crtc->name, crtc->base.id, encoder->name, encoder->base.id); require_hvs_enabled(dev); @@ -620,7 +620,7 @@ static void vc4_crtc_atomic_enable(struct drm_crtc *crtc, struct vc4_encoder *vc4_encoder = to_vc4_encoder(encoder); int idx; - drm_dbg(dev, "Enabling CRTC %s (%u) connected to Encoder %s (%u)", + drm_dbg(dev, "Enabling CRTC %s (%u) connected to Encoder %s (%u)\n", crtc->name, crtc->base.id, encoder->name, encoder->base.id); if (!drm_dev_enter(dev, &idx)) From patchwork Wed Sep 6 19:02:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Cromie X-Patchwork-Id: 13375906 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1ACEBEE14D7 for ; Wed, 6 Sep 2023 19:03:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2109C10E71A; Wed, 6 Sep 2023 19:02:40 +0000 (UTC) Received: from mail-io1-xd2f.google.com (mail-io1-xd2f.google.com [IPv6:2607:f8b0:4864:20::d2f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 67E1310E70E; Wed, 6 Sep 2023 19:02:36 +0000 (UTC) Received: by mail-io1-xd2f.google.com with SMTP id ca18e2360f4ac-794cd987ea6so4443539f.2; Wed, 06 Sep 2023 12:02:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694026955; x=1694631755; darn=lists.freedesktop.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=usLeqXzE5U9X3mWlGIhl2wkCPYgPL1jt55C0ImyryHk=; b=npZ3pZivWvRqUaXwwfgbiguPH8fIFg/ymvUutQrUntSfmh/E29WtFKknD9snKamVwN Okc/tkNL3PRzrkzp746RGHAcMyHeJ+8Y4F3u/t9moLokgDmVrT4ydrNxu0DmbIUFMnw5 j5ceMAYRhfBZxpniBBxheQaXfDXOAM5FS7matSrvmj1y6sRL6nj69oRHm7FDq4VHFpyk wVPiBDa8LuUDgxWJLmYouZ+ut7fTZOoc5SjVJnghuDf+FH1R9RhnyWDiFwsrHKcrq7AF fvoLus6My1popPUKgRoZ26Pvi6xILs99qtTOic3DTCMMO4NzUVhpNRKqU4QnUYBJ2c8a KzKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694026955; x=1694631755; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=usLeqXzE5U9X3mWlGIhl2wkCPYgPL1jt55C0ImyryHk=; b=Sk97UZyd8Y1bFPBuoqqv1xCI2maLXSph0qsR7eeoXcJqdtWX4k5IrqjJpWfdlV/q8n xlCmDqs5HSK1JFroGsTkYGes2hqdlelZNQLohI/V60h7f8TudSlrt145gcBCEUWxV/Qg yKxnZgwZ73pcI57Nzs1ZYrp3nNf+vABdNcr9kHW8+7HZU9vYCKuIR91PGjsEfyom+ETL cAWxSJKpn6nQh0enHARycqduTXucxVSz6oowS3eqmgFQPf0K4D+shGadSE1m3KF3mP/b hHI8rXWHdSwej2/Th0c+OhlBRKq+I8Y2YCpb3hFe9PJ+vqlS+17OFVEgDuVjDU4PsLXL N+1w== X-Gm-Message-State: AOJu0YwTHTGkBWgWgMTYPnSt7o3G3jIjhfCcUFCppQspKqNfc7zDqRmX j3xwYprtviRkpMDGMhsnUPY= X-Google-Smtp-Source: AGHT+IFTPVrAnUWjjhREw0Hvr2AR0rY8UkvdcnI2CamAN17ipmhg22bz+NrpSLLjzXAWDFV8FZHQ6Q== X-Received: by 2002:a6b:dd0b:0:b0:791:16ba:d764 with SMTP id f11-20020a6bdd0b000000b0079116bad764mr18373492ioc.16.1694026955566; Wed, 06 Sep 2023 12:02:35 -0700 (PDT) Received: from frodo.. (c-73-78-62-130.hsd1.co.comcast.net. [73.78.62.130]) by smtp.googlemail.com with ESMTPSA id w11-20020a5d844b000000b0076ffebfc9fasm5152306ior.47.2023.09.06.12.02.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Sep 2023 12:02:35 -0700 (PDT) From: Jim Cromie To: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Subject: [PATCH v3 5/5] drm/Makefile: use correct ccflags-y syntax Date: Wed, 6 Sep 2023 13:02:23 -0600 Message-ID: <20230906190224.583577-6-jim.cromie@gmail.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230906190224.583577-1-jim.cromie@gmail.com> References: <20230906190224.583577-1-jim.cromie@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Zimmermann , jani.nikula@intel.com, daniel.vetter@ffwll.ch, Maxime Ripard , seanpaul@chromium.org, Greg Kroah-Hartman Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Incorrect CFLAGS- usage failed to add -DDYNAMIC_DEBUG_MODULE when needed, which broke builds with: CONFIG_DRM_USE_DYNAMIC_DEBUG=Y CONFIG_DYNAMIC_DEBUG_CORE=Y CONFIG_DYNAMIC_DEBUG=N Also add subdir-ccflags so that all drivers pick up the addition. Fixes: 84ec67288c10 ("drm_print: wrap drm_*_dbg in dyndbg descriptor factory macro") Signed-off-by: Jim Cromie --- drivers/gpu/drm/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile index 7a09a89b493b..013cde886326 100644 --- a/drivers/gpu/drm/Makefile +++ b/drivers/gpu/drm/Makefile @@ -3,7 +3,8 @@ # Makefile for the drm device driver. This driver provides support for the # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. -CFLAGS-$(CONFIG_DRM_USE_DYNAMIC_DEBUG) += -DDYNAMIC_DEBUG_MODULE +ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG) += -DDYNAMIC_DEBUG_MODULE +subdir-ccflags-$(CONFIG_DRM_USE_DYNAMIC_DEBUG) += -DDYNAMIC_DEBUG_MODULE drm-y := \ drm_aperture.o \