From patchwork Thu Sep 7 02:29:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13376096 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26623EE14D7 for ; Thu, 7 Sep 2023 02:29:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71A1E280028; Wed, 6 Sep 2023 22:29:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F17E280027; Wed, 6 Sep 2023 22:29:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 56988280028; Wed, 6 Sep 2023 22:29:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3DBF3280022 for ; Wed, 6 Sep 2023 22:29:43 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 09CEC120F8A for ; Thu, 7 Sep 2023 02:29:43 +0000 (UTC) X-FDA: 81208220646.27.904255E Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf20.hostedemail.com (Postfix) with ESMTP id 539201C000E for ; Thu, 7 Sep 2023 02:29:41 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AsOlxP5a; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694053781; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9ichdburCZJiJv2UkNCIr2BwS+E/lTRotObA8fmDBD8=; b=6nw28sghDsHm+vXtS3CC3v33fVIBpuJvUVoP0kt02NGD9j7cqcAe1N6Is/ZYJuTL7izfDK j2+cgNKMehj5iPKjsidnFAtEGHqTlO5faVvXNT28J7Tyxlggf2UM0huGK1aUwwWKX7S5xd v7SGxCtDwFuW9oHkfp+r239hxzb5nL0= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=AsOlxP5a; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf20.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694053781; a=rsa-sha256; cv=none; b=HSJgaDVJFmVbLrX7nin4g6YmooDb/iA7rUSrXDLvpZmT6gEAygiZQV/dXNtv6CyF1Bvpu0 5UHJfPch5n75sNl5ihUvyvp/53TvEvn1D8CFJqeWdU3vENXNiXHGMKnXPhr2e/3Tl9Qa7a o3+0vMTpM13XtP9jv+f4tfu9Wr7pQ3g= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 74F3FB81B5B; Thu, 7 Sep 2023 02:29:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B71ABC433C9; Thu, 7 Sep 2023 02:29:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694053778; bh=+IqrUHwg2Fad6cIIwKzoX0FcbTzdrwz+hio0MOPrv5I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AsOlxP5a2voHFqvcPXAprrlsyv3GaIQgNIogoaQ4+Hmsfl/P8G7laywwqsD3jEOt2 gdwGsJwzcfQbKU+LiCOw4he3yX1Uwy/hSjOMt4r6BkQqwZpdjo74Mfk3njTwNdGPgY hrLRQBbiAo9XZvp6VU1rvKAp5+hTF2Vk+PWz9zhnJFgON14NW2o0aG/Hnz38HRXEks 9FEyjNy+rO8BUMugU0TM93xwBKB2MmRBlMgYlgJ+q7Rp43OOVwTP/Az2crLmw0Sb/m SZ3oLq0US685pFT1kaBvWoLHhVrRtzbyuyhjMHplJLIUS4c5sWdpbN3WaYeNCMJd3y ydV0f5sQAeJsA== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Jonathan Corbet , damon@lists.linux.dev, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/11] Docs/admin-guide/mm/damon/usage: fixup missed :ref: keyword Date: Thu, 7 Sep 2023 02:29:19 +0000 Message-Id: <20230907022929.91361-2-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230907022929.91361-1-sj@kernel.org> References: <20230907022929.91361-1-sj@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Stat-Signature: nejqumog1oad8wt55fh57sn7bsftyuet X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 539201C000E X-HE-Tag: 1694053781-296919 X-HE-Meta: U2FsdGVkX188BNU5FeIALaOgbE5YifDykE1DEED/1W7pX9fy9GHJPrRbXL3fARtmUf5+2DujV19aGUwUbkiaNuoehd42tDJr0lUx1le8yX3RE5kMGog/jfV1IuI1sGBGMhq+DbYWkd9JD20PDvTuPD+ZCLvnqPQgd4DlbamHQ2ApSQEhmhk4BAHKZS22ERNzBvly3lX8/c+dQKdl2H7/ClHvdOGPhGpVrU6AWUGO/8SIcPlzxYT7hYkGeZenPf3P7w3v0yUecmIFGeOcb3Q82K7wjJONw1vGo/4+ZWycGWPYEfMH1YFQEAqDVbo1GruxV4WyAu8KYguI2JJiR4e+G/cRoBXzbjbXX4HzUSBdX/Boy0+PcgUjVqAFaHe6xiIDM4qCGdbjWHv3RwoQr9HOqc8q2+Mc/ksi9ABluGyYHntYpqEWuX1rCMAsdm7xt57lheQU15MLTk3v0w7bfi+MyJo6C7+R1XfFbshimiT+CKGrg41pd3UL1kxncwp7dNCHB99T+p5c/x08UU5VVQXKWu7iRzwoVI3KNvV51x3ciYSBl5EOHjbxHo9w3SLl3uPLhyOe3UFJem5YJiOaGTch84DZoRnBrAL9MpyjcWAvudzho8Uo2lqnfKmEssvOaupLyPzCbBSNSmn4uB4aHFo8M88gb0wccVZ5l6tQ7lr/LYF6TrXMXKMR6jmYwgEI3Rv3et9w8lEkL8xWoGe3Ry6DJ2JUekk69RJ3DknxhVVm0ePLt17/h+iNvEs6qhC3KxSOo5PmEKnJAt6/9JCXK4HIZQ0L7AQpY+WTkiZymfmc/Gut8RdN6dSkC0DKglA2nVLrm6uMuZzmFDxhN206qw7ljO560qBwAMzJQn2AaSYs+KwsAvViC+6l+QeBgUeq6d/Ivesegjh9fVskOH+3gOsasRO3mrWTA8tTLYrYjX8ceocfDJYT6qvR7gZHcWkOidUimdFmBNqQ3riasr+rOR1 X66DsIjl 1Xs7YX6ggUVAkd1cNwYPYSzaGQSh09beABgiTVToiNYtmx4h+I57JBbJVMNQooYC0zUq1SLdOc3zWFxepXqt78+Py8b94x+96WCysJRs0CQnV6qsq7hEPB+aWpPaUYPsuDT+WHTtWqJJG4JTaY3Qj+bngwRMb83MCcAiWBky/3DFzMBWbCI2xYgpeHotV5HP73nbMCgLzA9aEzdbQuuFxhomIQgoiHkkGMRrGV/4t1OEUe9P5g2EmdDihUDOfRnXUsYSnGAIzBy2wwF1XhtkTpVp1h/JF0RUBpnCopdJTEEtthU3vNcOyBBxX09YdPT4qJM34zjU9XrZ+K9Wu1XZliOHF7g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: A cross-link reference in DAMON usage document is missing ':ref:' Sphynx keyword. Fix it. Signed-off-by: SeongJae Park --- Documentation/admin-guide/mm/damon/usage.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/admin-guide/mm/damon/usage.rst b/Documentation/admin-guide/mm/damon/usage.rst index 8da1b7281827..834eefe39650 100644 --- a/Documentation/admin-guide/mm/damon/usage.rst +++ b/Documentation/admin-guide/mm/damon/usage.rst @@ -392,7 +392,7 @@ pages of all memory cgroups except ``/having_care_already``.:: echo N > 1/matching Note that ``anon`` and ``memcg`` filters are currently supported only when -``paddr`` `implementation ` is being used. +``paddr`` :ref:`implementation ` is being used. Also, memory regions that are filtered out by ``addr`` or ``target`` filters are not counted as the scheme has tried to those, while regions that filtered From patchwork Thu Sep 7 02:29:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13376104 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F127EEE14C3 for ; Thu, 7 Sep 2023 02:30:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5DAFB280029; Wed, 6 Sep 2023 22:29:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E570280030; Wed, 6 Sep 2023 22:29:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21015280029; Wed, 6 Sep 2023 22:29:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0009828002E for ; Wed, 6 Sep 2023 22:29:46 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CA28FB42B6 for ; Thu, 7 Sep 2023 02:29:46 +0000 (UTC) X-FDA: 81208220772.06.53C7A68 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf21.hostedemail.com (Postfix) with ESMTP id 9C77A1C0004 for ; Thu, 7 Sep 2023 02:29:44 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=P13xdxS4; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694053785; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8qVOlJbQg5WpMY88dRdLG9yIZfdeC+Hc8xuFzhLuiEk=; b=vTxCyRbJrtDpnonBSdAJ0DKY4/NTYU5sea2fTNNQmnH+4VzBElckBMRNudKfjEFgZMS0sR +JyXuTweflZ4bM45Kx7JmPVOhRQgJ8YckYVct80QQnC8AD1OCE94BGKByWXl5WyWsMcFwR hdZgM6WaP9DMqERXRRBzYfP+5K41Rqw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694053785; a=rsa-sha256; cv=none; b=IRrg+1vJDszDHuyap2CfzIr15RNIpYfRstGwRR+WiGkjKIphkNpBr/CcLK0SAkU/Xjd8sm EB3L5k1ofhVuc52E/YfEf4g8uCpyij2okoVjMPwNw2wwKJdtWfvb5DP69IAaL9cD/lXjh3 Q/PCZd1vQCDIna2pQl+mPVg2hApyomI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=P13xdxS4; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 56841CE1843; Thu, 7 Sep 2023 02:29:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 756FAC433CA; Thu, 7 Sep 2023 02:29:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694053779; bh=ddAwo+PJ4HbDbLRCVex0LmwHXE3nv9K1631hg64QSQQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=P13xdxS4wlGAVIBUe5kpWPR/UNmFyYTU4FLLLMcCHrKh3uUJ1xUCoyNRngufVl8B/ VvJ+If3uwJfzB71IHKAUD238aAFRPRvh8Uc+23igy+x6rguGNyGfpt4cIiqz/Rwyvo cdqrwQY0g6DFBeJuVmSoMlAdEBwMPPBXGOpAGZSZW9CAoGUbfGNuZuucH6JmAOaim5 xFvqb7c55zEtR86oxNiJVzFYZMGAV/FfX8LJYvMggb+uNfja4GUtBfiHvpAUH9XBdL 2bsLXJNCa0vHIZ7Ef6iRQ0I/ijEwT0vn62cEXBrYQpc4PQITTO9myhuqgpaT2/1QB8 suwu4x18IKU/A== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Jonathan Corbet , damon@lists.linux.dev, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 02/11] Docs/admin-guide/mm/damon/usage: place debugfs usage at the bottom Date: Thu, 7 Sep 2023 02:29:20 +0000 Message-Id: <20230907022929.91361-3-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230907022929.91361-1-sj@kernel.org> References: <20230907022929.91361-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: 9C77A1C0004 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ihce3brrdr633qbcdhou3fer7y9c881o X-HE-Tag: 1694053784-104125 X-HE-Meta: U2FsdGVkX1/3K1Rq2GwAj5huyoR1W9igWObUhb6/Z/sn05PmSBU+Dfr8xVpPofPvbul/YaiG57NrI8n7u68DpsrruDzyAEtPPsxHKg0wOamb1xEcOGy47mTUFpc064Be54hpSpOOlFNr1OgkWQ9sIQ64Ertv2qIJJWr/gs9+w9HDHcqd9lcg/28/dhz61EUVxVqY6yFeBCibsCw97V9EQcyhyHpSCeJ1y6BA+MakRYI7nMqNy80Xi0xhmYLIpNVfoTwaX0ulr5KRlJwJuRksBFpsSDC6uq0eLbFvLCxzlV9+SAQD1XudzHejB7uNuybVE0ef1Ot4x9Kwx8shlUL28a/wRnJdsnzO92WIsvg+b8Zu/VwdYu9qt7j5lhPX68D+HXSdATlA5wfnKGq++erJBhXobAG/+g0O28K/Ih28D5ZQYeSRitDfhSMAA3DPP+fgPU0B+nWAxI9kbQWXXSsLZvY7v1DO7a/uAADpPmc+qIwZI+fW/dc6UUVMQTuAJDxcUYlzvEm19SNF2HymMbEjyEnuS91x7eMjyX18W3xsAuTc6LiXp7V4Th317QJqb1wIjPMIfEuNSqtCpzb7I+ZBPdYpYuhMBCkm0qUm+kdGVzFv7cuo+HcV95KT4PTdgMg/9s346hjlCH6stFIf0DOiYfeXki2DUHRjMCAhaSIfajrKNPHWTu0rNYwkLX81LgvbC//gwjpgd9pVR6wPq1x9NyfnJwMBqHyTTIIjggZSfwbi55gE0AyGNExr1e65qqDVXah47frVhcPa34Z5aURQ8/GPJTKso3p10+eflHRgVOR1MPXrdUtKPOryk0Qi0NyfPaDzU9uTBCzEfJ4/HsPAXvm3mcS4+t2NdrxF/65Zie3EwOc39XoArvH4RLE+SCTBetCEqJ+7mBxo6re7IAJ6jDD+cC9pJ4h5b+qzHuSKs0wBcgBGX4Op4sC5lKvsXDinMH1GKX/8jyxa0eeEhEa W8lk+GIy MuyMu8lLHsBKUKShQb4UAYNdoRRXBOig3A8F+JXdGXS8Q6ucsNngb/iVaVIid5c02sH7sCb6Ga8pH5kF93q4p/wjiHg4mV1ifCM5z2lH7RN6tdyQ2lcVKwXXaGNGxLJZzixYxSeochQlPa7Ye9Xu88+0LYNCnIZZB4rPTgg0FQAkjn6WXd0Rsk2blWivEefnSZMVycHAGd5x14rZwnEoSagtw+d8I1dJGNuMh7f9DwW3QuKUmA5/A4XP6Ry2TFZH8C42KgonxylK3hss0DWUuC1Mvn1iNGc5OloK1B+C26TzPXy/Ra1gn6sRnrmMyaJmpg2NEUrjJOiOBBu4EkO+tdZkjGma5fnelMQE2MpS9IMsXSsU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: debugfs interface is deprecated. Put it at the bottom of the document so that readers have less chances to read it. Signed-off-by: SeongJae Park --- Documentation/admin-guide/mm/damon/usage.rst | 39 ++++++++++---------- 1 file changed, 19 insertions(+), 20 deletions(-) diff --git a/Documentation/admin-guide/mm/damon/usage.rst b/Documentation/admin-guide/mm/damon/usage.rst index 834eefe39650..bffe9dd9b0d6 100644 --- a/Documentation/admin-guide/mm/damon/usage.rst +++ b/Documentation/admin-guide/mm/damon/usage.rst @@ -495,6 +495,25 @@ Please note that it's highly recommended to use user space tools like `damo `_ rather than manually reading and writing the files as above. Above is only for an example. +.. _tracepoint: + +Tracepoint for Monitoring Results +================================= + +Users can get the monitoring results via the :ref:`tried_regions +` or a tracepoint, ``damon:damon_aggregated``. +While the tried regions directory is useful for getting a snapshot, the +tracepoint is useful for getting a full record of the results. While the +monitoring is turned on, you could record the tracepoint events and show +results using tracepoint supporting tools like ``perf``. For example:: + + # echo on > monitor_on + # perf record -e damon:damon_aggregated & + # sleep 5 + # kill 9 $(pidof perf) + # echo off > monitor_on + # perf script + .. _debugfs_interface: debugfs Interface (DEPRECATED!) @@ -790,23 +809,3 @@ directory by putting the name of the context to the ``rm_contexts`` file. :: Note that ``mk_contexts``, ``rm_contexts``, and ``monitor_on`` files are in the root directory only. - - -.. _tracepoint: - -Tracepoint for Monitoring Results -================================= - -Users can get the monitoring results via the :ref:`tried_regions -` or a tracepoint, ``damon:damon_aggregated``. -While the tried regions directory is useful for getting a snapshot, the -tracepoint is useful for getting a full record of the results. While the -monitoring is turned on, you could record the tracepoint events and show -results using tracepoint supporting tools like ``perf``. For example:: - - # echo on > monitor_on - # perf record -e damon:damon_aggregated & - # sleep 5 - # kill 9 $(pidof perf) - # echo off > monitor_on - # perf script From patchwork Thu Sep 7 02:29:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13376099 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BBE7EE14D4 for ; Thu, 7 Sep 2023 02:29:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 803B0280027; Wed, 6 Sep 2023 22:29:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 76F0D28002B; Wed, 6 Sep 2023 22:29:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 458EE280027; Wed, 6 Sep 2023 22:29:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 24AD3280029 for ; Wed, 6 Sep 2023 22:29:44 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 01FBD120B14 for ; Thu, 7 Sep 2023 02:29:43 +0000 (UTC) X-FDA: 81208220688.24.A074323 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf27.hostedemail.com (Postfix) with ESMTP id 48A3F40003 for ; Thu, 7 Sep 2023 02:29:42 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VfeGOqRl; spf=pass (imf27.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694053782; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uvHisJ3wMf7FZhz1RjxYMdXBF9iWlOlTysfYQoTsdZ8=; b=YC7my0QRcAmI5vOOQrb7R06JroBSFOZZugit/gEO3tloJjNg+ILCxIgpDtHDPzMOgO5nZs 1KKQw+ezkB63+9eP7Kdz+zzwTr0wmK6pTQAxb3Fk2+rVuk3vAbwd+Q/HaVuWYXwqBVjxwS LKGG0mRBF6Z4Vu5/jfn+C/CSNt/Ez1Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694053782; a=rsa-sha256; cv=none; b=LReeQsEXjoxm7MLFeXP2+OrvjFf5teAnPpPHGPCjCjpX/pYYgn9JccY++bveFT5S7mGYKx Ubb5NUq2PkYC4ra/+ZHRoaFUkdyCV9nts2bSsy/5cn3ATauzwBcbj7ex2B4KwhdQjzd/pI 7Wq8DJi+Ug9kxKCIljcEKjGpNn400t4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=VfeGOqRl; spf=pass (imf27.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 043CEB80920; Thu, 7 Sep 2023 02:29:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4271BC43391; Thu, 7 Sep 2023 02:29:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694053779; bh=DPwXZPd8fZ7k76FJchCmgeNiFjKUbh+BZTC85e+typU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VfeGOqRlnm1Nvu7Y2kpqlsGEtfB0Kla59hAm6h5Y/p0nAKX8Y+yr52/mK2U5nrH+2 hfS//w3W7c4ET/DXTDnly0qtrnvotoU8irI8jZt6PdrASx/nf/QCHupesbiS82wbFj KiEcIUhAXFG2uDrfO7LiMuLy2Rl8udgQmP0xafcIhBpkH7aY7lDryUSN0oIFlsieQ6 w46kYv6osQmpIdkqCMMZ7FT6hb0JL4NY4ZUNEszYWhQrH29kzmKstStqhSqFr9tdTC teVpDaZxwOf9lyI69y4dN4BLbnN/YZPQNcQueIoGSoDt4n070hfVug2XT9bl33UsZ8 IXUNAIM0JHyvA== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Jonathan Corbet , damon@lists.linux.dev, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/11] Docs/admin-guide/mm/damon/usage: move debugfs intro to the bottom of the section Date: Thu, 7 Sep 2023 02:29:21 +0000 Message-Id: <20230907022929.91361-4-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230907022929.91361-1-sj@kernel.org> References: <20230907022929.91361-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: 48A3F40003 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: gdwmooszx4qrqoqymucus5n7ejcweumd X-HE-Tag: 1694053782-262476 X-HE-Meta: U2FsdGVkX1/Xcx8uaBPVNz+aQBuR319Ujkr6fxjZkZz66Z8VxSUM/IHVPAOn9VziiL5nJxrnzFRYQ5N6OENu3BVqgMeHoaGCMvXHwjrLeyCEAASatBpksSHtmT4+CMJ06aBKBot08ItZCwQn9Dvk3ashcOhqYqdvuWb58Pn21uUHVjldy6yxMvvXQ0CfUJqFx3LSB3NdIKuDnNxk5dp5NlCJWrZSvvzNG2xK1xE40MOLmkgCOAK+rb5HicDsiwc40tWWY/BT6e7LFbje9JdetyRjvnqIP2L9TgIB0/1Lcw7Xq5XtQ/5eH0ZNDRYleLXRTKC15Lxy2NE/ktaxVl2CU51Bsq1nS6PkgM2xR6XdVZIZ0bhtDzfoVaD29ZJ6XxMbAPP81Bld6DLjKv1o6oTCH/7GawTrl0gBpugowZxKMBI3DauuKFxt2taRzh34wb71OzLz5tI7oTUdwcRyRJe83aF8JAW61UaP+ue+n+eaBUGuF6wStRk/zGSYGLjH/KJH4bcBq0toLF+0wxU39UpgtVyWcfLWtBAi0pQky3DBzh+t9PrVAZN1E3kAN7zwLQvzwR8vLXw4E9PWAT9+xjJ14OWyztSmH9NecZTCEcuxr1a7zdWx2ppeFmTCwUg60UxaYq57CdbejC3dd9cOMW6DZgb17b6AcU3/5/GY68LCejcZEE75Msa02+9zn4sFLHN8hpNWrrsprGC0MR/aVnHMWLGSumzCTjkPPjd3t5md9xTIqWMr+zqKYEQVKnUOn3sJ6QFByIxNfF4qTv+3s7xK4W3fFe3qjSS5QX3WI7NPg86NK/A8qghznxv+4BEsJiChy/jaPlqUupef14C8BPJpDJ4SpLrWQWd2E+lQOCE6GbOvbIXwuS4UIRosVtYhGKcWZGxdDRibkyGZSXJ6uEifJSwGgIQOsWvLVMMBv50a89azQfqFeDwiLrK2z9tsa76hTZlc2M6npRp1sakiYVC 4JkHH1Og 5cEQfacrbveMbfSqcinfYF4mt5baJfGVSZx93o20696CIwpElau+bJJvxEx2i3GyH3Dazw17p92tVo8xzQ1jhEyilDDqmD4bd0vFgV+vzSWh8sgRgFG05quUo1a4EN9Mk6goXZMKhCCewsmRD+8xQcajCkU3zSCs6s69gaG30b46G6NTJqiG9Aj95Gi+/2MvQ+ooajHSDkKCc40uR/VDnnrVeVWhsFrYAz5wxHioPnfBGKHLL3nEm5SM5jw3RuzzMlSVfkoZDcP06u4F2oeZiCDZ1FsPgWiRZF02pytd1QiFb6g6JBDKucvX7qIOpwXMUFFM0AaZfu6nb4zk7Vt0lHcNZWipfuJZVeznkUcqjchd/LD8jnrjfcKu7OrlLFdQuQ3LIOoWzVwR9algm0d7Bqg5+PnKyksnx922dVdYx0acCROTyjUk0LXuimcq7X6HE+JmI7b7it5+SAgGv7OFKx1AR0d/zRY8vyzbj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On the DAMON usage introduction section, the introduction of DAMON debugfs interface, which is deprecated, is above kernel API, which is actively supported. Move the DAMON debugfs intro to bottom, so that readers have less chances to read it. Signed-off-by: SeongJae Park --- Documentation/admin-guide/mm/damon/usage.rst | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Documentation/admin-guide/mm/damon/usage.rst b/Documentation/admin-guide/mm/damon/usage.rst index bffe9dd9b0d6..e48101c777e1 100644 --- a/Documentation/admin-guide/mm/damon/usage.rst +++ b/Documentation/admin-guide/mm/damon/usage.rst @@ -20,18 +20,18 @@ DAMON provides below interfaces for different users. you can write and use your personalized DAMON sysfs wrapper programs that reads/writes the sysfs files instead of you. The `DAMON user space tool `_ is one example of such programs. -- *debugfs interface. (DEPRECATED!)* - :ref:`This ` is almost identical to :ref:`sysfs interface - `. This is deprecated, so users should move to the - :ref:`sysfs interface `. If you depend on this and cannot - move, please report your usecase to damon@lists.linux.dev and - linux-mm@kvack.org. - *Kernel Space Programming Interface.* :doc:`This ` is for kernel space programmers. Using this, users can utilize every feature of DAMON most flexibly and efficiently by writing kernel space DAMON application programs for you. You can even extend DAMON for various address spaces. For detail, please refer to the interface :doc:`document `. +- *debugfs interface. (DEPRECATED!)* + :ref:`This ` is almost identical to :ref:`sysfs interface + `. This is deprecated, so users should move to the + :ref:`sysfs interface `. If you depend on this and cannot + move, please report your usecase to damon@lists.linux.dev and + linux-mm@kvack.org. .. _sysfs_interface: From patchwork Thu Sep 7 02:29:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13376097 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12019EE14C3 for ; Thu, 7 Sep 2023 02:29:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 98CE5280022; Wed, 6 Sep 2023 22:29:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F0A7280029; Wed, 6 Sep 2023 22:29:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EB19280022; Wed, 6 Sep 2023 22:29:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 457A8280027 for ; Wed, 6 Sep 2023 22:29:43 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 21119B42C1 for ; Thu, 7 Sep 2023 02:29:43 +0000 (UTC) X-FDA: 81208220646.28.850DD67 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf18.hostedemail.com (Postfix) with ESMTP id 76EC41C000D for ; Thu, 7 Sep 2023 02:29:41 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ohoS0Q5N; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694053781; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vT0qqmzZ4R2b8Z6h3w2hqYqtimOoHaKOyhjsO73TOmU=; b=ZCdqOlY9qFH3kXU0/8nv3UuaE7UoI9u7SDeb/DhkWOxG/8ESQSj50tm6vqdoPKm2CS6rv6 8ntEZt66ASIzi+wK1spyQkv5oE4C0oRD6AoO2+aJ6nUJeHjEkJfP2ekpbGh01pKMMNiYuk b6cxFcw9jYTiv3Y8ESfVV8Jw1v5N4Oc= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ohoS0Q5N; spf=pass (imf18.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694053781; a=rsa-sha256; cv=none; b=dVSeUHMxgx5b1O+PilsxHMZoUTqX1gtUGFCK9B9LvFNqouSosSSS4b2892pS02bc30WVP+ 78kxb75tviFDvHFLMFpDiM2ghSK2JVETU7fuwXvHDFih0pyqSr9aVueLMdblixtQml31t4 8+HGL/CnQH/IWWZTuBM2lNGrHKrMXIM= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AB02B611FE; Thu, 7 Sep 2023 02:29:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0184BC433C7; Thu, 7 Sep 2023 02:29:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694053780; bh=EttCSXcWQaBCLpMduSaDVf+bO6xFKw8ChvQvuGULuQo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ohoS0Q5NTqWvbTzBXP57Dq2ofbn2QBljXe1cpT6j4lRuQzRB3V3WC0/jjWNW9zKsh Pj0L+aNe9DpvOK+7f35EDNXepLHd2afINFwGotsGZrvFObI/8v0cnnEYpBOI2JUYmH /zr4DyQSRbrTK5dB2xtxZlxJVBO3UwjdbgcXEKRHJ7oe+HD6kjIPk8WJR4qzpiLMez orXkcK9BjJfpw0WtGMGlpGtkR3tkbB/jErb9/Dcmbg7Npz4s11Z0ecchpXsRgN5L5M t0gpXfrIaxSegMGSQeogKMEwEIC3I5l9+WKq0T+o70jZ9Bez1OALFBaPB6txHNOCkN ks7bnKiPNy1Vg== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Jonathan Corbet , damon@lists.linux.dev, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/11] Docs/mm/damon/design: explicitly introduce ``nr_accesses`` Date: Thu, 7 Sep 2023 02:29:22 +0000 Message-Id: <20230907022929.91361-5-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230907022929.91361-1-sj@kernel.org> References: <20230907022929.91361-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: 76EC41C000D X-Rspam-User: X-Stat-Signature: uw9k5hsfna9b8ynm1bg7p86ipzib6kw7 X-Rspamd-Server: rspam01 X-HE-Tag: 1694053781-558204 X-HE-Meta: U2FsdGVkX1+KBysRTR6RX6VkPgFufMCobFLP9Uf2YtZpqcfhZ9Qs1BX1uooBpl4woOVS7V+DdLH+eb2Dir+qIFBa/3AYoUR0NNM5RpJ+jV7HAgFY2pXfWZQ7KL5LpWd2rVHEq6EjT9YULyBzbTyi8njbNC3JWYr2lZcPbenfN19XfaDWnHCswTHdB2iH+ugve90j1db3codYasU247MzAFH1dVfzhzpt5gHuv8PqCPpMfol8j/7uxto1aSlVDlFp6BcljaASSybTjk6Pw+sOXsGVoK8J7Ve7KSboDuzbveiK8D0DMwUOxkFRgE+7MUemutbJI0fz3HWs9W0LWQ3e+WQn17ZZqZdp+tTrNcFPO8T5f0XJRltKWWiSt3UiVglgAmkbwT+MdIZQOeTI0qpP/YbYyd0bBBkK/Fd2FDc8Zit/MYdCqXCnUzJOeB9noe684jjZxckjH2G4PVWZpK6XWka7dsoQEXUfq3DILQaZmpVzmFZrJm08N9oS89p77KVz04j3DiH5xcuL7A3GA4SuuDQmijIbFc7Ny+8Lvo0n8xIn0p4qOObNDpaBjorh2ZUs3JuqxoFXnphXC3x+jXb3+W8JkfQty8Ips/FpF7EtgAX9ME7UzwCea2pYodUUUza31boVYHMM9ppxlVx3p1m3YTPaT8TOjd65MxYVNEWQtlUarV5IOTC21CXVjDdFJs2lC9NZRoGTNEWTv5E/B0Vko3G3bqwQVIIy/hXEBXd2Wlfh5DD4PjojEQXZ8zoGRTm44MUbB0FmQAiyUIFSJFCYK5elSnCG+E8SBJQwp1S9S88EZtwlO8ONs0Ner0rXO0mEwFSjciyErq0LU3UkD6xW+ixFB0GKzaAgc6MWbvmamSqmhDlNxW9Pj+5uGfvB88b+NNo/GGTYfnkhjKtz7M8RYx3I4bDf69ys4BUnVvwVyfjJWVHXyKy9qgsDOmhdX+VfLREehrYstBGXAMdIWWn PPYKna1X 0BdGd3Xa6AXS7MczThrFBJBbwX5Jbeh8uEY6N/9/VuEF4Jnf1D0cUHU/DKyuvUEGfuRr9cYuF19Ma+i5YHe+gM/YH6UAEV1inHKns0CaKBoFnE/ZJQhdp0QcYxO3ZAR9jHx/RhZcbMOQ4wvEY8zq46YSPvqHpeMvR2XVHZyJbNtVF82TZCoK/RORhHbVfXKphKnMOwXOAbnaNleTkz+uQNbLS0ynhzYJKMjA9IayWcFZVf7GIjAlU2xZXXfgWPIFCCmbzh1C8a9ivlRUUW/qwLBHiAGWl2iKGPUO+2qvv8aNUz4nCSIzDmh2vlxhUBU8g5VR00VonH0AYet40/WSHNgv48AfEGgI3cW1YByCsfc700ovJefXSBOXkc1wONjRAQyUd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The design document is explaining about the access tracking mechanism and the access rate counter (nr_accesses), but not directly mentions the name. Add a sentence for making it clear. Signed-off-by: SeongJae Park --- Documentation/mm/damon/design.rst | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst index a20383d01a95..5c465835a44f 100644 --- a/Documentation/mm/damon/design.rst +++ b/Documentation/mm/damon/design.rst @@ -163,9 +163,10 @@ assumption (pages in a region have the same access frequencies) is kept, only one page in the region is required to be checked. Thus, for each ``sampling interval``, DAMON randomly picks one page in each region, waits for one ``sampling interval``, checks whether the page is accessed meanwhile, and -increases the access frequency of the region if so. Therefore, the monitoring -overhead is controllable by setting the number of regions. DAMON allows users -to set the minimum and the maximum number of regions for the trade-off. +increases the access frequency counter of the region if so. The counter is +called ``nr_regions`` of the region. Therefore, the monitoring overhead is +controllable by setting the number of regions. DAMON allows users to set the +minimum and the maximum number of regions for the trade-off. This scheme, however, cannot preserve the quality of the output if the assumption is not guaranteed. From patchwork Thu Sep 7 02:29:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13376098 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D9E0EE14D8 for ; Thu, 7 Sep 2023 02:29:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BB1E28002A; Wed, 6 Sep 2023 22:29:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 542C5280029; Wed, 6 Sep 2023 22:29:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3735C28002A; Wed, 6 Sep 2023 22:29:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 10060280027 for ; Wed, 6 Sep 2023 22:29:44 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DB22A1CAD28 for ; Thu, 7 Sep 2023 02:29:43 +0000 (UTC) X-FDA: 81208220646.23.F00D52E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id 4A25A40007 for ; Thu, 7 Sep 2023 02:29:42 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=e1aBIvrV; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694053782; a=rsa-sha256; cv=none; b=hVgB0rgrnjN3VjLp80jnIv/SI4Hr0CURnwD5i80c1InXVvMvMW7oAgYmhCLiyTfpjqEZXU 6cfc43mbO0xnObwkg2nZyLitFla1Bqer6l3bCzSKrIQ3x+pQR6habRIvs4Y92wFjXnfObM YbirsH8LEyu9UdX24P6gjLkR2UxgwsA= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=e1aBIvrV; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694053782; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WTLK4j9PrIQ0ettyDfx41Rnu2+T/YaiCbqhNgxLxtuA=; b=pi8QATltECuVCRZteiQ6v1ICOl/reSxTtc2z5QgxMcIIehnmoLlVwjZw4gzeQG4yc0llOK yIGM8MBd99Y7ZLibnYTxlJvNBXn4SuTZt0h3liDU8unIve0hXEUGxmnywyIqPPaD9PwLfR CQLjEYXFW+Hm5HFFjBLBIr8IOa8PL0Y= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6A5C361191; Thu, 7 Sep 2023 02:29:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3E37C433C9; Thu, 7 Sep 2023 02:29:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694053781; bh=/4c0bNqammeumkz0XhdEYekAGWITk+eiJUgJ8I1y+iI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=e1aBIvrVp1OYAQpfz00zRovXOneOesmUDSZyTevcK820XKsGAeBqVz+uKLkcn19ia t6iRL/0aRlSuwJh0x/3UVFXNGwBKDRIioHx4gYhpYlanDqU5oNeS/uQo/0Kf0FYlTn yHWjH8sqOnKWJtQ8ZXjS0fEpJY2oDw3OKXbcwx4Q8uXajUh3jhQ00R6lMX83jpsFLU 7qB3XGpSq8hnVEiIUFzsOtdQuhLHqy8onWed+iUqj13gYcdnfp+m/ndsdEmepn6P66 SD0M9Ouci60A3Zf8RhsozItBrOl647bJks1M3TsZTbi3TpBkLEJgMaWCHyNU2RtBuS owRht7VtaeJcQ== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Jonathan Corbet , damon@lists.linux.dev, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 05/11] Docs/admin-guide/mm/damon/usage: explain the format of damon_aggregate tracepoint Date: Thu, 7 Sep 2023 02:29:23 +0000 Message-Id: <20230907022929.91361-6-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230907022929.91361-1-sj@kernel.org> References: <20230907022929.91361-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4A25A40007 X-Stat-Signature: ayca18mtdiqp5thbprrghb7it3ke3cn7 X-Rspam-User: X-HE-Tag: 1694053782-782019 X-HE-Meta: U2FsdGVkX19IXSavnPy5gmP07h8Y3iyGtorQWywbz8AlPo+ue4cBgbGuJnkyIhnRT/j0Jy38dCi6weEo7ykOGuLfWhu1HM+pAaNgwYKGo3WkDMSmhLnAOgu2RIFdajYWSGlq/ugGn7LwnTIREmB7eq2ZDYDcFiLpx8NdxO00lizMMQWAmCWcTp23fmH4P/4l6hNHp+GrY/QJqOZLVDCaggjOhkn5usUymdoGgy+JmdCAll6rn2SbhftJuCjdJ3BtJpByh38bdRIw8Mik5smE5Fu4ZWeMp8iccR9Zt+cvqn7Niw/l6Se5yRfTWnADc220I0BiB8Bsa4kx2a7bDg32jCeRf0NLaO2jVplg011p1FluUtXlYavRX36UT3+IZZ0INX/FV5ZjRnKtnOtdJSQttze4oAKEwTxK4ZRqt4euoTIJEvldJcht4ej5GxOY0sNfcZsbNbvpKkGrPK1NdgrIyNYm4fX7S9Rm1alfD5KOyWfJs79at56a3sLKK46ZF1vW3DATV3AtU1PkRx4pxqvZDu5XDopzo5W8Qo5yr/cHcdISHMlQ6kYDnUuQ19kOHGv5bC0VZ1AufA0FssynMMEuqextfKdhqo7L3owi3+ODtKZCWNp/oMuDUAPm3i6e6naQiaUOczsCrhsWJodyOe8XXk1xt6OfvKst7fXhbQL2LcNEqujjWhIBCrZC8hIKPlATSK1BGfCmSap2Zl5viHwFcvboATqqoRoUfIeeoh7Uh5I3PoacyvItjRnMX3MdQpOk98L85VfYdwWC7wfvVvC5p1TmagCgbh54zauJp3CG2/Yx0L2PbmZu+YgBePu0jPfovXP+BSJQVAirGSuU+hb1mkVOC67zD6gZTP5Eo/j8WR39HehL77ouX4UDUHq/HkoMcnfopsY/eROqEyO8P6EbcPC2zl0BGd2NWyyyEOpTl/ftYnIMLat6PqCWWjijBWknQmceEjDQh5a7DbirjjL sbpaoLw/ bnA8piQRjhopTyl/ZILQVPPTA3vAd1X/4TO7HJagtmxityJe62JrnZ5IFjO3Y4UzHDcwpIOz0jmv5SXmI8WJMrEDn0qC9XvZkLU7lfYD+QQ3LdF+SdvkpPlmdUPcLxTyK/WEspzAsK0dsIu6YNcVaxByxvIf9VhuYOhFsaAsPPd97ULJQT72IRNXM9nFc1DWQyDtKLRT2GCuHBv3jm2gVs2lOccZ1zQ7IPobhCmUCrC6v+8xzKhYLTUrkqHFIDfVFm5CUGsaehV84SrCtTsN/XGzvhv5I7Q6UOMoVHpM/ha7xEh7fP3s0Zt6ombpFgrAUGoqz3la8Rz1vZpd7xDQnaqW3H5m7RszKcA4CdE1q/IXJYHlfG33iyAw0NBXRt5EQ3aVZq3sU7u7lPnOn/Kn9MaO0bkUYHeX+/pKW X-Bogosity: Ham, tests=bogofilter, spamicity=0.091820, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The example of the section for damon_aggregated tracepoint is not explaining how the output looks like, and how it can be interpreted. Add it. Signed-off-by: SeongJae Park --- Documentation/admin-guide/mm/damon/usage.rst | 14 ++++++++++++++ Documentation/mm/damon/design.rst | 4 ++++ 2 files changed, 18 insertions(+) diff --git a/Documentation/admin-guide/mm/damon/usage.rst b/Documentation/admin-guide/mm/damon/usage.rst index e48101c777e1..758575d33ab6 100644 --- a/Documentation/admin-guide/mm/damon/usage.rst +++ b/Documentation/admin-guide/mm/damon/usage.rst @@ -513,6 +513,20 @@ results using tracepoint supporting tools like ``perf``. For example:: # kill 9 $(pidof perf) # echo off > monitor_on # perf script + kdamond.0 46568 [027] 79357.842179: damon:damon_aggregated: target_id=0 nr_regions=11 122509119488-135708762112: 0 864 + [...] + +Each line of the perf script output represents each monitoring region. The +first five fields are as usual other tracepoint outputs. The sixth field +(``target_id=X``) shows the ide of the monitoring target of the region. The +seventh field (``nr_regions=X``) shows the total number of monitoring regions +for the target. The eighth field (``X-Y:``) shows the start (``X``) and end +(``Y``) addresses of the region in bytes. The ninth field (``X``) shows the +``nr_accesses`` of the region (refer to +:ref:`design ` for more details of the +counter). Finally the tenth field (``X``) shows the ``age`` of the region +(refer to :ref:`design ` for more details of the +counter). .. _debugfs_interface: diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst index 5c465835a44f..51aab9b0621a 100644 --- a/Documentation/mm/damon/design.rst +++ b/Documentation/mm/damon/design.rst @@ -154,6 +154,8 @@ The monitoring overhead of this mechanism will arbitrarily increase as the size of the target workload grows. +.. _damon_design_region_based_sampling: + Region Based Sampling ~~~~~~~~~~~~~~~~~~~~~ @@ -191,6 +193,8 @@ In this way, DAMON provides its best-effort quality and minimal overhead while keeping the bounds users set for their trade-off. +.. _damon_design_age_tracking: + Age Tracking ~~~~~~~~~~~~ From patchwork Thu Sep 7 02:29:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13376100 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76E87EE14C3 for ; Thu, 7 Sep 2023 02:29:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 285A028002B; Wed, 6 Sep 2023 22:29:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 23687280029; Wed, 6 Sep 2023 22:29:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AF5128002B; Wed, 6 Sep 2023 22:29:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E9F80280029 for ; Wed, 6 Sep 2023 22:29:44 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CD50FB42EC for ; Thu, 7 Sep 2023 02:29:44 +0000 (UTC) X-FDA: 81208220688.17.AD44CA8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 453A4A0003 for ; Thu, 7 Sep 2023 02:29:43 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=I9w1kxv9; spf=pass (imf15.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694053783; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KMJyRsRl0+WyLbI9IfWC7CH5HJg0EsWACMvwQ7Z8xg0=; b=zhFDaG/HA80cF1bUVhKtcXjgnuW7wbGuzZTkQXqwVrH3vcy0VQUZJvnW/Fk7A4BzFZU3gy XLhW3p3J7WnZdY+HptnvaoOgb4gcru8Im1orRpkTbLsHm6jLZQyuCscTEONyHY5bg0vyGU 1vBVLiVMUUp1pnUtCksdz9W43izdV6E= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=I9w1kxv9; spf=pass (imf15.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694053783; a=rsa-sha256; cv=none; b=MNmkUjpWBZY/5Wgd1QAVDB/tjClNQSea1RJjvhgVO1wkKT7C5/VCojnE8ETY/PsG2/Ou7W ANEVv/VSEi52HOs5qrO1UWDQ0BESm2QcVGbC7TjHM9bsfegISVqk5UYo8rQxkT6PpYRr7X 2sQbqiO7zM6UgGfhIdZbms7SrJ8i2PQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7D94161211; Thu, 7 Sep 2023 02:29:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73D10C433CC; Thu, 7 Sep 2023 02:29:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694053782; bh=nX+lBCNxvHlh2Hd6gi4Ol2YBYOd7nIVtVx3JTRH4uq0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I9w1kxv9RA186Id0zHiS1zj+BAWURWAM5lFzFwxGnAFkbOzT+alc0bJOmHHWt8jct Q4jtNAkHhp+5IA6yHicRT3lr/mvEFKowHjn869YNnj4WhXTR6m9pryGxMT2+ME1DTC DMptSU91rd7c6N4zVxIIoXhw+QDzsyi0AO1xQdEgloEG1ovEnYjbJyUsoo6s74QWSp beuyoPPwVNVq+pc8howL9hkKWIUO3KAdpEzIpzs3Hhu0WBQMaGsAOnUtSDLvDS21uK qwRvMdnKNG7PeimG83FzH02OCX+LD3nmd+vZ0CUO8eRiFMPYGbJ+Ekra1waYsgazYV Kr6xv4L++j1iw== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Jonathan Corbet , damon@lists.linux.dev, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/11] Docs/mm/damon/design: add a section for kdamond and DAMON context Date: Thu, 7 Sep 2023 02:29:24 +0000 Message-Id: <20230907022929.91361-7-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230907022929.91361-1-sj@kernel.org> References: <20230907022929.91361-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: 453A4A0003 X-Rspam-User: X-Stat-Signature: xfene6yb88qfmyx1af7gxcfc6971bemm X-Rspamd-Server: rspam01 X-HE-Tag: 1694053783-793637 X-HE-Meta: U2FsdGVkX19lkMESrf+QrEGnRq87jsu2pdlv0ux3IMEkY8GxNPB6K+exJNNS47pTT5yB/4VKMuDwYV/8OMNMqilyePkls3Y2xx2DQBcnlVQtN88LbzOWeV6aEXhjKLpNzyyD2+XXKMhGB7k3a+X2IGj00dCEpPbqyVvTIvdkOW411s7OG1qYBUfqEwsYNrGSszvIEWMC4smkcA5zuzJSMd6VrnK/0gxrfG8+e7ZB8qQvQ72j1lOh9PJh0PNH/yUtPyLwLocNRoHF983C7qBQgkfAD7LRuU9EO5Hkc7OgTkHKQ68+KdfD6zDrp6yPmA1j5pgOQ3NtOW2xhKwdqIkTVw+yc8GzvJOK5GAX2LXFvP1BTRWsrP8Dp8q79mmqKHCWMUavbllGDvyuQOgSF4ae19Acp+ltGQGoqIRHIq2gX+nuRU+gKyar1FF0CxkbZeBUwSOO1f8PRE0vnKEUDzdXYggp5T6bAW7G67XOGDJMQway3SkyTadotEBW5zaU7JTqjrLkNNvM11lUz8wTRzWj+5CL3l4Qs15LkNHjT5XnKCCxg8IM5HwyFF7M0CSLcWvyTEsTTEKAJ2tIC7ndKpXmAn8o/DowxnSEXNDdyD2HutI6q8E1RY1gu6P6u9JlhUaF8LCG4RpNp0LlDOxHxDd16XAtWKdx9iOJkYrvafvi0hQOI8ZzHlugWf15f2XvfaceSqRqPRc48jirvtRxQLFhKffNQJ0uSgO7C5+B7XJJ08DEhMxrFSVOnDgKHOp01lraKR9fSKP4Qlwz1hZ6GhTwY2aBB7lgMCvfmF+V80iCYJKy86MD0gKdNX60FTdoGkW95w2H5tTct7VAwgOEaoQyMs4x3G1i7raDb3l2Hr3zbUGh2ZjXrYwUwSdN0/2sN1DNMYrVbt40WgxhBvZXdaImT2kwSBOJI/lBLRbnAT5Gc5AVLepYqRC9f6Vw0IR0q5Ef2f6opiO2WTsKIAEcVos N+bDy7hf 4sTfssW6i99GDgGttGMvx1bPRQrxwRxXoBLxBx4sxmGZj2AnT/SkIgnJ7bpIBAoaazZecRX7peMkZ7RPLUWkLrSUx1k5u8qWUONMmbYp0Y5MKlAccyIPvBIfaGUE9WiP8W+scSJIdvkgHQjGybs2t59aMELWLQeSD/WjKVhaCcNtsPe/Yv9j3xd1ky7vK1BF7Df514g6PIwaVyft6K+uf1p4gI9nKhenld/YAH2A+NLjRomK1uHIZgYhmVYpRvEM7tsYTdcizZLZyTfdR/URjeGh3vCFaaGHozQWGTsX3I7gQE2YZx8RbKDyybLcQmNrxQgKYqlaYEdRfZ7uD4wC+7g7AUg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The design document is not explaining about the concept of kdamond and the DAMON context, while usage document does. Those concept explanation should be in the design document, and usage document should link those. Add a section for those. Signed-off-by: SeongJae Park --- Documentation/mm/damon/design.rst | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst index 51aab9b0621a..ee099d45fea8 100644 --- a/Documentation/mm/damon/design.rst +++ b/Documentation/mm/damon/design.rst @@ -476,3 +476,13 @@ modules for proactive reclamation and LRU lists manipulation are provided. For more detail, please read the usage documents for those (:doc:`/admin-guide/mm/damon/reclaim` and :doc:`/admin-guide/mm/damon/lru_sort`). + + +Execution Model and Data Structures +=================================== + +The monitoring-related information including the monitoring request +specification and DAMON-based operation schemes are stored in a data structure +called DAMON ``context``. DAMON executes each context with a kernel thread +called ``kdamond``. Multiple kdamonds could run in parallel, for different +types of monitoring. From patchwork Thu Sep 7 02:29:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13376101 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97E28EE14C3 for ; Thu, 7 Sep 2023 02:29:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD4A828002C; Wed, 6 Sep 2023 22:29:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B83FA280029; Wed, 6 Sep 2023 22:29:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D9F328002C; Wed, 6 Sep 2023 22:29:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 82BAB280029 for ; Wed, 6 Sep 2023 22:29:45 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5AADF160F4C for ; Thu, 7 Sep 2023 02:29:45 +0000 (UTC) X-FDA: 81208220730.13.999F797 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id BB59480009 for ; Thu, 7 Sep 2023 02:29:43 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MVm2PfWX; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694053783; a=rsa-sha256; cv=none; b=jxm8OSFS5K1vqMa62O1a4sdBAh4oVGd5bpHIXE+5yZBWqnNzBj5Sly2mkubVSqoVqHG822 cUkqh4YxNOGFazyhA4/rYsGuqfQpDpD/BhJ9INpI5Y6zZ4WzvFzexS2EPIdfXVtW4k+WwZ Wcn1gi8/IB9fKj5bPtxxlgbKqzmmNqc= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MVm2PfWX; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf30.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694053783; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=G9MR7Mw5zSiENeiUoafSx5gmKmaBzGpkOuYNCChq1RQ=; b=qiXyUv+BhfF8/4plNNjOii6U32dlggrvP0sn0G+5djupMapdM62viq1c+/SLhXOWJK0Jnv N3YJZjBjh+hzu2vjSczY4a2XqkATe6VOHWIb4DMyIfr0PpTMwz0iuY+ENhAFuWkcrpCNoM oY7GvbiFxgmX7i+FwErtxsrCGjqnRIk= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DEE17611DD; Thu, 7 Sep 2023 02:29:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34969C433CA; Thu, 7 Sep 2023 02:29:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694053782; bh=M64Pfxcjf04QA6IY4mZMjdI8QQdmOQDItlzxRcwz4LQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MVm2PfWXGzcgo0kBxY/8/P25MQuwXf2YFzHZmudczea0VOOSzggdox8oqOLX3u4Nr ZlZHTblD7l+UcOvhoYenzWvOLWWxJslj5dYbFGfNz0oN3B81Pcxt+aPPDKmI6jrtMo YllggfJnHAK1A1kkPPl/wWO7P2zWYpBc1Pe//JP9NYo6K6Q70bKcUnlzBrImIpv2NS izprI02tEPyUMz1Hfpctj6gMDM09k49HVu5q+X2frB82M8+ahs+8gOQpnkbrxSw5zm Qkvh9AomlCBXMtNeaCR/vzEj0YIX85F7RxK58U3UuYr+LD8Mxn/OkeIaAZNfHgvaPS MjJ6rWY4ilFKQ== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Jonathan Corbet , damon@lists.linux.dev, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/11] Docs/admin-guide/mm/damon/usage: link design doc for details of kdamond and context Date: Thu, 7 Sep 2023 02:29:25 +0000 Message-Id: <20230907022929.91361-8-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230907022929.91361-1-sj@kernel.org> References: <20230907022929.91361-1-sj@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: BB59480009 X-Stat-Signature: fw88axrzyjkzadgxkxzqs7uiebbzg6tt X-HE-Tag: 1694053783-153106 X-HE-Meta: U2FsdGVkX1/EbAWOMda+pJyYQTi2EN0qoU6sq6Ft4Lgut0QYOZHQAdmi8BqNTIviOvHZ+gcAncyJvp1ZUNn2njK3rBgOGLA7d8dW979QbA2/TiFAzR7bAbwZnNGyXW3eTx4e302XgyIilUHEw8rDlNQ9FHRGkRZDS1B5GYxpfYFldUgKJt9AStfNvyKZa++F/PuHaiteYGZqRiCLK3nA9mgeoJPNrLZ6mVKrBEfqko4IHyjxN2d1uZq8nXYU1fUjL3cEdk4rQ3Nde8b9aE8oOYA5fVhTy3RHRuFkf7v7Kgf+b1N6cnJa9Mr3N10JM3MSIoNv131qGNiitt4/2E5Ovt/cCETM5hy4YERuxXjExS1OpQQN4M90u5qMU9FIOmYZghyoSVr6bTOZmpM1HV6kYxtqmmm+jF39WQ4ZPo1h4abtVP7TFr9KuasdiSXOOyxfs+B4g2iXPpsZfTIKJbcB8Ws4m/Jc7glrWZc6PEI6CGhsVE0L13Nv4/OZdSdiONMuVl72CZitmm7QkcZPLHeD891+DTweZL6Noj/FWc+g2TxVtL4yTNKElLdFwr0n1XgJ4Ocgj9DM6nPj0qurWbQYQtm+D5UUZkT5sRSKqIPcyJUB8w9P3KPj/S7MOeVK9ck3znbClIDuDTZHGczxyilv99O/8wLWnMFtG5cMtJ9SG5wzJyGwEOAmaZlh1mzhg3/FegEG8x6tKI9efK0JMIvzaVzysm5quDa8Y78KQm/HKO+B6/h+8MAwjaw8QrUtGiyKY1+0f27yvwixzsS/+sS17Ycu4fyOV2cNmLYlgtufNrSGJAv4jmyq9rnv1F61vGCCOnNB/gzC3dRH7m+4OCSVIVBybyvPkWtiapOkwY5NZ5BvdP2r1Cf8EmcSjIu/JLAmLlk32oMEhNannO8HAOUFMB2KPIS/TrbJzIH08f9h3kj/8bEb/R9jjajb9eEaPnd3HD3r6g/qpmsLNfMdb3Y iVyognLp KKqG3JMWvtq1mHX6i2Rk1qq0p9nU4heNZI7giPtU3OyB1CO+wOU6vAFAr/YYv+Wa3ovVqJJ9ohMnYNjAbe4T7gabHs2GBsIgsaw7n6rjZRxo7doqrciLZ0wlFLoDjIS66Lvi79aDhg7wx9LjCtBUtVx/i/un7YvyXI8wJr1dhrT8Hy+iYKmJCCU+3QjzYQ9z7O/6AeGTFAejjOfJtIODuZ1T6q0KdEO8ic6Q9fzgJPt81gFi1imlgaLo89eQV2fY62C23WvgeLq874QiDYEf6bzjK5StId/6HwWEVroBdkGtN5Gs7zWu9Rhyak/IwosDJndUvHdSOdrdbqczM8V4ag03I9zw5bAPhfjabjTg9zndRh/2O+eIBQyaslw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The explanation of kdamond and context is duplicated in the design and the usage documents. Replace that in the usage with links to those in the design document. Signed-off-by: SeongJae Park --- Documentation/admin-guide/mm/damon/usage.rst | 19 +++++++++---------- Documentation/mm/damon/design.rst | 2 ++ 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/Documentation/admin-guide/mm/damon/usage.rst b/Documentation/admin-guide/mm/damon/usage.rst index 758575d33ab6..282062b6f134 100644 --- a/Documentation/admin-guide/mm/damon/usage.rst +++ b/Documentation/admin-guide/mm/damon/usage.rst @@ -105,14 +105,12 @@ having the root permission could use this directory. kdamonds/ --------- -The monitoring-related information including request specifications and results -are called DAMON context. DAMON executes each context with a kernel thread -called kdamond, and multiple kdamonds could run in parallel. - Under the ``admin`` directory, one directory, ``kdamonds``, which has files for -controlling the kdamonds exist. In the beginning, this directory has only one -file, ``nr_kdamonds``. Writing a number (``N``) to the file creates the number -of child directories named ``0`` to ``N-1``. Each directory represents each +controlling the kdamonds (refer to +:ref:`design ` for more +details) exists. In the beginning, this directory has only one file, +``nr_kdamonds``. Writing a number (``N``) to the file creates the number of +child directories named ``0`` to ``N-1``. Each directory represents each kdamond. kdamonds// @@ -150,9 +148,10 @@ kdamonds//contexts/ In the beginning, this directory has only one file, ``nr_contexts``. Writing a number (``N``) to the file creates the number of child directories named as -``0`` to ``N-1``. Each directory represents each monitoring context. At the -moment, only one context per kdamond is supported, so only ``0`` or ``1`` can -be written to the file. +``0`` to ``N-1``. Each directory represents each monitoring context (refer to +:ref:`design ` for more +details). At the moment, only one context per kdamond is supported, so only +``0`` or ``1`` can be written to the file. .. _sysfs_contexts: diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst index ee099d45fea8..18e9b42673f8 100644 --- a/Documentation/mm/damon/design.rst +++ b/Documentation/mm/damon/design.rst @@ -478,6 +478,8 @@ more detail, please read the usage documents for those :doc:`/admin-guide/mm/damon/lru_sort`). +.. _damon_design_execution_model_and_data_structures: + Execution Model and Data Structures =================================== From patchwork Thu Sep 7 02:29:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13376102 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CF87EE14C3 for ; Thu, 7 Sep 2023 02:29:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3700828002D; Wed, 6 Sep 2023 22:29:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32165280029; Wed, 6 Sep 2023 22:29:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 173B928002D; Wed, 6 Sep 2023 22:29:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 00B7A280029 for ; Wed, 6 Sep 2023 22:29:45 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id CDA05140FA4 for ; Thu, 7 Sep 2023 02:29:45 +0000 (UTC) X-FDA: 81208220730.15.9C1F60D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 388C31C0005 for ; Thu, 7 Sep 2023 02:29:44 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=o5w62vS3; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694053784; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JjKL+ChY5zoP3UCge3ViOfj/+gBb7K5npBfEmTW69iA=; b=k6IAc32Moxf4O939H39U7Zy2XHDIul2lJafOiu3xXtIVV0PLiU4LxDTQeXxzZ6P63y/Wlb Iqh/mXDRxdfIpPk9oMIDCaatClCjfL0NPiP3vENwebdNS6692lxyf7/xCgtxJGG0cHzF95 tY6LMNcQqjCKreYjL2FCJ3xvoQRaJ5I= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694053784; a=rsa-sha256; cv=none; b=oGeKd5TVTOB3H+nyU1B9lHwUnK0+ONuP9m8VMZ+YC4oPvbbuor1fPhpeQ+oa/MDF64qsF4 BHoioFLA2rzI/IKbGhj5FIAA+coytRfZjMgqDzCCI/VVY04NqSPqExHbQU7D/JoCq3LD+V Pd5zwyVibT3YDQOCjhrhP0UwJf9n3IE= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=o5w62vS3; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7C4736113A; Thu, 7 Sep 2023 02:29:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E90E7C433D9; Thu, 7 Sep 2023 02:29:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694053783; bh=ey6ldgAd6VTxnRDoPtCtQlr0A3IAnRC6k78ku2lztFc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=o5w62vS3iAkNVuzYgY9bfNL4wHOb5z8v2SB71t6EVqtoa8SA11fQws6liGofafFMo p8YQONgSgi2PrcMcx4kRPKTnnkIXVq+T1F6uLipVw79Q83LbAwU6y0a0xAjmmGBI3a Qy/07A+eOLSlFgEP0sKXQqwPmigbHXrm0JGjzBbAuJbX2SriKrQ8PW+HGJDuIDIalY G+kkyD7yTeSglfm6B5Wt3S064RhYrOztpWqbp1us/4OowA0TWkqW/8E63Ooa6Hxefr 66k8OkJbNqIzn+YiAzcNVQcfgU1rLO034hJIKGrtYOYB0QvlE4wLe6a4gGRCytSnCj Mhm23vrRe1GgQ== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/11] mm/damon/core: fix a comment about damon_set_attrs() call timings Date: Thu, 7 Sep 2023 02:29:26 +0000 Message-Id: <20230907022929.91361-9-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230907022929.91361-1-sj@kernel.org> References: <20230907022929.91361-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: 388C31C0005 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 99rduhg964igw6cf7e71hhb1i79ypmjt X-HE-Tag: 1694053784-188894 X-HE-Meta: U2FsdGVkX1/YkGUMpUTHgoCB7uH+Ajcn4xSSDMZb8ZgOEyxIlswXYj46PUSkSGr+uwdQzXf7qnMRkAxC8WJ9WI0tvoGq1hDM/uS+GiBZ2L2WZAv7Os1Mm6dJ4ECX+lWJRiHMVJpZIHhitBoY0ryHkCVkuETWkqo/yq6xq9puOlfFVSo3z80LIdT2b+EydbOhjWMMBZfRElQihJOFJW1uW6d/ZKuOHmhTjCh3wpvuLELvNGvUlgD7Xv4fzrEsNOeHREOE3+ISatndG8aeD4eHe1ZCrCQ3sd49RiWWjq8GnwRg4fw/5WaTP8m2uffILYXs+++utzYLwrOqLVpoYHUyU7x6N89TrlJCoK4A/6ise5+Ygfb4XGtEW/egq+XqTnyh2EB+Fh5fohHb4NzpKoExgUmChK8AlCQZ6oj44jjBnRWTgv7jEydzthYFZuS1qTSGwVA+Tc1vW+S1FmUTSv3cdmb4iuwxZMP+y09F5NU0FnK4IIvUtqG5sKMHbjG1Slwh1v4NWr7dClGZ7JFZdS4ix2lYvXUFx2qyfhwSnntIg4vpKm3mNvMaV8wPPVgt1zwOx4rSurRhLj63sqaPqn7ZhXHi5ELTTja6uNnvenqbqlyaaQrqKVsmbnIDyHZ38rY/wQho5upR+tSeZrmBzFcspCKfPY0EfVYcmf23WRyEERT2XGw7YJR9bc9owzN30mhOJ23GMSi+lJF+ecrTTuQ74/lqUPzUgIgQ9HrGCjgqmDjmonSq58ZjYN76pOZx6j0HmwGzq9DVmwnA+DIWzY4FLShPkpdgZWYyMXfyOfDptXAGtJGFUekt8g1vkPR0vwPBIxsoXZL4myMLevCCYVc7Zdo9OaSbnmLMORoDfcZjbAlYd+Yme49Du2BsCux5K8nLEVKYoTjFfx81xXMBG3asSjdKpyHmHubamTo/jtxjSEkECqiFHysmgyBkR128s+Nn6fh+EZy2y97Qft4FddJ vA9BBS57 RCQHfr6pqyCeCeNCIDKSFbOI3klXqpvYdW/Ge9zxa64yrOkrTJ6XrE5NTVSGGEo4PnrwVYMjWlaIBv6TMaMVBstf84odZNT99JAPGdYc5p5Nr6D2i0Q5VbR7xTuCatTkXYN4WjdLE9Jsg6MmwxJQTQ61PE+l4oFw8SC0gfvsm4sUDG0KWBhgXL+ysZOweUNhZ7ERrsY7eKKnOwwKNtnRGHt9wYkPRyG+cBamkvM5XAJDiBOn/XI4eutfE05goBUBYsAXRNVFXsnxvVAyxS3dSp/MCpZn2XJw6r+C43vKg1rmEbV6+w23eggWBgr09AIZwZbVdfmKg7/+ryYoJ/wIUqFEzl1j+lqd/EvMW+8s37+lnwoVzhOZJ+SVbYjMYD3Y96Hyq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The comment on damon_set_attrs() says it should not be called while the kdamond is running, but now some DAMON modules like sysfs interface and DAMON_RECLAIM call it from after_aggregation() and/or after_wmarks_check() callbacks for online tuning. Update the comment. Signed-off-by: SeongJae Park --- mm/damon/core.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/mm/damon/core.c b/mm/damon/core.c index 28c7c49882d3..1ce483a3c2b5 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -570,7 +570,11 @@ static void damon_update_monitoring_results(struct damon_ctx *ctx, * @ctx: monitoring context * @attrs: monitoring attributes * - * This function should not be called while the kdamond is running. + * This function should be called while the kdamond is not running, or an + * access check results aggregation is not ongoing (e.g., from + * &struct damon_callback->after_aggregation or + * &struct damon_callback->after_wmarks_check callbacks). + * * Every time interval is in micro-seconds. * * Return: 0 on success, negative error code otherwise. From patchwork Thu Sep 7 02:29:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13376103 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75FD0EE14D3 for ; Thu, 7 Sep 2023 02:30:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3262F28002F; Wed, 6 Sep 2023 22:29:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AB7528002E; Wed, 6 Sep 2023 22:29:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14CA328002F; Wed, 6 Sep 2023 22:29:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id ECBE5280029 for ; Wed, 6 Sep 2023 22:29:46 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id C761E1A0F66 for ; Thu, 7 Sep 2023 02:29:46 +0000 (UTC) X-FDA: 81208220772.08.CACFEFD Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf10.hostedemail.com (Postfix) with ESMTP id 2DB7BC0008 for ; Thu, 7 Sep 2023 02:29:44 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qlP28eTv; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694053785; a=rsa-sha256; cv=none; b=LFzDHAEGPs+mujtFDYVI4zlrPuF/lQ7BXmT6KPuc6ZVQ7MXcdEpGBe/g6OjMmy00kE1ifY QRH1ZoUh1j3ydyhr2u2jZ068L+vThWyTtAb02kKAwcvQWFKbCyxuxMsAx6m5KF91RduuD7 n/MPzFd2rX4dfieKSPVk2JS3EOOESSM= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=qlP28eTv; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694053785; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FqnAu9TiPE+mMxqOi7wi9wxvJKRcL57L5dZRyRQMI4g=; b=VTmn2C7mqJ/+FW+OA9RnjIZJDSwOn4xnjdHFJzy1bzqbvj9U9DQScgWR912FhCvIdR4TNF 4J7cTjT4AKl8Kx9knX32PXUiHCEIcEgjMozh8YCQHtu931cHzbX6Tg+iPAMA41M20CwokS xMoyI6tV9xl/DnfB9C7lR6WEgtoIxTg= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 79B31611E7; Thu, 7 Sep 2023 02:29:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86713C433CB; Thu, 7 Sep 2023 02:29:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694053783; bh=vRYmypXxVu4qyBFRsVgWGOXy10baQDAbK4q5Co5NXh8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qlP28eTvxlZIfTv787ShyqGqsODexay16ibiTx1Diaxx+5FsRbtNpcWuURBIEOMiI MVGKGITV1obC+0nnb1wK5BP+LzyRRcd22VUneG4Do06WAlT3yR5Cd4F5A9REjPyqBs 37dj2ZaxtE7cCscAaXS3ulztigwpy2rxfNIB/MP1lbmzWgDIRBSYzFZ5uX3duR5pRS 34mSNwMpDpPDvZaq1aJb+hbu3YNtVwi4x9LJOwcXDyF89pA615ep4hmc4QbMa62sh/ HR+4gHtb2WSAAsdQ53ZSq8MRmZsVIpt6LNlSWFJHAhzOnHHSDJPv6qce6YRagf/g2j OkLTbEuTqmVSA== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/11] mm/damon/core: add more comments for nr_accesses Date: Thu, 7 Sep 2023 02:29:27 +0000 Message-Id: <20230907022929.91361-10-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230907022929.91361-1-sj@kernel.org> References: <20230907022929.91361-1-sj@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2DB7BC0008 X-Stat-Signature: 49fzwdp6db7czqrx93ttotpn48wgrwir X-HE-Tag: 1694053784-527587 X-HE-Meta: U2FsdGVkX18rdMTGLIoY6GjGDfbm7VahSKHq1LIQcCyrwtt6uTvTot6R/9H5wfqPrHfrm1TAuOMsG2hkYZsvTh6a5NJUI2UPSs5q4kPxLo/fAlHD1x1cDdOXQe0M5X03YDBl8ntVRALwXo8PEjyXQv0rwCS0TrVLE00TM8hdK/YzeqDF7hJNgpY/e4o9F2/+vnHgGRlzbnuXWOwlGZ2euBrkHGQ0GsqmrKF8e6UmzQc75pGcwZAIvfh5tyJaFB/xepYTZZ7X0jajwXu6XP13dCQKyIw8PCUJUHOHoJZlMNCbwYB5puPlS2kxoxrUcjVLTGvCnh1CJwDLfCzRr2nSqOWEg8Mv9SF5vXYAlXfmS94KwngIm9tY7ZJV36xg74HN4xoDr83MEe89O3k3qSp9rntshkTVtCQOiRwGFtQQMFTNDIn9J7tefOkyYDocvapUMIVU5x2Ih6eN3SysuDbr5mB6ZhKP2QHa+ADUMqeHyXX+MWbwMRafZ016t3hHcVyTQfVLzZrJjU0+yZGP12O9oCiZrXBPO4YZ4ECpjBnbDZpyJMSfxT/mgoimYrXay5CWYTVcOtvlJDZX5aUySBCgDA5KTyi7XvG5Ge9BZsS0OmEJp9hgdhQeyc2hMghDqixPZvFmV0DXWCtTrbp8Il4xEJDCihJCaf9oAylgFb4LogEFAfucHSGPk67hooC5KrjhflNuV8LiUR8jyiQghYfLDJfc6xtRJg6LzLvxHYLNLqQWhuuaIN3Jl1xiDQEsDNgZdcn6owY4+ZwBCpscgoXJKS8bxomkEJQZGMu/ku0VDjdeBUCfmCgfG0qNzUU/fB21c0zkQf1EHqdb16ovCOFY6KF4HzfDl0RRim0sb/9FnmroL15rqkCutI/3gLcVmglo3nt2Kp6KTlnNRSXaFr3e2m1mDdlv9e+1OEMfaEq3+cZYDLAhoHG1pUpJOQ+vd7HjDIYS9TH46IfJN22e6ue 3849EJ3y eD/lhV+zzK9ccjPyaVx2rLH39e1f5jTZWT0l+onOgLu1dYu8IizJecAxLtRRkyLsRTOQ+FI7uc9UXyxACa+kOdHMdmH/hg9hWuLjNZatU2ubY5ZgxjEGUcxQwY7LXNj8LoPo+fQyUiP2Mku52DxXQwV00HQSe87+RjfyL3eddUOsQ8/AuQvbtkgbqTjiLNDmAQ+kBuy63zaCg7v6BzRfcZftk8LBAuAFnYJIvq2Ho5scu/+PAL53Lv3S5x8l+gV3o6JbgF8Y0K++4SxAlaJ4GR/265+s/Y2sGTwkvK/s0irWRGq2SFXG+aue1MQN++htpNfBLcUX/WAfsVzbvkwU2mHKPLD47Cjq15nAGos71Em34aBn9TEhmOOWQ7fL8Gngl0/CB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The comment on struct damon_region about nr_accesses field looks not sufficient. Many people actually used to ask what nr_accesses mean. There is more detailed explanation of the mechanism on the comment for struct damon_attrs, but it is also ambiguous, as it doesn't specify the name of the counter for aggregating the access check results. Make those more detailed. Signed-off-by: SeongJae Park --- include/linux/damon.h | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index ae2664d1d5f1..266f92b34dd2 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -43,6 +43,10 @@ struct damon_addr_range { * @list: List head for siblings. * @age: Age of this region. * + * @nr_accesses is reset to zero for every &damon_attrs->aggr_interval and be + * increased for every &damon_attrs->sample_interval if an access to the region + * during the last sampling interval is found. + * * @age is initially zero, increased for each aggregation interval, and reset * to zero again if the access frequency is significantly changed. If two * regions are merged into a new region, both @nr_accesses and @age of the new @@ -472,13 +476,14 @@ struct damon_callback { * regions. * * For each @sample_interval, DAMON checks whether each region is accessed or - * not. It aggregates and keeps the access information (number of accesses to - * each region) for @aggr_interval time. DAMON also checks whether the target - * memory regions need update (e.g., by ``mmap()`` calls from the application, - * in case of virtual memory monitoring) and applies the changes for each - * @ops_update_interval. All time intervals are in micro-seconds. - * Please refer to &struct damon_operations and &struct damon_callback for more - * detail. + * not during the last @sample_interval. If such access is found, DAMON + * aggregates the information by increasing &damon_region->nr_accesses for + * @aggr_interval time. For each @aggr_interval, the count is reset. DAMON + * also checks whether the target memory regions need update (e.g., by + * ``mmap()`` calls from the application, in case of virtual memory monitoring) + * and applies the changes for each @ops_update_interval. All time intervals + * are in micro-seconds. Please refer to &struct damon_operations and &struct + * damon_callback for more detail. */ struct damon_attrs { unsigned long sample_interval; From patchwork Thu Sep 7 02:29:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13376106 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8A65EE14C3 for ; Thu, 7 Sep 2023 02:30:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A347280031; Wed, 6 Sep 2023 22:29:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3273B28002E; Wed, 6 Sep 2023 22:29:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 175C6280031; Wed, 6 Sep 2023 22:29:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 01C2E28002E for ; Wed, 6 Sep 2023 22:29:48 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D112580FE6 for ; Thu, 7 Sep 2023 02:29:48 +0000 (UTC) X-FDA: 81208220856.27.83DD2F7 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf26.hostedemail.com (Postfix) with ESMTP id 26329140005 for ; Thu, 7 Sep 2023 02:29:46 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XawgFLeB; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694053787; a=rsa-sha256; cv=none; b=0kxffUddGxIR+asyWNnc1dCPAZjIn94FG20i99kagI+DIK38ELYDdhrVoj2lk5urNRt35M 2t7/UXKX/JD10kjcTHE6BmTBZAtOX5hyDiTrSsRDhtY0DBS84ypOeHloV/RALrmJc7XQ/u F1bKkRvknDhTjOQ0qn86KiyvNCX4AC8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XawgFLeB; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694053787; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=J2/fk2g6ueN998UEDuqZALTDt1bKp8IG2lCGBYcRTJY=; b=lqQLoylbjQTFG2kzyePIRZoNphL+E98Oqlb1eX5SRleWYjM4V0qny/HwJ89+oaW6FLPeaq UGlJ2jr1K+EK6h5IDSoqDJK60UWklo73yiMgRb+NpWoi9JzopzQnTgddlUravHRwVjd5ip JgBKvLUhYux0eU6aTkKwatxpGJIVPUc= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B20E6B80920; Thu, 7 Sep 2023 02:29:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24ADAC433C8; Thu, 7 Sep 2023 02:29:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694053784; bh=4wgatm5vkHkhu7CH7xqyyNlcb3rmypBu/L3jao8ltp0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XawgFLeBMRtYOs3eZvOrynqaYFsNYcVhLx4gCHHw8pi43JQBD3uHXY0KkhiTqaGT7 mNsMft8lIeEKWffka38pyw/THuXrqBK9lCxF7GSU53urAFxBy2e34GMG46ha2dtpJk A2qUWz0p0c1Q56x5p1kfVqwyGYYN2kW5IlP34dX80TZprJO/+HIeMH2b3NtgDi29EH CsivVUHp0QpYal2v7rLUMXrU+cryg6NOrdV6gUSkozYykti4rRyRVLSSjW8+u8m5H5 /NpzEaSnWhhuGqCXSw2hRbt++8Ez7+7o1gHUHZTiUEG946PnOUZkO8cEQ1zk+23TlQ omATik1sdthtw== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 10/11] mm/damon/core: remove duplicated comment for watermarks-based deactivation Date: Thu, 7 Sep 2023 02:29:28 +0000 Message-Id: <20230907022929.91361-11-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230907022929.91361-1-sj@kernel.org> References: <20230907022929.91361-1-sj@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 26329140005 X-Stat-Signature: ugk1r5josfyurgwg771iujhp1y5zgimy X-HE-Tag: 1694053786-321333 X-HE-Meta: U2FsdGVkX19ewjrZe5YBiTMLHzPLVNylUKf06QyvE708tTHvaoArNhFZI03vFQcIkO2xWK7jdydJfFkVTBMUqE9qeXdfeSHYyYCRqyWkAZh9A12jKIUhqj9up5OiYThgpbJoNVG0gLq38l5rmOn4weoJF6YSMgryFA+j0AvSjrd9z4n0wsSpJdx6gWP/FijBpRTOUinl3alCB7KTOW6oBuuiIKMm22rck0BexfRwmlUZRkGf1rzfTCADiVDNGSozB1IJf9vqYZfNiado2nQBnuA0A8tz4ON5FOupsDPJotWS5mrjwSARW2gVfn52zHLMqLNEyei2NhAhyTKfydkI3pfEe+wLWJFdaRqbrfDeF30E0MiTfgy4S8c58sz7Lkqz0JkGtRUi+KKGAHSNS8hN+WZOItnQgK6cLHBTEHQ4PLLpslZZU/rupjf7YHzFE44k6GLmu63em0CsSW6ilq3ggAgz74vqDUYvbW8PxCtM8B8LNYT0q1c9nyfWcoOOofr/kH6ewsJMiQHax7jcZx7IKolU0W66TPacQTSeFVBRcJY+cF7xzEc7TnSW0GkuAlbXb9OCNbhmCWtuRLGHEH+IKwWPkCSE4q0KqBrwwEGw72gtFZMr8jQvGJ314bRlGqJuMY/NiDMYmXhMku2wR4sDZpG6tb91gsVziVSg9NY0676tmMOwp8BPvwUaOmWnCrmQRg1O+l7t77l8pbr8E/AwBbH/u0Bt+wZ7oZoiH+AcWIxMTCbk0uDDcfRP7vrMakfRzEqoZSM7w0vCEqkOE4SAaReKgJ3xmSsbfbVEIVmBsxWcrk2wNTzJMat//7pehJ1R1W8TPbPFgKOmHC1q0LjNm8yOGdUrmPcjcQD3POf+wFVxsvWrMKVqb0exeMVelywP+cIAAeWjSwrYO1R5DnoNVGD9AH/Pt1zRPlcDz/lacmAZhmj3N5gJTk5BdXcGRunV0pnvsy73daOOdibEp3h TidrQ5kN rPJQ0kLb/VLOiR+ohAj2HLnnwDzbiVVoYwF4HU1Cw2xtpzhueg6sKbDsVZjpsUqqNgS7b+tRi1rhXsPyOfILgr0ACeukxm5ydP4u5NQD0jvfPa0hDvhKacUH9WWCJofT5zkYPFECn7CuzfhYRAN7ZqsQ4JQ3BUJ7t2vCtVDtjhsvGs3fR0Te5Jqk14H2dKuSthfSF2GSwV/7wJQVnHYO9XusYrEGcZXVmJqdjeGsRZX3dUZ7MaeYHCd2/GvbuFlYW0jFqmAzpPaWRtvuVoISPhagP69Nc3/lNuZSo+V7cgj81pliT5Q88T1F2Xvd91hWgYral59eDizXwDJR0VeAUo5jzst+ISF6uSEXVVuqU7W1AmFQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The comment for explaining about watermarks-based monitoring part deactivation is duplicated in two paragraphs. Remove one. Signed-off-by: SeongJae Park --- include/linux/damon.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index 266f92b34dd2..ab3089de1478 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -317,9 +317,6 @@ struct damos_access_pattern { * monitoring context are inactive, DAMON stops monitoring either, and just * repeatedly checks the watermarks. * - * If all schemes that registered to a &struct damon_ctx are inactive, DAMON - * stops monitoring and just repeatedly checks the watermarks. - * * Before applying the &action to a memory region, &struct damon_operations * implementation could check pages of the region and skip &action to respect * &filters From patchwork Thu Sep 7 02:29:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13376105 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 384DEEE14C3 for ; Thu, 7 Sep 2023 02:30:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 14ECA280030; Wed, 6 Sep 2023 22:29:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DC2028002E; Wed, 6 Sep 2023 22:29:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE064280030; Wed, 6 Sep 2023 22:29:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CE57F28002E for ; Wed, 6 Sep 2023 22:29:47 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A8D14A0FB5 for ; Thu, 7 Sep 2023 02:29:47 +0000 (UTC) X-FDA: 81208220814.03.87AD9F9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 170751C0005 for ; Thu, 7 Sep 2023 02:29:45 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kW9lSKJU; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694053786; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ONba5mhYMpPWfm7LJGm357LmZx9M+CqpCi7z1MYxLiw=; b=OdFsfMFUWBFGmTTYO5UFL+0cPkNZDy1/ML/skDYOdv9wIyrDEMfSPSNUP1shNAZePZSLqo YK+xfUhZRwkGFfnLAHyGm7UhVB6iJodv+E52IOTWxeANIVDvd039JA6uj93thmKd0ozk5p zk0lHf88fiIrxupG0lG+hV74IRrpSdI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694053786; a=rsa-sha256; cv=none; b=km/1VIRSdpVqdomZvsRZYBj81owTGhemLXMrQFhUUoETRdyW8N3xTsrY8+qizqmzuWz9x4 bLEwV/qp7ZGghN+oDUgd9J5mfSMm1MYw1N0VpXU3vRJgjmUAmN3YAsPmOnj5IkGL4jZ9r4 HNyF9R9lM/k1KBETnJrmZ+AICjPTb/w= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=kW9lSKJU; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CFC4B611FE; Thu, 7 Sep 2023 02:29:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5C04C433C9; Thu, 7 Sep 2023 02:29:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1694053785; bh=BKOeFu7T8a2LEb2S23swx71FouyPaLhdxkSplv88jDE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kW9lSKJUK8+ODGx8+zLAuwY4U8iF1ZuvoO7A+S27Q/xz6o4XPq68SwXNgzmyYnuEj 7WyyAtobo0uu9GfdSX6ATJ6HmrbwpUrlbRY76oIle3a7639PBD8FsDroWOedtlhvBJ BprdBWHVEqzGCzw1lDqWeyDNOvDtW4K3fbPjftNElyFGevEYFcZI9LzRv05kW1qN4M 6PYPngTZqKcq7sHlV9uEdLmA9k+RYmpT5Y6vpkCEZmF6/KzzVksprDIJzoQbnn7lf6 8EYD5qEPNvxsMDKaO3Nq5KDn2d3yN6qiyuRZxCJf3DJt5CLXz0xiLjdo+Z3cOkkHoo eI3cefVYuwqfg== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Steven Rostedt , damon@lists.linux.dev, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 11/11] mm/damon/core: remove 'struct target *' parameter from damon_aggregated tracepoint Date: Thu, 7 Sep 2023 02:29:29 +0000 Message-Id: <20230907022929.91361-12-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230907022929.91361-1-sj@kernel.org> References: <20230907022929.91361-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: 170751C0005 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: tybo1pgp8zpftoacb3acunx37mqo6jeu X-HE-Tag: 1694053785-316922 X-HE-Meta: U2FsdGVkX1+Sm5XaQp/P049W/qYImRwgYjDro36gOOfXnigbNca8Hbg4OOsFHfPyWn09P9G1Q+Of7GegpsGUfz6kcdkG2COB1BjxwTgXRDU1EXgfgVMSepFfWrQj2G9wBP8jp1QeSPvgE25lcXDEgs58YODR0nhwEYdOMKkd2qEjlY4iB881jzBYpkKJEe7SAYNVl6kLFdpL5QN/3gQHYS5YVuaatmV17//S+hCAlg5JK2CSvTnmm0hQ4N8QCm10kiDLwjkkNxOX21c+wX0sMwYHcsQv76PmBvXTTkpdbc+uMki3//+3aqdxHkSrgKdFxMm9MuDRNYvQeeqxuNbIv0Jlfzt/HfpMkAkr9JdRyR0GiBlRDUa6nWrkVOOj5gUJyulAeXVgQwQLw3d7gQI6YAobf5p+uZqUCv7BAYDjOHBjyJEdCzNpf+0fzMLagYmG/G9BJ5VpofwdT5nfJOvTIgWGeCDrSd1GsEGUIlrKpzo/l9rci8BO8Z6jFO4V5FILHEtnXqkiUly/5n1qjbyClNiVe9jZVl91sBgY99qmxhPCbGU5Nbs3z9gH+FXazqqHOYYwKVq/PemNmh6HJv95a3HtEo6hWOJTgCZ0ht5FlRyqirmbtgv73wVtqnFd4g6XT6cWa78PP5eVkF45w9dJcZ5ya5LdMiawMSVftmMJhuYr9D95ynbxFV+uxk8CkOjxVGQ/QcaF+vUqIQ2E1aDKD3+HsyaHxeqSmIG8OaGYUEzrPEKWdT7AlFJzBaRLW0KBG9CMDZWoOX5k649DItdRaD0QWXf+wmDqQptKdGb25bVYkHMJ87K4XqFBkN/+tiHC2EO5Rdt28416i+93jj8I+0/I3lze3ZmWXPyJCpmdtkLAvBxDhkbWW2H3jBoi/TJnD2bboZfJffYFz955UV0ZUmL8CtW2Q6Uo2kqouv5uDuVBX0UMudoUVWz0muxciu9lIpSNTsh2h4SVnXGzD1P I9QCvq3J It3JbYF7cfEOpP9zh6RswspmULV3RdGjSt3DRC0xCeOja7kkdlPBegBJpzUT6lno744G0OLfMyo1v6+SeGYQTFAxN/M3CyHb8T5URGAD/VN1OIRGrEiCpi/Tyh1rYPRBk3F2IQFH8rTMU132anpaWMG1dogh86o2z696MgsouVYHTdQbPOhNVBYYgNcvwqKiNUs2NCPDLptc0zBncv2LSMePO5GcQVlkL0w71LSz1C+KMUgUzcHLen8+h/b7+6BzMq9qB02PdKTjFrvi02nRNY2AsX0E+IyDLga8cFLRrhpg6wL1i7fpCpuRPGdEWxRZ1yVOARnWmkAGskh8gMZbz6eoKTpm3CS4CNQSTmeA//C2c9ZIE8fIzURZoP/jUcZawSnhD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: damon_aggregateed tracepoint is receiving 'struct target *', but doesn't use it. Remove it from the prototype. Signed-off-by: SeongJae Park --- include/trace/events/damon.h | 6 +++--- mm/damon/core.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/trace/events/damon.h b/include/trace/events/damon.h index c79f1d4c39af..0b8d13bde17a 100644 --- a/include/trace/events/damon.h +++ b/include/trace/events/damon.h @@ -11,10 +11,10 @@ TRACE_EVENT(damon_aggregated, - TP_PROTO(struct damon_target *t, unsigned int target_id, - struct damon_region *r, unsigned int nr_regions), + TP_PROTO(unsigned int target_id, struct damon_region *r, + unsigned int nr_regions), - TP_ARGS(t, target_id, r, nr_regions), + TP_ARGS(target_id, r, nr_regions), TP_STRUCT__entry( __field(unsigned long, target_id) diff --git a/mm/damon/core.c b/mm/damon/core.c index 1ce483a3c2b5..b895f70acb2d 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -805,7 +805,7 @@ static void kdamond_reset_aggregated(struct damon_ctx *c) struct damon_region *r; damon_for_each_region(r, t) { - trace_damon_aggregated(t, ti, r, damon_nr_regions(t)); + trace_damon_aggregated(ti, r, damon_nr_regions(t)); r->last_nr_accesses = r->nr_accesses; r->nr_accesses = 0; }