From patchwork Tue Sep 12 13:27:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Fitzgerald X-Patchwork-Id: 13381675 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15EB0CA0EC3 for ; Tue, 12 Sep 2023 13:29:10 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2323B950; Tue, 12 Sep 2023 15:28:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2323B950 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1694525348; bh=KioXVN+ocHFfSXNGCpGkkRbazKMRGOswYo7EQxS4iz4=; h=From:To:CC:Subject:Date:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=Ohpw6jjAORmdcjX7vmYmctCAYLrsxyTRTJ2dBt7HESbRW3YAqih+pGdaKX/sLjjyQ He7HJ7vOqJqfS6RlwiiadNctI6sUPsy7hye/JFvXjL7R7s0Afum5/0reSdN6OztUrU /nFx3zD6lTN5fFind/GBZiZirEsPGU7mMgk4UrI8= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 275D9F80549; Tue, 12 Sep 2023 15:28:17 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 013B3F80425; Tue, 12 Sep 2023 15:28:16 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 10131F80425; Tue, 12 Sep 2023 15:27:58 +0200 (CEST) Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id ADF7AF8007C for ; Tue, 12 Sep 2023 15:27:44 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz ADF7AF8007C Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=cirrus.com header.i=@cirrus.com header.a=rsa-sha256 header.s=PODMain02222019 header.b=E4VZDDHN Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.17.1.22/8.17.1.22) with ESMTP id 38CARhwA022397; Tue, 12 Sep 2023 08:27:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h= from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding:content-type; s=PODMain02222019; bh=p /qu/HO+QWXMZClGw2V6UqRARF88uGiEQkPRhZezuIw=; b=E4VZDDHNOq9yFT0BQ IKSGrO6SseUkOvvIZZJkGdrPcNvw79Y7DcMlOueJ0dWq85a2Xp41scQjLW+RqelQ zDmwZOGQGdwRXfW3SCh4zpBT3OAaQmbmUwPl3mXhy5hW3vxLX2wlEhpr6JF5ST1r WkGgyh+Cncjfr731MbVOCcNkqd9uOCneZ2234m34fJe+j5FwrnYnBNySFx68nUto 7ma/vzYbEw5JnQk5+0cOiZbFuM8R/+HqC5NWESp1BceVmrt/vD6A8iXq8P+dHtnB Wj8zFcn/UJRZc74l5ArGqZv32YcIEJFULknhRV9qWD6ogn30uqx/jlWGSMNxV7Da wpSrQ== Received: from ediex01.ad.cirrus.com ([84.19.233.68]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 3t0p3xkm7r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 12 Sep 2023 08:27:41 -0500 (CDT) Received: from ediex02.ad.cirrus.com (198.61.84.81) by ediex01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.37; Tue, 12 Sep 2023 14:27:39 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by anon-ediex02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server id 15.2.1118.37 via Frontend Transport; Tue, 12 Sep 2023 14:27:39 +0100 Received: from edi-sw-dsktp-006.ad.cirrus.com (edi-sw-dsktp-006.ad.cirrus.com [198.90.251.125]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 1EE6C2A1; Tue, 12 Sep 2023 13:27:39 +0000 (UTC) From: Richard Fitzgerald To: CC: , , , Richard Fitzgerald Subject: [PATCH] ALSA: hda: cs35l56: Disable low-power hibernation mode Date: Tue, 12 Sep 2023 14:27:39 +0100 Message-ID: <20230912132739.3478441-1-rf@opensource.cirrus.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: ibH2zfBop7k4z-d0i_r4D_ZFe2-7TJA2 X-Proofpoint-GUID: ibH2zfBop7k4z-d0i_r4D_ZFe2-7TJA2 X-Proofpoint-Spam-Reason: safe Message-ID-Hash: 7G6TNLFHKL6PDTJHDUXFHKUG25HHAD7C X-Message-ID-Hash: 7G6TNLFHKL6PDTJHDUXFHKUG25HHAD7C X-MailFrom: prvs=4619193f72=rf@opensource.cirrus.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Do not allow the CS35L56 to be put into its lowest power "hibernation" mode. This only affects I2C because "hibernation" is already disabled on SPI. Recent firmwares need a different wake-up sequence. Until that sequence has been specified, the chip "hibernation" mode must be disabled otherwise it can intermittently fail to wake. Signed-off-by: Richard Fitzgerald --- sound/pci/hda/cs35l56_hda_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/pci/hda/cs35l56_hda_i2c.c b/sound/pci/hda/cs35l56_hda_i2c.c index 83e4acdd89ac..757a4d193e0f 100644 --- a/sound/pci/hda/cs35l56_hda_i2c.c +++ b/sound/pci/hda/cs35l56_hda_i2c.c @@ -21,7 +21,6 @@ static int cs35l56_hda_i2c_probe(struct i2c_client *clt) return -ENOMEM; cs35l56->base.dev = &clt->dev; - cs35l56->base.can_hibernate = true; cs35l56->base.regmap = devm_regmap_init_i2c(clt, &cs35l56_regmap_i2c); if (IS_ERR(cs35l56->base.regmap)) { ret = PTR_ERR(cs35l56->base.regmap);