From patchwork Sun Sep 17 16:18:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rahul Rameshbabu X-Patchwork-Id: 13388612 X-Patchwork-Delegate: jikos@jikos.cz Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C014CD37B4 for ; Sun, 17 Sep 2023 16:20:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230010AbjIQQT0 (ORCPT ); Sun, 17 Sep 2023 12:19:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229957AbjIQQS7 (ORCPT ); Sun, 17 Sep 2023 12:18:59 -0400 Received: from mail-0301.mail-europe.com (mail-0301.mail-europe.com [188.165.51.139]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A8E9118 for ; Sun, 17 Sep 2023 09:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1694967530; x=1695226730; bh=RUQIbh4mykPDFpwSsOl8cABgN/OT0C59vVfLwOnYqHc=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=qAQ9RbaAgK4P2I7BncTsJmiFc+wCZdTbNabd3QCZUZnxcItTyMTFnbO5W2h+sE2x/ ok7Rmmcbsb/sdRUh6YcEUAv0GqE1p1HdsKmjP+rLZwXMOkCG7GLCg5rTo/Ye6wKtva sZ9kBuk3wNOiVT9BD+A8UC6hDMVOvNHIxS7Qd/x2NDK2eIDclAPQ3DS0NPf88Yw6Vg x64srzhY5hy8baNvQMPeYX4QNlrng+4kOhFm1MAtBTqiNLOt7iYPa7KoZTydz+Jeur uTXpuDM1OtKugU6xSsUUh/Fw5iDx4Y1Spv/4zeq8+emwdb/Fka/NH7NCC/mcqkU11g 9TmsCaJDtr5qQ== Date: Sun, 17 Sep 2023 16:18:43 +0000 To: Jiri Kosina , Benjamin Tissoires , Henrik Rydberg From: Rahul Rameshbabu Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Rahul Rameshbabu , Rain Subject: [PATCH] HID: multitouch: Add required quirk for Synaptics 0xcd7e device Message-ID: <20230917161802.39716-1-sergeantsagara@protonmail.com> Feedback-ID: 26003777:user:proton MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Register the Synaptics device as a special multitouch device with certain quirks that may improve usability of the touchpad device. Reported-by: Rain Closes: https://lore.kernel.org/linux-input/2bbb8e1d-1793-4df1-810f-cb0137341ff4@app.fastmail.com/ Signed-off-by: Rahul Rameshbabu --- Notes: Theory: I think the Synaptics device in the related email to the linux-input mailing list requires certain quirks like MT_QUIRK_HOVERING to correctly reconfigure the distance configuration for multitouch events. This might explain why light touches were not registered originally when MT_CLS_DEFAULT was used by default for the device. Would like to have this patch tested before being merged. A Tested-by: git trailer can then be appended. drivers/hid/hid-multitouch.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 521b2ffb4244..8db4ae05febc 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c @@ -2144,6 +2144,10 @@ static const struct hid_device_id mt_devices[] = { USB_DEVICE_ID_MTP_STM)}, /* Synaptics devices */ + { .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT, + HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8, + USB_VENDOR_ID_SYNAPTICS, 0xcd7e) }, + { .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT, HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8, USB_VENDOR_ID_SYNAPTICS, 0xce08) },