From patchwork Tue Sep 19 19:49:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever X-Patchwork-Id: 13391828 X-Patchwork-Delegate: kuba@kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79C9A31A9F; Tue, 19 Sep 2023 19:49:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4422C433C7; Tue, 19 Sep 2023 19:49:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695152987; bh=/qzbcYyPGtl5OcnAwTZe644svoNDhqecK3zgkYe0zrA=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=gN42LAy71RMYseYGOmloVbkJw8F5zZroy2JgteV1tEulnPxXzaXYPlUP58DLeTtAW dqL6S2QTbymdABTquByMalf7Rm4R5lKKoB98xk9knkJ+9+jUUYQf5hz6470qRuIwfq mk4kCt0A5Rg4TETQRkYPQnxwQkzpG6+XVUpWQr7TtoMYGCUd0C4eEqmYOnn8zscVJs Dy6UzaP2sLjrrnolh6SOi3L0aDEr4vg3xitO+zNx8dpUMSmg9Xac+xgi0lJBjzNEZH 2upZOnZ3FBr0lyVcjXKI7WQWOj+KvBc9J+k+JNKNYIBwhWmlbtTTfbxNiGL3iwoxLz JDLSqNP+aUutQ== Subject: [PATCH v1 1/2] handshake: Fix sign of socket file descriptor fields From: Chuck Lever To: netdev@vger.kernel.org, kernel-tls-handshake@lists.linux.dev Cc: Chuck Lever Date: Tue, 19 Sep 2023 15:49:36 -0400 Message-ID: <169515296663.5349.3635488813931843415.stgit@oracle-102.nfsv4bat.org> In-Reply-To: <169515283988.5349.4586265020008671093.stgit@oracle-102.nfsv4bat.org> References: <169515283988.5349.4586265020008671093.stgit@oracle-102.nfsv4bat.org> User-Agent: StGit/1.5 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Chuck Lever Socket file descriptors are signed integers. Use nla_get/put_s32 for those to avoid implicit signed conversion in the netlink protocol. Signed-off-by: Chuck Lever --- Documentation/netlink/specs/handshake.yaml | 4 ++-- net/handshake/genl.c | 2 +- net/handshake/netlink.c | 2 +- net/handshake/tlshd.c | 2 +- tools/net/ynl/generated/handshake-user.h | 6 +++--- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/Documentation/netlink/specs/handshake.yaml b/Documentation/netlink/specs/handshake.yaml index 6d89e30f5fd5..a49b46b80e16 100644 --- a/Documentation/netlink/specs/handshake.yaml +++ b/Documentation/netlink/specs/handshake.yaml @@ -43,7 +43,7 @@ attribute-sets: attributes: - name: sockfd - type: u32 + type: s32 - name: handler-class type: u32 @@ -79,7 +79,7 @@ attribute-sets: type: u32 - name: sockfd - type: u32 + type: s32 - name: remote-auth type: u32 diff --git a/net/handshake/genl.c b/net/handshake/genl.c index 233be5cbfec9..f55d14d7b726 100644 --- a/net/handshake/genl.c +++ b/net/handshake/genl.c @@ -18,7 +18,7 @@ static const struct nla_policy handshake_accept_nl_policy[HANDSHAKE_A_ACCEPT_HAN /* HANDSHAKE_CMD_DONE - do */ static const struct nla_policy handshake_done_nl_policy[HANDSHAKE_A_DONE_REMOTE_AUTH + 1] = { [HANDSHAKE_A_DONE_STATUS] = { .type = NLA_U32, }, - [HANDSHAKE_A_DONE_SOCKFD] = { .type = NLA_U32, }, + [HANDSHAKE_A_DONE_SOCKFD] = { .type = NLA_S32, }, [HANDSHAKE_A_DONE_REMOTE_AUTH] = { .type = NLA_U32, }, }; diff --git a/net/handshake/netlink.c b/net/handshake/netlink.c index 1086653e1fad..8bea091b52be 100644 --- a/net/handshake/netlink.c +++ b/net/handshake/netlink.c @@ -163,7 +163,7 @@ int handshake_nl_done_doit(struct sk_buff *skb, struct genl_info *info) if (GENL_REQ_ATTR_CHECK(info, HANDSHAKE_A_DONE_SOCKFD)) return -EINVAL; - fd = nla_get_u32(info->attrs[HANDSHAKE_A_DONE_SOCKFD]); + fd = nla_get_s32(info->attrs[HANDSHAKE_A_DONE_SOCKFD]); err = 0; sock = sockfd_lookup(fd, &err); diff --git a/net/handshake/tlshd.c b/net/handshake/tlshd.c index b735f5cced2f..83595e6ae0ee 100644 --- a/net/handshake/tlshd.c +++ b/net/handshake/tlshd.c @@ -210,7 +210,7 @@ static int tls_handshake_accept(struct handshake_req *req, goto out_cancel; ret = -EMSGSIZE; - ret = nla_put_u32(msg, HANDSHAKE_A_ACCEPT_SOCKFD, fd); + ret = nla_put_s32(msg, HANDSHAKE_A_ACCEPT_SOCKFD, fd); if (ret < 0) goto out_cancel; ret = nla_put_u32(msg, HANDSHAKE_A_ACCEPT_MESSAGE_TYPE, treq->th_type); diff --git a/tools/net/ynl/generated/handshake-user.h b/tools/net/ynl/generated/handshake-user.h index 47646bb91cea..f8e481fa9e09 100644 --- a/tools/net/ynl/generated/handshake-user.h +++ b/tools/net/ynl/generated/handshake-user.h @@ -65,7 +65,7 @@ struct handshake_accept_rsp { __u32 peername_len; } _present; - __u32 sockfd; + __s32 sockfd; enum handshake_msg_type message_type; __u32 timeout; enum handshake_auth auth_mode; @@ -104,7 +104,7 @@ struct handshake_done_req { } _present; __u32 status; - __u32 sockfd; + __s32 sockfd; unsigned int n_remote_auth; __u32 *remote_auth; }; @@ -122,7 +122,7 @@ handshake_done_req_set_status(struct handshake_done_req *req, __u32 status) req->status = status; } static inline void -handshake_done_req_set_sockfd(struct handshake_done_req *req, __u32 sockfd) +handshake_done_req_set_sockfd(struct handshake_done_req *req, __s32 sockfd) { req->_present.sockfd = 1; req->sockfd = sockfd; From patchwork Tue Sep 19 19:50:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuck Lever X-Patchwork-Id: 13391829 X-Patchwork-Delegate: kuba@kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BA6028DB9; Tue, 19 Sep 2023 19:50:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32D3DC433C8; Tue, 19 Sep 2023 19:50:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695153014; bh=Lcj9eNyGpLTTf7vSIn1C/bOzZVEKBLrcr8Lf+whvyOc=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=uCWuHDwYg6YcgKm6Z8KzofY9uepRJ8/EvTYpNfhbbbPqDm3JJa/tz+q7poZpyM5ut CzpDx2JKPsdJGoiX+LtHJHyMhRacWtCXmwDbg+UgEmbAYTcrLA+43CAZdUW7nSqftV axkfJhEVPuXwiCmnYakKEx62Ff1ukHOYrN4U7MJ54CuyeDK3Dco1qkM0sB35LW4uyj q1FJILJtgbvhyqqmYRxQt4cxTbifJkz9h42iG4G8Yhkp2fdQWKPLkGAExuU/JTcAJu S5T4zTuwf7M+DFIgrNbOMtSnPrkWeYbs32NcWkYDqvYg5JER/QoCKEaobn1UtLeXmP 5CYyLeY/rXuNg== Subject: [PATCH v1 2/2] handshake: Fix sign of key_serial_t fields From: Chuck Lever To: netdev@vger.kernel.org, kernel-tls-handshake@lists.linux.dev Cc: Chuck Lever Date: Tue, 19 Sep 2023 15:50:03 -0400 Message-ID: <169515299313.5349.16234521174047472380.stgit@oracle-102.nfsv4bat.org> In-Reply-To: <169515283988.5349.4586265020008671093.stgit@oracle-102.nfsv4bat.org> References: <169515283988.5349.4586265020008671093.stgit@oracle-102.nfsv4bat.org> User-Agent: StGit/1.5 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org From: Chuck Lever key_serial_t fields are signed integers. Use nla_get/put_s32 for those to avoid implicit signed conversion in the netlink protocol. Signed-off-by: Chuck Lever --- Documentation/netlink/specs/handshake.yaml | 4 ++-- net/handshake/tlshd.c | 4 ++-- tools/net/ynl/generated/handshake-user.h | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Documentation/netlink/specs/handshake.yaml b/Documentation/netlink/specs/handshake.yaml index a49b46b80e16..b934cc513e3d 100644 --- a/Documentation/netlink/specs/handshake.yaml +++ b/Documentation/netlink/specs/handshake.yaml @@ -34,10 +34,10 @@ attribute-sets: attributes: - name: cert - type: u32 + type: s32 - name: privkey - type: u32 + type: s32 - name: accept attributes: diff --git a/net/handshake/tlshd.c b/net/handshake/tlshd.c index 83595e6ae0ee..f018b931784c 100644 --- a/net/handshake/tlshd.c +++ b/net/handshake/tlshd.c @@ -169,9 +169,9 @@ static int tls_handshake_put_certificate(struct sk_buff *msg, if (!entry_attr) return -EMSGSIZE; - if (nla_put_u32(msg, HANDSHAKE_A_X509_CERT, + if (nla_put_s32(msg, HANDSHAKE_A_X509_CERT, treq->th_certificate) || - nla_put_u32(msg, HANDSHAKE_A_X509_PRIVKEY, + nla_put_s32(msg, HANDSHAKE_A_X509_PRIVKEY, treq->th_privkey)) { nla_nest_cancel(msg, entry_attr); return -EMSGSIZE; diff --git a/tools/net/ynl/generated/handshake-user.h b/tools/net/ynl/generated/handshake-user.h index f8e481fa9e09..2b34acc608de 100644 --- a/tools/net/ynl/generated/handshake-user.h +++ b/tools/net/ynl/generated/handshake-user.h @@ -28,8 +28,8 @@ struct handshake_x509 { __u32 privkey:1; } _present; - __u32 cert; - __u32 privkey; + __s32 cert; + __s32 privkey; }; /* ============== HANDSHAKE_CMD_ACCEPT ============== */