From patchwork Mon Sep 25 15:45:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lad, Prabhakar" X-Patchwork-Id: 13398048 X-Patchwork-Delegate: geert@linux-m68k.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F35BCE7A8C for ; Mon, 25 Sep 2023 15:46:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231226AbjIYPqN (ORCPT ); Mon, 25 Sep 2023 11:46:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230417AbjIYPqM (ORCPT ); Mon, 25 Sep 2023 11:46:12 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FE12B6; Mon, 25 Sep 2023 08:46:06 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-4053c6f0db8so57725925e9.3; Mon, 25 Sep 2023 08:46:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695656764; x=1696261564; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=9/CuCsB7lG3PrLf1A3sCZl+ySqyxlyn/r1ko2GPt+iQ=; b=UQ3GGGZ8J4zyR2Tyntaqv/clPTx6NJQ7+nM/rJ0+1n2B4qv8f1uLzZyQzdPYcOH/Ro ykRlAn3kkYYqnGvISSYdJvn07/N0LNawnynVMUN/DB1aSpjVnwgQWpEZS4v8EuTRKpSv 1emRT8edQkSkDXlWemNnm3jtdm53A4WEUM4oq4xoUv9y2WCBzjtEcbFvZYr9VTEKAasK ACGqVG0Hf0cRDUwpUbTk8K3y+SSadqOVKnUo1vq5BIA+TzAaqHuiAeV86PmLqLKoFN5D eodCcIRw5w4gXGDkaeCmpfCbjcVkJIsmbIaxa+BUaRRhoHDekFy2md4BMXr9oUgmsJqO pTpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695656764; x=1696261564; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9/CuCsB7lG3PrLf1A3sCZl+ySqyxlyn/r1ko2GPt+iQ=; b=e0ZTiP3oAaVfymM700uBWMR8gByVW3k2wqlINWuQF28uphUtA7E05ckHsXSg3mr5Jz Cz3GAjsjEZ3fNjCuf5V2PNAYDZBl+PW2leR7ajh8HAj35quWtHeinnsfS2xElQg6PS6d Wue4tzs0Eg/42az+MlH1B55KmcxA0ge4wrniFZs7I31SyQI1JNPFfBpWc80neTTvNeQL svc5ZxCYEVhVjRayTyP/SRzUI+3xfcRa+6GAFdSamfgYm6D2VO1qh+KMzoIxdG7kkz4j Onkrqxsko6bChXbdayEOL4N3/HWOaD9PMAF612in7CV86YIr4z1sP5/KhBTwscOk583V TzqA== X-Gm-Message-State: AOJu0Yxlyeh9eC1ebm/sJomAS5smuLgL19pec3eHqVbjVpLMt8j9qk4I Q/dIXnXYVhYSHV61KneVdjE= X-Google-Smtp-Source: AGHT+IEqH8vnp7oGDLXNvXEzzA8KHjMo2VSGDWnuhLGbauwCA13b7XYuMFX5nIb7A+/w6QlViZl4jQ== X-Received: by 2002:a7b:ce92:0:b0:405:3f19:fc49 with SMTP id q18-20020a7bce92000000b004053f19fc49mr5972338wmj.34.1695656764282; Mon, 25 Sep 2023 08:46:04 -0700 (PDT) Received: from prasmi.home ([2a00:23c8:2501:c701:47ed:1dba:e442:ccf2]) by smtp.gmail.com with ESMTPSA id b1-20020a5d4d81000000b003140f47224csm12097377wru.15.2023.09.25.08.46.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 08:46:03 -0700 (PDT) From: Prabhakar X-Google-Original-From: Prabhakar To: Geert Uytterhoeven , Linus Walleij , linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Claudiu Beznea , Lad Prabhakar Subject: [PATCH v3] pinctrl: renesas: pinctrl-rzg2l: Add validation of GPIO pin in rzg2l_gpio_request() Date: Mon, 25 Sep 2023 16:45:48 +0100 Message-Id: <20230925154548.27048-1-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org From: Lad Prabhakar Validate the GPIO pin request in rzg2l_gpio_request() callback using rzg2l_validate_gpio_pin() function. This stops any accidental usage of GPIO pins which are not supported by the SoCs. Signed-off-by: Lad Prabhakar Reviewed-by: Claudiu Beznea Tested-by: Claudiu Beznea Reviewed-by: Geert Uytterhoeven --- v2->v3 * Updated pin_data variable to be u32 instead of u64. v1->v2 * Maintained reverse christmas tree order. * Included RB/TB tags from Claudiu. --- drivers/pinctrl/renesas/pinctrl-rzg2l.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c index 37cdfe4b04f9..94984966084d 100644 --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c @@ -795,12 +795,18 @@ static const struct pinconf_ops rzg2l_pinctrl_confops = { static int rzg2l_gpio_request(struct gpio_chip *chip, unsigned int offset) { struct rzg2l_pinctrl *pctrl = gpiochip_get_data(chip); + const struct pinctrl_pin_desc *pin = &pctrl->desc.pins[offset]; u32 port = RZG2L_PIN_ID_TO_PORT(offset); u8 bit = RZG2L_PIN_ID_TO_PIN(offset); + u32 *pin_data = pin->drv_data; unsigned long flags; u8 reg8; int ret; + ret = rzg2l_validate_gpio_pin(pctrl, *pin_data, port, bit); + if (ret) + return ret; + ret = pinctrl_gpio_request(chip->base + offset); if (ret) return ret;