From patchwork Mon Sep 25 22:05:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring (Arm)" X-Patchwork-Id: 13398509 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC8FCCE79A5 for ; Mon, 25 Sep 2023 22:05:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=KI61E9k5fYbVhjiaFYzmk5yzdGjrQ/xrT6ZO/5mcveY=; b=Cw8YLiTDvwHCCi ua609raYYr62ItO+QlzrXkKLGb0Xo3fgJYq7SzsoLf8Kvr+FefvptcGOtSHgIEZ6NiJmQONeHC9Uu hyPkOIcEdoDSKgm5YQgLTkCe3UlfOlezXct3KgMCV2YhTLBbYoz0c23K05zcWQB4pnIzMHkLdyUN2 6OAbu7jmGt73JYMjlTAVksm3tK5URscnC8LbJdkelaOTQKaSUYbbejkxi9QRQ4YTdei/RXLP98gTA +Hj+8NGIJrpUv37K7Fnp9UL7i9mkqGu1H4NkhVyjAyaPQ6aOfWZ606vX6i982fU38sSvEDuMYCRko H1HV6cS8q5b8dRT90t/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkths-00F6wZ-0S; Mon, 25 Sep 2023 22:05:32 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkthp-00F6vY-1T for linux-arm-kernel@lists.infradead.org; Mon, 25 Sep 2023 22:05:30 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id C11DCB80D42; Mon, 25 Sep 2023 22:05:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5F298C433C8; Mon, 25 Sep 2023 22:05:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695679524; bh=H4jPOTCta7deecGCFZSg91gHO4eF5tZipTzNxDka1fc=; h=From:To:Cc:Subject:Date:From; b=YsiWcjhPsQdx8BhkOak0BQnIP6/PyKjreGSE1FoJowCn7x4tkGxL2IJWJyN3ePum1 zV9eMnG9xI95nOvPD/AoP3K1bSM+v7jO27cVG0ORvNdYcXiFGRu4GQ98JlBe/3woRl gov+dtq00vnipriX/C4L9TPpr3hVZvNvxc9u/YuVWz+9WnAsfkUahXTJckCrs+ISmI S/1dsZHwd+GjRPHm+YVM9wi3s5a4J/uQSkIo1SVavDbW+GXEfLtpM23hiQ/MSEg7dn U2KXurs33xuWywDZ2mi25KX8oMN8Hs6CbCeWocgqmsJxCDMd8FryfwjR2Dm5X/vd+g nYyKFr3JYWv1w== Received: (nullmailer pid 2026838 invoked by uid 1000); Mon, 25 Sep 2023 22:05:20 -0000 From: Rob Herring To: Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Krzysztof Kozlowski , Conor Dooley Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] dt-bindings: arm,coresight-cti: Drop type for 'cpu' property Date: Mon, 25 Sep 2023 17:05:05 -0500 Message-Id: <20230925220511.2026514-1-robh@kernel.org> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_150529_637367_04970F62 X-CRM114-Status: GOOD ( 10.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org 'cpu' has been added as a single phandle type to dtschema, so drop the type here. Signed-off-by: Rob Herring Reviewed-by: Mike Leach Acked-by: Conor Dooley --- Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml index 6216cfb0a188..b9bdfc8969cd 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml @@ -92,7 +92,6 @@ properties: maxItems: 1 cpu: - $ref: /schemas/types.yaml#/definitions/phandle description: Handle to cpu this device is associated with. This must appear in the base cti node if compatible string arm,coresight-cti-v8-arch is used, From patchwork Mon Sep 25 22:05:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring (Arm)" X-Patchwork-Id: 13398510 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 383A3CE79A5 for ; Mon, 25 Sep 2023 22:06:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LrAAUVSWTgXJfrvoJCnXL0Z9C2wsal6EKqGOP5iqwhI=; b=te2aFW3F7et3Fj g4fcmYl2TJYzKvAQ/ngkFYx82hZD5ytUQ567r1HnLz0ki2HordGIkkE1qR5Cz4hXit7cJgoqCdDOK Yded1I5F7TzSG6Ub/e4keboxD9dp0m5/1+7wEiUbxaJ8ZCyFKS5dMpd/yewlKltAdIbOqev5xorQw pza+v013K05f5rsMHyjrAb7hQ2uqdvqhVnmWuZcyrC090QbPIWB49+M3LzMRcsUiRlXFDbVXhzhws gYwMu8StwOnVz8x5WX+l7etK95c0FPz0IAMyl4C/nqPeEbU+TzJtGZFjnGsTD4hhXw8xH6gjQ3mGg rth1A/6wMNKrFvvhcKvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qkthy-00F6yG-2g; Mon, 25 Sep 2023 22:05:38 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qkthv-00F6x4-36 for linux-arm-kernel@lists.infradead.org; Mon, 25 Sep 2023 22:05:37 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 6A616CE1162; Mon, 25 Sep 2023 22:05:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A5D5C433C8; Mon, 25 Sep 2023 22:05:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695679532; bh=FmZZfIJ7IjqsgMWeiyIf/YJBP5eLlOuuOdfPlbttg+A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c4+YavJePbk5XQhufDOKssIq1IW9tGV2SLanMeov18NhO3LjgeJSUdunp+PCdUPid cv6cNmJubZL8ILBF8xH3B9XfYk3Epuj212eYufl9Z3GBSGCaWPJ2Y924Ftlif9vhST JFp6ozAm1b+YgUOl5QeIamrwJ2spycsWUBPhLIQTP2IJE9iRqY1KR+DiviCyZyOW7i GvlMAIMvxBNT7LGNXXu+MrY9uKnrq+6zNLdGHwCWem90eIqJ/ew9VaKt8x6V8kNh+D ivOOj6JOuYTIrtAiCV8UZusUZLTFS0iyvQZOgirkJt7JF+yUXTFLYmaiFmhG2vXIoc qJv/N3jqi16gA== Received: (nullmailer pid 2027056 invoked by uid 1000); Mon, 25 Sep 2023 22:05:30 -0000 From: Rob Herring To: Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Krzysztof Kozlowski , Conor Dooley Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] dt-bindings: arm,coresight-cti: Add missing additionalProperties on child nodes Date: Mon, 25 Sep 2023 17:05:06 -0500 Message-Id: <20230925220511.2026514-2-robh@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230925220511.2026514-1-robh@kernel.org> References: <20230925220511.2026514-1-robh@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230925_150536_350956_5C9BB152 X-CRM114-Status: GOOD ( 16.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Just as unevaluatedProperties or additionalProperties are required at the top level of schemas, they should (and will) also be required for child node schemas. That ensures only documented properties are present for any node. Adding additionalProperties constraint on 'trig-conns' nodes results in warnings that 'cpu' and 'arm,cs-dev-assoc' are not allowed. These are already defined for the parent node, but need to be duplicated for the child node. Drop the free form description that the properties also apply to the child nodes. Signed-off-by: Rob Herring Reviewed-by: Mike Leach Acked-by: Conor Dooley --- .../bindings/arm/arm,coresight-cti.yaml | 33 ++++++++++++++----- 1 file changed, 24 insertions(+), 9 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml index b9bdfc8969cd..2d5545a2b49c 100644 --- a/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml +++ b/Documentation/devicetree/bindings/arm/arm,coresight-cti.yaml @@ -93,9 +93,7 @@ properties: cpu: description: - Handle to cpu this device is associated with. This must appear in the - base cti node if compatible string arm,coresight-cti-v8-arch is used, - or may appear in a trig-conns child node when appropriate. + Handle to cpu this CTI is associated with. power-domains: maxItems: 1 @@ -112,12 +110,12 @@ properties: description: defines a phandle reference to an associated CoreSight trace device. When the associated trace device is enabled, then the respective CTI - will be enabled. Use in a trig-conns node, or in CTI base node when - compatible string arm,coresight-cti-v8-arch used. If the associated - device has not been registered then the node name will be stored as - the connection name for later resolution. If the associated device is - not a CoreSight device or not registered then the node name will remain - the connection name and automatic enabling will not occur. + will be enabled. Use in CTI base node when compatible string + arm,coresight-cti-v8-arch used. If the associated device has not been + registered then the node name will be stored as the connection name for + later resolution. If the associated device is not a CoreSight device or + not registered then the node name will remain the connection name and + automatic enabling will not occur. # size cells and address cells required if trig-conns node present. "#size-cells": @@ -129,6 +127,8 @@ properties: patternProperties: '^trig-conns@([0-9]+)$': type: object + additionalProperties: false + description: A trigger connections child node which describes the trigger signals between this CTI and another hardware device. This device may be a CPU, @@ -140,6 +140,21 @@ patternProperties: reg: maxItems: 1 + cpu: + description: + Handle to cpu this trigger connection is associated with. + + arm,cs-dev-assoc: + $ref: /schemas/types.yaml#/definitions/phandle + description: + defines a phandle reference to an associated CoreSight trace device. + When the associated trace device is enabled, then the respective CTI + will be enabled. If the associated device has not been registered + then the node name will be stored as the connection name for later + resolution. If the associated device is not a CoreSight device or + not registered then the node name will remain the connection name + and automatic enabling will not occur. + arm,trig-in-sigs: $ref: /schemas/types.yaml#/definitions/uint32-array minItems: 1