From patchwork Fri Sep 29 14:26:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 13404322 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10E2AE71D41 for ; Fri, 29 Sep 2023 14:26:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233405AbjI2O0X (ORCPT ); Fri, 29 Sep 2023 10:26:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229545AbjI2O0W (ORCPT ); Fri, 29 Sep 2023 10:26:22 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30C3E1A4; Fri, 29 Sep 2023 07:26:20 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72D45C433C8; Fri, 29 Sep 2023 14:26:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695997579; bh=Zw7LkgQ/jKyOg203queN+Fkkg1u+kROALg4WtGtfvCc=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=EVH9jRguqswD55Xh3REVy5atRnfNRD7jy5K3A6PMZ2hwYDtVBPPrx22APc/fen2e5 lZ8X3uPC6B8R71sKQO0GOiu+fr96b0gCpYCuOG3nmtD2fnI5teqJD/+EC7Ak1LjoLi 6FcuZPfAuguQwCQsYWJIHGEuhfXqESB0aFarjt4bKyAKO0VmFaax8czh4pxKw8goDm efEd/jlZnA6/HQyYQ9otdA5xmZ2gZgQBXvQcXdix75pslsI8aWwrxEEwOen6fAZpEK AEKSM0k4vOdnbdkAtJNCzNVVyQUH6Dq0hNzBf0jBtM8JKbd8x/WMw1MxkRNDZhcPYK L5FBjWmvbtg4g== From: Mark Brown Date: Fri, 29 Sep 2023 16:26:05 +0200 Subject: [PATCH 1/4] clk: versaclock3: Remove redundant _is_writeable() MIME-Version: 1.0 Message-Id: <20230929-clk-maple-versaclk-v1-1-24dd5b3d8689@kernel.org> References: <20230929-clk-maple-versaclk-v1-0-24dd5b3d8689@kernel.org> In-Reply-To: <20230929-clk-maple-versaclk-v1-0-24dd5b3d8689@kernel.org> To: Michael Turquette , Stephen Boyd , Luca Ceresoli , Alex Helms Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown X-Mailer: b4 0.13-dev-0438c X-Developer-Signature: v=1; a=openpgp-sha256; l=1042; i=broonie@kernel.org; h=from:subject:message-id; bh=Zw7LkgQ/jKyOg203queN+Fkkg1u+kROALg4WtGtfvCc=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBlFt6F7PaipmJ69d/cW/ps7RCYA6xxUmTpTT6T4 d+4P6XyfryJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZRbehQAKCRAk1otyXVSH 0POhB/9KpT0m755dGN/X1/7bXWbyfTwS4nPkXjX8GlPt9lmLuyvpurVy6QnVnn/beGfUanJKlY5 nQodCL8Y0nH2eHq9oBl216ODJznp+p5Z7KohuuGVkdEghB+tWUyDtC7sI2PQSjzPcpwsxIxO0V8 GzTG/7Ogxa0WFUxK1AtSb+ruFt2jLWkAvtfKiW9dtO97j0sCm00M+c8B18OAC2gVSLZuoZdg8/c R32MJodHAJFAeTuaGMUf3ex5G3AHq0kcJZS5zcSxBwgHa2wV9WNAy45Hg7Ltg1YHs2W7/kiaxwd bLO3VUgSDgPjO7jI1WjSRhMut2c1VlKSmDsDbfobn5BhKe/Q X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org The versaclock3 driver provides an _is_writeable() function which returns true for all registers. This is the default assumption for regmaps so we can remove the function for a very minor improvement in performance and code size. Signed-off-by: Mark Brown --- drivers/clk/clk-versaclock3.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/clk/clk-versaclock3.c b/drivers/clk/clk-versaclock3.c index 7ab2447bd203..a5ab48ff242c 100644 --- a/drivers/clk/clk-versaclock3.c +++ b/drivers/clk/clk-versaclock3.c @@ -586,17 +586,11 @@ static const struct clk_ops vc3_clk_mux_ops = { .get_parent = vc3_clk_mux_get_parent, }; -static bool vc3_regmap_is_writeable(struct device *dev, unsigned int reg) -{ - return true; -} - static const struct regmap_config vc3_regmap_config = { .reg_bits = 8, .val_bits = 8, .cache_type = REGCACHE_RBTREE, .max_register = 0x24, - .writeable_reg = vc3_regmap_is_writeable, }; static struct vc3_hw_data clk_div[5]; From patchwork Fri Sep 29 14:26:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 13404324 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 023C5E71D40 for ; Fri, 29 Sep 2023 14:26:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233420AbjI2O02 (ORCPT ); Fri, 29 Sep 2023 10:26:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233421AbjI2O0X (ORCPT ); Fri, 29 Sep 2023 10:26:23 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA9CC1A4; Fri, 29 Sep 2023 07:26:21 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43DB7C433CB; Fri, 29 Sep 2023 14:26:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695997581; bh=PHkW5LlzxtfJIOrjyeQ0VbxZvJkl5oNvN0r2Mt8D8ME=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=joAt9QG+o3YOlBmYoMVZWtJ+0RZIpPxHF+jYHtYkx26jj5BS4zPkUxaVMEhqhhqOt oK7PwNeezJYGqmwMuXg98d28FcoTpocEA9GZmlxgUQsbJqHselHh5/VMsXM3+sg+MI xa99C3BgxICmaIIOIzSVojnAD1fz/WZsbQyKwp/HoUYQwHbs/aPCSfxDGyJej2VeTT M6DBhEIOGknxGn3m3Ms/HGPB0g52YMoOIBl3kZmWkpBrkOC7o/vLb0+13XZFnwhoE8 wwh3gII+2Msbvx1k7bFBlMwnhq0t9ag83hIgUzUZnH3E7+PhsKRrsRRnewDq2hC9GJ mk187n2YNpRig== From: Mark Brown Date: Fri, 29 Sep 2023 16:26:06 +0200 Subject: [PATCH 2/4] clk: versaclock3: Convert to use maple tree register cache MIME-Version: 1.0 Message-Id: <20230929-clk-maple-versaclk-v1-2-24dd5b3d8689@kernel.org> References: <20230929-clk-maple-versaclk-v1-0-24dd5b3d8689@kernel.org> In-Reply-To: <20230929-clk-maple-versaclk-v1-0-24dd5b3d8689@kernel.org> To: Michael Turquette , Stephen Boyd , Luca Ceresoli , Alex Helms Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown X-Mailer: b4 0.13-dev-0438c X-Developer-Signature: v=1; a=openpgp-sha256; l=837; i=broonie@kernel.org; h=from:subject:message-id; bh=PHkW5LlzxtfJIOrjyeQ0VbxZvJkl5oNvN0r2Mt8D8ME=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBlFt6GcPViAAEpgq5/50KiAU465RMOR7kGCWMPj OfFdxpeJT6JATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZRbehgAKCRAk1otyXVSH 0BMfCACD2noxzhF9tu6nOaX1jTUd6aNVy8hgdg0p22j9mYHk2Jf8zWn3t6IJ9SYqwnkc4Z3UmyL 9UzT2s6UBSXWwaUtV9C+liNEZ/EbQifMMEvOqQ0FLEtgYW0/EOYAJH/BXPTHS2MOspi/Uw+S3qV j6bm3GPFCSAj0G4sQw/B6SgdTGlgQdx+U0TBRGvnKHmRjzuzlNQYcGk3mFB+rIldayb+fxvyKAZ qzYtk/HnvBpOSxA4kXZUJ7M7lDxNFudNoZ2QBefQ7M/GUmtps57BAJFVsYqlu15DsIYNrYO/0jy Gzl3p8XALIibrs9DKXblSzWpK4X8o4AukFb30M4fPBlpgxTn X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org The maple tree register cache is based on a much more modern data structure than the rbtree cache and makes optimisation choices which are probably more appropriate for modern systems than those made by the rbtree cache. Signed-off-by: Mark Brown --- drivers/clk/clk-versaclock3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk-versaclock3.c b/drivers/clk/clk-versaclock3.c index a5ab48ff242c..b4a89c083c11 100644 --- a/drivers/clk/clk-versaclock3.c +++ b/drivers/clk/clk-versaclock3.c @@ -589,7 +589,7 @@ static const struct clk_ops vc3_clk_mux_ops = { static const struct regmap_config vc3_regmap_config = { .reg_bits = 8, .val_bits = 8, - .cache_type = REGCACHE_RBTREE, + .cache_type = REGCACHE_MAPLE, .max_register = 0x24, }; From patchwork Fri Sep 29 14:26:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 13404323 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 341AAE71D3D for ; Fri, 29 Sep 2023 14:26:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233469AbjI2O01 (ORCPT ); Fri, 29 Sep 2023 10:26:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233435AbjI2O0Z (ORCPT ); Fri, 29 Sep 2023 10:26:25 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA0FC1A4; Fri, 29 Sep 2023 07:26:23 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 048A8C433CD; Fri, 29 Sep 2023 14:26:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695997583; bh=oBY3soSZF3SsFysTGE6a4Btp1eNwflyt47C1uRidxWE=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=uShAj1BKI4qV+ZWq82jsq1cQ3GqJix/mYZCJafDp1fSn733PpFie2sjfDH9gGi6Af u5S6xbU0x9Bqhl3MpNq84tQrwxULfkSAzGKpp1gfpxjCquBC8nvpN/s97OMz5Ky3sc qLMwWK0IekDwJfgw6/3YyJow+4ODijM8uJ/nPdyAvYrqXgBC849+dVy8XvoaLmRdrH hIsrJ5j5F4McuplvgTD8Oiw5ooP/YHRy79w0JKHbofYfKIycLKMawpQSmDPRg13ay5 TJ6/g4yxjqRmFR9hV+SQaozK5LwGUvYOR+W1vffpDzwQ7b5mAvF38ZcKLb6S4+OKUR /Z6rC4iijz5jA== From: Mark Brown Date: Fri, 29 Sep 2023 16:26:07 +0200 Subject: [PATCH 3/4] clk: versaclock5: Convert to use maple tree register cache MIME-Version: 1.0 Message-Id: <20230929-clk-maple-versaclk-v1-3-24dd5b3d8689@kernel.org> References: <20230929-clk-maple-versaclk-v1-0-24dd5b3d8689@kernel.org> In-Reply-To: <20230929-clk-maple-versaclk-v1-0-24dd5b3d8689@kernel.org> To: Michael Turquette , Stephen Boyd , Luca Ceresoli , Alex Helms Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown X-Mailer: b4 0.13-dev-0438c X-Developer-Signature: v=1; a=openpgp-sha256; l=905; i=broonie@kernel.org; h=from:subject:message-id; bh=oBY3soSZF3SsFysTGE6a4Btp1eNwflyt47C1uRidxWE=; b=owEBbQGS/pANAwAKASTWi3JdVIfQAcsmYgBlFt6GTzdwHoiUGD7uKWSyPtgDql6gcsZWsoEaK 1u8FSkHegSJATMEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZRbehgAKCRAk1otyXVSH 0Ki/B/0Yo7fANFWdcXWG2wo/wCMqLWi1fZD19xJsig5XJRajpdEqS72I3l2kQ8Lr+kz8MbQkLly i1n22pEkX4zwPz0WGB+F+hfQWsk84PzJiy3rx/mB2awh8JZYhsLAdnWcgChgWE8CEDUNPF6C0Tu ZEfUiW+1cOt6UKo4xHc6goqb/Jb7IhhGJc0dSd6Yi5Lt+gfL4wt8jbeTZqT71Uv+tkHPWHF+pLC q9cJ2Gu6lnJa/xMmrASw5RsbW4Ni7G9lCsnRq349B7rvcG+PD0UiFGQSyKeU4aK5IMzXd4k55i5 jPOpL13I4G5XynPAKT1cZ12fqhJfz6VEuIVL5Qs6qHledWgs X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org The maple tree register cache is based on a much more modern data structure than the rbtree cache and makes optimisation choices which are probably more appropriate for modern systems than those made by the rbtree cache. Signed-off-by: Mark Brown --- drivers/clk/clk-versaclock5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk-versaclock5.c b/drivers/clk/clk-versaclock5.c index 17cbb30d20ad..6d31cd54d7cf 100644 --- a/drivers/clk/clk-versaclock5.c +++ b/drivers/clk/clk-versaclock5.c @@ -217,7 +217,7 @@ static bool vc5_regmap_is_writeable(struct device *dev, unsigned int reg) static const struct regmap_config vc5_regmap_config = { .reg_bits = 8, .val_bits = 8, - .cache_type = REGCACHE_RBTREE, + .cache_type = REGCACHE_MAPLE, .max_register = 0x76, .writeable_reg = vc5_regmap_is_writeable, }; From patchwork Fri Sep 29 14:26:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 13404325 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4F2DE71D3D for ; Fri, 29 Sep 2023 14:26:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233276AbjI2O0a (ORCPT ); Fri, 29 Sep 2023 10:26:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233463AbjI2O01 (ORCPT ); Fri, 29 Sep 2023 10:26:27 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E35A01B6; Fri, 29 Sep 2023 07:26:25 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8F64C433CA; Fri, 29 Sep 2023 14:26:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695997585; bh=sejfCcVQti2Hi8yDe3f20hbpcbYbp6CNahq98VEjTTs=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=D49Fy1gG40zXkfUkXiYPjOBhKb97foft4tMjLSqdeuevmDCDLa7D2Ld1lYNtaEGm0 36MnJ4mi0480zSIXrgJQJWmVUT3zfBfuDOoYOIKLC1Pxr1fq01gkc1CzN3p4F2Jqu9 M7ql95SbM2mi+lj4nWAQwL1trmZKC47Sg/4UXZONpPiUSVdq9QQ/MhcrUBf5xkxIxx mUrM03QVnF1jKzW28v3WZqUGVmVSQgJ8r4ZIFWqZYDrYZ9lrJzwpnyTYtbBJzYEl8j +ibijrMpNCzjWqMtS4o3MU4uAjsRVf8S929e+D1Hke8cOq82QnJRteVPKBC5QAtCOW LCNd5GrPShT6w== From: Mark Brown Date: Fri, 29 Sep 2023 16:26:08 +0200 Subject: [PATCH 4/4] clk: versaclock7: Convert to use maple tree register cache MIME-Version: 1.0 Message-Id: <20230929-clk-maple-versaclk-v1-4-24dd5b3d8689@kernel.org> References: <20230929-clk-maple-versaclk-v1-0-24dd5b3d8689@kernel.org> In-Reply-To: <20230929-clk-maple-versaclk-v1-0-24dd5b3d8689@kernel.org> To: Michael Turquette , Stephen Boyd , Luca Ceresoli , Alex Helms Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Brown X-Mailer: b4 0.13-dev-0438c X-Developer-Signature: v=1; a=openpgp-sha256; l=949; i=broonie@kernel.org; h=from:subject:message-id; bh=sejfCcVQti2Hi8yDe3f20hbpcbYbp6CNahq98VEjTTs=; b=owEBbAGT/pANAwAKASTWi3JdVIfQAcsmYgBlFt6HIXHja+8p20IPJvS0bbuD7/si4p9bG1/Wt xioKS4KFzeJATIEAAEKAB0WIQSt5miqZ1cYtZ/in+ok1otyXVSH0AUCZRbehwAKCRAk1otyXVSH 0FnhB/iiR9k4uSZN3HpWNB22ExzRN6CZnZk+i0JKce4/yfdm+6uiDrLQXWhDBeXiHOdT8n0ax6l J+FLIkEsUf1qFzM1qS+ndCVYCRgjTsaNQtOyhSwKnQN7hGIf/60FcK9B3Y8WxwxpHU4pWYysDFG BL0PQQ2I4S3NnyMxAYNMDXmelbXqYemwwJi5XoXTCJ7y0a7vLh/WRxO7bzht3Hu9NPf39G4Df76 r9lg3jsdlKk0978s6N98kaquQISn388TCqsDeXuzaIlQid3GkM4lDMEYplYtk3aoVlhWO5pnRwZ t/FPmTkusYWorqWBFeL1aixT9LhihrD0Tjg8mBtAgZZFU1E= X-Developer-Key: i=broonie@kernel.org; a=openpgp; fpr=3F2568AAC26998F9E813A1C5C3F436CA30F5D8EB Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org The maple tree register cache is based on a much more modern data structure than the rbtree cache and makes optimisation choices which are probably more appropriate for modern systems than those made by the rbtree cache. Signed-off-by: Mark Brown --- drivers/clk/clk-versaclock7.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk-versaclock7.c b/drivers/clk/clk-versaclock7.c index 9ab35c1af0ff..f323263e32c3 100644 --- a/drivers/clk/clk-versaclock7.c +++ b/drivers/clk/clk-versaclock7.c @@ -1275,7 +1275,7 @@ static const struct regmap_config vc7_regmap_config = { .ranges = vc7_range_cfg, .num_ranges = ARRAY_SIZE(vc7_range_cfg), .volatile_reg = vc7_volatile_reg, - .cache_type = REGCACHE_RBTREE, + .cache_type = REGCACHE_MAPLE, .can_multi_write = true, .reg_format_endian = REGMAP_ENDIAN_LITTLE, .val_format_endian = REGMAP_ENDIAN_LITTLE,