From patchwork Fri Oct 6 14:57:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 13411658 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30E2E1CA9A; Fri, 6 Oct 2023 14:57:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ZmeILY5k" Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73B138F; Fri, 6 Oct 2023 07:57:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696604261; x=1728140261; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=q4C2m1ZeP3/o/tBX987mEihRhp/gFyXcIn4YqEPfmlw=; b=ZmeILY5kiTOV3pkauuNNsBr/8Dovu7CHlKZbs9B19wtxji3XUK4skvgZ RnKSaBMMqDAPIhqQX9gpCiK8ERlnkpplRVh+sAhdzehzUbSwHgL2V1cZY 1dv7gsFE4dz/9e2H+SMTxT62C4mrq3c4O1AB04+GL0t7Kj7Tbx5mTRlvx PCVPm8lJF+2kgdxEQVdBEkIaJYKzilwsKvWX196s5oGKc0Jl/oD19ro6o fZB5ItjsVtgvkZ5Z2pdKObyFhQJyNf/AGU+JjfHcs1hCi+SCHvxKl9fYo HTyvOIu8ysnI0h2J6qn9ZLo22wVF86asLRS/konT931HkVy4nKxn604pI A==; X-IronPort-AV: E=McAfee;i="6600,9927,10855"; a="368840606" X-IronPort-AV: E=Sophos;i="6.03,204,1694761200"; d="scan'208";a="368840606" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2023 07:57:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10855"; a="755880699" X-IronPort-AV: E=Sophos;i="6.03,204,1694761200"; d="scan'208";a="755880699" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga007.fm.intel.com with ESMTP; 06 Oct 2023 07:57:36 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 4A16C430; Fri, 6 Oct 2023 17:57:35 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , Rob Herring , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , "Rafael J. Wysocki" , Len Brown , Russell King , Rob Herring , Frank Rowand , Peng Fan Subject: [PATCH v3 1/2] amba: bus: balance firmware node reference counting Date: Fri, 6 Oct 2023 17:57:31 +0300 Message-Id: <20231006145732.3419115-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Currently the ACPI code doesn't bump the reference count of the firmware node, while OF counter part does. Not that it's a problem right now, since ACPI doesn't really use the reference counting for firmware nodes, it still makes sense to make code robust against any changes done there. For this, - switch ACPI case to use device_set_node() to be unified with OF - move reference counting to amba_device_add() - switch to use firmware nodes instead of OF ones In the result we will have reference counting done in the same module for all callers independently on the nature of firmware node behind. Signed-off-by: Andy Shevchenko --- v3: no changes v2: fixed compilation error (LKP), all dependencies are in v6.6-rcX (Rob) drivers/acpi/arm64/amba.c | 2 +- drivers/amba/bus.c | 5 ++++- drivers/of/platform.c | 2 +- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/arm64/amba.c b/drivers/acpi/arm64/amba.c index 60be8ee1dbdc..171b5c2c7edd 100644 --- a/drivers/acpi/arm64/amba.c +++ b/drivers/acpi/arm64/amba.c @@ -101,7 +101,7 @@ static int amba_handler_attach(struct acpi_device *adev, if (parent) dev->dev.parent = acpi_get_first_physical_node(parent); - ACPI_COMPANION_SET(&dev->dev, adev); + device_set_node(&dev->dev, acpi_fwnode_handle(adev)); ret = amba_device_add(dev, &iomem_resource); if (ret) { diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c index 09e72967b8ab..a24c152bfaac 100644 --- a/drivers/amba/bus.c +++ b/drivers/amba/bus.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include #include @@ -528,7 +529,7 @@ static void amba_device_release(struct device *dev) { struct amba_device *d = to_amba_device(dev); - of_node_put(d->dev.of_node); + fwnode_handle_put(dev_fwnode(&d->dev)); if (d->res.parent) release_resource(&d->res); mutex_destroy(&d->periphid_lock); @@ -548,6 +549,8 @@ int amba_device_add(struct amba_device *dev, struct resource *parent) { int ret; + fwnode_handle_get(dev_fwnode(&dev->dev)); + ret = request_resource(parent, &dev->res); if (ret) return ret; diff --git a/drivers/of/platform.c b/drivers/of/platform.c index f235ab55b91e..126d265aa7d8 100644 --- a/drivers/of/platform.c +++ b/drivers/of/platform.c @@ -273,7 +273,7 @@ static struct amba_device *of_amba_device_create(struct device_node *node, dev->dev.dma_mask = &dev->dev.coherent_dma_mask; /* setup generic device info */ - device_set_node(&dev->dev, of_fwnode_handle(of_node_get(node))); + device_set_node(&dev->dev, of_fwnode_handle(node)); dev->dev.parent = parent ? : &platform_bus; dev->dev.platform_data = platform_data; if (bus_id) From patchwork Fri Oct 6 14:57:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 13411659 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5754F1CA9A; Fri, 6 Oct 2023 14:57:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="NTCz/cNV" Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17266A6; Fri, 6 Oct 2023 07:57:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696604266; x=1728140266; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=pwbbbgcEIxTYBd2yOIqpmkQsPrsV9eQPsSf0L3T2NTk=; b=NTCz/cNVB31ceIYjJDZbdiayHxTba4rhA3Ai5BlWPLjtTLBV44Ob6Zid RW77iatlzfSWExIvJDYhpQfQF6FZmSjmNw4oRakTLgziJZO4Dj8sFzIgz 5FilqeBM0wzTrRV+1bspSqryd5CFl8XCI5fGVRSHOZMWF0MBmMWUVgDz6 Rz5pQPyELxBRuFxF0gXRpMkZnXPkUEAi88mV0WvWXO3CHBXl/ljNuW1dG yx7Zo3j+FKa6wwcu0oYHYLE5jcofiYepewXG7WprOINxTCowqDduWSunT OpaLQwHkvsIErCOaUjnYxjKMZd9wbhDUk93QAdNi5/iP8q5aiL48vEdhi Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10855"; a="368840637" X-IronPort-AV: E=Sophos;i="6.03,204,1694761200"; d="scan'208";a="368840637" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2023 07:57:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10855"; a="755880712" X-IronPort-AV: E=Sophos;i="6.03,204,1694761200"; d="scan'208";a="755880712" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga007.fm.intel.com with ESMTP; 06 Oct 2023 07:57:42 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id AB142430; Fri, 6 Oct 2023 17:57:41 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , Rob Herring , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , "Rafael J. Wysocki" , Len Brown , Russell King , Rob Herring , Frank Rowand , Peng Fan Subject: [PATCH v3 2/2] amba: bus: Enable compile testing Date: Fri, 6 Oct 2023 17:57:32 +0300 Message-Id: <20231006145732.3419115-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20231006145732.3419115-1-andriy.shevchenko@linux.intel.com> References: <20231006145732.3419115-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net There is no architecture specific code in the implementation of AMBA bus, let's enable compile testing for it. Signed-off-by: Andy Shevchenko --- v3: fixed compilation error (LKP, Rob), amended summary (Rob) v2: new patch to make it easier to compile test on non-ARM drivers/amba/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/amba/Kconfig b/drivers/amba/Kconfig index fb6c7e0b4cce..21fa17697b48 100644 --- a/drivers/amba/Kconfig +++ b/drivers/amba/Kconfig @@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 config ARM_AMBA - bool + bool "Arm (AMBA) Primecell Device bus" if COMPILE_TEST if ARM_AMBA