From patchwork Sun Oct 8 22:32:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 13412813 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B6E4E95A67 for ; Sun, 8 Oct 2023 22:33:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D1E8A10E025; Sun, 8 Oct 2023 22:33:26 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) by gabe.freedesktop.org (Postfix) with ESMTPS id A625310E025 for ; Sun, 8 Oct 2023 22:33:24 +0000 (UTC) Received: from tr.lan (ip-86-49-120-218.bb.vodafone.cz [86.49.120.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 6044F86CDB; Mon, 9 Oct 2023 00:33:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1696804387; bh=gKcYdBG1htOzH5N6anQyRWU5kbG7koGh4+SFC7WXwHc=; h=From:To:Cc:Subject:Date:From; b=ua88bF+uftrNfUSiRNa6TPrVIWLS1GLNwdj5uCzQcDqcJ422vLgmLbLb1VvDMulpv g0EJEbkwRDixyiElTQd0F2QOKNvX7O9vqwZZjC8fHddNXy41l9lYnyZ8LSKhlnmA/c h3+PywNfpfDR/XHVx1M1FXhhON0u5nsO8PGn6vKY9lg1WETgcqy7bPh3BBONmgU6Kw B2zwg1sWw9/jfhVpPFgkLUEB4fGO4ytEWZaL8mmfcfKgnZ8nujWE/Ppyn3BFOK+Aps JQUhe2zJJ2UQVYhjT2Jk04dLsM+8dtZzTvXc+jFA+HAiPXDzcu0AYPGXkw8Sbin/FY yTYG6vlra1MvA== From: Marek Vasut To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm/panel: simple: Fix Innolux G101ICE-L01 timings Date: Mon, 9 Oct 2023 00:32:56 +0200 Message-Id: <20231008223256.279196-1-marex@denx.de> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , Neil Armstrong , Thomas Zimmermann , Sam Ravnborg , Maxime Ripard , Jessica Zhang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The Innolux G101ICE-L01 datasheet [1] page 17 table 6.1 INPUT SIGNAL TIMING SPECIFICATIONS indicates that maximum vertical blanking time is 40 lines. Currently the driver uses 29 lines. Fix it, and since this panel is a DE panel, adjust the timings to make them less hostile to controllers which cannot do 1 px HSA/VSA, distribute the delays evenly between all three parts. [1] https://www.data-modul.com/sites/default/files/products/G101ICE-L01-C2-specification-12042389.pdf Fixes: 1e29b840af9f ("drm/panel: simple: Add Innolux G101ICE-L01 panel") Signed-off-by: Marek Vasut Reviewed-by: Neil Armstrong --- Cc: Daniel Vetter Cc: David Airlie Cc: Jessica Zhang Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Neil Armstrong Cc: Sam Ravnborg Cc: Thomas Zimmermann Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/panel/panel-simple.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 7ce51ad616296..44c11c418cd56 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -2295,13 +2295,13 @@ static const struct panel_desc innolux_g070y2_t02 = { static const struct display_timing innolux_g101ice_l01_timing = { .pixelclock = { 60400000, 71100000, 74700000 }, .hactive = { 1280, 1280, 1280 }, - .hfront_porch = { 41, 80, 100 }, - .hback_porch = { 40, 79, 99 }, - .hsync_len = { 1, 1, 1 }, + .hfront_porch = { 30, 60, 70 }, + .hback_porch = { 30, 60, 70 }, + .hsync_len = { 22, 40, 60 }, .vactive = { 800, 800, 800 }, - .vfront_porch = { 5, 11, 14 }, - .vback_porch = { 4, 11, 14 }, - .vsync_len = { 1, 1, 1 }, + .vfront_porch = { 3, 8, 14 }, + .vback_porch = { 3, 8, 14 }, + .vsync_len = { 4, 7, 12 }, .flags = DISPLAY_FLAGS_DE_HIGH, };