From patchwork Sun Oct 15 20:12:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dorcas Litunya X-Patchwork-Id: 13422320 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4384CDB47E for ; Sun, 15 Oct 2023 20:14:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230200AbjJOUOc (ORCPT ); Sun, 15 Oct 2023 16:14:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230156AbjJOUOc (ORCPT ); Sun, 15 Oct 2023 16:14:32 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBBC4B7; Sun, 15 Oct 2023 13:14:30 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-9becde9ea7bso249726066b.0; Sun, 15 Oct 2023 13:14:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697400869; x=1698005669; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=E01GM7WTt8O9z43gWlZ2wCLn5WJWwuOIiG1N7ZnbIAk=; b=c2N+if2iQ4A/3YH69wzSvgcoal4R6ai82gHhjekJ3oJo8L6ZofUp0K07vkNtU1U+zi x8onL0K9Q2gJwOA1U8smxomo27CRtD9R+A4fjcoDzFmvLIdrdwqO5BCIGVQxpVtUV1yq eqBySc0mWyoHG1EZiPq1qk5QsnlCNLJXzUZ5/h1AMOTg0ji5o8/415prED+vxyOqseAr r7BzaAvcL4wamKsZ4bKRm/4TnbNoIK1WBmvTYm1BJX4dQafMtb5t+ui+IlKdMITx7KIX 4K1I5IpX1bWNKdsjhAT7lH/739eWwHTpwI6ET5Bj5hCsnE9tiwm3H7zXWFBVhhehUTgN 8Ppg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697400869; x=1698005669; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E01GM7WTt8O9z43gWlZ2wCLn5WJWwuOIiG1N7ZnbIAk=; b=ct0TZQadAgZPSU7tL7o90g13fSKOZotnNJwkzuY7XmhoX7KgT9cO9NFxyHKlVZA/cP jfRfzvBdEPmmA6ecGS2Jdp3xTZZntO9CQ/PgpJU9+FddGZdXhKc72RWhunyzTWA1e42N LqHonGphflLclFOW4QmOrdUM8msuAUiL0Q9ShXsCFplFeJUL2ELWYgB8G9WOiQGaGbY9 jYy35DKPzrw4uDmPAkpROd+tNcPDacpiDJGVBYYWAYGh6XP7TAyFciFo591CHBOL4Mi5 JgTewcgrbVr64pHB2ZH166+kHLzBP91xQEYnZ+9cCWlCwn7ambq8ys3QAy+8WVt43IQ1 8Hsg== X-Gm-Message-State: AOJu0YylmC5192IW/fegEiQ8+/cm0HqkXhIUtGz6h3Upm+ZWMP4yV8dY dSBpEiRxDaYGehXNRzdaaGCqar75AhayWPQ= X-Google-Smtp-Source: AGHT+IEzZG/3pGHapm1wmqB24H+D+DFxbgwenYhV7bi/4YFWFECn87yHreYV9h1q7mMoZz2ScF1V+w== X-Received: by 2002:a17:907:1c10:b0:9a5:7dec:fab9 with SMTP id nc16-20020a1709071c1000b009a57decfab9mr5752145ejc.9.1697400869239; Sun, 15 Oct 2023 13:14:29 -0700 (PDT) Received: from dorcaslitunya-virtual-machine.localdomain ([105.163.157.6]) by smtp.gmail.com with ESMTPSA id m10-20020a170906234a00b009ae587ce133sm2721766eja.188.2023.10.15.13.14.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Oct 2023 13:14:28 -0700 (PDT) From: Dorcas AnonoLitunya Cc: anonolitunya@gmail.com, outreachy@lists.linux.dev, Sudip Mukherjee , Teddy Wang , Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 1/5] Staging: sm750fb: Rename displayControlAdjust_SM750E Date: Sun, 15 Oct 2023 23:12:34 +0300 Message-ID: <16a9ad33ef67993482da0d350d7239aee3f0dd22.1697400022.git.anonolitunya@gmail.com> X-Mailer: git-send-email 2.42.0.345.gaab89be2eb In-Reply-To: References: MIME-Version: 1.0 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Rename function displayControlAdjust_SM750E to display_control_adjust_SM750E.This follows snakecase naming convention and ensures consistent naming style throughout the file.Issue by checkpatch. Mutes the following error: CHECK:Avoid CamelCase: Signed-off-by: Dorcas AnonoLitunya --- drivers/staging/sm750fb/ddk750_mode.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c index e00a6cb31947..8708995f676c 100644 --- a/drivers/staging/sm750fb/ddk750_mode.c +++ b/drivers/staging/sm750fb/ddk750_mode.c @@ -14,8 +14,8 @@ * in bit 29:27 of Display Control register. */ static unsigned long -displayControlAdjust_SM750LE(struct mode_parameter *pModeParam, - unsigned long dispControl) +display_control_adjust_SM750LE(struct mode_parameter *pModeParam, + unsigned long dispControl) { unsigned long x, y; @@ -125,7 +125,7 @@ static int programModeRegisters(struct mode_parameter *pModeParam, tmp |= DISPLAY_CTRL_HSYNC_PHASE; if (sm750_get_chip_type() == SM750LE) { - displayControlAdjust_SM750LE(pModeParam, tmp); + display_control_adjust_SM750LE(pModeParam, tmp); } else { reg = peek32(CRT_DISPLAY_CTRL) & ~(DISPLAY_CTRL_VSYNC_PHASE | From patchwork Sun Oct 15 20:12:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dorcas Litunya X-Patchwork-Id: 13422323 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EFC7CDB47E for ; Sun, 15 Oct 2023 20:15:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230261AbjJOUPM (ORCPT ); Sun, 15 Oct 2023 16:15:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230156AbjJOUPL (ORCPT ); Sun, 15 Oct 2023 16:15:11 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E61BB7; Sun, 15 Oct 2023 13:15:10 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-53e3b8f906fso4199340a12.2; Sun, 15 Oct 2023 13:15:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697400908; x=1698005708; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QXTa2gL9HBai55IcBL1BTntgkzuJUdmD/v5gCocZbHs=; b=e7R5dt+FbP42D1zSxDvrstvkPrVR0CkduPDvESQzrgXahf8RvRp4EohVzKa0vLOsi3 j4taQJcA7J1vpdA+/VmnGG+pCvykXeQhxblQNlI7Q57bpBgbqz5CyuXzt6BH/80/KnRU 4Q+oM113ua0JvT3FcnK65b/KnJm0vTzYZ/GkmlX5iGEsh/2KrcMjmZSSOjai6lFKbe/D 40UcbG8m0409PyMsOSDZRGs2oZ9EdB+IUTZOZKKMKmUx75KsAzORfScKGmX0jjCCA6oH eWJaDqxjVDFk9XpkEPiUA9rMwxvbLJYHXCYlOTqn+qbFsNnMzEfwbNZdDo1/7bKeAuqv K9tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697400908; x=1698005708; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QXTa2gL9HBai55IcBL1BTntgkzuJUdmD/v5gCocZbHs=; b=YW/IgsezBy3b88t4CXMqVOgftBIEL9srtoFugF0hwYKakaU5qyz9elHpTT9FGmJ7tJ O41mSerRkasiACovBDC57GIL5RK38ggwVGfYbsWv93TXaDox46sx6EDZTYetas6jn0Pl 34OccaTuOeyfBiXJIx2kA6U4wbXATdMUw2HG5OCYXEwSM84yonDXAmS8CRtC+sTRZSS9 zvAX+jnTU5Ci2dPxmfOK8KVd7e+3ZcfKiNDJ/mnal+FUo89VsY3TNAFhOpSWVJcrbWKw +mGzDptEqVOZZK2SgHQSkiX9sXzNQdORHLliawgNOXZXmbbu2EE2uwML9WpEFXitZ7WM u6yA== X-Gm-Message-State: AOJu0YwuAJqmKRD6Edzd/wwTi1gqNxmCbjDGnBPcndHmWnl3DqRykrhU aAwX94Qn/jYiptO2BgscZA== X-Google-Smtp-Source: AGHT+IETPtm5unk77kgqFdIgB+l/ZOGyPbpxXd+Uhi+vj3W4vbJora6mEHU5R3B5breKXMk+NpeKgg== X-Received: by 2002:a17:907:869e:b0:9bd:9bfe:e410 with SMTP id qa30-20020a170907869e00b009bd9bfee410mr7301558ejc.72.1697400908491; Sun, 15 Oct 2023 13:15:08 -0700 (PDT) Received: from dorcaslitunya-virtual-machine.localdomain ([105.163.157.6]) by smtp.gmail.com with ESMTPSA id m10-20020a170906234a00b009ae587ce133sm2721766eja.188.2023.10.15.13.15.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Oct 2023 13:15:08 -0700 (PDT) From: Dorcas AnonoLitunya Cc: anonolitunya@gmail.com, outreachy@lists.linux.dev, Sudip Mukherjee , Teddy Wang , Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 2/5] Staging: sm750fb: Rename pModeParam Date: Sun, 15 Oct 2023 23:12:35 +0300 Message-ID: <38ca20478a21d770f3a0b6f5478d06b67510492e.1697400022.git.anonolitunya@gmail.com> X-Mailer: git-send-email 2.42.0.345.gaab89be2eb In-Reply-To: References: MIME-Version: 1.0 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Rename variable pModeParam to mode_param.This follows snakecase naming convention and ensures consistent naming style throughout the file.Issue by checkpatch. Mutes the following checkpatch error: CHECK: Avoid CamelCase: Signed-off-by: Dorcas AnonoLitunya --- drivers/staging/sm750fb/ddk750_mode.c | 52 +++++++++++++-------------- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c index 8708995f676c..431b273a347a 100644 --- a/drivers/staging/sm750fb/ddk750_mode.c +++ b/drivers/staging/sm750fb/ddk750_mode.c @@ -14,13 +14,13 @@ * in bit 29:27 of Display Control register. */ static unsigned long -display_control_adjust_SM750LE(struct mode_parameter *pModeParam, +display_control_adjust_SM750LE(struct mode_parameter *mode_param, unsigned long dispControl) { unsigned long x, y; - x = pModeParam->horizontal_display_end; - y = pModeParam->vertical_display_end; + x = mode_param->horizontal_display_end; + y = mode_param->vertical_display_end; /* * SM750LE has to set up the top-left and bottom-right @@ -75,7 +75,7 @@ display_control_adjust_SM750LE(struct mode_parameter *pModeParam, } /* only timing related registers will be programed */ -static int programModeRegisters(struct mode_parameter *pModeParam, +static int programModeRegisters(struct mode_parameter *mode_param, struct pll_value *pll) { int ret = 0; @@ -86,46 +86,46 @@ static int programModeRegisters(struct mode_parameter *pModeParam, /* programe secondary pixel clock */ poke32(CRT_PLL_CTRL, sm750_format_pll_reg(pll)); - tmp = ((pModeParam->horizontal_total - 1) << + tmp = ((mode_param->horizontal_total - 1) << CRT_HORIZONTAL_TOTAL_TOTAL_SHIFT) & CRT_HORIZONTAL_TOTAL_TOTAL_MASK; - tmp |= (pModeParam->horizontal_display_end - 1) & + tmp |= (mode_param->horizontal_display_end - 1) & CRT_HORIZONTAL_TOTAL_DISPLAY_END_MASK; poke32(CRT_HORIZONTAL_TOTAL, tmp); - tmp = (pModeParam->horizontal_sync_width << + tmp = (mode_param->horizontal_sync_width << CRT_HORIZONTAL_SYNC_WIDTH_SHIFT) & CRT_HORIZONTAL_SYNC_WIDTH_MASK; - tmp |= (pModeParam->horizontal_sync_start - 1) & + tmp |= (mode_param->horizontal_sync_start - 1) & CRT_HORIZONTAL_SYNC_START_MASK; poke32(CRT_HORIZONTAL_SYNC, tmp); - tmp = ((pModeParam->vertical_total - 1) << + tmp = ((mode_param->vertical_total - 1) << CRT_VERTICAL_TOTAL_TOTAL_SHIFT) & CRT_VERTICAL_TOTAL_TOTAL_MASK; - tmp |= (pModeParam->vertical_display_end - 1) & + tmp |= (mode_param->vertical_display_end - 1) & CRT_VERTICAL_TOTAL_DISPLAY_END_MASK; poke32(CRT_VERTICAL_TOTAL, tmp); - tmp = ((pModeParam->vertical_sync_height << + tmp = ((mode_param->vertical_sync_height << CRT_VERTICAL_SYNC_HEIGHT_SHIFT)) & CRT_VERTICAL_SYNC_HEIGHT_MASK; - tmp |= (pModeParam->vertical_sync_start - 1) & + tmp |= (mode_param->vertical_sync_start - 1) & CRT_VERTICAL_SYNC_START_MASK; poke32(CRT_VERTICAL_SYNC, tmp); tmp = DISPLAY_CTRL_TIMING | DISPLAY_CTRL_PLANE; - if (pModeParam->vertical_sync_polarity) + if (mode_param->vertical_sync_polarity) tmp |= DISPLAY_CTRL_VSYNC_PHASE; - if (pModeParam->horizontal_sync_polarity) + if (mode_param->horizontal_sync_polarity) tmp |= DISPLAY_CTRL_HSYNC_PHASE; if (sm750_get_chip_type() == SM750LE) { - display_control_adjust_SM750LE(pModeParam, tmp); + display_control_adjust_SM750LE(mode_param, tmp); } else { reg = peek32(CRT_DISPLAY_CTRL) & ~(DISPLAY_CTRL_VSYNC_PHASE | @@ -140,40 +140,40 @@ static int programModeRegisters(struct mode_parameter *pModeParam, poke32(PANEL_PLL_CTRL, sm750_format_pll_reg(pll)); - reg = ((pModeParam->horizontal_total - 1) << + reg = ((mode_param->horizontal_total - 1) << PANEL_HORIZONTAL_TOTAL_TOTAL_SHIFT) & PANEL_HORIZONTAL_TOTAL_TOTAL_MASK; - reg |= ((pModeParam->horizontal_display_end - 1) & + reg |= ((mode_param->horizontal_display_end - 1) & PANEL_HORIZONTAL_TOTAL_DISPLAY_END_MASK); poke32(PANEL_HORIZONTAL_TOTAL, reg); poke32(PANEL_HORIZONTAL_SYNC, - ((pModeParam->horizontal_sync_width << + ((mode_param->horizontal_sync_width << PANEL_HORIZONTAL_SYNC_WIDTH_SHIFT) & PANEL_HORIZONTAL_SYNC_WIDTH_MASK) | - ((pModeParam->horizontal_sync_start - 1) & + ((mode_param->horizontal_sync_start - 1) & PANEL_HORIZONTAL_SYNC_START_MASK)); poke32(PANEL_VERTICAL_TOTAL, - (((pModeParam->vertical_total - 1) << + (((mode_param->vertical_total - 1) << PANEL_VERTICAL_TOTAL_TOTAL_SHIFT) & PANEL_VERTICAL_TOTAL_TOTAL_MASK) | - ((pModeParam->vertical_display_end - 1) & + ((mode_param->vertical_display_end - 1) & PANEL_VERTICAL_TOTAL_DISPLAY_END_MASK)); poke32(PANEL_VERTICAL_SYNC, - ((pModeParam->vertical_sync_height << + ((mode_param->vertical_sync_height << PANEL_VERTICAL_SYNC_HEIGHT_SHIFT) & PANEL_VERTICAL_SYNC_HEIGHT_MASK) | - ((pModeParam->vertical_sync_start - 1) & + ((mode_param->vertical_sync_start - 1) & PANEL_VERTICAL_SYNC_START_MASK)); tmp = DISPLAY_CTRL_TIMING | DISPLAY_CTRL_PLANE; - if (pModeParam->vertical_sync_polarity) + if (mode_param->vertical_sync_polarity) tmp |= DISPLAY_CTRL_VSYNC_PHASE; - if (pModeParam->horizontal_sync_polarity) + if (mode_param->horizontal_sync_polarity) tmp |= DISPLAY_CTRL_HSYNC_PHASE; - if (pModeParam->clock_phase_polarity) + if (mode_param->clock_phase_polarity) tmp |= DISPLAY_CTRL_CLOCK_PHASE; reserved = PANEL_DISPLAY_CTRL_RESERVED_MASK | From patchwork Sun Oct 15 20:12:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dorcas Litunya X-Patchwork-Id: 13422324 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15101CDB47E for ; Sun, 15 Oct 2023 20:15:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229983AbjJOUPX (ORCPT ); Sun, 15 Oct 2023 16:15:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33826 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230352AbjJOUPX (ORCPT ); Sun, 15 Oct 2023 16:15:23 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C675CDE; Sun, 15 Oct 2023 13:15:20 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-9bdf5829000so302795666b.0; Sun, 15 Oct 2023 13:15:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697400919; x=1698005719; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=C7fHtR18EgBCEQREVmue4LTAycmdBOG4IGNb7hGTz+I=; b=nATkoitibM/AAgt6s/fIXj6InUHVPS7SYtFBhUrOcMJ1Afhxj9qw3jZrRmueEg6HIG RgNN7nIr/NP82igIasOSKjZ7iuhznXr2to4FEdYGZo4yEPjhTtc+aovOzGRQASwYEjct h625nqZPeZE76f3uk9t3ZzRYMM2V2jJr1Y0mq6U+1b2HZXevvTClLLgZHRx5mV60eVCd 0ErAme9X97NE6uJoh7kAL7QdfWMJyCu489pr2Pu+vK2VSY9qKF1Qfxv/Z0qpx1DhkwJx q3ZGqPwR1GXL4KvV73iJyP84KORSbZzkQCimB2b+znQ6R0Qn6vy6uBvGM7+OzIEjHmnQ sQqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697400919; x=1698005719; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C7fHtR18EgBCEQREVmue4LTAycmdBOG4IGNb7hGTz+I=; b=fKP3fvy1NfOEe2WH4mlN8qJiubLaMt9TA/Wwy+bgu366gqbS9+FAHzhDU97ekEtGeM +XassxNX5IMKKw7bDzQ0v24ckO7NTAEv9pMwA/IotIWBjs8YT4pVJnbAg8EEuWe3jyyB Of4fsng4xvJIHZwjzLGaBv7iXFqWwXgR1IYo+mMWQnZ/wUiaSTJhs5HP6z5ndSctpYD5 OFKAfrQruC84VshLObtGvHjAEZ8EpAnXYWM3juFj8+12rOF+nkHSxclOrF2prU1iXDyB Vuo4u8LVHVQpElRgOAguBGde9aPdfhdHHIIzpBFGxyePROGaytWGCEdBEitcgv6dzmvz q1Kg== X-Gm-Message-State: AOJu0Yw1dITniLsjliSNkKNzC0ZKYvfrdPfyVhdIY6lT0zL2IQD0Q7Df KGqvU8GjsooWuDqiEP1eIA== X-Google-Smtp-Source: AGHT+IFcUmakawG4mi5/cnj+QCu8NJpy46yrrOtg/488uT9MrdczN+fnaVgKvaEaH9uw+uTcrwKvww== X-Received: by 2002:a17:907:31c2:b0:9be:2b53:ac4d with SMTP id xf2-20020a17090731c200b009be2b53ac4dmr4493560ejb.74.1697400918792; Sun, 15 Oct 2023 13:15:18 -0700 (PDT) Received: from dorcaslitunya-virtual-machine.localdomain ([105.163.157.6]) by smtp.gmail.com with ESMTPSA id m10-20020a170906234a00b009ae587ce133sm2721766eja.188.2023.10.15.13.15.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Oct 2023 13:15:18 -0700 (PDT) From: Dorcas AnonoLitunya Cc: anonolitunya@gmail.com, outreachy@lists.linux.dev, Sudip Mukherjee , Teddy Wang , Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 3/5] Staging: sm750fb: Rename displayControl Date: Sun, 15 Oct 2023 23:12:36 +0300 Message-ID: <596de9b4cf3483d872b1ba25e1b02194aec34bac.1697400022.git.anonolitunya@gmail.com> X-Mailer: git-send-email 2.42.0.345.gaab89be2eb In-Reply-To: References: MIME-Version: 1.0 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Rename variable displayControl to display_control. This follows snakecase naming convention and ensures consistent naming style throughout the file.Issue by checkpatch. Mutes the following checkpatch error: CHECK: Avoid CamelCase: Signed-off-by: Dorcas AnonoLitunya --- drivers/staging/sm750fb/ddk750_mode.c | 32 +++++++++++++-------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c index 431b273a347a..fc3db09de9ae 100644 --- a/drivers/staging/sm750fb/ddk750_mode.c +++ b/drivers/staging/sm750fb/ddk750_mode.c @@ -15,7 +15,7 @@ */ static unsigned long display_control_adjust_SM750LE(struct mode_parameter *mode_param, - unsigned long dispControl) + unsigned long disp_control) { unsigned long x, y; @@ -36,42 +36,42 @@ display_control_adjust_SM750LE(struct mode_parameter *mode_param, ((x - 1) & CRT_AUTO_CENTERING_BR_RIGHT_MASK)); /* - * Assume common fields in dispControl have been properly set before + * Assume common fields in disp_control have been properly set before * calling this function. - * This function only sets the extra fields in dispControl. + * This function only sets the extra fields in disp_control. */ /* Clear bit 29:27 of display control register */ - dispControl &= ~CRT_DISPLAY_CTRL_CLK_MASK; + disp_control &= ~CRT_DISPLAY_CTRL_CLK_MASK; /* Set bit 29:27 of display control register for the right clock */ /* Note that SM750LE only need to supported 7 resolutions. */ if (x == 800 && y == 600) - dispControl |= CRT_DISPLAY_CTRL_CLK_PLL41; + disp_control |= CRT_DISPLAY_CTRL_CLK_PLL41; else if (x == 1024 && y == 768) - dispControl |= CRT_DISPLAY_CTRL_CLK_PLL65; + disp_control |= CRT_DISPLAY_CTRL_CLK_PLL65; else if (x == 1152 && y == 864) - dispControl |= CRT_DISPLAY_CTRL_CLK_PLL80; + disp_control |= CRT_DISPLAY_CTRL_CLK_PLL80; else if (x == 1280 && y == 768) - dispControl |= CRT_DISPLAY_CTRL_CLK_PLL80; + disp_control |= CRT_DISPLAY_CTRL_CLK_PLL80; else if (x == 1280 && y == 720) - dispControl |= CRT_DISPLAY_CTRL_CLK_PLL74; + disp_control |= CRT_DISPLAY_CTRL_CLK_PLL74; else if (x == 1280 && y == 960) - dispControl |= CRT_DISPLAY_CTRL_CLK_PLL108; + disp_control |= CRT_DISPLAY_CTRL_CLK_PLL108; else if (x == 1280 && y == 1024) - dispControl |= CRT_DISPLAY_CTRL_CLK_PLL108; + disp_control |= CRT_DISPLAY_CTRL_CLK_PLL108; else /* default to VGA clock */ - dispControl |= CRT_DISPLAY_CTRL_CLK_PLL25; + disp_control |= CRT_DISPLAY_CTRL_CLK_PLL25; /* Set bit 25:24 of display controller */ - dispControl |= (CRT_DISPLAY_CTRL_CRTSELECT | CRT_DISPLAY_CTRL_RGBBIT); + disp_control |= (CRT_DISPLAY_CTRL_CRTSELECT | CRT_DISPLAY_CTRL_RGBBIT); /* Set bit 14 of display controller */ - dispControl |= DISPLAY_CTRL_CLOCK_PHASE; + disp_control |= DISPLAY_CTRL_CLOCK_PHASE; - poke32(CRT_DISPLAY_CTRL, dispControl); + poke32(CRT_DISPLAY_CTRL, disp_control); - return dispControl; + return disp_control; } /* only timing related registers will be programed */ From patchwork Sun Oct 15 20:12:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dorcas Litunya X-Patchwork-Id: 13422325 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3850CDB47E for ; Sun, 15 Oct 2023 20:15:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230352AbjJOUPf (ORCPT ); Sun, 15 Oct 2023 16:15:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229649AbjJOUP3 (ORCPT ); Sun, 15 Oct 2023 16:15:29 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DF8EDE; Sun, 15 Oct 2023 13:15:28 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-9ae2cc4d17eso622201966b.1; Sun, 15 Oct 2023 13:15:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697400927; x=1698005727; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KOqkDNi2G1klSItw+VfFUFmDBPvfXQMPHAdmvnTWKuY=; b=dMLMAH/Z6JUUUKif67a1PIqErjC7VE0HEIAO/qhxt2Q1EQrsNeMccK0g4rmfn1piEI MOASk5ymic0s5gIM67mPPgPaaRvbLPQlZTaZrs9KaKW7stBnpspRBDEXDkN5VtTYdgqk OfRAnctFYtb8rzXnF+SFemkbi7qdAUf+F21DbuNynWXRgjaxIgEiVkVUPe9cNnm+KcBP ovqdw897+lbmwDWf0IbepSCkHxtWIue46B/zyHiMnfapkF92ZEACifwthxtmS7Rkv3XK KOKW/ohrwsIP3D//Ov0C8KwmibDVNmaEWFsVuU3TnmkWmGTPHYi/Yy8/WX2k9p24W6pT XS8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697400927; x=1698005727; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KOqkDNi2G1klSItw+VfFUFmDBPvfXQMPHAdmvnTWKuY=; b=HCrxxLvXO7JwbhrT56p4dJZ+fsGmCQdmKTgdoCBbuTmwogdHTMdmRM6gIOk2kb7zxV UFPsyQRoSUum+xjtjiD7iOFTz1oJrcAUmjiqW4mrOUDL9mTQv4tj/5nk6yplQ5UOF6M/ VbgKAvUHXZe4S+wKgY914Z85QtcAzXd5EQ+IZzb3mF7rez1+p1+s9jhYT++3CNwabYe4 +Nk1Cb/IB7/8S2LgyY5EI+Ln/UjTa3jb9K2I1d7N3z4EGmUmOKeqnwXsxSlwZVbakLj0 A9I5ZtMh/DAW+6qSzfSf3Y7YznFoYPwnTlrOxXuRtj3yYvq2JXCcbLasEzkVBC5/PjLO KpPQ== X-Gm-Message-State: AOJu0Yw+hlY0P5/W7nxs1Q5lIR9vBCoywv+zJhAQhu7DHQaRqoVERhnC 9awHzsT9fnozc7glWiNQdI3bvFlFawoUSlQ= X-Google-Smtp-Source: AGHT+IGmDRzZZ15imc7zYxdckrpC7tosOr9IS4ylHP2yT0JnqKftSePWFbjYO1E8NFxywr2czVZL4A== X-Received: by 2002:a17:907:7ea4:b0:9be:6395:6b12 with SMTP id qb36-20020a1709077ea400b009be63956b12mr5248720ejc.27.1697400926427; Sun, 15 Oct 2023 13:15:26 -0700 (PDT) Received: from dorcaslitunya-virtual-machine.localdomain ([105.163.157.6]) by smtp.gmail.com with ESMTPSA id m10-20020a170906234a00b009ae587ce133sm2721766eja.188.2023.10.15.13.15.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Oct 2023 13:15:26 -0700 (PDT) From: Dorcas AnonoLitunya Cc: anonolitunya@gmail.com, outreachy@lists.linux.dev, Sudip Mukherjee , Teddy Wang , Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 4/5] Staging: sm750fb: Rename programModeRegisters Date: Sun, 15 Oct 2023 23:12:37 +0300 Message-ID: <1f4999e1523371bfb7dadde8eea7073ef3a04c75.1697400022.git.anonolitunya@gmail.com> X-Mailer: git-send-email 2.42.0.345.gaab89be2eb In-Reply-To: References: MIME-Version: 1.0 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Rename function programModeRegisters to program_mode_registers. This follows snakecase naming convention and ensures consistent naming style throughout the file.Issue by checkpatch. Mutes the following checkpatch error: CHECK: Avoid CamelCase: Signed-off-by: Dorcas AnonoLitunya --- drivers/staging/sm750fb/ddk750_mode.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c index fc3db09de9ae..e901855fa9b6 100644 --- a/drivers/staging/sm750fb/ddk750_mode.c +++ b/drivers/staging/sm750fb/ddk750_mode.c @@ -75,8 +75,8 @@ display_control_adjust_SM750LE(struct mode_parameter *mode_param, } /* only timing related registers will be programed */ -static int programModeRegisters(struct mode_parameter *mode_param, - struct pll_value *pll) +static int program_mode_registers(struct mode_parameter *mode_param, + struct pll_value *pll) { int ret = 0; int cnt = 0; @@ -220,6 +220,6 @@ int ddk750_setModeTiming(struct mode_parameter *parm, enum clock_type clock) outb_p(0x88, 0x3d4); outb_p(0x06, 0x3d5); } - programModeRegisters(parm, &pll); + program_mode_registers(parm, &pll); return 0; } From patchwork Sun Oct 15 20:12:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dorcas Litunya X-Patchwork-Id: 13422326 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7C19CDB47E for ; Sun, 15 Oct 2023 20:15:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230466AbjJOUPn (ORCPT ); Sun, 15 Oct 2023 16:15:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230467AbjJOUPj (ORCPT ); Sun, 15 Oct 2023 16:15:39 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EEB2D9; Sun, 15 Oct 2023 13:15:37 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-53e2dc8fa02so4978647a12.2; Sun, 15 Oct 2023 13:15:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697400936; x=1698005736; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qh2e0sxZPUbHxzk4qSfOyASeBQgiUPXTS5/RpBzGDJ8=; b=QG3bX8KDkaNhiiMco09vlpY33T7XbLm68u0qMZshfZv70c7cMxruEpprLsmWnsiH3q Q4HmrGJcMMlAa76J7kpfTC9dr31DcGAjjbIFN6X4f7wIG4j/Q9Hxmtow03sC2QQsrDvL JzPSsmDZprVxjCK55EfcHiU3pklqtiReCQrc44rX9Osfc36B49F6UwxqnbWZtS0lBsQs h94EQIR88eijpcM9mBUcM2zKLIu3t4aHlHM9KhinQtfb1JAuqhbJj28DehM5gyeDE0iI j35iby58Oeq5FkCcfidxJ95NO3nQhOZVq/QjkWxFzYdaZRW0PT+hw52dQyu4lWrW3JWf i2+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697400936; x=1698005736; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qh2e0sxZPUbHxzk4qSfOyASeBQgiUPXTS5/RpBzGDJ8=; b=iMGrtnHJsYEEVlUWOArBd1vgStUh56IPFaewWxJI74cOi6g4JP1rNQPE4KxwSs2URb czMO8D3xqFXQW4O/24v71bpxMt747jHVJ/PQ7p52qpbyxhPBaLMsZAXilkaGlTUAqMlT bLCPXVzbuhElU/jhTDi4A9cPPPxG/Ngdpv3kxL9Wri3gUCE228z3CSFQtNaAFIsdiLu6 e3M1fKUd/Zo7hF+4W9U/ySvnO2+18IVGLrn9AogSvF4NDrNypSYlejnAQ9Tru8LMeVjg VKzR9BSy+tWTZxHjVg9J0Z1pu6GataPlmWT5p3TNe4ZAKN14SZw8QjjDhRYKsBh93suX zQXw== X-Gm-Message-State: AOJu0Yxk9QsR9w4b+Ead1Zo5qSPDUptqH8xu2nLyLKowZcJoik/cqTJO IV5z6im+xqakq0XvR291gg== X-Google-Smtp-Source: AGHT+IFqzTsU6PuT+EvGO/BJNuln/2IQzK8j3ikapXlYLlZLg5TqQn6SCwu5v+2ZILaHz6gL/ZAZew== X-Received: by 2002:a17:907:6d2a:b0:9bd:d1e8:57f1 with SMTP id sa42-20020a1709076d2a00b009bdd1e857f1mr5290693ejc.50.1697400935496; Sun, 15 Oct 2023 13:15:35 -0700 (PDT) Received: from dorcaslitunya-virtual-machine.localdomain ([105.163.157.6]) by smtp.gmail.com with ESMTPSA id m10-20020a170906234a00b009ae587ce133sm2721766eja.188.2023.10.15.13.15.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Oct 2023 13:15:35 -0700 (PDT) From: Dorcas AnonoLitunya Cc: anonolitunya@gmail.com, outreachy@lists.linux.dev, Sudip Mukherjee , Teddy Wang , Greg Kroah-Hartman , linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 5/5] Staging: sm750fb: Rename ddk750_setModeTiming Date: Sun, 15 Oct 2023 23:12:38 +0300 Message-ID: X-Mailer: git-send-email 2.42.0.345.gaab89be2eb In-Reply-To: References: MIME-Version: 1.0 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Rename function ddk750_setModeTiming to ddk750_set_mode_timing.This patch affects three files as the function is imported to other external files. Renaming the function ensures snakecase naming convention is followed thus enabling consistent naming style throughout.Issue by checkpatch. Mutes the following checkpatch error: CHECK:Avoid CamelCase: Signed-off-by: Dorcas AnonoLitunya --- drivers/staging/sm750fb/ddk750_mode.c | 2 +- drivers/staging/sm750fb/ddk750_mode.h | 2 +- drivers/staging/sm750fb/sm750_hw.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c index e901855fa9b6..f3f354831617 100644 --- a/drivers/staging/sm750fb/ddk750_mode.c +++ b/drivers/staging/sm750fb/ddk750_mode.c @@ -207,7 +207,7 @@ static int program_mode_registers(struct mode_parameter *mode_param, return ret; } -int ddk750_setModeTiming(struct mode_parameter *parm, enum clock_type clock) +int ddk750_set_mode_timing(struct mode_parameter *parm, enum clock_type clock) { struct pll_value pll; diff --git a/drivers/staging/sm750fb/ddk750_mode.h b/drivers/staging/sm750fb/ddk750_mode.h index 2df78a0937b2..1b70885f85e5 100644 --- a/drivers/staging/sm750fb/ddk750_mode.h +++ b/drivers/staging/sm750fb/ddk750_mode.h @@ -33,5 +33,5 @@ struct mode_parameter { enum spolarity clock_phase_polarity; }; -int ddk750_setModeTiming(struct mode_parameter *parm, enum clock_type clock); +int ddk750_set_mode_timing(struct mode_parameter *parm, enum clock_type clock); #endif diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c index 71247eaf26ee..4bc89218c11c 100644 --- a/drivers/staging/sm750fb/sm750_hw.c +++ b/drivers/staging/sm750fb/sm750_hw.c @@ -305,7 +305,7 @@ int hw_sm750_crtc_setMode(struct lynxfb_crtc *crtc, clock = SECONDARY_PLL; pr_debug("Request pixel clock = %lu\n", modparm.pixel_clock); - ret = ddk750_setModeTiming(&modparm, clock); + ret = ddk750_set_mode_timing(&modparm, clock); if (ret) { pr_err("Set mode timing failed\n"); goto exit;