From patchwork Tue Oct 24 19:40:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Henrie X-Patchwork-Id: 13435217 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 041CE3CD07 for ; Tue, 24 Oct 2023 19:40:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C6SyJxB9" Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 732B710D7 for ; Tue, 24 Oct 2023 12:40:15 -0700 (PDT) Received: by mail-io1-xd34.google.com with SMTP id ca18e2360f4ac-7a69a71cc1dso188280339f.0 for ; Tue, 24 Oct 2023 12:40:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698176414; x=1698781214; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iQPpgnc6iH7M54KsEpKq47ofo2VjroMenjJs2kprUFI=; b=C6SyJxB9rQ7H8B92KH9fXeig100UYCfQozT2elpD3t2tehfVDTMlW6YSOLoT5ksa0B xmNa5/zK3yz21u0yroYdaNaEU6lx0PBIwEc1u39dhNbjbKI6Z/YmR9sMEdsyxhSfLMdA 3rqM7lOSDvZMpSJxEzDZByvSsHfvQ7S0Ff/YSfQ/wI9zrKOKx605ZTnO+RitLIT9dJu9 EMGPBGpRp0UBlLuQ1eDgkbb7SIK8uJXIl3SrGOny8YMT1sp3J2ZFQEon64RFL0E+JY9u UH+eqC78H3COuHTAEhtATL6xD+d1Hc5v5CZ41SBrXjwHTivyDYSfP9PK1lGBkct5/3t6 YtXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698176414; x=1698781214; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iQPpgnc6iH7M54KsEpKq47ofo2VjroMenjJs2kprUFI=; b=Lh+AlN4jx/tLMyM/oJeDHSOoPBl4PctQ8IDTfHBPgKdgX/koEiVoAMpAvx3xUFuEb7 1Y4IzOYjWYIP9Ma9SRUXHBjQogzSZQ7KJOHOUyDvUJdwZODbLxpdX2xtvu+ZXEc1ueDo eObJXwL41lVhsy7OWYY+iRa7mQm7pUIL8ZaZYPqGXOepdozKl1arkccJTUeW5Lb3B3Zd J1WcQkoOlqtloOK1A/Z22RdXC4Q5bQCkxbIHG0o2QKgCM3qGrLK3rGeWvxkF+x3Xklm5 c65g9GMdsaA2WMFydovhlb3shWdnJWqgdSQ3erlbhuKw3uAg/g1Fg7sYRsOI4bIZmeTN asow== X-Gm-Message-State: AOJu0YzenZsDHtofMrJ4S+BHlgUgEk4nVneBRsFl6MR2wenB7+02K+MD ZV9OOjVlR+8XPz7F0QWorJvaG5HTlTE= X-Google-Smtp-Source: AGHT+IE7k+UORsR+zD8bEbwvuibrW3HGR6l9vrRioMECsByYL+6znIy809AaqxJ4XMQAiSpMSm+9Og== X-Received: by 2002:a05:6e02:b2e:b0:34f:9f86:dd45 with SMTP id e14-20020a056e020b2e00b0034f9f86dd45mr17457015ilu.3.1698176414485; Tue, 24 Oct 2023 12:40:14 -0700 (PDT) Received: from localhost.localdomain ([64.77.246.98]) by smtp.gmail.com with ESMTPSA id s7-20020a056e02216700b00357ca1ed25esm2294486ilv.80.2023.10.24.12.40.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 12:40:14 -0700 (PDT) From: Alex Henrie To: netdev@vger.kernel.org, jbohac@suse.cz, benoit.boissinot@ens-lyon.org, davem@davemloft.net, hideaki.yoshifuji@miraclelinux.com, dsahern@kernel.org, pabeni@redhat.com, kuba@kernel.org Cc: Alex Henrie Subject: [PATCH resend 1/4] net: ipv6/addrconf: clamp preferred_lft to the maximum allowed Date: Tue, 24 Oct 2023 13:40:01 -0600 Message-ID: <20231024194010.99995-1-alexhenrie24@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20230829054623.104293-1-alexhenrie24@gmail.com> References: <20230829054623.104293-1-alexhenrie24@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org Without this patch, there is nothing to stop the preferred lifetime of a temporary address from being greater than its valid lifetime. If that was the case, the valid lifetime was effectively ignored. Signed-off-by: Alex Henrie --- net/ipv6/addrconf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 0b6ee962c84e..e51c30d1daff 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -1397,6 +1397,7 @@ static int ipv6_create_tempaddr(struct inet6_ifaddr *ifp, bool block) idev->cnf.temp_valid_lft + age); cfg.preferred_lft = cnf_temp_preferred_lft + age - idev->desync_factor; cfg.preferred_lft = min_t(__u32, ifp->prefered_lft, cfg.preferred_lft); + cfg.preferred_lft = min_t(__u32, cfg.valid_lft, cfg.preferred_lft); cfg.plen = ifp->prefix_len; tmp_tstamp = ifp->tstamp; From patchwork Tue Oct 24 19:40:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Henrie X-Patchwork-Id: 13435220 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BABB3D385 for ; Tue, 24 Oct 2023 19:40:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EJuMqZWA" Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96B4310DE for ; Tue, 24 Oct 2023 12:40:16 -0700 (PDT) Received: by mail-io1-xd30.google.com with SMTP id ca18e2360f4ac-7a94a3b0a49so91295939f.2 for ; Tue, 24 Oct 2023 12:40:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698176415; x=1698781215; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SjMlbDMYFj4B42KI8Ei4iIUEFFGe3IN3vvrI8NnMDjE=; b=EJuMqZWAMtDz8u8/MokJTUsF4tHZBk/Jv5YlDUQXYQnN3W+uSUpvjshKzmey7UlGHi MguyukPt6gCG9y7U10q3cegyC4kVkNklIJ9kJvb9zpz5cf1xWMO1CXn9WktyNSXcUiNa TdOU3OH8BBvck5VonkppgtDq7ItiRzEw/kLEt8Q3zIW0MBa+icUmdT3kLW67cRx+QomT d5y7B3K8CMAOA30m/u3bwOYhzYXaF42Y1QUw/mJQlxYc4zyDPttpThe903HRtcaZ8ayO ER6ITkUtE7/S8YPSYBGslcDLMbUtpZ3Bb/F4D/KC0wh8TnSwom0Lqt6WtZV0eZEwdQJm TC/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698176415; x=1698781215; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SjMlbDMYFj4B42KI8Ei4iIUEFFGe3IN3vvrI8NnMDjE=; b=cv+OuJbuEDQgkT5uNvcgOl3u2lBhxjnKSFBpGxdPoW2l3VIHwZDROTih1U273C1Lz7 tthnRtHCSqzteP8j2jC4sSc+vYhxerxC2NBvFGZBIpdBeLqU79PYhqaU/UMY4vzXKe9q AHWszDwUqKvFzHHWiWuS91uV52UOAcOiZIaOK2gd3qMc5JaN962eOYckuXD8CWuZnMRO xNQUcjtgHivf1v6Fwfy2/enZceVXMBliVTnjZTYgpP6nl/IfSeXLLj2CcYhcfSCX5v1u mmwl3w3CE5CPxctJ49I23KLwrX8BjM9I9cEI6on13q4PJ5kPF/SzK4pNFByR+qyafDJE zODQ== X-Gm-Message-State: AOJu0YxpbkGCMLYOiNRfuZy6GF0dgCRKPY65ozvD51vKfSSKugatu1R3 kAELWtFvmBDhuuN13WD+oLbO7Xp9ROE= X-Google-Smtp-Source: AGHT+IHqhF2xtHWeVrBAXsFWHl85kJut3zUDOfHxDrqtL0fN5xLI2MYKcRmhxN7+FRVFql425+9Tyw== X-Received: by 2002:a92:d691:0:b0:357:71f2:bbb7 with SMTP id p17-20020a92d691000000b0035771f2bbb7mr13363957iln.21.1698176415337; Tue, 24 Oct 2023 12:40:15 -0700 (PDT) Received: from localhost.localdomain ([64.77.246.98]) by smtp.gmail.com with ESMTPSA id s7-20020a056e02216700b00357ca1ed25esm2294486ilv.80.2023.10.24.12.40.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 12:40:14 -0700 (PDT) From: Alex Henrie To: netdev@vger.kernel.org, jbohac@suse.cz, benoit.boissinot@ens-lyon.org, davem@davemloft.net, hideaki.yoshifuji@miraclelinux.com, dsahern@kernel.org, pabeni@redhat.com, kuba@kernel.org Cc: Alex Henrie Subject: [PATCH resend 2/4] net: ipv6/addrconf: clamp preferred_lft to the minimum required Date: Tue, 24 Oct 2023 13:40:02 -0600 Message-ID: <20231024194010.99995-2-alexhenrie24@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231024194010.99995-1-alexhenrie24@gmail.com> References: <20230829054623.104293-1-alexhenrie24@gmail.com> <20231024194010.99995-1-alexhenrie24@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org If the preferred lifetime was less than the minimum required lifetime, ipv6_create_tempaddr would error out without creating any new address. On my machine and network, this error happened immediately with the preferred lifetime set to 1 second, after a few minutes with the preferred lifetime set to 4 seconds, and not at all with the preferred lifetime set to 5 seconds. During my investigation, I found a Stack Exchange post from another person who seems to have had the same problem: They stopped getting new addresses if they lowered the preferred lifetime below 3 seconds, and they didn't really know why. The preferred lifetime is a preference, not a hard requirement. The kernel does not strictly forbid new connections on a deprecated address, nor does it guarantee that the address will be disposed of the instant its total valid lifetime expires. So rather than disable IPv6 privacy extensions altogether if the minimum required lifetime swells above the preferred lifetime, it is more in keeping with the user's intent to increase the temporary address's lifetime to the minimum necessary for the current network conditions. With these fixes, setting the preferred lifetime to 3 or 4 seconds "just works" because the extra fraction of a second is practically unnoticeable. It's even possible to reduce the time before deprecation to 1 or 2 seconds by also disabling duplicate address detection (setting /proc/sys/net/ipv6/conf/*/dad_transmits to 0). I realize that that is a pretty niche use case, but I know at least one person who would gladly sacrifice performance and convenience to be sure that they are getting the maximum possible level of privacy. Link: https://serverfault.com/a/1031168/310447 Signed-off-by: Alex Henrie --- net/ipv6/addrconf.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index e51c30d1daff..a1eec8f09594 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -1405,15 +1405,23 @@ static int ipv6_create_tempaddr(struct inet6_ifaddr *ifp, bool block) write_unlock_bh(&idev->lock); - /* A temporary address is created only if this calculated Preferred - * Lifetime is greater than REGEN_ADVANCE time units. In particular, - * an implementation must not create a temporary address with a zero - * Preferred Lifetime. + /* From RFC 4941: + * + * A temporary address is created only if this calculated Preferred + * Lifetime is greater than REGEN_ADVANCE time units. In + * particular, an implementation must not create a temporary address + * with a zero Preferred Lifetime. + * + * Clamp the preferred lifetime to a minimum of regen_advance, unless + * that would exceed valid_lft. + * * Use age calculation as in addrconf_verify to avoid unnecessary * temporary addresses being generated. */ age = (now - tmp_tstamp + ADDRCONF_TIMER_FUZZ_MINUS) / HZ; - if (cfg.preferred_lft <= regen_advance + age) { + if (cfg.preferred_lft <= regen_advance + age) + cfg.preferred_lft = regen_advance + age + 1; + if (cfg.preferred_lft > cfg.valid_lft) { in6_ifa_put(ifp); in6_dev_put(idev); ret = -1; From patchwork Tue Oct 24 19:40:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Henrie X-Patchwork-Id: 13435219 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0454E3D382 for ; Tue, 24 Oct 2023 19:40:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WEYs3Gcg" Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FC0F10DD for ; Tue, 24 Oct 2023 12:40:17 -0700 (PDT) Received: by mail-il1-x12f.google.com with SMTP id e9e14a558f8ab-357c8dbac0eso11511565ab.2 for ; Tue, 24 Oct 2023 12:40:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698176416; x=1698781216; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=G//uZtGBOL4/v3OESmEgRsB4CqBYA+qMh3xoRKxy/6M=; b=WEYs3GcgR9VPOtG6IBCEokAJxLht+PkhnK8S+RzbmJytAr9OOylp+is09TH3CXmKxq tZrOrEP2heFCGTxRyc8KmpMUfxxn3kGYgTNZQx0eWjhC2V9SlMsLb9m0tI3Cy6JtEJJE Prylv1Tw6FuRmArro5zkfv2Ruhb4DsZgcM3QtgGEcnub1XExmcekSs+lcShMi8PYyYZZ doScgtYmUmIFVRIki3AdGqhs2K4OmDukX0mHkbxkCVD+23Xv+3G8VfkyP3w95a+Yx+7q 5xEVlA1xu/37MOe04m3EZLwLVbNlprlG3W800JvQpvAeq9sqzmbjh/+HhYh1b6EoH+3l QGew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698176416; x=1698781216; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G//uZtGBOL4/v3OESmEgRsB4CqBYA+qMh3xoRKxy/6M=; b=wn/4qzmaU1wO6HdJN8zyh3g+s5KaGHJWOwnblDM7XU+5fssbz7cNvOeynOg5RIlcMt jaDDpM6Ykmn2UVmguBZ/QlYShcGK1rpPTjEQ+U0XBfkqi4OVcL5Uzrp59/+ssDFUMg3Q 4VAWM6crImzaevk+7a69IKh+lDhsGkMJyaJwfGzud+asmiqEUaPqY14qxb9WulLP8mHK V5sLH4FeKhcH7KWPUqLFVheU4z0emy3KZxGlCSyBhL47RLC/fgdfcMpuwRLMkw2QOKeB cUZMSA6c91YJs9FjZtWrr5cNhtTMg/Oe7WUN1BA/mVPrPWvn+XhGU9UtYvlqcaWi1zR7 uJsQ== X-Gm-Message-State: AOJu0YxCpzxLvZaqRQlSwIbyKOZmHNY4SCw+eSozvvNhTRNxfgSI0MLw eetFXoz34UVAxAr/3b6vN9ewqARsNiY= X-Google-Smtp-Source: AGHT+IHDKrDvsd1zzc0Opx0pM4Kg7ZbrygAWUCezyHWalw4PtaYO48iIySIYo+Uhj48R7LjzdKwFag== X-Received: by 2002:a05:6e02:1ba8:b0:351:1d53:c789 with SMTP id n8-20020a056e021ba800b003511d53c789mr18012299ili.8.1698176416353; Tue, 24 Oct 2023 12:40:16 -0700 (PDT) Received: from localhost.localdomain ([64.77.246.98]) by smtp.gmail.com with ESMTPSA id s7-20020a056e02216700b00357ca1ed25esm2294486ilv.80.2023.10.24.12.40.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 12:40:15 -0700 (PDT) From: Alex Henrie To: netdev@vger.kernel.org, jbohac@suse.cz, benoit.boissinot@ens-lyon.org, davem@davemloft.net, hideaki.yoshifuji@miraclelinux.com, dsahern@kernel.org, pabeni@redhat.com, kuba@kernel.org Cc: Alex Henrie Subject: [PATCH resend 3/4] Documentation: networking: explain what happens if temp_valid_lft is too small Date: Tue, 24 Oct 2023 13:40:03 -0600 Message-ID: <20231024194010.99995-3-alexhenrie24@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231024194010.99995-1-alexhenrie24@gmail.com> References: <20230829054623.104293-1-alexhenrie24@gmail.com> <20231024194010.99995-1-alexhenrie24@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org Signed-off-by: Alex Henrie --- Documentation/networking/ip-sysctl.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst index a66054d0763a..f200382858da 100644 --- a/Documentation/networking/ip-sysctl.rst +++ b/Documentation/networking/ip-sysctl.rst @@ -2471,7 +2471,9 @@ use_tempaddr - INTEGER * -1 (for point-to-point devices and loopback devices) temp_valid_lft - INTEGER - valid lifetime (in seconds) for temporary addresses. + valid lifetime (in seconds) for temporary addresses. If less than the + minimum required lifetime (typically 5 seconds), temporary addresses + will not be created. Default: 172800 (2 days) From patchwork Tue Oct 24 19:40:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Henrie X-Patchwork-Id: 13435218 X-Patchwork-Delegate: kuba@kernel.org Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 835073D386 for ; Tue, 24 Oct 2023 19:40:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MQLv97Go" Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D58A10E3 for ; Tue, 24 Oct 2023 12:40:18 -0700 (PDT) Received: by mail-il1-x131.google.com with SMTP id e9e14a558f8ab-357c8dbac0eso11511595ab.2 for ; Tue, 24 Oct 2023 12:40:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698176417; x=1698781217; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cK7HYXOmQjB7hEtR++TIYejmFfYC8wV5bUXlKm+PDXs=; b=MQLv97Gov7YK5Hngw4v6fAyBzQmXyq1w8+mp7F3q7w7uHO/zAvwt60y12RUxViOpmj O+cBBNRXVBTOeuj0dGdmPbxhfqDMtAN7XL4s+0yCSidLO5F51rIIUGKcyMCtXKT2lSMQ rKIBjiAvju9bdCdJuneCPFDGkJMUb2fVVlqIYp5Ls3Ds9IOuqL0ouDGNvmA/UsXp7njJ OLfFBmPClkiUnyUiCgfkbn7IGvsY2TywmwNtRLUkTdB68D1S64729PQK077whO5Vvlaw oxJgtFhujtE8pggE+wT3hykGKAhD6mIec1+Q8sBwHO4/LNVyBsTyhGlwugYr7/lak2rt MK/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698176417; x=1698781217; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cK7HYXOmQjB7hEtR++TIYejmFfYC8wV5bUXlKm+PDXs=; b=QKNV3vdVFNFNh/jCnSUv1iUrYdhkoUM7jTihhsJb3FVjnm29TocMACiowpzYvcqgvK DscRuUbOPoxhQPtQoegLyPprQcxvIbxlGxecUIcUeohfwZtI2RSKmy523bXeEicRVbFx 9V9P0zbAZW05rN54vg6qiNKCkeC2lyjjUEi3ghOvOjgRGPat08lNHgku2mUfSpSsPv9Q RG6iZfZIWFYaGQUE+OnDzqGHYQ72sMaCUhXBxy8c65zxxTC3031B7XarqziYxceVOhn2 LJSs61qYXzjoGtVZq26LRitvBC4O/rrthK23jPjbhpib5zZ6d4vy7MTiUPChW1F0cvPx v3Rg== X-Gm-Message-State: AOJu0YwU+XNxmrWt5wg62SxXP8KAf0ZoOdoZlAXUs7xbKsruZbh1i0iy Q24flrc4l75yFfWs7TrFFnpNnKUk/3k= X-Google-Smtp-Source: AGHT+IFGNEQ3FFAKx5mAokh5oZct5W/vgxXJSCkwCHwOYyZe8c6gyj94BCbNgEi5O103fU3KDlh34A== X-Received: by 2002:a92:2a02:0:b0:357:f3ad:8925 with SMTP id r2-20020a922a02000000b00357f3ad8925mr1177172ile.14.1698176417296; Tue, 24 Oct 2023 12:40:17 -0700 (PDT) Received: from localhost.localdomain ([64.77.246.98]) by smtp.gmail.com with ESMTPSA id s7-20020a056e02216700b00357ca1ed25esm2294486ilv.80.2023.10.24.12.40.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 12:40:16 -0700 (PDT) From: Alex Henrie To: netdev@vger.kernel.org, jbohac@suse.cz, benoit.boissinot@ens-lyon.org, davem@davemloft.net, hideaki.yoshifuji@miraclelinux.com, dsahern@kernel.org, pabeni@redhat.com, kuba@kernel.org Cc: Alex Henrie Subject: [PATCH resend 4/4] Documentation: networking: explain what happens if temp_prefered_lft is too small or too large Date: Tue, 24 Oct 2023 13:40:04 -0600 Message-ID: <20231024194010.99995-4-alexhenrie24@gmail.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231024194010.99995-1-alexhenrie24@gmail.com> References: <20230829054623.104293-1-alexhenrie24@gmail.com> <20231024194010.99995-1-alexhenrie24@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org Signed-off-by: Alex Henrie --- Documentation/networking/ip-sysctl.rst | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst index f200382858da..d919380b1729 100644 --- a/Documentation/networking/ip-sysctl.rst +++ b/Documentation/networking/ip-sysctl.rst @@ -2478,7 +2478,11 @@ temp_valid_lft - INTEGER Default: 172800 (2 days) temp_prefered_lft - INTEGER - Preferred lifetime (in seconds) for temporary addresses. + Preferred lifetime (in seconds) for temporary addresses. If + temp_prefered_lft is less than the minimum required lifetime (typically + 5 seconds), the preferred lifetime is the minimum required. If + temp_prefered_lft is greater than temp_valid_lft, the preferred lifetime + is temp_valid_lft. Default: 86400 (1 day)