From patchwork Tue Oct 24 23:45:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nhat Pham X-Patchwork-Id: 13435345 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD32FC07545 for ; Tue, 24 Oct 2023 23:45:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A4C36B02F0; Tue, 24 Oct 2023 19:45:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 255406B02F5; Tue, 24 Oct 2023 19:45:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11DBF6B02FA; Tue, 24 Oct 2023 19:45:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 017C16B02F0 for ; Tue, 24 Oct 2023 19:45:12 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CBF38160B06 for ; Tue, 24 Oct 2023 23:45:12 +0000 (UTC) X-FDA: 81381988464.02.97F2057 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf20.hostedemail.com (Postfix) with ESMTP id 23D4F1C000A for ; Tue, 24 Oct 2023 23:45:10 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lPHIRt6Z; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698191111; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=+x0VqA3cD4M+ao6grVHPW3xmsMyW1K3p+Nk8uf2CQsI=; b=HiBf2IZJO5WUSww5xHDOQbhx0w8e4AE0xENSLokfZWMfp2Dx1nDAGHauW0HM+WHGp81q5T q0JA8F9IWt1F7ie71fxZ+r/I2ti8z5rDWstZSoUBtBsKp2ZeLYyrcu82zFo5P7+L9m15kl RmRdVqQQ6VE3d5yfTUyyJ0A9duNHPbg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=lPHIRt6Z; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of nphamcs@gmail.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=nphamcs@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698191111; a=rsa-sha256; cv=none; b=jvILVT8DNy8mw3jna5WC4j6JRBDW+xb2zm2F3l7395cULd7qxpHLd8SKBthUjSvqWfwMSA hSauJH9agSsjhVF3bg0GurZshWMrIuFuKLhWG3lzgTTewZSd4S4bKLyogn2xzk0S644bkR rX6MJoRsBncgCxHdHoVHcI7oHBHF8uw= Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6be1bc5aa1cso4893287b3a.3 for ; Tue, 24 Oct 2023 16:45:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698191110; x=1698795910; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+x0VqA3cD4M+ao6grVHPW3xmsMyW1K3p+Nk8uf2CQsI=; b=lPHIRt6Z1bLUto8+j7ppnwj8PB2qOgyUMybzvpQakoI4wf8fUlwY4OF3yoek7H/iFM nz28vPs3kKQ5adqmHPnZ2tgzADxjRjedJgPPKYxfa3+6OvF2ZHCMIiXBStGXLCqBKaZi aMNYeDRQp4fNgjcBug3YFpCyX7MiWC9YZEWxLEaPDI9djwHYvJs3gA5LmV68vHVRfu5Y H6MKYT2bUcUnGch566XS8W7Lx1mqRcVutmbxJc62/VuW11u3jpirzjSSS5L5CnOSfYUg erEPlXFJbHsdgZELmpTi9gqs+FEmmxiTLP/nCGIkcPEq33mkwwH1fVgXv7Yp6vF+8tOu 8A6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698191110; x=1698795910; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+x0VqA3cD4M+ao6grVHPW3xmsMyW1K3p+Nk8uf2CQsI=; b=hgp/g0gtQZdYT/CuoUiInu5FmPK3HAeOPK7MfweDodGtZfNBQEbv+Ro3A9hjR7wXhB nfSbnDWPsJtaYg+Ck/ov2B0woc9G+y2IE9Uj7e6J4mepcasolbPXVbE1MQEmDeuPwv0I 1d8w29J/etY5j/TLRqytE1Ub0iB3U9o786iaMhYNTX4Ti+zTVeYvT5Bsbzkq3AMcwUsw 2zk7Wg8692BMjfiq0OLncNdUeA7pnX0F7iXxKpO5s/uP47clc0iphuaRO2PqPN7qx1Mr 9ThZZ4dLpxrNcrDaJjSftmD04cdte/i8afqOkJUVvWCGqFF5cR3SUdbUwknBo/Ro7eVf Pt5g== X-Gm-Message-State: AOJu0YwFJTJmL/TolzG1MXtdEwypew9fswWCiwmxz6hLz1Bf2jxNJuu7 n8XVDdjH+8TCeGJAkNwxOfE= X-Google-Smtp-Source: AGHT+IG9b7uiwD4opdLGFWcO+BS8gEzyOBmXiwUWx48lzcMpqTQYDgS4zrtFiMvQGqA8/nHWUnmEHw== X-Received: by 2002:a05:6a00:2482:b0:6be:130a:22a0 with SMTP id c2-20020a056a00248200b006be130a22a0mr15986264pfv.14.1698191109799; Tue, 24 Oct 2023 16:45:09 -0700 (PDT) Received: from localhost (fwdproxy-prn-117.fbsv.net. [2a03:2880:ff:75::face:b00c]) by smtp.gmail.com with ESMTPSA id w14-20020aa7954e000000b00686b649cdd0sm8076226pfq.86.2023.10.24.16.45.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 16:45:09 -0700 (PDT) From: Nhat Pham To: akpm@linux-foundation.org Cc: hannes@cmpxchg.org, cerasuolodomenico@gmail.com, yosryahmed@google.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: [PATCH] zswap: export compression failure stats Date: Tue, 24 Oct 2023 16:45:09 -0700 Message-Id: <20231024234509.2680539-1-nphamcs@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Rspam-User: X-Stat-Signature: 11hxidzc35w9crs9srdxez9kgqrwydut X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 23D4F1C000A X-HE-Tag: 1698191110-676049 X-HE-Meta: U2FsdGVkX1+2JtFHWoNdOtNrBJ7aVUADBqDMKY3a4ZZpssN4W18ru6N2aJDYwJ/dhHrrHhIdCxgD5ab0d5W1F4vAA+Wv9NWIAC1rzCV4cwJ52t0I7X0gQbf19jEqaArhqC6SUIcY7X6JQzZeIrf4nOOrAIq/d4PrnARDHJ6VxKp1Tuhe8l+nkoNrVrej4XleAvwXz4VYgehBevJc2x4+WHF3Dw0/B3xgYNo7Fj+BU5OdTnsyL4PjVokQIEmgHAcNnMUE2d87OyKp90Mr5QALSR/1k0SaNF+T8KVejCcI4oJgvrC4lt+O7lAdnaSDVIpi1RuMgyCeAiA4c5ESbIo7bqnzWHH/Vv5chRM8WJ+A46cZZBkvnoLRbasYzt0vchdssAgsD4rh0NjEbd9pS26G7Sg1P6kVW+tS1kTAphMcEaULkx4gEyfrG/c5oNij0oZI0eK1vLBO/2Fcv9QTfc3QUb7mcDG+Fa0RU17D38a3MzexReULae+j8ts63XEJcpu5gcC0WRxqKj4u7AfGv9oOlSCpFeawfyVT2hOTX8VmHPmX98x6hPHw+jEjlWXBSgBBQWsIeFrTMrn2p65jued8+hEE24QmFnZQLlyG5dksRrcTtwKC9F/nyBnfRC3wxWZIddYaIly4KCzwZLHBCZQUsPgpEYzmqkcSAG7xhDnbbKxR9VVbONHqlO93ZcKk0v9cxK++K+fkndH26w4H27I41TV/6KR64rLIobIxzSnr5LdGlUnV040//I2AyUahXE/RGMXReE+lgcN4M2fMUIP5sz+W6hXUsj/kra9MFONqhunORtRIvYEZ2ThsJMgkONChVsD7DnBo/sOfPDw21JGohoucW8uU6Zqf4LUWBebWnQ3Rr3+CjvApl857pLdIaKbVhCNh+/zPVi876qmz360nWjQOIIipgT3PiUrFuYjhUDvKTTSUIEAw5yuhdnYMJbEO8c7IcPXhZznlJTBherz 8T/FkDhF w+XmFYpo3wtQWF6wFnjgCw1sN7hLVdRKQr4Tv4ZHXa+2J3ucTcE9agco405aZHHj50qY+APMhNdE8GPaoHXCYEEF1SgCquArvysrefJNMLWfjv8fznzZa2GLaNZ4J5YKsdm1OqyFPG+0FgDc8Gso6JgG7WrplpNphAqat5UdQiJlj4cTczbtC9CO+KLVr/AiWYRl+NUMiKFracqBppmS+s98mv6adr49AZGLGJDDvnoJ04LGvp6vfvi48yn1B2yM/Cb3gfOW+gotm2U9stJiYJpq0LvTnP7Jlpz6I5u7Pw4WofD51i7rkRferI83bQYR8f9mDxidDolpsyvlajPkRhdDrfU1k6BOhcHI3GnqpsKJr6JF38xMW+ILxjzHBRIF/fzlafIup+B33JWiycAn8l6hgBdqOkzmAEXYdqXr26/s1ctw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000018, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: During a zswap store attempt, the compression algorithm could fail (for e.g due to the page containing incompressible random data). This is not tracked in any of existing zswap counters, making it hard to monitor for and investigate. We have run into this problem several times in our internal investigations on zswap store failures. This patch adds a dedicated debugfs counter for compression algorithm failures. Signed-off-by: Nhat Pham Reviewed-by: Sergey Senozhatsky --- mm/zswap.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/mm/zswap.c b/mm/zswap.c index 37d2b1cb2ecb..e12e76289226 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -61,6 +61,8 @@ static u64 zswap_pool_limit_hit; static u64 zswap_written_back_pages; /* Store failed due to a reclaim failure after pool limit was reached */ static u64 zswap_reject_reclaim_fail; +/* Store failed due to compression algorithm failure */ +static u64 zswap_reject_compress_fail; /* Compressed page was too big for the allocator to (optimally) store */ static u64 zswap_reject_compress_poor; /* Store failed because underlying allocator could not get memory */ @@ -1309,8 +1311,10 @@ bool zswap_store(struct folio *folio) ret = crypto_wait_req(crypto_acomp_compress(acomp_ctx->req), &acomp_ctx->wait); dlen = acomp_ctx->req->dlen; - if (ret) + if (ret) { + zswap_reject_compress_fail++; goto put_dstmem; + } /* store */ zpool = zswap_find_zpool(entry); @@ -1550,6 +1554,8 @@ static int zswap_debugfs_init(void) zswap_debugfs_root, &zswap_reject_alloc_fail); debugfs_create_u64("reject_kmemcache_fail", 0444, zswap_debugfs_root, &zswap_reject_kmemcache_fail); + debugfs_create_u64("reject_compress_fail", 0444, + zswap_debugfs_root, &zswap_reject_compress_fail); debugfs_create_u64("reject_compress_poor", 0444, zswap_debugfs_root, &zswap_reject_compress_poor); debugfs_create_u64("written_back_pages", 0444,