From patchwork Wed Oct 25 13:01:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Serafini X-Patchwork-Id: 13436097 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAD52C0032E for ; Wed, 25 Oct 2023 13:01:50 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.622870.970083 (Exim 4.92) (envelope-from ) id 1qvdVs-0002wG-Nz; Wed, 25 Oct 2023 13:01:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 622870.970083; Wed, 25 Oct 2023 13:01:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qvdVs-0002w9-LP; Wed, 25 Oct 2023 13:01:32 +0000 Received: by outflank-mailman (input) for mailman id 622870; Wed, 25 Oct 2023 13:01:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qvdVr-0002w3-IN for xen-devel@lists.xenproject.org; Wed, 25 Oct 2023 13:01:31 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9cc92e05-7336-11ee-9b0e-b553b5be7939; Wed, 25 Oct 2023 15:01:29 +0200 (CEST) Received: from Dell.home-life.hub (unknown [151.29.134.109]) by support.bugseng.com (Postfix) with ESMTPSA id 755E74EE073A; Wed, 25 Oct 2023 15:01:28 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9cc92e05-7336-11ee-9b0e-b553b5be7939 From: Federico Serafini To: xen-devel@lists.xenproject.org Cc: consulting@bugseng.com, Federico Serafini , Jan Beulich , Andrew Cooper Subject: [XEN PATCH v2] x86/iommu_init: address a violation of MISRA C:2012 Rule 8.3 Date: Wed, 25 Oct 2023 15:01:22 +0200 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Make function definition and declaration consistent and emphasize that the formal parameter is deliberately not used. No functional change. Signed-off-by: Federico Serafini --- Changes in v2: - improved code format. --- xen/drivers/passthrough/amd/iommu_init.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/amd/iommu_init.c b/xen/drivers/passthrough/amd/iommu_init.c index 9c01a49435..9f955743e1 100644 --- a/xen/drivers/passthrough/amd/iommu_init.c +++ b/xen/drivers/passthrough/amd/iommu_init.c @@ -692,7 +692,7 @@ static void iommu_check_ppr_log(struct amd_iommu *iommu) spin_unlock_irqrestore(&iommu->lock, flags); } -static void cf_check do_amd_iommu_irq(void *unused) +static void cf_check do_amd_iommu_irq(void *data) { struct amd_iommu *iommu; @@ -702,6 +702,9 @@ static void cf_check do_amd_iommu_irq(void *unused) return; } + /* Formal parameter is deliberately unused. */ + (void)data; + /* * No matter from where the interrupt came from, check all the * IOMMUs present in the system. This allows for having just one