From patchwork Mon Oct 30 05:20:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernd Edlinger X-Patchwork-Id: 13440002 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00CD4C4167D for ; Mon, 30 Oct 2023 05:20:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6440F6B0182; Mon, 30 Oct 2023 01:20:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F4106B0183; Mon, 30 Oct 2023 01:20:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46CB56B0184; Mon, 30 Oct 2023 01:20:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 35C3E6B0182 for ; Mon, 30 Oct 2023 01:20:48 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 040BF1A025F for ; Mon, 30 Oct 2023 05:20:47 +0000 (UTC) X-FDA: 81400978176.16.191C44D Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2047.outbound.protection.outlook.com [40.92.89.47]) by imf27.hostedemail.com (Postfix) with ESMTP id 2888540002 for ; Mon, 30 Oct 2023 05:20:44 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of bernd.edlinger@hotmail.de designates 40.92.89.47 as permitted sender) smtp.mailfrom=bernd.edlinger@hotmail.de; dmarc=pass (policy=none) header.from=hotmail.de; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698643245; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gFQ6SUWoRtb1QCrUsYGC9VhNKNQd/LjfvED3AKRgEk0=; b=NgeztsM16L8miDKmAD1j02zq4CTY+mzm36Sx7PpGjy9CiBM3/EurGVJHBcDpoCIfrgA+3V 1SQpcBBlMar/MAkk/T79VBLEsW+cWbpjgt/ClzY2x7IwaTFmYq/lzJ08dy8b380R7qqc25 da1oEabumsQ4UY2XpDn3Fkg2Gx0lOzg= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1698643245; a=rsa-sha256; cv=pass; b=VjgwDC2b2Q41LgSUqYBdU0ZSG3VUeewsrCEVQYq8WlgsDrXyYvB+JvFwbaJWYQ2vumtiZL hIrO1LmiUv/M+dvDJnCHjiODuwpMa/9sGyLs/Vw2WTKYoy/FOKT4jAsPJsVgULtjB9T1/f O6IHS3ew89ZT10ImdybCjHZKN82DqA4= ARC-Authentication-Results: i=2; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of bernd.edlinger@hotmail.de designates 40.92.89.47 as permitted sender) smtp.mailfrom=bernd.edlinger@hotmail.de; dmarc=pass (policy=none) header.from=hotmail.de; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pkpj1QqPCZRUDj1Vj9GhFAVaNOosWjQxYMQ3qwV1Ywv5I9Ix+eHWY14gIRGHqoC9Dv82d2vgfx0FHto6VVruE35dq8RSJJR/QDSMNLiuhO48aIiePS6nrtrYE5LfdyD0gTuq6M1prz6gTaM+3PWnBE4tYRFG74wHJ7cmL1VPZlM1X3TGDoYBgPqDUsbzqmXZtrSuxTLxPQWKjd9quh/PLy6eAeDSKc+E52WnmUaT+QU5QPWUaXeIUqH9QA/jYX3/8FrQ6/Lpqg+aDPc/q4rSbLwwfiPK2UCIPgf2DKqS4MzajQZxskNZSOdiXSOnUJJIRPkhdJf7yZSimelMaPrD5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gFQ6SUWoRtb1QCrUsYGC9VhNKNQd/LjfvED3AKRgEk0=; b=WtgbkrP3WZ70baVzf7SXotsicbzwfP1q0iK+7mEVyBdYDHhSJH11iRI6aaaQ+JkQ5wkylShjQe+gquAvoGUxl0tdPtXSzmRIAqxiGaK0blxcWe68x9GOIqU8F09WR4oeVR+mCTKUdYas2W9ePqccvjufmv/DtAwEa5FNGEXFhfWnrch43i3T1oXmGeEDVNIZqN7zHmFYYuo7tCsZJAH5yy3pB6qdBxPasaQvUn/vFq2h0xBXDmW173fza5X2jAnNORa9OZnQ+3aCE8LkdUqcVfrzou8zESWkTM6FlApQIPt2QgqS+ajZSqKuewoGROdfCf+8gevTkuSAlU6WXUaLuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from AS8P193MB1285.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:333::21) by AS8P193MB1606.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:39f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.27; Mon, 30 Oct 2023 05:20:42 +0000 Received: from AS8P193MB1285.EURP193.PROD.OUTLOOK.COM ([fe80::b89e:5e18:1a08:409d]) by AS8P193MB1285.EURP193.PROD.OUTLOOK.COM ([fe80::b89e:5e18:1a08:409d%6]) with mapi id 15.20.6933.027; Mon, 30 Oct 2023 05:20:42 +0000 Message-ID: Date: Mon, 30 Oct 2023 06:20:51 +0100 User-Agent: Mozilla Thunderbird Subject: [PATCH v12] exec: Fix dead-lock in de_thread with ptrace_attach From: Bernd Edlinger To: Alexander Viro , Alexey Dobriyan , Oleg Nesterov , Kees Cook , Andy Lutomirski , Will Drewry , Christian Brauner , Andrew Morton , Michal Hocko , Serge Hallyn , James Morris , Randy Dunlap , Suren Baghdasaryan , YiFei Zhu , Yafang Shao , Helge Deller , "Eric W. Biederman" , Adrian Reber , Thomas Gleixner , Jens Axboe , Alexei Starovoitov , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-kselftest@vger.kernel.org, linux-mm@kvack.org, tiozhang , Luis Chamberlain , "Paulo Alcantara (SUSE)" , Sergey Senozhatsky , Frederic Weisbecker , YueHaibing , Paul Moore , Aleksa Sarai , Stefan Roesch , Chao Yu , xu xin , Jeff Layton , Jan Kara , David Hildenbrand , Dave Chinner , Shuah Khan , Zheng Yejian References: Content-Language: en-US In-Reply-To: X-TMN: [M6UUeJHu0Zej9vCxa5AMPrUq6jF464P1RxnK7JM5faY4p/9sANXi9ArfRA2SQfi+] X-ClientProxiedBy: FR4P281CA0144.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:b8::20) To AS8P193MB1285.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:333::21) X-Microsoft-Original-Message-ID: <4022bbc4-4c4d-43d5-ae50-80aa9d9ecd12@hotmail.de> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8P193MB1285:EE_|AS8P193MB1606:EE_ X-MS-Office365-Filtering-Correlation-Id: fd3a8721-537b-4faf-633c-08dbd907f5c2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L5fcoESXHgAxgYbnth3HJIjo2svo1xI3WgOs+3vd8TdkK2yZ9lmSWEi/AN3X9baBAXfDCqvxXXvGywk/qlq0IUa8CdHR44+bM6Z04KBRDHH0+hjEAtTagLxCRvjVIdPvbXJRVRcH1+EcSJAh1pDmqG/KcLhxZQHWt+prChbplDSM3TkkSe3gbQzfkb614fhPRUW9SzxlysUiuBnGGYtquw/9NOixqgAiY+JpF0ZL8kAf7S3BEQkIDeWczRom1rB+0catnqcmzjddyK0pGtDJQQKojJNKWOp9+nRwUgzcdvWaMxCz3xSBgc89Yww+rqt1cbvH944IuVDQhjlwcn4hUEnmGNHKjyHxNB30TzmpmY0jEBiu+dzTwh+tfcRLxAQzOhuS7sL5fOdq3vaz/eU6OBj8vu9fDGT8vJWBmndUhIiLkoa2G87QcTSk9tzXi6UZ8Rx8EJLItqnI9Ev8LvSIiCdJ7qcnmLgfj8Xl2brB1hfcOSRfcAbxBSraA+Klk90goFqBYwxPISFNsBTHm8PaOu9aaxrwweNk8Xh9WoxCvv80syXclXNuqd1tiZ7V79gCoOdg5RMYvnhKpAkmmWgTDt5L8k/g2NzphNp1dmTuLoU= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?IgiaqBZ/Zke9zjI6reivS5hYJswg?= =?utf-8?q?SATarTTjePBl7/JVIQY08sLyczQGS6e6fosKZa82jwKcJYK15HHjT8u+Jkiuf66oN?= =?utf-8?q?2xWfFFXBxX7LQhhlFObwU6ulCsjPk6cQvbLfypzGJu/nfQX0euAoFMnGUorE1sUJE?= =?utf-8?q?j6q4z/wkchzDqUUpZpj6sQ1hkiTb/EldSOUkURu8AkN+tQUNDhbsVKkbU99B2uHeh?= =?utf-8?q?Qt25HPU7FzzDIdKETkMXOl9u8UaKWH3Bm3y0NVVbi76FQZNq2qoOsb1H/6QXVexSe?= =?utf-8?q?uZg27R54v0vPm8XhB1SrEZvuE8QQiXHeaaktCNQ1/FiRblvfufEo61n4Cd3RknMzv?= =?utf-8?q?pHXo5huk1lGm48YdIS2opQL91cL31ynl1JVysahJu/u45fb2JXbhhmhuU3JtHWdDX?= =?utf-8?q?wlnxIVhWOH021KYeGerpbHZ65UCAlp7SIJAphqEx60KqXvNr7zKP1sfF+Z2LdkrmN?= =?utf-8?q?gCwI05EAALdvnTsTaQChRW3LqZ6hZgtnYyYq8aCSf7fI6JmV9A+3AWtADGQMYTHP2?= =?utf-8?q?uiPWPFezWZobocfH22hlyYSP0/29QrbawQLpJUDonfgXeJt5oBFK9pNvS9LTyFbt/?= =?utf-8?q?NLwmsCcqjlice4p/BOa8mXv/JRB3E3WXH5QvUBUujDsqaOh4P7Dqm8iNgXffAYFzH?= =?utf-8?q?W20KeBBO40HxENv5RR0IR4mHNdK5PukyGCW9D+pI9ET9PIEU+DStqmUjwsRbI6GAD?= =?utf-8?q?Y05c7VQxtkRxkZqPA3G/a78UUgmGtEADWDUgklfIJCyIOlZFdJqzaEjL5hWYsAPsy?= =?utf-8?q?y6lV/LkghQ4OB5F1tf8h/sJGBITZDb346PvwSiZGKKxOhIu2dF3wekzzIdTrF0Lg7?= =?utf-8?q?4uZI8gsjX/ovq5tUqd1NKKSnBnMeXwR7EYesErUNIosbysaQFn0AyHEpJLIlPd4Rm?= =?utf-8?q?BbXkawz+3/CynFcARsFKXV1I61JbwMKwsFsbLK3XdytT4nux3jcglGwITXDlWe543?= =?utf-8?q?+vFgGHwZnkDDIwaG6rVzprUeY9iffhyNDzsRVdQqbJd4nKHVX9z/Ki97ssdggaxpP?= =?utf-8?q?tiPtuxeSbcDc4zaI6pP0J1rQpBM8tr+JT7+GUkiTqF9rERzrkCqIOOgQQDXyj2Cr6?= =?utf-8?q?T9Nb4oRtcv7/AVL5+Bf0WPiWN+dZTEhzEGfLSo3BL3crFCX87qlCxaUTI2zVdGslI?= =?utf-8?q?TjjB2H17xaicTkO1JJoKLwhg0qpyHwyEUOUdDCIUm4Hl8tPrJGOL5L/XlX3IxIZsB?= =?utf-8?q?VZLIVRbFnGR14yn82Gqa2vVPB0na8auNkXibB1A630WsCVodipmTGTssWmTg=3D?= X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-80ceb.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: fd3a8721-537b-4faf-633c-08dbd907f5c2 X-MS-Exchange-CrossTenant-AuthSource: AS8P193MB1285.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2023 05:20:41.8858 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8P193MB1606 X-Rspamd-Queue-Id: 2888540002 X-Rspam-User: X-Stat-Signature: 3a5osxe6ggmj9i3andfgx5sop9kqky4s X-Rspamd-Server: rspam03 X-HE-Tag: 1698643244-73529 X-HE-Meta: U2FsdGVkX184wlFr59j/qqL6OSWk7iqHrcgIoc7cOTLLpKaCgRJUhG+8H1yct/6H//3h9drjdGgF8/MU6CbqM4GOP2pu8y5U5osi7f/ehMlR8QhkeBInuILEddGZ3KqqbtB/BLMFwALC6EUA3gdUOsD14B3EUgl5LxCDu+R+DrhXDdkvN/khMJvluwL+vKt7YfH4yHDiwP/O2dBw6hMgijd/Wbom+Xg0ifA0EgrVU5HUuJSNL2wI0kLfaQxwtYLFoyIbEWj3a3J+t/uoYT5rvJbgxvW/wI13g4pQZTQ40QRxG9BCaC5WIZwYXYtz0BwBfeOCY4VryP/UPgxrmVhxATegjaVOcN87YlEBgAkOyJyXfGzgfewRsEXvpZUFoTtwdJoimTpzxTEsEkARTb0d0YdTIPW3LWCYCGo0FQUAsCzQydm01c3F3JQyJY85WUEL4oI0heZrUzOzl1fSvHePfct2fDZ721J9wBtpWOsrXfINma4h09htZgvDmM8tGPaJTVRnWbQui4PwAu/6WahUcovbzFw4Pt/il2w7KWm0WyUaPwuicNitqmGdd3VY+yxjJSCx9ZnAA2e5L6PEsOPFg7qmA1GELkGieKKIiLeyK23rwS/b9ay4qhTG42akoy18xnh+sg3nahMN7lymsGiFN+J064H1R4SYYu5t/dIDaikwsghyy54YCKM6Y6TpyA1QqTv/y8N9dqNAW8cJEelyseHpobcWWjhN+IVttfDGR9SWerwxxr75rqtJJHLzqtlqWtGIFku0x8/RKz9TPz3G4W5bF4xQjC47K34/FFKap/37s5QwS6+pDS3+e7RxczT88ZyjwPL0KLQGOvOs4JaJBZfHkLvHcv01zPdw8xzT4o/h/YoDYH+zo2r0u45ijQUEzy9lTcbmfgtEBCJYsCo4IbsuOIR1RNeLE5uZtvq6ACZKpcm0IxPVKLw2LeHIxkOTuY4nIGFoGVTCHg9RNI6 prw/8dao cntN2/wRKh1cKa5a2p8oh4Zf6AkQpxER9rB8rJdjgVNHILxP3uTNLszmxelGmaT19ymmm/flhivbHaEEUzNeIx2kUjyS9f2N+Hoh8RxwCinii5Pv7caHgWBH/cRuA99udwj92qYb0WkRLsKm/IY+6lL20bxJqjn1GzCa7VttfkjVg73e1FbxIZ9RGRvTVZlx4NzUfwscQD6mbp8hJhKV6WWef60ngJaRs58sa7Br8OasU24q/dmUaf3dHiPQ9U4ZA2ujRajpkU99loQ5sCycNh5ooh6AVvVqXDNIS/nfe1caRRMFcTGym5PJmmzFG3E3SUJkcoKvYUMTwGaX2ZGYhsgEDv/pnD5SPqAfrGuLRL1WSQEypIilwKncXU1OnC44JWxpipe1PGShF0XdnlKcqaYESRqziTunV3Wsc2CcteZIAAJOTs3goVBc95641UCpEhH4N11g7cznSk+0x+/vt/sH1autEhRLTNRLs+IPl0BFQ3PvTml2sYc+ASzLGTkyZSQOakpP03pZdWoRgDbmDMitJl1nx0Gbnfv+b/iq55+yZnKwmEj1XJvx0TU+I+Ml73eK8i4176pzoQZHXHFBu3mUhCdA2L+gPlE4k X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This introduces signal->exec_bprm, which is used to fix the case when at least one of the sibling threads is traced, and therefore the trace process may dead-lock in ptrace_attach, but de_thread will need to wait for the tracer to continue execution. The solution is to detect this situation and allow ptrace_attach to continue by temporarily releasing the cred_guard_mutex, while de_thread() is still waiting for traced zombies to be eventually released by the tracer. In the case of the thread group leader we only have to wait for the thread to become a zombie, which may also need co-operation from the tracer due to PTRACE_O_TRACEEXIT. When a tracer wants to ptrace_attach a task that already is in execve, we simply retry the ptrace_may_access check while temporarily installing the new credentials and dumpability which are about to be used after execve completes. If the ptrace_attach happens on a thread that is a sibling-thread of the thread doing execve, it is sufficient to check against the old credentials, as this thread will be waited for, before the new credentials are installed. Other threads die quickly since the cred_guard_mutex is released, but a deadly signal is already pending. In case the mutex_lock_killable misses the signal, the non-zero current->signal->exec_bprm makes sure they release the mutex immediately and return with -ERESTARTNOINTR. This means there is no API change, unlike the previous version of this patch which was discussed here: https://lore.kernel.org/lkml/b6537ae6-31b1-5c50-f32b-8b8332ace882@hotmail.de/ See tools/testing/selftests/ptrace/vmaccess.c for a test case that gets fixed by this change. Note that since the test case was originally designed to test the ptrace_attach returning an error in this situation, the test expectation needed to be adjusted, to allow the API to succeed at the first attempt. Signed-off-by: Bernd Edlinger --- fs/exec.c | 69 ++++++++++++++++------- fs/proc/base.c | 6 ++ include/linux/cred.h | 1 + include/linux/sched/signal.h | 18 ++++++ kernel/cred.c | 28 +++++++-- kernel/ptrace.c | 32 +++++++++++ kernel/seccomp.c | 12 +++- tools/testing/selftests/ptrace/vmaccess.c | 23 +++++--- 8 files changed, 155 insertions(+), 34 deletions(-) v10: Changes to previous version, make the PTRACE_ATTACH retun -EAGAIN, instead of execve return -ERESTARTSYS. Added some lessions learned to the description. v11: Check old and new credentials in PTRACE_ATTACH again without changing the API. Note: I got actually one response from an automatic checker to the v11 patch, https://lore.kernel.org/lkml/202107121344.wu68hEPF-lkp@intel.com/ which is complaining about: >> kernel/ptrace.c:425:26: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct cred const *old_cred @@ got struct cred const [noderef] __rcu *real_cred @@ 417 struct linux_binprm *bprm = task->signal->exec_bprm; 418 const struct cred *old_cred; 419 struct mm_struct *old_mm; 420 421 retval = down_write_killable(&task->signal->exec_update_lock); 422 if (retval) 423 goto unlock_creds; 424 task_lock(task); > 425 old_cred = task->real_cred; v12: Essentially identical to v11. - Fixed a minor merge conflict in linux v5.17, and fixed the above mentioned nit by adding __rcu to the declaration. - re-tested the patch with all linux versions from v5.11 to v6.6 v10 was an alternative approach which did imply an API change. But I would prefer to avoid such an API change. The difficult part is getting the right dumpability flags assigned before de_thread starts, hope you like this version. If not, the v10 is of course also acceptable. Thanks Bernd. diff --git a/fs/exec.c b/fs/exec.c index 2f2b0acec4f0..902d3b230485 100644 --- a/fs/exec.c +++ b/fs/exec.c @@ -1041,11 +1041,13 @@ static int exec_mmap(struct mm_struct *mm) return 0; } -static int de_thread(struct task_struct *tsk) +static int de_thread(struct task_struct *tsk, struct linux_binprm *bprm) { struct signal_struct *sig = tsk->signal; struct sighand_struct *oldsighand = tsk->sighand; spinlock_t *lock = &oldsighand->siglock; + struct task_struct *t = tsk; + bool unsafe_execve_in_progress = false; if (thread_group_empty(tsk)) goto no_thread_group; @@ -1068,6 +1070,19 @@ static int de_thread(struct task_struct *tsk) if (!thread_group_leader(tsk)) sig->notify_count--; + while_each_thread(tsk, t) { + if (unlikely(t->ptrace) + && (t != tsk->group_leader || !t->exit_state)) + unsafe_execve_in_progress = true; + } + + if (unlikely(unsafe_execve_in_progress)) { + spin_unlock_irq(lock); + sig->exec_bprm = bprm; + mutex_unlock(&sig->cred_guard_mutex); + spin_lock_irq(lock); + } + while (sig->notify_count) { __set_current_state(TASK_KILLABLE); spin_unlock_irq(lock); @@ -1158,6 +1173,11 @@ static int de_thread(struct task_struct *tsk) release_task(leader); } + if (unlikely(unsafe_execve_in_progress)) { + mutex_lock(&sig->cred_guard_mutex); + sig->exec_bprm = NULL; + } + sig->group_exec_task = NULL; sig->notify_count = 0; @@ -1169,6 +1189,11 @@ static int de_thread(struct task_struct *tsk) return 0; killed: + if (unlikely(unsafe_execve_in_progress)) { + mutex_lock(&sig->cred_guard_mutex); + sig->exec_bprm = NULL; + } + /* protects against exit_notify() and __exit_signal() */ read_lock(&tasklist_lock); sig->group_exec_task = NULL; @@ -1253,6 +1278,24 @@ int begin_new_exec(struct linux_binprm * bprm) if (retval) return retval; + /* If the binary is not readable then enforce mm->dumpable=0 */ + would_dump(bprm, bprm->file); + if (bprm->have_execfd) + would_dump(bprm, bprm->executable); + + /* + * Figure out dumpability. Note that this checking only of current + * is wrong, but userspace depends on it. This should be testing + * bprm->secureexec instead. + */ + if (bprm->interp_flags & BINPRM_FLAGS_ENFORCE_NONDUMP || + is_dumpability_changed(current_cred(), bprm->cred) || + !(uid_eq(current_euid(), current_uid()) && + gid_eq(current_egid(), current_gid()))) + set_dumpable(bprm->mm, suid_dumpable); + else + set_dumpable(bprm->mm, SUID_DUMP_USER); + /* * Ensure all future errors are fatal. */ @@ -1261,7 +1304,7 @@ int begin_new_exec(struct linux_binprm * bprm) /* * Make this the only thread in the thread group. */ - retval = de_thread(me); + retval = de_thread(me, bprm); if (retval) goto out; @@ -1284,11 +1327,6 @@ int begin_new_exec(struct linux_binprm * bprm) if (retval) goto out; - /* If the binary is not readable then enforce mm->dumpable=0 */ - would_dump(bprm, bprm->file); - if (bprm->have_execfd) - would_dump(bprm, bprm->executable); - /* * Release all of the old mmap stuff */ @@ -1350,18 +1388,6 @@ int begin_new_exec(struct linux_binprm * bprm) me->sas_ss_sp = me->sas_ss_size = 0; - /* - * Figure out dumpability. Note that this checking only of current - * is wrong, but userspace depends on it. This should be testing - * bprm->secureexec instead. - */ - if (bprm->interp_flags & BINPRM_FLAGS_ENFORCE_NONDUMP || - !(uid_eq(current_euid(), current_uid()) && - gid_eq(current_egid(), current_gid()))) - set_dumpable(current->mm, suid_dumpable); - else - set_dumpable(current->mm, SUID_DUMP_USER); - perf_event_exec(); __set_task_comm(me, kbasename(bprm->filename), true); @@ -1480,6 +1506,11 @@ static int prepare_bprm_creds(struct linux_binprm *bprm) if (mutex_lock_interruptible(¤t->signal->cred_guard_mutex)) return -ERESTARTNOINTR; + if (unlikely(current->signal->exec_bprm)) { + mutex_unlock(¤t->signal->cred_guard_mutex); + return -ERESTARTNOINTR; + } + bprm->cred = prepare_exec_creds(); if (likely(bprm->cred)) return 0; diff --git a/fs/proc/base.c b/fs/proc/base.c index ffd54617c354..0da9adfadb48 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -2788,6 +2788,12 @@ static ssize_t proc_pid_attr_write(struct file * file, const char __user * buf, if (rv < 0) goto out_free; + if (unlikely(current->signal->exec_bprm)) { + mutex_unlock(¤t->signal->cred_guard_mutex); + rv = -ERESTARTNOINTR; + goto out_free; + } + rv = security_setprocattr(PROC_I(inode)->op.lsm, file->f_path.dentry->d_name.name, page, count); diff --git a/include/linux/cred.h b/include/linux/cred.h index f923528d5cc4..b01e309f5686 100644 --- a/include/linux/cred.h +++ b/include/linux/cred.h @@ -159,6 +159,7 @@ extern const struct cred *get_task_cred(struct task_struct *); extern struct cred *cred_alloc_blank(void); extern struct cred *prepare_creds(void); extern struct cred *prepare_exec_creds(void); +extern bool is_dumpability_changed(const struct cred *, const struct cred *); extern int commit_creds(struct cred *); extern void abort_creds(struct cred *); extern const struct cred *override_creds(const struct cred *); diff --git a/include/linux/sched/signal.h b/include/linux/sched/signal.h index 0014d3adaf84..14df7073a0a8 100644 --- a/include/linux/sched/signal.h +++ b/include/linux/sched/signal.h @@ -234,9 +234,27 @@ struct signal_struct { struct mm_struct *oom_mm; /* recorded mm when the thread group got * killed by the oom killer */ + struct linux_binprm *exec_bprm; /* Used to check ptrace_may_access + * against new credentials while + * de_thread is waiting for other + * traced threads to terminate. + * Set while de_thread is executing. + * The cred_guard_mutex is released + * after de_thread() has called + * zap_other_threads(), therefore + * a fatal signal is guaranteed to be + * already pending in the unlikely + * event, that + * current->signal->exec_bprm happens + * to be non-zero after the + * cred_guard_mutex was acquired. + */ + struct mutex cred_guard_mutex; /* guard against foreign influences on * credential calculations * (notably. ptrace) + * Held while execve runs, except when + * a sibling thread is being traced. * Deprecated do not use in new code. * Use exec_update_lock instead. */ diff --git a/kernel/cred.c b/kernel/cred.c index 98cb4eca23fb..586cb6c7cf6b 100644 --- a/kernel/cred.c +++ b/kernel/cred.c @@ -433,6 +433,28 @@ static bool cred_cap_issubset(const struct cred *set, const struct cred *subset) return false; } +/** + * is_dumpability_changed - Will changing creds from old to new + * affect the dumpability in commit_creds? + * + * Return: false - dumpability will not be changed in commit_creds. + * Return: true - dumpability will be changed to non-dumpable. + * + * @old: The old credentials + * @new: The new credentials + */ +bool is_dumpability_changed(const struct cred *old, const struct cred *new) +{ + if (!uid_eq(old->euid, new->euid) || + !gid_eq(old->egid, new->egid) || + !uid_eq(old->fsuid, new->fsuid) || + !gid_eq(old->fsgid, new->fsgid) || + !cred_cap_issubset(old, new)) + return true; + + return false; +} + /** * commit_creds - Install new credentials upon the current task * @new: The credentials to be assigned @@ -467,11 +489,7 @@ int commit_creds(struct cred *new) get_cred(new); /* we will require a ref for the subj creds too */ /* dumpability changes */ - if (!uid_eq(old->euid, new->euid) || - !gid_eq(old->egid, new->egid) || - !uid_eq(old->fsuid, new->fsuid) || - !gid_eq(old->fsgid, new->fsgid) || - !cred_cap_issubset(old, new)) { + if (is_dumpability_changed(old, new)) { if (task->mm) set_dumpable(task->mm, suid_dumpable); task->pdeath_signal = 0; diff --git a/kernel/ptrace.c b/kernel/ptrace.c index 443057bee87c..eb1c450bb7d7 100644 --- a/kernel/ptrace.c +++ b/kernel/ptrace.c @@ -20,6 +20,7 @@ #include #include #include +#include #include #include #include @@ -435,6 +436,28 @@ static int ptrace_attach(struct task_struct *task, long request, if (retval) goto unlock_creds; + if (unlikely(task->in_execve)) { + struct linux_binprm *bprm = task->signal->exec_bprm; + const struct cred __rcu *old_cred; + struct mm_struct *old_mm; + + retval = down_write_killable(&task->signal->exec_update_lock); + if (retval) + goto unlock_creds; + task_lock(task); + old_cred = task->real_cred; + old_mm = task->mm; + rcu_assign_pointer(task->real_cred, bprm->cred); + task->mm = bprm->mm; + retval = __ptrace_may_access(task, PTRACE_MODE_ATTACH_REALCREDS); + rcu_assign_pointer(task->real_cred, old_cred); + task->mm = old_mm; + task_unlock(task); + up_write(&task->signal->exec_update_lock); + if (retval) + goto unlock_creds; + } + write_lock_irq(&tasklist_lock); retval = -EPERM; if (unlikely(task->exit_state)) @@ -508,6 +531,14 @@ static int ptrace_traceme(void) { int ret = -EPERM; + if (mutex_lock_interruptible(¤t->signal->cred_guard_mutex)) + return -ERESTARTNOINTR; + + if (unlikely(current->signal->exec_bprm)) { + mutex_unlock(¤t->signal->cred_guard_mutex); + return -ERESTARTNOINTR; + } + write_lock_irq(&tasklist_lock); /* Are we already being traced? */ if (!current->ptrace) { @@ -523,6 +554,7 @@ static int ptrace_traceme(void) } } write_unlock_irq(&tasklist_lock); + mutex_unlock(¤t->signal->cred_guard_mutex); return ret; } diff --git a/kernel/seccomp.c b/kernel/seccomp.c index 255999ba9190..b29bbfa0b044 100644 --- a/kernel/seccomp.c +++ b/kernel/seccomp.c @@ -1955,9 +1955,15 @@ static long seccomp_set_mode_filter(unsigned int flags, * Make sure we cannot change seccomp or nnp state via TSYNC * while another thread is in the middle of calling exec. */ - if (flags & SECCOMP_FILTER_FLAG_TSYNC && - mutex_lock_killable(¤t->signal->cred_guard_mutex)) - goto out_put_fd; + if (flags & SECCOMP_FILTER_FLAG_TSYNC) { + if (mutex_lock_killable(¤t->signal->cred_guard_mutex)) + goto out_put_fd; + + if (unlikely(current->signal->exec_bprm)) { + mutex_unlock(¤t->signal->cred_guard_mutex); + goto out_put_fd; + } + } spin_lock_irq(¤t->sighand->siglock); diff --git a/tools/testing/selftests/ptrace/vmaccess.c b/tools/testing/selftests/ptrace/vmaccess.c index 4db327b44586..3b7d81fb99bb 100644 --- a/tools/testing/selftests/ptrace/vmaccess.c +++ b/tools/testing/selftests/ptrace/vmaccess.c @@ -39,8 +39,15 @@ TEST(vmaccess) f = open(mm, O_RDONLY); ASSERT_GE(f, 0); close(f); - f = kill(pid, SIGCONT); - ASSERT_EQ(f, 0); + f = waitpid(-1, NULL, 0); + ASSERT_NE(f, -1); + ASSERT_NE(f, 0); + ASSERT_NE(f, pid); + f = waitpid(-1, NULL, 0); + ASSERT_EQ(f, pid); + f = waitpid(-1, NULL, 0); + ASSERT_EQ(f, -1); + ASSERT_EQ(errno, ECHILD); } TEST(attach) @@ -57,22 +64,24 @@ TEST(attach) sleep(1); k = ptrace(PTRACE_ATTACH, pid, 0L, 0L); - ASSERT_EQ(errno, EAGAIN); - ASSERT_EQ(k, -1); + ASSERT_EQ(k, 0); k = waitpid(-1, &s, WNOHANG); ASSERT_NE(k, -1); ASSERT_NE(k, 0); ASSERT_NE(k, pid); ASSERT_EQ(WIFEXITED(s), 1); ASSERT_EQ(WEXITSTATUS(s), 0); - sleep(1); - k = ptrace(PTRACE_ATTACH, pid, 0L, 0L); + k = waitpid(-1, &s, 0); + ASSERT_EQ(k, pid); + ASSERT_EQ(WIFSTOPPED(s), 1); + ASSERT_EQ(WSTOPSIG(s), SIGTRAP); + k = ptrace(PTRACE_CONT, pid, 0L, 0L); ASSERT_EQ(k, 0); k = waitpid(-1, &s, 0); ASSERT_EQ(k, pid); ASSERT_EQ(WIFSTOPPED(s), 1); ASSERT_EQ(WSTOPSIG(s), SIGSTOP); - k = ptrace(PTRACE_DETACH, pid, 0L, 0L); + k = ptrace(PTRACE_CONT, pid, 0L, 0L); ASSERT_EQ(k, 0); k = waitpid(-1, &s, 0); ASSERT_EQ(k, pid);