From patchwork Tue Oct 31 19:12:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 13442193 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DFD0C4332F for ; Tue, 31 Oct 2023 18:59:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233401AbjJaS7F (ORCPT ); Tue, 31 Oct 2023 14:59:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233231AbjJaS7E (ORCPT ); Tue, 31 Oct 2023 14:59:04 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 667B6E8 for ; Tue, 31 Oct 2023 11:59:02 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1ca85ff26afso11041335ad.1 for ; Tue, 31 Oct 2023 11:59:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698778742; x=1699383542; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tlpWK49hIBdc/FU/2GIUrAp30u6EONBnVwJ2rzn6r/Q=; b=gAIWLXKN8VL+ZxNB04U2PKoBkJTT7BJZa7HbgtcGX8c6L8m0NRLfJD/20ZuoupLEzS X4C2QcJmutMQDKIMpfUqG+wnnJS9A+tY/4sQg41BEd23WeoO+cDFvVONJbKceB8V45c/ xQMQt7AkexmNGLsBZT59WG+Kcg73/NTaprN73K2QKN5aWLBulwj1ceCI0GnqFqgVF9FP fskpvTl09Kwh59qDAyUF07gyU6Fp7ysH9klG7EZ2uq7YfqzNIprplIKovou9Zew9bFKY VMj94YRVogNXBbaT3b9n5tYtzRUM3tyzTvpsgLHhrfOH3YnQ85GPsII2Y0S6KenHZOWN N0Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698778742; x=1699383542; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tlpWK49hIBdc/FU/2GIUrAp30u6EONBnVwJ2rzn6r/Q=; b=mr+z8MyutqZ0Hsf4Gm8R55QYJYKFlS9XtjRbPDKp7Bh98WiGA82I3U3z6jV2kktew3 gaPH0WsuW//9NUyguhc+hRBMedoHmdc7NoxwKZmod7Y+mUfRZ8kHTAPBeArZyMjCqpkP J3iVYj3yx9RosRoWx6aceZwBmWqhl1Utqvy4U9Yi+GGkOpsIIqS0965e0x8dM9FADgEW iqY+qmXrEHVKiUoLHbOvoco/3w/AJ3Fm7i/0cHjTsD0I5gRGks6pd5R6Fykskk+8yT+a j4NEGyvtQ3mDdbTiwtXd94qSI026aweQMdNq8B2LWAK4SLo6+iLKjT4y2lYbhHPYF4uh EoPw== X-Gm-Message-State: AOJu0YxFjUSThrMNDFEfi+rnDl8qYvVXsOGtU3I2QWXZmopGTDXt6IH0 //0AJO+FMlW37etvAPgbChGoS1Osu+A= X-Google-Smtp-Source: AGHT+IFVv/GhF2vXV3kzcSRdMdZzXww0P//59wqpNa9Mxlxpmi5i+Zzt5YTabLNH7sFxN6yaLEuOXg== X-Received: by 2002:a17:902:f305:b0:1bf:349f:b85c with SMTP id c5-20020a170902f30500b001bf349fb85cmr13381324ple.1.1698778741731; Tue, 31 Oct 2023 11:59:01 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id bh6-20020a170902a98600b001c9d6923e7dsm1628657plb.222.2023.10.31.11.59.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Oct 2023 11:59:01 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 1/9] lpfc: Correct maximum PCI function value for RAS fw logging Date: Tue, 31 Oct 2023 12:12:16 -0700 Message-Id: <20231031191224.150862-2-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20231031191224.150862-1-justintee8345@gmail.com> References: <20231031191224.150862-1-justintee8345@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Currently, the ras_fwlog_func sysfs parameter allows users to input a value greater than three when selecting a PCI function to enable RAS fw logging feature. The user's input is sanity checked in lpfc_sli4_ras_init, but allowing an input greater than three doesn't make sense because the max number of ports per HBA is four. Change the allowable range from [0, 7] to [0, 3]. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_attr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c index b1c9107d3408..48c727a51193 100644 --- a/drivers/scsi/lpfc/lpfc_attr.c +++ b/drivers/scsi/lpfc/lpfc_attr.c @@ -5905,11 +5905,11 @@ LPFC_ATTR_RW(ras_fwlog_level, 0, 0, 4, "Firmware Logging Level"); /* * lpfc_ras_fwlog_func: Firmware logging enabled on function number * Default function which has RAS support : 0 - * Value Range is [0..7]. + * Value Range is [0..3]. * FW logging is a global action and enablement is via a specific * port. */ -LPFC_ATTR_RW(ras_fwlog_func, 0, 0, 7, "Firmware Logging Enabled on Function"); +LPFC_ATTR_RW(ras_fwlog_func, 0, 0, 3, "Firmware Logging Enabled on Function"); /* * lpfc_enable_bbcr: Enable BB Credit Recovery From patchwork Tue Oct 31 19:12:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 13442194 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C35DC4332F for ; Tue, 31 Oct 2023 18:59:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233631AbjJaS7K (ORCPT ); Tue, 31 Oct 2023 14:59:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233231AbjJaS7J (ORCPT ); Tue, 31 Oct 2023 14:59:09 -0400 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 763B6E6 for ; Tue, 31 Oct 2023 11:59:07 -0700 (PDT) Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1ca85ff26afso11041475ad.1 for ; Tue, 31 Oct 2023 11:59:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698778747; x=1699383547; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dQtbotzg2x+a6R9yFCDaJO3CuC1xbKUS9GOGH5x4dw8=; b=W5kMEgc2BNSN41+eVHReiejjwqAGrb5BZ3YIeykcj+DNuzy4/99tZDVrE9W/k0/mIP MFGhTUCj+f4IQp3vCPmWvcwQ0Xx0S7nj4SB7pDrvv0n28HHuuqF8LSDOrEKRrPdmVt1m Ac+Ci6d0kjxFK8TZahAtAvCg5UBcYW78I7gpsKKSR1bdkBSI42VBRMQtVzmUEndxvCmG deccz9d3xbpiweTxJU4SCx8OQ4dgOh48MNiZ6Fgj729G9yfl3n8mmfmy8bJ/qA0wcshJ oHKHJjWT6bP3C0GcwpwwYKv/PW3gYgi9SPS2NpmUjfEK2ZF9eNamAEhHbXaZNelbPT+W Rzng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698778747; x=1699383547; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dQtbotzg2x+a6R9yFCDaJO3CuC1xbKUS9GOGH5x4dw8=; b=qbZTAfHegr0JD+Pz2CeUcJLHN4aimYJe7HmsIiXAJXziTQpmCZhPEtITv6/Sjr+u66 nBspfLSu4l3UanydWeGEKk36x3O/0WlceCD7doFRDip9pym+6LKvQuIlIU5tjkG2lmlA xMicn7rPcp5Vr+udp7RSc7OhWzO6U2IGOHSa0duz+dZmySCUi3MxBQBNyIbH9BeayHiC W2fZEE3/wcZ5wiT23ilKHYQa4iht2zjm/IwVU/DwMQQZN9bXI6/O95IHsD5mYyUoQ0vd vM+R58lXoPd0PBr07MH+paQTW3fFbpg0+PzulA6tudNJuUy3lHSvOT80uDRH87Q3BIvJ O5Zw== X-Gm-Message-State: AOJu0Ywg9RtcV+8dj5x0ECRenKW0iLeWwf4A/m368CV+w1gyaNlbMbzv rA2aWcrLeMxAjvnRxeUDer1km0MgpcM= X-Google-Smtp-Source: AGHT+IEHmlTUkOh074CIL+ZWYXqkqVgOYLFXmHTeX5u6OIR3KofnxL4RDZIC7z24p3QUpp2hhwW6IQ== X-Received: by 2002:a17:902:f214:b0:1cc:27fa:1fb7 with SMTP id m20-20020a170902f21400b001cc27fa1fb7mr11602594plc.5.1698778746692; Tue, 31 Oct 2023 11:59:06 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id bh6-20020a170902a98600b001c9d6923e7dsm1628657plb.222.2023.10.31.11.59.05 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Oct 2023 11:59:06 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 2/9] lpfc: Fix possible file string name overflow when updating firmware Date: Tue, 31 Oct 2023 12:12:17 -0700 Message-Id: <20231031191224.150862-3-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20231031191224.150862-1-justintee8345@gmail.com> References: <20231031191224.150862-1-justintee8345@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Because file_name and phba->ModelName are both declared a size 80 bytes, the extra ".grp" file extension could cause an overflow into file_name. Define a ELX_FW_NAME_SIZE macro with value 84. 84 incorporates the 4 extra characters from ".grp". file_name is changed to be declared as a char and initialized to zeros i.e. null chars. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc.h | 1 + drivers/scsi/lpfc/lpfc_init.c | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc.h b/drivers/scsi/lpfc/lpfc.h index af15f7a22d25..04d608ea9106 100644 --- a/drivers/scsi/lpfc/lpfc.h +++ b/drivers/scsi/lpfc/lpfc.h @@ -33,6 +33,7 @@ struct lpfc_sli2_slim; #define ELX_MODEL_NAME_SIZE 80 +#define ELX_FW_NAME_SIZE 84 #define LPFC_PCI_DEV_LP 0x1 #define LPFC_PCI_DEV_OC 0x2 diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index 9e59c050103d..2c336953e56c 100644 --- a/drivers/scsi/lpfc/lpfc_init.c +++ b/drivers/scsi/lpfc/lpfc_init.c @@ -14725,7 +14725,7 @@ lpfc_write_firmware(const struct firmware *fw, void *context) int lpfc_sli4_request_firmware_update(struct lpfc_hba *phba, uint8_t fw_upgrade) { - uint8_t file_name[ELX_MODEL_NAME_SIZE]; + char file_name[ELX_FW_NAME_SIZE] = {0}; int ret; const struct firmware *fw; @@ -14734,7 +14734,7 @@ lpfc_sli4_request_firmware_update(struct lpfc_hba *phba, uint8_t fw_upgrade) LPFC_SLI_INTF_IF_TYPE_2) return -EPERM; - snprintf(file_name, ELX_MODEL_NAME_SIZE, "%s.grp", phba->ModelName); + scnprintf(file_name, sizeof(file_name), "%s.grp", phba->ModelName); if (fw_upgrade == INT_FW_UPGRADE) { ret = request_firmware_nowait(THIS_MODULE, FW_ACTION_UEVENT, From patchwork Tue Oct 31 19:12:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 13442195 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED2BDC4332F for ; Tue, 31 Oct 2023 18:59:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234067AbjJaS7O (ORCPT ); Tue, 31 Oct 2023 14:59:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233231AbjJaS7O (ORCPT ); Tue, 31 Oct 2023 14:59:14 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D8C5E6 for ; Tue, 31 Oct 2023 11:59:12 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1cc703d2633so1011635ad.0 for ; Tue, 31 Oct 2023 11:59:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698778751; x=1699383551; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nrT4bHXx1zsvU/xTx5lFQNU8eF2+RrfLfBhFNKJAd2Y=; b=itb6n2PzSc2gKhk1Zy4MnzY1c0u9KU6HN3cvL4oyEaZIVK7wMbsZBMDidcTQoICIaD 5tNe7nWolSbKbMWQAdHmduZ9ImBQCzZnVIXepvfKGBEyIIsg05aFEiAnVGpyb4wtHfHx ZERRECn7Dvr/SU5aZNQrc7yEF3X6EiLhjuu4lAbegTYGM0jeCf6h6QVqdGddcKdgkK5e A9LDJ8xtgSVhACv3JxJernLw5aXyGjJWIQofGwpauVMNV7oq9b+b+XJePSgRHqSSuDTV FV2BwA0/THnBzyKBMGxjByaeZc3xKjpr3Gjsm3GVhU37ih5lIkm2YKX6ZLfUTklmow/O 7v8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698778751; x=1699383551; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nrT4bHXx1zsvU/xTx5lFQNU8eF2+RrfLfBhFNKJAd2Y=; b=MTo1QiUXBxIAxOH5F1ssmA2Gt2BTIfWcBNpgEknD3DxglXSW+VrQhmwnLU+XswQNWH BsXlJlOC77vJr4ATZ+OQTG+CEMpNugTwRjo6AQTlX+g7LYLfcS32LYZL3x7jMU2M4jRe 6jgtEPMe5rTEn0AZYKBRn5xazLyeMLdVkEZT2IYEmpuJhS36pXhnp1fWNtM35OmsIY0+ wU0XawitUm6Z2NUTKh8rsFb1Shez6jDgz3uYaqDKGlGaWRdpU9Sm1lo6aW6lvyoYjMeB 2/upHw4FLoiQVZIBC/NyuX8RuMiwfCsjJkAOvrayCxbJoQuAskxslFcGsR+RVuPDNkwe HgQQ== X-Gm-Message-State: AOJu0YyhdGJ5FpMSvpZg5YMKkij8GE58+T7wR2XuUBul2DnQdwbuChGa R7exW6u7a97YdEgXbn4imCJHi5M+ZEg= X-Google-Smtp-Source: AGHT+IG4EbG4oqgac7fFf7iOmsEjel/U1N/ofVEvlw9lTjGAXUC4GGJVJUghDabEcHGMzeZ4YOIqcw== X-Received: by 2002:a17:902:f213:b0:1c4:1cd3:8062 with SMTP id m19-20020a170902f21300b001c41cd38062mr14098511plc.2.1698778751419; Tue, 31 Oct 2023 11:59:11 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id bh6-20020a170902a98600b001c9d6923e7dsm1628657plb.222.2023.10.31.11.59.10 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Oct 2023 11:59:10 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee , Dan Carpenter Subject: [PATCH 3/9] lpfc: Fix list_entry null check warning in lpfc_cmpl_els_plogi Date: Tue, 31 Oct 2023 12:12:18 -0700 Message-Id: <20231031191224.150862-4-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20231031191224.150862-1-justintee8345@gmail.com> References: <20231031191224.150862-1-justintee8345@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Smatch called out a warning for null checking a ptr that is assigned by list_entry. list_entry does not return null and, if the list is empty, can return an invalid ptr. Thus, the !psrp check does not execute properly. drivers/scsi/lpfc/lpfc_els.c:2133 lpfc_cmpl_els_plogi() warn: list_entry() does not return NULL 'prsp' Replace list_entry with list_get_first, which does a list_empty check before returning the first entry. Fixes: a3c3c0a806f1 ("scsi: lpfc: Validate ELS LS_ACC completion payload") Reported-by: Dan Carpenter Closes: https://lore.kernel.org/linux-scsi/01b7568f-4ab4-4d56-bfa6-9ecc5fc261fe@moroto.mountain/ Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_els.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index f9627eddab08..0829fe6ddff8 100644 --- a/drivers/scsi/lpfc/lpfc_els.c +++ b/drivers/scsi/lpfc/lpfc_els.c @@ -2128,8 +2128,8 @@ lpfc_cmpl_els_plogi(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, NLP_EVT_DEVICE_RM); } else { /* Good status, call state machine */ - prsp = list_entry(cmdiocb->cmd_dmabuf->list.next, - struct lpfc_dmabuf, list); + prsp = list_get_first(&cmdiocb->cmd_dmabuf->list, + struct lpfc_dmabuf, list); if (!prsp) goto out; if (!lpfc_is_els_acc_rsp(prsp)) From patchwork Tue Oct 31 19:12:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 13442196 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A6E3C4167B for ; Tue, 31 Oct 2023 18:59:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234191AbjJaS7R (ORCPT ); Tue, 31 Oct 2023 14:59:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234152AbjJaS7Q (ORCPT ); Tue, 31 Oct 2023 14:59:16 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57F35E8 for ; Tue, 31 Oct 2023 11:59:14 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1ca85ff26afso11041645ad.1 for ; Tue, 31 Oct 2023 11:59:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698778753; x=1699383553; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NwY0abciY/5rOgynozGa1kZPjEvQWzBEbUsGFTHsmos=; b=WTJUl5YBXYLoMscKZgHDkvDMj5oC1x0NeYXRPb0lkhbmJ6Ai0EjO/wrnlyL7t4y1bg tUQlSUK84t+ys+5eO4hLiafOGDwlCDYVG0BpmdYvK+XHX3jxIcWpPGXscmRjsbKxy/7K P3dfAuB//BxvS1snz2QbrpCDBZCwSvJP4nLy/l07tXRAp7ndI3gz25jkyaB0cDhjQNWt g6ovfKkQ1Wz6W2cAjLxrYRg1G3kct2HAJ1ErIC9MdjnltzaviIM4/3teWHmI7nXgK2+9 4Ez9OBkI6XlynHMjnBnOdgDZVTAKzXZlvi6lHQ0LEQcpwFyLPC/KsZ+2VzKT2kCtTh53 35KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698778754; x=1699383554; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NwY0abciY/5rOgynozGa1kZPjEvQWzBEbUsGFTHsmos=; b=T+C7f/TDafj5kTz0g6qKDj8nGSpn7ZnDt+NnD/83FQ2xwu+7rSrOmKxBvybhyYv06l AlpmtjbqMx4bfEXvSSmxPzRKPiQ1MwwF9Qm8uZeVeqlimCUgmPFE+22GdluFw0y5KYqU yZpN/IzYKbszWW1s6b+xA8x4ZFy53Eux+WAoIgPi/JsPJ61TMIDxSJAjVGLD4ZkkERi+ qgqcHFlNzcwPgSrn6+QcVcwNG4Hw4J2BM9ZFew6tMgxYlCksJQrAC78arb6Ni0x16E6U soIsJMh28E0jorFvbgz7HY2YxRRpCWm5dhGEdNnIq0EN0bjFLg9zJntgFnI+6aVn1mmh Chpw== X-Gm-Message-State: AOJu0YyEgZPGdb3SthXVzjTjfaF/EAmY41SGh9X8E0jx4MwRjJ6oeAqr P9U8EIw1P9VN3srnp8Y/hAMPb8akL8o= X-Google-Smtp-Source: AGHT+IEjld9aJpYeVQz0ZLsIf1FqbWanHWmTPUnRP/JmhJZmeYEDU2x4SdoScw2EG14t/2Xj2AkT5g== X-Received: by 2002:a17:902:f214:b0:1cc:27fa:1fb7 with SMTP id m20-20020a170902f21400b001cc27fa1fb7mr11602811plc.5.1698778753687; Tue, 31 Oct 2023 11:59:13 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id bh6-20020a170902a98600b001c9d6923e7dsm1628657plb.222.2023.10.31.11.59.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Oct 2023 11:59:13 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 4/9] lpfc: Eliminate unnecessary relocking in lpfc_check_nlp_post_devloss Date: Tue, 31 Oct 2023 12:12:19 -0700 Message-Id: <20231031191224.150862-5-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20231031191224.150862-1-justintee8345@gmail.com> References: <20231031191224.150862-1-justintee8345@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org In lpfc_check_nlp_post_devloss, retaking of the ndlp lock in the if statement is useless because the very next line unlocks. Simply, return to avoid relocking. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_hbadisc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c index 7ef9841f0728..f80bbc315f4c 100644 --- a/drivers/scsi/lpfc/lpfc_hbadisc.c +++ b/drivers/scsi/lpfc/lpfc_hbadisc.c @@ -411,7 +411,7 @@ lpfc_check_nlp_post_devloss(struct lpfc_vport *vport, "port_state = x%x\n", ndlp->nlp_DID, kref_read(&ndlp->kref), ndlp, ndlp->nlp_flag, vport->port_state); - spin_lock_irqsave(&ndlp->lock, iflags); + return; } spin_unlock_irqrestore(&ndlp->lock, iflags); } From patchwork Tue Oct 31 19:12:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 13442197 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58399C4332F for ; Tue, 31 Oct 2023 18:59:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233231AbjJaS7U (ORCPT ); Tue, 31 Oct 2023 14:59:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234263AbjJaS7S (ORCPT ); Tue, 31 Oct 2023 14:59:18 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 223FDE8 for ; Tue, 31 Oct 2023 11:59:16 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1cc55bcd51eso4353235ad.0 for ; Tue, 31 Oct 2023 11:59:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698778755; x=1699383555; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NDTqE7DBDC1j/pMX1esEVkDNCh0SMey5rbfN1InPrtY=; b=LAXucowOopTaIsVFkRSg4o28VbQjHN6WzA3nD6RGXlx2Om0NuTnYLA4OVuIwnjqE46 aJrP/oVH1wJEuxtSCjc2dBo62i7uAVubgivUvvbKjONK0TfLt5AK4g2icv/RIZnnOMQg mws29bcqWfryXu3IL6477v/ocZtuFm6N7IIVm5WhKH+HrI23HUpOq/6h0g81DTVDxfSk +EZkJexfG+ZtWy5D2kgfFEnoh1C1WEjYtIoPOzM9d93IMSxWPcWVwK3leK/eQFADYH0h lWoZagrHWXssgNbB68D8dMANNlZzWYIpviffKKGYpddBNxTwHzaegR0pQ2ol9YiB7qlE +qIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698778755; x=1699383555; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NDTqE7DBDC1j/pMX1esEVkDNCh0SMey5rbfN1InPrtY=; b=gU0OUEsXqjudLF36Lsv7lQ96C+ogu1bgvslzjeOA7X9QNfFxF/AaEVEdN/+UEG0d94 tLs3yRkrYL8BUmRVe/WN5wCT3NoQnXX0Fplkv5J6i4fP1jfqulVehAwC1xiWz/UxSKZ1 gP+JSyNM7e1Ai9tR0m36nhE2dsC8Kh+8HbokxZVD6issV0ZXVFMsf4b/KVBlfHkcc2lV 5xKLdcsjwzmXNmEDGe+TqPJzQ9+AgFR1DYLuKgnRnsi9c2cUPKUeTHxZhrHK6nzSnDkt nM/4kiYcm68zWxfVU6wfjKBYHxwMTFP5Kf3IDPJhU+9Jx5X9jZ0bMRvQnXgSabqZUFT+ WKWQ== X-Gm-Message-State: AOJu0YydJMmaaiiP5qWNzQLX7etNJ5vOcAW4WBWsaJC/5ATnLjvBQss3 ukMRq3gCo1EwOrssvOgH6qTCJHMUE9g= X-Google-Smtp-Source: AGHT+IEcrnyS3BVsXjQb1jQ+loEauQ8RdunW1SgyfKEUG0DXcwz77wWAkxh9cbbiL6hvU8PqjOE7ww== X-Received: by 2002:a17:902:ced1:b0:1cc:e66:f994 with SMTP id d17-20020a170902ced100b001cc0e66f994mr14573276plg.1.1698778755488; Tue, 31 Oct 2023 11:59:15 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id bh6-20020a170902a98600b001c9d6923e7dsm1628657plb.222.2023.10.31.11.59.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Oct 2023 11:59:15 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 5/9] lpfc: Return early in lpfc_poll_eratt when the driver is unloading Date: Tue, 31 Oct 2023 12:12:20 -0700 Message-Id: <20231031191224.150862-6-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20231031191224.150862-1-justintee8345@gmail.com> References: <20231031191224.150862-1-justintee8345@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Add a check in lpfc_poll_eratt when the driver is unloading. There is no point to check for error attention events if the driver is rmmod'ed. If the driver is reloaded, as part of insmod initialization, then a fresh reset is always asserted to start clean and free of error attention events. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_sli.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index 9386e7b44750..2cb327efd57d 100644 --- a/drivers/scsi/lpfc/lpfc_sli.c +++ b/drivers/scsi/lpfc/lpfc_sli.c @@ -3938,6 +3938,9 @@ void lpfc_poll_eratt(struct timer_list *t) if (!(phba->hba_flag & HBA_SETUP)) return; + if (phba->pport->load_flag & FC_UNLOADING) + return; + /* Here we will also keep track of interrupts per sec of the hba */ sli_intr = phba->sli.slistat.sli_intr; From patchwork Tue Oct 31 19:12:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 13442198 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00A72C4167D for ; Tue, 31 Oct 2023 18:59:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234152AbjJaS7V (ORCPT ); Tue, 31 Oct 2023 14:59:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234077AbjJaS7U (ORCPT ); Tue, 31 Oct 2023 14:59:20 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E707F1 for ; Tue, 31 Oct 2023 11:59:18 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1cc28719cb0so7299975ad.0 for ; Tue, 31 Oct 2023 11:59:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698778757; x=1699383557; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bH5B+NVEOli7E5i13owgmpNxf+GKiAEfSKEwOkOdDIA=; b=UQaAAEacoSkoh8fFYJWoWDznWTfTkjtlXUeGc/4sfVoiPcEiOsYlBG7meJZM5IRzkS Mt+euOmxVSOvxOzInZBMQKW04YDhmPqp7GFFD0qM0i54t94ZnxTDL0bUbG9+TcbNLPl1 nl9Tx46kj45R2LUvAr8arjfFlbjXkrmzRhoDfBt+M/yItG0QDn97LlULvM+NGkZDAQz/ x/vkWNM+IXO17LQf9MBM15N5ZJe9tVTgl+wLXY47qwwmDI8qQKw+DNeY15q76LcsLgjD 2qSVEugt/4fL1H99TrkVeV5L6jXGcvYBKGBzgnSmYmXFIj6loQNk2vU/mzo8Qyy6MLCF Fekw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698778757; x=1699383557; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bH5B+NVEOli7E5i13owgmpNxf+GKiAEfSKEwOkOdDIA=; b=EzPSbKD1xbIc5LIWIC3+hh+8U/uVwzQdPODoziFyYQ6O0AmbsMbJinpoVQs4EqTtoS hIzHtd1lUL783MNAwm8wxhcz50zUWHlNAt3V5pX3g5rYfTd7X5wmmMIzDcAvtuUvEHKk 4RS/5IFKHCuluynBiw+SnKUMmwqviLnkyreau0yrm3Z/oiGByNwATq1/cZwEclDioPoO AyP2vmW+zTdtHI2x8FElltnJ9IO3eHM2O8ATbIl2AbMyhvLJaiJJANuaMvYLNpXlI1AY Y49VnDfpWj3MVsQlAGOkjJ6mAuKumB2LLb/XqjPK11QTS7RmD4lcWIZci7Nz/azQFYdu 4Aow== X-Gm-Message-State: AOJu0YzRqbIH4cmoWP0mjn0THYrCFx2UU+DVHeWlcqZI8bSWJZN+Cbqf LOIhfmtYj/7xai5YVWuaXFj6WcVtdbE= X-Google-Smtp-Source: AGHT+IEOBnDbJ6CEDZT2hdtNKn6Dn9FGthHfJ27mhRPHK2WOuumW+AK8uSA/qn5qj4wasPUNmDyBPg== X-Received: by 2002:a17:902:f214:b0:1cc:27fa:1fb7 with SMTP id m20-20020a170902f21400b001cc27fa1fb7mr11602930plc.5.1698778757360; Tue, 31 Oct 2023 11:59:17 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id bh6-20020a170902a98600b001c9d6923e7dsm1628657plb.222.2023.10.31.11.59.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Oct 2023 11:59:17 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 6/9] lpfc: Refactor and clean up mailbox command memory free Date: Tue, 31 Oct 2023 12:12:21 -0700 Message-Id: <20231031191224.150862-7-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20231031191224.150862-1-justintee8345@gmail.com> References: <20231031191224.150862-1-justintee8345@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org A lot of repeated clean up code exists when freeing mailbox commands in lpfc_mem_free_all. Introduce a lpfc_mem_free_sli_mbox helper routine to refactor the copy-paste code. Additionally, reinitialize the mailbox command structure context pointers to NULL in lpfc_sli4_mbox_cmd_free. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_mbox.c | 4 +++- drivers/scsi/lpfc/lpfc_mem.c | 45 ++++++++++++++++++++--------------- drivers/scsi/lpfc/lpfc_sli.c | 6 +++++ drivers/scsi/lpfc/lpfc_sli.h | 8 ++++--- 4 files changed, 40 insertions(+), 23 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_mbox.c b/drivers/scsi/lpfc/lpfc_mbox.c index 0dfdc0c4c08c..b5ab44234f20 100644 --- a/drivers/scsi/lpfc/lpfc_mbox.c +++ b/drivers/scsi/lpfc/lpfc_mbox.c @@ -1814,7 +1814,9 @@ lpfc_sli4_mbox_cmd_free(struct lpfc_hba *phba, struct lpfcMboxq *mbox) dma_free_coherent(&phba->pcidev->dev, SLI4_PAGE_SIZE, mbox->sge_array->addr[sgentry], phyaddr); } - /* Free the sge address array memory */ + /* Reinitialize the context pointers to avoid stale usage. */ + mbox->ctx_buf = NULL; + mbox->context3 = NULL; kfree(mbox->sge_array); /* Finally, free the mailbox command itself */ mempool_free(mbox, phba->mbox_mem_pool); diff --git a/drivers/scsi/lpfc/lpfc_mem.c b/drivers/scsi/lpfc/lpfc_mem.c index 89cbeba06aea..ef6e5256a35e 100644 --- a/drivers/scsi/lpfc/lpfc_mem.c +++ b/drivers/scsi/lpfc/lpfc_mem.c @@ -48,6 +48,29 @@ #define LPFC_RRQ_POOL_SIZE 256 /* max elements in non-DMA pool */ #define LPFC_MBX_POOL_SIZE 256 /* max elements in MBX non-DMA pool */ +/* lpfc_mbox_free_sli_mbox + * + * @phba: HBA to free memory for + * @mbox: mailbox command to free + * + * This routine detects the mbox type and calls the correct + * free routine to fully release all associated memory. + */ +static void +lpfc_mem_free_sli_mbox(struct lpfc_hba *phba, LPFC_MBOXQ_t *mbox) +{ + /* Detect if the caller's mbox is an SLI4_CONFIG type. If so, this + * mailbox type requires a different cleanup routine. Otherwise, the + * mailbox is just an mbuf and mem_pool release. + */ + if (phba->sli_rev == LPFC_SLI_REV4 && + bf_get(lpfc_mqe_command, &mbox->u.mqe) == MBX_SLI4_CONFIG) { + lpfc_sli4_mbox_cmd_free(phba, mbox); + } else { + lpfc_mbox_rsrc_cleanup(phba, mbox, MBOX_THD_UNLOCKED); + } +} + int lpfc_mem_alloc_active_rrq_pool_s4(struct lpfc_hba *phba) { size_t bytes; @@ -288,27 +311,16 @@ lpfc_mem_free_all(struct lpfc_hba *phba) { struct lpfc_sli *psli = &phba->sli; LPFC_MBOXQ_t *mbox, *next_mbox; - struct lpfc_dmabuf *mp; /* Free memory used in mailbox queue back to mailbox memory pool */ list_for_each_entry_safe(mbox, next_mbox, &psli->mboxq, list) { - mp = (struct lpfc_dmabuf *)(mbox->ctx_buf); - if (mp) { - lpfc_mbuf_free(phba, mp->virt, mp->phys); - kfree(mp); - } list_del(&mbox->list); - mempool_free(mbox, phba->mbox_mem_pool); + lpfc_mem_free_sli_mbox(phba, mbox); } /* Free memory used in mailbox cmpl list back to mailbox memory pool */ list_for_each_entry_safe(mbox, next_mbox, &psli->mboxq_cmpl, list) { - mp = (struct lpfc_dmabuf *)(mbox->ctx_buf); - if (mp) { - lpfc_mbuf_free(phba, mp->virt, mp->phys); - kfree(mp); - } list_del(&mbox->list); - mempool_free(mbox, phba->mbox_mem_pool); + lpfc_mem_free_sli_mbox(phba, mbox); } /* Free the active mailbox command back to the mailbox memory pool */ spin_lock_irq(&phba->hbalock); @@ -316,12 +328,7 @@ lpfc_mem_free_all(struct lpfc_hba *phba) spin_unlock_irq(&phba->hbalock); if (psli->mbox_active) { mbox = psli->mbox_active; - mp = (struct lpfc_dmabuf *)(mbox->ctx_buf); - if (mp) { - lpfc_mbuf_free(phba, mp->virt, mp->phys); - kfree(mp); - } - mempool_free(mbox, phba->mbox_mem_pool); + lpfc_mem_free_sli_mbox(phba, mbox); psli->mbox_active = NULL; } diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index 2cb327efd57d..bfbc23248692 100644 --- a/drivers/scsi/lpfc/lpfc_sli.c +++ b/drivers/scsi/lpfc/lpfc_sli.c @@ -22170,6 +22170,12 @@ struct lpfc_io_buf *lpfc_get_io_buf(struct lpfc_hba *phba, * The data will be truncated if datasz is not large enough. * Version 1 is not supported with Embedded mbox cmd, so we must use version 0. * Returns the actual bytes read from the object. + * + * This routine is hard coded to use a poll completion. Unlike other + * sli4_config mailboxes, it uses lpfc_mbuf memory which is not + * cleaned up in lpfc_sli4_cmd_mbox_free. If this routine is modified + * to use interrupt-based completions, code is needed to fully cleanup + * the memory. */ int lpfc_read_object(struct lpfc_hba *phba, char *rdobject, uint32_t *datap, diff --git a/drivers/scsi/lpfc/lpfc_sli.h b/drivers/scsi/lpfc/lpfc_sli.h index cd33dfec758c..14b8b5a3addf 100644 --- a/drivers/scsi/lpfc/lpfc_sli.h +++ b/drivers/scsi/lpfc/lpfc_sli.h @@ -182,9 +182,11 @@ typedef struct lpfcMboxq { struct lpfc_mqe mqe; } u; struct lpfc_vport *vport; /* virtual port pointer */ - void *ctx_ndlp; /* caller ndlp information */ - void *ctx_buf; /* caller buffer information */ - void *context3; + void *ctx_ndlp; /* an lpfc_nodelist pointer */ + void *ctx_buf; /* an lpfc_dmabuf pointer */ + void *context3; /* a generic pointer. Code must + * accommodate the actual datatype. + */ void (*mbox_cmpl) (struct lpfc_hba *, struct lpfcMboxq *); uint8_t mbox_flag; From patchwork Tue Oct 31 19:12:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 13442199 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 037C1C4167D for ; Tue, 31 Oct 2023 18:59:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234263AbjJaS70 (ORCPT ); Tue, 31 Oct 2023 14:59:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234077AbjJaS7W (ORCPT ); Tue, 31 Oct 2023 14:59:22 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E19D3E8 for ; Tue, 31 Oct 2023 11:59:19 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1cc4d306fe9so5150075ad.0 for ; Tue, 31 Oct 2023 11:59:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698778759; x=1699383559; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6QBK5fLy0U3b6zmeHz4k+VvgXfMeYUN84qpqw5Ya2Ow=; b=QezSF7nfutNTxZCH/3VQP2fRX2IUKrubiLiIzjx+IBjKGZhKJwqQODrwQIN4F+0+KO CTO4hDaUvjLMSGMqNfcAVYcSfNxj+FzPDV5AJ/waCXuWrLKuBMFEKVHsqYe7E8whf7/c /t7Msjd6gMuMkl6OvgHBu2oV7yATo5qeAZSKMMub01rBqyJS/4MuhCytXx3KiqtRVX0D fzFoyW7amU4qY+Vfslpdo8bKeHKp6qKJjT8iXASvo6HGbpXuDV7KU7tni9FLty8fuujJ gksyPjKoTCPxczH87ZAFk/n+JE8relvI+gluu19kOXEB1riJn+PldtnKV3KGpFPC8sY+ nrIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698778759; x=1699383559; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6QBK5fLy0U3b6zmeHz4k+VvgXfMeYUN84qpqw5Ya2Ow=; b=RsUFeQstflwyBgQPtUkokrNKCbIsEpjPTC8ZJv9mLbX/d6gKj7jOjjIs4p5Z4SeD9p T0TZ3LsyIzuPFQ54R9z4Xu6qjeuHw0s87DzznR1yjgr0qNgMwcEZX3tiRpuGRuY8bfdy rBV+QqlKIQ5XU12JaxI5HiFWl76JOFC+MUklKXoj2S+Q2k4X6UEkTJqRQ2Fr2DHc9UaY zXUu2pu1w1o5oicgyG/5Q3B1MU5qMyZH1LDz6XZJ6i54XjJNvktxoXAhYPWnHdtx0EBm j9Z4O0hNf2Lx/PI5SJICkDx0pPTYNJmE+IbGjNGiNnBZAsgIDtZLZVuegLv5cwd+fAX7 4znw== X-Gm-Message-State: AOJu0YzUDP5Y/jasHxK/iZrRGQ6d58psj1yRWQ9VjJAekkV7BspytlY6 OWB26bxMx/HgDTBvpuHwRa5y/Vu/s6k= X-Google-Smtp-Source: AGHT+IF9RSB0xlB1wLQdWgZInb0xoV0ZJ0VPlMXX1+awIRpSS+daZfnDL0lJimQ3KsvppwdYszuVVQ== X-Received: by 2002:a17:902:c70b:b0:1c3:a4f2:7c99 with SMTP id p11-20020a170902c70b00b001c3a4f27c99mr13121945plp.4.1698778759244; Tue, 31 Oct 2023 11:59:19 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id bh6-20020a170902a98600b001c9d6923e7dsm1628657plb.222.2023.10.31.11.59.18 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Oct 2023 11:59:18 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 7/9] lpfc: Enhance driver logging for selected discovery events Date: Tue, 31 Oct 2023 12:12:22 -0700 Message-Id: <20231031191224.150862-8-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20231031191224.150862-1-justintee8345@gmail.com> References: <20231031191224.150862-1-justintee8345@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Typically, debugging discovery issues requires the ndlp reference count, nlp flags, transport flags, and the io tag for root cause analysis. Modify important discovery log messages to include one or more of these attributes to aid in debugging and support. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_els.c | 49 +++++++++++++++++++++++------------- drivers/scsi/lpfc/lpfc_sli.c | 11 +++++--- 2 files changed, 38 insertions(+), 22 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index 0829fe6ddff8..f04326db8c19 100644 --- a/drivers/scsi/lpfc/lpfc_els.c +++ b/drivers/scsi/lpfc/lpfc_els.c @@ -2062,8 +2062,9 @@ lpfc_cmpl_els_plogi(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, /* PLOGI completes to NPort */ lpfc_printf_vlog(vport, KERN_INFO, LOG_ELS, "0102 PLOGI completes to NPort x%06x " - "Data: x%x x%x x%x x%x x%x\n", - ndlp->nlp_DID, ndlp->nlp_fc4_type, + "IoTag x%x Data: x%x x%x x%x x%x x%x\n", + ndlp->nlp_DID, iotag, + ndlp->nlp_fc4_type, ulp_status, ulp_word4, disc, vport->num_disc_nodes); @@ -2362,9 +2363,10 @@ lpfc_cmpl_els_prli(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, /* PRLI completes to NPort */ lpfc_printf_vlog(vport, KERN_INFO, LOG_ELS, "0103 PRLI completes to NPort x%06x " - "Data: x%x x%x x%x x%x\n", + "Data: x%x x%x x%x x%x x%x\n", ndlp->nlp_DID, ulp_status, ulp_word4, - vport->num_disc_nodes, ndlp->fc4_prli_sent); + vport->num_disc_nodes, ndlp->fc4_prli_sent, + ndlp->fc4_xpt_flags); /* Check to see if link went down during discovery */ if (lpfc_els_chk_latt(vport)) @@ -2805,7 +2807,7 @@ lpfc_cmpl_els_adisc(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, IOCB_t *irsp; struct lpfc_nodelist *ndlp; int disc; - u32 ulp_status, ulp_word4, tmo; + u32 ulp_status, ulp_word4, tmo, iotag; bool release_node = false; /* we pass cmdiocb to state machine which needs rspiocb as well */ @@ -2818,9 +2820,11 @@ lpfc_cmpl_els_adisc(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, if (phba->sli_rev == LPFC_SLI_REV4) { tmo = get_wqe_tmo(cmdiocb); + iotag = get_wqe_reqtag(cmdiocb); } else { irsp = &rspiocb->iocb; tmo = irsp->ulpTimeout; + iotag = irsp->ulpIoTag; } lpfc_debugfs_disc_trc(vport, LPFC_DISC_TRC_ELS_CMD, @@ -2838,9 +2842,11 @@ lpfc_cmpl_els_adisc(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, /* ADISC completes to NPort */ lpfc_printf_vlog(vport, KERN_INFO, LOG_ELS, "0104 ADISC completes to NPort x%x " - "Data: x%x x%x x%x x%x x%x\n", - ndlp->nlp_DID, ulp_status, ulp_word4, + "IoTag x%x Data: x%x x%x x%x x%x x%x\n", + ndlp->nlp_DID, iotag, + ulp_status, ulp_word4, tmo, disc, vport->num_disc_nodes); + /* Check to see if link went down during discovery */ if (lpfc_els_chk_latt(vport)) { spin_lock_irq(&ndlp->lock); @@ -3001,7 +3007,7 @@ lpfc_cmpl_els_logo(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, int wake_up_waiter = 0; u32 ulp_status; u32 ulp_word4; - u32 tmo; + u32 tmo, iotag; /* we pass cmdiocb to state machine which needs rspiocb as well */ cmdiocb->rsp_iocb = rspiocb; @@ -3011,9 +3017,11 @@ lpfc_cmpl_els_logo(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, if (phba->sli_rev == LPFC_SLI_REV4) { tmo = get_wqe_tmo(cmdiocb); + iotag = get_wqe_reqtag(cmdiocb); } else { irsp = &rspiocb->iocb; tmo = irsp->ulpTimeout; + iotag = irsp->ulpIoTag; } spin_lock_irq(&ndlp->lock); @@ -3032,9 +3040,11 @@ lpfc_cmpl_els_logo(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, /* LOGO completes to NPort */ lpfc_printf_vlog(vport, KERN_INFO, LOG_ELS, "0105 LOGO completes to NPort x%x " - "refcnt %d nflags x%x Data: x%x x%x x%x x%x\n", - ndlp->nlp_DID, kref_read(&ndlp->kref), ndlp->nlp_flag, - ulp_status, ulp_word4, + "IoTag x%x refcnt %d nflags x%x xflags x%x " + "Data: x%x x%x x%x x%x\n", + ndlp->nlp_DID, iotag, + kref_read(&ndlp->kref), ndlp->nlp_flag, + ndlp->fc4_xpt_flags, ulp_status, ulp_word4, tmo, vport->num_disc_nodes); if (lpfc_els_chk_latt(vport)) { @@ -5075,16 +5085,19 @@ lpfc_els_retry(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb, if (logerr) { lpfc_printf_vlog(vport, KERN_ERR, LOG_TRACE_EVENT, "0137 No retry ELS command x%x to remote " - "NPORT x%x: Out of Resources: Error:x%x/%x\n", - cmd, did, ulp_status, - ulp_word4); + "NPORT x%x: Out of Resources: Error:x%x/%x " + "IoTag x%x\n", + cmd, did, ulp_status, ulp_word4, + cmdiocb->iotag); } else { lpfc_printf_vlog(vport, KERN_INFO, LOG_ELS, - "0108 No retry ELS command x%x to remote " - "NPORT x%x Retried:%d Error:x%x/%x\n", - cmd, did, cmdiocb->retry, ulp_status, - ulp_word4); + "0108 No retry ELS command x%x to remote " + "NPORT x%x Retried:%d Error:x%x/%x " + "IoTag x%x nflags x%x\n", + cmd, did, cmdiocb->retry, ulp_status, + ulp_word4, cmdiocb->iotag, + (ndlp ? ndlp->nlp_flag : 0)); } return 0; } diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index bfbc23248692..46e6f807d1ca 100644 --- a/drivers/scsi/lpfc/lpfc_sli.c +++ b/drivers/scsi/lpfc/lpfc_sli.c @@ -2995,8 +2995,9 @@ lpfc_sli4_unreg_rpi_cmpl_clr(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb) LPFC_SLI_INTF_IF_TYPE_2)) { if (ndlp) { lpfc_printf_vlog( - vport, KERN_INFO, LOG_MBOX | LOG_SLI, - "0010 UNREG_LOGIN vpi:%x " + vport, KERN_INFO, + LOG_MBOX | LOG_SLI | LOG_NODE, + "0010 UNREG_LOGIN vpi:x%x " "rpi:%x DID:%x defer x%x flg x%x " "x%px\n", vport->vpi, ndlp->nlp_rpi, @@ -3012,7 +3013,8 @@ lpfc_sli4_unreg_rpi_cmpl_clr(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb) (ndlp->nlp_defer_did != NLP_EVT_NOTHING_PENDING)) { lpfc_printf_vlog( - vport, KERN_INFO, LOG_DISCOVERY, + vport, KERN_INFO, + LOG_MBOX | LOG_SLI | LOG_NODE, "4111 UNREG cmpl deferred " "clr x%x on " "NPort x%x Data: x%x x%px\n", @@ -10144,11 +10146,12 @@ lpfc_sli_issue_mbox_s4(struct lpfc_hba *phba, LPFC_MBOXQ_t *mboxq, spin_unlock_irqrestore(&phba->hbalock, iflags); lpfc_printf_log(phba, KERN_INFO, LOG_MBOX | LOG_SLI, "(%d):0354 Mbox cmd issue - Enqueue Data: " - "x%x (x%x/x%x) x%x x%x x%x\n", + "x%x (x%x/x%x) x%x x%x x%x x%x\n", mboxq->vport ? mboxq->vport->vpi : 0xffffff, bf_get(lpfc_mqe_command, &mboxq->u.mqe), lpfc_sli_config_mbox_subsys_get(phba, mboxq), lpfc_sli_config_mbox_opcode_get(phba, mboxq), + mboxq->u.mb.un.varUnregLogin.rpi, phba->pport->port_state, psli->sli_flag, MBX_NOWAIT); /* Wake up worker thread to transport mailbox command from head */ From patchwork Tue Oct 31 19:12:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 13442201 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 717D2C4332F for ; Tue, 31 Oct 2023 18:59:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234315AbjJaS73 (ORCPT ); Tue, 31 Oct 2023 14:59:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234271AbjJaS7X (ORCPT ); Tue, 31 Oct 2023 14:59:23 -0400 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87B59EA for ; Tue, 31 Oct 2023 11:59:21 -0700 (PDT) Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1cc4d306fe9so5150095ad.0 for ; Tue, 31 Oct 2023 11:59:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698778761; x=1699383561; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SWCHVlrp4QI6QJQeA3Yw7epl6gIptzpQaQ9nMWBqSiM=; b=JnkYvtB8yYqGdGFeJvIzVjw6t3xFPkItyHNiolExwFpvj0MlZM0kn3/U6Sw0ffSkfj rzwA29J3kAJZ1RGBMIJ6PabgzIvpAId61zqlox2YgefS2n5o6XkFg76qHl2QZgo7IheR eZchkfdw2g26TQEBArsYSJtb9ds8FD1bZMh+CZPcZMUfhfzj58hhn6FLsoDc31aA5zkP tLLXX4TI7Lr6Rxz/0nEtZf0P6oWcxpSjXc4boD5funH/ezlwLbTmudMxzM7T+IkXb3su ADVhKkPxdhXMct5uWpJaeTF97/Dsbh6qh/wRnji1vu3gHapPAqjGnWg9ew5Ftrw/QMKJ pvxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698778761; x=1699383561; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SWCHVlrp4QI6QJQeA3Yw7epl6gIptzpQaQ9nMWBqSiM=; b=hI/fNZNRJaCISGjpLbBFIM3fLk2ZV5OykXuPg+9aBfaGDhGHJUWYnJ86d2UCq/d6sR YW0SdfELrqQvrW5uvAMDqATiIwuBhnsCqfKBQYTR4vOBFhXKpe/bNskoLpmpbBNC2YGa LJ98EJ9zb2S/o8EmQpaSeoxmGYa6/LZrpeLYrD2BqTxMvurhc8UbpsXjcGhHHOyy4LnA xgMkPk1JpcuIGJmT3JqtB/n2ZovpBFgPtAZaEvaojmrO/B40VfshjehHQaX3gxpavG5x E3jI8uJIPzbRsJwRwOEcQhslNfQwkZLVGJTNj9ir0vLh/Y7oMb1UNJM/fVVPiyso65YV qmTg== X-Gm-Message-State: AOJu0YzOEUIxxMkxnrGvaYxkaqKD05mEPXokfW4D7ko8HFdl90IxzA2e yUY+ZddWhmvDn9htxlnHqKQvnt5h9lE= X-Google-Smtp-Source: AGHT+IET9HCSxKx+S1UkRIHjAxrtbsnYMpzbEe1niqAqWoT0N2GvrEYPpIfLd/nCHbjoWASPqh7kDQ== X-Received: by 2002:a17:902:c74c:b0:1cc:2ba2:55f4 with SMTP id q12-20020a170902c74c00b001cc2ba255f4mr10887502plq.0.1698778760877; Tue, 31 Oct 2023 11:59:20 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id bh6-20020a170902a98600b001c9d6923e7dsm1628657plb.222.2023.10.31.11.59.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Oct 2023 11:59:20 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 8/9] lpfc: Update lpfc version to 14.2.0.16 Date: Tue, 31 Oct 2023 12:12:23 -0700 Message-Id: <20231031191224.150862-9-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20231031191224.150862-1-justintee8345@gmail.com> References: <20231031191224.150862-1-justintee8345@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Update lpfc version to 14.2.0.16 Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index 88068834cab9..b7d39e2f19fc 100644 --- a/drivers/scsi/lpfc/lpfc_version.h +++ b/drivers/scsi/lpfc/lpfc_version.h @@ -20,7 +20,7 @@ * included with this package. * *******************************************************************/ -#define LPFC_DRIVER_VERSION "14.2.0.15" +#define LPFC_DRIVER_VERSION "14.2.0.16" #define LPFC_DRIVER_NAME "lpfc" /* Used for SLI 2/3 */ From patchwork Tue Oct 31 19:12:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Justin Tee X-Patchwork-Id: 13442200 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC408C4167B for ; Tue, 31 Oct 2023 18:59:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234326AbjJaS71 (ORCPT ); Tue, 31 Oct 2023 14:59:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234309AbjJaS7Z (ORCPT ); Tue, 31 Oct 2023 14:59:25 -0400 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58DC6ED for ; Tue, 31 Oct 2023 11:59:23 -0700 (PDT) Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-6bb744262caso1633264b3a.0 for ; Tue, 31 Oct 2023 11:59:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698778763; x=1699383563; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EiRiYpRTXS+2WWemyWGygLIOM2rmQEI/Y7EUynmYac8=; b=c2k56UjnlF1VbR/6GA3Wrne0P8HuZV6Djm7Q8zwbgKJMqOuMes2R49d8Age/414aSD PeCsqraFBqzTVIEOjJsxkJj2GFSYnqaFNWt0sOWYsoDONcvMRxqhESPMDjVFqzKs8/Mx rEsaaep70/bVRhLzRRNRPScKoTlXgwmki9qbFfSjb+2FXvomC9hHvCHaUUBh5ROiTw44 YQXd+vKYcSRrbrFEl9BR10ydvohfUKbVbzMVVy/Ab077vm8dFv+mfryr8EWmzcez/OUf dd4Y1ToqvaWMIWedniV9uEbO0J3Gg07d0lAioDn/bwZfem0tKT3nvwY6syleDMxlXTUm Nz+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698778763; x=1699383563; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EiRiYpRTXS+2WWemyWGygLIOM2rmQEI/Y7EUynmYac8=; b=Q8G3rqiF/8W2croJJlyo5qEAhehTHlmd/4q76PyE5p9OtUJwfNojdNac1Iy8zCzmWD lu1gi6w32mQRvhdw1EPHEq01Q1cV6ung4hNRptF7jxYwkz+u1mDkR15z9ienUwS6+2ka E+yhkI0tPGbfczJj0Xqdit2n56XLS+1PV08XDtNdNWthXbjnRm2iIkVOz4sKsaPh/xoM W6/OKyGFKw+UTiM+XbfVXZ7PpAUurq6b3darzuq72ke63fgwH4XQ1JyiC5Dnun57d4tx RVG/SokX/egeS90NB38g3nGXRkna7+iaOAbPDKrcG6y4233fwt5RnFonDpUP9WTXBXO6 12/Q== X-Gm-Message-State: AOJu0YxRzImUbAHdiOKSlGU00CZc1kJZOpDXLw7LyDo1HrCtJW5YoZVT WzMGnqJ6Gi7uW9MrZYoM7JKkcvfMG8M= X-Google-Smtp-Source: AGHT+IGRWNB7AUG9NewNZC6cMyigZR1cYoXB0LYa4TZHvYUtXWBn8gET3FukM88Qw9MLeMMXqAAxjw== X-Received: by 2002:a05:6a20:d419:b0:171:737:dfaf with SMTP id il25-20020a056a20d41900b001710737dfafmr13355227pzb.5.1698778762747; Tue, 31 Oct 2023 11:59:22 -0700 (PDT) Received: from dhcp-10-231-55-133.dhcp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id bh6-20020a170902a98600b001c9d6923e7dsm1628657plb.222.2023.10.31.11.59.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Oct 2023 11:59:22 -0700 (PDT) From: Justin Tee To: linux-scsi@vger.kernel.org Cc: jsmart2021@gmail.com, justin.tee@broadcom.com, Justin Tee Subject: [PATCH 9/9] lpfc: Copyright updates for 14.2.0.16 patches Date: Tue, 31 Oct 2023 12:12:24 -0700 Message-Id: <20231031191224.150862-10-justintee8345@gmail.com> X-Mailer: git-send-email 2.38.0 In-Reply-To: <20231031191224.150862-1-justintee8345@gmail.com> References: <20231031191224.150862-1-justintee8345@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Update copyrights to 2023 for files modified in the 14.2.0.16 patch set. Signed-off-by: Justin Tee --- drivers/scsi/lpfc/lpfc_mbox.c | 2 +- drivers/scsi/lpfc/lpfc_mem.c | 2 +- drivers/scsi/lpfc/lpfc_sli.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_mbox.c b/drivers/scsi/lpfc/lpfc_mbox.c index b5ab44234f20..cadcd16494e1 100644 --- a/drivers/scsi/lpfc/lpfc_mbox.c +++ b/drivers/scsi/lpfc/lpfc_mbox.c @@ -1,7 +1,7 @@ /******************************************************************* * This file is part of the Emulex Linux Device Driver for * * Fibre Channel Host Bus Adapters. * - * Copyright (C) 2017-2022 Broadcom. All Rights Reserved. The term * + * Copyright (C) 2017-2023 Broadcom. All Rights Reserved. The term * * “Broadcom” refers to Broadcom Inc. and/or its subsidiaries. * * Copyright (C) 2004-2016 Emulex. All rights reserved. * * EMULEX and SLI are trademarks of Emulex. * diff --git a/drivers/scsi/lpfc/lpfc_mem.c b/drivers/scsi/lpfc/lpfc_mem.c index ef6e5256a35e..2697da3248b3 100644 --- a/drivers/scsi/lpfc/lpfc_mem.c +++ b/drivers/scsi/lpfc/lpfc_mem.c @@ -1,7 +1,7 @@ /******************************************************************* * This file is part of the Emulex Linux Device Driver for * * Fibre Channel Host Bus Adapters. * - * Copyright (C) 2017-2022 Broadcom. All Rights Reserved. The term * + * Copyright (C) 2017-2023 Broadcom. All Rights Reserved. The term * * “Broadcom” refers to Broadcom Inc. and/or its subsidiaries. * * Copyright (C) 2004-2014 Emulex. All rights reserved. * * EMULEX and SLI are trademarks of Emulex. * diff --git a/drivers/scsi/lpfc/lpfc_sli.h b/drivers/scsi/lpfc/lpfc_sli.h index 14b8b5a3addf..c911a39cb46b 100644 --- a/drivers/scsi/lpfc/lpfc_sli.h +++ b/drivers/scsi/lpfc/lpfc_sli.h @@ -1,7 +1,7 @@ /******************************************************************* * This file is part of the Emulex Linux Device Driver for * * Fibre Channel Host Bus Adapters. * - * Copyright (C) 2017-2022 Broadcom. All Rights Reserved. The term * + * Copyright (C) 2017-2023 Broadcom. All Rights Reserved. The term * * “Broadcom” refers to Broadcom Inc. and/or its subsidiaries. * * Copyright (C) 2004-2016 Emulex. All rights reserved. * * EMULEX and SLI are trademarks of Emulex. *