From patchwork Tue Aug 14 09:13:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 10565207 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 58AEA1390 for ; Tue, 14 Aug 2018 09:16:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 45C1A29755 for ; Tue, 14 Aug 2018 09:16:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 384482976A; Tue, 14 Aug 2018 09:16:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B607229755 for ; Tue, 14 Aug 2018 09:16:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729536AbeHNMDF (ORCPT ); Tue, 14 Aug 2018 08:03:05 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:37427 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728101AbeHNMDE (ORCPT ); Tue, 14 Aug 2018 08:03:04 -0400 Received: from wuerfel.lan ([109.193.40.16]) by mrelayeu.kundenserver.de (mreue101 [212.227.15.145]) with ESMTPA (Nemesis) id 0LeLhV-1gEwcS1sSb-00q9AS; Tue, 14 Aug 2018 11:16:37 +0200 From: Arnd Bergmann To: Todor Tomov , Mauro Carvalho Chehab Cc: Arnd Bergmann , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] [v2] media: camss: add missing includes Date: Tue, 14 Aug 2018 11:13:31 +0200 Message-Id: <20180814091636.1960071-1-arnd@arndb.de> X-Mailer: git-send-email 2.18.0 X-Provags-ID: V03:K1:npx7b+Dtsv5ytFB47WHxbwCCgjdGTMxx1vHB8UhCTI7HpRxlKEY Xs1VDJ1pp0lecLU+Rwaol4+RDmK5YuNCOtGb/AbIFxhFWx/lSQS2DQG/xv0NInZ097XjaT9 1FPT+2pG24j5AheSpe7FiXK2iLEPrr5CkpPHQgfmmjt8N0TJUNdnTsVhUFuPO32ektQMA97 bo5SXF0YevO85I2/ecP6A== X-UI-Out-Filterresults: notjunk:1;V01:K0:f9FyHfzR1JQ=:2hH7d0l6QP9rk7rocxdRxo dJ/ukr5dtnue8wXlNWHM7H+ehd0VR9LPZPu/y9AJphh2T5rHIQ9vkzQ81BwtOtBAyTGjKrg+0 lNfLSvEBrVjtghCSGG+mirVaFo9LqWe72b/bJZIP9WDdFVBXx8DONsifJC0M/EitlHN9gRPh4 0hR7gxh8EIxqAYk2Z3FXQrJXxtuYfxVx7YZtn5U+UIsTUP+n8CJcSWD4tnt05KkXkQEOM/6AW xPYjSjVr8ITXOVMYw3qDrdP71w9vMlfiqCXRpiH2jYIhterI60aAY7UOW2uqhG/3xIyXuK8DH kZvoKah/jIpmXBr2DALAaON5Ynja0sghbrqfMBe5S+KMVFY0XTYaDGWpGOx8eUlVKJbQAEPTt HfFf0iVOrhSqtw0DQgaxsn0GJ0ioD/yLo61QOetBbMoPVmfptHMVCG3Wn0I63z8FcbJjaDguQ Tee8YeyFh5WKkcpiF5XoeB9RV9vQ+IdPTLRk8Xf3tycnagnTz5vd3p+peFkYG+LmLf5dTGQMk U5hB287y566JlQpbVfQxDgXF2MkgvXEdpyo4Lwy7GdB28QLORlFIX8xqK5HnNvAYC708U6hCh Uj9+xOfvcaiReK637aVqnWRMer6kNsorCRfTySaG53bUmNyAAQT+od6QpXcRKB98dK9VYl/WP wCLc/UqtczqUpQB5ath3olBwYydAZNgCrEvjgjUdTYSdsKcreOpvNrlM4s+BeKr/7egA= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Multiple files in this driver fail to build because of missing header inclusions: drivers/media/platform/qcom/camss/camss-csiphy-2ph-1-0.c: In function 'csiphy_hw_version_read': drivers/media/platform/qcom/camss/camss-csiphy-2ph-1-0.c:31:18: error: implicit declaration of function 'readl_relaxed'; did you mean 'xchg_relaxed'? [-Werror=implicit-function-declaration] drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c: In function 'csiphy_hw_version_read': drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c:52:2: error: implicit declaration of function 'writel' [-Werror=implicit-function-declaration] drivers/media/platform/qcom/camss/camss-ispif.c: In function 'msm_ispif_subdev_init': drivers/media/platform/qcom/camss/camss-ispif.c:1079:16: error: implicit declaration of function 'kcalloc'; did you mean 'kvcalloc'? [-Werror=implicit-function-declaration] Add the ones that I observed, plus linux/io.h in all other files that call readl/writel and related interfaces. Signed-off-by: Arnd Bergmann Acked-by: Todor Tomov --- v2: actually add the linux/io.h instances for files that did not show the error but might still be affected because of the readl/writel usage --- drivers/media/platform/qcom/camss/camss-csid.c | 1 + drivers/media/platform/qcom/camss/camss-csiphy-2ph-1-0.c | 1 + drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c | 1 + drivers/media/platform/qcom/camss/camss-csiphy.c | 1 + drivers/media/platform/qcom/camss/camss-ispif.c | 2 ++ drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 1 + drivers/media/platform/qcom/camss/camss-vfe-4-7.c | 1 + 7 files changed, 8 insertions(+) diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c index 729b31891466..a5ae85674ffb 100644 --- a/drivers/media/platform/qcom/camss/camss-csid.c +++ b/drivers/media/platform/qcom/camss/camss-csid.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-2ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-2ph-1-0.c index c832539397d7..12bce391d71f 100644 --- a/drivers/media/platform/qcom/camss/camss-csiphy-2ph-1-0.c +++ b/drivers/media/platform/qcom/camss/camss-csiphy-2ph-1-0.c @@ -12,6 +12,7 @@ #include #include +#include #define CAMSS_CSI_PHY_LNn_CFG2(n) (0x004 + 0x40 * (n)) #define CAMSS_CSI_PHY_LNn_CFG3(n) (0x008 + 0x40 * (n)) diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c index bcd0dfd33618..2e65caf1ecae 100644 --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c @@ -12,6 +12,7 @@ #include #include +#include #define CSIPHY_3PH_LNn_CFG1(n) (0x000 + 0x100 * (n)) #define CSIPHY_3PH_LNn_CFG1_SWI_REC_DLY_PRG (BIT(7) | BIT(6)) diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.c b/drivers/media/platform/qcom/camss/camss-csiphy.c index 4559f3b1b38c..008afb85023b 100644 --- a/drivers/media/platform/qcom/camss/camss-csiphy.c +++ b/drivers/media/platform/qcom/camss/camss-csiphy.c @@ -10,6 +10,7 @@ #include #include #include +#include #include #include #include diff --git a/drivers/media/platform/qcom/camss/camss-ispif.c b/drivers/media/platform/qcom/camss/camss-ispif.c index 7f269021d08c..d824c4958c07 100644 --- a/drivers/media/platform/qcom/camss/camss-ispif.c +++ b/drivers/media/platform/qcom/camss/camss-ispif.c @@ -10,11 +10,13 @@ #include #include #include +#include #include #include #include #include #include +#include #include #include #include diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c index da3a9fed9f2d..174a36be6f5d 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c +++ b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c @@ -9,6 +9,7 @@ */ #include +#include #include #include "camss-vfe.h" diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c index 4c584bffd179..0dca8bf9281e 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c +++ b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c @@ -9,6 +9,7 @@ */ #include +#include #include #include "camss-vfe.h"