From patchwork Sat Nov 11 11:04:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yun Levi X-Patchwork-Id: 13453058 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2BE0C4332F for ; Sat, 11 Nov 2023 11:04:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71DE228001D; Sat, 11 Nov 2023 06:04:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CE278D0003; Sat, 11 Nov 2023 06:04:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 595DA28001D; Sat, 11 Nov 2023 06:04:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 495AC8D0003 for ; Sat, 11 Nov 2023 06:04:26 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D28758124C for ; Sat, 11 Nov 2023 11:04:23 +0000 (UTC) X-FDA: 81445389606.08.A9F9166 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by imf09.hostedemail.com (Postfix) with ESMTP id 130E1140022 for ; Sat, 11 Nov 2023 11:04:21 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ehRm3gKc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of ppbuk5246@gmail.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=ppbuk5246@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699700662; a=rsa-sha256; cv=none; b=LM+7Ubl3GypZv5Jrx4Zs1dfSCn6CCFpjsa8fJLCVJgLe0BcFy88gHfJkCBzcQVO6WhdnmP MRcv9F+RWE6VSdCsOqc3yl1XCDjCVbkoZjqii36LLrHpz6TrFGh6I/ZQfN3RuTjo2+uHNg g/k/pXh0le7zRpLPZzCsKBl7Xy2khe0= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ehRm3gKc; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of ppbuk5246@gmail.com designates 209.85.221.41 as permitted sender) smtp.mailfrom=ppbuk5246@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699700662; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=8r0FmZTR6STnmbPAV9YPLA4Axw4SVrkLLNyDLZCWi9E=; b=lrr5cvT7UtI2EeUWZ/Qv9BriESMxJ8DSZ2Zi1ZE1ntXN5YcZqFxdbTk79woJZqCCAXtPR4 4CK+PQTNv4Lz7eyVh4uCIe9eBZGJCy/GKGJfQNk5HXR+TPOFGPcR7ICJSZuSdPVKG9p9Gg Z4gZ3Rj+U1oN5FnGUqTTBAX74t0AJ90= Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-32fdd0774d9so1710434f8f.2 for ; Sat, 11 Nov 2023 03:04:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699700660; x=1700305460; darn=kvack.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8r0FmZTR6STnmbPAV9YPLA4Axw4SVrkLLNyDLZCWi9E=; b=ehRm3gKcad7cvVKwEJBNa5f6sTfANTL1ijJKHiTJ7JeOUa1/nHxvJ77wT+TZIzacK+ iO5YKujMbUl1Yc9wyoYH58V0wJ1y5KfgfzkRxdvvFQ0Ud65sXmAuI9aHHVWgZahQYFJ9 bU/majaKGEEPuiiK8/i8UmZB+qG/7ZstLjQ92VX8x+vVUK/Kwv7sC3MJJzsuzdoFZwqu Kih5FGQiL9Hcp9l8Kz+iDLVRK7nubMWtKlQXnzsulnTL2gIqUBg3unkQPtY9iEtfLpqR VpoOv3WWgdcYVZ9ygybGkSD0FhmWKW0cLpFx4IA93b/LIEEnONAT5X1r9ZjqgferS/zb aSJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699700660; x=1700305460; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8r0FmZTR6STnmbPAV9YPLA4Axw4SVrkLLNyDLZCWi9E=; b=Jcy29GOdxZRy4+HU1LE+1QSMjM9GnjWf9Y/iSUYCH2VTySdwm/UubLezwmYQORmf/U 1VHhG7zyZmvYIsxG67gFw2g9dbMbU+mwmqvJxf5Lhj5Hg9j3wozBE/gBDMMT1xZigZMn AaElYBy0/5aYkCi1k5SW9tY/joi9I/xFcYwBxZ939qInDSbVLeNvOIpD89AbH19kEL62 q+L9bs2rVS9ngSore91xmJ2+5IYDnHXaFQC1up9V4boJLyqSchBFDy9KWSn+mda4VYL4 RNePKwR+B4rxhW0d1gcyFRJSPiZsqdII7FVANLRZk6hM+RywZpyg5zgeTE4IGWwq9cLC gOsQ== X-Gm-Message-State: AOJu0YyVVxQGAUe0D8n9nFTTS/zlUeeaDCgR6hf+QynPXkPeGKezjNR6 c86fDOV7ZnY1PS9aDQrgG3Q= X-Google-Smtp-Source: AGHT+IFGGh2/+JeObHNUzTNlG2D+WWzZRL26L+sR+3Bg51BU7nIBEbjruszGooz2Mxdqo1sw2tdZqg== X-Received: by 2002:a05:6000:154d:b0:32d:8f4c:a70b with SMTP id 13-20020a056000154d00b0032d8f4ca70bmr1571057wry.9.1699700660330; Sat, 11 Nov 2023 03:04:20 -0800 (PST) Received: from localhost.localdomain (host86-136-214-82.range86-136.btcentralplus.com. [86.136.214.82]) by smtp.gmail.com with ESMTPSA id d1-20020a5d6441000000b0032f7f4d008dsm1256652wrw.20.2023.11.11.03.04.19 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 11 Nov 2023 03:04:19 -0800 (PST) From: Levi Yun To: Liam.Howlett@oracle.com Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Levi Yun Subject: [PATCH] maple_tree: remove mast_overflow. Date: Sat, 11 Nov 2023 11:04:17 +0000 Message-ID: <20231111110417.38655-1-ppbuk5246@gmail.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 130E1140022 X-Stat-Signature: depoabwr5qtfz1k4rpcoym7nb19zu9a9 X-HE-Tag: 1699700661-418364 X-HE-Meta: U2FsdGVkX19Gy0F0IycHZJ6EuLntfbtZkC3jc1AMlAHgZgdD95WVX/hS1Mz8CuoXD7uhK/dYwhHXPR5U2hqBDyAxPiHjoGAjSsxArGSrQ1ErdZyaKzJ6H0p+t9kDuet1AfkVtw+aY19xRNEdqNAb5uWM4JbSRBjwd7DDkcQRGEPoXss0ZkUfndpoHxYT/xZd98tj9uW3BVrmxVRsWf9Dt8yAUDxwVBhBoXsunbxchUI/s7msMrv+KClwqMdR60Ey1Y+cFkJQq6vOdArqarkSps/8WUdjQ8tvyv6gJalrwARovyEgFpoVY5u/NBSOoOtm953NNSiqcv7QSmlWQOpL8f8S+jvo2v2mUYoQCcyQ/waXa421ymcGSL77sqgtJgHBRlC8XJdHUOH53rOuGI7P9ShoXEp/8+9CBPpkwd1HXevJEon5gjumAnLaMrhXUNjLEqQL3Y+geJmzjeFkFDrInk8eDge0Y1lHRH1d/PVomo8ORliciqxdnT+wieWnHtghVeklA1ZG1W1lUaMH0pLUapOL7x6/GZx1ca0PFHC0LZTQouuVmy2wYIcQmpSPoOv6ikshr5V0/63WfwLJW2IEBQhJaOLcFPLT3J8sp/rke24YIvEdNgMBdZG7pwn0pgWWmZN7iJscL+bGACDCHtCFMwFdLxLjy1Dj3+1Ex+zzA1rSERxw9I2DD0mSJZV/HGySAVD0shs3qeb+CGhI+MyF53GAZWB0r7wrTlI1rO8TEKCPa4eIRjcWXG/982KjwFnkpr52OoMa6khPlhQHrSN4eXgIEg8JHxBRChxSWlKfA/K+21Ahp7YdaPy0aG30EvfKkYBrr+dOhVbi+eYc0j+KQJ8126SWnQqHdj2iMB6Rd/6VxtckTWnCbGxg9TuZKP3PDTzNvQaNkRMLevAzRfiq2IZsGDKLgAJxqzVtuMVOINbT/9vYYnwgbd78CLgfMU8zYvBoQCspmREpsbA77VU UR+Gx1JQ xjO4+nkJp3GGZW3zeezDt3xEu3ewQtIwXmKU1Y+G+Q2jC+17tZl8Y+UeoXjZqDI0R3Bn+szL8F3VMN0X6e06JzdT+gQGQEw40f/VPNdblLcPSs1b/RHdy3FE/3CLot78IC446Fd48e7j7FXAAo9mH+vGxHAQzCu8ZxLpvjoxrm4on0qIbFN6Mr8acIcFId/daSKYzP0+kyIIaDI3tGEiOGJJyGLXnR+jp2FyFy9kdJY00JJmONnrqd2s6s4mXy2wdLDEgQYe/Boo/vt3ceNgWaJN1mThNZg8ID710EO9ZFjNii+snmC517RJzvpaLJG6YDjf+3Udr0A01B247sfOXkw6SwcOQhLnspPiQOOwFqJI4cGqL8b7AKhY8sNUSie8fm9yEfn8EtK90OvlHjrx3l0crvkbFo7FZ3Hzh/3qGPx/mHasRD3jfQ1W8qQ9ed6IHlztPoPV0rrG+WHL+DpycoxxT+Mikyyans4hl55TgwxLEGsE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.051376, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: mast_overflow is used only in mas_spanning_rebalance. But when mast_sufficient is false, mast_overflow always returns false, and when mast_suffictent is true, it never reaches to mast_overflow in mas_spanning_rebalance. Therefore, mast_overflow is dead code in mas_spanning_rebalance. And there is no other usage of mast_overflow execpt mas_spanning_rebalance, Remove mast_overflow. Signed-off-by: Levi Yun --- lib/maple_tree.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/lib/maple_tree.c b/lib/maple_tree.c index bb24d84a4922..1e591e71621e 100644 --- a/lib/maple_tree.c +++ b/lib/maple_tree.c @@ -2767,19 +2767,6 @@ static inline bool mast_sufficient(struct maple_subtree_state *mast) return false; } -/* - * mast_overflow: Check if there is too much data in the subtree state for a - * single node. - * @mast: The maple subtree state - */ -static inline bool mast_overflow(struct maple_subtree_state *mast) -{ - if (mast->bn->b_end >= mt_slot_count(mast->orig_l->node)) - return true; - - return false; -} - static inline void *mtree_range_walk(struct ma_state *mas) { unsigned long *pivots; @@ -2934,9 +2921,6 @@ static int mas_spanning_rebalance(struct ma_state *mas, if (mast_sufficient(mast)) continue; - if (mast_overflow(mast)) - continue; - /* May be a new root stored in mast->bn */ if (mas_is_root_limits(mast->orig_l)) break;