From patchwork Wed Nov 22 00:42:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Holland X-Patchwork-Id: 13463781 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20021C61D85 for ; Wed, 22 Nov 2023 00:42:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=LjL4jtiUAbMznCC5TgX5ar/uoUrnnoQAhKKZmreZvO0=; b=EWOAlzSL8ZcYNM Eie10fnmo7bmPFGMuskJ8ktVEaGw6w7P26hEljHf/E8vrdHr7jXtWQYRRAdejBBEaZ95lSWI1WGE8 PB1Eip2YhRaaP4HefT5p9ghPQRp2KLbI8z6Z3/V09vsQmcq+Q2fYXYalMcVP5bqsBZC/33YjJs9nK Cph+DQHqxNZ6Ey97h5IyCRimrhQmvQnoeomieQSFzDzrfe+kqd3Ol5iTwnWR8/dQsShBg37kwzbf+ 8BozHOza/GO04+yNMo67C+A0tDJpbwnXrWZIIYrqsmdnROxMzaINs/oX12j40bnvLjUpRiSChN09S +MVBQJuCKy14SHsNJ9eQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r5bJy-000LRZ-2k; Wed, 22 Nov 2023 00:42:26 +0000 Received: from mail-oi1-x233.google.com ([2607:f8b0:4864:20::233]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r5bJv-000LQz-0y for linux-arm-kernel@lists.infradead.org; Wed, 22 Nov 2023 00:42:25 +0000 Received: by mail-oi1-x233.google.com with SMTP id 5614622812f47-3b6d88dbaa3so4046296b6e.1 for ; Tue, 21 Nov 2023 16:42:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; t=1700613742; x=1701218542; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3JAG0RDoM6r+OhcBNCljqVXixFJN9onE/iS8GXZuAZc=; b=ViLXChsgwYJYwCPbLLXK1QgHtY3ff4zwsfy5bfkBIeIwAsKP5824G1Go0DWBcXFgeR IoVZQusX2rCrKHtAmhYeMi9/xXdcQqZQ5AoWkqoUWo4mFY500pptUxWPhMZW41ETt5UE dGzRp+OZDBlq+L6OL3CwwieN7Fi2E4c8pzCOlETckOg+83N28IUK+aI6C61qAYexJvjn GvR0pyXPkq0vq6plRokCwezncoePGkOxnMloTYExEWnuPrVjWy+9SGHHyG7LZmamFdIC yI3H1962Zvc4gQaP60mVPH6Q4u7sZPZBNZILNwpO7toBvbC8wc76H0fgDJiRgZIKkWJd fOEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700613742; x=1701218542; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3JAG0RDoM6r+OhcBNCljqVXixFJN9onE/iS8GXZuAZc=; b=VPkEHsr3FJbZ2XCALGja/f5JD+XhTaEGq4vo9iMw+hAXErBoDf+6BN/Of4Dn9oeAEt M2vsI1IfWZpLwgiKrPszQZe6zK69Ux+nZ8AguOKXLx7eBuc/w6LYbftte6HXdTe3QFHr NMbXCu0vsR2IalsU4Pg62keWmQ401H7pPnKsAI5cZgMsYqbWKEnaYLsHP+obt6ZMWKD7 EYly2leg5kjsTkF7MIUAjI+XTHyzpYXToRnfMtB3i3j7kRxqYISwC2j4afG8fgYBUSI8 ZRzuwW0ULq0KWaAs6KXRoBEZ1g0p5SLzZ/S3T4D6FrYWH5C3wNj8fU/8S+BZb8Qd7cB7 /p1w== X-Gm-Message-State: AOJu0YyhPdxBdidoEOIn2L15b+aBbP4pnbTKRaAxVzYp4vrPV8KXAs5L VtbQKOpDxWT3eLte4Jbse2YInQ== X-Google-Smtp-Source: AGHT+IFtjceUKgV711uY05lmug8NPHDY9L8jlpd8D8wBrSUqKZ6rNZvgEDLVfLqCG+sn6SOl8BLolA== X-Received: by 2002:a05:6808:1693:b0:3b8:3ba9:b14b with SMTP id bb19-20020a056808169300b003b83ba9b14bmr1311964oib.43.1700613741892; Tue, 21 Nov 2023 16:42:21 -0800 (PST) Received: from sw06.internal.sifive.com ([4.53.31.132]) by smtp.gmail.com with ESMTPSA id z128-20020a636586000000b005b856fab5e9sm8382145pgb.18.2023.11.21.16.42.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 16:42:21 -0800 (PST) From: Samuel Holland To: Radhey Shyam Pandey Cc: Samuel Holland , Ariane Keller , Daniel Borkmann , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Michal Simek , Paolo Abeni , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH net] net: axienet: Fix check for partial TX checksum Date: Tue, 21 Nov 2023 16:42:17 -0800 Message-ID: <20231122004219.3504219-1-samuel.holland@sifive.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231121_164223_377053_665AD1B3 X-CRM114-Status: GOOD ( 12.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Due to a typo, the code checked the RX checksum feature in the TX path. Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver") Signed-off-by: Samuel Holland Reviewed-by: Andrew Lunn Reviewed-by: Radhey Shyam Pandey --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index 82d0d44b2b02..bf6e33990490 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -822,7 +822,7 @@ axienet_start_xmit(struct sk_buff *skb, struct net_device *ndev) if (lp->features & XAE_FEATURE_FULL_TX_CSUM) { /* Tx Full Checksum Offload Enabled */ cur_p->app0 |= 2; - } else if (lp->features & XAE_FEATURE_PARTIAL_RX_CSUM) { + } else if (lp->features & XAE_FEATURE_PARTIAL_TX_CSUM) { csum_start_off = skb_transport_offset(skb); csum_index_off = csum_start_off + skb->csum_offset; /* Tx Partial Checksum Offload Enabled */