From patchwork Wed Nov 22 22:12:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring (Arm)" X-Patchwork-Id: 13465490 Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FDB01B9; Wed, 22 Nov 2023 14:12:43 -0800 (PST) Received: by mail-io1-f49.google.com with SMTP id ca18e2360f4ac-7a93df91813so6579539f.2; Wed, 22 Nov 2023 14:12:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700691162; x=1701295962; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hU6Wnghj5KH1Ld3lLkNyhwgfAXJhDGyB0CCvRi7u8mk=; b=UthVPCrkPmuaSKUpj8hiQFvad2Bn3BhipezxF0q9MXsmZXF2YcmG67xt4d0EwJcAlt 1EGHrqmIS+C3trWjV+xrjV4+9QUxOzTmZ05uo0hlD/B7JSjAiLa026Tm62EmkbEda06t WEJk2EH85L7uFCpVtYQq/HFNuCoPQBCRgYecP5JKIbfu+v//01SyhKoA1f+f2HvjO/oL CSLwdjWd1S+RCnfJOMXHnHgVlmx7ayvUGGcqdkocLFPtW+u39r7HQMN8Rab2+0i8hnKz sza2ZakkiflBqx+x1KHtUkJmItDpQxZs0YSlT3q5a/8f6fs+pUblaILtz8AY2++7+5/Q INiA== X-Gm-Message-State: AOJu0YzL8w2dcOTnHFBHPGQZTRKtumb2Ljq4zhuVhxU5Kme2gs/ZYh27 jKitkDsZ8Z6nUMFEQugiY5x37Nh92w== X-Google-Smtp-Source: AGHT+IF8osr8TMYr2K7RbdJl1f0Qs0a8Vvy9ayPPg6W5HhHI5G6ri/6sDydnhfguLO7f2AvVQEKSig== X-Received: by 2002:a92:908:0:b0:359:d397:c806 with SMTP id y8-20020a920908000000b00359d397c806mr4100582ilg.18.1700691162319; Wed, 22 Nov 2023 14:12:42 -0800 (PST) Received: from herring.priv ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id r3-20020a92cd83000000b00357ce043118sm159221ilb.79.2023.11.22.14.12.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 14:12:41 -0800 (PST) Received: (nullmailer pid 2753836 invoked by uid 1000); Wed, 22 Nov 2023 22:12:33 -0000 From: Rob Herring Date: Wed, 22 Nov 2023 15:12:32 -0700 Subject: [PATCH v2 1/4] kbuild: Move dtc graph_child_address warning to W=2 Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231122-dtc-warnings-v2-1-bd4087325392@kernel.org> References: <20231122-dtc-warnings-v2-0-bd4087325392@kernel.org> In-Reply-To: <20231122-dtc-warnings-v2-0-bd4087325392@kernel.org> To: Masahiro Yamada , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Krzysztof Kozlowski , Alim Akhtar , Conor Dooley Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org X-Mailer: b4 0.13-dev There are cases where having a single child node with a unit-address is valid. For example, other child nodes may be optional or added via a DT overlay. This hasn't mattered until now, but as platforms become free of W=1 warnings, we want to enable W=1 by default on a per platform basis. So move the warning to W=2. In the process, the logic can be reworked a bit to avoid specifying a given warning in multiple places. Signed-off-by: Rob Herring --- scripts/Makefile.lib | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 68d0134bdbf9..a67f781ae8ee 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -340,8 +340,6 @@ quiet_cmd_gzip = GZIP $@ # DTC # --------------------------------------------------------------------------- DTC ?= $(objtree)/scripts/dtc/dtc -DTC_FLAGS += -Wno-interrupt_provider \ - -Wno-unique_unit_address # Disable noisy checks by default ifeq ($(findstring 1,$(KBUILD_EXTRA_WARN)),) @@ -357,9 +355,11 @@ endif ifneq ($(findstring 2,$(KBUILD_EXTRA_WARN)),) DTC_FLAGS += -Wnode_name_chars_strict \ - -Wproperty_name_chars_strict \ - -Winterrupt_provider \ - -Wunique_unit_address + -Wproperty_name_chars_strict +else +DTC_FLAGS += -Wno-interrupt_provider \ + -Wno-unique_unit_address \ + -Wno-graph_child_address endif DTC_FLAGS += $(DTC_FLAGS_$(basetarget)) From patchwork Wed Nov 22 22:12:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring (Arm)" X-Patchwork-Id: 13465492 Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93881D53; Wed, 22 Nov 2023 14:12:48 -0800 (PST) Received: by mail-io1-f54.google.com with SMTP id ca18e2360f4ac-7b350130c3fso6485339f.3; Wed, 22 Nov 2023 14:12:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700691168; x=1701295968; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SvKVScUhvKKHq5yH2cV8DV0lJfU3kh2MuS6ZYH4ebh8=; b=HiFRz5NnDAw1OP/A8dBJikYWxNB6udr/LmxBA+xh6y6ObJQxLUFsF++WmF7XMkT6NU U4srEvw8Wn7/T+qqbFdUU7CALMDXGALWdNwHJZxnTd6oEwlrEx4RicSGoFwrmVb+H2sJ nPRe5TYdx59t4LWVAaQea4Kzcq0/4icA2XRPrAu5sUg0e8eJTBzG1pRaUiPInCVuADLe lXxh1NvMeLloZcr5NRSd4KM8ymrgfZ/UdrcE7KUHSt4MSBUOcwD5wVQBAf6itQiWJVZU 5Vdzv71F0CY4M1Lcakdk4UUE3MV4hjvBTT145+GMnN/E7w7VyUUQGSUY9bVopYtu8w3G FHJQ== X-Gm-Message-State: AOJu0YzrahSUME/P+8BubZTGpuQAGnnQs3pC6N7u6k+YOrGNUWvTNS0h t+3pAnw+fHxKaqPJf5fH9w== X-Google-Smtp-Source: AGHT+IGLO9xpcHV8HSJx4kSfogE9LNdREnwsjAbOU8PWDbp45WItqfhi9+N7Ml1bG8W7Xsf1CyrYyw== X-Received: by 2002:a05:6602:2c96:b0:792:8d16:91ef with SMTP id i22-20020a0566022c9600b007928d1691efmr4004136iow.18.1700691167790; Wed, 22 Nov 2023 14:12:47 -0800 (PST) Received: from herring.priv ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id q10-20020a02a30a000000b0043a0aa909bfsm83341jai.159.2023.11.22.14.12.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 14:12:47 -0800 (PST) Received: (nullmailer pid 2753838 invoked by uid 1000); Wed, 22 Nov 2023 22:12:33 -0000 From: Rob Herring Date: Wed, 22 Nov 2023 15:12:33 -0700 Subject: [PATCH v2 2/4] kbuild: Allow arch/platform override of dtc warning level Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231122-dtc-warnings-v2-2-bd4087325392@kernel.org> References: <20231122-dtc-warnings-v2-0-bd4087325392@kernel.org> In-Reply-To: <20231122-dtc-warnings-v2-0-bd4087325392@kernel.org> To: Masahiro Yamada , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Krzysztof Kozlowski , Alim Akhtar , Conor Dooley Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org X-Mailer: b4 0.13-dev In order to allow enabling extra dtc warnings on a per arch or platform basis, define a new variable, KBUILD_EXTRA_WARN_DTC, which contains the warning level and can be set by an arch or platform independently of KBUILD_EXTRA_WARN. The default value is KBUILD_EXTRA_WARN as before. The platform setting and command line setting are merged. For example, with a platform that defaults to W=1, one can run 'make W=2 dtbs' which will enable both level 1 and 2 warnings. Signed-off-by: Rob Herring --- scripts/Makefile.lib | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index a67f781ae8ee..53a74e53e0ca 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -341,8 +341,10 @@ quiet_cmd_gzip = GZIP $@ # --------------------------------------------------------------------------- DTC ?= $(objtree)/scripts/dtc/dtc +KBUILD_EXTRA_WARN_DTC += $(KBUILD_EXTRA_WARN) + # Disable noisy checks by default -ifeq ($(findstring 1,$(KBUILD_EXTRA_WARN)),) +ifeq ($(findstring 1,$(KBUILD_EXTRA_WARN_DTC)),) DTC_FLAGS += -Wno-unit_address_vs_reg \ -Wno-avoid_unnecessary_addr_size \ -Wno-alias_paths \ @@ -353,7 +355,7 @@ DTC_FLAGS += \ -Wunique_unit_address_if_enabled endif -ifneq ($(findstring 2,$(KBUILD_EXTRA_WARN)),) +ifneq ($(findstring 2,$(KBUILD_EXTRA_WARN_DTC)),) DTC_FLAGS += -Wnode_name_chars_strict \ -Wproperty_name_chars_strict else From patchwork Wed Nov 22 22:12:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring (Arm)" X-Patchwork-Id: 13465491 Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8AC61BD; Wed, 22 Nov 2023 14:12:45 -0800 (PST) Received: by mail-il1-f169.google.com with SMTP id e9e14a558f8ab-359c1f42680so876265ab.2; Wed, 22 Nov 2023 14:12:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700691165; x=1701295965; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=shYyO58BPes3ozOUzmFhahNxoCiZTriaHChWVdh269w=; b=omMUj/9PmI/bVj2XUQJZ0AiwhwX9qoa4nFEKbAlgSRZPyU42S9f74UBXRARR0Zwgy7 NhhtmoTYfDCV4LFD0ZUSVs3jJZOl2dhE/j5O2/AenNl+BILKH3ztmQhJyVY585bqa3p0 BXnnjjOGdo8yavzG4tuE/ErJntQJU4t72nx2zpbW9nlWKGEEIF3n/exxSY6u7qoRL+z8 DdRBIM/uEZ5sQyc19qWeKZ9WwJ3zotIioH3xgQrmwRfua7R18PF7D+M+rXAPQ20+l683 wZMx6aIt8eqCeSMQeqHsAblCfUbHEQVtreyuJYsEnk200iq2h8hbsSdJSJKXOoUoNkTf CgGQ== X-Gm-Message-State: AOJu0YxRiXpIsAFED8Bxeb0izCY+RvV/Vf7+VqEUygUbR4UuLWODM+yp lxW/gfGhfK5pzvh7FNsXqZwV0nMDpw== X-Google-Smtp-Source: AGHT+IFMJzsEvpbSktexSSdFIfR9OaWDnu0zBfHOB7Y/r6iYkYi/TaZpUgTAHm5TMgYN9AvcD7iJ5A== X-Received: by 2002:a05:6e02:603:b0:357:704a:8699 with SMTP id t3-20020a056e02060300b00357704a8699mr3547266ils.8.1700691165100; Wed, 22 Nov 2023 14:12:45 -0800 (PST) Received: from herring.priv ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id em4-20020a0566384da400b0045b4a059a57sm91639jab.44.2023.11.22.14.12.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 14:12:44 -0800 (PST) Received: (nullmailer pid 2753840 invoked by uid 1000); Wed, 22 Nov 2023 22:12:33 -0000 From: Rob Herring Date: Wed, 22 Nov 2023 15:12:34 -0700 Subject: [PATCH v2 3/4] riscv: dts: Always enable extra W=1 warnings Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231122-dtc-warnings-v2-3-bd4087325392@kernel.org> References: <20231122-dtc-warnings-v2-0-bd4087325392@kernel.org> In-Reply-To: <20231122-dtc-warnings-v2-0-bd4087325392@kernel.org> To: Masahiro Yamada , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Krzysztof Kozlowski , Alim Akhtar , Conor Dooley Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org X-Mailer: b4 0.13-dev As all RISC-V .dts files are W=1 clean, enable the W=1 warnings all the time. Signed-off-by: Rob Herring --- arch/riscv/boot/dts/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/riscv/boot/dts/Makefile b/arch/riscv/boot/dts/Makefile index 72030fd727af..a7b17e0ac8c8 100644 --- a/arch/riscv/boot/dts/Makefile +++ b/arch/riscv/boot/dts/Makefile @@ -1,4 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 + +export KBUILD_EXTRA_WARN_DTC=1 + subdir-y += allwinner subdir-y += canaan subdir-y += microchip From patchwork Wed Nov 22 22:12:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring (Arm)" X-Patchwork-Id: 13465489 Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from mail-il1-f176.google.com (mail-il1-f176.google.com [209.85.166.176]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DDDCB9; Wed, 22 Nov 2023 14:12:40 -0800 (PST) Received: by mail-il1-f176.google.com with SMTP id e9e14a558f8ab-35937f2fadeso858685ab.2; Wed, 22 Nov 2023 14:12:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700691159; x=1701295959; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oQrmqAZcdIuXmqszFM5kR+KdU7shYUbjsm44jbecVtk=; b=HmmXPwzc50joKTkOWtAw3+vfvwRiCJwUxb66bn0t0RkrnwXrWSRk3c6b5Shvdoh2sU 1Ws/58s/BN2eTAn9XZvjg6u01uhbmcGAOH7EnsT+kTbG2DIzyuyoxcgEUpJSXFmnJePk QQFX+2Kc5fgSuinpVmNBN0WU84ER/oosxaKkNnMFeDluUotIq3Bd6gjBQR3ybPRhwEjb 3YjUYSLEYZ36hbpwG01KySCr8IpTslGHW3dGY/IF9WMA4uRhuAgeCglzQNyCJgSACRSa P63Vid7B+ctDcka/yhDiQzEvFAXyWjeYu/OLlYTrWUwkdQoXBUUVmXBRHUsORX3WYomF TyAA== X-Gm-Message-State: AOJu0YwUMbJYNNiUHMB89pLYoBA7II/J2cjO01l4lvOT9QyA4sONZp2z KAWDU3LqmPgemTxsBpStKA== X-Google-Smtp-Source: AGHT+IGj21a13xz1WqdS/H6Nqa3rnnJqU98fDkeH4YoBfe8sZRN0UwRgSamoEKVV6rR3nWw7fbCw5w== X-Received: by 2002:a92:c5cb:0:b0:35b:110f:8127 with SMTP id s11-20020a92c5cb000000b0035b110f8127mr3639999ilt.26.1700691159445; Wed, 22 Nov 2023 14:12:39 -0800 (PST) Received: from herring.priv ([64.188.179.252]) by smtp.gmail.com with ESMTPSA id y17-20020a056e02119100b0035b19b773b8sm159259ili.59.2023.11.22.14.12.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Nov 2023 14:12:38 -0800 (PST) Received: (nullmailer pid 2753842 invoked by uid 1000); Wed, 22 Nov 2023 22:12:33 -0000 From: Rob Herring Date: Wed, 22 Nov 2023 15:12:35 -0700 Subject: [PATCH v2 4/4] arm/arm64: dts: samsung: Always enable extra W=1 warnings Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231122-dtc-warnings-v2-4-bd4087325392@kernel.org> References: <20231122-dtc-warnings-v2-0-bd4087325392@kernel.org> In-Reply-To: <20231122-dtc-warnings-v2-0-bd4087325392@kernel.org> To: Masahiro Yamada , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Krzysztof Kozlowski , Alim Akhtar , Conor Dooley Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org X-Mailer: b4 0.13-dev Samsung platforms are clean of W=1 dtc warnings, so enable the warnings by default. This way submitters don't have to remember to run a W=1 build of the .dts files and the grumpiness of the maintainers can be reduced. Signed-off-by: Rob Herring Reviewed-by: Krzysztof Kozlowski --- v2: - Use new variable name --- arch/arm/boot/dts/samsung/Makefile | 3 +++ arch/arm64/boot/dts/exynos/Makefile | 3 +++ 2 files changed, 6 insertions(+) diff --git a/arch/arm/boot/dts/samsung/Makefile b/arch/arm/boot/dts/samsung/Makefile index 7becf36656b1..fffc5c45d441 100644 --- a/arch/arm/boot/dts/samsung/Makefile +++ b/arch/arm/boot/dts/samsung/Makefile @@ -1,4 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 + +KBUILD_EXTRA_WARN_DTC=1 + dtb-$(CONFIG_ARCH_EXYNOS3) += \ exynos3250-artik5-eval.dtb \ exynos3250-monk.dtb \ diff --git a/arch/arm64/boot/dts/exynos/Makefile b/arch/arm64/boot/dts/exynos/Makefile index 6e4ba69268e5..9cb188ef470d 100644 --- a/arch/arm64/boot/dts/exynos/Makefile +++ b/arch/arm64/boot/dts/exynos/Makefile @@ -1,4 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 + +KBUILD_EXTRA_WARN_DTC=1 + dtb-$(CONFIG_ARCH_EXYNOS) += \ exynos5433-tm2.dtb \ exynos5433-tm2e.dtb \