From patchwork Thu Nov 23 07:37:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Vetrini X-Patchwork-Id: 13465893 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B548EC5AD4C for ; Thu, 23 Nov 2023 07:46:50 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.639390.996711 (Exim 4.92) (envelope-from ) id 1r64Q2-00013I-Vf; Thu, 23 Nov 2023 07:46:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 639390.996711; Thu, 23 Nov 2023 07:46:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r64Q2-00013B-RY; Thu, 23 Nov 2023 07:46:38 +0000 Received: by outflank-mailman (input) for mailman id 639390; Thu, 23 Nov 2023 07:46:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r64Hp-0004g4-5G for xen-devel@lists.xenproject.org; Thu, 23 Nov 2023 07:38:09 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3e8e0aff-89d3-11ee-9b0e-b553b5be7939; Thu, 23 Nov 2023 08:38:07 +0100 (CET) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id 0A8124EE0747; Thu, 23 Nov 2023 08:38:05 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e8e0aff-89d3-11ee-9b0e-b553b5be7939 From: Nicola Vetrini To: nicola.vetrini@bugseng.com, xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, jbeulich@suse.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, George Dunlap , Julien Grall , Wei Liu Subject: [XEN PATCH v3 1/2] xen/vmap: use ISOLATE_LSB to wrap a violation of Rule 10.1 Date: Thu, 23 Nov 2023 08:37:54 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 No functional change. Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini --- Changes in v2: - Changed macro name Changes in v3: - Changed macro name --- xen/common/vmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/vmap.c b/xen/common/vmap.c index 4fd6b3067ec1..330e2ba897d7 100644 --- a/xen/common/vmap.c +++ b/xen/common/vmap.c @@ -53,7 +53,7 @@ static void *vm_alloc(unsigned int nr, unsigned int align, if ( !align ) align = 1; else if ( align & (align - 1) ) - align &= -align; + align = ISOLATE_LSB(align); ASSERT((t >= VMAP_DEFAULT) && (t < VMAP_REGION_NR)); if ( !vm_base[t] ) From patchwork Thu Nov 23 07:37:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Vetrini X-Patchwork-Id: 13465882 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2AC39C5AD4C for ; Thu, 23 Nov 2023 07:38:21 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.639378.996691 (Exim 4.92) (envelope-from ) id 1r64Hq-0006gr-Va; Thu, 23 Nov 2023 07:38:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 639378.996691; Thu, 23 Nov 2023 07:38:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r64Hq-0006gk-RO; Thu, 23 Nov 2023 07:38:10 +0000 Received: by outflank-mailman (input) for mailman id 639378; Thu, 23 Nov 2023 07:38:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r64Hp-0004t9-FC for xen-devel@lists.xenproject.org; Thu, 23 Nov 2023 07:38:09 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3f0c32bb-89d3-11ee-98e2-6d05b1d4d9a1; Thu, 23 Nov 2023 08:38:08 +0100 (CET) Received: from nico.bugseng.com (unknown [147.123.100.131]) by support.bugseng.com (Postfix) with ESMTPSA id A73B14EE0C89; Thu, 23 Nov 2023 08:38:07 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f0c32bb-89d3-11ee-98e2-6d05b1d4d9a1 From: Nicola Vetrini To: nicola.vetrini@bugseng.com, xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, jbeulich@suse.com, andrew.cooper3@citrix.com, roger.pau@citrix.com, Paul Durrant Subject: [XEN PATCH v3 2/2] xen/iommu: use ISOLATE_LSB to wrap a violation of Rule 10.1 Date: Thu, 23 Nov 2023 08:37:55 +0100 Message-Id: <864df3cff95b6dde17ebd7af6d814f79a0ab2044.1700724699.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 No functional change. Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini Acked-by: Jan Beulich --- Changes in v2: - Changed macro name Changes in v3: - Changed macro name --- xen/drivers/passthrough/iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index f9a9f53dbd44..996c31be1284 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -560,7 +560,7 @@ int __init iommu_setup(void) rc = iommu_hardware_setup(); if ( !rc ) ops = iommu_get_ops(); - if ( ops && (ops->page_sizes & -ops->page_sizes) != PAGE_SIZE ) + if ( ops && (ISOLATE_LSB(ops->page_sizes)) != PAGE_SIZE ) { printk(XENLOG_ERR "IOMMU: page size mask %lx unsupported\n", ops->page_sizes);