From patchwork Thu Nov 23 14:27:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Baokun Li X-Patchwork-Id: 13466296 Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AFF119E for ; Thu, 23 Nov 2023 06:23:23 -0800 (PST) Received: from dggpeml500021.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4SbgGK29PFzPpXm; Thu, 23 Nov 2023 22:19:05 +0800 (CST) Received: from huawei.com (10.175.127.227) by dggpeml500021.china.huawei.com (7.185.36.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 23 Nov 2023 22:23:21 +0800 From: Baokun Li To: CC: , , , , , , Subject: [PATCH v4] ext4: Regression test of ext4_lblk_t overflow Date: Thu, 23 Nov 2023 22:27:20 +0800 Message-ID: <20231123142720.4107258-1-libaokun1@huawei.com> X-Mailer: git-send-email 2.31.1 Precedence: bulk X-Mailing-List: fstests@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpeml500021.china.huawei.com (7.185.36.21) X-CFilter-Loop: Reflected Append writes to a file with logical block numbers close to 0xffffffff and observe if a kernel crash is caused by ext4_lblk_t overflow triggering BUG_ON at ext4_mb_new_inode_pa(). This is a regression test for commit bc056e7163ac ("ext4: fix BUG in ext4_mb_new_inode_pa() due to overflow") Signed-off-by: Baokun Li --- V1->V2: Changes to make the use case more generic, not just for testing ext4.(ext4 and xfs have been tested) V2->V3: Clean up the code and remove hardcoding. V3->V4: Correct the description and modify finsert related code to make the test case easier to understand. tests/generic/737 | 54 +++++++++++++++++++++++++++++++++++++++++++ tests/generic/737.out | 2 ++ 2 files changed, 56 insertions(+) create mode 100755 tests/generic/737 create mode 100644 tests/generic/737.out diff --git a/tests/generic/737 b/tests/generic/737 new file mode 100755 index 00000000..59bd2217 --- /dev/null +++ b/tests/generic/737 @@ -0,0 +1,54 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2023 HUAWEI. All Rights Reserved. +# +# FS QA Test No. 737 +# +# Append writes to a file with logical block numbers close to 0xffffffff +# and observe if a kernel crash is caused by ext4_lblk_t overflow triggering +# BUG_ON at ext4_mb_new_inode_pa(). This is a regression test for commit +# bc056e7163ac ("ext4: fix BUG in ext4_mb_new_inode_pa() due to overflow") +# +. ./common/preamble +. ./common/populate +_begin_fstest auto quick insert prealloc + +# real QA test starts here +[[ "$FSTYP" =~ ext* ]] && _fixed_by_kernel_commit bc056e7163ac \ + "ext4: fix BUG in ext4_mb_new_inode_pa() due to overflow" + +_require_odirect +_require_xfs_io_command "falloc" +_require_xfs_io_command "finsert" + +dev_size=$((100 * 1024 * 1024)) +_scratch_mkfs_sized $dev_size >>$seqres.full 2>&1 || _fail "mkfs failed" + +_scratch_mount +file_blksz="$(_get_file_block_size ${SCRATCH_MNT})" + +# Reserve 1M space +$XFS_IO_PROG -f -c "falloc 0 1M" "${SCRATCH_MNT}/tmp" >> $seqres.full + +# Create a file with logical block numbers close to 0xffffffff +$XFS_IO_PROG -f -c "falloc 0 10M" "${SCRATCH_MNT}/file" >> $seqres.full +max_pos=$(( 0xffffffff * file_blksz )) +finsert_len=$(( max_pos - ((10 + 3) << 20) )) +$XFS_IO_PROG -f -c "finsert 1M ${finsert_len}" "${SCRATCH_MNT}/file" >> $seqres.full + +# Filling up the free space ensures that the pre-allocated space is the reserved space. +nr_free=$(stat -f -c '%f' ${SCRATCH_MNT}) +_fill_fs $((nr_free * file_blksz)) ${SCRATCH_MNT}/fill $file_blksz 0 >> $seqres.full 2>&1 +sync + +# Remove reserved space to gain free space for allocation +rm -f ${SCRATCH_MNT}/tmp + +# Trying to allocate two blocks triggers BUG_ON. +$XFS_IO_PROG -c "open -ad ${SCRATCH_MNT}/file" -c "pwrite -S 0xff 0 $((2 * file_blksz))" >> $seqres.full + +echo "Silence is golden" + +# success, all done +status=0 +exit diff --git a/tests/generic/737.out b/tests/generic/737.out new file mode 100644 index 00000000..67b83d78 --- /dev/null +++ b/tests/generic/737.out @@ -0,0 +1,2 @@ +QA output created by 737 +Silence is golden