From patchwork Fri Nov 24 17:40:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grant Erickson X-Patchwork-Id: 13468075 Received: from mohas.pair.com (mohas.pair.com [209.68.5.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FF5131740 for ; Fri, 24 Nov 2023 17:40:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nuovations.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nuovations.com Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from mohas.pair.com (localhost [127.0.0.1]) by mohas.pair.com (Postfix) with ESMTP id 0F55E730FB for ; Fri, 24 Nov 2023 12:40:28 -0500 (EST) Received: from localhost.localdomain (unknown [IPv6:2601:647:5a00:15c1:230d:b2c9:c388:f96b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mohas.pair.com (Postfix) with ESMTPSA id B24397310A for ; Fri, 24 Nov 2023 12:40:27 -0500 (EST) From: Grant Erickson To: connman@lists.linux.dev Subject: [PATCH v2 1/3] service: Leverage 'connman_service_is_default'. Date: Fri, 24 Nov 2023 09:40:23 -0800 Message-ID: <20231124174025.971512-2-gerickson@nuovations.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231124174025.971512-1-gerickson@nuovations.com> References: <20231116030912.636756-1-gerickson@nuovations.com> <20231124174025.971512-1-gerickson@nuovations.com> Precedence: bulk X-Mailing-List: connman@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: mailmunge 3.11 on 209.68.5.112 This leverages the recently-added 'connman_service_is_default' in 'address_updated' rather than duplicating the same logic from the former in the latter. --- src/service.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/service.c b/src/service.c index dd50b81a7e5a..b98ec00f808c 100644 --- a/src/service.c +++ b/src/service.c @@ -2239,7 +2239,7 @@ static void address_updated(struct connman_service *service, enum connman_ipconfig_type type) { if (is_connected(service->state) && - service == connman_service_get_default()) { + connman_service_is_default(service)) { nameserver_remove_all(service, type); nameserver_add_all(service, type); start_online_check(service, type); From patchwork Fri Nov 24 17:40:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grant Erickson X-Patchwork-Id: 13468077 Received: from mohas.pair.com (mohas.pair.com [209.68.5.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 885D8381D4 for ; Fri, 24 Nov 2023 17:40:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nuovations.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nuovations.com Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from mohas.pair.com (localhost [127.0.0.1]) by mohas.pair.com (Postfix) with ESMTP id 865AB73104 for ; Fri, 24 Nov 2023 12:40:28 -0500 (EST) Received: from localhost.localdomain (unknown [IPv6:2601:647:5a00:15c1:230d:b2c9:c388:f96b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mohas.pair.com (Postfix) with ESMTPSA id 3450273127 for ; Fri, 24 Nov 2023 12:40:28 -0500 (EST) From: Grant Erickson To: connman@lists.linux.dev Subject: [PATCH v2 2/3] service: Add DBG statement to 'address_updated'. Date: Fri, 24 Nov 2023 09:40:24 -0800 Message-ID: <20231124174025.971512-3-gerickson@nuovations.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231124174025.971512-1-gerickson@nuovations.com> References: <20231116030912.636756-1-gerickson@nuovations.com> <20231124174025.971512-1-gerickson@nuovations.com> Precedence: bulk X-Mailing-List: connman@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: mailmunge 3.11 on 209.68.5.112 This adds a DBG statement to 'address_upated' to aid in debugging. --- src/service.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/service.c b/src/service.c index b98ec00f808c..ce02aa62fb7c 100644 --- a/src/service.c +++ b/src/service.c @@ -2238,6 +2238,11 @@ void __connman_service_wispr_start(struct connman_service *service, static void address_updated(struct connman_service *service, enum connman_ipconfig_type type) { + DBG("service %p (%s) type %d (%s)", + service, + connman_service_get_identifier(service), + type, __connman_ipconfig_type2string(type)); + if (is_connected(service->state) && connman_service_is_default(service)) { nameserver_remove_all(service, type); From patchwork Fri Nov 24 17:40:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grant Erickson X-Patchwork-Id: 13468076 Received: from mohas.pair.com (mohas.pair.com [209.68.5.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE89325749 for ; Fri, 24 Nov 2023 17:40:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nuovations.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nuovations.com Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from mohas.pair.com (localhost [127.0.0.1]) by mohas.pair.com (Postfix) with ESMTP id 00C4373106 for ; Fri, 24 Nov 2023 12:40:29 -0500 (EST) Received: from localhost.localdomain (unknown [IPv6:2601:647:5a00:15c1:230d:b2c9:c388:f96b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mohas.pair.com (Postfix) with ESMTPSA id ACC737313E for ; Fri, 24 Nov 2023 12:40:28 -0500 (EST) From: Grant Erickson To: connman@lists.linux.dev Subject: [PATCH v2 3/3] service: Add documentation to 'address_updated'. Date: Fri, 24 Nov 2023 09:40:25 -0800 Message-ID: <20231124174025.971512-4-gerickson@nuovations.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231124174025.971512-1-gerickson@nuovations.com> References: <20231116030912.636756-1-gerickson@nuovations.com> <20231124174025.971512-1-gerickson@nuovations.com> Precedence: bulk X-Mailing-List: connman@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Scanned-By: mailmunge 3.11 on 209.68.5.112 This adds documentation to the 'address_updated' function. --- src/service.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/src/service.c b/src/service.c index ce02aa62fb7c..86eb74d26c6e 100644 --- a/src/service.c +++ b/src/service.c @@ -2235,6 +2235,33 @@ void __connman_service_wispr_start(struct connman_service *service, online_check_connect_timeout_ms, complete_online_check); } +/** + * @brief + * Handle an update to the address(es) for the specified network + * service and IP configuration type. + * + * This attempts to handle an address change or update for the + * specified network service and IP configuration type if and only if + * it is connected (that is, #is_connected returns true) and it is + * the default service (that is, has the default route). + * + * If the service meets those criteria, then nameservers are + * refreshed, an "online" HTTP-based Internet reachability check is + * initiated, and a time-of-day synchronization is requested. + * + * @param[in,out] service A pointer to the mutable network service + * for which there was an address change or + * update. + * @param[in] type The IP configuration type for @a service + * for which there was an address change or + * update. + * + * @sa nameserver_remove_all + * @sa nameserver_add_all + * @sa start_online_check + * @sa __connman_timeserver_sync + * + */ static void address_updated(struct connman_service *service, enum connman_ipconfig_type type) {