From patchwork Wed Nov 29 15:24:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Vetrini X-Patchwork-Id: 13473012 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2537FC10DAA for ; Wed, 29 Nov 2023 15:25:09 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.643990.1004559 (Exim 4.92) (envelope-from ) id 1r8MQi-0001Pw-5X; Wed, 29 Nov 2023 15:24:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 643990.1004559; Wed, 29 Nov 2023 15:24:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r8MQi-0001Pp-1T; Wed, 29 Nov 2023 15:24:48 +0000 Received: by outflank-mailman (input) for mailman id 643990; Wed, 29 Nov 2023 15:24:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r8MQg-0001PY-Ft for xen-devel@lists.xenproject.org; Wed, 29 Nov 2023 15:24:46 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6cd696df-8ecb-11ee-98e3-6d05b1d4d9a1; Wed, 29 Nov 2023 16:24:45 +0100 (CET) Received: from nico.bugseng.com (unknown [147.123.100.152]) by support.bugseng.com (Postfix) with ESMTPSA id 675114EE073E; Wed, 29 Nov 2023 16:24:44 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6cd696df-8ecb-11ee-98e3-6d05b1d4d9a1 From: Nicola Vetrini To: nicola.vetrini@bugseng.com, xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, bertrand.marquis@arm.com, julien@xen.org, Volodymyr Babchuk Subject: [XEN PATCH 1/7] xen/arm: mmu: add headers for missing declarations Date: Wed, 29 Nov 2023 16:24:19 +0100 Message-Id: <7032dd53fa025ad19ce53171b80e51db9d332b83.1701270983.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 The definitions needing the inclusion of asm/setup.h are boot_{first,second,third}(_id)?, whereas vmap.h is needed by arch_vmap_virt_end. No functional change. Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini --- xen/arch/arm/mmu/setup.c | 1 + xen/arch/arm/mmu/smpboot.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/xen/arch/arm/mmu/setup.c b/xen/arch/arm/mmu/setup.c index a5a9b538ff13..d5264e51bc44 100644 --- a/xen/arch/arm/mmu/setup.c +++ b/xen/arch/arm/mmu/setup.c @@ -8,6 +8,7 @@ #include #include #include +#include #include diff --git a/xen/arch/arm/mmu/smpboot.c b/xen/arch/arm/mmu/smpboot.c index 12f1a5d761e7..b6fc0aae07f1 100644 --- a/xen/arch/arm/mmu/smpboot.c +++ b/xen/arch/arm/mmu/smpboot.c @@ -7,6 +7,8 @@ #include +#include + /* * Static start-of-day pagetables that we use before the allocators * are up. These are used by all CPUs during bringup before switching From patchwork Wed Nov 29 15:24:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Vetrini X-Patchwork-Id: 13473010 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 312A7C07CB1 for ; Wed, 29 Nov 2023 15:25:08 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.643992.1004572 (Exim 4.92) (envelope-from ) id 1r8MQi-0001f3-TW; Wed, 29 Nov 2023 15:24:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 643992.1004572; Wed, 29 Nov 2023 15:24:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r8MQi-0001d7-Nn; Wed, 29 Nov 2023 15:24:48 +0000 Received: by outflank-mailman (input) for mailman id 643992; Wed, 29 Nov 2023 15:24:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r8MQh-0001PZ-EJ for xen-devel@lists.xenproject.org; Wed, 29 Nov 2023 15:24:47 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6d71379b-8ecb-11ee-9b0e-b553b5be7939; Wed, 29 Nov 2023 16:24:46 +0100 (CET) Received: from nico.bugseng.com (unknown [147.123.100.152]) by support.bugseng.com (Postfix) with ESMTPSA id 144604EE073F; Wed, 29 Nov 2023 16:24:45 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d71379b-8ecb-11ee-9b0e-b553b5be7939 From: Nicola Vetrini To: nicola.vetrini@bugseng.com, xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, bertrand.marquis@arm.com, julien@xen.org, Jan Beulich , Andrew Cooper , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH 2/7] x86/i8259: add missing header for init_IRQ declaration Date: Wed, 29 Nov 2023 16:24:20 +0100 Message-Id: <3443c1a877c63f1c6213e0c184e89b20aaa29ffb.1701270983.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 No functional change. Signed-off-by: Nicola Vetrini --- xen/arch/x86/i8259.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/i8259.c b/xen/arch/x86/i8259.c index e0fa1f96b4f2..470d690c3594 100644 --- a/xen/arch/x86/i8259.c +++ b/xen/arch/x86/i8259.c @@ -19,6 +19,7 @@ #include #include #include +#include #include #include From patchwork Wed Nov 29 15:24:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Vetrini X-Patchwork-Id: 13473013 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 480F7C10DC1 for ; Wed, 29 Nov 2023 15:25:09 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.643994.1004593 (Exim 4.92) (envelope-from ) id 1r8MQk-0002De-Gd; Wed, 29 Nov 2023 15:24:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 643994.1004593; Wed, 29 Nov 2023 15:24:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r8MQk-0002CA-B1; Wed, 29 Nov 2023 15:24:50 +0000 Received: by outflank-mailman (input) for mailman id 643994; Wed, 29 Nov 2023 15:24:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r8MQi-0001PZ-Aj for xen-devel@lists.xenproject.org; Wed, 29 Nov 2023 15:24:48 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6df25e84-8ecb-11ee-9b0e-b553b5be7939; Wed, 29 Nov 2023 16:24:47 +0100 (CET) Received: from nico.bugseng.com (unknown [147.123.100.152]) by support.bugseng.com (Postfix) with ESMTPSA id DB0154EE0741; Wed, 29 Nov 2023 16:24:45 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6df25e84-8ecb-11ee-9b0e-b553b5be7939 From: Nicola Vetrini To: nicola.vetrini@bugseng.com, xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, bertrand.marquis@arm.com, julien@xen.org, Jan Beulich , Andrew Cooper , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH 3/7] xen/x86: add missing instances of asmlinkage attributes Date: Wed, 29 Nov 2023 16:24:21 +0100 Message-Id: <4815279026ca4e2f1d93c98bfe6ea51ee139280d.1701270983.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 No functional change. Signed-off-by: Nicola Vetrini --- xen/arch/x86/desc.c | 2 +- xen/arch/x86/efi/efi-boot.h | 5 +++-- xen/arch/x86/mm.c | 2 +- xen/arch/x86/smpboot.c | 2 +- 4 files changed, 6 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/desc.c b/xen/arch/x86/desc.c index 39080ca67211..b332adedf28e 100644 --- a/xen/arch/x86/desc.c +++ b/xen/arch/x86/desc.c @@ -91,7 +91,7 @@ seg_desc_t boot_compat_gdt[PAGE_SIZE / sizeof(seg_desc_t)] = * References boot_cpu_gdt_table for a short period, until the CPUs switch * onto their per-CPU GDTs. */ -const struct desc_ptr boot_gdtr = { +const struct desc_ptr asmlinkage boot_gdtr = { .limit = LAST_RESERVED_GDT_BYTE, .base = (unsigned long)(boot_gdt - FIRST_RESERVED_GDT_ENTRY), }; diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h index 86467da301e5..8ea64e31cdc2 100644 --- a/xen/arch/x86/efi/efi-boot.h +++ b/xen/arch/x86/efi/efi-boot.h @@ -808,8 +808,9 @@ static const char *__init get_option(const char *cmd, const char *opt) return o; } -void __init efi_multiboot2(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable, - const char *cmdline) +void asmlinkage __init efi_multiboot2(EFI_HANDLE ImageHandle, + EFI_SYSTEM_TABLE *SystemTable, + const char *cmdline) { EFI_GRAPHICS_OUTPUT_PROTOCOL *gop; EFI_HANDLE gop_handle; diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 0a66db10b959..9ce21c443bea 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -143,7 +143,7 @@ /* Mapping of the fixmap space needed early. */ l1_pgentry_t __section(".bss.page_aligned") __aligned(PAGE_SIZE) l1_fixmap[L1_PAGETABLE_ENTRIES]; -l1_pgentry_t __section(".bss.page_aligned") __aligned(PAGE_SIZE) +l1_pgentry_t asmlinkage __section(".bss.page_aligned") __aligned(PAGE_SIZE) l1_fixmap_x[L1_PAGETABLE_ENTRIES]; bool __read_mostly machine_to_phys_mapping_valid; diff --git a/xen/arch/x86/smpboot.c b/xen/arch/x86/smpboot.c index 4c54ecbc91d7..8aa621533f3d 100644 --- a/xen/arch/x86/smpboot.c +++ b/xen/arch/x86/smpboot.c @@ -310,7 +310,7 @@ static void set_cpu_sibling_map(unsigned int cpu) } } -void start_secondary(void *unused) +void asmlinkage start_secondary(void *unused) { struct cpu_info *info = get_cpu_info(); From patchwork Wed Nov 29 15:24:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Vetrini X-Patchwork-Id: 13473007 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F5E2C10DAA for ; Wed, 29 Nov 2023 15:25:02 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.643993.1004589 (Exim 4.92) (envelope-from ) id 1r8MQk-00029N-6E; Wed, 29 Nov 2023 15:24:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 643993.1004589; Wed, 29 Nov 2023 15:24:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r8MQk-00028O-1Z; Wed, 29 Nov 2023 15:24:50 +0000 Received: by outflank-mailman (input) for mailman id 643993; Wed, 29 Nov 2023 15:24:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r8MQi-0001PY-6x for xen-devel@lists.xenproject.org; Wed, 29 Nov 2023 15:24:48 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6e5ba655-8ecb-11ee-98e3-6d05b1d4d9a1; Wed, 29 Nov 2023 16:24:47 +0100 (CET) Received: from nico.bugseng.com (unknown [147.123.100.152]) by support.bugseng.com (Postfix) with ESMTPSA id B76B84EE0744; Wed, 29 Nov 2023 16:24:46 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e5ba655-8ecb-11ee-98e3-6d05b1d4d9a1 From: Nicola Vetrini To: nicola.vetrini@bugseng.com, xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, bertrand.marquis@arm.com, julien@xen.org, Paul Durrant , Wei Liu , Jan Beulich , Andrew Cooper , =?utf-8?q?Roger_Pau_Monn=C3=A9?= Subject: [XEN PATCH 4/7] x86/viridian: make build_assertions static Date: Wed, 29 Nov 2023 16:24:22 +0100 Message-Id: <1fc043cb040a24515e2355a5a908c42f20a39418.1701270983.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 This is consistent with other instances of the same function and also resolves a violation of MISRA C:2012 Rule 8.4. No functional change. Signed-off-by: Nicola Vetrini Reviewed-by: Stefano Stabellini --- xen/arch/x86/hvm/viridian/synic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/hvm/viridian/synic.c b/xen/arch/x86/hvm/viridian/synic.c index 8cf600cec68f..3375e55e95ca 100644 --- a/xen/arch/x86/hvm/viridian/synic.c +++ b/xen/arch/x86/hvm/viridian/synic.c @@ -18,7 +18,7 @@ #include "private.h" -void __init __maybe_unused build_assertions(void) +static void __init __maybe_unused build_assertions(void) { BUILD_BUG_ON(sizeof(struct hv_message) != HV_MESSAGE_SIZE); } From patchwork Wed Nov 29 15:24:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Vetrini X-Patchwork-Id: 13473008 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52AA9C4167B for ; Wed, 29 Nov 2023 15:25:02 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.643995.1004601 (Exim 4.92) (envelope-from ) id 1r8MQl-0002Kz-2R; Wed, 29 Nov 2023 15:24:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 643995.1004601; Wed, 29 Nov 2023 15:24:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r8MQk-0002I3-MM; Wed, 29 Nov 2023 15:24:50 +0000 Received: by outflank-mailman (input) for mailman id 643995; Wed, 29 Nov 2023 15:24:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r8MQj-0001PY-0g for xen-devel@lists.xenproject.org; Wed, 29 Nov 2023 15:24:49 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6ed6493e-8ecb-11ee-98e3-6d05b1d4d9a1; Wed, 29 Nov 2023 16:24:48 +0100 (CET) Received: from nico.bugseng.com (unknown [147.123.100.152]) by support.bugseng.com (Postfix) with ESMTPSA id A0DE24EE0747; Wed, 29 Nov 2023 16:24:47 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ed6493e-8ecb-11ee-98e3-6d05b1d4d9a1 From: Nicola Vetrini To: nicola.vetrini@bugseng.com, xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, bertrand.marquis@arm.com, julien@xen.org, Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [XEN PATCH 5/7] docs/misra: add entry to exclude-list.json Date: Wed, 29 Nov 2023 16:24:23 +0100 Message-Id: <538cd0aaacc5af9111c09664cd3c4a4f78ba36fa.1701270983.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 x86/efi/check.c is not part of the final Xen binary, therefore it doesn't need to conform to MISRA guidelines at the moment. Signed-off-by: Nicola Vetrini Acked-by: Jan Beulich --- docs/misra/exclude-list.json | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/misra/exclude-list.json b/docs/misra/exclude-list.json index b858a0baa106..24e4de3ca524 100644 --- a/docs/misra/exclude-list.json +++ b/docs/misra/exclude-list.json @@ -93,6 +93,10 @@ "rel_path": "arch/x86/x86_64/mmconf-fam10h.c", "comment": "Imported from Linux, ignore for now" }, + { + "rel_path": "arch/x86/efi/check.c", + "comment": "The resulting code is not included in the final Xen binary, ignore for now" + }, { "rel_path": "common/bitmap.c", "comment": "Imported from Linux, ignore for now" From patchwork Wed Nov 29 15:24:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Vetrini X-Patchwork-Id: 13473009 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9FC45C10DC1 for ; Wed, 29 Nov 2023 15:25:02 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.643997.1004620 (Exim 4.92) (envelope-from ) id 1r8MQm-0002uj-KG; Wed, 29 Nov 2023 15:24:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 643997.1004620; Wed, 29 Nov 2023 15:24:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r8MQm-0002tY-F3; Wed, 29 Nov 2023 15:24:52 +0000 Received: by outflank-mailman (input) for mailman id 643997; Wed, 29 Nov 2023 15:24:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r8MQk-0001PZ-Oe for xen-devel@lists.xenproject.org; Wed, 29 Nov 2023 15:24:50 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6f6bf152-8ecb-11ee-9b0e-b553b5be7939; Wed, 29 Nov 2023 16:24:49 +0100 (CET) Received: from nico.bugseng.com (unknown [147.123.100.152]) by support.bugseng.com (Postfix) with ESMTPSA id 6FB884EE074E; Wed, 29 Nov 2023 16:24:48 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f6bf152-8ecb-11ee-9b0e-b553b5be7939 From: Nicola Vetrini To: nicola.vetrini@bugseng.com, xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, bertrand.marquis@arm.com, julien@xen.org, Jan Beulich , Andrew Cooper , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Wei Liu Subject: [XEN PATCH 6/7] xen/x86: remove stale comment Date: Wed, 29 Nov 2023 16:24:24 +0100 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 The comment referred to the declaration for do_mca, which now is part of hypercall-defs.h, therefore the comment is stale. No functional change. Signed-off-by: Nicola Vetrini --- xen/arch/x86/cpu/mcheck/mce.c | 2 +- xen/arch/x86/include/asm/hypercall.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/cpu/mcheck/mce.c b/xen/arch/x86/cpu/mcheck/mce.c index 779a458cd88f..53493c8e4778 100644 --- a/xen/arch/x86/cpu/mcheck/mce.c +++ b/xen/arch/x86/cpu/mcheck/mce.c @@ -14,7 +14,7 @@ #include #include #include -#include /* for do_mca */ +#include #include #include diff --git a/xen/arch/x86/include/asm/hypercall.h b/xen/arch/x86/include/asm/hypercall.h index ec2edc771e9d..76658fff19ff 100644 --- a/xen/arch/x86/include/asm/hypercall.h +++ b/xen/arch/x86/include/asm/hypercall.h @@ -12,7 +12,7 @@ #include #include #include -#include /* for do_mca */ +#include #include #define __HYPERVISOR_paging_domctl_cont __HYPERVISOR_arch_1 From patchwork Wed Nov 29 15:24:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicola Vetrini X-Patchwork-Id: 13473011 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D88EC10DC2 for ; Wed, 29 Nov 2023 15:25:09 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.643996.1004617 (Exim 4.92) (envelope-from ) id 1r8MQm-0002rA-D9; Wed, 29 Nov 2023 15:24:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 643996.1004617; Wed, 29 Nov 2023 15:24:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r8MQm-0002pY-4N; Wed, 29 Nov 2023 15:24:52 +0000 Received: by outflank-mailman (input) for mailman id 643996; Wed, 29 Nov 2023 15:24:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1r8MQk-0001PY-Kl for xen-devel@lists.xenproject.org; Wed, 29 Nov 2023 15:24:50 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6fca78b7-8ecb-11ee-98e3-6d05b1d4d9a1; Wed, 29 Nov 2023 16:24:50 +0100 (CET) Received: from nico.bugseng.com (unknown [147.123.100.152]) by support.bugseng.com (Postfix) with ESMTPSA id 3806E4EE0C81; Wed, 29 Nov 2023 16:24:49 +0100 (CET) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6fca78b7-8ecb-11ee-98e3-6d05b1d4d9a1 From: Nicola Vetrini To: nicola.vetrini@bugseng.com, xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, michal.orzel@amd.com, xenia.ragiadakou@amd.com, ayan.kumar.halder@amd.com, consulting@bugseng.com, bertrand.marquis@arm.com, julien@xen.org, Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [XEN PATCH 7/7] xen/page_alloc: deviate first_valid_mfn for MISRA C Rule 8.4 Date: Wed, 29 Nov 2023 16:24:25 +0100 Message-Id: <1ee69d2f0b9e9a704bf869e2b2700f88a8069343.1701270983.git.nicola.vetrini@bugseng.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 No functional change. Signed-off-by: Nicola Vetrini Acked-by: Stefano Stabellini --- The preferred way to deviate is to use asmlinkage, but this modification is only the consequence of NUMA on ARM (and possibly PPC) being a work in progress. As stated in the comment above the textual deviation, first_valid_mfn will likely then become static and there would be no need for the comment anymore. This works towards having the analysis for this rule clean (i.e. no violations); the interest in having a clean rule is that then it could be used to signal newly introduced violations by making the analysis job fail. --- xen/common/page_alloc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 9b5df74fddab..794d7689b179 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -258,6 +258,7 @@ static PAGE_LIST_HEAD(page_broken_list); * first_valid_mfn is exported because it is use in ARM specific NUMA * helpers. See comment in arch/arm/include/asm/numa.h. */ +/* SAF-1-safe */ mfn_t first_valid_mfn = INVALID_MFN_INITIALIZER; struct bootmem_region {