From patchwork Thu Feb 14 15:47:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rask Ingemann Lambertsen X-Patchwork-Id: 10813799 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7418C922 for ; Thu, 14 Feb 2019 21:24:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 60F502E706 for ; Thu, 14 Feb 2019 21:24:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 545842E734; Thu, 14 Feb 2019 21:24:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=2.0 tests=BAYES_00,DATE_IN_PAST_03_06, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8E64B2E706 for ; Thu, 14 Feb 2019 21:24:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Date:To: From:Message-Id:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=U20KPDFsbc6biu8NrV1hRHRO0Gkp327TrlFbwH4szdg=; b=YOe 8yEcg0gKWlJzLSCFMKufX9sucGjjwZTuR6tGapLIncU+F99CjFkGzl5aS07xx+m2mYWuXEmXTPMC5 /akcxlB3XDyj7F1gnn9UGEQN/KY23EFlND6WyePOv+GKC8iL93rA4xrzx9WI861cn3UYEEPEIust+ WeOUxggbZpWmfE/95CFa/4VRPLbcPrwWZLQdGvm4N8eVmD4T+jEyCQsX8Hjyp0v1xOQbCJov8TlRD xu4LizTiNLuLeKp/EmopAaK4HGziM/fZgeI65IPfaDgmaiQU1JIQn9pT+njryBnNXo3J7mgGENhzn Nl/M1TGclEfXoyRcFuY5UZPDkX1PjUg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1guOUu-0003I9-G2; Thu, 14 Feb 2019 21:24:44 +0000 Received: from customer-2a00-7660-0ca7-0000-0000-0000-0000-0b1b.ip6.gigabit.dk ([2a00:7660:ca7::b1b]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1guOUr-0003Hj-Ng for linux-arm-kernel@lists.infradead.org; Thu, 14 Feb 2019 21:24:43 +0000 Received: by customer-2a00-7660-0ca7-0000-0000-0000-0000-0b1b.ip6.gigabit.dk (Postfix, from userid 1000) id F21E74AC6E; Thu, 14 Feb 2019 22:24:37 +0100 (CET) Message-Id: <641301f26ac895e39b15d62a2ba069b853ab5b09.1550178066.git.rask@formelder.dk> From: Rask Ingemann Lambertsen To: Liam Girdwood , Mark Brown , Chen-Yu Tsai , linux-kernel@vger.kernel.org Date: Thu, 14 Feb 2019 16:47:41 +0100 Subject: [PATCH] regulator: axp20x: Fix AXP806 dcdcb copy/paste bug X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190214_132441_927804_B9F126C9 X-CRM114-Status: UNSURE ( 8.58 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Olliver Schinagl , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP An obvious copy/paste bug was introduced with the conversion to sybolic register masks. The result is contradictory output like this: vcc-dram: Bringing 1100000uV into 1450000-1450000uV vcc-dram: 1450 <--> 1550 mV at 1050 mV This patch fixes it: vcc-dram: 1450 <--> 1550 mV at 1500 mV Fixes: db4a555f7c4c ("regulator: axp20x: use defines for masks") Signed-off-by: Rask Ingemann Lambertsen Acked-by: Chen-Yu Tsai --- drivers/regulator/axp20x-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/axp20x-regulator.c b/drivers/regulator/axp20x-regulator.c index 1b51d557ab55..f03cae440f7f 100644 --- a/drivers/regulator/axp20x-regulator.c +++ b/drivers/regulator/axp20x-regulator.c @@ -791,7 +791,7 @@ static const struct regulator_desc axp806_regulators[] = { AXP806_DCDCA_V_CTRL, AXP806_DCDCA_V_CTRL_MASK, AXP806_PWR_OUT_CTRL1, AXP806_PWR_OUT_DCDCA_MASK), AXP_DESC(AXP806, DCDCB, "dcdcb", "vinb", 1000, 2550, 50, - AXP806_DCDCB_V_CTRL, AXP806_DCDCB_V_CTRL, + AXP806_DCDCB_V_CTRL, AXP806_DCDCB_V_CTRL_MASK, AXP806_PWR_OUT_CTRL1, AXP806_PWR_OUT_DCDCB_MASK), AXP_DESC_RANGES(AXP806, DCDCC, "dcdcc", "vinc", axp806_dcdca_ranges, AXP806_DCDCA_NUM_VOLTAGES,