From patchwork Wed Nov 29 21:28:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13473457 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WcPxlb1r" Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E185D7D for ; Wed, 29 Nov 2023 13:28:44 -0800 (PST) Received: by mail-lj1-x232.google.com with SMTP id 38308e7fff4ca-2c9bf8964c3so3599441fa.1 for ; Wed, 29 Nov 2023 13:28:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701293323; x=1701898123; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=uGzqJZeCIvHWgx50HcN8P2Sdt/SHVZafM+S/3T4/ITk=; b=WcPxlb1rvfwiFf9/6+qE9ZRL/4+EdRBIoPBvRpBqE0j9u40zIlse4JraXLPQcgusiU f12rbHu1B1SMEncy1MYVKSkV/ReGNyEc2ogCK1YDQgFyBqX4GwG7ovHfwE9Igwin9b9K KQuVbi97UDajHpkpETNcCZ5ALzmBt4BK0UoPQI+cJK68KbkfC8U7SItR0XLQBZFZ8KP5 oVM7tQakk9jHgWHxQp8NGDSH6IIM6YEjLEzHyp2ZhOl9kl3gnkjI3i3fbFRUxc6im3C1 HjTp5tig53iwohafmd6RBWnRof4B/mV6hPwykh+hLEx6q+IwqHyR5AS6IuyNgmZyROVM 1r+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701293323; x=1701898123; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uGzqJZeCIvHWgx50HcN8P2Sdt/SHVZafM+S/3T4/ITk=; b=vyE0Bvf1N2dm8oBcqAH07xOEqOQl9igE02L5/gSenQWhhcQNxH/1FMRhkdaFKXTDm7 MHcm6cakTQHk91NDW1ccD+ewpNrQjKyb+zKEsRNfs2aTlaLAkWBAGqa5yjlgffU/idOT QgbnF3P4eW9rq1PAKJmBIbvaj5oeTVuUqq/krDf3+KZkNaSspcT5Vg0A9xqNy99NDl0n Hs/5neAbnaD2rAS98tQmtGbA3uACHMRXaWVnc5VVPOukb3BemlC3OfZH8/NywJqB9RIu GYqpBd0YWrdwgWC1zaEQ6HX/b57GeYgnzY8VKgYWg8Mdb/tsW7/TDn6NGoFwucXbTOFx dukQ== X-Gm-Message-State: AOJu0YxNHxDHQ5RyU8fzNGTNBzDPAQDtaQ0uy9oHqcTQvuKMF4YR+XBN QNu7u7sVzFBONPIgcI+yzZsyig== X-Google-Smtp-Source: AGHT+IH2iP1+SnhRh5dk6NH/SIXt5a1DgU9BeCKEI9Kd5MNkN/wjAcRvj26p+QcR+8v7vqnF7DFCiA== X-Received: by 2002:a05:651c:b27:b0:2c9:a9ba:97ec with SMTP id b39-20020a05651c0b2700b002c9a9ba97ecmr6389122ljr.38.1701293322448; Wed, 29 Nov 2023 13:28:42 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id b5-20020a05651c032500b002bcdbfe36b9sm2106196ljp.111.2023.11.29.13.28.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 13:28:41 -0800 (PST) From: Linus Walleij Date: Wed, 29 Nov 2023 22:28:37 +0100 Subject: [PATCH 01/10] ASoC: cs35l32: Drop legacy include Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231129-descriptors-sound-cirrus-v1-1-31aa74425ff8@linaro.org> References: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> In-Reply-To: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij X-Mailer: b4 0.12.4 This driver includes the legacy GPIO API but does not use any symbols from it. Drop the include. Signed-off-by: Linus Walleij --- sound/soc/codecs/cs35l32.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/cs35l32.c b/sound/soc/codecs/cs35l32.c index 138040618438..d1350ffbf3bd 100644 --- a/sound/soc/codecs/cs35l32.c +++ b/sound/soc/codecs/cs35l32.c @@ -13,7 +13,6 @@ #include #include #include -#include #include #include #include From patchwork Wed Nov 29 21:28:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13473458 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oDiahQQU" Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E3AAD67 for ; Wed, 29 Nov 2023 13:28:45 -0800 (PST) Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2c8879a1570so3925561fa.1 for ; Wed, 29 Nov 2023 13:28:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701293323; x=1701898123; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=w98h2S9ziwqYlZ5eRbk63Kp1zoQv2lCTleH6DrVq65w=; b=oDiahQQUL2hIrwkhtZ+38voKbKrhRzRIzb2VC56Wpkc6X3W+J+3I01qf71oCa8z32K mX0hciWHJLuQLyy0Z0f5KYKzhXk5rxEGnq2XyI1wGzUA7CJugJpcugUvplhkWHDhwt0+ ydmM16GZRpApq5gMqlXTUuuJT+IaV87wTkNs5/JpUSD1CngBgzx568k/MPDCRqCJdYy4 Zwd3lAzov8LJhXxJIKTkOQVcrXn9kMkOqp9zwHpEY5Pgc/6h5YGIGhNOwLXAbeU9G8Lm +Ee5HdPRiyMx/uIayCwEb5FSald0Pd4vmmrsA/1T6szm42R9tCBiPxOI+Uis6Ak2k8sF ms3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701293323; x=1701898123; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w98h2S9ziwqYlZ5eRbk63Kp1zoQv2lCTleH6DrVq65w=; b=eID7uQeslVrgCSYAmNZ1ClWhZkRbeiucVjXQgTnF+UB7lw9m9gXqPcmplqIetlxIf1 7CoLlxHo/xWGV6jmPB2VWfmW5Sa3gDhUvLxN+NG4xHGUQAZVJsqUIQppna9g1gVAbBOd dw7odBuOtPFxZ8T1Oc2ofir415v60Za778KlrErpits5zzOBVjYm7edM+En+SLu6Qj7m H3rmCLWVJQ4FVlbl0G1/71uB07QxGqoGII3au/pPVjz2hxZK0a4YYj+ScZwXFluxHWrw im9qVq9jXorozlBos05kHy9MvRMF1X4aTe3h9VmiwwswR6Ct/d8MIqRkEOeLdOe0J46s oBbg== X-Gm-Message-State: AOJu0YzJEZE4Xv4m/LrNqhh5JDauNZahsM9+ZkhyjnmPJcXkc4tbmvtA Ui/08rb3Hxr4OdfXUcpNdNhUlw== X-Google-Smtp-Source: AGHT+IEC56sw8UX2ii4LX1W7ed8InaZsSu/jcEIqr13PU5ZEBtax1tJX/hGuJk6YOIA9moirDg3WrA== X-Received: by 2002:a2e:874b:0:b0:2c9:c58a:b2f4 with SMTP id q11-20020a2e874b000000b002c9c58ab2f4mr1049900ljj.41.1701293323490; Wed, 29 Nov 2023 13:28:43 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id b5-20020a05651c032500b002bcdbfe36b9sm2106196ljp.111.2023.11.29.13.28.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 13:28:43 -0800 (PST) From: Linus Walleij Date: Wed, 29 Nov 2023 22:28:38 +0100 Subject: [PATCH 02/10] ASoC: cs35l33: Fix GPIO name and drop legacy include Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231129-descriptors-sound-cirrus-v1-2-31aa74425ff8@linaro.org> References: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> In-Reply-To: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij X-Mailer: b4 0.12.4 This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Further the driver is requesting "reset-gpios" rather than just "gpios" from the GPIO framework. This is wrong because the gpiolib core will add "-gpios" before processing the request from e.g. device tree. Drop the suffix. The last problem means that the optional RESET GPIO has never been properly retrieved and used even if it existed, but nobody noticed. Fixes: 3333cb7187b9 ("ASoC: cs35l33: Initial commit of the cs35l33 CODEC driver.") Signed-off-by: Linus Walleij --- sound/soc/codecs/cs35l33.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/cs35l33.c b/sound/soc/codecs/cs35l33.c index 4010a2d33a33..a19a2bafb37c 100644 --- a/sound/soc/codecs/cs35l33.c +++ b/sound/soc/codecs/cs35l33.c @@ -22,13 +22,11 @@ #include #include #include -#include #include #include #include #include #include -#include #include #include "cs35l33.h" @@ -1165,7 +1163,7 @@ static int cs35l33_i2c_probe(struct i2c_client *i2c_client) /* We could issue !RST or skip it based on AMP topology */ cs35l33->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev, - "reset-gpios", GPIOD_OUT_HIGH); + "reset", GPIOD_OUT_HIGH); if (IS_ERR(cs35l33->reset_gpio)) { dev_err(&i2c_client->dev, "%s ERROR: Can't get reset GPIO\n", __func__); From patchwork Wed Nov 29 21:28:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13473459 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BhraCzG7" Received: from mail-lj1-x234.google.com (mail-lj1-x234.google.com [IPv6:2a00:1450:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53BE510C0 for ; Wed, 29 Nov 2023 13:28:46 -0800 (PST) Received: by mail-lj1-x234.google.com with SMTP id 38308e7fff4ca-2c9b5b72983so3743521fa.2 for ; Wed, 29 Nov 2023 13:28:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701293324; x=1701898124; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gxA1zyyyxC7/6y6RpRxRpLmaP1pTY49ZhzDzMcyXsOY=; b=BhraCzG75ggv57D/T7VOHe8Aa61nPtYk8FJffp8rqxA5ChK45FwQoJLq1uh2R4pWjQ J9AquvLvqHEKa61xo2z5sDJkmk/3EqHSBMrBZFF10FMfjCv7emaB78+uPcriWYj/cqLq BU4iLH3wgEf1ITpmtUzjJetBL6H1qiVPxBvj/X6sl6zCwkyS6fcSleZW6DXmwu1YGIz+ zxsFwR+svgdq26h9ciOip37HmTcu5gXb1cMfvaiVz7nqMlO0zkVbL2J1QJU98GP9OMaE YJ+NPjxKWtUldBYFnz05ikUqwdS9kwx+enXw6NzPrvKg7AUI//D3F/Yt+J62zxTOlXiq oFuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701293324; x=1701898124; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gxA1zyyyxC7/6y6RpRxRpLmaP1pTY49ZhzDzMcyXsOY=; b=AtbGUmwjFe7lNlvko2zOy/WmvwZppbg2hV5Ij/ry9Q5g6OT8NuwAufuLxf1kIomo1o NvhWjwJ2E1Vpjrtfaq5XlYq7Shj0FKI3zrZCinGdwXZRu2jGU/265tvVEFSDk8RRp8xj zS3G/sbEsVIRY4RXO7yPtQiBpCXXzKUg8BD85tx+Mqokcd3lwHZw3mfMxY9qmFHusMBj fatgV+NftOZymNSiKJ+3jl7Dodst1DSQE4zaL1uvjAZgHLWmQZDXAA8Vf3ehGZMVr4Cs fKMR/SM4aPvtTVAVtTwqX3xPQUbyBlrzzUjPP7t3C/LqeHL2C6B8Y3bzTZylJvYi5N9a UUaA== X-Gm-Message-State: AOJu0YyrDu+snMt+Ka4rA/NvWskJEgs28D/IfFA0cvbfHPQ1eOILcjVY +IG9eehcxE69VAhGQeTjQw+RMQ== X-Google-Smtp-Source: AGHT+IH2XK3VmzyApGKH2dJRP5mNU0HGdkujQYH19VxvKR71Nk9rdeM2oIikSY71v9WV2Mt3FvghIA== X-Received: by 2002:a2e:8709:0:b0:2c9:c192:42a8 with SMTP id m9-20020a2e8709000000b002c9c19242a8mr1654073lji.38.1701293324577; Wed, 29 Nov 2023 13:28:44 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id b5-20020a05651c032500b002bcdbfe36b9sm2106196ljp.111.2023.11.29.13.28.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 13:28:44 -0800 (PST) From: Linus Walleij Date: Wed, 29 Nov 2023 22:28:39 +0100 Subject: [PATCH 03/10] ASoC: cs35l34: Fix GPIO name and drop legacy include Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231129-descriptors-sound-cirrus-v1-3-31aa74425ff8@linaro.org> References: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> In-Reply-To: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij X-Mailer: b4 0.12.4 This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Further the driver is requesting "reset-gpios" rather than just "gpios" from the GPIO framework. This is wrong because the gpiolib core will add "-gpios" before processing the request from e.g. device tree. Drop the suffix. The last problem means that the optional RESET GPIO has never been properly retrieved and used even if it existed, but nobody noticed. Fixes: c1124c09e103 ("ASoC: cs35l34: Initial commit of the cs35l34 CODEC driver.") Signed-off-by: Linus Walleij --- sound/soc/codecs/cs35l34.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/cs35l34.c b/sound/soc/codecs/cs35l34.c index e5871736fa29..cca59de66b73 100644 --- a/sound/soc/codecs/cs35l34.c +++ b/sound/soc/codecs/cs35l34.c @@ -20,14 +20,12 @@ #include #include #include -#include #include #include #include #include #include #include -#include #include #include #include @@ -1061,7 +1059,7 @@ static int cs35l34_i2c_probe(struct i2c_client *i2c_client) dev_err(&i2c_client->dev, "Failed to request IRQ: %d\n", ret); cs35l34->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev, - "reset-gpios", GPIOD_OUT_LOW); + "reset", GPIOD_OUT_LOW); if (IS_ERR(cs35l34->reset_gpio)) { ret = PTR_ERR(cs35l34->reset_gpio); goto err_regulator; From patchwork Wed Nov 29 21:28:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13473460 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qOmapnSW" Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8614BD7F for ; Wed, 29 Nov 2023 13:28:47 -0800 (PST) Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2c9c82a976bso1631341fa.3 for ; Wed, 29 Nov 2023 13:28:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701293326; x=1701898126; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YU/umhZ4xMv6PXObbvZL6R5y01gsoGYZgYp3KJFvARs=; b=qOmapnSW5GLcKq7hzpbZQklUCY8/JzOIhPzOMP55fM6MUFE7O+ydi8JTluhQ4by6/2 XEaixxMI+Vs7mC6fDukIySkMVPybwK3SqWiVTd9yWoODsJkg614F/TrMgGQR7LwguQDm ex0fEDr0OW6kBBcf9ALimh9o2O3MggEzLyWkHrzSN1QVrzWMZA6Kr0ppQSRwzEmz9zCf lZ61Pc30wVILOUESmubfCoTmrk/sCsiJfB0sF6ZlE0FR8HoUAQnS38plNQXZcmTDCXni hq/9FF0ZJnyXg0KwdKOF/vdhneNa044VjZJuJolFgPD4/an/z0a6t8PdcJWB7keP3b4A Uqqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701293326; x=1701898126; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YU/umhZ4xMv6PXObbvZL6R5y01gsoGYZgYp3KJFvARs=; b=YThyTkTiS97KNnZ+Z5xC7bA6bAj9jb7ar2H2X8TrdEe4xlhSipuQzZGGS/If228pZM 5oBqH3fwZkXHg2gI+k9U3/zUhIdR5meyN6CRTiynrYfa2Ew1VR6s4AxbKj9jRvVvjsPL 7voIEaE3bjAYj6lB7Sk30zdSoU0u+A8LW/qz7+pYNW21ry0owLfnUg+0SR5bR8phHf+G Q03rLxPu5GJ8brfRLRdz75Btk1jKpR7KdR9YGLdVeeG8M5ogQatFZBudvQgDCro+LwwH 7ZcYnCGA6khz0tumnulDeU9tRFoPLLdOvQ0QTLEID1mRepsPtEzpwToSvP2tkZAh08FB kShA== X-Gm-Message-State: AOJu0YyXxtfOl66jiyzxj+uzABKX3TZ8+Ik6vvSeEpQzywic47JoxrJg AZaLwo442aInVxiEgrqAcxVEHQ== X-Google-Smtp-Source: AGHT+IE+lDIdHAdte4rENQsg0tSBQfqVYqAjeDvwRKqHOtDWVAZmyuqpLukchZeA3cMSJEgTRjKklw== X-Received: by 2002:a2e:88c6:0:b0:2c9:c438:d0fb with SMTP id a6-20020a2e88c6000000b002c9c438d0fbmr1191629ljk.34.1701293325848; Wed, 29 Nov 2023 13:28:45 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id b5-20020a05651c032500b002bcdbfe36b9sm2106196ljp.111.2023.11.29.13.28.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 13:28:45 -0800 (PST) From: Linus Walleij Date: Wed, 29 Nov 2023 22:28:40 +0100 Subject: [PATCH 04/10] ASoC: cs35l35: Drop legacy includes Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231129-descriptors-sound-cirrus-v1-4-31aa74425ff8@linaro.org> References: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> In-Reply-To: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij X-Mailer: b4 0.12.4 This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Signed-off-by: Linus Walleij --- sound/soc/codecs/cs35l35.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c index 63a538f747d3..ddb7d63213a3 100644 --- a/sound/soc/codecs/cs35l35.c +++ b/sound/soc/codecs/cs35l35.c @@ -18,14 +18,12 @@ #include #include #include -#include #include #include #include #include #include #include -#include #include #include #include From patchwork Wed Nov 29 21:28:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13473461 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FN5b0IS+" Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FCBED67 for ; Wed, 29 Nov 2023 13:28:48 -0800 (PST) Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2c9c82a976bso1631551fa.3 for ; Wed, 29 Nov 2023 13:28:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701293327; x=1701898127; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BhewE5OJd+lUpEbKMUw+a2p3lLwyC+mccGsAap2s2vQ=; b=FN5b0IS+ZIklVM8Zj7o/c8aRg9ajBoXyLBkrQIZxBsxmPNwoqLQ/uRJ1yN4TfYYkmh yw+kdBGRmRhU2g6wfMjB4de1jZtG4r+CgQLL6Eft1WP6FXcmO8ZQFA0I9eGxim8dJWiZ EEyBaVe7wU136LVx8SKeomQKJ6vzYFBJVCz3bxU6MGpbIxP4NPPxj6fxeVKHZFzzj4Xg 4hVxbh3TuLQtdMesMaA6tcb3xziTf0nLKiu9gWEe8zjyljjqOzoeU5Q/neRjcP1dfvo4 lXtaV0LIrCNIGQ3YcW0PcLHQJTB1RFREh4m/hCKc33JPztpoA8svMPHEQLlf68+p8awx Mh5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701293327; x=1701898127; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BhewE5OJd+lUpEbKMUw+a2p3lLwyC+mccGsAap2s2vQ=; b=LfsDFTrk9bERMUFJCTH40Ds6yFtBu1XdUClm0+B/OHfx1dd0PXK4l0aFTr7K8OMhZZ //LaFUqDUnuSb0qfzT9Z2GpjToBwl9FiYNYKUwjGlKIl/EA41OuQTNs/h8gPrQDyfVJ9 jBt7eGf3xPv2uzMTe6AywYEffpOiQhanax1WcG/LA1edWOs6gteXfSduxplYfu90Qve1 qh24OO5DZbRJqTmEQm17978c42R7ugtTfcnqFC7YvLnvfDyeXG5ea2EB97nV7h9zbIwT E4mEU8xAJLgJ0YbDwGA6UiVOZipldLWQuXOIRzAM741rov8xGw/M5Un8Z5ZXFthauqy1 3pPg== X-Gm-Message-State: AOJu0Yy9BAWwYsMH1ueLC9pvNBv7GDeYOahp4mEN4sONuNUjibYiI8ni X4l6pTxHPor49zlSI6zs6VPCDw== X-Google-Smtp-Source: AGHT+IGxbQDzbtRllfk3uIL9CtkIkPKjX8R74m1/levpV4rcuCDOPksrJ0QcmNJ3lIdNQ3SMD2Q4bg== X-Received: by 2002:a2e:8e27:0:b0:2c9:9a87:6683 with SMTP id r7-20020a2e8e27000000b002c99a876683mr8118803ljk.1.1701293327016; Wed, 29 Nov 2023 13:28:47 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id b5-20020a05651c032500b002bcdbfe36b9sm2106196ljp.111.2023.11.29.13.28.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 13:28:46 -0800 (PST) From: Linus Walleij Date: Wed, 29 Nov 2023 22:28:41 +0100 Subject: [PATCH 05/10] ASoC: cs35l36: Drop legacy includes Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231129-descriptors-sound-cirrus-v1-5-31aa74425ff8@linaro.org> References: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> In-Reply-To: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij X-Mailer: b4 0.12.4 This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Signed-off-by: Linus Walleij --- sound/soc/codecs/cs35l36.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/codecs/cs35l36.c b/sound/soc/codecs/cs35l36.c index f2fde6e652b9..ec407aca33e9 100644 --- a/sound/soc/codecs/cs35l36.c +++ b/sound/soc/codecs/cs35l36.c @@ -18,14 +18,12 @@ #include #include #include -#include #include #include #include #include #include #include -#include #include #include #include From patchwork Wed Nov 29 21:28:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13473463 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="haaAiuk8" Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87C9910C6 for ; Wed, 29 Nov 2023 13:28:50 -0800 (PST) Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2c9bd3557cfso3601951fa.3 for ; Wed, 29 Nov 2023 13:28:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701293329; x=1701898129; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rd9nw7xvRPUV3hk495kPLrQSq+AWlSC2p6ACSHGPZ1M=; b=haaAiuk8EyTF/awJ6ar8hI24IHV/B/lVgxy/SN9xIrO7xmW/PazT9XwsUXjdUmLEfI D6+7uky+fUdH73zqU73cUtJtegOawV2wVa/Pk146O4+PzByYw5R62dd4ssexmyx7Vv8Z TAkz4QyFWAwM5iI7AUa3xb5Wh5Q3gZOXUt4jM1Bnk5wWq3oBrZLFxgsBTnCsA3uEKYqM PaLjKpSlFCh2yIFQeGxGfurcmcIQke51tPzj8YQ8ZPM2TyfaMBZ0sYaoXg/9FLIqRx3m G3483CVD9+JCFsH2/9Mk24xofs+9e0QhQTtSWM4o6d+niJnZuMmM1TuHLztu1vjsrqVG Z9Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701293329; x=1701898129; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rd9nw7xvRPUV3hk495kPLrQSq+AWlSC2p6ACSHGPZ1M=; b=r+8IQDYHUH8+MQIx/bp23CK74OgtU8o3Qivj95S1IjLo8HLrY5cWt9VqvTNChI0DJr v9CdEa4GQLWMcwt2WyfEUMavO4hwHwrnQTtFJfa0bl8M4Hdhd29KS9X6/EYIK+bcawTN OrTU1/CALrhgpgqESXIHajp3RYwcJgp5hH7IxChSdwNAyIZonZiuf3jC+NieZYmLTjM1 xzDU9EyuLQnasfKIpuDGIxHdz9uJtUIOTWPIMuFAiFKgygRyWDWzWkpdIOl66ARjz7WZ trnbqqjlJcnKvj0APbNUalGnrrs8NbHEWGSCU5RktSFGa3B3kUUUXal5k9W48LiKf6Mf KV7Q== X-Gm-Message-State: AOJu0YzoRQXCw98LPdCHMHWhllB9In+gqftHrM7xTCtwGZHzY4tW5bOr +6OxgW+oy7CXhp+xL44oQhuLQ66IIAajoFucdAg= X-Google-Smtp-Source: AGHT+IFYlzgUTSMaBZ8vEEiRv4XxRnEyblyItbYXJ5pRKVGQeaxn6T2fQjE0N0TkwHLyCEnjMtygKw== X-Received: by 2002:a2e:9e17:0:b0:2c9:c566:ef73 with SMTP id e23-20020a2e9e17000000b002c9c566ef73mr812071ljk.15.1701293328854; Wed, 29 Nov 2023 13:28:48 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id b5-20020a05651c032500b002bcdbfe36b9sm2106196ljp.111.2023.11.29.13.28.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 13:28:47 -0800 (PST) From: Linus Walleij Date: Wed, 29 Nov 2023 22:28:42 +0100 Subject: [PATCH 06/10] ASoC: cs4271: Convert to GPIO descriptors Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231129-descriptors-sound-cirrus-v1-6-31aa74425ff8@linaro.org> References: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> In-Reply-To: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij X-Mailer: b4 0.12.4 This converts the Cirrus CS4271 ASoC codec driver to use GPIO descriptors. It turns out that there are two in-kernel users of the platform data passing mechanism so these are switched over as well. One locally defined GPIO "gpio_disabled" is declared in the state struct but completely unused in the driver, so we delete it. Signed-off-by: Linus Walleij Reviewed-by: Alexander Sverdlin --- NB: the affected platform EP93xx is being converted to device tree I don't know if that is happening in this merge window, but the colission should be manageable. --- arch/arm/mach-ep93xx/edb93xx.c | 32 +++++++++++++++++++++++++---- arch/arm/mach-ep93xx/vision_ep9307.c | 12 ++++++++++- include/sound/cs4271.h | 1 - sound/soc/codecs/cs4271.c | 39 ++++++++++++------------------------ 4 files changed, 52 insertions(+), 32 deletions(-) diff --git a/arch/arm/mach-ep93xx/edb93xx.c b/arch/arm/mach-ep93xx/edb93xx.c index 4b90899a66e9..dbdb822a0100 100644 --- a/arch/arm/mach-ep93xx/edb93xx.c +++ b/arch/arm/mach-ep93xx/edb93xx.c @@ -88,7 +88,7 @@ static void __init edb93xx_register_i2c(void) * EDB93xx SPI peripheral handling *************************************************************************/ static struct cs4271_platform_data edb93xx_cs4271_data = { - .gpio_nreset = -EINVAL, /* filled in later */ + /* Intentionally left blank */ }; static struct spi_board_info edb93xx_spi_board_info[] __initdata = { @@ -114,14 +114,38 @@ static struct ep93xx_spi_info edb93xx_spi_info __initdata = { /* Intentionally left blank */ }; +static struct gpiod_lookup_table edb93xx_cs4272_edb9301_gpio_table = { + .dev_id = "spi0.0", /* CS0 on SPI0 */ + .table = { + GPIO_LOOKUP("A", 1, "reset", GPIO_ACTIVE_LOW), + { }, + }, +}; + +static struct gpiod_lookup_table edb93xx_cs4272_edb9302_gpio_table = { + .dev_id = "spi0.0", /* CS0 on SPI0 */ + .table = { + GPIO_LOOKUP("H", 2, "reset", GPIO_ACTIVE_LOW), + { }, + }, +}; + +static struct gpiod_lookup_table edb93xx_cs4272_edb9315_gpio_table = { + .dev_id = "spi0.0", /* CS0 on SPI0 */ + .table = { + GPIO_LOOKUP("B", 6, "reset", GPIO_ACTIVE_LOW), + { }, + }, +}; + static void __init edb93xx_register_spi(void) { if (machine_is_edb9301() || machine_is_edb9302()) - edb93xx_cs4271_data.gpio_nreset = EP93XX_GPIO_LINE_EGPIO1; + gpiod_add_lookup_table(&edb93xx_cs4272_edb9301_gpio_table); else if (machine_is_edb9302a() || machine_is_edb9307a()) - edb93xx_cs4271_data.gpio_nreset = EP93XX_GPIO_LINE_H(2); + gpiod_add_lookup_table(&edb93xx_cs4272_edb9302_gpio_table); else if (machine_is_edb9315a()) - edb93xx_cs4271_data.gpio_nreset = EP93XX_GPIO_LINE_EGPIO14; + gpiod_add_lookup_table(&edb93xx_cs4272_edb9315_gpio_table); gpiod_add_lookup_table(&edb93xx_spi_cs_gpio_table); ep93xx_register_spi(&edb93xx_spi_info, edb93xx_spi_board_info, diff --git a/arch/arm/mach-ep93xx/vision_ep9307.c b/arch/arm/mach-ep93xx/vision_ep9307.c index 30d9cf3791eb..9471938df64c 100644 --- a/arch/arm/mach-ep93xx/vision_ep9307.c +++ b/arch/arm/mach-ep93xx/vision_ep9307.c @@ -164,7 +164,7 @@ static struct i2c_board_info vision_i2c_info[] __initdata = { * SPI CS4271 Audio Codec *************************************************************************/ static struct cs4271_platform_data vision_cs4271_data = { - .gpio_nreset = EP93XX_GPIO_LINE_H(2), + /* Intentionally left blank */ }; /************************************************************************* @@ -241,6 +241,15 @@ static struct spi_board_info vision_spi_board_info[] __initdata = { }, }; +static struct gpiod_lookup_table vision_spi_cs4271_gpio_table = { + .dev_id = "spi0.0", /* cs4271 @ CS0 */ + .table = { + /* RESET */ + GPIO_LOOKUP_IDX("H", 2, NULL, 0, GPIO_ACTIVE_LOW), + { }, + }, +}; + static struct gpiod_lookup_table vision_spi_cs_gpio_table = { .dev_id = "spi0", .table = { @@ -292,6 +301,7 @@ static void __init vision_init_machine(void) ep93xx_register_i2c(vision_i2c_info, ARRAY_SIZE(vision_i2c_info)); + gpiod_add_lookup_table(&vision_spi_cs4271_gpio_table); gpiod_add_lookup_table(&vision_spi_mmc_gpio_table); gpiod_add_lookup_table(&vision_spi_cs_gpio_table); ep93xx_register_spi(&vision_spi_master, vision_spi_board_info, diff --git a/include/sound/cs4271.h b/include/sound/cs4271.h index 6ff23ab48894..5a55d135bdea 100644 --- a/include/sound/cs4271.h +++ b/include/sound/cs4271.h @@ -9,7 +9,6 @@ #define __CS4271_H struct cs4271_platform_data { - int gpio_nreset; /* GPIO driving Reset pin, if any */ bool amutec_eq_bmutec; /* flag to enable AMUTEC=BMUTEC */ /* diff --git a/sound/soc/codecs/cs4271.c b/sound/soc/codecs/cs4271.c index 9e6f8a048dd5..74a84832d958 100644 --- a/sound/soc/codecs/cs4271.c +++ b/sound/soc/codecs/cs4271.c @@ -13,9 +13,8 @@ #include #include #include -#include +#include #include -#include #include #include #include @@ -160,9 +159,7 @@ struct cs4271_private { /* Current sample rate for de-emphasis control */ int rate; /* GPIO driving Reset pin, if any */ - int gpio_nreset; - /* GPIO that disable serial bus, if any */ - int gpio_disable; + struct gpio_desc *reset; /* enable soft reset workaround */ bool enable_soft_reset; struct regulator_bulk_data supplies[ARRAY_SIZE(supply_names)]; @@ -487,12 +484,10 @@ static int cs4271_reset(struct snd_soc_component *component) { struct cs4271_private *cs4271 = snd_soc_component_get_drvdata(component); - if (gpio_is_valid(cs4271->gpio_nreset)) { - gpio_direction_output(cs4271->gpio_nreset, 0); - mdelay(1); - gpio_set_value(cs4271->gpio_nreset, 1); - mdelay(1); - } + gpiod_direction_output(cs4271->reset, 1); + mdelay(1); + gpiod_set_value(cs4271->reset, 0); + mdelay(1); return 0; } @@ -612,9 +607,8 @@ static void cs4271_component_remove(struct snd_soc_component *component) { struct cs4271_private *cs4271 = snd_soc_component_get_drvdata(component); - if (gpio_is_valid(cs4271->gpio_nreset)) - /* Set codec to the reset state */ - gpio_set_value(cs4271->gpio_nreset, 0); + /* Set codec to the reset state */ + gpiod_set_value(cs4271->reset, 1); regcache_mark_dirty(cs4271->regmap); regulator_bulk_disable(ARRAY_SIZE(cs4271->supplies), cs4271->supplies); @@ -639,7 +633,6 @@ static const struct snd_soc_component_driver soc_component_dev_cs4271 = { static int cs4271_common_probe(struct device *dev, struct cs4271_private **c) { - struct cs4271_platform_data *cs4271plat = dev->platform_data; struct cs4271_private *cs4271; int i, ret; @@ -647,17 +640,11 @@ static int cs4271_common_probe(struct device *dev, if (!cs4271) return -ENOMEM; - cs4271->gpio_nreset = of_get_named_gpio(dev->of_node, "reset-gpio", 0); - - if (cs4271plat) - cs4271->gpio_nreset = cs4271plat->gpio_nreset; - - if (gpio_is_valid(cs4271->gpio_nreset)) { - ret = devm_gpio_request(dev, cs4271->gpio_nreset, - "CS4271 Reset"); - if (ret < 0) - return ret; - } + cs4271->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_ASIS); + if (IS_ERR(cs4271->reset)) + return dev_err_probe(dev, PTR_ERR(cs4271->reset), + "error retrieveing RESET GPIO\n"); + gpiod_set_consumer_name(cs4271->reset, "CS4271 Reset"); for (i = 0; i < ARRAY_SIZE(supply_names); i++) cs4271->supplies[i].supply = supply_names[i]; From patchwork Wed Nov 29 21:28:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13473462 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="uw3wiAJ4" Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A399DD67 for ; Wed, 29 Nov 2023 13:28:51 -0800 (PST) Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2c9b5e50c1fso4101791fa.0 for ; Wed, 29 Nov 2023 13:28:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701293330; x=1701898130; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Y5TZCHl5JrsKzVzdedTBOjjaGJPtqogPOahlRjnAK3I=; b=uw3wiAJ4T0B+RHiz6qEy3mNAL9bPy+MFF+0MRp9lbwFNPXAHTJ61Ov3tMfP5zmAur2 jdKimxnelbYRUntLj4F4bHjeBg3fOyjEgGO+qAeVfBK6vL3SRf8XYHd/4xKqWblD7hlz 9PgV9+ZFCq8KhCBgXK2NTno+whua27beAaf9jhoiImC9XnVFoqTnQDP2wokHNVJIBTh7 ACl/pZTS4Hk5UN5VzcHFwOmdqh7XTTAbrmZ0/5DU76Thv3zAwAdr/usJ1FiUl0FNShtU IdvVbg5A8JKg0ausQsFTG/POjBm9XKk0pUB4ZnavAACF25p7x5SQa1PHsDoJGwzJGwlW sDQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701293330; x=1701898130; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y5TZCHl5JrsKzVzdedTBOjjaGJPtqogPOahlRjnAK3I=; b=C06cNL+4H7MtY4DWwCNl0qfijId6jGt/5VvEySXpGs00YG/3wMRxJrEPcpi8T6nXew 21aMqmgFltj4OWfSs9lnwitdmoRVVw4o8eZasLCldkTajJkCWWroLy8eTZ8vtqRbRvOA CIYdXwY1VYy04WMgXhzzzzvHD0VxAfUs/4U4ZQhE2VdHInLvZJz1K0F81OA3YUVvDSK6 cPdaRsesPSUneIF0bY9/TcY2AyWYisRHV7/3Vb465KB+q9Ft8GFFk/JyjR2wtrUMFm3W 5lMAcZRPDDjWYd9P8lZNGRpvvsjR/DOW2jPsvvXHbsn0JuVXf+t7OGYphR2NMcJATrJU DFpw== X-Gm-Message-State: AOJu0YwhlpZYugimVmSP5VNh0s79wu+yaXBhjknxvlloXPdPnmi8lCL4 37QodoOsvbxFqOlNZAe8/qLsHQ== X-Google-Smtp-Source: AGHT+IG2iJRuG1eHTWV98yu7FrzVbLk4F45mt7qi99SvzYEoV5Esdv1xtlzmQWw30MGgDqcTjnHMVA== X-Received: by 2002:a2e:9b4d:0:b0:2c9:b4c6:a7ff with SMTP id o13-20020a2e9b4d000000b002c9b4c6a7ffmr3942168ljj.40.1701293329961; Wed, 29 Nov 2023 13:28:49 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id b5-20020a05651c032500b002bcdbfe36b9sm2106196ljp.111.2023.11.29.13.28.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 13:28:49 -0800 (PST) From: Linus Walleij Date: Wed, 29 Nov 2023 22:28:43 +0100 Subject: [PATCH 07/10] ASoC: cirrus: edb93xx: Drop legacy include Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231129-descriptors-sound-cirrus-v1-7-31aa74425ff8@linaro.org> References: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> In-Reply-To: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij X-Mailer: b4 0.12.4 This driver includes the legacy GPIO API but does not use any symbols from it. Drop the include. Signed-off-by: Linus Walleij Reviewed-by: Alexander Sverdlin --- sound/soc/cirrus/edb93xx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/cirrus/edb93xx.c b/sound/soc/cirrus/edb93xx.c index 6b6817256331..8bb67d7d2b4b 100644 --- a/sound/soc/cirrus/edb93xx.c +++ b/sound/soc/cirrus/edb93xx.c @@ -11,7 +11,6 @@ */ #include -#include #include #include #include From patchwork Wed Nov 29 21:28:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13473464 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ngKbmoUU" Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0FA9D7F for ; Wed, 29 Nov 2023 13:28:52 -0800 (PST) Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2c9c1e39defso3625361fa.1 for ; Wed, 29 Nov 2023 13:28:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701293331; x=1701898131; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Iu+jnDbRLvNSd29JPH0PlE0Rt4h1OZvlGiQIvlLElkY=; b=ngKbmoUUT5FuNtEHWf5Ps5LydKMHS7Td03FEC97NElV6fGj0JJhxjy1YnN/pLSiO7x ytrqzclKM9i3n9pwQkrR8BnC6g3tgYvovY7Mb2UWohfdayJYio1OaXpKLNuRVhI/ZSuA 1Yg6c7zUgsRN9e/b759PNtDtIzPBM7lypJzpkz+LXXZ3TqYeMYwCdRoEoF1o5ezkv45K sM6SjswQVtfEm6OhucQztWtVC2J3//d7bclS0xJPFo+4jde35PLjNU19/mvujgEGH7TQ RRtSXpW8tOLzaWq9DViwrsfow9jA1lFgqMVHBNYaFQrS8hX2s1dvp0p7velZN082p7vr 2gMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701293331; x=1701898131; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Iu+jnDbRLvNSd29JPH0PlE0Rt4h1OZvlGiQIvlLElkY=; b=BD/BVWNw55wG9xqKYGfo9aZTowqhCicJy6p9EoHySxb0DSj6LoVZFJL6gZ6cSmIOb6 J4r8pOtdatRj+ifxSa+PsYmXpUjYyPYb5WSCnRm65YOEjp+k3ax0ThKv1zlaLbByNfyl Y026OFXcMIixoT1HtDIL1+1koElHegR5GozWpzzvA0wfUx9mxLAMNT59K0SPg93pBrsy U/dkVN/qvaYdPZNfEhDxy6Sy8ABFPN482bZkE98eKOuAqVfMyXuMEigrFRa6yXSMUNfZ u+NHEpUb3YjMLh2PJIbVXdaAUzyP/AVXG43tAGapbxLSBH0shg9rg9mJbWYmiTBTZE/8 qulA== X-Gm-Message-State: AOJu0YyB/NZtJs5c/Ldd9xH6UMtjkqLSB/zHgGbNs6EkZvUjUMPUpk5s aEK40NShR+kcgWBdyrg0lGPxYw== X-Google-Smtp-Source: AGHT+IF/28zICERnGlS5+OnSEEJkvgxEGnITMU5KpHeObXbDWy5BHjwpi8sDYXn7h5PUPVbGD2wWHA== X-Received: by 2002:a2e:87d9:0:b0:2c9:bfb1:aa75 with SMTP id v25-20020a2e87d9000000b002c9bfb1aa75mr2165119ljj.29.1701293331064; Wed, 29 Nov 2023 13:28:51 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id b5-20020a05651c032500b002bcdbfe36b9sm2106196ljp.111.2023.11.29.13.28.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 13:28:50 -0800 (PST) From: Linus Walleij Date: Wed, 29 Nov 2023 22:28:44 +0100 Subject: [PATCH 08/10] ASoC: cs42l42: Drop legacy include Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231129-descriptors-sound-cirrus-v1-8-31aa74425ff8@linaro.org> References: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> In-Reply-To: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij X-Mailer: b4 0.12.4 This driver includes the legacy GPIO API but does not use any symbols from it. Drop the include. Signed-off-by: Linus Walleij --- sound/soc/codecs/cs42l42.c | 1 - sound/soc/codecs/cs42l42.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c index 94bcab812629..2d11c5125f73 100644 --- a/sound/soc/codecs/cs42l42.c +++ b/sound/soc/codecs/cs42l42.c @@ -15,7 +15,6 @@ #include #include #include -#include #include #include #include diff --git a/sound/soc/codecs/cs42l42.h b/sound/soc/codecs/cs42l42.h index 7785125b73ab..3d85ebc59489 100644 --- a/sound/soc/codecs/cs42l42.h +++ b/sound/soc/codecs/cs42l42.h @@ -14,7 +14,7 @@ #include #include -#include +#include #include #include #include From patchwork Wed Nov 29 21:28:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13473465 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="H7rB1wto" Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB24410C2 for ; Wed, 29 Nov 2023 13:28:53 -0800 (PST) Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2c9c5d30b32so3510171fa.2 for ; Wed, 29 Nov 2023 13:28:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701293332; x=1701898132; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GU757npNrUowgHMI8BxiU0vGtre+9oPF8HlBVHP1/Qc=; b=H7rB1wtokBIDME4Yp/S3xHalZe+0WnVOEOh7j0jolKG4XZt/kKdUy1/R2NoJnKRvSx XM/rS8kaSeTIEakse/XUKF0ieYzR+tyPdQb3r4fCHCGp/6gRStvKjcAozqkYK6BF0eya dUVKlORSrhOWAVChxQ4GLvJu6spyvAdyibGz4i5Zb/YZtt3lh559DWFZHafWzRzA3yfl dq7drB4onry8vO2o/MEvgWuv2YtAR2DIBt5Yu6WyofPt9OLGUDh9/gHXwNqNk6KqL/lI I2kMsgYLH8pspClyMsASjSPiG+bmPQ2m0Gtu9ZAIxFbbpdQ1drqROZ4Vh8dffxvBHhvU ZDJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701293332; x=1701898132; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GU757npNrUowgHMI8BxiU0vGtre+9oPF8HlBVHP1/Qc=; b=pph2IhgklYfh1OJX9QgIedFTgaH+r2l+CpyUfTX2wkxaMZ2cz+tqKxf8z9Aa1WQiKp wrfXc/LAZCen5EiZKMlUkzzfsfOPQPdi+p95FqdhFnQ/QOYSKUaIQo6Cc4dF3OUyamtg kGsMz96UUCOKft8vG9/7dk6dvyu2gpcYGqNwCY9nqcXh0bzfDLXRxMgvWlZJ9Cv9Islo ew96uwUvXGWROcpo0Qyiq7Q1MudfhpiyvTjaqw+uaBtU2laIbsCCkLoBQ7mQPn9g6uf3 AADeVoCJ6pdXhiFFehdHt/+LxGowqlD4b1J+MqdDc2J6jeajg6/+6Nzvlmxu44aBINJ4 T15A== X-Gm-Message-State: AOJu0Yxp+LqrrRDZKD4tEgLEh8RymknpfSvgQ+M+r4WVRugCgmxeKcYi JtbYxTjT+Z//eT1MYYNXgJytXQ== X-Google-Smtp-Source: AGHT+IEdyUI6Rv6RH6eVMr/I17nk4CK9OjZr5lyleg/5SJIpqBPmIm2LRa2NEJpv2cv9yqxd+ociMg== X-Received: by 2002:a2e:7203:0:b0:2c9:bf97:81d1 with SMTP id n3-20020a2e7203000000b002c9bf9781d1mr1989104ljc.27.1701293332163; Wed, 29 Nov 2023 13:28:52 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id b5-20020a05651c032500b002bcdbfe36b9sm2106196ljp.111.2023.11.29.13.28.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 13:28:51 -0800 (PST) From: Linus Walleij Date: Wed, 29 Nov 2023 22:28:45 +0100 Subject: [PATCH 09/10] ASoC: cs43130: Drop legacy includes Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231129-descriptors-sound-cirrus-v1-9-31aa74425ff8@linaro.org> References: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> In-Reply-To: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij X-Mailer: b4 0.12.4 This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Signed-off-by: Linus Walleij --- sound/soc/codecs/cs43130.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/codecs/cs43130.c b/sound/soc/codecs/cs43130.c index 0b40fdfb1825..18933bf04684 100644 --- a/sound/soc/codecs/cs43130.c +++ b/sound/soc/codecs/cs43130.c @@ -11,7 +11,6 @@ #include #include #include -#include #include #include #include @@ -26,7 +25,6 @@ #include #include #include -#include #include #include #include From patchwork Wed Nov 29 21:28:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13473466 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PZXJFKMB" Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1230AD67 for ; Wed, 29 Nov 2023 13:28:55 -0800 (PST) Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2c887d1fb8fso3928421fa.0 for ; Wed, 29 Nov 2023 13:28:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701293333; x=1701898133; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HSsSWusvyuFKnB0n59GG/ZJpbxUajSal4/kkXB4+BwY=; b=PZXJFKMBTUVrKVvqZ/68DQT3iiTk5dSPHxWJOmhSdX2Z5yq2ZDXgY5JOTL0jQCGSBJ ASlO1h3r3BvUyOT3Ol/yA4rE5VyS/J6/VR33z8kl9zsfTN9juCJudwcJfoLTxGKMIRVy yh0VPhsLPNqD0KUdTdKmtR5SsQWKdfqjwlBApUuSpvNalxZzYiHUevUKptMnLGQgvIsG 8ncCDQt9OjPVcToMV7vRtEkc6ZL63gb6TKXhAxLgOV0igrPwzEyie0vwoQraNMnhv+jU tBzJH6bE6DC5vWYm79GaEDH3RveJ2VrOrff6Kur72MXCbpKG0hwVFz1/fvtuLYoNeuC/ D6bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701293333; x=1701898133; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HSsSWusvyuFKnB0n59GG/ZJpbxUajSal4/kkXB4+BwY=; b=jXvffNczydFRRmo72Lfm+izhOH4kZuM5L399meyxND6leOYwGQx8EpsY2sQ/FvlEks BfvNvlciHQX+I4giBoEpH87cHUwzUcebmRDPuazJdghqmx/RB0k8x4XTrELjowWJKbao b6qlimRpZR12WQsEWMRSQe3qLBWKcSv0p++erV8NRXVEZhI+w+Q3sCjP73dv60eyUlm5 EyUxZ/F1FlUcYF3aDxBxg+FC34ZrgtvMVYikDG+M6Mgb0CBYsBunim8MfmTRTECkHl2G tA1Q0ij1g34CkDMrlgwAF44Phy20TwzN5MhMZC540bPVKgEF8V5UMCoWhq0PisoKAIc2 2RHQ== X-Gm-Message-State: AOJu0YwmFDE/4VWPa5aBYffNga7UqodyAYSrl+mlR8n/i9rA3B78FOz8 qHNzr7/cIgyhZP2ebHx5tG5oMg== X-Google-Smtp-Source: AGHT+IEkmWdPL4oWl2UHqoreap/8MLKCw3gg/vwTWvzAYgZdYOH7cYqyChHDv5dnd47KwZaWZPj/7A== X-Received: by 2002:a2e:9f06:0:b0:2c9:b9bc:b029 with SMTP id u6-20020a2e9f06000000b002c9b9bcb029mr3098669ljk.17.1701293333337; Wed, 29 Nov 2023 13:28:53 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id b5-20020a05651c032500b002bcdbfe36b9sm2106196ljp.111.2023.11.29.13.28.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 13:28:52 -0800 (PST) From: Linus Walleij Date: Wed, 29 Nov 2023 22:28:46 +0100 Subject: [PATCH 10/10] ASoC: cs4349: Drop legacy include Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231129-descriptors-sound-cirrus-v1-10-31aa74425ff8@linaro.org> References: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> In-Reply-To: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij X-Mailer: b4 0.12.4 This driver includes the legacy GPIO API but does not use any symbols from it. Drop the include. Signed-off-by: Linus Walleij --- sound/soc/codecs/cs4349.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/cs4349.c b/sound/soc/codecs/cs4349.c index 9083228495d4..ca8f21aa4837 100644 --- a/sound/soc/codecs/cs4349.c +++ b/sound/soc/codecs/cs4349.c @@ -13,7 +13,6 @@ #include #include #include -#include #include #include #include