From patchwork Wed Nov 29 21:28:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13473490 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9138C4167B for ; Wed, 29 Nov 2023 21:29:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8RTgQ6i2ZAWCOn5uSE1VSydK3Fm/+ijOkXXTfa4BLGw=; b=syWHi5O76Wvlgf 6Stah8SWf6oavW/QOON7Ailfpwgjg9BO+EUu6ko0Mr4dP1wdQ461XBL6eN3rhWdkmCPp69i++MM2A +9MyeGC6KF3GzY8Lc40CEtJ5pTU3AJSOZDZdTL2qtJ2lhVxd/hLqq7UbS7so0jEWi+jNT+jIK0OR6 +qdnYpp4OMfPLvcngkTKRCs8FulsaudYePxYPSnW8sCZpw6vEJKgdXhTMg0q4yEJLan0qSv/b1MP+ zizqDDYOpY2NR+0zvcG/8rFXDLVjCW77I8oEI1Hy6lO7PuUL3nfaMJjwm1ZzfD81LO7IEy7YTazNT A6+OTj2JH7/eabq7bhnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8S73-009KRb-1I; Wed, 29 Nov 2023 21:28:53 +0000 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8S6x-009KNV-32 for linux-arm-kernel@lists.infradead.org; Wed, 29 Nov 2023 21:28:49 +0000 Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2c871d566cfso3461481fa.3 for ; Wed, 29 Nov 2023 13:28:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701293323; x=1701898123; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=uGzqJZeCIvHWgx50HcN8P2Sdt/SHVZafM+S/3T4/ITk=; b=MeXAlKXxPQgv2r2X1oGMGjkVyNrkN3Y4XDEOE3BQcQk0Ov/I2Dc9i7D59ugBS9A4ix XXHFbDxNpHxUzi1h9XOPesGQe25PcMPafVZ/dKACZ0RlidHUvyVVrSPykPaZf8nbDLr9 qsqiwXrxTn2v46Tzm8XYVJVc7Nt25Is6pO2NiY1xdIXaqkrp9CB+KPwt3eytSNrDleKq KsHIRVCeqHhNEfj2MsIRPm7gn2Pl9dw3I65Xd/Y8zbS7NqapUsLtB4irDAx+5i1xpeh2 W+WGFq8qqHTTFx3NtUwjlQfAS1kn+rLhrH+H/rfQA2NdJLK70+w9S0dwXBucnXHQytRq mpTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701293323; x=1701898123; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uGzqJZeCIvHWgx50HcN8P2Sdt/SHVZafM+S/3T4/ITk=; b=be3SJyntYESywRgdpnhDaOo6Kl4Vt51Nl2wmbHIcKNVs/N47SHcy4JGqeLi5qHPOJK PG5IQgalyvJiL+HMFwDVoApsj2UkAmSCil9ZbSw2YMg083hTYwu8BXC33BQixKVqaMet AURIBMc94u7U/LA/pzO1bu2H6GmWtJTIdmPG+SSxNFXAEemXsSsRK62MTC3kDrTaKV3L cuUgEZM+JvaZMx66q5L/si6FvxP2cFZ3qlilWpB3Zd3egit8x89kdHCTY6eamUhXlb19 eQeOrT0sSXhDWfjAG73q4aiZ19tjILhDqBkEpkfu4zL672ObhkcqNUTZf+B9dBwbCgoh WvZQ== X-Gm-Message-State: AOJu0YxSjCIYd70WhEul2SAN9MI8ZLtMjG27CIBd9h4mF45op9UzNEax 31fNIPsyUAjsLVa2CxIr7/iGlQ== X-Google-Smtp-Source: AGHT+IH2iP1+SnhRh5dk6NH/SIXt5a1DgU9BeCKEI9Kd5MNkN/wjAcRvj26p+QcR+8v7vqnF7DFCiA== X-Received: by 2002:a05:651c:b27:b0:2c9:a9ba:97ec with SMTP id b39-20020a05651c0b2700b002c9a9ba97ecmr6389122ljr.38.1701293322448; Wed, 29 Nov 2023 13:28:42 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id b5-20020a05651c032500b002bcdbfe36b9sm2106196ljp.111.2023.11.29.13.28.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 13:28:41 -0800 (PST) From: Linus Walleij Date: Wed, 29 Nov 2023 22:28:37 +0100 Subject: [PATCH 01/10] ASoC: cs35l32: Drop legacy include MIME-Version: 1.0 Message-Id: <20231129-descriptors-sound-cirrus-v1-1-31aa74425ff8@linaro.org> References: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> In-Reply-To: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231129_132847_984171_0AD379BE X-CRM114-Status: GOOD ( 11.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This driver includes the legacy GPIO API but does not use any symbols from it. Drop the include. Signed-off-by: Linus Walleij --- sound/soc/codecs/cs35l32.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/cs35l32.c b/sound/soc/codecs/cs35l32.c index 138040618438..d1350ffbf3bd 100644 --- a/sound/soc/codecs/cs35l32.c +++ b/sound/soc/codecs/cs35l32.c @@ -13,7 +13,6 @@ #include #include #include -#include #include #include #include From patchwork Wed Nov 29 21:28:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13473487 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D607C4167B for ; Wed, 29 Nov 2023 21:29:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=goI1+ChyYl75GMtGfsJg8a2harG03X99Sj4fAqIa+mc=; b=HLJIvP1f18Aoy8 0YeAVuV80LHkZDT/KmgW1JTwE8JeWuODFZffGKS5+Mzkm7qAv50waIy8HicVAZL52COYPxCdT4qBz xmZREIQYK3RsYtUZ0DrwL71udK4MxbsXHPySclzOcHxkX2tguF5moBmDNBYUig4MTLZsBzEUGrez3 9QKuCp+Q7ILiwUiJREKbqsuVDikV7R1FtiC4TOMnoNv2q7K9Lh9AgEzIBtpURQRTFWpcb/b6dkLKf 1GpyQI5KRvfP1fFTH3IBENVHI5wUYjNGMhFkkuEUZSF0C49rsqC7dkHiqfNCbDWaLM8pVUeFDLqzD kP0jVBi3dtjFIrOzF+xA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8S74-009KSF-0q; Wed, 29 Nov 2023 21:28:54 +0000 Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8S6x-009KNg-33 for linux-arm-kernel@lists.infradead.org; Wed, 29 Nov 2023 21:28:49 +0000 Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2c9b77be7ceso3800161fa.2 for ; Wed, 29 Nov 2023 13:28:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701293323; x=1701898123; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=w98h2S9ziwqYlZ5eRbk63Kp1zoQv2lCTleH6DrVq65w=; b=emgQdUJPvo+6iyjlTiSq43SSzvxl5tA2kmdM8IJKv4YOVoYAd+wWNJpH21fHby+Qda Z+gNXsXccObbiEqFLMQP1IkavRWjux4PmLngvMQ5l3wIyH0Qm8tLKbfo7SgTaKWKRhcj Ol2Eri5L2bvTJN1FzYr3PpRGshdPiAUWmufmDmPOuCqxD6mx3a6/77HaRU/cBPfeQFe1 hxMh3KrQBXFlv/noUegnSEQlcH7jKrI9aMZI7ib10qU/XxwAKVowH+T6ZOKqx7QHSLxh PHY7Ldp+AwzPxFzB70pOd1EDeYRyVhlNH91hhtOdrcsZ10iXSK6AS+dxqSPtxpPE2afo f43g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701293323; x=1701898123; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w98h2S9ziwqYlZ5eRbk63Kp1zoQv2lCTleH6DrVq65w=; b=EeW1BdZDVUjSjXResBGT6LBex/qvZvmL7BR6RnQZsytTjhDPvH/R6cU0eGGJ2zrI9W LOVumws/M+oP1zytHmVkfA9pjW/I7l12bz+8r/pEWIr7IIh4CUGE7Y9MeYFLpYjBm0Dd ChrU0XDMua7IYtQY/e1+vnjSO6tWcFB4ZeNvMzyupKkqAN0dNwzPTbDlTntlcelstWPU LSSPF/FzLf0/0tv8c+3vHwcksZq7IXt0veNAmdizmDnzHZUJ5ggYjY0UJmHVT5kCEerR yovBnSQjzscoJn4COXBic9FcPhur3ZLU6gq4q/X9lbzR3uavLqObDHlMgFlMsMx8TXE+ lZcw== X-Gm-Message-State: AOJu0YxgO/xCBzmjH0imxVdiq5UEVoQVv1MxNUv5A+0TJpUQeaDbVl5t 3O0iOE1WfqHI0zrBMVAGLWKZYg== X-Google-Smtp-Source: AGHT+IEC56sw8UX2ii4LX1W7ed8InaZsSu/jcEIqr13PU5ZEBtax1tJX/hGuJk6YOIA9moirDg3WrA== X-Received: by 2002:a2e:874b:0:b0:2c9:c58a:b2f4 with SMTP id q11-20020a2e874b000000b002c9c58ab2f4mr1049900ljj.41.1701293323490; Wed, 29 Nov 2023 13:28:43 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id b5-20020a05651c032500b002bcdbfe36b9sm2106196ljp.111.2023.11.29.13.28.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 13:28:43 -0800 (PST) From: Linus Walleij Date: Wed, 29 Nov 2023 22:28:38 +0100 Subject: [PATCH 02/10] ASoC: cs35l33: Fix GPIO name and drop legacy include MIME-Version: 1.0 Message-Id: <20231129-descriptors-sound-cirrus-v1-2-31aa74425ff8@linaro.org> References: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> In-Reply-To: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231129_132847_991027_5D0A9C3E X-CRM114-Status: GOOD ( 16.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Further the driver is requesting "reset-gpios" rather than just "gpios" from the GPIO framework. This is wrong because the gpiolib core will add "-gpios" before processing the request from e.g. device tree. Drop the suffix. The last problem means that the optional RESET GPIO has never been properly retrieved and used even if it existed, but nobody noticed. Fixes: 3333cb7187b9 ("ASoC: cs35l33: Initial commit of the cs35l33 CODEC driver.") Signed-off-by: Linus Walleij --- sound/soc/codecs/cs35l33.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/cs35l33.c b/sound/soc/codecs/cs35l33.c index 4010a2d33a33..a19a2bafb37c 100644 --- a/sound/soc/codecs/cs35l33.c +++ b/sound/soc/codecs/cs35l33.c @@ -22,13 +22,11 @@ #include #include #include -#include #include #include #include #include #include -#include #include #include "cs35l33.h" @@ -1165,7 +1163,7 @@ static int cs35l33_i2c_probe(struct i2c_client *i2c_client) /* We could issue !RST or skip it based on AMP topology */ cs35l33->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev, - "reset-gpios", GPIOD_OUT_HIGH); + "reset", GPIOD_OUT_HIGH); if (IS_ERR(cs35l33->reset_gpio)) { dev_err(&i2c_client->dev, "%s ERROR: Can't get reset GPIO\n", __func__); From patchwork Wed Nov 29 21:28:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13473489 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4FC6DC07E98 for ; Wed, 29 Nov 2023 21:29:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zDUMk7X7ZK+CZo/YgqKgEEZXg4S/4t5aX8Mz29QHXwI=; b=Oq0yx7PsjFqB2v pRl5tgAJKMgccxj+v9Y2UsLQpYXVfOHB2OJscHCRYpKRp83Og+idqeWZGZT2Jv3C5w2bVFXfDuet2 VSG4ap/7v8zsjIRMfa4C9wHwrdNfV0kC46E2APh3lL4X7GNxmO3xtVenRt3+4k0hvrSu3Bkjm5gTo rQtugN4+UN2m8e/f7SLX2sUD/i1MlRRf9oQYQ66wLpoq1/BcPzr/KDGY53j+VzlNf4XOTb+/t9yaL H7DksUypaVdzk7F7mJAWeoOoCh54lh6gCP/fRw7CsBbxTKYXm0HCi/yw1HznFfJXNwWnp+cPO2Pzd m7ZcE6F8MS/XWlMzix+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8S75-009KSs-19; Wed, 29 Nov 2023 21:28:55 +0000 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8S6x-009KNl-32 for linux-arm-kernel@lists.infradead.org; Wed, 29 Nov 2023 21:28:49 +0000 Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2c9b5b72983so3743531fa.2 for ; Wed, 29 Nov 2023 13:28:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701293324; x=1701898124; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gxA1zyyyxC7/6y6RpRxRpLmaP1pTY49ZhzDzMcyXsOY=; b=S9y3BXYtcKxWGMH8uORITBBwY/usSQr70QSoK0FxSEj3RosG68kYXozW1uPRsqzdpw fjg0KD02NdrXb1QnUBvA1zsMyYHrOqvk80gldUcBLUpDP78/WkLKx2/tqX5HuM3Ci19R TbG8nzZkZbxcuZOgjTdXIjrHACneCftinsKg8k2dxi/7BlwBgCZ4mhc04M9e8AUztib3 fntRwBqLpgBIIVL5qMTxUfVK1sKXREj1SlxQ6FovaZssaq2xCijNZB6w+sPHRV9Eolgh +Krw1daKawFSZpBeKFnhfrWZ3i06jS4hTrFl7Z0zH/84rNuzEzU8fIRx9RhRRKLndMI0 TQ2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701293324; x=1701898124; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gxA1zyyyxC7/6y6RpRxRpLmaP1pTY49ZhzDzMcyXsOY=; b=nTIsVoBNhZynEDzzQcWOtmUFtIc6EkTecd60PDnEbJwSQeE/lUp7dV3MNYu40vYARI vX9SkUovCnUSwbUu/MQcSoiAXacLZ+sBohSCDWZ/SL+1l2GLD6I8FxiPvqZuW3QfTeS0 aKmbNwDg9Tc5B2ys/BZgZiVNMq5tC5v/QMleyhBdmw0RqYJFRe2zpWL0GweUcD50EQOD 3ATNPA8Fh3wu1NgTW0RUquX4YfD2vg7btQ8dZF0X1a4s0D+NtUj7R+mFj0d+9iL8pP/5 E8tXwbvNk4CltDYhbMvfnWIVqn5Krlv7SsV2jNrmCLeo1ATo5KgnPK6FtcbDoY3z54nc Ye3g== X-Gm-Message-State: AOJu0YzciwxBtbzfZRDhfaHavfPhUoAn/24a9XKs/3zOFIQHLf8aVgt5 GnC6JtvMcLmLUJyNFE90Rvd41g== X-Google-Smtp-Source: AGHT+IH2XK3VmzyApGKH2dJRP5mNU0HGdkujQYH19VxvKR71Nk9rdeM2oIikSY71v9WV2Mt3FvghIA== X-Received: by 2002:a2e:8709:0:b0:2c9:c192:42a8 with SMTP id m9-20020a2e8709000000b002c9c19242a8mr1654073lji.38.1701293324577; Wed, 29 Nov 2023 13:28:44 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id b5-20020a05651c032500b002bcdbfe36b9sm2106196ljp.111.2023.11.29.13.28.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 13:28:44 -0800 (PST) From: Linus Walleij Date: Wed, 29 Nov 2023 22:28:39 +0100 Subject: [PATCH 03/10] ASoC: cs35l34: Fix GPIO name and drop legacy include MIME-Version: 1.0 Message-Id: <20231129-descriptors-sound-cirrus-v1-3-31aa74425ff8@linaro.org> References: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> In-Reply-To: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231129_132847_987858_3B6C63BE X-CRM114-Status: GOOD ( 15.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Further the driver is requesting "reset-gpios" rather than just "gpios" from the GPIO framework. This is wrong because the gpiolib core will add "-gpios" before processing the request from e.g. device tree. Drop the suffix. The last problem means that the optional RESET GPIO has never been properly retrieved and used even if it existed, but nobody noticed. Fixes: c1124c09e103 ("ASoC: cs35l34: Initial commit of the cs35l34 CODEC driver.") Signed-off-by: Linus Walleij --- sound/soc/codecs/cs35l34.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/cs35l34.c b/sound/soc/codecs/cs35l34.c index e5871736fa29..cca59de66b73 100644 --- a/sound/soc/codecs/cs35l34.c +++ b/sound/soc/codecs/cs35l34.c @@ -20,14 +20,12 @@ #include #include #include -#include #include #include #include #include #include #include -#include #include #include #include @@ -1061,7 +1059,7 @@ static int cs35l34_i2c_probe(struct i2c_client *i2c_client) dev_err(&i2c_client->dev, "Failed to request IRQ: %d\n", ret); cs35l34->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev, - "reset-gpios", GPIOD_OUT_LOW); + "reset", GPIOD_OUT_LOW); if (IS_ERR(cs35l34->reset_gpio)) { ret = PTR_ERR(cs35l34->reset_gpio); goto err_regulator; From patchwork Wed Nov 29 21:28:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13473496 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E007C4167B for ; Wed, 29 Nov 2023 21:29:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=03mGekfwhcKbffvVJMID+xSn1nGLcsEqS1YnMmJoG08=; b=mGUiN7HCLr++Vg HewHh+Bb5X3Mwcserz2doD0p7A42LAybz9n/iiniEXV+/kyc9Qb/CZKluTV6OI8dMClThx3bIVK0D S5l2hStKGnwv5p2gpMA5KoDlGNSVKWdFpXrJ49jnQ4LlK8YoX5yxT3UGsftVWauJCNEzH2fHLRoWd diYTEnix7TqS6U8Hn8iRlU89YOBGjl48GlK8wtUD4sryZY8fqpKf35kCzvxAIt8QRAeC8W95Q6W1c ciNyeSbvnDLscyYEOdRDLdc/LIp4S5wDoReWs0kLGxAWH4ZP3on+rrD9/O/uEYeQHQekpA21/74G9 xWof+So0GfM7zMF+Io8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8S7b-009Ki0-2n; Wed, 29 Nov 2023 21:29:27 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8S78-009KUh-1j for linux-arm-kernel@bombadil.infradead.org; Wed, 29 Nov 2023 21:28:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Cc:To:In-Reply-To:References: Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Sender:Reply-To:Content-ID:Content-Description; bh=YU/umhZ4xMv6PXObbvZL6R5y01gsoGYZgYp3KJFvARs=; b=mY6BODNZ/yAh92lMZFuAbCb38a 9Nl0J0Q7LsSmr7widMQJvuRaFEcmufHTJCRlpg8t6SLLLe0WyQaaiqTKq0bfls2znnBSKwjvRzkqO s7XKAQtHjnfndFY/d31mam5N/w5n4q5kT3weDyvJyX9wCsChrkx+oZwr95UHGLy/sBpfRNuKqU30z rGlKDTIMtqnnYdNDlfUkLKwBuAaMmHFe5xBJ5okPlikFJF9xK6AAsH7r8ZyO44fpQrfL3VK1lYofy K9d3OAz3MVAH81k3uo04HhwpVuMZFvlcO5S78ktSYZ8x3KkvD8M9cGOI/0x9e0AvTUQcwK5m4aX1e BpR6qFQg==; Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8S70-000Tmf-2b for linux-arm-kernel@lists.infradead.org; Wed, 29 Nov 2023 21:28:56 +0000 Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2c887d1fb8fso3925871fa.0 for ; Wed, 29 Nov 2023 13:28:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701293326; x=1701898126; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=YU/umhZ4xMv6PXObbvZL6R5y01gsoGYZgYp3KJFvARs=; b=KCQ+qRyS7qy1cuLrwTbSYFMVSYwYkjSUWM3rZhjfkCwiLq4zGGXMrkyCzrCLH0W7ej XyIqZHZB9R75rV/ylhOLlM4iO26AS8QBQ9O2CBuNd7RgvvW7GYP9BY4ZJkNOwsYPZzm+ vOE0HAewOw2fcGyMM7mlv2W+zYk8jjhmIe/koWCoH3LRVo1Vi6jekmYcAeTDPki3NZbd rIDvrZf8eZgqDLjyvnBTEYxKNtjlNn4uNZvo9M//+M3+uUcxupJLd2HK/HLCiHs9Zxsw qtSOBUyOPVss2jJiFCAo5sYE+Lih1170WvHsnR0wrJQ5n4LfguioKrZtFrBvRgXye1l6 rjTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701293326; x=1701898126; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YU/umhZ4xMv6PXObbvZL6R5y01gsoGYZgYp3KJFvARs=; b=wJQ2SahwIQLKMCOOjsIRjX2gWrlU2i7DT7mWxhViSb31l25wm935ImeTBpxv5eNG7Q WC9cwRXGXLn4tbGVOA47ms9IqoVS67fYEBKwghCCcQEQUEj8LC72HBzg+hiuvjqp8YJz DY99RXchjkRZ4/cgR8fHF2i2JZYsCurTZDow4FfRyr0ARZMCE3h6dIcRDeh+iAx4DWEC dRXs1Hn4CqEte9Ym0EjXeisR/nqf5eYJAGkkcXvj6+KJT6ev+L6piepvXkvLYHti855C lwl99XeWtU3zeFBejcod/AVXak5vvKll9lUpFZMXGQNXqxUqhiEtFHuYsxq8AZriEsVD vyHw== X-Gm-Message-State: AOJu0YxKnbYlB87L48y1q67yHrgXgK2FzjdwBdOUsO2muizQ4A9IzKFo bZC84OpesL6iAizxxVmawx9XwA== X-Google-Smtp-Source: AGHT+IE+lDIdHAdte4rENQsg0tSBQfqVYqAjeDvwRKqHOtDWVAZmyuqpLukchZeA3cMSJEgTRjKklw== X-Received: by 2002:a2e:88c6:0:b0:2c9:c438:d0fb with SMTP id a6-20020a2e88c6000000b002c9c438d0fbmr1191629ljk.34.1701293325848; Wed, 29 Nov 2023 13:28:45 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id b5-20020a05651c032500b002bcdbfe36b9sm2106196ljp.111.2023.11.29.13.28.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 13:28:45 -0800 (PST) From: Linus Walleij Date: Wed, 29 Nov 2023 22:28:40 +0100 Subject: [PATCH 04/10] ASoC: cs35l35: Drop legacy includes MIME-Version: 1.0 Message-Id: <20231129-descriptors-sound-cirrus-v1-4-31aa74425ff8@linaro.org> References: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> In-Reply-To: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231129_212853_173419_D006A532 X-CRM114-Status: GOOD ( 11.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Signed-off-by: Linus Walleij --- sound/soc/codecs/cs35l35.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c index 63a538f747d3..ddb7d63213a3 100644 --- a/sound/soc/codecs/cs35l35.c +++ b/sound/soc/codecs/cs35l35.c @@ -18,14 +18,12 @@ #include #include #include -#include #include #include #include #include #include #include -#include #include #include #include From patchwork Wed Nov 29 21:28:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13473488 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1E92C4167B for ; Wed, 29 Nov 2023 21:29:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IU5A1N+47IncsnTX1OTuTFvAjYdFKyTLg5cDSyisfE8=; b=cLl59DuXGgwvq/ ybd0yFOkp4xrk8AzGal/awkPoGjRmUWbuHB/i1ObmVfIjx6GzV/lOqqOPWOjPVyt8Oh/ZgCWV5eD+ wfi+GT7qC1zI3+dur6bbioyYlOGgxQHdXif7Qnxg2o56q0HXiTjMC6/1Tjk5z78StWcKyNhMy3y/V uA1nQbIM8qt1ETgQkrguAwMkGxAuXDrS+DyDhUUN1e0ye8G2FQfdYAy2UKS+e84D774JCg3Jy23gR cD5KpBO8j1XW2YjFxjUXEU9OF8DVIdtz0DeYMlTxUOtmYTcfLJjCncjDwvLrGOt0+XrK+dqhfwiuA JyporRkkY51dC4hG3BWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8S76-009KTk-03; Wed, 29 Nov 2023 21:28:56 +0000 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8S6z-009KOQ-0k for linux-arm-kernel@lists.infradead.org; Wed, 29 Nov 2023 21:28:50 +0000 Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2c9c4df1287so3639601fa.2 for ; Wed, 29 Nov 2023 13:28:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701293327; x=1701898127; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BhewE5OJd+lUpEbKMUw+a2p3lLwyC+mccGsAap2s2vQ=; b=pp5GbT4c9Ygh5TTQ3AKdIY++aebpR+U92C09ykqf1RKHnWhdH1w3u0FlZ+Ic6rWVW+ hQBqt4c4iynuCb+vhWPyBHftOxGRa0neMhDozLnYTVo+E1/Q/W+uB87bdEsU2WUPDuWJ MNMUX43hhZMpkNfPnLgvIWCeehfL4GMgbm2d2Z5VH5i4xXlZN9RpRFICzLlL+plifq2i PGgAV/B6WLBpeolSD0Gi+O6n8IBnpnZ4iyJcbr79TQlwWdaFKBr1cd49tYTbbLqSLyY4 4xYIQ5jBmUD41HQXOBP+rfSnKLe3xp7Rjn8i9elnFUsJI0j4H/+sibruZBzWl4sc00tq tBDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701293327; x=1701898127; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BhewE5OJd+lUpEbKMUw+a2p3lLwyC+mccGsAap2s2vQ=; b=LqVracT6oiJ198Ho+rg9PwQZrqZWpNSALP9NcgbsrQg43S4k2pgMHOlAl0+bKsbwbV oXEXJs3ZffgCb/uSp4187RXe8yozF62nd0eAem2fCYFSHNkicVMcrLWFE3pL1y4kfztl iLIpgym+q1w9Wn6cMQCPdYW+KLoZlVhyhwA9rRSd2qzSbQOeLL4jhEJFcmkojjTwlFWx 1u6+MlRDGQD/IHS2wOsK8cn5dn5JnfT6EKEfYEHqLP37mqS2EjavMmG84ZXvvf/K1Y/y mUvU2dUmgGz/aGsqrzsTyTS9y5hgGs98xLwexrYGgLzCyzsN8o4h+/eI3gi2UVR8Szub 1s7g== X-Gm-Message-State: AOJu0Ywxml0o8C+bbOC9ccocE6gm0lIKdW5IUSwoa3QbFVKax32lz8s2 WyVyn6LbJnmUfZM0e1rWwOzdsg== X-Google-Smtp-Source: AGHT+IGxbQDzbtRllfk3uIL9CtkIkPKjX8R74m1/levpV4rcuCDOPksrJ0QcmNJ3lIdNQ3SMD2Q4bg== X-Received: by 2002:a2e:8e27:0:b0:2c9:9a87:6683 with SMTP id r7-20020a2e8e27000000b002c99a876683mr8118803ljk.1.1701293327016; Wed, 29 Nov 2023 13:28:47 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id b5-20020a05651c032500b002bcdbfe36b9sm2106196ljp.111.2023.11.29.13.28.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 13:28:46 -0800 (PST) From: Linus Walleij Date: Wed, 29 Nov 2023 22:28:41 +0100 Subject: [PATCH 05/10] ASoC: cs35l36: Drop legacy includes MIME-Version: 1.0 Message-Id: <20231129-descriptors-sound-cirrus-v1-5-31aa74425ff8@linaro.org> References: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> In-Reply-To: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231129_132849_293932_351574DC X-CRM114-Status: GOOD ( 11.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Signed-off-by: Linus Walleij --- sound/soc/codecs/cs35l36.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/codecs/cs35l36.c b/sound/soc/codecs/cs35l36.c index f2fde6e652b9..ec407aca33e9 100644 --- a/sound/soc/codecs/cs35l36.c +++ b/sound/soc/codecs/cs35l36.c @@ -18,14 +18,12 @@ #include #include #include -#include #include #include #include #include #include #include -#include #include #include #include From patchwork Wed Nov 29 21:28:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13473491 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4AC3AC4167B for ; Wed, 29 Nov 2023 21:29:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K3xV343WngtEv/0MOjlt4LNkXxbkl/g+HQSJU/nviEY=; b=nvPf0YQJsnpkiS Qfjr9W3AnC6oXnuXwDXFso9eaj6JPycQBFhTLFop6ElzkNo4vAtcrz+DikBLBeBEHxoCKtH5GOEv8 CTfjdhdTvNYpFLWlgujgG+nqapvTe0OorlDFBdOaNWt/2A2G8dRVch0KAdO3byHiJ0k3Zhx6GVUgx fTPNuquYyWs+47nSqkEJlJk7NXif6BjLDPogn2dwtrG5SnooGq1VZTHs2pMMlXqcp3xZb2+SXB4Ke E4VVDB1zhE9tPH5Coaxh1KrJ7OIueMREykJtEIm5Acvz9UQIVuDMHGBVAFQqMTOmWZQNBwXx4wV1d +BCTmCph7C8Ul8aE0sPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8S7X-009Kda-1j; Wed, 29 Nov 2023 21:29:23 +0000 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8S70-009KPV-0h for linux-arm-kernel@lists.infradead.org; Wed, 29 Nov 2023 21:28:51 +0000 Received: by mail-lj1-x230.google.com with SMTP id 38308e7fff4ca-2c87acba73bso3745101fa.1 for ; Wed, 29 Nov 2023 13:28:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701293329; x=1701898129; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=rd9nw7xvRPUV3hk495kPLrQSq+AWlSC2p6ACSHGPZ1M=; b=eEAkiRBUDgW48dRYABS0C+IhD1bq7+kkrUQOhYkDG2HNo08gdw4j1mt1nIj+Y2uedb i+WmTxZvc1kkm2K0uQ5PWVHN/San69DgW/WxpwQQUUATXOS+Plmgnhnz1cpdFJUpzYHn /RsTzJ2SyCIX5ydP/p1B6iFFy9guiQ+uJurto2CUKRZNd/St4hIag0xdey9BnKmlf7vC KuOXV1YGEVCjvbKbjWTNiKYSXgKCQUL7AKh/Fb0I7MPOwkuzCKZsVlYmYO3o/YPRsLtg ooeh6TftftNKTgP2DHtbh4pUbch5Ym2mkpIAju92WhLo4/S4VMfYXgVYiNdeS9WDiBry AS7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701293329; x=1701898129; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rd9nw7xvRPUV3hk495kPLrQSq+AWlSC2p6ACSHGPZ1M=; b=bhgYuOSMld6NtXAUs/633qvUwqFkT1EntnlI62S7j4+Mz+xiOb1GUdj7zVyb4B01TI VEdLoKs3y96tz15U/LMIUkp85ae67mrLNSXBSzLXus46uD9SY3xU6XxEvRYuu/tqqLct xmrA3t/1Zqzn8wOc4fdKvqqKaiyQVdzSGTUbKPbLfkyYXQC3A5dJgQuOYjeIW829gh6a e2Yvlo7Chj7Qdr50dyXoAN20a70PGlB7Vclxkn2SW61rzDqn5oyOR161CBrzmhjovKoq nALcxmC27Wf46Wx1OI3NzGVh+wUpy5phXvDugwUzBTS8ObsPTkS4l57czAzgwOnwMGFr CVuw== X-Gm-Message-State: AOJu0YxqmxIVokLJl/Tjatons2anOiYo7fam8iSrVwbjh2RzcVMgqrQU qDtGGL3m3fWdWEKLv8LpV3K4/Q== X-Google-Smtp-Source: AGHT+IFYlzgUTSMaBZ8vEEiRv4XxRnEyblyItbYXJ5pRKVGQeaxn6T2fQjE0N0TkwHLyCEnjMtygKw== X-Received: by 2002:a2e:9e17:0:b0:2c9:c566:ef73 with SMTP id e23-20020a2e9e17000000b002c9c566ef73mr812071ljk.15.1701293328854; Wed, 29 Nov 2023 13:28:48 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id b5-20020a05651c032500b002bcdbfe36b9sm2106196ljp.111.2023.11.29.13.28.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 13:28:47 -0800 (PST) From: Linus Walleij Date: Wed, 29 Nov 2023 22:28:42 +0100 Subject: [PATCH 06/10] ASoC: cs4271: Convert to GPIO descriptors MIME-Version: 1.0 Message-Id: <20231129-descriptors-sound-cirrus-v1-6-31aa74425ff8@linaro.org> References: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> In-Reply-To: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231129_132850_286373_1BC068B9 X-CRM114-Status: GOOD ( 26.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This converts the Cirrus CS4271 ASoC codec driver to use GPIO descriptors. It turns out that there are two in-kernel users of the platform data passing mechanism so these are switched over as well. One locally defined GPIO "gpio_disabled" is declared in the state struct but completely unused in the driver, so we delete it. Signed-off-by: Linus Walleij Reviewed-by: Alexander Sverdlin --- NB: the affected platform EP93xx is being converted to device tree I don't know if that is happening in this merge window, but the colission should be manageable. --- arch/arm/mach-ep93xx/edb93xx.c | 32 +++++++++++++++++++++++++---- arch/arm/mach-ep93xx/vision_ep9307.c | 12 ++++++++++- include/sound/cs4271.h | 1 - sound/soc/codecs/cs4271.c | 39 ++++++++++++------------------------ 4 files changed, 52 insertions(+), 32 deletions(-) diff --git a/arch/arm/mach-ep93xx/edb93xx.c b/arch/arm/mach-ep93xx/edb93xx.c index 4b90899a66e9..dbdb822a0100 100644 --- a/arch/arm/mach-ep93xx/edb93xx.c +++ b/arch/arm/mach-ep93xx/edb93xx.c @@ -88,7 +88,7 @@ static void __init edb93xx_register_i2c(void) * EDB93xx SPI peripheral handling *************************************************************************/ static struct cs4271_platform_data edb93xx_cs4271_data = { - .gpio_nreset = -EINVAL, /* filled in later */ + /* Intentionally left blank */ }; static struct spi_board_info edb93xx_spi_board_info[] __initdata = { @@ -114,14 +114,38 @@ static struct ep93xx_spi_info edb93xx_spi_info __initdata = { /* Intentionally left blank */ }; +static struct gpiod_lookup_table edb93xx_cs4272_edb9301_gpio_table = { + .dev_id = "spi0.0", /* CS0 on SPI0 */ + .table = { + GPIO_LOOKUP("A", 1, "reset", GPIO_ACTIVE_LOW), + { }, + }, +}; + +static struct gpiod_lookup_table edb93xx_cs4272_edb9302_gpio_table = { + .dev_id = "spi0.0", /* CS0 on SPI0 */ + .table = { + GPIO_LOOKUP("H", 2, "reset", GPIO_ACTIVE_LOW), + { }, + }, +}; + +static struct gpiod_lookup_table edb93xx_cs4272_edb9315_gpio_table = { + .dev_id = "spi0.0", /* CS0 on SPI0 */ + .table = { + GPIO_LOOKUP("B", 6, "reset", GPIO_ACTIVE_LOW), + { }, + }, +}; + static void __init edb93xx_register_spi(void) { if (machine_is_edb9301() || machine_is_edb9302()) - edb93xx_cs4271_data.gpio_nreset = EP93XX_GPIO_LINE_EGPIO1; + gpiod_add_lookup_table(&edb93xx_cs4272_edb9301_gpio_table); else if (machine_is_edb9302a() || machine_is_edb9307a()) - edb93xx_cs4271_data.gpio_nreset = EP93XX_GPIO_LINE_H(2); + gpiod_add_lookup_table(&edb93xx_cs4272_edb9302_gpio_table); else if (machine_is_edb9315a()) - edb93xx_cs4271_data.gpio_nreset = EP93XX_GPIO_LINE_EGPIO14; + gpiod_add_lookup_table(&edb93xx_cs4272_edb9315_gpio_table); gpiod_add_lookup_table(&edb93xx_spi_cs_gpio_table); ep93xx_register_spi(&edb93xx_spi_info, edb93xx_spi_board_info, diff --git a/arch/arm/mach-ep93xx/vision_ep9307.c b/arch/arm/mach-ep93xx/vision_ep9307.c index 30d9cf3791eb..9471938df64c 100644 --- a/arch/arm/mach-ep93xx/vision_ep9307.c +++ b/arch/arm/mach-ep93xx/vision_ep9307.c @@ -164,7 +164,7 @@ static struct i2c_board_info vision_i2c_info[] __initdata = { * SPI CS4271 Audio Codec *************************************************************************/ static struct cs4271_platform_data vision_cs4271_data = { - .gpio_nreset = EP93XX_GPIO_LINE_H(2), + /* Intentionally left blank */ }; /************************************************************************* @@ -241,6 +241,15 @@ static struct spi_board_info vision_spi_board_info[] __initdata = { }, }; +static struct gpiod_lookup_table vision_spi_cs4271_gpio_table = { + .dev_id = "spi0.0", /* cs4271 @ CS0 */ + .table = { + /* RESET */ + GPIO_LOOKUP_IDX("H", 2, NULL, 0, GPIO_ACTIVE_LOW), + { }, + }, +}; + static struct gpiod_lookup_table vision_spi_cs_gpio_table = { .dev_id = "spi0", .table = { @@ -292,6 +301,7 @@ static void __init vision_init_machine(void) ep93xx_register_i2c(vision_i2c_info, ARRAY_SIZE(vision_i2c_info)); + gpiod_add_lookup_table(&vision_spi_cs4271_gpio_table); gpiod_add_lookup_table(&vision_spi_mmc_gpio_table); gpiod_add_lookup_table(&vision_spi_cs_gpio_table); ep93xx_register_spi(&vision_spi_master, vision_spi_board_info, diff --git a/include/sound/cs4271.h b/include/sound/cs4271.h index 6ff23ab48894..5a55d135bdea 100644 --- a/include/sound/cs4271.h +++ b/include/sound/cs4271.h @@ -9,7 +9,6 @@ #define __CS4271_H struct cs4271_platform_data { - int gpio_nreset; /* GPIO driving Reset pin, if any */ bool amutec_eq_bmutec; /* flag to enable AMUTEC=BMUTEC */ /* diff --git a/sound/soc/codecs/cs4271.c b/sound/soc/codecs/cs4271.c index 9e6f8a048dd5..74a84832d958 100644 --- a/sound/soc/codecs/cs4271.c +++ b/sound/soc/codecs/cs4271.c @@ -13,9 +13,8 @@ #include #include #include -#include +#include #include -#include #include #include #include @@ -160,9 +159,7 @@ struct cs4271_private { /* Current sample rate for de-emphasis control */ int rate; /* GPIO driving Reset pin, if any */ - int gpio_nreset; - /* GPIO that disable serial bus, if any */ - int gpio_disable; + struct gpio_desc *reset; /* enable soft reset workaround */ bool enable_soft_reset; struct regulator_bulk_data supplies[ARRAY_SIZE(supply_names)]; @@ -487,12 +484,10 @@ static int cs4271_reset(struct snd_soc_component *component) { struct cs4271_private *cs4271 = snd_soc_component_get_drvdata(component); - if (gpio_is_valid(cs4271->gpio_nreset)) { - gpio_direction_output(cs4271->gpio_nreset, 0); - mdelay(1); - gpio_set_value(cs4271->gpio_nreset, 1); - mdelay(1); - } + gpiod_direction_output(cs4271->reset, 1); + mdelay(1); + gpiod_set_value(cs4271->reset, 0); + mdelay(1); return 0; } @@ -612,9 +607,8 @@ static void cs4271_component_remove(struct snd_soc_component *component) { struct cs4271_private *cs4271 = snd_soc_component_get_drvdata(component); - if (gpio_is_valid(cs4271->gpio_nreset)) - /* Set codec to the reset state */ - gpio_set_value(cs4271->gpio_nreset, 0); + /* Set codec to the reset state */ + gpiod_set_value(cs4271->reset, 1); regcache_mark_dirty(cs4271->regmap); regulator_bulk_disable(ARRAY_SIZE(cs4271->supplies), cs4271->supplies); @@ -639,7 +633,6 @@ static const struct snd_soc_component_driver soc_component_dev_cs4271 = { static int cs4271_common_probe(struct device *dev, struct cs4271_private **c) { - struct cs4271_platform_data *cs4271plat = dev->platform_data; struct cs4271_private *cs4271; int i, ret; @@ -647,17 +640,11 @@ static int cs4271_common_probe(struct device *dev, if (!cs4271) return -ENOMEM; - cs4271->gpio_nreset = of_get_named_gpio(dev->of_node, "reset-gpio", 0); - - if (cs4271plat) - cs4271->gpio_nreset = cs4271plat->gpio_nreset; - - if (gpio_is_valid(cs4271->gpio_nreset)) { - ret = devm_gpio_request(dev, cs4271->gpio_nreset, - "CS4271 Reset"); - if (ret < 0) - return ret; - } + cs4271->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_ASIS); + if (IS_ERR(cs4271->reset)) + return dev_err_probe(dev, PTR_ERR(cs4271->reset), + "error retrieveing RESET GPIO\n"); + gpiod_set_consumer_name(cs4271->reset, "CS4271 Reset"); for (i = 0; i < ARRAY_SIZE(supply_names); i++) cs4271->supplies[i].supply = supply_names[i]; From patchwork Wed Nov 29 21:28:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13473494 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 041FDC10DC1 for ; Wed, 29 Nov 2023 21:29:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Vg/eOFsop8Qix1iX6ED4lf0fLmp4LBpIJV6vvvjQyLM=; b=U/jSCPNPay8a4y 3QggengCg8Rh8viU8WS9SGil2+NOupgPD3LkZH3aHf/taa60nwKxlXBKP5YhDlcrlxSvThw+K7Fb3 6dU3l6Ej7zrbxTtfTiZovsZsVtWLkNQnUbSKgdotSM28aixtjCbUY7Cw/Kj+Nq0RC20lsGNoSiowS D+4DulfxlqZVJc/ZvMO6jQ2Xb05iYwuljJPTGa9UEjMyE7tyoNHy722w1Gatk0XkAK2DvbnPQi1qW FhjHUDfozTv17A7PtwDucINeonmdB6mHipZZClF/U1ciebcU1El8nZy+FjZLfUQrjOxmNoi2AhMk5 W5owwnOHTDGTcayN8mjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8S7Y-009Ke9-0w; Wed, 29 Nov 2023 21:29:24 +0000 Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8S72-009KQZ-0o for linux-arm-kernel@lists.infradead.org; Wed, 29 Nov 2023 21:28:53 +0000 Received: by mail-lj1-x233.google.com with SMTP id 38308e7fff4ca-2c9b77be7ceso3801241fa.2 for ; Wed, 29 Nov 2023 13:28:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701293330; x=1701898130; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Y5TZCHl5JrsKzVzdedTBOjjaGJPtqogPOahlRjnAK3I=; b=KWxUAq59tcNVousDM0Xhce1qpnG82NdPsm/p2CljwSkN1uLeZ1BFMj3QAAIT/9QFVo N9sKEKT22wxt7EUqCttkvCoDqx9J/62KuLX9XJ44jH4VyNUIk3EDTzhU8VCTN0X+51oM ooz/KAg/CIUdtyeq3/bT0gjzaWzYbMMF5XcQnWZPxVdH+49MpMVch7ibo4quOjpq9O8D EI3mKt1HIoedH8bcygdlqZ8DM+cFlPc3DFWVU3+nqyWjSTc1IwOCQ6auTx3js2CusfFw R5kLfDLkuyapqUoA6Uu2ODB7amLGMF7moowu4et3wqPf3oc+fACBVbIl6c7pwnj8DIFB AFRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701293330; x=1701898130; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y5TZCHl5JrsKzVzdedTBOjjaGJPtqogPOahlRjnAK3I=; b=ZR3HElxKW+ethksT2fOV+/k22JqA1A8Mq0L7E4AFxpTo4l6Ai/+UgjJz7RNasFuEVo 2C/ilUBdfFkv7g3Si3ssjvDjKgVpXsiyiErvjcIuNY7a9JsIxCy1CLiIa0X3qdpoqh2U pjDBLeOqGePK3SDKzSJkgwOJLO7x0ApA3+NXh6rxb7ziNTwX+5goihzEHyRMMYM6cYG+ G8ADWO1WGNTSuTPxS07ZOIenbpddkxZmx+Iq5QGijZKVuLxGacDtyiXcpGUwGlxohmGe U5yVU1PY1IuLTPD+mteXh0IWFG4HZfGrv6D9Y/4YEZukwAabjtZm1RgJ1pmDAEurkJZx AyTw== X-Gm-Message-State: AOJu0YyJGDqJxjQddZEXtBW3WnUJuv8JYfJajPHuBKtsrODORIIugg6L Vq9tSZFVtmoYyJnRWRpyfsnzygN3Fp7DMKxc0Hw= X-Google-Smtp-Source: AGHT+IG2iJRuG1eHTWV98yu7FrzVbLk4F45mt7qi99SvzYEoV5Esdv1xtlzmQWw30MGgDqcTjnHMVA== X-Received: by 2002:a2e:9b4d:0:b0:2c9:b4c6:a7ff with SMTP id o13-20020a2e9b4d000000b002c9b4c6a7ffmr3942168ljj.40.1701293329961; Wed, 29 Nov 2023 13:28:49 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id b5-20020a05651c032500b002bcdbfe36b9sm2106196ljp.111.2023.11.29.13.28.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 13:28:49 -0800 (PST) From: Linus Walleij Date: Wed, 29 Nov 2023 22:28:43 +0100 Subject: [PATCH 07/10] ASoC: cirrus: edb93xx: Drop legacy include MIME-Version: 1.0 Message-Id: <20231129-descriptors-sound-cirrus-v1-7-31aa74425ff8@linaro.org> References: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> In-Reply-To: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231129_132852_286224_A1266591 X-CRM114-Status: GOOD ( 11.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This driver includes the legacy GPIO API but does not use any symbols from it. Drop the include. Signed-off-by: Linus Walleij Reviewed-by: Alexander Sverdlin --- sound/soc/cirrus/edb93xx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/cirrus/edb93xx.c b/sound/soc/cirrus/edb93xx.c index 6b6817256331..8bb67d7d2b4b 100644 --- a/sound/soc/cirrus/edb93xx.c +++ b/sound/soc/cirrus/edb93xx.c @@ -11,7 +11,6 @@ */ #include -#include #include #include #include From patchwork Wed Nov 29 21:28:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13473492 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EAC8BC4167B for ; Wed, 29 Nov 2023 21:29:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bfvO0BbwBX/LZsA9vLeehUGUrj0j2fZNUu+ibB9dA5E=; b=wfa8xIpqaCDwMQ tbaU3t/9JYBs2aSlgM4yfUDh25hXW3GrA46Q3p11YOnAWv8d2FesxrasT9/fz2D5j+sop0ztvNgs1 JOdtyr3MMwkzeAz1V369K7XGUnJlF0nLNSOBpLkJlJnE3HkjyYnMPAMULU6pr197dBshvYOqCF0ei ZNQha2p+YDPc//S8w3ckeQPtk4QYujVztHIMvaSco3L7yVfKEN+XgviCp+lCbLug8dr2oDaM90Pup akTk9SsutBMCdn0UOO12Xw9TXRYe84Y9Ee0AYIMciZLpaijVzJGgjXQ0rksQUlmFnfARptdmvL4Dd qCt9bGXJvOPll5JN+8Gw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8S7Z-009KfC-1G; Wed, 29 Nov 2023 21:29:25 +0000 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8S72-009KQn-16 for linux-arm-kernel@lists.infradead.org; Wed, 29 Nov 2023 21:28:53 +0000 Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2c9c1e39defso3625371fa.1 for ; Wed, 29 Nov 2023 13:28:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701293331; x=1701898131; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Iu+jnDbRLvNSd29JPH0PlE0Rt4h1OZvlGiQIvlLElkY=; b=H6gQnlEIjd1rcY7J7e7p03WyGkkPzU5nekPuugYNXN+PAP8AKY/rLYSYr/9DPGC6/v dIt/A7MMbXN9VkKKO20ECCw8yXxh1f56l+lySTMXX9iry9FXET/kjL3U074pqX2rVYTi mnKGhTuN0UrPTjz/R55oJwo/aI45KcOTcdq8TnoClc3Jza/UwiyxWmT3KUoAvnipoxDB eFxqKvuEvZg9G1bfApk50JHplcWWy9wTu/yy2nNvE3hq9fZwoNnZrGCbww2sckUDPi3d K+arcsHQ6vaALq0JgPVzpV5+BCnx5Yzcc9fj6+KS8VXlx/Aiclmu4WxQok5rvac6dCIV Fm+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701293331; x=1701898131; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Iu+jnDbRLvNSd29JPH0PlE0Rt4h1OZvlGiQIvlLElkY=; b=UnRVJ9e6bEiSXo2cqF61k6YjgyHTvBz8ypCtnHmhW4T6GSRlcCGNRBpUHiJJaLY4/N p98tbC633aiMakQekNzLa7FEIvqaUNi6vfhxkds8R3qFzxeIayDNnQ3oqiKWuw+oeshB IIlraGxK9AuQkeypuL+7sX3WD+mgzc9DjZeLD6hL0qYllnxZ/DQID5ZyYRZ/Gz8mLg2/ V7PRADFmc4JsKWsVonekqFbOQKRtftxPprbLY0VC8DeYp9eb5sLS67DUVwn0imSYAJ3j QGByyOD86CH2M9YzhQiZ/e1+kKP26aVHjOJAnSNGtpixSKgVEZJzvrG0BCHA0KB6wyop o6NQ== X-Gm-Message-State: AOJu0YzHc+Mj6kiXwwpGYq1jOkwHMuBKwxnHNkVgGk07OCMNS7aXjK5u 4LnbpsbYyGQUGl1Zej7O8IsCIA== X-Google-Smtp-Source: AGHT+IF/28zICERnGlS5+OnSEEJkvgxEGnITMU5KpHeObXbDWy5BHjwpi8sDYXn7h5PUPVbGD2wWHA== X-Received: by 2002:a2e:87d9:0:b0:2c9:bfb1:aa75 with SMTP id v25-20020a2e87d9000000b002c9bfb1aa75mr2165119ljj.29.1701293331064; Wed, 29 Nov 2023 13:28:51 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id b5-20020a05651c032500b002bcdbfe36b9sm2106196ljp.111.2023.11.29.13.28.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 13:28:50 -0800 (PST) From: Linus Walleij Date: Wed, 29 Nov 2023 22:28:44 +0100 Subject: [PATCH 08/10] ASoC: cs42l42: Drop legacy include MIME-Version: 1.0 Message-Id: <20231129-descriptors-sound-cirrus-v1-8-31aa74425ff8@linaro.org> References: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> In-Reply-To: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231129_132852_375751_14C03BB1 X-CRM114-Status: GOOD ( 13.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This driver includes the legacy GPIO API but does not use any symbols from it. Drop the include. Signed-off-by: Linus Walleij --- sound/soc/codecs/cs42l42.c | 1 - sound/soc/codecs/cs42l42.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c index 94bcab812629..2d11c5125f73 100644 --- a/sound/soc/codecs/cs42l42.c +++ b/sound/soc/codecs/cs42l42.c @@ -15,7 +15,6 @@ #include #include #include -#include #include #include #include diff --git a/sound/soc/codecs/cs42l42.h b/sound/soc/codecs/cs42l42.h index 7785125b73ab..3d85ebc59489 100644 --- a/sound/soc/codecs/cs42l42.h +++ b/sound/soc/codecs/cs42l42.h @@ -14,7 +14,7 @@ #include #include -#include +#include #include #include #include From patchwork Wed Nov 29 21:28:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13473495 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00BD4C07E98 for ; Wed, 29 Nov 2023 21:29:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iT3ALYk8/gVRG95rr9QO/eE9gZXbRUzXi+aj7UGgkYA=; b=L8Z4cMuRmKNcrV wZPrZjIBiMVsyspqfDeIdMfZJt+1MOzP6pCSWAGFifGG0LJpE3jBRxg0bB63cjQWTnORI5C9kBnbF QJN3dWoBG3eMt7XWl2+uhbpEp9TdZwCTXl+yDWNOa/AHcWXBrU6vEiX3Qu9H6VpF0G+LzemOxrNjO yREwETC33+XH8Ol45DL51K1kRK9LDF3+xrpOt7cHy3YBlxikxNdjVH+0iJdHD/ypyEuVJEwLfo3IW gTmBbcJzopEZCvhogZidQbUqBJaaZiFP2lBrIZWCAhmNhDqiItbIA/0x7XKduhNSC9kxlNw9OcUNN t8r0Ii9KkneEdJr3oWzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8S7a-009Kga-1C; Wed, 29 Nov 2023 21:29:26 +0000 Received: from mail-lj1-x231.google.com ([2a00:1450:4864:20::231]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8S73-009KRN-1l for linux-arm-kernel@lists.infradead.org; Wed, 29 Nov 2023 21:28:54 +0000 Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2c9c39b7923so3754851fa.0 for ; Wed, 29 Nov 2023 13:28:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701293332; x=1701898132; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=GU757npNrUowgHMI8BxiU0vGtre+9oPF8HlBVHP1/Qc=; b=FFlnthyifFmIm61sUbc3FS81McQpm9cME0/FmQxJBql+yNIBlhwTp2pBLWZy3ZETto sH7QnMx2gaxnXIsnjqPlb7EoHEH9sFggDj+dCIvlgE+OXQok5FEVF033IC0aAgjj71Ju UgkJV1bYVA5Itc04MzPAeOZTtBD9d6CYQaagKCU2nCJMdYqERgVOPnXw7eFBnrZ5hzj5 ecXBsAeaehtU1OPcRjAR65Wy7h5JUB03k1glPxap/ASE2+LAKQILWxl88k2IUc9ARGJ5 6/8BHTL5CThtNG3fwO0oGb7lqAfd1j3KT8Tl0wsWhJwVmHL9wT63ygmS7ekATW5xPO2e F7xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701293332; x=1701898132; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GU757npNrUowgHMI8BxiU0vGtre+9oPF8HlBVHP1/Qc=; b=jCLIqD7/7Wn76EpVQbVH+1t1a16bTcCiqGOqdu7psEx5kxkBXE3Ke0+SZvgsc2AL3n 48ap1qSLz2QgaoyvHdgDbNmn19b1abQ4U8e+TRd0QPGWBsDkShKLb6pR6gh0InC/bz8i 5A1lmMBe1wqgJ3hlv/1s/AZ/WwUHuX1IQwRDar+xcn49qmWXJNJcNvhxUN4GxqoJP1U7 L7xBZd6pUDKlnF8A8y0OMth5BAPgYcn3BGmkSOGdAIufnNmvTR1CwnxYR9RSsH1E37US pDSiWMm18INbFqAalhD5UjT4Linz5JAmYut4jP/bWK0vnVsyq966LUY0ShMsl3MzaWw4 +3qA== X-Gm-Message-State: AOJu0YwBmI/n0bmZ40mWD5WLNKzu9IbFlLnvCGaGtx0eVmgDZi2Hl5b9 btpxWzLeD2p3RwCWietY6AKCSA== X-Google-Smtp-Source: AGHT+IEdyUI6Rv6RH6eVMr/I17nk4CK9OjZr5lyleg/5SJIpqBPmIm2LRa2NEJpv2cv9yqxd+ociMg== X-Received: by 2002:a2e:7203:0:b0:2c9:bf97:81d1 with SMTP id n3-20020a2e7203000000b002c9bf9781d1mr1989104ljc.27.1701293332163; Wed, 29 Nov 2023 13:28:52 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id b5-20020a05651c032500b002bcdbfe36b9sm2106196ljp.111.2023.11.29.13.28.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 13:28:51 -0800 (PST) From: Linus Walleij Date: Wed, 29 Nov 2023 22:28:45 +0100 Subject: [PATCH 09/10] ASoC: cs43130: Drop legacy includes MIME-Version: 1.0 Message-Id: <20231129-descriptors-sound-cirrus-v1-9-31aa74425ff8@linaro.org> References: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> In-Reply-To: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231129_132853_633697_12227B7F X-CRM114-Status: GOOD ( 11.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Signed-off-by: Linus Walleij --- sound/soc/codecs/cs43130.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/codecs/cs43130.c b/sound/soc/codecs/cs43130.c index 0b40fdfb1825..18933bf04684 100644 --- a/sound/soc/codecs/cs43130.c +++ b/sound/soc/codecs/cs43130.c @@ -11,7 +11,6 @@ #include #include #include -#include #include #include #include @@ -26,7 +25,6 @@ #include #include #include -#include #include #include #include From patchwork Wed Nov 29 21:28:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13473493 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72680C07CB1 for ; Wed, 29 Nov 2023 21:29:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References:Message-Id :MIME-Version:Subject:Date:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ll8vwsZoBwHECJAI2bz7Miz8A+iJU+vfDMlMKt41xGw=; b=VloCbo6Xu8qqzv bHRYm82ZPlMchAfrVbY87Bu8qGe/r6K3sgKMdep4cyoLaw/QI0D4DVhDVoi54pGH9XZQRHyqcMhRV 6pnDOhKREhgkYFoMqse9zCtSUg3CPxd2SE3Afo0NnQclPSOtxGYIS+LvIfO28/SRmGG6k8rnt3K9g icmtrI9qIlWqwH9DT0jx/u9i7BUMbAmdl2UxalJZkzmgAKqRURoflBBBq+COOz0vrVs6Y6u/mgn5J /DCSrjNy/xSukgzSzMTcSGY4Sb558DL5cE/CzRxVFYL//2s9SL0BE+9V/xmnSyx6KYolsnvcqi6pp mWrYG23UwV8ZhedQfapw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8S7b-009KhX-0T; Wed, 29 Nov 2023 21:29:27 +0000 Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8S75-009KSB-2C for linux-arm-kernel@lists.infradead.org; Wed, 29 Nov 2023 21:28:57 +0000 Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2c9c4df1287so3641641fa.2 for ; Wed, 29 Nov 2023 13:28:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701293333; x=1701898133; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=HSsSWusvyuFKnB0n59GG/ZJpbxUajSal4/kkXB4+BwY=; b=Am6/FGnGXUzNHsoI5IiVaA6Ry1hwTHsmAsvuSTPK+ANCoKT+qiBbfvXEUu63Aqntq2 GuNrXQUbMeyn2wdBWJiVijIhsSSk9B9IwWx3tapObEM6jgiK7xRV5YwpdOVVxF9KaeWO YW9jOZ1oeh8XSFqPhjbpnv+R9iUECf/gmvv219n3DrQzu8Aq+JgKcuRIPDeN9qtsDfxh z0dmqSMxc+og2VeU/dXEUQ6gNLlbkCWGGUv7bKCxIIllgfQy5+QunlIpAjyk29RsGnZk gqs+ayEnKBx0gQCBZGHEzPaUJmok1rKZElaqhyLNDKzJlsQtMMRLi86P1E4+UXfl8cuE cudQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701293333; x=1701898133; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HSsSWusvyuFKnB0n59GG/ZJpbxUajSal4/kkXB4+BwY=; b=ih7H5/9i8my3+6E+3e7/SsGmleOw7i3QopyYA50L3GolHV1w4cQ+BPRjC6ImCkw0cL bEBDYxoq1lfITZDWmKgPXjqwtqr94khD7xBPrxJm+Co1cWAYZXSJ5KM+fpAWcsQO4EaP PweFYWLvvG0YfxOQBHq/ZmULCc2zhrLDu8xUlUBn81FkBI68qLruql3aE/T9L3kaOnNo OmBfuu0Y7xzdY7ztnNf6g0W3qpsrIwra+B8n66cKezziQmfNTOIyBlPwQjGUkTkZpvw4 plzbWW9+4LiyLBgbyttKjI/KvOsuhDtDGhJuwH4VpdIfy3z08D+wpTSl10inn0QilXhL 26CA== X-Gm-Message-State: AOJu0YyCqJPOgRuZ1u8DYeaREEI5KUroSfjhkwUwDLlAzPIe0PrAbtCu 8VaMwU51j3y94O+KqkPg/6t7glniREeYTpe0MNE= X-Google-Smtp-Source: AGHT+IEkmWdPL4oWl2UHqoreap/8MLKCw3gg/vwTWvzAYgZdYOH7cYqyChHDv5dnd47KwZaWZPj/7A== X-Received: by 2002:a2e:9f06:0:b0:2c9:b9bc:b029 with SMTP id u6-20020a2e9f06000000b002c9b9bcb029mr3098669ljk.17.1701293333337; Wed, 29 Nov 2023 13:28:53 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id b5-20020a05651c032500b002bcdbfe36b9sm2106196ljp.111.2023.11.29.13.28.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 13:28:52 -0800 (PST) From: Linus Walleij Date: Wed, 29 Nov 2023 22:28:46 +0100 Subject: [PATCH 10/10] ASoC: cs4349: Drop legacy include MIME-Version: 1.0 Message-Id: <20231129-descriptors-sound-cirrus-v1-10-31aa74425ff8@linaro.org> References: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> In-Reply-To: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij X-Mailer: b4 0.12.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231129_132855_723526_249B7432 X-CRM114-Status: GOOD ( 11.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This driver includes the legacy GPIO API but does not use any symbols from it. Drop the include. Signed-off-by: Linus Walleij --- sound/soc/codecs/cs4349.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/cs4349.c b/sound/soc/codecs/cs4349.c index 9083228495d4..ca8f21aa4837 100644 --- a/sound/soc/codecs/cs4349.c +++ b/sound/soc/codecs/cs4349.c @@ -13,7 +13,6 @@ #include #include #include -#include #include #include #include