From patchwork Fri Dec 1 13:20:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13475790 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pzAPEedG" Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C081610D0 for ; Fri, 1 Dec 2023 05:20:34 -0800 (PST) Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-50bce78f145so2344277e87.0 for ; Fri, 01 Dec 2023 05:20:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701436833; x=1702041633; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6nBS0qEXkMT109HJpJHOUn0za4cdp5UY2TNq9aMO3Co=; b=pzAPEedGiuGQQr3XfWkoV7Udxo2F6wvwzhq8DAMPC/ik3tgMDKtT5efAfHmmAbaK8+ KE4HMQDJHVjDpFX+BJgc9TSHMr7pDnSLhhB0hVrR2jtof4ZkqlIPUaf3GnKqBro7Fglp YJwJkbacAmywo6Vb31QJQ+OstKjutixf666p1f5Mgstj4bJrds8Yroe/TEDOh7jxCEzI QEReUXX4aHPuCIMmu51HSSUqGQknnhDkVzzr3S/4GFkoT6UeqNqbH6Y1FCxnTqG3nzHI nupYXjwi2KGh5qjWlEcyMAR0WpMur82sqALvb5bmbEkFvy8QhBumY9j6z+mAnFQVV4tC 7D0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701436833; x=1702041633; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6nBS0qEXkMT109HJpJHOUn0za4cdp5UY2TNq9aMO3Co=; b=U2OyIjSy4JOpDIQlaRZFqso6CfqKBh/APW3etK2bzy+rF4bAWUIREFaBEuujyyFs1m mag56VEvutDJzJjviFFpd90HCod31mdNTjAUhb23GcD/RkrRk+faFGvp+IfbJxPrEso1 A9nkTgMjBYG4RSJVIRyWQhcvLJKL1p4dxV8jau4tjtbMXdXHVpOEQUvv1z+MB57a1da9 elBnXt29yt5wjsFuKQbvXpK+gLBVhzzFGeKITVyABrXpFi/9LNxjmtNpIoihWCRMxIBs 6+5CT+FQXfwFWuMVHQqSEhbpcEkhAK2qWF3CknRSX5ut6BYCRhJ4s9UttLt3ywxdOdhJ Dx2g== X-Gm-Message-State: AOJu0YzpEa628uTZUhBdlVZddYuNJ3z53flwp1GIiCKXC51rZ3Zy9IR+ nKOmWT1OAo+1N4GAvNc3QLVKrA== X-Google-Smtp-Source: AGHT+IEZBoALYT2AI/HvZGmMjYehDRhxvtPlZru/apoTdsAj69LXnriJmkSP9pMwuY+NY+SyLAK8qw== X-Received: by 2002:ac2:46db:0:b0:50b:d764:8e5f with SMTP id p27-20020ac246db000000b0050bd7648e5fmr446890lfo.113.1701436832963; Fri, 01 Dec 2023 05:20:32 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id u25-20020ac243d9000000b0050be054b4e8sm1081lfl.121.2023.12.01.05.20.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 05:20:32 -0800 (PST) From: Linus Walleij Date: Fri, 01 Dec 2023 14:20:30 +0100 Subject: [PATCH v2 01/10] ASoC: cs35l32: Drop legacy include Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231201-descriptors-sound-cirrus-v2-1-ee9f9d4655eb@linaro.org> References: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> In-Reply-To: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Charles Keepax X-Mailer: b4 0.12.4 This driver includes the legacy GPIO API but does not use any symbols from it. Drop the include. Acked-by: Charles Keepax Signed-off-by: Linus Walleij --- sound/soc/codecs/cs35l32.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/cs35l32.c b/sound/soc/codecs/cs35l32.c index 138040618438..d1350ffbf3bd 100644 --- a/sound/soc/codecs/cs35l32.c +++ b/sound/soc/codecs/cs35l32.c @@ -13,7 +13,6 @@ #include #include #include -#include #include #include #include From patchwork Fri Dec 1 13:20:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13475792 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IJM8OTO4" Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFBAD10E2 for ; Fri, 1 Dec 2023 05:20:35 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-50bc22c836bso3028909e87.0 for ; Fri, 01 Dec 2023 05:20:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701436834; x=1702041634; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=hvwEnfEWC7X3PkrakUYA7rH73mlgP4mcx3Rphz/0vOk=; b=IJM8OTO4byvSlW9lNhOVEvl9W9xORYkxq2l0w5vVuoCdklwN0aVGPuir0IyHOOeSd+ kmeaL/AOVJ53W4lxWXXPJ1vIICjnU5CD/uK+w/y1sq/fyZz+zeVXWUQ018BsOepKImCq jl9SODPPXbIOCmznMquvgM6qrbqW0JuQBi0tl42qXjegytNQ1PBXkvvmsC5PrWgp0Wgq 34HY8pyYWSB/LtAxvRjj+i527xd3XBV/+mxFIfpEiDNUzZ5/Ej7ito24j/vCvQvAi8Sq VwHO9EyXRzAAIP0q1hK/PBdK9Xtobss3wA3bvANI2heowUq44jMpaxr3zHyygW8CXQI8 Luxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701436834; x=1702041634; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hvwEnfEWC7X3PkrakUYA7rH73mlgP4mcx3Rphz/0vOk=; b=iE3QWHGuJkPq0FBI1RSU0XCLnG7nen6p9lHdwHonI+DHn0XPjSdGh2c/RijG8i6uXm Az28g3r7iluiLeNHSqLehROSqC4vgoKhjmoW95pWBDDnbSWZurgDAIJG2aEugC8Gj/rk AtWypq7FFmcJoFlh9moYtE77Iyvtx/dJrpklhY/Rdglx6CTSgEN3A1PmH/mjM0xkoB0Q E5IGI7Bh/JZGCAoLgAn5xIYGQ1XV30Mph7bJ6Q72x/0IcTw1+f2qyr7l5CDDNk7L1Zsm 6sLgdaH9D2dyl6EWty71muyFVQXxe3XeGeFe0KehyliSbEF2p8ZVQVjoWQEjqiUtkYdf PxEQ== X-Gm-Message-State: AOJu0YyqANazV4G+AmWTTfVKvnPW8Vmilz94WJVwLLeN8VPuUnzwb0AQ 54T/m2mg0AkRzpibuuzm3bHS7g== X-Google-Smtp-Source: AGHT+IHy8r+VGJLhcKYulz95n0Llz8QkGNwo3fVIlOQzYeCx6OX80VUxPFF/MbvUz9dVuCcnHSKjPw== X-Received: by 2002:a05:6512:36d2:b0:50b:d764:6ec8 with SMTP id e18-20020a05651236d200b0050bd7646ec8mr745977lfs.120.1701436834148; Fri, 01 Dec 2023 05:20:34 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id u25-20020ac243d9000000b0050be054b4e8sm1081lfl.121.2023.12.01.05.20.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 05:20:33 -0800 (PST) From: Linus Walleij Date: Fri, 01 Dec 2023 14:20:31 +0100 Subject: [PATCH v2 02/10] ASoC: cs35l33: Fix GPIO name and drop legacy include Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231201-descriptors-sound-cirrus-v2-2-ee9f9d4655eb@linaro.org> References: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> In-Reply-To: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Charles Keepax X-Mailer: b4 0.12.4 This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Further the driver is requesting "reset-gpios" rather than just "reset" from the GPIO framework. This is wrong because the gpiolib core will add "-gpios" before processing the request from e.g. device tree. Drop the suffix. The last problem means that the optional RESET GPIO has never been properly retrieved and used even if it existed, but nobody noticed. Fixes: 3333cb7187b9 ("ASoC: cs35l33: Initial commit of the cs35l33 CODEC driver.") Acked-by: Charles Keepax Signed-off-by: Linus Walleij --- sound/soc/codecs/cs35l33.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/cs35l33.c b/sound/soc/codecs/cs35l33.c index 4010a2d33a33..a19a2bafb37c 100644 --- a/sound/soc/codecs/cs35l33.c +++ b/sound/soc/codecs/cs35l33.c @@ -22,13 +22,11 @@ #include #include #include -#include #include #include #include #include #include -#include #include #include "cs35l33.h" @@ -1165,7 +1163,7 @@ static int cs35l33_i2c_probe(struct i2c_client *i2c_client) /* We could issue !RST or skip it based on AMP topology */ cs35l33->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev, - "reset-gpios", GPIOD_OUT_HIGH); + "reset", GPIOD_OUT_HIGH); if (IS_ERR(cs35l33->reset_gpio)) { dev_err(&i2c_client->dev, "%s ERROR: Can't get reset GPIO\n", __func__); From patchwork Fri Dec 1 13:20:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13475793 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hv8Fh6R1" Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 290CB10F8 for ; Fri, 1 Dec 2023 05:20:37 -0800 (PST) Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-50bc4fe8158so3001575e87.0 for ; Fri, 01 Dec 2023 05:20:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701436835; x=1702041635; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=lDKFgSOaPuVFur80bPhP3dFYnn3zUMFtVllkw5He9o4=; b=hv8Fh6R1nweNNqSDTh70Avl3Zen3zf1n76HYzFAtUKl3mB3vdTQq1ssxy8PWsHYy6t sK9jvEPg4k48jK45Qr3dc0X8HJtqGjLJNRFTY2v02MQRLuB8pnnU2Eu9zbD5PMESalL2 nZKMMXMX8nPwE3G+cHcgEnqk6HGJrTogVj8kQPzyqPC2vEJe7eE6XDtZzM/KIyoddar9 cSNeWmztSJr9sx3d3CRUCYGziLHZJu8suwBFob96gMnlOmKc47PRrIyt0LjNbiYa5epA Q/4radCB/KbKAnMlx7wcDZ2XazYt146Blia+Fz5G+3QI4QcGI1thTA5m6C3LfJex3h5f e2jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701436835; x=1702041635; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lDKFgSOaPuVFur80bPhP3dFYnn3zUMFtVllkw5He9o4=; b=vWBU5ifCw9URPQw1FkOSD+IYotGvy977jjJmJFKzZOeugsofcDmf8Pwn2KUFQZ/79V JQGP9MtidnZxi48Dy7BwJGOPr4SDjcA21EDf1RJ8jZ/ES+isg0Y/AE3B54lRuyCI13yh ace/wTeIxzmJpBHmxHSZxohBHCT2iG0fbT0XB+Dj+CDJ93Qw9KQ3HYCKJYpJOpqMW4zT fAAEwWag/a68xKyUbzmFT0ib6JLZhgyD/z8vN+ahLtgrqpYXM33TcAD8ZOGRgZk+UpER +scU4IXCwc6mlJRdj2X8NzLZtCs29sft1IrxfqnT5pl6EKw5Wl2k7XpE4UaLpvLOYzVC 7Qow== X-Gm-Message-State: AOJu0YyZCVU3YR4axMrs/VNTV68CRlr2dQeJrpsxBOgRTNDMJv/CvT8N 5y5bPMEnJw1+8/T8BJNQ9AnHyw== X-Google-Smtp-Source: AGHT+IHPhwhCcZemWJXPkwH3F0g8I2ogdr+dlRUEBR2WBwxAYjUakxV0jDfSRYYeCIC7/cyqXFUOUQ== X-Received: by 2002:a05:6512:615:b0:50b:d764:9683 with SMTP id b21-20020a056512061500b0050bd7649683mr765669lfe.103.1701436835426; Fri, 01 Dec 2023 05:20:35 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id u25-20020ac243d9000000b0050be054b4e8sm1081lfl.121.2023.12.01.05.20.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 05:20:34 -0800 (PST) From: Linus Walleij Date: Fri, 01 Dec 2023 14:20:32 +0100 Subject: [PATCH v2 03/10] ASoC: cs35l34: Fix GPIO name and drop legacy include Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231201-descriptors-sound-cirrus-v2-3-ee9f9d4655eb@linaro.org> References: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> In-Reply-To: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Charles Keepax X-Mailer: b4 0.12.4 This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Further the driver is requesting "reset-gpios" rather than just "reset" from the GPIO framework. This is wrong because the gpiolib core will add "-gpios" before processing the request from e.g. device tree. Drop the suffix. The last problem means that the optional RESET GPIO has never been properly retrieved and used even if it existed, but nobody noticed. Fixes: c1124c09e103 ("ASoC: cs35l34: Initial commit of the cs35l34 CODEC driver.") Acked-by: Charles Keepax Signed-off-by: Linus Walleij --- sound/soc/codecs/cs35l34.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/cs35l34.c b/sound/soc/codecs/cs35l34.c index e5871736fa29..cca59de66b73 100644 --- a/sound/soc/codecs/cs35l34.c +++ b/sound/soc/codecs/cs35l34.c @@ -20,14 +20,12 @@ #include #include #include -#include #include #include #include #include #include #include -#include #include #include #include @@ -1061,7 +1059,7 @@ static int cs35l34_i2c_probe(struct i2c_client *i2c_client) dev_err(&i2c_client->dev, "Failed to request IRQ: %d\n", ret); cs35l34->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev, - "reset-gpios", GPIOD_OUT_LOW); + "reset", GPIOD_OUT_LOW); if (IS_ERR(cs35l34->reset_gpio)) { ret = PTR_ERR(cs35l34->reset_gpio); goto err_regulator; From patchwork Fri Dec 1 13:20:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13475794 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SZ74a/xk" Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F66213E for ; Fri, 1 Dec 2023 05:20:38 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-50aabfa1b75so3085912e87.3 for ; Fri, 01 Dec 2023 05:20:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701436836; x=1702041636; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QXDjDPaMbvQx1bg37W4jgjJHDDiGcy2tlOvY5Yp+dBc=; b=SZ74a/xkRlP3R4CZMf9s9Asc07otU2b3B0jal1K4fcn/gLX4CWSkpgeUlwYH86gr6W lm2dkZmwj2ZpEIl9o2NPbo7dSm8bXSvV+gefu+5ja3iFZlSYS8NhN4I7RcDDWk7UnPVC 5tKlQNSy3umNva95WxnngQV8JeoaVbqdd0ztnO/V7E6IsOhqnAZ4+1G4nVhBFGsN3sPf DSxM4Oly4bR2xTdspywToBUzE6CYgXNA7XVF1dE+OtjGU7/K+28WkK1VrTW0IQZe8RZQ hHxb8HapZIzy3WMnPF3vle6CSn5BljQmVHMXRRD59f8sS59N/Mf10PG4369RBA8Huly0 U/tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701436836; x=1702041636; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QXDjDPaMbvQx1bg37W4jgjJHDDiGcy2tlOvY5Yp+dBc=; b=kw+X7YuXAObTy6WjHPP4IdoV9mrpm4w6FyCROkzZ3qJ+/EPcyfXvVRe34MOvcjvbHr O6FooHjT+WUkZ13vA/G5vXc0rRPaAeOTyotS4vlfOrY1esMn3l4crZ6uSITcXQLtRhYm ND3q9uc7C3zbt6ovB5aGBqv6up5SSsVGIByLiArV1tM0cEZ/jAk/+lfyqptBWU9g7+9o Y8G2nahvxMOILr/dkqZwCiJV2pdmthS76lFMzWGh+cK1jM8Srlw7sqJ/3bKJtAUKT0J8 4G4XavCrstsi8gcYOPklZSxq2grqdQILRPWwdwyZi17dnliwBZ/tPPUMA/ii5xfkJdQI r/aQ== X-Gm-Message-State: AOJu0YxwKEYb4lUkyLIZhkI8YviyJWlEJ0701dv2/ILEp91VQGFbUdSE UdUW5g7+G7dEtU0SeEMOpEAd2w== X-Google-Smtp-Source: AGHT+IGIItJJwYORlQRXrQG7gfQ5ooIDSNWEgNp2rLh/rkXJ7icDeuvVSqIoEojB48neS29HuUSSVw== X-Received: by 2002:a05:6512:239f:b0:50b:c2f4:ad44 with SMTP id c31-20020a056512239f00b0050bc2f4ad44mr1028231lfv.29.1701436836629; Fri, 01 Dec 2023 05:20:36 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id u25-20020ac243d9000000b0050be054b4e8sm1081lfl.121.2023.12.01.05.20.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 05:20:36 -0800 (PST) From: Linus Walleij Date: Fri, 01 Dec 2023 14:20:33 +0100 Subject: [PATCH v2 04/10] ASoC: cs35l35: Drop legacy includes Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231201-descriptors-sound-cirrus-v2-4-ee9f9d4655eb@linaro.org> References: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> In-Reply-To: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Charles Keepax X-Mailer: b4 0.12.4 This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Acked-by: Charles Keepax Signed-off-by: Linus Walleij --- sound/soc/codecs/cs35l35.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c index 63a538f747d3..ddb7d63213a3 100644 --- a/sound/soc/codecs/cs35l35.c +++ b/sound/soc/codecs/cs35l35.c @@ -18,14 +18,12 @@ #include #include #include -#include #include #include #include #include #include #include -#include #include #include #include From patchwork Fri Dec 1 13:20:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13475795 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ktcAmG4j" Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E3DF10D0 for ; Fri, 1 Dec 2023 05:20:39 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-50bce42295eso2365772e87.2 for ; Fri, 01 Dec 2023 05:20:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701436837; x=1702041637; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tmhoeNK2XrxfkfGdL3xKNy/HfoA09+0EnEv8OOqmFiw=; b=ktcAmG4jsASqae2vNTaUpPgTKswO9HgBlmKtgHEwqVZERXrUccemi+TRCwPZJes1YV x2tZMRPaDCmIcHRZUmkQ/6WkmLtRV5D41R0EKM+YQe77Nz+DeNq7LkHtiXuCnYzRodD5 f2nOyMtBrapkU5a8ExzQrMTZ10VKPCsAu3Fy8oSTZvkrYS+MF1FfGPqB0cCEc2WtYrVE U860AdnqfqdytxvzPaKvWYcwP5DJFvRi+uxV+7uU2xNBqvfbJw1kx1XDUYpMm9u8dOQ7 Vg1qlJdlUfasRysrw9CCq5Z3CLiVH5bSc99wUBtZe4GMN9dm/UjS+gB00Wm9cP6H1j0/ dVkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701436837; x=1702041637; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tmhoeNK2XrxfkfGdL3xKNy/HfoA09+0EnEv8OOqmFiw=; b=EdNAJMkhFHhwuqJkQTCl4adB02KzF+L6mA77Ftd9TTN7l9wRqXjsuIYFv5zXukbwUr 83MeiEUEefbxXu8HDsEMubQvtAfhNLC1GJKCqAjDdsS+O+gzRLvgRESOH0WzAbW8Jg/I SEqIZdNdYHD6apk2ElMLIvQR5Aj3fIdOOtMnHhk4KMqgW+yfaXCohduPVnBdBlDg9htT SfD6UTMrDAVWlLvem5UTUE4bY4hDmApGmc68zCZHWkKYxNAcT1P2vHYtsd8Nlksyqs2A EvSPbbtohiWJzagYhXmxSamdeIuxYLSOcV7ScVT+gwEPz7HwFvoCxuBkO+Zx5xceMQb9 b6og== X-Gm-Message-State: AOJu0YxzMp+xhjGsBOdw0dM1bRKDkeE2KiIVNjYKFrvHoh2j/mUX8myg 9U9H/Uzzp+AQ+ZPHNFwlMUSKkw== X-Google-Smtp-Source: AGHT+IFSgPDic86kEaX7pw26R4wwmabuIQgTcHwgTfrqNNG5jSVMDDG459yzdd7DusaO3vXR73bQLQ== X-Received: by 2002:a19:7906:0:b0:50b:d764:8819 with SMTP id u6-20020a197906000000b0050bd7648819mr784054lfc.101.1701436837631; Fri, 01 Dec 2023 05:20:37 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id u25-20020ac243d9000000b0050be054b4e8sm1081lfl.121.2023.12.01.05.20.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 05:20:37 -0800 (PST) From: Linus Walleij Date: Fri, 01 Dec 2023 14:20:34 +0100 Subject: [PATCH v2 05/10] ASoC: cs35l36: Drop legacy includes Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231201-descriptors-sound-cirrus-v2-5-ee9f9d4655eb@linaro.org> References: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> In-Reply-To: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Charles Keepax X-Mailer: b4 0.12.4 This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Acked-by: Charles Keepax Signed-off-by: Linus Walleij --- ChangeLog v1->v2: - Add include, apparently the driver relied on this being implicitly included from --- sound/soc/codecs/cs35l36.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/codecs/cs35l36.c b/sound/soc/codecs/cs35l36.c index f2fde6e652b9..f5bd32e434a0 100644 --- a/sound/soc/codecs/cs35l36.c +++ b/sound/soc/codecs/cs35l36.c @@ -17,15 +17,14 @@ #include #include #include +#include #include -#include #include #include #include #include #include #include -#include #include #include #include From patchwork Fri Dec 1 13:20:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13475796 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="FlpoGBR4" Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 665B810E2 for ; Fri, 1 Dec 2023 05:20:40 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-50bd4fcbde1so1726560e87.1 for ; Fri, 01 Dec 2023 05:20:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701436838; x=1702041638; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=5WhXxuLZNgkWwHrPw1QLUfir5/y69DK46Q+annr/jjk=; b=FlpoGBR4JQukQDGLtdeEC73M/OQYgMZ0GL7IAWUHn0Pw0oyDbVnrcR4nPHd9QgtXmG 7R+Of0EWpLx4YhvhRbcCRtK5GkOOHQBZePD6bsH2K25mL/0IU2i1wbKpyadkD4E8MEH1 GxydKR7b47zdsr94Lo0HHHjjWYMqZm9h3NQrk/FlLLWsPeXC1HEuMWhnxKJK0aEfj103 DeAS66mEyPm1A+n3SyNgz+SQEiOIIAIYvJNHfVYbAufVDNERQ6dYsy6Red4qy96a2xRL mYc8EsWE2affW0wRL4qTKIOOms9VcgKhuS1fSk8VFautbEoxC/RaUAaSiK/whLEkXEW0 xxUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701436838; x=1702041638; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5WhXxuLZNgkWwHrPw1QLUfir5/y69DK46Q+annr/jjk=; b=YaENFrY8MOl7LtpUqvZig+W69nXdACtAP2CcgZeneKfWE3v8CsZ+8daGxBUoOq/OiL ME5bVrpH12NXojaIT4HE4tv7WyturL0/4SYXNzPWZLBbYRr07xyfi6Lxg1lo2y6JoDCq 8AqEb9MFuBu6HFwthCWerBjmOKcJmCViuqU5vHcKo47CFUwOhIA6x70XTfAl5d3uk3kr BD4b7raQinQKLLvrXYj5EChtlCWaqOYrxs5dR4nFSA01AiBZxJsiw/ogNjRgBPLtPyQt evCtqVmmWadYnI9ESEf9T92yhFi1+huFoOlaH5hELk/R3EtHNlqXns+TXfiOouWxyG2x 0iUQ== X-Gm-Message-State: AOJu0Yx9H2+PxbXevX8ntEHhMzbWmDIXmdh/cx0qnL00kAhivdrhCJ20 6dAO5hpacZ69u9o171VvU5SJ5Q== X-Google-Smtp-Source: AGHT+IHsLRMMFCTZlDmh+/PBoPEELtq/DFrM73vYAwtEFpAp1w/UNgpsq/nwT/BE4N79+osG9ZAmHQ== X-Received: by 2002:ac2:5586:0:b0:50b:c9e7:2949 with SMTP id v6-20020ac25586000000b0050bc9e72949mr792476lfg.40.1701436838667; Fri, 01 Dec 2023 05:20:38 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id u25-20020ac243d9000000b0050be054b4e8sm1081lfl.121.2023.12.01.05.20.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 05:20:38 -0800 (PST) From: Linus Walleij Date: Fri, 01 Dec 2023 14:20:35 +0100 Subject: [PATCH v2 06/10] ASoC: cs4271: Convert to GPIO descriptors Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231201-descriptors-sound-cirrus-v2-6-ee9f9d4655eb@linaro.org> References: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> In-Reply-To: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Charles Keepax X-Mailer: b4 0.12.4 This converts the Cirrus CS4271 ASoC codec driver to use GPIO descriptors. It turns out that there are two in-kernel users of the platform data passing mechanism so these are switched over as well. One locally defined GPIO "gpio_disabled" is declared in the state struct but completely unused in the driver, so we delete it. Reviewed-by: Alexander Sverdlin Acked-by: Charles Keepax Signed-off-by: Linus Walleij --- NB: the affected platform EP93xx is being converted to device tree I don't know if that is happening in this merge window, but the colission should be manageable. --- arch/arm/mach-ep93xx/edb93xx.c | 32 +++++++++++++++++++++++++---- arch/arm/mach-ep93xx/vision_ep9307.c | 12 ++++++++++- include/sound/cs4271.h | 1 - sound/soc/codecs/cs4271.c | 39 ++++++++++++------------------------ 4 files changed, 52 insertions(+), 32 deletions(-) diff --git a/arch/arm/mach-ep93xx/edb93xx.c b/arch/arm/mach-ep93xx/edb93xx.c index 4b90899a66e9..dbdb822a0100 100644 --- a/arch/arm/mach-ep93xx/edb93xx.c +++ b/arch/arm/mach-ep93xx/edb93xx.c @@ -88,7 +88,7 @@ static void __init edb93xx_register_i2c(void) * EDB93xx SPI peripheral handling *************************************************************************/ static struct cs4271_platform_data edb93xx_cs4271_data = { - .gpio_nreset = -EINVAL, /* filled in later */ + /* Intentionally left blank */ }; static struct spi_board_info edb93xx_spi_board_info[] __initdata = { @@ -114,14 +114,38 @@ static struct ep93xx_spi_info edb93xx_spi_info __initdata = { /* Intentionally left blank */ }; +static struct gpiod_lookup_table edb93xx_cs4272_edb9301_gpio_table = { + .dev_id = "spi0.0", /* CS0 on SPI0 */ + .table = { + GPIO_LOOKUP("A", 1, "reset", GPIO_ACTIVE_LOW), + { }, + }, +}; + +static struct gpiod_lookup_table edb93xx_cs4272_edb9302_gpio_table = { + .dev_id = "spi0.0", /* CS0 on SPI0 */ + .table = { + GPIO_LOOKUP("H", 2, "reset", GPIO_ACTIVE_LOW), + { }, + }, +}; + +static struct gpiod_lookup_table edb93xx_cs4272_edb9315_gpio_table = { + .dev_id = "spi0.0", /* CS0 on SPI0 */ + .table = { + GPIO_LOOKUP("B", 6, "reset", GPIO_ACTIVE_LOW), + { }, + }, +}; + static void __init edb93xx_register_spi(void) { if (machine_is_edb9301() || machine_is_edb9302()) - edb93xx_cs4271_data.gpio_nreset = EP93XX_GPIO_LINE_EGPIO1; + gpiod_add_lookup_table(&edb93xx_cs4272_edb9301_gpio_table); else if (machine_is_edb9302a() || machine_is_edb9307a()) - edb93xx_cs4271_data.gpio_nreset = EP93XX_GPIO_LINE_H(2); + gpiod_add_lookup_table(&edb93xx_cs4272_edb9302_gpio_table); else if (machine_is_edb9315a()) - edb93xx_cs4271_data.gpio_nreset = EP93XX_GPIO_LINE_EGPIO14; + gpiod_add_lookup_table(&edb93xx_cs4272_edb9315_gpio_table); gpiod_add_lookup_table(&edb93xx_spi_cs_gpio_table); ep93xx_register_spi(&edb93xx_spi_info, edb93xx_spi_board_info, diff --git a/arch/arm/mach-ep93xx/vision_ep9307.c b/arch/arm/mach-ep93xx/vision_ep9307.c index 30d9cf3791eb..9471938df64c 100644 --- a/arch/arm/mach-ep93xx/vision_ep9307.c +++ b/arch/arm/mach-ep93xx/vision_ep9307.c @@ -164,7 +164,7 @@ static struct i2c_board_info vision_i2c_info[] __initdata = { * SPI CS4271 Audio Codec *************************************************************************/ static struct cs4271_platform_data vision_cs4271_data = { - .gpio_nreset = EP93XX_GPIO_LINE_H(2), + /* Intentionally left blank */ }; /************************************************************************* @@ -241,6 +241,15 @@ static struct spi_board_info vision_spi_board_info[] __initdata = { }, }; +static struct gpiod_lookup_table vision_spi_cs4271_gpio_table = { + .dev_id = "spi0.0", /* cs4271 @ CS0 */ + .table = { + /* RESET */ + GPIO_LOOKUP_IDX("H", 2, NULL, 0, GPIO_ACTIVE_LOW), + { }, + }, +}; + static struct gpiod_lookup_table vision_spi_cs_gpio_table = { .dev_id = "spi0", .table = { @@ -292,6 +301,7 @@ static void __init vision_init_machine(void) ep93xx_register_i2c(vision_i2c_info, ARRAY_SIZE(vision_i2c_info)); + gpiod_add_lookup_table(&vision_spi_cs4271_gpio_table); gpiod_add_lookup_table(&vision_spi_mmc_gpio_table); gpiod_add_lookup_table(&vision_spi_cs_gpio_table); ep93xx_register_spi(&vision_spi_master, vision_spi_board_info, diff --git a/include/sound/cs4271.h b/include/sound/cs4271.h index 6ff23ab48894..5a55d135bdea 100644 --- a/include/sound/cs4271.h +++ b/include/sound/cs4271.h @@ -9,7 +9,6 @@ #define __CS4271_H struct cs4271_platform_data { - int gpio_nreset; /* GPIO driving Reset pin, if any */ bool amutec_eq_bmutec; /* flag to enable AMUTEC=BMUTEC */ /* diff --git a/sound/soc/codecs/cs4271.c b/sound/soc/codecs/cs4271.c index 9e6f8a048dd5..74a84832d958 100644 --- a/sound/soc/codecs/cs4271.c +++ b/sound/soc/codecs/cs4271.c @@ -13,9 +13,8 @@ #include #include #include -#include +#include #include -#include #include #include #include @@ -160,9 +159,7 @@ struct cs4271_private { /* Current sample rate for de-emphasis control */ int rate; /* GPIO driving Reset pin, if any */ - int gpio_nreset; - /* GPIO that disable serial bus, if any */ - int gpio_disable; + struct gpio_desc *reset; /* enable soft reset workaround */ bool enable_soft_reset; struct regulator_bulk_data supplies[ARRAY_SIZE(supply_names)]; @@ -487,12 +484,10 @@ static int cs4271_reset(struct snd_soc_component *component) { struct cs4271_private *cs4271 = snd_soc_component_get_drvdata(component); - if (gpio_is_valid(cs4271->gpio_nreset)) { - gpio_direction_output(cs4271->gpio_nreset, 0); - mdelay(1); - gpio_set_value(cs4271->gpio_nreset, 1); - mdelay(1); - } + gpiod_direction_output(cs4271->reset, 1); + mdelay(1); + gpiod_set_value(cs4271->reset, 0); + mdelay(1); return 0; } @@ -612,9 +607,8 @@ static void cs4271_component_remove(struct snd_soc_component *component) { struct cs4271_private *cs4271 = snd_soc_component_get_drvdata(component); - if (gpio_is_valid(cs4271->gpio_nreset)) - /* Set codec to the reset state */ - gpio_set_value(cs4271->gpio_nreset, 0); + /* Set codec to the reset state */ + gpiod_set_value(cs4271->reset, 1); regcache_mark_dirty(cs4271->regmap); regulator_bulk_disable(ARRAY_SIZE(cs4271->supplies), cs4271->supplies); @@ -639,7 +633,6 @@ static const struct snd_soc_component_driver soc_component_dev_cs4271 = { static int cs4271_common_probe(struct device *dev, struct cs4271_private **c) { - struct cs4271_platform_data *cs4271plat = dev->platform_data; struct cs4271_private *cs4271; int i, ret; @@ -647,17 +640,11 @@ static int cs4271_common_probe(struct device *dev, if (!cs4271) return -ENOMEM; - cs4271->gpio_nreset = of_get_named_gpio(dev->of_node, "reset-gpio", 0); - - if (cs4271plat) - cs4271->gpio_nreset = cs4271plat->gpio_nreset; - - if (gpio_is_valid(cs4271->gpio_nreset)) { - ret = devm_gpio_request(dev, cs4271->gpio_nreset, - "CS4271 Reset"); - if (ret < 0) - return ret; - } + cs4271->reset = devm_gpiod_get_optional(dev, "reset", GPIOD_ASIS); + if (IS_ERR(cs4271->reset)) + return dev_err_probe(dev, PTR_ERR(cs4271->reset), + "error retrieveing RESET GPIO\n"); + gpiod_set_consumer_name(cs4271->reset, "CS4271 Reset"); for (i = 0; i < ARRAY_SIZE(supply_names); i++) cs4271->supplies[i].supply = supply_names[i]; From patchwork Fri Dec 1 13:20:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13475797 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RMeMo7Qn" Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BC0213E for ; Fri, 1 Dec 2023 05:20:41 -0800 (PST) Received: by mail-lf1-x12f.google.com with SMTP id 2adb3069b0e04-50bc743c7f7so2879672e87.3 for ; Fri, 01 Dec 2023 05:20:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701436839; x=1702041639; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=h1YwCm+XH2HIMFvp7NT2GALpzlzAqPDpRrGRX4ZS3D8=; b=RMeMo7Qn1JFYgqhi7H9+WvV0UAhIjPDOcGq5ZJTBe5i78N4eSBTu3vSH7D4ORyN38k gbnH4TYpedILJr4/jQ6Zm9He6d/UUJjgx1jhu6X1Sd6ezvLVZj4WUWHLGdlzdCCLwzh5 h3l9XyylWFzxnsan5yULpfXh5Mv7ox9GPWGVy/tSKV7XgPSsa+xqLbjooRIjjqlnZytY KpG5YV7I+U1SiRLM69b10O+Tg9Djs6zSDZDnWGnqd5jp33IJ/PZ7a41cDu79CSR9WwG3 pPiNKD/2a8Rgz2A4+Sj4lTxrrm6xUzTvaPxaVJOQDLZS31uZzKJKqdzL4eeElwfOBzE5 LMQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701436839; x=1702041639; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h1YwCm+XH2HIMFvp7NT2GALpzlzAqPDpRrGRX4ZS3D8=; b=S0yo6166Yaa4XXa1I4DiceiOUZMI4AXqv4skiRrs3wbH8Drrz+6Rx14TWfztpyI/RP rLUCU0ODAEoSV+NowZ5R4hUQ1SJT/1DBuHo82obj5pF563I7C2lDFg21GXUHAWQvFz6E eUuxp628a2o4tVqKLMkkDprCe4h6LQ9BZTn8uY785QgDBHCYLiRRHYc1KwkSqyFrrjmz VZ+AC8MaaL8elZE/Y/WcREqCH/hGpZ6nSpM7s0N3hXk48XRzPW2to0zIt7sCI4VLbyGH oPUnAotZMEu2TZtjFanbZfNZNXQETX5vWzwLj5QxVGg7VuqnF9m/A9AS7XFfch0Imcnw SITQ== X-Gm-Message-State: AOJu0YxlY+BsOnxOoDar1WpKieihqg28e/DMipuUSA/O8o9ms4AHnh6y NKXK7GFFYYNUO6tlnX6QvQsbug== X-Google-Smtp-Source: AGHT+IHz0vX9CqCj+qD3UQTWnTMff91+vQiG2xdvgEoaXCXAVJNAM8ut2DNGIFy42sB0tfaYdArJbQ== X-Received: by 2002:a05:6512:1597:b0:50b:c9c1:19ba with SMTP id bp23-20020a056512159700b0050bc9c119bamr868333lfb.63.1701436839678; Fri, 01 Dec 2023 05:20:39 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id u25-20020ac243d9000000b0050be054b4e8sm1081lfl.121.2023.12.01.05.20.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 05:20:39 -0800 (PST) From: Linus Walleij Date: Fri, 01 Dec 2023 14:20:36 +0100 Subject: [PATCH v2 07/10] ASoC: cirrus: edb93xx: Drop legacy include Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231201-descriptors-sound-cirrus-v2-7-ee9f9d4655eb@linaro.org> References: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> In-Reply-To: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Charles Keepax X-Mailer: b4 0.12.4 This driver includes the legacy GPIO API but does not use any symbols from it. Drop the include. Reviewed-by: Alexander Sverdlin Link: https://patchwork.kernel.org/project/alsa-devel/patch/20231122-ep93xx-v5-38-d59a76d5df29@maquefel.me/ Acked-by: Charles Keepax Signed-off-by: Linus Walleij --- sound/soc/cirrus/edb93xx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/cirrus/edb93xx.c b/sound/soc/cirrus/edb93xx.c index 6b6817256331..8bb67d7d2b4b 100644 --- a/sound/soc/cirrus/edb93xx.c +++ b/sound/soc/cirrus/edb93xx.c @@ -11,7 +11,6 @@ */ #include -#include #include #include #include From patchwork Fri Dec 1 13:20:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13475800 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zvUB69li" Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A453010D0 for ; Fri, 1 Dec 2023 05:20:42 -0800 (PST) Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-50bd928b13cso974344e87.2 for ; Fri, 01 Dec 2023 05:20:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701436841; x=1702041641; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=kJ+3Y6BEIrIf7qh9svq9OVzbI1CjxUGno02MCFoO1oo=; b=zvUB69liLPXcAbWUti3AncjW/OlmM6nz9VIj0rPYAEptUHZo18wusjPH4VnO9h4T2o 8k9CRw0S8sNsqxyYNejqBXxnK8mlVvZj0ECW7JW9D3J2qyL7cWElwuMOLU9WqFMu0ggU 6FqNC0m8r68JgwDE6e3/Bc/H8s4F4OF5HMRA8cF+GXja6N2VQhZxpfFf0ZFhc+eZiz34 9odauVRWQeeKytR4ixNv/Knw7W7273AZWckshxWib/lKQy9hdcbNpsjCYnlHvHOlzb+v InXy0lCqQvGtpzZ1xIlfhU2VTIG2q3poOcukL/SPG7p0UIqq5rA8lObhqlRt2yXod+5w Ca/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701436841; x=1702041641; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kJ+3Y6BEIrIf7qh9svq9OVzbI1CjxUGno02MCFoO1oo=; b=l2LxRyNBn7/cKnMk4YZPqWpv2O5DZPmqOqnPOY7P2OjsZgeDilAln+mccpg9jfuDs/ 8PVE2q1v1vc3vsQqYDizqQ7hAg+ZSsgKsiacYvjhoRptDHOVc9PMf1JDyqTAt4tkhBCY bo+kYX7k0BGILNzfUTWax8DnDS2EjiS8sQFvJQv/HirLjy6aRoRsM0Zp2IOPcdvaZW9n V71SeHkQEdS0xsM4JUlk0gqn1NgiPftsSEi+UpHBPh5CE7FBv/XR4bpjDO7c5LAnTtlQ x0j13Phs28CLExpoC9YmdoejbieYSpPcnicQTwDXwT+M04r+tZPZC79Awrh/08yJ92ro Wkkg== X-Gm-Message-State: AOJu0YwG+Z37kQl2sl+Ax1Y1948qQKpWhD8Q5TNhfmiUrqzCPUAy8wc4 Vf6bIrKzF3JHubh2PF6KAi6sTQ== X-Google-Smtp-Source: AGHT+IFCWkhwbCMo2Kf7qMaVHd44Tp9vXFDKbzrS0UCWqndYYop0TULKRfjWVlBGS5I0GO/2TXb3TQ== X-Received: by 2002:a19:915e:0:b0:50b:d764:6edb with SMTP id y30-20020a19915e000000b0050bd7646edbmr666344lfj.139.1701436840946; Fri, 01 Dec 2023 05:20:40 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id u25-20020ac243d9000000b0050be054b4e8sm1081lfl.121.2023.12.01.05.20.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 05:20:40 -0800 (PST) From: Linus Walleij Date: Fri, 01 Dec 2023 14:20:37 +0100 Subject: [PATCH v2 08/10] ASoC: cs42l42: Drop legacy include Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231201-descriptors-sound-cirrus-v2-8-ee9f9d4655eb@linaro.org> References: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> In-Reply-To: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Charles Keepax X-Mailer: b4 0.12.4 This driver includes the legacy GPIO API but does not use any symbols from it. Drop the include. Acked-by: Charles Keepax Signed-off-by: Linus Walleij --- sound/soc/codecs/cs42l42.c | 1 - sound/soc/codecs/cs42l42.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/sound/soc/codecs/cs42l42.c b/sound/soc/codecs/cs42l42.c index 94bcab812629..2d11c5125f73 100644 --- a/sound/soc/codecs/cs42l42.c +++ b/sound/soc/codecs/cs42l42.c @@ -15,7 +15,6 @@ #include #include #include -#include #include #include #include diff --git a/sound/soc/codecs/cs42l42.h b/sound/soc/codecs/cs42l42.h index 7785125b73ab..3d85ebc59489 100644 --- a/sound/soc/codecs/cs42l42.h +++ b/sound/soc/codecs/cs42l42.h @@ -14,7 +14,7 @@ #include #include -#include +#include #include #include #include From patchwork Fri Dec 1 13:20:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13475799 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UAusfU3e" Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC07310F8 for ; Fri, 1 Dec 2023 05:20:43 -0800 (PST) Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-50bc8a9503fso2917202e87.3 for ; Fri, 01 Dec 2023 05:20:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701436842; x=1702041642; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=k2Zjl+ghnoX/3uQpkhvwTgBBfYBwCJ4hUzQ4RLGrPPQ=; b=UAusfU3eTMojzKvxgNYFEl+apPkPQINrhAc/b/g2uEi5TGt0o4QlW0AL+YPmtOfYyO KD39PXAh3HOl7dmc2c3bYK4rG+oVvyPuswleg7paks9ivABcNs9boZgC67N6pufrwoLh +j7WNacmiK1T5Pj27IA9gSUYf+JrFLRLMnhuOBPkbgzSCJqBt4JOy187H/zHpJX323Dr LKsuHGk3zwTTj2svAGuoYFxpPG5H6kUkAaUSVikAFZp06jKN9L42zUHt4LovAtN3RMxn T2Uiv57ykJ6+/oxaPh8+hTkS0mwGkp3QWSfxiS6fU5NMx+jL0bkfPINjW+dHDCcMJpHM QTMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701436842; x=1702041642; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k2Zjl+ghnoX/3uQpkhvwTgBBfYBwCJ4hUzQ4RLGrPPQ=; b=r5jdf4uKhQSmcgKdhUMogOUAa+1TsH4X54ndIos++lcJtQn64++TW8shEDLrZUC2oT 9mJs4cKZI0JbGhnIxBodqJxhTe7JUsqtmkNIQ89/G0Vu3Ut5Y22/Lp7KYAOpeZIZyTUs 4INBZrN/LRxF/F0KuWRI9eIPY61nOk6uxWaTlCk5jOxJGEwc3F/Dr69K1PK1hs2ki5v3 TyrHJFsS97fs4d9m4TlnwhI+ftLyjxv5Le1vx5Q7Kpvy/VdbO0yjWETYqpAv5WjBvTkv mavMT7R/w0teB5YDGy8ba197xK+3vFSB9o5pZ2MpTvl3XVyh9Q95nkQ8eZrO8weOYUP5 nqqg== X-Gm-Message-State: AOJu0YxgHG8NNyXG18xLOh5IJ0UsBmL+4ucd4EgOZQ1DIUEZnhhJ6K41 224whUqhJrDjVwBBlEYgb0VwSA== X-Google-Smtp-Source: AGHT+IEP9YooEM6UIg2kUPyWgnGCZVy2TmLr2VGSLb6afACF8IimZsUAaROd3HdHHX8+hnBq6Qopkw== X-Received: by 2002:a05:6512:118f:b0:50b:c7b0:ecaf with SMTP id g15-20020a056512118f00b0050bc7b0ecafmr892089lfr.49.1701436842052; Fri, 01 Dec 2023 05:20:42 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id u25-20020ac243d9000000b0050be054b4e8sm1081lfl.121.2023.12.01.05.20.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 05:20:41 -0800 (PST) From: Linus Walleij Date: Fri, 01 Dec 2023 14:20:38 +0100 Subject: [PATCH v2 09/10] ASoC: cs43130: Drop legacy includes Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231201-descriptors-sound-cirrus-v2-9-ee9f9d4655eb@linaro.org> References: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> In-Reply-To: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Charles Keepax X-Mailer: b4 0.12.4 This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Acked-by: Charles Keepax Signed-off-by: Linus Walleij --- sound/soc/codecs/cs43130.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/codecs/cs43130.c b/sound/soc/codecs/cs43130.c index 0b40fdfb1825..18933bf04684 100644 --- a/sound/soc/codecs/cs43130.c +++ b/sound/soc/codecs/cs43130.c @@ -11,7 +11,6 @@ #include #include #include -#include #include #include #include @@ -26,7 +25,6 @@ #include #include #include -#include #include #include #include From patchwork Fri Dec 1 13:20:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 13475798 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Fjda7kAI" Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC2B510E2 for ; Fri, 1 Dec 2023 05:20:44 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-50bbfad8758so2888054e87.3 for ; Fri, 01 Dec 2023 05:20:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701436843; x=1702041643; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=+fvbs0Xp4GpuorKL8Tfj6BakgsRgukno1Vk7LhvLiBQ=; b=Fjda7kAIte4KopGlVDv1zFPCcpxE/5458cod4v6furtM4uXLLceKFXt84gaVaf2+dR zxDwPY3Rcfdb5vnOzkxKv5IPIdP9UBAXVsvwQGNfduQp1wXb2suiTO/ERAfsWfQ0FzJ9 /4fqRbrxuvWx6hhrBp+/R8cUKVrlhUYY4+6zBlky5qS/hLqkFtM/41hIewNoeHkDUyC5 2/0fqprL9JxHXWbpRCgdBygjmBKSWs9JO4lWXJiYyuPQ42eweQZS6Blfyexseww0ZCzl VVdz2BHfAbj9gdwuuHPNTYmqTPbkbY7ZOgcJZmrfKkyHd42sd9dcQmN1SvWWH3PYe/ws Lurw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701436843; x=1702041643; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+fvbs0Xp4GpuorKL8Tfj6BakgsRgukno1Vk7LhvLiBQ=; b=te0YCUHoLd2ImW0fxct5u6D8k3yR7d4wpgR+PyavPu08kP0uvnPmFj3TpCeggCKjM9 psEYPWInXPkj5bFVjSefqCEF9sTB4b8n6OTv5IpV7+UmuHAmN1ySgDK3rIf8dQ2e6e0j q23T5WwHO/1MTVhfHDblq9tkQW68BEC+RAABLhjfH8zsKfPDa6of1B0YGebuDVyt3V2R WE7fA9v17gTQzEuu12hs+8942Zd8FailPAW7B+z6mZItLZIM7o+wUxYLR54fo7UxTGEX QvCcYMl7/ZLybqYMKFLc66tBLNzwj8JKne/3Hwt0E+pjYdi1VrhYKqodBsOsrXCYX8F0 1iEg== X-Gm-Message-State: AOJu0Yw/23NIUW91KPsNa9DxoQnWLBf4bU3UB3f53pbdiw3FRCdG5U27 IyQBQJYeiII7aWdagVHVpUmn6Q== X-Google-Smtp-Source: AGHT+IHtjQtt799xLpoVCezjOYP5wu/F6yl+pLI9Fcs3e2ywoijlCxrF0bm3T9nOT+wMNRQXj8UvwQ== X-Received: by 2002:a05:6512:1046:b0:50b:b9f3:9fc6 with SMTP id c6-20020a056512104600b0050bb9f39fc6mr534218lfb.54.1701436843083; Fri, 01 Dec 2023 05:20:43 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id u25-20020ac243d9000000b0050be054b4e8sm1081lfl.121.2023.12.01.05.20.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 05:20:42 -0800 (PST) From: Linus Walleij Date: Fri, 01 Dec 2023 14:20:39 +0100 Subject: [PATCH v2 10/10] ASoC: cs4349: Drop legacy include Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231201-descriptors-sound-cirrus-v2-10-ee9f9d4655eb@linaro.org> References: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> In-Reply-To: <20231201-descriptors-sound-cirrus-v2-0-ee9f9d4655eb@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij , Charles Keepax X-Mailer: b4 0.12.4 This driver includes the legacy GPIO API but does not use any symbols from it. Drop the include. Acked-by: Charles Keepax Signed-off-by: Linus Walleij --- sound/soc/codecs/cs4349.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/cs4349.c b/sound/soc/codecs/cs4349.c index 9083228495d4..ca8f21aa4837 100644 --- a/sound/soc/codecs/cs4349.c +++ b/sound/soc/codecs/cs4349.c @@ -13,7 +13,6 @@ #include #include #include -#include #include #include #include