From patchwork Tue Dec 5 18:22:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tim Harvey X-Patchwork-Id: 13480603 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA538C4167B for ; Tue, 5 Dec 2023 18:23:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Pi6U9FOBqV+4KjnkYYTbQnjXBiwtP5lBjwsTd0Bfb6M=; b=uQt3x/8PaCSspR JL4JPQfN8ikb0NTo/08ckKMrARHxZwFcVmeTFhPtR0Sg4S2I/R0UAjFbajvJnn0/T3wP4Ij5OPMju YPoD6PBonNFZ2YizjDy75TZOhR1+pwtzcmLuZb7DbaMgEQIXNyC1712Pm3AAkIT8IwekAw9HliUGd cNXiLvOZe1QFSeM9eHzd4DzEd7TIOC9J6A9CgbA/hVOKoJTifN++hNqAF5+VGs1Ou3DmRjcQ4e2FL KR3e7/KEk2R0V03T0DS6+mGjU3hrFbrrOZ94WZNz0W/S9eL+cPnCsEgDQmYESTvJZ4PfWW8pSXdki mAZRAoUptVcQJgZ0HxUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rAa4U-0089Jb-0N; Tue, 05 Dec 2023 18:23:02 +0000 Received: from finn.gateworks.com ([108.161.129.64] helo=finn.localdomain) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rAa4Q-0089HR-1H for linux-arm-kernel@lists.infradead.org; Tue, 05 Dec 2023 18:23:00 +0000 Received: from 068-189-091-139.biz.spectrum.com ([68.189.91.139] helo=tharvey.pdc.gateworks.com) by finn.localdomain with esmtp (Exim 4.93) (envelope-from ) id 1rAa4A-00BDe6-Vq; Tue, 05 Dec 2023 18:22:43 +0000 From: Tim Harvey To: Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tim Harvey Subject: [PATCH] arm64: dts: imx8mm-venice-gw7: Fix pci sub-nodes Date: Tue, 5 Dec 2023 10:22:41 -0800 Message-Id: <20231205182241.2550284-1-tharvey@gateworks.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231205_102258_433164_44EA6ED6 X-CRM114-Status: UNSURE ( 8.69 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Several schema warnings were fixed in commit d61c5068729a ("arm64: dts: imx8mm-venice-gw7: Fix pci sub-nodes") however the node names and the ethernet NIC node were not quite correct. Fix the node names as the ethernet device should have a node name of 'ethernet' and remove the device_type, #address-cells, #size-cells, and ranges properties that should only be on busses/bridges. Fixes: d61c5068729a ("arm64: dts: imx8mm-venice-gw7: Fix pci sub-nodes") Signed-off-by: Tim Harvey --- .../dts/freescale/imx8mm-venice-gw72xx.dtsi | 18 +++++++----------- .../dts/freescale/imx8mm-venice-gw73xx.dtsi | 18 +++++++----------- .../dts/freescale/imx8mm-venice-gw7902.dts | 10 +++------- 3 files changed, 17 insertions(+), 29 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi index a337e8f20441..31f16f7cf37c 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw72xx.dtsi @@ -157,33 +157,29 @@ &pcie0 { <&clk IMX8MM_SYS_PLL2_250M>; status = "okay"; - pcie@0,0 { - reg = <0x0000 0 0 0 0>; + pcie@0 { device_type = "pci"; + reg = <0x0000 0 0 0 0>; #address-cells = <3>; #size-cells = <2>; ranges; - pcie@0,0 { - reg = <0x0000 0 0 0 0>; + pcie@0 { device_type = "pci"; + reg = <0x0000 0 0 0 0>; #address-cells = <3>; #size-cells = <2>; ranges; - pcie@3,0 { - reg = <0x1800 0 0 0 0>; + pcie@3 { device_type = "pci"; + reg = <0x1800 0 0 0 0>; #address-cells = <3>; #size-cells = <2>; ranges; - eth1: pcie@0,0 { + eth1: ethernet@0 { reg = <0x0000 0 0 0 0>; - device_type = "pci"; - #address-cells = <3>; - #size-cells = <2>; - ranges; local-mac-address = [00 00 00 00 00 00]; }; diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi index 2247d1c4e2af..6f5a6d91c95e 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw73xx.dtsi @@ -177,33 +177,29 @@ &pcie0 { <&clk IMX8MM_SYS_PLL2_250M>; status = "okay"; - pcie@0,0 { - reg = <0x0000 0 0 0 0>; + pcie@0 { device_type = "pci"; + reg = <0x0000 0 0 0 0>; #address-cells = <3>; #size-cells = <2>; ranges; - pcie@0,0 { - reg = <0x0000 0 0 0 0>; + pcie@0 { device_type = "pci"; + reg = <0x0000 0 0 0 0>; #address-cells = <3>; #size-cells = <2>; ranges; - pcie@4,0 { - reg = <0x2000 0 0 0 0>; + pcie@4 { device_type = "pci"; + reg = <0x2000 0 0 0 0>; #address-cells = <3>; #size-cells = <2>; ranges; - eth1: pcie@0,0 { + eth1: ethernet@0 { reg = <0x0000 0 0 0 0>; - device_type = "pci"; - #address-cells = <3>; - #size-cells = <2>; - ranges; local-mac-address = [00 00 00 00 00 00]; }; diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts index 7ef17c2b0e9d..4bb22fdc5d2e 100644 --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts @@ -633,19 +633,15 @@ &pcie0 { <&clk IMX8MM_SYS_PLL2_250M>; status = "okay"; - pcie@0,0 { - reg = <0x0000 0 0 0 0>; + pcie@0 { device_type = "pci"; + reg = <0x0000 0 0 0 0>; #address-cells = <3>; #size-cells = <2>; ranges; - eth1: pcie@0,0 { + eth1: ethernet@0 { reg = <0x0000 0 0 0 0>; - device_type = "pci"; - #address-cells = <3>; - #size-cells = <2>; - ranges; local-mac-address = [00 00 00 00 00 00]; };