From patchwork Wed Dec 6 12:37:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13481744 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23AE8241F4 for ; Wed, 6 Dec 2023 12:37:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RcwhKY5d" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C0D26C433C9; Wed, 6 Dec 2023 12:37:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701866243; bh=rpE8tUM2R/1vhSlb7IqgfgIczGVZAD4AZUaewUYEnhI=; h=From:To:Cc:Subject:Date:From; b=RcwhKY5dkx9Ra+6ZK+fh2xWlEwOwFl2Uw0B/m5v5ovvziWI3hRlO9ai6VnyxAbMvD czgNL9W6WnTLezAjG9C7ktlYhjZ0/Ys3rIq1JVuCXEMozsspQiGWGP+Zt7lm7UZ6HD 5stWmarfaqI1ioZHFJ/tfzfiQ6xm6Kdj8oT2wP088PshaGGDfeIp/aUSmPqUnomUTl XGIWpnhbLg4QoHCyyFEju904l8+NQHc0fnTom+IW+jXMUC++rq+YnUJ+PtuHQssq5l IlMwmyO993Kzr7qSwhLocupRq+e3c4wDXWG6yb2mMUBzrvJDIm9KoV2yw80+hqR3RS ARURZ/fpvvO5g== From: Arnd Bergmann To: Bjorn Andersson Cc: Arnd Bergmann , Andy Gross , Konrad Dybcio , Stephen Boyd , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] soc: qcom: stats: fix 64-bit division Date: Wed, 6 Dec 2023 13:37:06 +0100 Message-Id: <20231206123717.524009-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Arnd Bergmann Unguarded 64-bit division is not allowed on 32-bit kernels because this is very slow. The result of trying anyway is a link failure: arm-linux-gnueabi-ld: drivers/soc/qcom/qcom_stats.o: in function `qcom_ddr_stats_show': qcom_stats.c:(.text+0x334): undefined reference to `__aeabi_uldivmod' As this function is only used for debugging and not performance critical, rewrite it to use div_u64() instead. ARCH_TIMER_FREQ is a multiple of MSEC_PER_SEC anyway, so there is no loss in precisison. Fixes: e84e61bdb97c ("soc: qcom: stats: Add DDR sleep stats") Signed-off-by: Arnd Bergmann Reviewed-by: Uwe Kleine-König --- drivers/soc/qcom/qcom_stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/qcom/qcom_stats.c b/drivers/soc/qcom/qcom_stats.c index 4763d62a8cb0..5ec8a754b22b 100644 --- a/drivers/soc/qcom/qcom_stats.c +++ b/drivers/soc/qcom/qcom_stats.c @@ -221,7 +221,7 @@ static int qcom_ddr_stats_show(struct seq_file *s, void *unused) for (i = 0; i < ddr.entry_count; i++) { /* Convert the period to ms */ - entry[i].dur = mult_frac(MSEC_PER_SEC, entry[i].dur, ARCH_TIMER_FREQ); + entry[i].dur = div_u64(entry[i].dur, ARCH_TIMER_FREQ / MSEC_PER_SEC); } for (i = 0; i < ddr.entry_count; i++) From patchwork Wed Dec 6 12:37:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13481745 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32AA428E0E for ; Wed, 6 Dec 2023 12:37:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aqStE1Fj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 297A7C433C8; Wed, 6 Dec 2023 12:37:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701866264; bh=ADJ2QTgdrL4qnigrFQHFb2Ou59LIW/2P5BY+VaVUnI4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aqStE1Fje2FGe68gp0llFETF/lI7zCt6KDJO/DA8l7htMiMHkVP5pFCGhPpzkZE6+ OLhZ7Qv8k2kRAzI0NgPlsCDy5yO7DxLtXndtu7ZQpRpSxx4nmct6h91JWitQP+7PbO t+Y3B8voX+GchPJJXMfZRkMuOLq35zi3F/apKfacUBNYaEU5xLrnZy3AA9pP/0jm1E MVB/lxNzKRvD/fYGBtSAgWfx+GvxFUOuSTlBwriNJTGhG7MCE1yxBcLrkiqzgfFc8o dqEAeiRCPlWg3EbghGzd6bH1nd9pIWZKfsAyzvtUcjZATiM6IswXXxoo5rXE56/hTS K8Fg5gea4PwKQ== From: Arnd Bergmann To: Andy Gross , Bjorn Andersson , Konrad Dybcio Cc: Arnd Bergmann , Dmitry Baryshkov , Neil Armstrong , Ulf Hansson , AngeloGioacchino Del Regno , Souradeep Chowdhury , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] soc: qcom_stats: add AOSS_QMP dependency Date: Wed, 6 Dec 2023 13:37:07 +0100 Message-Id: <20231206123717.524009-2-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231206123717.524009-1-arnd@kernel.org> References: <20231206123717.524009-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Arnd Bergmann Using the QMP functions fails in a built-in driver when QMP is a loadable module: aarch64-linux-ld: drivers/soc/qcom/qcom_stats.o: in function `qcom_ddr_stats_show': qcom_stats.c:(.text+0x6f4): undefined reference to `qmp_send' aarch64-linux-ld: drivers/soc/qcom/qcom_stats.o: in function `qcom_stats_probe': qcom_stats.c:(.text+0x117c): undefined reference to `qmp_get' Fixes: e84e61bdb97c ("soc: qcom: stats: Add DDR sleep stats") Signed-off-by: Arnd Bergmann --- drivers/soc/qcom/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig index bf213b514a52..a55f9d6c392a 100644 --- a/drivers/soc/qcom/Kconfig +++ b/drivers/soc/qcom/Kconfig @@ -222,6 +222,7 @@ config QCOM_STATS tristate "Qualcomm Technologies, Inc. (QTI) Sleep stats driver" depends on (ARCH_QCOM && DEBUG_FS) || COMPILE_TEST depends on QCOM_SMEM + depends on QCOM_AOSS_QMP || !QCOM_AOSS_QMP help Qualcomm Technologies, Inc. (QTI) Sleep stats driver to read the shared memory exported by the remote processor related to