From patchwork Mon Dec 11 12:53:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryan Roberts X-Patchwork-Id: 13487190 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD1E0C4167B for ; Mon, 11 Dec 2023 12:53:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1AA496B00D7; Mon, 11 Dec 2023 07:53:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 15A616B00D8; Mon, 11 Dec 2023 07:53:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0492A6B00D9; Mon, 11 Dec 2023 07:53:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EA4366B00D7 for ; Mon, 11 Dec 2023 07:53:38 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B85F91407E6 for ; Mon, 11 Dec 2023 12:53:38 +0000 (UTC) X-FDA: 81554528916.04.B40EDBC Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf14.hostedemail.com (Postfix) with ESMTP id 9C684100015 for ; Mon, 11 Dec 2023 12:53:35 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf14.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702299215; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hP8ffO/kmGn8RcwkdJKgJ+ciubnylUNx/E/cF0c21qg=; b=y2iZGKV+gPNn9PnNKyk3Fw0Be1URa2p7AevSBxIVqTjCy6RA3+9ac362leEa+gmvptCa9l sS/i9jfm1wJLXMUO8qYQTV47rHDPXbq2oX3ZunOwvTcXfAsVuH1dyDJEnQdvH5beNynh4C NULGc8L6eC3/EPWGEhP5yDRYyEnTTbc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf14.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702299215; a=rsa-sha256; cv=none; b=Biiga/ttT4phcGeajmNxVpgAExrsxm2JRePlend1/gUv2jstiCSKWOv00H578QsOHY9anY qdJcu5GugCcDpxsiXQVS9ShPMkRGzBdHF8QUe4jSdE9ntyYb/7D+UJxYt5H4+RNaQrQDh8 DO4gzom5RUTsZ1I+5zpL/aRD+i3yj3M= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0010AFEC; Mon, 11 Dec 2023 04:54:21 -0800 (PST) Received: from e125769.cambridge.arm.com (e125769.cambridge.arm.com [10.1.196.26]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 934533F762; Mon, 11 Dec 2023 04:53:33 -0800 (PST) From: Ryan Roberts To: Andrew Morton Cc: Ryan Roberts , kernel test robot , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Barry Song Subject: [PATCH] mm: thp: Fix build warning when CONFIG_SYSFS is disabled Date: Mon, 11 Dec 2023 12:53:20 +0000 Message-Id: <20231211125320.3997543-1-ryan.roberts@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <202312111916.YbsHxKPq-lkp@intel.com> References: <202312111916.YbsHxKPq-lkp@intel.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: 9C684100015 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: utj88dfk484xdq5cqup6u78cftercuc9 X-HE-Tag: 1702299215-766654 X-HE-Meta: U2FsdGVkX19n5V4JW/RqfvXCK7EgaA1kvE8DepUY8p8aXFlB8UyQLfRx7nhP+ojs2X/uT4VWl5ueKzcHYv36f5qB63b17f3mR1Tt8bZCd51AYr7MjBFdxsemK12SsDrTUnGdsw/dLAwLKLdkFGTu1amaQvN6MCT7/D+hChTUWJQ4LmBlroZq4QR7HOmZrsWyTRzsZRZolTWPff4xr+2bNijdFXOuBGVs7CrbfCgWrcoY5IK6/VqLg0oX2VacGaMyiJNtSFjdrEcbqTDp8dU89Ooa4JebWiiUKhwISxxBOQSc8eEsF/uyvtI6lrMOZizfpwQLf8ENjYJanOFo3mTKYJLy8qhzvTS4vT69RYGpHSSKWfQPYP3hGLghdj7B6QzVNr/ybh5czwoxjJD452IVOBZqJILCbFCawuW7NBw18inr/X4p71g3cOOS+w0lq7cxjk726dpqIM3zGqGppgCvOrn471MTTpdMKdKD3jHBdSkyqNRVjBQD+5uBng4XN4q4bz+UiNYts4rVl7NXJZQK4XC2Ev3ZbVTBgMA4OREkdqzuPN+5YbhyOzRD6+EoG7Lurq7yDjs1A9MR/0pEvk5r8XM24v5RtHHyvU3nxquZ4gX+Jy5QgD0wnqko5FGGXBTEt/TyHE6cNiYbmvSTexGhcOSDuriC4xKdWJSq52x0OR+D4UuszQMiGsinCapg/EoaMiygv8TYUovNiovcqH/zufdZb6C2RD0toLoTUwxqHdA5azckgMpQZ+BBhNXa70k3zYyBwsUYp7SwMgUU9DHsgx5tutBuckIk+Ng4lZ3K0UppVmysQ63jqYSBEbpC+WoWDOTyNirFXhbHIxRaV/DYHJoThefN+sQBFaeoy9nLqlb0DYQ/h4Xeg5IjMHMaEvdEWmsgj3Sy1ehQ6s3QBS+dDm3cy5WBHT+x4bXRk0/v/nEscZ8de5RPAc50+FfJ6ZrPCY7q9+KLkBeG/XFje8P JbUcYW98 JhMVgbvOd+IOqaMmAuwx59E+mtPOrUxNvmuvLRKlgKJkbYlhRKL3DqYF68ziMlTFatUI1XCxM6e2tvF9NUpviLydFFJnudxu795t5n6j1pnVBGfK15QJiMiJwELgoK+OaNKcYG9xr7WgUF2/sppqmEbb0IAU611sRvxzvCgmbYh14J+ICwkgPB6tF0KOqhSAEK0f8pkhmRrkEP6lxJuE9fpjbu63Y0sFMCh3TdJHXetT25MwtDXRWtBJJhM8+w6oaZaP2ySsQMxgoByd81ywuGGvpy0qwRNKhwQnF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: huge_anon_orders_lock is used only to serialize sysfs writers. So move its definition so that it is within the CONFIG_SYSFS ifdefery to suppress "defined but not used" warning when sysfs is disabled. Fixes: fe2c9313a8c0 ("mm: thp: Introduce multi-size THP sysfs interface") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202312111916.YbsHxKPq-lkp@intel.com/ Signed-off-by: Ryan Roberts --- Hi Andrew, David mentioned that your preference is to squash minor fixes into patches in mm-unstable? Could you please squash this into commit fe2c9313a8c0 ("mm: thp: Introduce multi-size THP sysfs interface")? Thanks, Ryan mm/huge_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 diff --git a/mm/huge_memory.c b/mm/huge_memory.c index cfb1d04a71b1..ddf73422d3b5 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -77,7 +77,6 @@ unsigned long huge_zero_pfn __read_mostly = ~0UL; unsigned long huge_anon_orders_always __read_mostly; unsigned long huge_anon_orders_madvise __read_mostly; unsigned long huge_anon_orders_inherit __read_mostly; -static DEFINE_SPINLOCK(huge_anon_orders_lock); unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma, unsigned long vm_flags, bool smaps, @@ -442,6 +441,7 @@ static const struct attribute_group hugepage_attr_group = { static void hugepage_exit_sysfs(struct kobject *hugepage_kobj); static void thpsize_release(struct kobject *kobj); +static DEFINE_SPINLOCK(huge_anon_orders_lock); static LIST_HEAD(thpsize_list); struct thpsize {