From patchwork Mon Dec 11 15:07:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miquel Raynal X-Patchwork-Id: 13487382 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E5A7C4167B for ; Mon, 11 Dec 2023 15:07:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=INqQwTO7WB8rcpY7co8kAF5W7dmtA2amZhhQW5te91E=; b=BCuX670EfBdaEQ tpYAK5cDAbW6Gc0SH9eXlsRn3TU3Z84nYohApYmkW4U6eRGImku0//bLKk+hDYhoLCDWJ94gjxkXV mNwV7fJVJuHobZVpg10RtlS9u8AM9mGio/ZMRcgVTCHkZiO2UuE97PdxphVGwAD5U0dmdrbvwlANH ibTeE9AIgpTiLMOyLWsSP27a3SBRfh5j2Tumv3GxziwH59cVrNhRK8fPJQfEi7d5mavFBxDwt6JbG way8Qed6FE6Z1lwF4EkrNSD93sb99INyaN+aZguUGz4AjwnJoOmsXZGirT8DJPMDa1ZUQmuGMq1fc DupS3l7wGsDciGeRqwvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rChsJ-005INc-17; Mon, 11 Dec 2023 15:07:15 +0000 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rChsC-005IIm-2t; Mon, 11 Dec 2023 15:07:12 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id F33EDFF80A; Mon, 11 Dec 2023 15:07:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1702307226; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=+IG8edyMhn3FE8xgdJtbiJSuCXcG/WjMqFQomY/cHok=; b=lh5zGP5FO5/ZpxLd8TIhtY60UAozhTv0xXej8AGly1KO7aZvzIuxTlsm8Nh7xaKvACv0i9 475YA1n01wVeS4HTiJWiB6CuBzZiNiYVwfsvsOSiJfj35dcTDPQTe1PLrFM6QyTmqxDCCf Mby6pALwG6HC+G2wfcx2hyKp813pwRVgU+Tq4uIo/cdwQv20kiYJQWkoBsfWsWzGTwNKr4 kAyOJD83tALofG7IlyEUia6XdCFI3+jxGRrt/xADzX5YVT3qxrcN7YhogEjtW27T2VHg1u 3a2vKZT0AjMzVSza2BvEmW+iIho+NIo4fvxlK1TeK8Ef8kdNQnkZI0Rsh7TXzA== From: Miquel Raynal To: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Pratyush Yadav , Michael Walle , Cc: Heiko Stuebner , , Thomas Petazzoni , , Yifeng Zhao , Miquel Raynal , kernel test robot Subject: [PATCH 1/2] mtd: rawnand: rockchip: Rename a structure Date: Mon, 11 Dec 2023 16:07:03 +0100 Message-Id: <20231211150704.109138-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231211_070709_087154_911ED47E X-CRM114-Status: GOOD ( 10.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Robots are unhappy with the ecc_cnt_status structure because the kernel doc says it should be called rk_ecc_cnt_status. In general, it is considered a better practice to prefix all symbols in a file with the same prexif, and thus it seems more relevant to rename the structure rather than changing the kernel doc header. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202312102130.geZ4dqyN-lkp@intel.com/ Fixes: 058e0e847d54 ("mtd: rawnand: rockchip: NFC driver for RK3308, RK2928 and others") Signed-off-by: Miquel Raynal --- drivers/mtd/nand/raw/rockchip-nand-controller.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/nand/raw/rockchip-nand-controller.c b/drivers/mtd/nand/raw/rockchip-nand-controller.c index 596cf9a78274..ab1a9e8687e0 100644 --- a/drivers/mtd/nand/raw/rockchip-nand-controller.c +++ b/drivers/mtd/nand/raw/rockchip-nand-controller.c @@ -98,7 +98,7 @@ enum nfc_type { * @high: ECC count high bit index at register. * @high_mask: mask bit */ -struct ecc_cnt_status { +struct rk_ecc_cnt_status { u8 err_flag_bit; u8 low; u8 low_mask; @@ -144,8 +144,8 @@ struct nfc_cfg { u32 int_st_off; u32 oob0_off; u32 oob1_off; - struct ecc_cnt_status ecc0; - struct ecc_cnt_status ecc1; + struct rk_ecc_cnt_status ecc0; + struct rk_ecc_cnt_status ecc1; }; struct rk_nfc_nand_chip { From patchwork Mon Dec 11 15:07:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miquel Raynal X-Patchwork-Id: 13487383 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6234DC10F05 for ; Mon, 11 Dec 2023 15:07:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Uw694f6MBRZOXTxov3QZ0Ax5xE9B3zgDIGz1Uj7uEgE=; b=OWOyb0zC/f+co9 8f13QlvprSZTfW4nmZ7zZ0fbqEU8+O0INu/tt5C4omss+ieCgWXOiQegbcw6NaOGa+qjJcqNDQi4k lDTM8K086Ap3lzYqhDUTCIWwyqw0fzCCsjLkWzXcKMVpU4/GOQhbWleymq3YY7eNjb0xTMOpRFmTX u+LdyQydQ6lz5LA4cK8Y5RZrNBDOydmAJML5HEGABTDTnsa/VqTV1M5LXm902pv7zB1cmOk191X4T ifsSA+6GFsH9P7OMada/cfM1Q9EVq/W2DHM625zvd/GUdbZjMVSfKjNlqMKxgnWm7z4etWgbUoFpX CUQhMFwikUHn77aVTN+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rChsO-005IPj-1h; Mon, 11 Dec 2023 15:07:20 +0000 Received: from relay9-d.mail.gandi.net ([217.70.183.199]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rChsE-005IJf-23; Mon, 11 Dec 2023 15:07:13 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id A6A27FF80D; Mon, 11 Dec 2023 15:07:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1702307227; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mCpgckyHYRCqWcLrdBFdkY7ytfN/j08qDrPdaUCnFjM=; b=NXtE0+6vHknV4JejSwmwtFfYY8e8PAl8atvUVbCIFhiAAGkuh57OFlS8a2lXa/Nt9mTWuC 5nfYSVdQNaTJQ1xhCYVAllRXSMYL5Ov0pPywSpAe3ViN393GkPsJOpPCP03kmVoWLoKXZm KYyvDiS7IugU7ReUwOopHdiXUTUMy6hnf6SWOh/dFm5OXt635WXkVizTXMkEsOsJP5Ww95 vYO3sUf6d3UfOcNVGPPs/w/GWuGWao65AT7cvLgTlDJUvHYUF7b0PYZhJKKWs4eaJh2xDH HtBvdp/5a5FAube0d/wRbUeYm5C2dSdKlSkAj3glmHf4F46/ya/KAg0Z5rYYEQ== From: Miquel Raynal To: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , Pratyush Yadav , Michael Walle , Cc: Heiko Stuebner , , Thomas Petazzoni , , Yifeng Zhao , Miquel Raynal Subject: [PATCH 2/2] mtd: rawnand: rockchip: Add missing title to a kernel doc comment Date: Mon, 11 Dec 2023 16:07:04 +0100 Message-Id: <20231211150704.109138-2-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231211150704.109138-1-miquel.raynal@bootlin.com> References: <20231211150704.109138-1-miquel.raynal@bootlin.com> MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231211_070710_893278_1B48E744 X-CRM114-Status: UNSURE ( 8.41 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org All fields of the nfc_cfg structure are documented but the name, which leads to a W=1 warning. Add a title. Fixes: 058e0e847d54 ("mtd: rawnand: rockchip: NFC driver for RK3308, RK2928 and others") Signed-off-by: Miquel Raynal --- drivers/mtd/nand/raw/rockchip-nand-controller.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/nand/raw/rockchip-nand-controller.c b/drivers/mtd/nand/raw/rockchip-nand-controller.c index ab1a9e8687e0..7baaef69d70a 100644 --- a/drivers/mtd/nand/raw/rockchip-nand-controller.c +++ b/drivers/mtd/nand/raw/rockchip-nand-controller.c @@ -108,6 +108,7 @@ struct rk_ecc_cnt_status { }; /** + * struct nfc_cfg: Rockchip NAND controller configuration * @type: NFC version * @ecc_strengths: ECC strengths * @ecc_cfgs: ECC config values